Re: Delegate Vs Reviewer
On Wed, Nov 26, 2014 at 01:42:21PM +0800, Jeremy Kerr wrote: On Mon, Nov 24, 2014 at 05:35:11PM +, Damien Lespiau wrote: I'd like to be able to assign reviewers to patches. That seems very close to what a delegate is today. Would anyone have objections if I just use Delegate as Reviewer? I'm honestly not sure what Delegate is intended for. It seems like its purpose is open to your interpretation. One example: on the powerpc list, we have an overall maintainer, and several sub-maintainers, who are generally responsible for their own subsystem or set of hardware. If a patch for one of the sub-maintiners' areas appears, it can be delegated to the appropriate person to review, test, and/or merge. The change is then included in the next merge-request from the sub-maintainer to the main maintainer. In this case, patch review is only one of the tasks of the delegate. Thanks for the explanation. I have to say I'm not the biggest fan of a field with multiple and project-dependent meanings. I guess I'll introduce a separate reviewer field then. -- Damien ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Delegate Vs Reviewer
Em Wed, 26 Nov 2014 13:42:21 +0800 Jeremy Kerr j...@ozlabs.org escreveu: Hi all, On Mon, Nov 24, 2014 at 05:35:11PM +, Damien Lespiau wrote: I'd like to be able to assign reviewers to patches. That seems very close to what a delegate is today. Would anyone have objections if I just use Delegate as Reviewer? I'm honestly not sure what Delegate is intended for. It seems like its purpose is open to your interpretation. One example: on the powerpc list, we have an overall maintainer, and several sub-maintainers, who are generally responsible for their own subsystem or set of hardware. If a patch for one of the sub-maintiners' areas appears, it can be delegated to the appropriate person to review, test, and/or merge. The change is then included in the next merge-request from the sub-maintainer to the main maintainer. We do the same at the media subsystem. Laurent even wrote some patches for patchwork to do patch auto-delegation based on the paths inside the diffstat, using regex expressions. Not sure if he sent those patches upstream. In this case, patch review is only one of the tasks of the delegate. Cheers, Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Delegate Vs Reviewer
On Mon, Nov 24, 2014 at 05:35:11PM +, Damien Lespiau wrote: I'd like to be able to assign reviewers to patches. That seems very close to what a delegate is today. Would anyone have objections if I just use Delegate as Reviewer? I'm honestly not sure what Delegate is intended for. It seems like its purpose is open to your interpretation. One caveat is that I think a Delegee must be a Maintainer for your project, and in the general case, a Reviewer is not necessarily a Maintainer. Brian ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
Re: Delegate Vs Reviewer
Hi all, On Mon, Nov 24, 2014 at 05:35:11PM +, Damien Lespiau wrote: I'd like to be able to assign reviewers to patches. That seems very close to what a delegate is today. Would anyone have objections if I just use Delegate as Reviewer? I'm honestly not sure what Delegate is intended for. It seems like its purpose is open to your interpretation. One example: on the powerpc list, we have an overall maintainer, and several sub-maintainers, who are generally responsible for their own subsystem or set of hardware. If a patch for one of the sub-maintiners' areas appears, it can be delegated to the appropriate person to review, test, and/or merge. The change is then included in the next merge-request from the sub-maintainer to the main maintainer. In this case, patch review is only one of the tasks of the delegate. Cheers, Jeremy ___ Patchwork mailing list Patchwork@lists.ozlabs.org https://lists.ozlabs.org/listinfo/patchwork
