RE: MARC::Lint update
There were some unitialized variable warnings, nothing serious. 'make test' will run perl under the warnings pragma, so 'use warnings' in your module will help you catch this sort of thing early. I generally 'use warnings' or use the -w flag in the modules and scripts I've been writing. I didn't notice it was missing. I need to add strict and warnings to CodeData, as well. In modules/package files, is it practice to leave out the shebang (#!perl) line, since the file is not generally executed directly? If so, is that the reason for 'use warnings' vs. -w? I don't know what editor you use, but .it's been the norm for marc/perl module folks to not embed tabs in source code for indentation. vim and emacs both support mapping a tab to spaces when you hit the tab key. I use BBEdit Lite, which has a good global search/replace function. In the future, I'll try to remember to convert the indentation tabs to 4 spaces per tab. Are non-indentation tabs ok? In MARC::Lint::CodeData, I used split on \t to split the codes into a hash. Since some codes have or need spaces, splitting on \s would probably not work as well. Thank you for your assistance, Bryan Baldus [EMAIL PROTECTED] [EMAIL PROTECTED] http://home.inwave.com/eija
Re: MARC::Lint update
On Mon, Jan 24, 2005 at 08:37:41AM -0600, Bryan Baldus wrote: I generally 'use warnings' or use the -w flag in the modules and scripts I've been writing. I didn't notice it was missing. I need to add strict and warnings to CodeData, as well. In modules/package files, is it practice to leave out the shebang (#!perl) line, since the file is not generally executed directly? If so, is that the reason for 'use warnings' vs. -w? Yeah. I use BBEdit Lite, which has a good global search/replace function. In the future, I'll try to remember to convert the indentation tabs to 4 spaces per tab. Are non-indentation tabs ok? In MARC::Lint::CodeData, I used split on \t to split the codes into a hash. Since some codes have or need spaces, splitting on \s would probably not work as well. Non-indentation tabs should be fine. There shouldn't be any need to remember to search/replace, try Edit - Text Options - and check Auto-Expand Tabs ... and you should be good to go. I guess for converting the existing tabs search/replace will come in handy though :-) //Ed
MARC::Lint update
The SourceForge CVS version of MARC::Lint has been updated with new checks (041, 043), revisions to check_245, a new internal _check_article method, the addition of MARC::Lint::CodeData (for 041, 043, etc.), and 2 new tests. Watch for further added check_xxx methods in the near future, as I move them out of MARC::Lintadditions into MARC::Lint. Thank you, Bryan Baldus [EMAIL PROTECTED] [EMAIL PROTECTED] http://home.inwave.com/eija
Re: MARC::Lint update
On Sun, Jan 23, 2005 at 08:48:50AM -0600, Bryan Baldus wrote: The SourceForge CVS version of MARC::Lint has been updated with new checks (041, 043), revisions to check_245, a new internal _check_article method, the addition of MARC::Lint::CodeData (for 041, 043, etc.), and 2 new tests. Watch for further added check_xxx methods in the near future, as I move them out of MARC::Lintadditions into MARC::Lint. Thanks for the update Bryan. It's great to see the new tests code. I added the new files to the MANIFEST so make test would succeed, and also made some adjustments in MARC::Lint to avoid warnings under 'make test'. There were some unitialized variable warnings, nothing serious. 'make test' will run perl under the warnings pragma, so 'use warnings' in your module will help you catch this sort of thing early. One more kind of pedantic thing: I don't know what editor you use, but it's been the norm for marc/perl module folks to not embed tabs in source code for indentation. vim and emacs both support mapping a tab to spaces when you hit the tab key. The marc/perl code uses four spaces for indentation: if you need help getting your editor to do this indentation let me know. -- Ed Summers aim: inkdroid web: http://www.inkdroid.org He who binds to himself a joy Does the winged life destroy; But he who kisses the joy as it flies Lives in eternity's sun rise. [William Blake]
