[BUGS] BUG #8271: Configure warning: sys/ucred.h: present but cannot be compiled

2013-06-30 Thread emre
The following bug has been logged on the website:

Bug reference:  8271
Logged by:  Emre Hasegeli
Email address:  e...@hasegeli.com
PostgreSQL version: 9.1.9
Operating system:   OpenBSD 5.3 amd64
Description:

Configure warning on OpenBSD 5.3:


checking sys/ucred.h usability... no
checking sys/ucred.h presence... yes
configure: WARNING: sys/ucred.h: present but cannot be compiled
configure: WARNING: sys/ucred.h: check for missing prerequisite
headers?
configure: WARNING: sys/ucred.h: see the Autoconf documentation
configure: WARNING: sys/ucred.h: section Present But Cannot Be
Compiled
configure: WARNING: sys/ucred.h: proceeding with the preprocessor's result
configure: WARNING: sys/ucred.h: in the future, the compiler will take
precedence
configure: WARNING: ##  ##
configure: WARNING: ## Report this to pgsql-bugs@postgresql.org ##
configure: WARNING: ##  ##
checking for sys/ucred.h... yes


It appears on 9.1.9, 9.2.4, 9.3beta2; does not appear on 9.0.13.




-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] BUG #8271: Configure warning: sys/ucred.h: present but cannot be compiled

2013-06-30 Thread Andres Freund
On 2013-06-30 10:43:49 +, e...@hasegeli.com wrote:
 checking sys/ucred.h usability... no
 checking sys/ucred.h presence... yes
 configure: WARNING: sys/ucred.h: present but cannot be compiled
 configure: WARNING: sys/ucred.h: check for missing prerequisite
 headers?
 configure: WARNING: sys/ucred.h: see the Autoconf documentation
 configure: WARNING: sys/ucred.h: section Present But Cannot Be
 Compiled
 configure: WARNING: sys/ucred.h: proceeding with the preprocessor's result
 configure: WARNING: sys/ucred.h: in the future, the compiler will take
 precedence
 configure: WARNING: ##  ##
 configure: WARNING: ## Report this to pgsql-bugs@postgresql.org ##
 configure: WARNING: ##  ##
 checking for sys/ucred.h... yes

Could you attach config.log?

Greetings,

Andres Freund

-- 
 Andres Freund http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training  Services


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] BUG #8271: Configure warning: sys/ucred.h: present but cannot be compiled

2013-06-30 Thread Andres Freund
On 2013-06-30 15:11:24 +0300, Emre Hasegeli wrote:
 2013/6/30 Andres Freund and...@2ndquadrant.com:
  On 2013-06-30 10:43:49 +, e...@hasegeli.com wrote:
  Could you attach config.log?
 
 Attached.

This seems to be caused by be4585b1c27ac5dbdd0d61740d18f7ad9a00e268. The
fault imo lies with openbsd which doesn't include the prerequisite
sys/param.h header which defines NGROUPS:
http://fxr.watson.org/fxr/source/sys/ucred.h?v=OPENBSD
The other BSD flavors seems to get that right.

Before that commit the checks for cmsgcred which includes sys/ucred.h
happened to include params.h... Patch attached, missing the configure
update since I don't have a compatible autoconf on my laptop, to produce
a minimal diff.

It's a bit sad that we didn't notice this despite having spoonbill
reporting it, presumably for a good while:
http://pgbuildfarm.org/cgi-bin/show_stage_log.pl?nm=spoonbilldt=2013-06-29%2011%3A00%3A04stg=configure

The reason we presumably missed it is that getpeereid is properly
present.

Andrew: Could we perhaps check for the Report this to bit in the
buildfarm?

Greetings,

Andres Freund

-- 
 Andres Freund http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training  Services
diff --git a/configure.in b/configure.in
index 58ece5b..fa37bda 100644
--- a/configure.in
+++ b/configure.in
@@ -982,7 +982,7 @@ AC_SUBST(OSSP_UUID_LIBS)
 ##
 
 dnl sys/socket.h is required by AC_FUNC_ACCEPT_ARGTYPES
-AC_CHECK_HEADERS([crypt.h dld.h fp_class.h getopt.h ieeefp.h ifaddrs.h langinfo.h poll.h pwd.h sys/ioctl.h sys/ipc.h sys/poll.h sys/pstat.h sys/resource.h sys/select.h sys/sem.h sys/shm.h sys/socket.h sys/sockio.h sys/tas.h sys/time.h sys/ucred.h sys/un.h termios.h ucred.h utime.h wchar.h wctype.h])
+AC_CHECK_HEADERS([crypt.h dld.h fp_class.h getopt.h ieeefp.h ifaddrs.h langinfo.h poll.h pwd.h sys/ioctl.h sys/ipc.h sys/param.h sys/poll.h sys/pstat.h sys/resource.h sys/select.h sys/sem.h sys/shm.h sys/socket.h sys/sockio.h sys/tas.h sys/time.h sys/un.h termios.h ucred.h utime.h wchar.h wctype.h])
 
 # On BSD, cpp test for net/if.h will fail unless sys/socket.h
 # is included first.
@@ -993,6 +993,14 @@ AC_CHECK_HEADERS(net/if.h, [], [],
 #endif
 ])
 
+# On OpenBSD including sys/ucred.h without sys/params.h will fail
+AC_CHECK_HEADERS(sys/ucred.h, [], [],
+[AC_INCLUDES_DEFAULT
+#ifdef HAVE_SYS_PARAM_H
+#include sys/param.h
+#endif
+])
+
 # At least on IRIX, cpp test for netinet/tcp.h will fail unless
 # netinet/in.h is included first.
 AC_CHECK_HEADERS(netinet/in.h)
@@ -1133,6 +1141,9 @@ PGAC_TYPE_LOCALE_T
 
 AC_CHECK_TYPES([struct cmsgcred], [], [],
 [#include sys/socket.h
+#ifdef HAVE_SYS_PARAM_H
+#include sys/param.h
+#endif
 #ifdef HAVE_SYS_UCRED_H
 #include sys/ucred.h
 #endif])

-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] BUG #8271: Configure warning: sys/ucred.h: present but cannot be compiled

2013-06-30 Thread Andres Freund
On 2013-06-30 15:17:20 +0200, Andres Freund wrote:
 Andrew: Could we perhaps check for the Report this to bit in the
 buildfarm?

FWIW: I checked that there are no other reports on HEAD atm.

Greetings,

Andres Freund

-- 
 Andres Freund http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training  Services


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] BUG #8271: Configure warning: sys/ucred.h: present but cannot be compiled

2013-06-30 Thread Andrew Dunstan


On 06/30/2013 09:20 AM, Andres Freund wrote:

On 2013-06-30 15:17:20 +0200, Andres Freund wrote:

Andrew: Could we perhaps check for the Report this to bit in the
buildfarm?

FWIW: I checked that there are no other reports on HEAD atm.




I'm not sure what you're asking here. Where exactly do you thing 
buildfarm failures should be reported? There are four mailing lists that 
get buildfarm status reports:


 * http://lists.pgfoundry.org/mailman/listinfo/pgbuildfarm-status-all
   gets a summary of every single reported build
 * http://lists.pgfoundry.org/mailman/listinfo/pgbuildfarm-status-fail gets
   a summary of every build that fails
 * http://lists.pgfoundry.org/mailman/listinfo/pgbuildfarm-status-chngs
   gets a summary of every build that results in a status change
 * http://lists.pgfoundry.org/mailman/listinfo/pgbuildfarm-status-green
   gets a summary of every build that results in a status change to or
   from green (a.k.a. OK)

These are available in digest form.

What we could possibly add is a feature to email a committer about a 
commit included in the changeset of a failing build. The main trick 
would be to avoid flooding the committers, so that a commit would only 
be notified once. Magnus has suggested something like this previously, 
but I haven't looked at it much - I can again. It might not be too hard.


cheers

andrew





--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] BUG #8271: Configure warning: sys/ucred.h: present but cannot be compiled

2013-06-30 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes:
 On 2013-06-30 15:17:20 +0200, Andres Freund wrote:
 Andrew: Could we perhaps check for the Report this to bit in the
 buildfarm?

 I'm not sure what you're asking here.

I think he's wishing that if configure prints something like

configure: WARNING: sys/ucred.h: present but cannot be compiled
configure: WARNING: sys/ucred.h: check for missing prerequisite headers?
configure: WARNING: sys/ucred.h: see the Autoconf documentation
configure: WARNING: sys/ucred.h: section Present But Cannot Be Compiled
configure: WARNING: sys/ucred.h: proceeding with the preprocessor's result
configure: WARNING: sys/ucred.h: in the future, the compiler will take 
precedence
configure: WARNING: ##  ##
configure: WARNING: ## Report this to pgsql-bugs@postgresql.org ##
configure: WARNING: ##  ##

that that ought to be treated as a failure not a success.  I'm not
entirely sure that I agree, but it's an arguable position.

regards, tom lane


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] BUG #8271: Configure warning: sys/ucred.h: present but cannot be compiled

2013-06-30 Thread Andrew Dunstan


On 06/30/2013 09:49 AM, Tom Lane wrote:

Andrew Dunstan and...@dunslane.net writes:

On 2013-06-30 15:17:20 +0200, Andres Freund wrote:

Andrew: Could we perhaps check for the Report this to bit in the
buildfarm?

I'm not sure what you're asking here.

I think he's wishing that if configure prints something like

configure: WARNING: sys/ucred.h: present but cannot be compiled
configure: WARNING: sys/ucred.h: check for missing prerequisite headers?
configure: WARNING: sys/ucred.h: see the Autoconf documentation
configure: WARNING: sys/ucred.h: section Present But Cannot Be Compiled
configure: WARNING: sys/ucred.h: proceeding with the preprocessor's result
configure: WARNING: sys/ucred.h: in the future, the compiler will take 
precedence
configure: WARNING: ##  ##
configure: WARNING: ## Report this to pgsql-bugs@postgresql.org ##
configure: WARNING: ##  ##

that that ought to be treated as a failure not a success.  I'm not
entirely sure that I agree, but it's an arguable position.



Oh. Well, if that's a failure then it's up to configure to treat it as 
one. The buildfarm doesn't second-guess the exit status of the various 
steps, and it doesn't report warnings - if it did we'd be flooded.


cheers

andrew


--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] BUG #8271: Configure warning: sys/ucred.h: present but cannot be compiled

2013-06-30 Thread Andres Freund
On 2013-06-30 10:17:50 -0400, Andrew Dunstan wrote:
 
 On 06/30/2013 09:49 AM, Tom Lane wrote:
 Andrew Dunstan and...@dunslane.net writes:
 On 2013-06-30 15:17:20 +0200, Andres Freund wrote:
 Andrew: Could we perhaps check for the Report this to bit in the
 buildfarm?
 I'm not sure what you're asking here.
 I think he's wishing that if configure prints something like
 
 configure: WARNING: sys/ucred.h: present but cannot be compiled
 configure: WARNING: sys/ucred.h: check for missing prerequisite headers?
 configure: WARNING: sys/ucred.h: see the Autoconf documentation
 configure: WARNING: sys/ucred.h: section Present But Cannot Be Compiled
 configure: WARNING: sys/ucred.h: proceeding with the preprocessor's result
 configure: WARNING: sys/ucred.h: in the future, the compiler will take 
 precedence
 configure: WARNING: ##  ##
 configure: WARNING: ## Report this to pgsql-bugs@postgresql.org ##
 configure: WARNING: ##  ##
 
 that that ought to be treated as a failure not a success.  I'm not
 entirely sure that I agree, but it's an arguable position.

Exactly. That we presumably had this warning showing up for more than 2
years seems to indicate we should think about doing something different.

 Oh. Well, if that's a failure then it's up to configure to treat it as one.
 The buildfarm doesn't second-guess the exit status of the various steps, and
 it doesn't report warnings - if it did we'd be flooded.

I guess we don't want to do that because it would probably hurt people
building in unusual environments where some variants of this very well
can show up without stopping pg from being built. Many people on such
problems will have no difficulties fixing a minor compilation error, but
fixing configure.in + installing the correct autoconf version is a
higher barrier.
We could add a --strict-mode or so to configure, but afair the handling
of that warning is burried in autoconf itself making this harder. So
I thought adding some grep like thing to the buildfarm might be the
easiest solution.

Greetings,

Andres Freund

-- 
 Andres Freund http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training  Services


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] BUG #8271: Configure warning: sys/ucred.h: present but cannot be compiled

2013-06-30 Thread Andrew Dunstan


On 06/30/2013 11:07 AM, Andres Freund wrote:

On 2013-06-30 10:17:50 -0400, Andrew Dunstan wrote:

On 06/30/2013 09:49 AM, Tom Lane wrote:

Andrew Dunstan and...@dunslane.net writes:

On 2013-06-30 15:17:20 +0200, Andres Freund wrote:

Andrew: Could we perhaps check for the Report this to bit in the
buildfarm?

I'm not sure what you're asking here.

I think he's wishing that if configure prints something like

configure: WARNING: sys/ucred.h: present but cannot be compiled
configure: WARNING: sys/ucred.h: check for missing prerequisite headers?
configure: WARNING: sys/ucred.h: see the Autoconf documentation
configure: WARNING: sys/ucred.h: section Present But Cannot Be Compiled
configure: WARNING: sys/ucred.h: proceeding with the preprocessor's result
configure: WARNING: sys/ucred.h: in the future, the compiler will take 
precedence
configure: WARNING: ##  ##
configure: WARNING: ## Report this to pgsql-bugs@postgresql.org ##
configure: WARNING: ##  ##

that that ought to be treated as a failure not a success.  I'm not
entirely sure that I agree, but it's an arguable position.

Exactly. That we presumably had this warning showing up for more than 2
years seems to indicate we should think about doing something different.


Oh. Well, if that's a failure then it's up to configure to treat it as one.
The buildfarm doesn't second-guess the exit status of the various steps, and
it doesn't report warnings - if it did we'd be flooded.

I guess we don't want to do that because it would probably hurt people
building in unusual environments where some variants of this very well
can show up without stopping pg from being built. Many people on such
problems will have no difficulties fixing a minor compilation error, but
fixing configure.in + installing the correct autoconf version is a
higher barrier.
We could add a --strict-mode or so to configure, but afair the handling
of that warning is burried in autoconf itself making this harder. So
I thought adding some grep like thing to the buildfarm might be the
easiest solution.




But that *would* be second-guessing configure's exit status.

I don't understand the reference to autoconf - nobody building Postgres, 
including buildfarm members, needs autoconf installed at all. Only 
developers and committers need to, and then only when configure.in is 
changed.


cheers

andrew


--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] BUG #8271: Configure warning: sys/ucred.h: present but cannot be compiled

2013-06-30 Thread Andres Freund
On 2013-06-30 11:19:50 -0400, Andrew Dunstan wrote:
 Oh. Well, if that's a failure then it's up to configure to treat it as one.
 The buildfarm doesn't second-guess the exit status of the various steps, and
 it doesn't report warnings - if it did we'd be flooded.
 I guess we don't want to do that because it would probably hurt people
 building in unusual environments where some variants of this very well
 can show up without stopping pg from being built. Many people on such
 problems will have no difficulties fixing a minor compilation error, but
 fixing configure.in + installing the correct autoconf version is a
 higher barrier.
 We could add a --strict-mode or so to configure, but afair the handling
 of that warning is burried in autoconf itself making this harder. So
 I thought adding some grep like thing to the buildfarm might be the
 easiest solution.

 But that *would* be second-guessing configure's exit status.

Yes. I think that's the easiest thing in this case.

 I don't understand the reference to autoconf - nobody building Postgres,
 including buildfarm members, needs autoconf installed at all. Only
 developers and committers need to, and then only when configure.in is
 changed.

If we would treat that warning as an error unconditionally - and I am
not sure how easy that is given the way it's emitted - users
encountering them, which usually will be on less common platforms, will
have to patch configure.in to make things work for them. Which is a high
bar.
Given that many of those warnings will *NOT* completely prohibit them
from building postgres that might be overreaching.

Greetings,

Andres Freund

-- 
 Andres Freund http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training  Services


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


[BUGS] Installer: Spurious service account ... not removed on uninstall

2013-06-30 Thread Craig Ringer
Hi folks

A Stack Overflow user noticed that the EDB installer for PostgreSQL
emits the message:

The data directory (bla bla) and service user account (NT
AUTHORITY\NetworkService) have not been removed

when 9.2 is uninstalled. They were quite confused by this. It occurs to
me that if the standard NetworkService account is used, it'd be good to
suppress the user account not removed part of the message entirely.

http://stackoverflow.com/q/17394116/398670

-- 
 Craig Ringer   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training  Services


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


[BUGS] BUG #8272: Unable to connect to diffrent schema from jdbc

2013-06-30 Thread emesika
The following bug has been logged on the website:

Bug reference:  8272
Logged by:  Eli Mesika
Email address:  emes...@redhat.com
PostgreSQL version: 8.4.17
Operating system:   Linux (Fedora 18)
Description:

Hi
Postgres does not support currently defining the schema in teh connection
parameters which makes it imposible to seprate the database to several
schemas and connect to the right one from the application.


There is already a thread discussing that and a suggested patch that is
fixing that.
See


http://www.postgresql.org/message-id/4873f034.8010...@scharp.org




-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs