Re: archive_command was duplicated in backup.sgml
Saito-san, Oh, I didn't realize that you have aready pointed out this 1 hour earlier than me. Sorry for this. Best reagards, -- Tatsuo Ishii SRA OSS LLC English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp From: Noboru Saito Subject: archive_command was duplicated in backup.sgml Date: Sat, 14 Jan 2023 10:00:26 +0900 Message-ID: > Hi, > archive_command was written twice in backup.sgml. > > diff --git a/doc/src/sgml/backup.sgml b/doc/src/sgml/backup.sgml > index 8bab521718..be05a33205 100644 > --- a/doc/src/sgml/backup.sgml > +++ b/doc/src/sgml/backup.sgml > @@ -956,8 +956,7 @@ SELECT * FROM pg_backup_stop(wait_for_archive => true); > On a standby, archive_mode must be > always in order > for pg_backup_stop to wait. > Archiving of these files happens automatically since you have > - already configured archive_command or > archive_library or > - archive_command. > + already configured archive_command or > archive_library. > In most cases this happens quickly, but you are advised to monitor your > archive system to ensure there are no delays. > If the archive process has fallen behind because of failures of the
Re: jsonlog cursor_position type is wrong.
> On Mon, Oct 24, 2022 at 02:04:48PM +0900, Michael Paquier wrote: >> Thanks, that's wrong :/ > > Anyway, this one is on me, so applied. Thanks for the patch and the > report! Thank you! -- Tatsuo Ishii SRA OSS LLC English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp
Re: jsonlog cursor_position type is wrong.
> Hi. > > PostgreSQL document In "Table 20.3. Keys and Values of JSON Log Entries", > "Type" in cursor_position should be "number", not "Sting". > https://www.postgresql.org/docs/current/runtime-config-logging.html#RUNTIME-CONFIG-LOGGING-JSONLOG-KEYS-VALUES Yeah, that's a typo. Patch attached. Best reagards, -- Tatsuo Ishii SRA OSS LLC English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index 703f6d5a7f..724c832308 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -7794,7 +7794,7 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv; cursor_position - string + number Cursor index into query string
Re: Only one nextval tag is different
>> Hello, I am a member of the PostgreSQL documentation Japanese translation >> team. >> >> I noticed that the nextval tag in ref/create_sequence.sgml is different. >> Is this just a mistake? Patch pushed to all supported branches. Thanks! -- Tatsuo Ishii SRA OSS LLC English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: Only one nextval tag is different
Yes, it seems using tag for nextval is plain wrong because nextval is a function name. Moreover in other places tags are used and using tag here looks inconsistent. Best reagards, -- Tatsuo Ishii SRA OSS LLC English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp > Hello, I am a member of the PostgreSQL documentation Japanese translation > team. > > I noticed that the nextval tag in ref/create_sequence.sgml is different. > Is this just a mistake? > > diff --git a/doc/src/sgml/ref/create_sequence.sgml > b/doc/src/sgml/ref/create_sequence.sgml > index a84aa5bf56..34e9084b5c 100644 > --- a/doc/src/sgml/ref/create_sequence.sgml > +++ b/doc/src/sgml/ref/create_sequence.sgml > @@ -303,21 +303,21 @@ SELECT * FROM name; > > > > Furthermore, although multiple sessions are guaranteed to allocate > distinct sequence values, the values might be generated out of > sequence when all the sessions are considered. For example, with > a cache setting of 10, > session A might reserve values 1..10 and return > nextval=1, then session B might reserve values > 11..20 and return nextval=11 before session A > - has generated nextval=2. Thus, with a > + has generated nextval=2. Thus, with a > cache setting of one > it is safe to assume that nextval values are > generated > sequentially; with a class="parameter">cache setting greater than one you > should only assume that the nextval values are all > distinct, not that they are generated purely sequentially. Also, > last_value will reflect the latest value reserved by > any session, whether or not it has yet been returned by > nextval. >
Re: pg_wal_lsn_diff
>> I'd just fix HEAD and v13. The earlier branches are not friendly >> at all to long function descriptions. > > +1 from me. Pushed to HEAD and v13. -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: pg_wal_lsn_diff
> I'd just fix HEAD and v13. The earlier branches are not friendly > at all to long function descriptions. +1 from me. -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: pg_wal_lsn_diff
> +1 for fixing that. Two notes though: first, your text doesn't agree
> with the prototype ("ls1" should be "lsn1"), and second, I think it
> would read better if you didn't split the phrase "difference in bytes".
> That is,
>
> -Calculates the difference in bytes between two write-ahead log
> +Calculates the difference in bytes (lsn1 - lsn2) between two
> write-ahead log
>
> Also maybe you should use the lsn1 markup
> in the text.
Thank you for the review. Attached is the revised patch.
So do you think we should back-patch to existing stable branches? The
reason I am asking is, the doc format for v12 and before use very
simple description and if we apply the same description of this patch
to those branche, the description level for the function may look
different from other functions.
(I am not against to apply to v13).
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index b7150510ab..1ab31a9056 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -25102,11 +25102,11 @@ SELECT collation for ('foo' COLLATE "de_DE");
pg_wal_lsn_diff
-pg_wal_lsn_diff ( lsn pg_lsn, lsn pg_lsn )
+pg_wal_lsn_diff ( lsn1 pg_lsn, lsn2 pg_lsn )
numeric
-Calculates the difference in bytes between two write-ahead log
+Calculates the difference in bytes (lsn1 - lsn2) between two write-ahead log
locations. This can be used
with pg_stat_replication or some of the
functions shown in to
pg_wal_lsn_diff
According to the pg_wal_lsn_diff manual:
pg_wal_lsn_diff ( lsn pg_lsn, lsn pg_lsn ) → numeric
Calculates the difference in bytes between two write-ahead log
locations. This can be used with pg_stat_replication or some of
the functions shown in Table 9.87 to get the replication lag.
It's not clear whether its return value is (first arg - second arg) or
(second arg - first arg). The order matters because the return value
could have a sign (it actually does first arg - second arg). Attached
is a patch to fix the description.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index b7150510ab..2870692164 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -25102,11 +25102,11 @@ SELECT collation for ('foo' COLLATE "de_DE");
pg_wal_lsn_diff
-pg_wal_lsn_diff ( lsn pg_lsn, lsn pg_lsn )
+pg_wal_lsn_diff ( lsn1 pg_lsn, lsn2 pg_lsn )
numeric
-Calculates the difference in bytes between two write-ahead log
+Calculates the difference (ls1 - ls2) in bytes between two write-ahead log
locations. This can be used
with pg_stat_replication or some of the
functions shown in to
Re: Need help on translating documentation
> While I was working on those table changes, I had some occasions > to want to do that sort of thing. I found that it was possible > to do it mechanically using XML tools. Unfortunately I did not > save my scripts, and they were just hacks anyway ;-). But you > might be able to get somewhere with that hint. Thanks for the info. I will try the direction. Actually I expected there are something like auto-generate-from-template systems to create catalogs.sgml. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Need help on translating documentation
I am working on translating PostgreSQL 13 documentation to Japanese and having a problem with catalogs.sgml. Due to major format change in 13, the number of places need to translate in 13 is large. 12: aggnumdirectargs int2 Number of direct (non-aggregated) arguments of an ordered-set or hypothetical-set aggregate, counting a variadic array as one argument. If equal to pronargs, the aggregate must be variadic and the variadic array describes the aggregated arguments as well as the final direct arguments. Always zero for normal aggregates. 13: aggnumdirectargs int2 Number of direct (non-aggregated) arguments of an ordered-set or hypothetical-set aggregate, counting a variadic array as one argument. If equal to pronargs, the aggregate must be variadic and the variadic array describes the aggregated arguments as well as the final direct arguments. Always zero for normal aggregates. It looks like in many places the description part of the document are same in 12 and 13. Since we already have translated 12 documents, I wonder if there's a (semi) automated way to reuse the 12 Japanese translation for 13 doc. I want to avoid manual cut work. Any suggestions are welcome. -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: High Availability, Load Balancing, and Replication Feature Matrix
> On Thu, Jul 30, 2020 at 04:02:25PM +0900, Tatsuo Ishii wrote: >> >> > Oops. Forgot to attach the patch. >> > >> >> In the table no bull mark is in "No conflict resolution necessary" row >> >> for pgpool-II. Actually this is wrong. Pgpool-II does not need >> >> conflict resolution. >> >> >> >> Also in the same page "Pgpool-II has this capability." (here "this" >> >> means "Multiple-Server Parallel Query Execution") This used to be true >> >> long time ago but current stable versions of Pgpool-II do not support >> >> this any more. >> >> >> >> Attached patch fixes these. >> >> If there's no objection, I am going to commit this. > > +1 Fix pushed to all supported branches. Thanks! -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: High Availability, Load Balancing, and Replication Feature Matrix
> Oops. Forgot to attach the patch. > >> In the table no bull mark is in "No conflict resolution necessary" row >> for pgpool-II. Actually this is wrong. Pgpool-II does not need >> conflict resolution. >> >> Also in the same page "Pgpool-II has this capability." (here "this" >> means "Multiple-Server Parallel Query Execution") This used to be true >> long time ago but current stable versions of Pgpool-II do not support >> this any more. >> >> Attached patch fixes these. If there's no objection, I am going to commit this. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: High Availability, Load Balancing, and Replication Feature Matrix
Oops. Forgot to attach the patch. > In the table no bull mark is in "No conflict resolution necessary" row > for pgpool-II. Actually this is wrong. Pgpool-II does not need > conflict resolution. > > Also in the same page "Pgpool-II has this capability." (here "this" > means "Multiple-Server Parallel Query Execution") This used to be true > long time ago but current stable versions of Pgpool-II do not support > this any more. > > Attached patch fixes these. > > Best regards, > -- > Tatsuo Ishii > SRA OSS, Inc. Japan > English: http://www.sraoss.co.jp/index_en.php > Japanese:http://www.sraoss.co.jp > > diff --git a/doc/src/sgml/high-availability.sgml b/doc/src/sgml/high-availability.sgml index 89f6d6eda6..a824d383f2 100644 --- a/doc/src/sgml/high-availability.sgml +++ b/doc/src/sgml/high-availability.sgml @@ -429,7 +429,7 @@ protocol to make nodes agree on a serializable transactional order. - + @@ -471,8 +471,7 @@ protocol to make nodes agree on a serializable transactional order. concurrently on a single query. It is usually accomplished by splitting the data among servers and having each server execute its part of the query and return results to a central server where they - are combined and returned to the user. Pgpool-II - has this capability. Also, this can be implemented using the + are combined and returned to the user. This can be implemented using the PL/Proxy tool set.
High Availability, Load Balancing, and Replication Feature Matrix
In the table no bull mark is in "No conflict resolution necessary" row for pgpool-II. Actually this is wrong. Pgpool-II does not need conflict resolution. Also in the same page "Pgpool-II has this capability." (here "this" means "Multiple-Server Parallel Query Execution") This used to be true long time ago but current stable versions of Pgpool-II do not support this any more. Attached patch fixes these. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
No mention about somaxconn
Currently there's no mention about net.core.somaxconn parameter needs to be adjusted if max_connections is large and UNIX domain socket is used for connection. Since the default for the kernel parameter is small (typically 128), it is easy to hit the limitation and you will get errors something like: could not connect to server: Resource temporarily unavailable I don't know if this should be applied to other OS as well though. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: Question to datatype.sgml
>> I think actually the standard terminology is "round-to-nearest-even". > > Ok, I will change it to "round-to-nearest-even" if there's no objection. Done. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: Question to datatype.sgml
>>> It does actually mean "even and odd". This kind of rounding is also >>> called "Banker's Rounding". >>> https://en.wikipedia.org/wiki/Rounding#Round_half_to_even > >> Oh, Thanks! The link is very helpful. > > I think actually the standard terminology is "round-to-nearest-even". Ok, I will change it to "round-to-nearest-even" if there's no objection. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: Question to datatype.sgml
> On 30/12/2019 01:34, Tatsuo Ishii wrote: >> Hi, >> >> Can you please someone elaborate what's the meaning of "even" in >> datatype.sgml? >> >> >> By default, floating point values are output in text form in their >> shortest precise decimal representation; the decimal value produced is >> closer to the true stored binary value than to any other value >> representable in the same binary precision. (However, the output value >> is >> currently never exactly midway between two >> representable values, in order to avoid a widespread bug where input >> routines do not properly respect the round-to-even rule.) This value >> will >> ~~~ >> use at most 17 significant decimal digits for float8 >> values, and at most 9 digits for float4 values. >> >> >> I think "even" means "equality" here, not "even" of "even and odd". > > > It does actually mean "even and odd". This kind of rounding is also > called "Banker's Rounding". > > https://en.wikipedia.org/wiki/Rounding#Round_half_to_even Oh, Thanks! The link is very helpful. -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: Typo in perform.sgml?
> I wrote: >> Actually, that whole para could do with a rewrite; whoever wrote >> it was obviously not familiar with Strunk & White's dictum >> "Omit needless words". > > Looking closer, there were also some unnecessary inconsistencies with > the rest of the section, such as use of "records" rather than "rows", > and different markup choices. I propose the attached ... it's > actually a bit longer than the original, but that's because it > offers more details. Thanks for looking into this. The patch looks much cleaner than before. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Typo in perform.sgml?
Around line 904 of perform.sgml "These node types have the ability to discard subnodes which they are able to determine won't contain any records required by the query." I was not able to parse this. Maybe "that they " is needed after "determine"? Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: standalone-install.xml
> On Thu, 2019-11-21 at 09:08 +0900, Tatsuo Ishii wrote: >> I just want to make sure that if I understand correctly what $subject says. >> In the file: >> >> The previous initdb step should have told you how to >> start up the database server. Do so now. The command should look >> something like: >> >> I think "previous initdb step" means the actual >> execution of initdb command, rather than it refers to the description >> about initdb in the previous section of the doc. >> >> In another word, "previous step should have told you how to start up >> the database server" referes to the message from initdb: >> >> Success. You can now start the database server using: >> >> pg_ctl -D data -l logfile start >> >> Am I correct? > > Right. > > Maybe it were better to write: > > The output from the previous initdb step should have > told you Thanks. That's much clearer to me. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
standalone-install.xml
I just want to make sure that if I understand correctly what $subject says. In the file: The previous initdb step should have told you how to start up the database server. Do so now. The command should look something like: I think "previous initdb step" means the actual execution of initdb command, rather than it refers to the description about initdb in the previous section of the doc. In another word, "previous step should have told you how to start up the database server" referes to the message from initdb: Success. You can now start the database server using: pg_ctl -D data -l logfile start Am I correct? Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: Small typo in func.sgml
>> On 19 Nov 2019, at 14:20, Tatsuo Ishii wrote: > >> >> -Copies an existing logical replication slot name >> src_slot_name >> +Copies an existing logical replication slot named >> src_slot_name > > +1 Fix committed/pushed to master and REL_12_STABLE branches. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Small typo in func.sgml
There's a very small typo in func.sgml. Patch attached. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index 28eb322f3f..e8082c05c9 100644 --- a/doc/src/sgml/func.sgml +++ b/doc/src/sgml/func.sgml @@ -20927,7 +20927,7 @@ postgres=# SELECT * FROM pg_walfile_name_offset(pg_stop_backup()); (slot_name name, lsn pg_lsn) -Copies an existing logical replication slot name src_slot_name +Copies an existing logical replication slot named src_slot_name to a logical replication slot named dst_slot_name while changing the output plugin and persistence. The copied logical slot starts from the same LSN as the source logical slot. Both
Small typo in func.sgml
I thinkk a new line is needed after . Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml index 28eb322f3f..6d82c9f0bd 100644 --- a/doc/src/sgml/func.sgml +++ b/doc/src/sgml/func.sgml @@ -12879,7 +12879,8 @@ table2-mapping . - JSON query functions and operators + + JSON query functions and operators pass the provided path expression to the path engine for evaluation. If the expression matches the queried JSON data, the corresponding SQL/JSON item is returned.
Re: First SVG graphic
> This has been committed. The SVG images are committed as well, so no > new tools are required. What is the policy of adding graphics to PostgreSQL 12? Is it encouraged to add more graphics to 12 docs? Or do we want to prohibit it? Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: First SVG graphic
> This has been committed. The SVG images are committed as well, so no > new tools are required. Is it possible to generate figure indexes? Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: Ancient comment in rules.sgml
>> Ok, I will remove the comment in all supported branches (after next >> minor releases are out). Patch attached. > > +1. Looks fine to me. Done. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: Ancient comment in rules.sgml
> Tatsuo Ishii writes: >> There's a comment beginning with: >> >> in rules.sgml around line 2437. It seems this has been there since 2003. >> Do we need to keep this? > > Well, the point is that the whole para after that is commented out. Yes, so my question was we could safely remove the whole comment or not. > The para in question seems to have shown up in 20a071326, and > at the time it began > > + > +Another situation are cases on UPDATE where it depends on the > +change of an attribute if an action should be performed or > +not. In Postgres version 6.4, the > +attribute specification for rule events is disabled (it will have > +it's comeback latest in 6.5, maybe earlier > +- stay tuned). So for now the only way to > +create a rule as in the shoelace_log example is to do it with > +a rule qualification. That results in an extra query that is > +performed allways, even if the attribute of interest cannot > > I think it's a safe bet at this point that that feature isn't ever > coming back, so I'd be good with ripping out the whole para. Ok, I will remove the comment in all supported branches (after next moinor releases are out). Patch attached. -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp diff --git a/doc/src/sgml/rules.sgml b/doc/src/sgml/rules.sgml index 3372b1ac2b..4e20664ea1 100644 --- a/doc/src/sgml/rules.sgml +++ b/doc/src/sgml/rules.sgml @@ -2434,30 +2434,6 @@ Nestloop in a command. - - - The summary is, rules will only be significantly slower than triggers if their actions result in large and badly qualified
Ancient comment in rules.sgml
There's a comment beginning with: in rules.sgml around line 2437. It seems this has been there since 2003. Do we need to keep this? Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: First SVG graphic
> On 24/01/2019 00:53, Bruce Momjian wrote: >> This is a pretty complicated issue with a lot of back-story. I am >> thinking Tatsuo or me will probably commit it before March. > > Isn't that all the more reason to add it to the commitfest? +1. -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: First SVG graphic
> On Mon, Jan 21, 2019 at 03:02:43PM +0100, Jürgen Purtz wrote: >> The attached patch contains all necessary changes to the sgml, svg, and >> Makefile. (Possibly we need some more changes regarding the 'install*' tasks >> of Makefile.) How to go on? Shall I send the patch to a different list or to >> Commitfest 2019-03? > > This is a pretty complicated issue with a lot of back-story. I am > thinking Tatsuo or me will probably commit it before March. Maybe I am missing in the discussion, but I realized that the patch does not include something like "figure number". I think it would be convenient for users to find that in the index. BTW, the patch has some trailing spaces. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp > --- > > >> >> Kind regards >> >> Jürgen Purtz >> >> >> On 17.01.19 23:43, Tatsuo Ishii wrote: >> >>>Thanks to an additional template created by Alexander Lakhin, which >> >>>extends the >> >>>'nochunk' stylesheet for SVG and MathML processing, it is now possible to >> >>>create the "single HTML file" of our documentation including SVG. For me >> >>>this >> >>>is a working solution as long as we use Docbook 4. After the migration to >> >>>Docbook 5, both languages as well as full namespace support will be >> >>>natively >> >>>included in Docbook. >> >>> >> >>>Does anyone faced some more problems? Or can we start to include the three >> >>>first SVG graphics into PG's documentation? >> >>OK, the wiki pages look good, as do the diagrams, and I think you have >> >>the process we all agreed with. Should we move ahead and commit some of >> >>these diagrams to the souce tree for PG 12? >> >Yes, I think we should. >> > >> >Best regards, >> >-- >> >Tatsuo Ishii >> >SRA OSS, Inc. Japan >> >English: http://www.sraoss.co.jp/index_en.php >> >Japanese:http://www.sraoss.co.jp >> > >> > > >> diff --git a/doc/src/sgml/Makefile b/doc/src/sgml/Makefile >> index 8326c7c673..27d1e674f4 100644 >> --- a/doc/src/sgml/Makefile >> +++ b/doc/src/sgml/Makefile >> @@ -57,6 +57,8 @@ GENERATED_SGML = version.sgml \ >> >> ALLSGML := $(wildcard $(srcdir)/*.sgml $(srcdir)/ref/*.sgml) >> $(GENERATED_SGML) >> >> +SVGSRC := $(wildcard $(srcdir)/svg/*.svg) >> + >> >> ## >> ## Man pages >> @@ -125,10 +127,12 @@ endif >> >> html: html-stamp >> >> -html-stamp: stylesheet.xsl postgres.sgml $(ALLSGML) >> +html-stamp: stylesheet.xsl postgres.sgml $(ALLSGML) $(SVGSRC) >> $(XMLLINT) $(XMLINCLUDE) --noout --valid $(word 2,$^) >> $(XSLTPROC) $(XMLINCLUDE) $(XSLTPROCFLAGS) $(XSLTPROC_HTML_FLAGS) >> $(wordlist 1,2,$^) >> cp $(srcdir)/stylesheet.css html/ >> +$(MKDIR_P) html/svg >> +cp $(SVGSRC) html/svg >> touch $@ >> >> htmlhelp: stylesheet-hh.xsl postgres.sgml $(ALLSGML) >> @@ -136,7 +140,7 @@ htmlhelp: stylesheet-hh.xsl postgres.sgml $(ALLSGML) >> $(XSLTPROC) $(XMLINCLUDE) $(XSLTPROCFLAGS) $(wordlist 1,2,$^) >> >> # single-page HTML >> -postgres.html: stylesheet-html-nochunk.xsl postgres.sgml $(ALLSGML) >> +postgres.html: stylesheet-html-nochunk.xsl postgres.sgml $(ALLSGML) >> $(SVGSRC) >> $(XMLLINT) $(XMLINCLUDE) --noout --valid $(word 2,$^) >> $(XSLTPROC) $(XMLINCLUDE) $(XSLTPROCFLAGS) $(XSLTPROC_HTML_FLAGS) -o $@ >> $(wordlist 1,2,$^) >> >> @@ -152,15 +156,15 @@ postgres.txt: postgres.html >> postgres.pdf: >> $(error Invalid target; use postgres-A4.pdf or postgres-US.pdf as >> targets) >> >> -%-A4.fo: stylesheet-fo.xsl %.sgml $(ALLSGML) >> +%-A4.fo: stylesheet-fo.xsl %.sgml >> $(XMLLINT) $(XMLINCLUDE) --noout --valid $(word 2,$^) >> $(XSLTPROC) $(XMLINCLUDE) $(XSLTPROCFLAGS) --stringparam paper.type A4 >> -o $@ $(wordlist 1,2,$^) >> >> -%-US.fo: stylesheet-fo.xsl %.sgml $(ALLSGML) >> +%-US.fo: stylesheet-fo.xsl %.sgml >> $(XMLLINT) $(XMLINCLUDE) --noout --valid $(word 2,$^) >> $(XSLTPROC) $(XMLINCLUDE) $(XSLTPROCFLAGS) --stringparam paper.type >> USletter -o $@ $(wordlist 1,2,$^) >> >> -%.pdf: %.fo >> +%.pdf: %.fo $(ALLSGML) $(SVGSRC) >> $(FOP) -fo $< -pdf $@ >> >> >&
Typo in URL
URL of OASIS group has been changed from http://www.oasis-open.org/ to https://www.oasis-open.org/, but there's a place where http is still used. Attached patch fixes that. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp diff --git a/doc/src/sgml/docguide.sgml b/doc/src/sgml/docguide.sgml index aa0f278b02..0608b8c612 100644 --- a/doc/src/sgml/docguide.sgml +++ b/doc/src/sgml/docguide.sgml @@ -80,7 +80,7 @@ - http://www.oasis-open.org/docbook/;>DocBook DTD + https://www.oasis-open.org/docbook/;>DocBook DTD This is the definition of DocBook itself. We currently use version
Re: First SVG graphic
>> Thanks to an additional template created by Alexander Lakhin, which extends >> the >> 'nochunk' stylesheet for SVG and MathML processing, it is now possible to >> create the "single HTML file" of our documentation including SVG. For me this >> is a working solution as long as we use Docbook 4. After the migration to >> Docbook 5, both languages as well as full namespace support will be natively >> included in Docbook. >> >> Does anyone faced some more problems? Or can we start to include the three >> first SVG graphics into PG's documentation? > > OK, the wiki pages look good, as do the diagrams, and I think you have > the process we all agreed with. Should we move ahead and commit some of > these diagrams to the souce tree for PG 12? Yes, I think we should. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: MULE_INTERNAL
> The following documentation comment has been logged on the website: > > Page: https://www.postgresql.org/docs/11/multibyte.html > Description: > > The documentation says that UTF-8 can be converted to any encoding: > > UTF8 all supported encodings > > That's not true: > > db => SET CLIENT_ENCODING TO 'MULE_INTERNAL'; > ERROR: invalid value for parameter "client_encoding": "MULE_INTERNAL" > DETAIL: Conversion between MULE_INTERNAL and UTF8 is not supported. > > Maybe MULE shouldn't be a supported encoding. One of the advantages of using MULE_INTERNAL as a database encoding is, it allows a round trip conversion between encodings, plus speed (unlike to/from UTF-8 conversion no table lookup is involved with MULE_INTERNAL.) On the other hand, UTF-8 does not allow round trip encoding conversions for some encodings, which means you may loose some information in your text data when you store it into a database. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: First SVG graphic
> On Wed, Nov 28, 2018 at 8:53 PM Alvaro Herrera > wrote: > >> On 2018-Nov-28, Bruce Momjian wrote: >> >> > On Wed, Nov 28, 2018 at 11:46:33AM -0800, Andres Freund wrote: >> > > Hi, >> > > >> > > On 2018-11-28 18:34:26 +0100, Jürgen Purtz wrote: >> > > > After one week no response at all? Neither positive nor negative. It >> seems >> > > > that the community has little interest in the SVG issue. Or in my >> > > > suggestion? >> > > >> > > I'd suggest describing your proposed workflow in sgml, not a pdf file. >> > >> > Well, there were a number of images in the PDF that would be harder to >> > do in SGML. >> >> I think the point is how do you integrate the images from the SVG source >> into the documentation output. Presumably that won't be PDF, for >> example the HTML output will not use a PDF as an image embedded in the >> page. It probably works ok for the PDF output (of the whole >> documentation) to use the PDF of the image ... I suppose the HTML output >> will need a PNG or such. >> >> > If the source is SVG, why not just use SVG? SVG support in browsers has to > be pushing 10 years now, shouldn't be a problem at all... And SVG can be > embedded in the HTML itself (whether that would work in this particular > case I don't know, but in theory it can) +1. -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: question, converting version 11 sgml files at once.
Hi Ioseph, BTW, Japan User Group is struggling with the same problem you have. We try to merge the difference between REL_10 doc and REL_11 doc into Japanese doc which is based on REL_10. We had too many conflicts there and one of JPUG members has been trying sgml2xml.pl to reduce the conflicts. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp > Thanks! > > That is what I was looking for. > > I'm trying to use a sgml2xml.pl script. > > > Regards, Ioseph > > > 2018년 10월 29일 19:09에 Peter Eisentraut 이(가) 쓴 글: >> On 19/10/2018 10:04, Ioseph Kim wrote: >>> 2017-11-23 Peter Eisentraut Convert documentation to DocBook >>> XML >>> 2017-10-20 Peter Eisentraut Convert SGML IDs to lower case >>> 2017-10-17 Peter Eisentraut Don't use SGML empty tags >>> >>> there were these commit log. >>> >>> I knew today that all sgml files have changed with these commit. >>> >>> >>> I want to change korean sgml files too. >>> >>> How can I change all file at once? >>> >>> I tried with sed, perl, even if python sgml parser coding, >>> unfortunately >>> this work was not easy. >>> >>> Please let me know secret method :) >> There is not a single method. The process was a combination of manual >> work supported by ad hoc scripts. Some of them have been posted in >> the >> "DocBook 5.x" thread. If you follow the above commits you know what >> needs to be done, and you can do it step by step, as we have done. >> > >
Creating Certificates
In "18.9.3. Creating Certificates", -- To create a server certificate whose identity can be validated by clients, first create a certificate signing request (CSR) and a public/private key file: openssl req -new -nodes -text -out root.csr \ -keyout root.key -subj "/CN=root.yourdomain.com" chmod og-rwx root.key Then, sign the request with the key to create a root certificate authority (using the default OpenSSL configuration file location on Linux): openssl x509 -req -in root.csr -text -days 3650 \ -extfile /etc/ssl/openssl.cnf -extensions v3_ca \ -signkey root.key -out root.crt -- For me it seesm the two-step procedure can be replaced with following one command: openssl req -new -x509 -nodes -text -days 3650 \ -config /etc/ssl/openssl.cnf -extensions v3_ca \ -out root.crt -keyout root.key -subj "/CN=root.yourdomain.com" Is there any reaon why our doc recommend the two-step procedure? Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
Re: Enhancing protocol.sgml
Hi Bradley, Thank your for your follow up. Your patch looks good to me. Can you please re-send your message in pgsql-hackers attaching to this thread? https://www.postgresql.org/message-id/flat/20180730.080748.1152436144966943439.t-is...@sraoss.co.jp I have registered the thread in CommitFest: https://commitfest.postgresql.org/19/1738/ Unfortunately CommitFest app does not allow to handle emails other than posted to pgsql-hackers. So I decided to post to pgsql-hackers after posting to pgsql-docs. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp From: "Bradley DeJong" Subject: Re: Enhancing protocol.sgml Date: Fri, 24 Aug 2018 15:43:28 + Message-ID: > On 2018-07-27, Tatsuo Ishii wrote ... >> ... I think this should be mentioned in protocol.sgml as well. ... > > I agree. It is already mentioned as one of the differences between v2 > and v3 but an implementer should not need to read that section if they > are only implementing v3. (I know I've never looked at it before.) > > Using protocol.diff as a base, I changed the phrasing to be more > prescriptive for v3 protocol implementers (don't send a final line, be > prepared to receive a final line), changed passive voice to active > voice and fixed one COPYData -> CopyData capitalization. > > I also called this out in the description of the CopyData message > format because that is where the termination line would be > transmitted.
protocol.sgml typo?
For me it seems there's a typo in protocol.sgml. I am not an English native speaker and I might be wrong though. diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml index 4fd61d7..366b684 100644 --- a/doc/src/sgml/protocol.sgml +++ b/doc/src/sgml/protocol.sgml @@ -5784,7 +5784,7 @@ StartupMessage (F) -In addition to the above, others parameter may be listed. +In addition to the above, other parameters may be listed. Parameter names beginning with _pq_. are reserved for use as protocol extensions, while others are treated as run-time parameters to be set at backend start Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp
