Re: Stale external URL in doc?

[Kyotaro Horiguchi]

At Sat, 18 Jul 2020 22:48:47 +0900, Michael Paquier  wrote 
in 
> On Fri, Jul 17, 2020 at 02:03:18PM +0900, Michael Paquier wrote:
> > It would be better to get all that fixed and backpatched. Is somebody
> > already looking into that?
> 
> I have been through this set, and applied the changes as of 045d03f & 
> friends.  There was an extra URL broken in 9.5 and 9.6 related to the
> passphrase FAQ.

Thanks!

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Re: Stale external URL in doc?

[Bruce Momjian]

On Thu, Jul  9, 2020 at 09:51:51AM -0400, Tom Lane wrote:
> Daniel Gustafsson  writes:
> > As a short term fix we should either a) remove these links completely or b)
> > link to archived copies of the pages on archive.org; or c) find a more
> > appropriate pages to link to.  A quick search didn't turn up anything I 
> > would
> > prefer for (c), and I'm not sure what he legality of linking to a cached 
> > copy
> > is, so I would advocate for (a).
> 
> +1.  It should have been obvious just from the spelling of this URL that
> it wasn't intended to be a long term stable location.  Digging in the
> git history shows we've already updated it twice, and I wonder how many
> changes there were that we didn't notice.
> 
> Just reverting bbd3bdba3 seems appropriate to me.

Yes, I was keeping those URLs specifically to document intermediate
certificate usage, but now that we have documentation of how to set up
intermediates, we don't need it anymore.

-- 
  Bruce Momjian  https://momjian.us
  EnterpriseDB https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee

Re: Stale external URL in doc?

[Michael Paquier]

On Fri, Jul 17, 2020 at 02:03:18PM +0900, Michael Paquier wrote:
> It would be better to get all that fixed and backpatched. Is somebody
> already looking into that?

I have been through this set, and applied the changes as of 045d03f & 
friends.  There was an extra URL broken in 9.5 and 9.6 related to the
passphrase FAQ.
--
Michael


signature.asc
Description: PGP signature

Re: Stale external URL in doc?

[Michael Paquier]

On Fri, Jul 17, 2020 at 12:13:08PM +0900, Kyotaro Horiguchi wrote:
> I checked through http:// URLs in the documentation.

It would be better to get all that fixed and backpatched. Is somebody
already looking into that?
--
Michael


signature.asc
Description: PGP signature

Re: Stale external URL in doc?

[Kyotaro Horiguchi]

At Thu, 16 Jul 2020 14:09:17 +0200, Daniel Gustafsson  wrote 
in 
> > On 10 Jul 2020, at 23:55, Daniel Gustafsson  wrote:
> > 
> >> On 10 Jul 2020, at 23:47, Tom Lane  wrote:
> >> Thomas Munro  writes:
> > 
> >>> The others required minor manual sleuthing to correct; I hope I found
> >>> the correct ISN ranges page.  Please see attached.
> >> 
> >> I didn't actually check any of these, but they look like sane changes.
> > 
> > +1, looks good, thanks!
> 
> Since this is still in flight, I'm tacking on a few more in the attached diff
> that I stumbled across.  gnu.org will redirect from http to https so we might
> as well have that in our docs from the start.

I checked through http:// URLs in the documentation.

1. 505 Not found (0001-Fix-505-URL.patch)

  (Shows login page instead)  
  http://citeseer.ist.psu.edu/seshadri95generalized.html 
=> https://citeseer.ist.psu.edu/viewdoc/summary?doi=10.1.1.40.5740

2. moved or rearranged (0002-Fixed-URLs-mofed-or-rearranged.patch)

  http://initd.org/psycopg/
=> https://www.psycopg.org/

  http://db.cs.berkeley.edu => https://dsf.berkeley.edu
http://db.cs.berkeley.edu/jmh/
http://db.cs.berkeley.edu/papers/
http://db.cs.berkeley.edu/papers/ERL-M85-95.pdf
http://db.cs.berkeley.edu/papers/ERL-M87-06.pdf
http://db.cs.berkeley.edu/papers/ERL-M87-13.pdf
http://db.cs.berkeley.edu/papers/ERL-M89-17.pdf
http://db.cs.berkeley.edu/papers/ERL-M89-82.pdf
http://db.cs.berkeley.edu/papers/ERL-M90-34.pdf
http://db.cs.berkeley.edu/papers/ERL-M90-36.pdf
http://db.cs.berkeley.edu/papers/UCB-MS-zfong.pdf
http://db.cs.berkeley.edu/postgres.html

   (I counldn't find the eqquivalent for http://gist.cs.berkeley.edu/
in dsf.berkeley.edu)

   http://json.org =>  https://www.json.org  (Redirects to localized page)


3. Has the same page for https://  (0003-change-http-URLs-to-https.patch)
  http://cve.mitre.org/
  http://jlcooke.ca/random/
  http://postgis.net/
  http://pqxx.org/
  http://pubs.opengroup.org/onlinepubs/009695399/functions/strftime.html
  http://snowballstem.org/
  http://sourceware.org/systemtap/
  http://standards.ieee.org/
  
http://standards.iso.org/ittf/PubliclyAvailableStandards/c067367_ISO_IEC_TR_19075-6_2017.zip
  http://web.mit.edu/Kerberos/dist/index.html
  http://www.issn.org/
  http://www.iusmentis.com/security/passphrasefaq/
  http://www.loc.gov/standards/iso639-2/php/English_list.php
  http://www.npgsql.org/
  http://www.openwall.com/crypt/
  http://www.perl.org
  http://www.red3d.com/cwr/evolve.html
  http://www.slony.info
  http://www.tcl.tk/
  http://www.zlib.net
  http://zlatkovic.com/pub/libxml
  (http://www.gnu.org/software/gettext/)
  (http://www.gnu.org/software/libtool/)

4. Has https:// page with some troubles.
  http://www.sunfreeware.com  (insecure certificate)
  http://xmlsoft.org (insercure certificate)
   http://xmlsoft.org/
   http://xmlsoft.org/XSLT/
  http://www.tpc.org/ (private certificate and ... looks odd..)


5. Seems not having https pages.
  http://gist.cs.berkeley.edu/
  http://gnuwin32.sourceforge.net
  http://newbiedoc.sourceforge.net/metadoc/docbook-guide.html
  http://meteora.ucsd.edu/s2k/s2k_home.html
  http://sg.danny.cz/sg/sdparm.html
  http://userguide.icu-project.org/collation/api
  http://userguide.icu-project.org/locale
  http://world.std.com/~reinhold/diceware.html
  http://www.faqs.org/faqs/ai-faq/genetic/part1/
  http://www.interhack.net/people/cmcurtin/snake-oil-faq.html
  http://www.mingw.org/
  http://www.mingw.org/wiki/MSYS
  http://www.ossp.org/pkg/lib/uuid/
  http://www.sai.msu.su/~megera/oddmuse/index.cgi/Gin
  http://www.sai.msu.su/~megera/postgres/gist/
  
http://www.sai.msu.su/~megera/postgres/gist/papers/concurrency/access-methods-for-next-generation.pdf.gz
  http://www.sai.msu.su/~megera/postgres/gist/tsearch/V2/
  http://www.sai.msu.su/~megera/wiki/Gin
  http://www.sai.msu.su/~megera/wiki/spgist_dev
  http://xahlee.info/UnixResource_dir/_/ldpath.html

I attached fixes for 1, 2 and 3, and not for 4. (5 doesn't need
changes).

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center
>From e8ab91092f22c917f3cb16b390af7287f920f45d Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi 
Date: Fri, 17 Jul 2020 11:38:46 +0900
Subject: [PATCH 1/3] Fix 505 URL

---
 doc/src/sgml/biblio.sgml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/src/sgml/biblio.sgml b/doc/src/sgml/biblio.sgml
index e72a65ff8a..43a113d3eb 100644
--- a/doc/src/sgml/biblio.sgml
+++ b/doc/src/sgml/biblio.sgml
@@ -352,7 +352,7 @@ ssimk...@ag.or.at
 


-http://citeseer.ist.psu.edu/seshadri95generalized.html";>Generalized
+https://citeseer.ist.psu.edu/viewdoc/summary?doi=10.1.1.40.5740";>Generalized
 Partial Indexes
 
  
-- 
2.18.4

>From 1bb3b8c6506c7b740470505109e5214797cbc496 Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi 
Date: Fri, 17 Jul 2020 11:41:28 +0900
Subject: [PATCH 2/3] Fix URLs moved or rearranged

---
 doc/src/sgml/biblio.sg

Re: Stale external URL in doc?

[Daniel Gustafsson]

> On 10 Jul 2020, at 23:55, Daniel Gustafsson  wrote:
> 
>> On 10 Jul 2020, at 23:47, Tom Lane  wrote:
>> Thomas Munro  writes:
> 
>>> The others required minor manual sleuthing to correct; I hope I found
>>> the correct ISN ranges page.  Please see attached.
>> 
>> I didn't actually check any of these, but they look like sane changes.
> 
> +1, looks good, thanks!

Since this is still in flight, I'm tacking on a few more in the attached diff
that I stumbled across.  gnu.org will redirect from http to https so we might
as well have that in our docs from the start.

cheers ./daniel



https_gnu.diff
Description: Binary data

Re: Stale external URL in doc?

[Kyotaro Horiguchi]

At Tue, 14 Jul 2020 15:40:41 +1200, Thomas Munro  wrote 
in 
> On Tue, Jul 14, 2020 at 3:27 PM Kyotaro Horiguchi
>  wrote:
> > A. I didn't find the files gb-18030-2000.xml and windows-949-2000.xml
> >   in the ICU site.  We have our own copy in our repository so it's not
> >   a serious problem but I'm not sure what we should do for this.
> 
> The patch I posted earlier fixes that problem (their source repository moved).

- $(DOWNLOAD) 
https://ssl.icu-project.org/repos/icu/data/trunk/charset/data/xml/$(@F)
+ $(DOWNLOAD) 
https://raw.githubusercontent.com/unicode-org/icu-data/master/charset/data/xml/$(@F)

Wow. The URL works and makes no difference in related map files.

Thanks!

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Re: Stale external URL in doc?

[Thomas Munro]

On Tue, Jul 14, 2020 at 3:27 PM Kyotaro Horiguchi
 wrote:
> A. I didn't find the files gb-18030-2000.xml and windows-949-2000.xml
>   in the ICU site.  We have our own copy in our repository so it's not
>   a serious problem but I'm not sure what we should do for this.

The patch I posted earlier fixes that problem (their source repository moved).

Re: Stale external URL in doc?

[Kyotaro Horiguchi]

It is found to be a time capsule full of worms..

At Tue, 14 Jul 2020 09:00:11 +0900 (JST), Kyotaro Horiguchi 
 wrote in 
> > Use of uninitialized value $b1_lower in printf at convutils.pm line 560.
> 
> Mmm. I see the same, too. I'm looking into that.

There are three easy-to-fix issues:

1. The script set utilized undef as zeros, so most of them are fixed
  by using zero for undefs.

2. Some Japanese-related converter scripts seem to be affected by a
  change of regexp greediness and easily fixed.

3. I got a certificate error for ssl.icu-project.org and found that
  the name is changed to icu-project.org. 

And one issue that I'm not sure how we shold treat this:

A. I didn't find the files gb-18030-2000.xml and windows-949-2000.xml
  in the ICU site.  We have our own copy in our repository so it's not
  a serious problem but I'm not sure what we should do for this.

  I found CP949.TXT for windows-949-2000.xml but the former is missing
  mappings for certaion code ranges (c9xx and fexx).


The attached is the fix for 1 to 3 above. It doesn't contain changes
in .map files.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center
>From 1544d47d847607cf2b9a449d586ebf53f1bc241a Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi 
Date: Tue, 14 Jul 2020 12:02:57 +0900
Subject: [PATCH v1] Fix conversion-table generator scripts

convutils.pm utilized implicit convertion of undefined value into an
integer zero. Some of conversion scripts are susceptible to regexp
greediness. Fix all of them.  Follow the changes of ICU site's
configuration.

This change yields one significant difference in resulting map files
for UHC. The mappings no longer have mappings for characters in the
range c9xx and fexx.
---
 src/backend/utils/mb/Unicode/Makefile |  2 +-
 .../utils/mb/Unicode/UCS_to_EUC_JIS_2004.pl   |  4 +-
 src/backend/utils/mb/Unicode/UCS_to_EUC_JP.pl |  3 +-
 .../utils/mb/Unicode/UCS_to_SHIFT_JIS_2004.pl |  4 +-
 src/backend/utils/mb/Unicode/convutils.pm | 56 ++-
 5 files changed, 37 insertions(+), 32 deletions(-)

diff --git a/src/backend/utils/mb/Unicode/Makefile b/src/backend/utils/mb/Unicode/Makefile
index 9084f03009..4645441b64 100644
--- a/src/backend/utils/mb/Unicode/Makefile
+++ b/src/backend/utils/mb/Unicode/Makefile
@@ -122,7 +122,7 @@ euc-jis-2004-std.txt sjis-0213-2004-std.txt:
 	$(DOWNLOAD) http://x0213.org/codetable/$(@F)
 
 gb-18030-2000.xml windows-949-2000.xml:
-	$(DOWNLOAD) https://ssl.icu-project.org/repos/icu/data/trunk/charset/data/xml/$(@F)
+	echo "The source for (@F) no longer exists"
 
 GB2312.TXT:
 	$(DOWNLOAD) 'http://trac.greenstone.org/browser/trunk/gsdl/unicode/MAPPINGS/EASTASIA/GB/GB2312.TXT?rev=1842&format=txt'
diff --git a/src/backend/utils/mb/Unicode/UCS_to_EUC_JIS_2004.pl b/src/backend/utils/mb/Unicode/UCS_to_EUC_JIS_2004.pl
index 092a5b44f5..62500efc6d 100755
--- a/src/backend/utils/mb/Unicode/UCS_to_EUC_JIS_2004.pl
+++ b/src/backend/utils/mb/Unicode/UCS_to_EUC_JIS_2004.pl
@@ -24,7 +24,7 @@ my @all;
 
 while (my $line = <$in>)
 {
-	if ($line =~ /^0x(.*)[ \t]*U\+(.*)\+(.*)[ \t]*#(.*)$/)
+	if ($line =~ /^0x(\w+)[ \t]*U\+(\w+)\+(\w+)[ \t]*#(.*)$/)
 	{
 
 		# combined characters
@@ -45,7 +45,7 @@ while (my $line = <$in>)
 			l  => $.
 		  };
 	}
-	elsif ($line =~ /^0x(.*)[ \t]*U\+(.*)[ \t]*#(.*)$/)
+	elsif ($line =~ /^0x(\w+)[ \t]*U\+(\w+)[ \t]*#(.*)$/)
 	{
 
 		# non-combined characters
diff --git a/src/backend/utils/mb/Unicode/UCS_to_EUC_JP.pl b/src/backend/utils/mb/Unicode/UCS_to_EUC_JP.pl
index 1d88c0296e..d8bed27e1b 100755
--- a/src/backend/utils/mb/Unicode/UCS_to_EUC_JP.pl
+++ b/src/backend/utils/mb/Unicode/UCS_to_EUC_JP.pl
@@ -80,7 +80,8 @@ foreach my $i (@$ct932)
 	}
 }
 
-foreach my $i (@mapping)
+# extract only SJIS characers
+foreach my $i (grep defined $_->{sjis}, @mapping)
 {
 	my $sjis = $i->{sjis};
 
diff --git a/src/backend/utils/mb/Unicode/UCS_to_SHIFT_JIS_2004.pl b/src/backend/utils/mb/Unicode/UCS_to_SHIFT_JIS_2004.pl
index b516e91306..025b0d2798 100755
--- a/src/backend/utils/mb/Unicode/UCS_to_SHIFT_JIS_2004.pl
+++ b/src/backend/utils/mb/Unicode/UCS_to_SHIFT_JIS_2004.pl
@@ -24,7 +24,7 @@ my @mapping;
 
 while (my $line = <$in>)
 {
-	if ($line =~ /^0x(.*)[ \t]*U\+(.*)\+(.*)[ \t]*#(.*)$/)
+	if ($line =~ /^0x(\w+)[ \t]*U\+(\w+)\+(\w+)[ \t]*#(.*)$/)
 	{
 
 		# combined characters
@@ -45,7 +45,7 @@ while (my $line = <$in>)
 			l  => $.
 		  };
 	}
-	elsif ($line =~ /^0x(.*)[ \t]*U\+(.*)[ \t]*#(.*)$/)
+	elsif ($line =~ /^0x(\w+)[ \t]*U\+(\w+)[ \t]*#(.*)$/)
 	{
 
 		# non-combined characters
diff --git a/src/backend/utils/mb/Unicode/convutils.pm b/src/backend/utils/mb/Unicode/convutils.pm
index 2f64a12ea1..9d97061c6f 100644
--- a/src/backend/utils/mb/Unicode/convutils.pm
+++ b/src/backend/utils/mb/Unicode/convutils.pm
@@ -380,7 +380,8 @@ sub print_radix_table
 	  {
 		header  => "Dummy map, for invalid values",
 		min_idx => 0,
-		max_idx => $widest_range
+		max_idx => $widest_range,
+		label => "dummy map"
 	  };
 
 	###
@@

Re: Stale external URL in doc?

[Kyotaro Horiguchi]

At Mon, 13 Jul 2020 11:36:17 +0200, Daniel Gustafsson  wrote 
in 
> > On 11 Jul 2020, at 05:25, Thomas Munro  wrote:
> 
> > Is it OK that I see the following warning many times when running
> > "make" under src/backend/utils/mb/Unicode?  It looks like this code is
> > from commit 1de9cc0d.  Horiguchi-san, do you think something changed
> > (input data format, etc) since you wrote it, or maybe some later
> > changes just made our perl scripts more picky about warnings?
> > 
> >  Use of uninitialized value $val in printf at convutils.pm line 612.
> 
> Confirmed here as well, combined with the below ones for a few of the files:
> 
> Use of uninitialized value in hash element at convutils.pm line 448.
> Use of uninitialized value $b1root in printf at convutils.pm line 558.
> Use of uninitialized value $b1_lower in printf at convutils.pm line 560.

Mmm. I see the same, too. I'm looking into that.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

Re: Stale external URL in doc?

[Daniel Gustafsson]

> On 11 Jul 2020, at 05:25, Thomas Munro  wrote:

> Is it OK that I see the following warning many times when running
> "make" under src/backend/utils/mb/Unicode?  It looks like this code is
> from commit 1de9cc0d.  Horiguchi-san, do you think something changed
> (input data format, etc) since you wrote it, or maybe some later
> changes just made our perl scripts more picky about warnings?
> 
>  Use of uninitialized value $val in printf at convutils.pm line 612.

Confirmed here as well, combined with the below ones for a few of the files:

Use of uninitialized value in hash element at convutils.pm line 448.
Use of uninitialized value $b1root in printf at convutils.pm line 558.
Use of uninitialized value $b1_lower in printf at convutils.pm line 560.
Use of uninitialized value $b1_upper in printf at convutils.pm line 561.
Use of uninitialized value $b3root in printf at convutils.pm line 570.
Use of uninitialized value $b3_1_lower in printf at convutils.pm line 572.
Use of uninitialized value $b3_1_upper in printf at convutils.pm line 573.
Use of uninitialized value $b3_2_lower in printf at convutils.pm line 574.
Use of uninitialized value $b3_2_upper in printf at convutils.pm line 575.
Use of uninitialized value $b3_3_lower in printf at convutils.pm line 576.
Use of uninitialized value $b3_3_upper in printf at convutils.pm line 577.
Use of uninitialized value $val in printf at convutils.pm line 612.

cheers ./daniel

Re: Stale external URL in doc?

[Thomas Munro]

On Sat, Jul 11, 2020 at 9:56 AM Daniel Gustafsson  wrote:
> > On 10 Jul 2020, at 23:47, Tom Lane  wrote:
> > Thomas Munro  writes:
> >> The others required minor manual sleuthing to correct; I hope I found
> >> the correct ISN ranges page.  Please see attached.
> >
> > I didn't actually check any of these, but they look like sane changes.
>
> +1, looks good, thanks!

Is it OK that I see the following warning many times when running
"make" under src/backend/utils/mb/Unicode?  It looks like this code is
from commit 1de9cc0d.  Horiguchi-san, do you think something changed
(input data format, etc) since you wrote it, or maybe some later
changes just made our perl scripts more picky about warnings?

  Use of uninitialized value $val in printf at convutils.pm line 612.

Re: Stale external URL in doc?

[Daniel Gustafsson]

> On 10 Jul 2020, at 23:47, Tom Lane  wrote:
> Thomas Munro  writes:

>> The others required minor manual sleuthing to correct; I hope I found
>> the correct ISN ranges page.  Please see attached.
> 
> I didn't actually check any of these, but they look like sane changes.

+1, looks good, thanks!

cheers ./daniel

Re: Stale external URL in doc?

[Tom Lane]

Thomas Munro  writes:
> The Microsoft one is OK, it's a redirect, but the redirect target
> looks like a more permanent URL to me so maybe we should change it.

+1

> The others required minor manual sleuthing to correct; I hope I found
> the correct ISN ranges page.  Please see attached.

I didn't actually check any of these, but they look like sane changes.

regards, tom lane

Re: Stale external URL in doc?

[Thomas Munro]

On Fri, Jul 10, 2020 at 10:07 AM Daniel Gustafsson  wrote:
> (but I didn't test all of them)

Cave-person shell script time:

for url in ` git grep 'url="http' | sed 's/.*url="//;s/".*//' | sort | uniq `
do
  if ! curl --output /dev/null --silent --head --fail "$url"
  then
echo "bad URL: $url"
  fi
done

bad URL: https://mingw-w64.org/
bad URL: https://msdn.microsoft.com/en-us/library/aa380493%28VS.85%29.aspx
bad URL: https://ssl.icu-project.org/icu-bin/locexp
bad URL: https://www.ismn-international.org/ranges.html

The Microsoft one is OK, it's a redirect, but the redirect target
looks like a more permanent URL to me so maybe we should change it.
The others required minor manual sleuthing to correct; I hope I found
the correct ISN ranges page.  Please see attached.

Looking at the ICU URL, I found a couple like that in our source tree,
and fixed those too, including one used by
src/backend/utils/mb/Unicode/Makefile to fetch source data which has
moved (http://site.icu-project.org/repository says "Announcement
07/16/2018: The ICU source code repository has been migrated from
Subversion to Git, and is now hosted on GitHub.").
From f27aed63697d7ed844dd32f46182d4a8b0edb903 Mon Sep 17 00:00:00 2001
From: Thomas Munro 
Date: Sat, 11 Jul 2020 09:33:10 +1200
Subject: [PATCH] Fix some more broken URLs.

Discussion: https://postgr.es/m/20200709.161226.204639179120026914.horikyota@gmail.com
---
 doc/src/sgml/acronyms.sgml| 2 +-
 doc/src/sgml/charset.sgml | 2 +-
 doc/src/sgml/installation.sgml| 2 +-
 doc/src/sgml/isn.sgml | 2 +-
 src/backend/utils/mb/Unicode/Makefile | 2 +-
 src/common/encnames.c | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/doc/src/sgml/acronyms.sgml b/doc/src/sgml/acronyms.sgml
index f638665dc9..d0265dfb93 100644
--- a/doc/src/sgml/acronyms.sgml
+++ b/doc/src/sgml/acronyms.sgml
@@ -649,7 +649,7 @@
 SSPI
 
  
-  https://msdn.microsoft.com/en-us/library/aa380493%28VS.85%29.aspx";>Security
+  https://docs.microsoft.com/en-us/windows/win32/secauthn/sspi";>Security
   Support Provider Interface
  
 
diff --git a/doc/src/sgml/charset.sgml b/doc/src/sgml/charset.sgml
index 4b4563c5b9..ccd39a55f5 100644
--- a/doc/src/sgml/charset.sgml
+++ b/doc/src/sgml/charset.sgml
@@ -841,7 +841,7 @@ CREATE COLLATION german (provider = libc, locale = 'de_DE');
 subtag) can be found in
 the https://github.com/unicode-org/cldr/blob/master/common/bcp47/collation.xml";>CLDR
 repository.
-The https://ssl.icu-project.org/icu-bin/locexp";>ICU Locale
+The https://icu-project.org/icu-bin/locexp";>ICU Locale
 Explorer can be used to check the details of a particular locale
 definition.  The examples using the k* subtags require
 at least ICU version 54.
diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml
index 552303e211..617eb1b044 100644
--- a/doc/src/sgml/installation.sgml
+++ b/doc/src/sgml/installation.sgml
@@ -2430,7 +2430,7 @@ xcodebuild -version -sdk macosx Path
 

  To build 64 bit binaries using MinGW, install the 64 bit tool set
- from https://mingw-w64.org/";>, put its bin
+ from https://www.mingw-w64.org/";>, put its bin
  directory in the PATH, and run
  configure with the
  --host=x86_64-w64-mingw32 option.
diff --git a/doc/src/sgml/isn.sgml b/doc/src/sgml/isn.sgml
index e1ea209ff1..bdab4eba34 100644
--- a/doc/src/sgml/isn.sgml
+++ b/doc/src/sgml/isn.sgml
@@ -400,7 +400,7 @@ SELECT isbn13(id) FROM test;
 https://en.wikipedia.org/wiki/List_of_ISBN_identifier_groups";>
 https://www.isbn-international.org/content/isbn-users-manual";>
 https://en.wikipedia.org/wiki/International_Standard_Music_Number";>
-https://www.ismn-international.org/ranges.html";>
+https://www.ismn-international.org/ranges/ranges";>

 
Care was taken during the creation of the algorithms and they
diff --git a/src/backend/utils/mb/Unicode/Makefile b/src/backend/utils/mb/Unicode/Makefile
index 9084f03009..da307d8eb9 100644
--- a/src/backend/utils/mb/Unicode/Makefile
+++ b/src/backend/utils/mb/Unicode/Makefile
@@ -122,7 +122,7 @@ euc-jis-2004-std.txt sjis-0213-2004-std.txt:
 	$(DOWNLOAD) http://x0213.org/codetable/$(@F)
 
 gb-18030-2000.xml windows-949-2000.xml:
-	$(DOWNLOAD) https://ssl.icu-project.org/repos/icu/data/trunk/charset/data/xml/$(@F)
+	$(DOWNLOAD) https://raw.githubusercontent.com/unicode-org/icu-data/master/charset/data/xml/$(@F)
 
 GB2312.TXT:
 	$(DOWNLOAD) 'http://trac.greenstone.org/browser/trunk/gsdl/unicode/MAPPINGS/EASTASIA/GB/GB2312.TXT?rev=1842&format=txt'
diff --git a/src/common/encnames.c b/src/common/encnames.c
index 14cf1b39e9..2404822619 100644
--- a/src/common/encnames.c
+++ b/src/common/encnames.c
@@ -408,7 +408,7 @@ const pg_enc2gettext pg_enc2gettext_tbl[] =
 /*
  * Table of encoding names for ICU (currently covers backend encodings only)
  *
- * Reference: 

Re: Stale external URL in doc?

[Daniel Gustafsson]

> On 10 Jul 2020, at 18:28, Tom Lane  wrote:
> Alvaro Herrera  writes:

>> Um, the comp.ai.genetic FAQ can still be found, eg. 
>> http://www.faqs.org/faqs/ai-faq/genetic/part1/
> 
> So it is, although that also shows it hasn't been updated since 2001.

Ah, I missed the alternative source.

> I'll go update that pointer and remove the other links per Daniel's
> patch.

Thanks for the fixup.

cheers ./daniel

Re: Stale external URL in doc?

[Tom Lane]

Alvaro Herrera  writes:
> On 2020-Jul-10, Daniel Gustafsson wrote:
>> Taking a look at other links to external resources, most links seemed to
>> resolve still (but I didn't test all of them).  I did find another one on the
>> GEQO page which is now dead without the content available elsewhere, as well 
>> as
>> a larger problem with the AIX references.

> Um, the comp.ai.genetic FAQ can still be found, eg. 
> http://www.faqs.org/faqs/ai-faq/genetic/part1/

So it is, although that also shows it hasn't been updated since 2001.

OTOH, that vintage of info is probably just fine for understanding GEQO.

I'll go update that pointer and remove the other links per Daniel's
patch.

regards, tom lane

Re: Stale external URL in doc?

[Alvaro Herrera]

On 2020-Jul-10, Daniel Gustafsson wrote:

> Taking a look at other links to external resources, most links seemed to
> resolve still (but I didn't test all of them).  I did find another one on the
> GEQO page which is now dead without the content available elsewhere, as well 
> as
> a larger problem with the AIX references.

Um, the comp.ai.genetic FAQ can still be found, eg. 
http://www.faqs.org/faqs/ai-faq/genetic/part1/



-- 
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Stale external URL in doc?

[Tom Lane]

Daniel Gustafsson  writes:
> Taking a look at other links to external resources, most links seemed to
> resolve still (but I didn't test all of them).  I did find another one on the
> GEQO page which is now dead without the content available elsewhere, as well 
> as
> a larger problem with the AIX references.

> We have a list of links to the AIX 6.1 documentation which no longer works as
> IBM only provides docset PDFs for 6.1.  Looking that 7.x documentation they
> have reorganized enough to make the older links not directly translatable.  I
> do wonder if updating this list is worth the effort, or if it will only lead 
> to
> us revisiting this once IBM does another site change.

> The attached suggestion removes the reported SSL links, the FAQ linked to on
> GEQO and all the IBM links, fully realizing that it might be controversial to
> some extent.

+1 for just deleting all of it.  I don't think we need to be telling users
of obsolete AIX versions how to run their systems.  The comp.ai.genetic
FAQ link might be more of a loss, but on the other hand I'd be willing to
bet it wasn't very up to date anymore.  Netnews has been moribund for a
long time :-(

regards, tom lane

Re: Stale external URL in doc?

[Daniel Gustafsson]

> On 9 Jul 2020, at 17:54, Magnus Hagander  wrote:
> 
> On Thu, Jul 9, 2020 at 3:52 PM Tom Lane  > wrote:
> Daniel Gustafsson mailto:dan...@yesql.se>> writes:
> > As a short term fix we should either a) remove these links completely or b)
> > link to archived copies of the pages on archive.org ; 
> > or c) find a more
> > appropriate pages to link to.  A quick search didn't turn up anything I 
> > would
> > prefer for (c), and I'm not sure what he legality of linking to a cached 
> > copy
> > is, so I would advocate for (a).
> 
> +1.  It should have been obvious just from the spelling of this URL that
> it wasn't intended to be a long term stable location.  Digging in the
> git history shows we've already updated it twice, and I wonder how many
> changes there were that we didn't notice.
> 
> Just reverting bbd3bdba3 seems appropriate to me.
> 
> +1.
> 
> If we want to keep a set of such links, probably the wiki is a better place 
> as more people can easily fix them there.

Taking a look at other links to external resources, most links seemed to
resolve still (but I didn't test all of them).  I did find another one on the
GEQO page which is now dead without the content available elsewhere, as well as
a larger problem with the AIX references.

We have a list of links to the AIX 6.1 documentation which no longer works as
IBM only provides docset PDFs for 6.1.  Looking that 7.x documentation they
have reorganized enough to make the older links not directly translatable.  I
do wonder if updating this list is worth the effort, or if it will only lead to
us revisiting this once IBM does another site change.

The attached suggestion removes the reported SSL links, the FAQ linked to on
GEQO and all the IBM links, fully realizing that it might be controversial to
some extent.

cheers ./daniel



stale_ssl_link.patch
Description: Binary data

Re: Stale external URL in doc?

[Magnus Hagander]

On Thu, Jul 9, 2020 at 6:36 PM Alvaro Herrera 
wrote:

> On 2020-Jul-09, Magnus Hagander wrote:
>
> > If we want to keep a set of such links, probably the wiki is a better
> place
> > as more people can easily fix them there.
>
> Or, since our docs have diagram capabilities now, we can make our own
> diagram.
>

Absolutely. I meant more as a general thing if we want to refer to websites
outside of our control for other things.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ 
 Work: https://www.redpill-linpro.com/ 

Re: Stale external URL in doc?

[Alvaro Herrera]

On 2020-Jul-09, Magnus Hagander wrote:

> If we want to keep a set of such links, probably the wiki is a better place
> as more people can easily fix them there.

Or, since our docs have diagram capabilities now, we can make our own
diagram.

-- 
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Stale external URL in doc?

[Magnus Hagander]

On Thu, Jul 9, 2020 at 3:52 PM Tom Lane  wrote:

> Daniel Gustafsson  writes:
> > As a short term fix we should either a) remove these links completely or
> b)
> > link to archived copies of the pages on archive.org; or c) find a more
> > appropriate pages to link to.  A quick search didn't turn up anything I
> would
> > prefer for (c), and I'm not sure what he legality of linking to a cached
> copy
> > is, so I would advocate for (a).
>
> +1.  It should have been obvious just from the spelling of this URL that
> it wasn't intended to be a long term stable location.  Digging in the
> git history shows we've already updated it twice, and I wonder how many
> changes there were that we didn't notice.
>
> Just reverting bbd3bdba3 seems appropriate to me.
>

+1.

If we want to keep a set of such links, probably the wiki is a better place
as more people can easily fix them there.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ 
 Work: https://www.redpill-linpro.com/ 

Re: Stale external URL in doc?

[Tom Lane]

Daniel Gustafsson  writes:
> As a short term fix we should either a) remove these links completely or b)
> link to archived copies of the pages on archive.org; or c) find a more
> appropriate pages to link to.  A quick search didn't turn up anything I would
> prefer for (c), and I'm not sure what he legality of linking to a cached copy
> is, so I would advocate for (a).

+1.  It should have been obvious just from the spelling of this URL that
it wasn't intended to be a long term stable location.  Digging in the
git history shows we've already updated it twice, and I wonder how many
changes there were that we didn't notice.

Just reverting bbd3bdba3 seems appropriate to me.

regards, tom lane

Re: Stale external URL in doc?

[Daniel Gustafsson]

> On 9 Jul 2020, at 09:12, Kyotaro Horiguchi  wrote:
> 
> Hello.
> 
> I see the following description in the doc.
> 
> https://www.postgresql.org/docs/13/ssl-tcp.html
> 
> Intermediate certificates that chain up to existing root certificates
> can also appear in the ssl_ca_file file if you wish to avoid storing
> them on clients (assuming the root and intermediate certificates were
> created with v3_ca extensions). Certificate Revocation List (CRL)
> entries are also checked if the parameter ssl_crl_file is set. (See
> http://h41379.www4.hpe.com/doc/83final/ba554_90007/ch04s02.html for
> diagrams showing SSL certificate usage.)
> 
> I follwed the URL above and saw the "Support and other resources" page
> of the document "OpeNVMS Systems Documemtation Index page".

Right, it's redirecting there now. The same goes for a link to hpe.com on
https://www.postgresql.org/docs/13/libpq-ssl.html which too is redirected
to a larger documentation set.

> FWIW the folloing URL shows "HP Open Source Security for OpenVMS
> Volume 2: HP SSL for Open VMS", which seems to be the originally
> intended document..
> 
> https://support.hpe.com/hpesc/public/docDisplay?docId=emr_na-c04622320

The intended document is a page which is more concise and to the point, the
full OpenVMS SSL documentation set doesn't really fit the purpose for this
link.

As a short term fix we should either a) remove these links completely or b)
link to archived copies of the pages on archive.org; or c) find a more
appropriate pages to link to.  A quick search didn't turn up anything I would
prefer for (c), and I'm not sure what he legality of linking to a cached copy
is, so I would advocate for (a).

Longer term we should try to incorporate (some of) these diagrams and content
into our own documentation now that we have proper capability for inline
images.

cheers ./daniel