Re: Think-o in foreign key comments

[Peter Eisentraut]

On 03.12.22 05:59, Ian Lawrence Barwick wrote:

2022年12月3日(土) 7:19 Paul Jungwirth :

I noticed a few places in the new foreign key code where a comment says
"the ON DELETE SET NULL/DELETE clause". I believe it should say "ON
DELETE SET NULL/DEFAULT".

These comments were added in d6f96ed94e7, "Allow specifying column list
for foreign key ON DELETE SET actions." Here is a patch to correct them.


LGTM.

I do notice the same patch adds the function "validateFkOnDeleteSetColumns"
but the name in the comment preceding it is "validateFkActionSetColumns",
might as well fix that the same time.


Committed with that addition and backpatched to PG15.

Re: Think-o in foreign key comments

[Ian Lawrence Barwick]

2022年12月3日(土) 7:19 Paul Jungwirth :
>
> Hello,
>
> I noticed a few places in the new foreign key code where a comment says
> "the ON DELETE SET NULL/DELETE clause". I believe it should say "ON
> DELETE SET NULL/DEFAULT".
>
> These comments were added in d6f96ed94e7, "Allow specifying column list
> for foreign key ON DELETE SET actions." Here is a patch to correct them.

LGTM.

I do notice the same patch adds the function "validateFkOnDeleteSetColumns"
but the name in the comment preceding it is "validateFkActionSetColumns",
might as well fix that the same time.

> I don't think you usually create a commitfest entry for tiny fixes like
> this, right? But if you'd like one please let me know and I'll add it.

>From experience usually a committer will pick up trivial fixes like this
within a few days, but if it escapes notice for more than a couple of weeks
a reminder and/or CF entry might be useful to make sure it doesn't get
forgotten.

Regards

Ian Barwick

Think-o in foreign key comments

[Paul Jungwirth]

Hello,

I noticed a few places in the new foreign key code where a comment says 
"the ON DELETE SET NULL/DELETE clause". I believe it should say "ON 
DELETE SET NULL/DEFAULT".


These comments were added in d6f96ed94e7, "Allow specifying column list 
for foreign key ON DELETE SET actions." Here is a patch to correct them. 
I don't think you usually create a commitfest entry for tiny fixes like 
this, right? But if you'd like one please let me know and I'll add it.


Yours,

--
Paul  ~{:-)
p...@illuminatedcomputing.comFrom dc5e317762266b93bfa44bb303fe1882853d8de7 Mon Sep 17 00:00:00 2001
From: "Paul A. Jungwirth" 
Date: Fri, 2 Dec 2022 14:02:55 -0800
Subject: [PATCH v1] Fix FK comment think-o

---
 src/backend/commands/tablecmds.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 3e83f375b5..716793e157 100644
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -9467,10 +9467,10 @@ validateFkOnDeleteSetColumns(int numfks, const int16 *fkattnums,
  * numfks is the number of columns in the foreign key
  * pkattnum is the attnum array of referenced attributes.
  * fkattnum is the attnum array of referencing attributes.
- * numfkdelsetcols is the number of columns in the ON DELETE SET NULL/DELETE
+ * numfkdelsetcols is the number of columns in the ON DELETE SET NULL/DEFAULT
  *  (...) clause
  * fkdelsetcols is the attnum array of the columns in the ON DELETE SET
- *  NULL/DELETE clause
+ *  NULL/DEFAULT clause
  * pf/pp/ffeqoperators are OID array of operators between columns.
  * old_check_ok signals that this constraint replaces an existing one that
  * was already validated (thus this one doesn't need validation).
@@ -9686,10 +9686,10 @@ addFkRecurseReferenced(List **wqueue, Constraint *fkconstraint, Relation rel,
  * pkattnum is the attnum array of referenced attributes.
  * fkattnum is the attnum array of referencing attributes.
  * pf/pp/ffeqoperators are OID array of operators between columns.
- * numfkdelsetcols is the number of columns in the ON DELETE SET NULL/DELETE
+ * numfkdelsetcols is the number of columns in the ON DELETE SET NULL/DEFAULT
  *  (...) clause
  * fkdelsetcols is the attnum array of the columns in the ON DELETE SET
- *  NULL/DELETE clause
+ *  NULL/DEFAULT clause
  * old_check_ok signals that this constraint replaces an existing one that
  *		was already validated (thus this one doesn't need validation).
  * lockmode is the lockmode to acquire on partitions when recursing.
-- 
2.25.1