Re: [HACKERS] Adding -E switch to pg_dumpall

2017-09-01 Thread Michael Paquier 
On Sat, Sep 2, 2017 at 1:32 AM, Robert Haas  wrote:
> On Fri, Jul 21, 2017 at 9:21 AM, Michael Paquier
>  wrote:
>> On Thu, Jul 20, 2017 at 11:17 AM, Fabien COELHO  wrote:
>>> Ok for me. I switched the status to "Ready for committers".
>>
>> Thanks for the review, Fabien.
>
> LGTM.  Committed.

Thanks for the commit.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Adding -E switch to pg_dumpall

2017-09-01 Thread Robert Haas 
On Fri, Jul 21, 2017 at 9:21 AM, Michael Paquier
 wrote:
> On Thu, Jul 20, 2017 at 11:17 AM, Fabien COELHO  wrote:
>> Ok for me. I switched the status to "Ready for committers".
>
> Thanks for the review, Fabien.

LGTM.  Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Adding -E switch to pg_dumpall

2017-07-21 Thread Michael Paquier 
On Thu, Jul 20, 2017 at 11:17 AM, Fabien COELHO  wrote:
> Ok for me. I switched the status to "Ready for committers".

Thanks for the review, Fabien.
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Adding -E switch to pg_dumpall

2017-07-20 Thread Fabien COELHO 


Hello Michaël-san,


Attached is a patch to add support for this switch. I am parking that
in the next CF.


I'm in favor of this feature for consistency with pg_dump, and as the 
environment variable workaround is not specially elegant and can induce 
issues of its own.


Patch applies and compiles.

No special regression tests are provided, but this seems ok to me as it 
just forward the option to pg_dump, which I have no doubt is heavily 
tested. Or not. Anyway it is consistent...


Manually tested with UTF8, latin1 (including conversion errors), non 
existing.


Code is straightforward. Doc and help are both fine.

Ok for me. I switched the status to "Ready for committers".

--
Fabien.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Adding -E switch to pg_dumpall

2017-07-15 Thread Michael Paquier 
On Fri, Jul 14, 2017 at 12:39 PM, Michael Paquier
 wrote:
> While looking at a user problem, I got surprised that pg_dumpall does
> not have a -E switch. This has been discussed a bit in the past like
> here:
> https://www.postgresql.org/message-id/75e4c42d37e6a74e9fb57c2e9f1300d601070...@tiger.nexperience.com
>
> Now it is possible to enforce the encoding used by using
> PGCLIENTENCODING but I think that a switch would be useful as well,
> particularly for Windows where "set" needs to be used. Are there any
> objections to a patch adding support for that? Such a patch should do:
> - Call PQsetClientEncoding if an encoding is defined after getting a 
> connection.
> - Pass down -E to pg_dump calls if something is set.
>
> Thoughts?

Attached is a patch to add support for this switch. I am parking that
in the next CF.
-- 
Michael


pgdumpall-encoding-v1.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Adding -E switch to pg_dumpall

2017-07-14 Thread Michael Paquier 
Hi all,

While looking at a user problem, I got surprised that pg_dumpall does
not have a -E switch. This has been discussed a bit in the past like
here:
https://www.postgresql.org/message-id/75e4c42d37e6a74e9fb57c2e9f1300d601070...@tiger.nexperience.com

Now it is possible to enforce the encoding used by using
PGCLIENTENCODING but I think that a switch would be useful as well,
particularly for Windows where "set" needs to be used. Are there any
objections to a patch adding support for that? Such a patch should do:
- Call PQsetClientEncoding if an encoding is defined after getting a connection.
- Pass down -E to pg_dump calls if something is set.

Thoughts?
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers