Re: [HACKERS] Patch rev 2: MySQL-ism help patch for psql

2010-01-20 Thread Rob Wultsch
On Tue, Jan 19, 2010 at 5:01 PM, David Christensen  wrote:
>
> On Jan 19, 2010, at 4:23 PM, Robert Haas wrote:
>
>> On Tue, Jan 19, 2010 at 5:14 PM, David E. Wheeler 
>> wrote:
>>>
>>> Why would they want more? It's not MySQL, and they know that. If we give
>>> them some very minor helpful hints for the most common things they try to
>>> do, it would be a huge benefit to them. I know I've badly wanted the
>>> opposite when I've had to use MySQL, but I don't expect MySQL to implement
>>> \c for me.
>>
>> +1.  I think this is a well-thought out proposal.  I like Tom's
>> suggestion upthread for how to handle \c.
>
> I've attached a second revision of this patch incorporating the various
> feedback I've received.
>
>> Although the deadline for patches for 8.5 has supposedly already
>> passed
>
> Yeah, I realized this after I scratched my itch, and had just thought I
> would send to the list any way for after the CF; you can commit or bump as
> needed.  Patch enclosed as a context-diff attachment this time.
>
> Regards,
>
> David
> --
> David Christensen
> End Point Corporation
> da...@endpoint.com


Although I have a snowballs chance in hell to convert my coworkers to
using pg I think that this patch would make such an outcome more
likely. Please consider what a  MySQL dba does when he gets a call at
3AM that a server
(p3.any43.db69.I_have_no_clue_what_this_stupid_f'ing_server_is.wtf.pg
) is at max-connections. I think that some helpful hints for non-pg
dba's that are using pg in some capacity are a very good idea.

-- 
Rob Wultsch
wult...@gmail.com

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Patch rev 2: MySQL-ism help patch for psql

2010-01-19 Thread Tom Lane
David Christensen  writes:
> I also forgot to enclose the sample output in this version, based  
> largely on Tom's wording for the USE usecase:

Please note that that was just an off-the-cuff example, not something
I thought was perfect as is ...

regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Patch rev 2: MySQL-ism help patch for psql

2010-01-19 Thread David Christensen


On Jan 19, 2010, at 6:01 PM, David Christensen wrote:



On Jan 19, 2010, at 4:23 PM, Robert Haas wrote:

On Tue, Jan 19, 2010 at 5:14 PM, David E. Wheeler > wrote:
Why would they want more? It's not MySQL, and they know that. If  
we give them some very minor helpful hints for the most common  
things they try to do, it would be a huge benefit to them. I know  
I've badly wanted the opposite when I've had to use MySQL, but I  
don't expect MySQL to implement \c for me.


+1.  I think this is a well-thought out proposal.  I like Tom's
suggestion upthread for how to handle \c.


I've attached a second revision of this patch incorporating the  
various feedback I've received.


Although the deadline for patches for 8.5 has supposedly already  
passed


Yeah, I realized this after I scratched my itch, and had just  
thought I would send to the list any way for after the CF; you can  
commit or bump as needed.  Patch enclosed as a context-diff  
attachment this time.



I also forgot to enclose the sample output in this version, based  
largely on Tom's wording for the USE usecase:



machack:machack:5432=# show tables

Perhaps you want "\dt"?
See \? for help with psql commands

[Tue Jan 19 18:04:50 CST 2010]
machack:machack:5432=# use database;

Perhaps you want "\c database" or "set search_path = schema"?
See \? for help with psql commands

[Tue Jan 19 18:05:07 CST 2010]
machack:machack:5432=#


Regards,

David
--
David Christensen
End Point Corporation
da...@endpoint.com





--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] Patch rev 2: MySQL-ism help patch for psql

2010-01-19 Thread David Christensen


On Jan 19, 2010, at 4:23 PM, Robert Haas wrote:

On Tue, Jan 19, 2010 at 5:14 PM, David E. Wheeler > wrote:
Why would they want more? It's not MySQL, and they know that. If we  
give them some very minor helpful hints for the most common things  
they try to do, it would be a huge benefit to them. I know I've  
badly wanted the opposite when I've had to use MySQL, but I don't  
expect MySQL to implement \c for me.


+1.  I think this is a well-thought out proposal.  I like Tom's
suggestion upthread for how to handle \c.


I've attached a second revision of this patch incorporating the  
various feedback I've received.


Although the deadline for patches for 8.5 has supposedly already  
passed


Yeah, I realized this after I scratched my itch, and had just thought  
I would send to the list any way for after the CF; you can commit or  
bump as needed.  Patch enclosed as a context-diff attachment this time.


Regards,

David
--
David Christensen
End Point Corporation
da...@endpoint.com



mysql-help.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers