Re: [HACKERS] Re: [Pg-migrator-general] Composite types break pg_migratedtables

2009-08-06 Thread Kevin Grittner
Andrew Dunstan and...@dunslane.net wrote:
 
 Excluding every database that has a composite/array-of 
 user-defined-type/enum type would be pretty nasty. After all, these
 are features we boast of.
 
Any idea whether domains are an issue?  I was thinking of trying this
tool soon, and we don't seem to be using any of the problem features
-- unless type issues include domains.
 
-Kevin

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Re: [Pg-migrator-general] Composite types break pg_migratedtables

2009-08-06 Thread Andrew Dunstan



Kevin Grittner wrote:

Andrew Dunstan and...@dunslane.net wrote:
 
  
Excluding every database that has a composite/array-of 
user-defined-type/enum type would be pretty nasty. After all, these

are features we boast of.

 
Any idea whether domains are an issue?  I was thinking of trying this

tool soon, and we don't seem to be using any of the problem features
-- unless type issues include domains.
 

  


I don't believe that they are an issue. The issue arises only when a 
catalog oid is used in the on-disk representation of a type. AFAIK the 
on-disk representation of a domain is the same as its base type.


cheers

andrew

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


Re: [HACKERS] Re: [Pg-migrator-general] Composite types break pg_migratedtables

2009-08-06 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes:
 Kevin Grittner wrote:
 Any idea whether domains are an issue?

 I don't believe that they are an issue. The issue arises only when a 
 catalog oid is used in the on-disk representation of a type. AFAIK the 
 on-disk representation of a domain is the same as its base type.

Arrays of domains would be a problem, if we had 'em, which we don't...

Also, as Peter already noted, arrays of built-in types are not really a
problem because the OID won't have changed since 8.3.  It's only arrays
of types created post-initdb that are risk factors.

regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers