Re: [HACKERS] commitfest.postgresql.org
Peter Eisentraut wrote: > On Saturday 04 July 2009 01:19:23 Joshua D. Drake wrote: >> a button says, "I am about to perform X". >> A link *always* says, "I am about to go to a new web page". > > That was my feeling. In addition, if the action will be preceded by a dialog (for options or confirmation) the button text should end with '...'. -Kevin -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] commitfest.postgresql.org
On Jul 4, 2009, at 5:18 PM, Dimitri Fontaine wrote: Le 5 juil. 09 à 00:13, Peter Eisentraut a écrit : On Saturday 04 July 2009 01:19:23 Joshua D. Drake wrote: Not arguing one way or the other, a button says, "I am about to perform X". A link *always* says, "I am about to go to a new web page". That was my feeling. And bots (google etc) will follow links. They won't log in, though. :-) Someone want to write a patch, then? ..Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] commitfest.postgresql.org
Le 5 juil. 09 à 00:13, Peter Eisentraut a écrit : On Saturday 04 July 2009 01:19:23 Joshua D. Drake wrote: Not arguing one way or the other, a button says, "I am about to perform X". A link *always* says, "I am about to go to a new web page". That was my feeling. And bots (google etc) will follow links. -- dim -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] commitfest.postgresql.org
On Saturday 04 July 2009 01:19:23 Joshua D. Drake wrote: > On Fri, 2009-07-03 at 17:57 -0400, Robert Haas wrote: > > I guess I'm not really seeing why that particular thing should be a > > button rather than a link. It would mess up the formatting for no > > obvious benefit. > > Not arguing one way or the other, a button says, "I am about to perform > X". A link *always* says, "I am about to go to a new web page". That was my feeling. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] commitfest.postgresql.org
On Fri, Jul 3, 2009 at 4:43 PM, Peter Eisentraut wrote: > On Friday 03 July 2009 07:57:35 Robert Haas wrote: >> We're still hacking on a few other details of the formatting and >> interface, but you might want to cruise over and have a look. > > One thing that I noticed it that it takes too many clicks in general to make a > set of changes. When I look at a patch, why not have the controls to add a > comment and make changes right there, instead of on another page? For > instance, the functionality of > > action/patch_view?id=69 > action/patch_comment_form?patch=69 > action/patch_form?id=69 > action/patch_bump?id=69 > > could all be on the same page. Well, I've added the comment form to that page, by request, but I don't see how you could fit the rest on there in any sort of sane way. But I'm accepting patches... ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] commitfest.postgresql.org
On Fri, Jul 3, 2009 at 6:19 PM, Joshua D. Drake wrote: > On Fri, 2009-07-03 at 17:57 -0400, Robert Haas wrote: > >> I guess I'm not really seeing why that particular thing should be a >> button rather than a link. It would mess up the formatting for no >> obvious benefit. >> > > Not arguing one way or the other, a button says, "I am about to perform > X". A link *always* says, "I am about to go to a new web page". Hmm, there is some truth to what you say. I guess the way I think about it, a button says "I am about to submit this form" and a link says "I am about to do something other than submit a form". But it's certainly an arguable point. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] commitfest.postgresql.org
On Fri, 2009-07-03 at 17:57 -0400, Robert Haas wrote: > I guess I'm not really seeing why that particular thing should be a > button rather than a link. It would mess up the formatting for no > obvious benefit. > Not arguing one way or the other, a button says, "I am about to perform X". A link *always* says, "I am about to go to a new web page". Joshua D. Drake > ...Robert > -- PostgreSQL - XMPP: jdr...@jabber.postgresql.org Consulting, Development, Support, Training 503-667-4564 - http://www.commandprompt.com/ The PostgreSQL Company, serving since 1997 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] commitfest.postgresql.org
On Fri, Jul 3, 2009 at 5:49 PM, Joshua D. Drake wrote: > On Fri, 2009-07-03 at 16:54 -0400, Tom Lane wrote: >> Peter Eisentraut writes: >> > And please make "Delete Patch" into a button instead of a link. >> >> Only if there's some kind of confirmation ... > > Should we actually delete patches? I get removing them from the list but > it seems there could be benefit from keeping patches that are not > "quite" there or perhaps present an idea that is ahead of its time (or > half baked but interesting in genera?). > > +1 on the confirmation regardless. There is a confirmation right now, plus it doesn't work at all unless you delete all the comments first, which you can't do either unless you are an administrator or the only person who has ever commented on the patch. Really, deleting patches should be quite rare and only needed in cases where the patch should not have been added in the first place. I guess I'm not really seeing why that particular thing should be a button rather than a link. It would mess up the formatting for no obvious benefit. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] commitfest.postgresql.org
On Fri, 2009-07-03 at 16:54 -0400, Tom Lane wrote: > Peter Eisentraut writes: > > And please make "Delete Patch" into a button instead of a link. > > Only if there's some kind of confirmation ... Should we actually delete patches? I get removing them from the list but it seems there could be benefit from keeping patches that are not "quite" there or perhaps present an idea that is ahead of its time (or half baked but interesting in genera?). +1 on the confirmation regardless. Joshua D. Drake > > regards, tom lane > -- PostgreSQL - XMPP: jdr...@jabber.postgresql.org Consulting, Development, Support, Training 503-667-4564 - http://www.commandprompt.com/ The PostgreSQL Company, serving since 1997 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] commitfest.postgresql.org
Peter Eisentraut writes: > And please make "Delete Patch" into a button instead of a link. Only if there's some kind of confirmation ... regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] commitfest.postgresql.org
On Friday 03 July 2009 07:57:35 Robert Haas wrote: > We're still hacking on a few other details of the formatting and > interface, but you might want to cruise over and have a look. One thing that I noticed it that it takes too many clicks in general to make a set of changes. When I look at a patch, why not have the controls to add a comment and make changes right there, instead of on another page? For instance, the functionality of action/patch_view?id=69 action/patch_comment_form?patch=69 action/patch_form?id=69 action/patch_bump?id=69 could all be on the same page. And please make "Delete Patch" into a button instead of a link. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] commitfest.postgresql.org
Per Dave Page's request of this morning, my CommitFest management application now has a real hostname (see subject line). I have also sent Dave an email with details of the install process and location of files, per his request (let me know if there's somewhere else those details should be posted). Brendan Jurd has graciously migrated all of the data from the CommitFest wiki page to the app by writing a script to parse the wiki markup and inserting the resulting data directly into the database. There are a few loose ends. The application stamps comments with the community login of the person who left them, but the import stamped them with names instead. This is actually of some significance, since the app will allow you to edit your own comments but not those of other people. We could probably fix this if someone can give us access to (or a dump of) the realname to username mappings from the community login DB. Also, we're currently missing the reviewer names due to limitations of the import script; Brendan is fixing this. Filling the DB with live data revealed a few warts. In particular, the original ordering of patches was alpha by topic and then alpha by name, which I thought would be OK, but upon seeing how it really looked, I hated it. So the topic manager now lets you set a sort order for commitfest topics, and the order is now numeric by topic sortorder, then alpha by topic, then by ascending patch ID (so the oldest patch comes up first within each topic section). Also, I originally had the topics displayed as a table column, but that didn't really work for me once I saw it either, so it's been reorganized to do it the same way the wiki does. We're still hacking on a few other details of the formatting and interface, but you might want to cruise over and have a look. Please however continue to make ALL CHANGES on the wiki, and not in the app. Brendan is going to manually move changes over to the new system incrementally until we get the kinks worked out. I think we're close, but we're not quite there yet. As a reminder, if you'd like to review or submit patches against the source, you can find it here: http://git.postgresql.org/gitweb?p=pgcommitfest.git;a=summary git://git.postgresql.org/git/pgcommitfest.git ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
