Re: [HACKERS] patch to fix unused variable warning on windows build
On Thu, 2013-11-07 at 19:13 +1300, David Rowley wrote: Attached is a small patch which fixes the unused variable warning in the visual studios build. Seems like VS does not support __attribute__((unused)) but looks like all other places we must assign to the variable. committed -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] patch to fix unused variable warning on windows build
On Sat, Nov 9, 2013 at 1:00 PM, David Rowley dgrowle...@gmail.com wrote: On Sat, Nov 9, 2013 at 7:29 PM, Amit Kapila amit.kapil...@gmail.com wrote: Thanks for the link. The reason that we don't see more warnings for this is that it seems in all other places where we have used PG_USED_FOR_ASSERTS_ONLY, the variable is getting assigned to every time, though it will only be when compiled in debug that the variable is checked. It seems microsoft decided to disable warnings for assigned but not used for pretty much this reason. http://stackoverflow.com/questions/10593547/why-is-no-warning-given-for-this-unused-variable Microsoft explain that it's because they had lots of complaints from people who were assigning variables purely so they could see what a method call returned during debugging, and found the warning irritating: So I guess fixing up PG_USED_FOR_ASSERTS_ONLY to work with visual studios is not required and my patch seems like the fix for this unique case. You are right that for this case it is sufficient to fix it the way you have done in patch. However it might be the case that here expectation is to provide a generic solution for such kind of warnings (as it doesn't occur on linux or other OS) so that in future such a case should not arise. I think it is good, if one of committer's who have windows env. can look into it and commit or provide suggestions, else you can make a combined patch of this and other warning you saw on windows and upload to next CF so that it doesn't get lost. I checked that you have already submitted a patch for this warning alone in CF. I was not quite sure what I should do for these tiny patches. Quite often if a committer happens to read the post and agrees with the patch then it might get committed pretty quickly even outside a commitfest, but if not then if I didn't add to the commitfest then it would likely get lost. You have done the right thing. With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] patch to fix unused variable warning on windows build
On Thu, Nov 7, 2013 at 11:43 AM, David Rowley dgrowle...@gmail.com wrote: Attached is a small patch which fixes the unused variable warning in the visual studios build. Seems like VS does not support __attribute__((unused)) but looks like all other places we must assign to the variable. I have raised same issue some time back, see the below link where there is some discussion about it. http://www.postgresql.org/message-id/caa4ek1jeoa1hjgauwpcqhw8av7zapkdxjdwubwetjomi2f8...@mail.gmail.com I think it is good, if one of committer's who have windows env. can look into it and commit or provide suggestions, else you can make a combined patch of this and other warning you saw on windows and upload to next CF so that it doesn't get lost. I checked that you have already submitted a patch for this warning alone in CF. With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
Re: [HACKERS] patch to fix unused variable warning on windows build
On Sat, Nov 9, 2013 at 7:29 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Thu, Nov 7, 2013 at 11:43 AM, David Rowley dgrowle...@gmail.com wrote: Attached is a small patch which fixes the unused variable warning in the visual studios build. Seems like VS does not support __attribute__((unused)) but looks like all other places we must assign to the variable. I have raised same issue some time back, see the below link where there is some discussion about it. http://www.postgresql.org/message-id/caa4ek1jeoa1hjgauwpcqhw8av7zapkdxjdwubwetjomi2f8...@mail.gmail.com Thanks for the link. The reason that we don't see more warnings for this is that it seems in all other places where we have used PG_USED_FOR_ASSERTS_ONLY, the variable is getting assigned to every time, though it will only be when compiled in debug that the variable is checked. It seems microsoft decided to disable warnings for assigned but not used for pretty much this reason. http://stackoverflow.com/questions/10593547/why-is-no-warning-given-for-this-unused-variable Microsoft explain that it's because they had lots of complaints from people who were assigning variables purely so they could see what a method call returned during debugging, and found the warning irritating: So I guess fixing up PG_USED_FOR_ASSERTS_ONLY to work with visual studios is not required and my patch seems like the fix for this unique case. I think it is good, if one of committer's who have windows env. can look into it and commit or provide suggestions, else you can make a combined patch of this and other warning you saw on windows and upload to next CF so that it doesn't get lost. I checked that you have already submitted a patch for this warning alone in CF. I was not quite sure what I should do for these tiny patches. Quite often if a committer happens to read the post and agrees with the patch then it might get committed pretty quickly even outside a commitfest, but if not then if I didn't add to the commitfest then it would likely get lost. Regards David Rowley With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
[HACKERS] patch to fix unused variable warning on windows build
Attached is a small patch which fixes the unused variable warning in the visual studios build. Seems like VS does not support __attribute__((unused)) but looks like all other places we must assign to the variable. Regards David Rowley unused_variable.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
