Re: [Pharo-dev] Help with reviewing needed

2013-09-23 Thread Camillo Bruni
> Le 23/09/2013 17:27, Camillo Bruni a écrit :
 => review the changes
 => leave feedback in the issue tracker
- positive => set the status to "Fix to Include"
- negative => set the status to "Work Needed"
>>> 
>>> I'm not allowed to set the status to "Work Needed" (I'm looking at 11628), 
>>> so maybe reviewing is not for everybody on the mailing-list?
>> 
>> Did you click on "resolve" / "edit"?
>> 
> I did, but in fact I needed to click on "Reactivate" :)

ah yes, sorry :), I a thought about the wrong status...


signature.asc
Description: Message signed with OpenPGP using GPGMail


Re: [Pharo-dev] Help with reviewing needed

2013-09-23 Thread Goubier Thierry



Le 23/09/2013 17:27, Camillo Bruni a écrit :

=> review the changes
=> leave feedback in the issue tracker
- positive => set the status to "Fix to Include"
- negative => set the status to "Work Needed"


I'm not allowed to set the status to "Work Needed" (I'm looking at 11628), so 
maybe reviewing is not for everybody on the mailing-list?


Did you click on "resolve" / "edit"?


I did, but in fact I needed to click on "Reactivate" :)

Thierry
--
Thierry Goubier
CEA list
Laboratoire des Fondations des Systèmes Temps Réel Embarqués
91191 Gif sur Yvette Cedex
France
Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95



Re: [Pharo-dev] Help with reviewing needed

2013-09-23 Thread Goubier Thierry



Le 23/09/2013 17:25, Stéphane Ducasse a écrit :


On Sep 23, 2013, at 5:23 PM, Goubier Thierry  wrote:




Le 23/09/2013 17:11, Camillo Bruni a écrit :

These are all cases with the status "Fix Review Needed"

=> load the changes in a fresh 3.0 image


Some of the fixes are for 2.0 :)


=> review the changes
=> leave feedback in the issue tracker
- positive => set the status to "Fix to Include"
- negative => set the status to "Work Needed"


I'm not allowed to set the status to "Work Needed" (I'm looking at 11628), so 
maybe reviewing is not for everybody on the mailing-list?


Strange, you have a fogbugz account I imagine so in that case I do not 
understand anything. Because normally we all can tag entries.


Me not understanding I need to reactivate the issue :( to be able to set 
it to Work needed :) Sort of done :)


Thierry
--
Thierry Goubier
CEA list
Laboratoire des Fondations des Systèmes Temps Réel Embarqués
91191 Gif sur Yvette Cedex
France
Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95



Re: [Pharo-dev] Help with reviewing needed

2013-09-23 Thread Camillo Bruni
>> => review the changes
>> => leave feedback in the issue tracker
>>  - positive => set the status to "Fix to Include"
>>  - negative => set the status to "Work Needed"
> 
> I'm not allowed to set the status to "Work Needed" (I'm looking at 11628), so 
> maybe reviewing is not for everybody on the mailing-list?

Did you click on "resolve" / "edit"?



signature.asc
Description: Message signed with OpenPGP using GPGMail


Re: [Pharo-dev] Help with reviewing needed

2013-09-23 Thread Stéphane Ducasse

On Sep 23, 2013, at 5:23 PM, Goubier Thierry  wrote:

> 
> 
> Le 23/09/2013 17:11, Camillo Bruni a écrit :
>> These are all cases with the status "Fix Review Needed"
>> 
>> => load the changes in a fresh 3.0 image
> 
> Some of the fixes are for 2.0 :)
> 
>> => review the changes
>> => leave feedback in the issue tracker
>>  - positive => set the status to "Fix to Include"
>>  - negative => set the status to "Work Needed"
> 
> I'm not allowed to set the status to "Work Needed" (I'm looking at 11628), so 
> maybe reviewing is not for everybody on the mailing-list?

Strange, you have a fogbugz account I imagine so in that case I do not 
understand anything. Because normally we all can tag entries.

> 
> Thierry
> 
>> On 2013-09-23, at 12:02, "p...@highoctane.be"  wrote:
>> 
>>> These are all closed things in Inbox.
>>> 
>>> What's the help about?
>>> 
>>> Phil
>>> 
>>> 
>>> 
>>> On Mon, Sep 23, 2013 at 4:08 PM, Marcus Denker 
>>> wrote:
>>> 
 Hi,
 
 It would really be helpful if more people would review:
 
https://pharo.fogbugz.com/f/filters/36/Review
 
 because if it has to wait for me, it might wait for a very long time.
 
Marcus
 
>> 
> 
> -- 
> Thierry Goubier
> CEA list
> Laboratoire des Fondations des Systèmes Temps Réel Embarqués
> 91191 Gif sur Yvette Cedex
> France
> Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95
> 




Re: [Pharo-dev] Help with reviewing needed

2013-09-23 Thread p...@highoctane.be
These are all closed things in Inbox.

What's the help about?

Phil



On Mon, Sep 23, 2013 at 4:08 PM, Marcus Denker wrote:

> Hi,
>
> It would really be helpful if more people would review:
>
> https://pharo.fogbugz.com/f/filters/36/Review
>
> because if it has to wait for me, it might wait for a very long time.
>
> Marcus
>


Re: [Pharo-dev] Help with reviewing needed

2013-09-23 Thread Camillo Bruni
These are all cases with the status "Fix Review Needed"

=> load the changes in a fresh 3.0 image
=> review the changes
=> leave feedback in the issue tracker
- positive => set the status to "Fix to Include"
- negative => set the status to "Work Needed"

On 2013-09-23, at 12:02, "p...@highoctane.be"  wrote:

> These are all closed things in Inbox.
> 
> What's the help about?
> 
> Phil
> 
> 
> 
> On Mon, Sep 23, 2013 at 4:08 PM, Marcus Denker wrote:
> 
>> Hi,
>> 
>> It would really be helpful if more people would review:
>> 
>>https://pharo.fogbugz.com/f/filters/36/Review
>> 
>> because if it has to wait for me, it might wait for a very long time.
>> 
>>Marcus
>> 



signature.asc
Description: Message signed with OpenPGP using GPGMail


Re: [Pharo-dev] Help with reviewing needed

2013-09-23 Thread Goubier Thierry



Le 23/09/2013 17:11, Camillo Bruni a écrit :

These are all cases with the status "Fix Review Needed"

=> load the changes in a fresh 3.0 image


Some of the fixes are for 2.0 :)


=> review the changes
=> leave feedback in the issue tracker
- positive => set the status to "Fix to Include"
- negative => set the status to "Work Needed"


I'm not allowed to set the status to "Work Needed" (I'm looking at 
11628), so maybe reviewing is not for everybody on the mailing-list?


Thierry


On 2013-09-23, at 12:02, "p...@highoctane.be"  wrote:


These are all closed things in Inbox.

What's the help about?

Phil



On Mon, Sep 23, 2013 at 4:08 PM, Marcus Denker wrote:


Hi,

It would really be helpful if more people would review:

https://pharo.fogbugz.com/f/filters/36/Review

because if it has to wait for me, it might wait for a very long time.

Marcus





--
Thierry Goubier
CEA list
Laboratoire des Fondations des Systèmes Temps Réel Embarqués
91191 Gif sur Yvette Cedex
France
Phone/Fax: +33 (0) 1 69 08 32 92 / 83 95



[Pharo-dev] Help with reviewing needed

2013-09-23 Thread Marcus Denker
Hi,

It would really be helpful if more people would review:

https://pharo.fogbugz.com/f/filters/36/Review

because if it has to wait for me, it might wait for a very long time.

Marcus


signature.asc
Description: Message signed with OpenPGP using GPGMail