Re: [Pharo-users] (MimeConverter forEncoding: 'quoted-printable') subclass responsibility
Hi Sven, thanks for porting this and making it available. I will re-integrate your improvements in the VAST code if that's okay with you. Hey, and I am now (very indirectly) a Pharo contributor, how cool! ;-))) Joachim Am 08.12.13 23:49, schrieb Sven Van Caekenberghe: On 08 Dec 2013, at 19:51, Sven Van Caekenberghe s...@stfx.eu wrote: Next I will actually move your code to the instance side of QuotedPrintableMimeConverter, the class where we actually need it. I am sure I can take over your units tests as they are, which is good. Done: https://pharo.fogbugz.com/f/cases/4825/Quoted-printable-encoding-incomplete RESOLVED Slice in 3.0 inbox: === Name: SLICE-Issue-4825-Quoted-printable-encoding-incomplete-SvenVanCaekenberghe.1 Author: SvenVanCaekenberghe Time: 8 December 2013, 11:45:09.148454 pm UUID: af015099-e48b-47f5-9553-840fca62d8e2 Ancestors: Dependencies: Network-MIME-SvenVanCaekenberghe.64, NetworkTests-SvenVanCaekenberghe.92 A completely new implementation of QuotedPrintableMimeConverter based on code contributed by Joachim Tuchel (thanks !) including a new set of unit tests. Note that the older code lacked the encoding part and had no tests at all. === Sven -- --- Objektfabrik Joachim Tuchel mailto:jtuc...@objektfabrik.de Fliederweg 1 http://www.objektfabrik.de D-71640 Ludwigsburg http://joachimtuchel.wordpress.com Telefon: +49 7141 56 10 86 0 Fax: +49 7141 56 10 86 1
Re: [Pharo-users] (MimeConverter forEncoding: 'quoted-printable') subclass responsibility
Joachim, On 09 Dec 2013, at 11:09, jtuc...@objektfabrik.de wrote: Hi Sven, thanks for porting this and making it available. I will re-integrate your improvements in the VAST code if that's okay with you. Yes, please do, that is the least we could do back. All Pharo code is MIT licensed. Hey, and I am now (very indirectly) a Pharo contributor, how cool! ;-))) And the code is already part of Pharo 3.0 (it went through the whole process with automatic validation by the CI system and finally integration): One way to see the changes is via github https://github.com/pharo-project/pharo-core/commit/76bf0c7bf67d5ce70f6b704375f7fa37172061ef So if you download Pharo 3.0 today should get a version 30633 or later. You’ll find your code in QuotedPrintableMimeConverter[Tests]. Thanks again ! Regards, Sven Joachim Am 08.12.13 23:49, schrieb Sven Van Caekenberghe: On 08 Dec 2013, at 19:51, Sven Van Caekenberghe s...@stfx.eu wrote: Next I will actually move your code to the instance side of QuotedPrintableMimeConverter, the class where we actually need it. I am sure I can take over your units tests as they are, which is good. Done: https://pharo.fogbugz.com/f/cases/4825/Quoted-printable-encoding-incomplete RESOLVED Slice in 3.0 inbox: === Name: SLICE-Issue-4825-Quoted-printable-encoding-incomplete-SvenVanCaekenberghe.1 Author: SvenVanCaekenberghe Time: 8 December 2013, 11:45:09.148454 pm UUID: af015099-e48b-47f5-9553-840fca62d8e2 Ancestors: Dependencies: Network-MIME-SvenVanCaekenberghe.64, NetworkTests-SvenVanCaekenberghe.92 A completely new implementation of QuotedPrintableMimeConverter based on code contributed by Joachim Tuchel (thanks !) including a new set of unit tests. Note that the older code lacked the encoding part and had no tests at all. === Sven -- --- Objektfabrik Joachim Tuchel mailto:jtuc...@objektfabrik.de Fliederweg 1 http://www.objektfabrik.de D-71640 Ludwigsburg http://joachimtuchel.wordpress.com Telefon: +49 7141 56 10 86 0 Fax: +49 7141 56 10 86 1
Re: [Pharo-users] (MimeConverter forEncoding: 'quoted-printable') subclass responsibility
Hi Joachim, hi Sven, thank yor very much for your work! I am looking forward to use Pharo 3.0 next year. :-) Sabine On Mon, Dec 9, 2013 at 11:11 AM, jtuchel [via Smalltalk] ml-node+s1294792n4728698...@n4.nabble.com wrote: Hi Sven, thanks for porting this and making it available. I will re-integrate your improvements in the VAST code if that's okay with you. Hey, and I am now (very indirectly) a Pharo contributor, how cool! ;-))) Joachim Am 08.12.13 23:49, schrieb Sven Van Caekenberghe: On 08 Dec 2013, at 19:51, Sven Van Caekenberghe [hidden email]http://user/SendEmail.jtp?type=nodenode=4728698i=0 wrote: Next I will actually move your code to the instance side of QuotedPrintableMimeConverter, the class where we actually need it. I am sure I can take over your units tests as they are, which is good. Done: https://pharo.fogbugz.com/f/cases/4825/Quoted-printable-encoding-incomplete RESOLVED Slice in 3.0 inbox: === Name: SLICE-Issue-4825-Quoted-printable-encoding-incomplete-SvenVanCaekenberghe.1 Author: SvenVanCaekenberghe Time: 8 December 2013, 11:45:09.148454 pm UUID: af015099-e48b-47f5-9553-840fca62d8e2 Ancestors: Dependencies: Network-MIME-SvenVanCaekenberghe.64, NetworkTests-SvenVanCaekenberghe.92 A completely new implementation of QuotedPrintableMimeConverter based on code contributed by Joachim Tuchel (thanks !) including a new set of unit tests. Note that the older code lacked the encoding part and had no tests at all. === Sven -- --- Objektfabrik Joachim Tuchel mailto:[hidden email]http://user/SendEmail.jtp?type=nodenode=4728698i=1 Fliederweg 1 http://www.objektfabrik.de D-71640 Ludwigsburg http://joachimtuchel.wordpress.com Telefon: +49 7141 56 10 86 0 Fax: +49 7141 56 10 86 1 -- If you reply to this email, your message will be added to the discussion below: http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4728698.html To start a new topic under Pharo Smalltalk Users, email ml-node+s1294792n1310670...@n4.nabble.com To unsubscribe from (MimeConverter forEncoding: 'quoted-printable') subclass responsibility, click herehttp://forum.world.st/template/NamlServlet.jtp?macro=unsubscribe_by_codenode=4727895code=c2FiaW5lLmtub2VmZWxAZ21haWwuY29tfDQ3Mjc4OTV8MTA0OTM5MTYx . NAMLhttp://forum.world.st/template/NamlServlet.jtp?macro=macro_viewerid=instant_html%21nabble%3Aemail.namlbase=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespacebreadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml -- View this message in context: http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4728721.html Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com.
Re: [Pharo-users] (MimeConverter forEncoding: 'quoted-printable') subclass responsibility
On 09 Dec 2013, at 12:34, Sabine Knöfel sabine.knoe...@gmail.com wrote: Hi Joachim, hi Sven, thank yor very much for your work! I am looking forward to use Pharo 3.0 next year. :-) If you need this code earlier, I see no reason why you should not be able to file out the QuotedPrintableMimeConverter[Tests] classes from 3.0 and file them in in 2.0 - there are no dependencies as far as I can see. Maybe this could even be officially back ported to 2.0. Sabine On Mon, Dec 9, 2013 at 11:11 AM, jtuchel [via Smalltalk] [hidden email] wrote: Hi Sven, thanks for porting this and making it available. I will re-integrate your improvements in the VAST code if that's okay with you. Hey, and I am now (very indirectly) a Pharo contributor, how cool! ;-))) Joachim Am a href=tel:08.12.13%2023 value=+498121323 target=_blank08.12.13 23:49, schrieb Sven Van Caekenberghe: On 08 Dec 2013, at 19:51, Sven Van Caekenberghe [hidden email] wrote: Next I will actually move your code to the instance side of QuotedPrintableMimeConverter, the class where we actually need it. I am sure I can take over your units tests as they are, which is good. Done: https://pharo.fogbugz.com/f/cases/4825/Quoted-printable-encoding-incomplete RESOLVED Slice in 3.0 inbox: === Name: SLICE-Issue-4825-Quoted-printable-encoding-incomplete-SvenVanCaekenberghe.1 Author: SvenVanCaekenberghe Time: 8 December 2013, 11:45:a href=tel:09.148454 value=+499148454 target=_blank09.148454 pm UUID: af015099-e48b-47f5-9553-840fca62d8e2 Ancestors: Dependencies: Network-MIME-SvenVanCaekenberghe.64, NetworkTests-SvenVanCaekenberghe.92 A completely new implementation of QuotedPrintableMimeConverter based on code contributed by Joachim Tuchel (thanks !) including a new set of unit tests. Note that the older code lacked the encoding part and had no tests at all. === Sven -- --- Objektfabrik Joachim Tuchel mailto:[hidden email] Fliederweg 1 http://www.objektfabrik.de D-71640 Ludwigsburg http://joachimtuchel.wordpress.com Telefon: a href=tel:%2B49%207141%2056%2010%2086%200 value=+4971415610860 target=_blank+49 7141 56 10 86 0 Fax: a href=tel:%2B49%207141%2056%2010%2086%201 value=+4971415610861 target=_blank+49 7141 56 10 86 1 If you reply to this email, your message will be added to the discussion below: http://forum.world.st/MimeConverter-forEncoding-quoted-printable-subclass-responsibility-tp4727895p4728698.html To start a new topic under Pharo Smalltalk Users, email [hidden email] To unsubscribe from (MimeConverter forEncoding: 'quoted-printable') subclass responsibility, click here. NAML View this message in context: Re: (MimeConverter forEncoding: 'quoted-printable') subclass responsibility Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com.
