Re: [Pharo-users] Multiple method deletion

[stepharo]

I have to think a bit (and read some code :).
Stef

Le 29/10/15 09:48, Ferlicot D. Cyril a écrit :

Le 29/10/2015 16:33, stepharo a écrit :

Excellent news!


Hi,

I think I found how to reproduce it:

https://pharo.fogbugz.com/f/cases/16891/FT-Multi-selection-can-happen-when-it-should-not


I think this is a FastTable problem with Nautilus.




The problem is that when we try to remove something, the MethodsWidget
give the selected methods.
These methods are store inside an identityDictonary with the
CompiledMethod as key and a boolean as value.

Usually that works but when we compile a method a new instance of
CompiledMethod is store on the dictionary. So with the identity
dictionary we now have two elements for the same method since the
pointers are not the same.

Does someone know if it is important that the selected methods of the
MethodWidget are store on an IdentityDictionary and not in a Dictionary ?

If this is not important we can change it, else at the compilation we
will need to remove this method from the IdentityDictionary.

Re: [Pharo-users] Multiple method deletion

[Ferlicot D. Cyril]

Le 29/10/2015 16:33, stepharo a écrit :
> Excellent news!
> 
>> Hi,
>>
>> I think I found how to reproduce it:
>>
>> https://pharo.fogbugz.com/f/cases/16891/FT-Multi-selection-can-happen-when-it-should-not
>>
>>
>> I think this is a FastTable problem with Nautilus.
>>
> 
> 

The problem is that when we try to remove something, the MethodsWidget
give the selected methods.
These methods are store inside an identityDictonary with the
CompiledMethod as key and a boolean as value.

Usually that works but when we compile a method a new instance of
CompiledMethod is store on the dictionary. So with the identity
dictionary we now have two elements for the same method since the
pointers are not the same.

Does someone know if it is important that the selected methods of the
MethodWidget are store on an IdentityDictionary and not in a Dictionary ?

If this is not important we can change it, else at the compilation we
will need to remove this method from the IdentityDictionary.

-- 

Cyril Ferlicot

http://www.synectique.eu

165 Avenue Bretagne
Lille 59000 France



signature.asc
Description: OpenPGP digital signature

Re: [Pharo-users] Multiple method deletion

[stepharo]

Excellent news!


Le 29/10/15 10:18, Ferlicot D. Cyril a écrit :

Le 09/10/2015 16:44, Alexandre Bergel a écrit :

Hi!

When I select several methods in Nautilus, and press cmd-m-x it seems to
delete more method that I have selected. It makes me lose code :-(

Cheers,
Alexandre
--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.




Hi,

I think I found how to reproduce it:

https://pharo.fogbugz.com/f/cases/16891/FT-Multi-selection-can-happen-when-it-should-not

I think this is a FastTable problem with Nautilus.

Re: [Pharo-users] Multiple method deletion

[Ferlicot D. Cyril]

Le 09/10/2015 16:44, Alexandre Bergel a écrit :
> Hi!
> 
> When I select several methods in Nautilus, and press cmd-m-x it seems to
> delete more method that I have selected. It makes me lose code :-(
> 
> Cheers,
> Alexandre
> -- 
> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
> Alexandre Bergel  http://www.bergel.eu
> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
> 
> 
> 

Hi,

I think I found how to reproduce it:

https://pharo.fogbugz.com/f/cases/16891/FT-Multi-selection-can-happen-when-it-should-not

I think this is a FastTable problem with Nautilus.

-- 

Cyril Ferlicot

http://www.synectique.eu

165 Avenue Bretagne
Lille 59000 France



signature.asc
Description: OpenPGP digital signature

Re: [Pharo-users] Multiple method deletion

[Hilaire]

Le 10/10/2015 20:47, stepharo a écrit :
> Yes I understand but with Pharo 30 and 40 I did not get this feeling.
> Also introducing package and tag makes things more complex.
> and I was talking about Pharo 50.
Yes. I have issues from time to time with 30.
> I think that we will have probably some glitches because we cleaned a
> lot of code.
> And we will have to do another pass.
> I think that as a community we should report and help us to fix all
> the tools glitches.
I reported several and try to look at. It is hard to see how these
situations evolves, because an application development cycle does not
follow the Pharo one (for example Dr.Geo is still based to Pharo3)

Hilaire

-- 
Dr. Geo
http://drgeo.eu
http://google.com/+DrgeoEu

Re: [Pharo-users] Multiple method deletion

[stepharo]

Yes I understand but with Pharo 30 and 40 I did not get this feeling. 
Also introducing package and tag makes things more complex.

and I was talking about Pharo 50.
I think that we will have probably some glitches because we cleaned a 
lot of code.

And we will have to do another pass.
I think that as a community we should report and help us to fix all the 
tools glitches.


Stef


Le 10/10/15 11:35, Hilaire a écrit :

Le 10/10/2015 09:57, stepharo a écrit :

Are you sure?
Because I code daily with it and I never got this behavior.
I will try.
Hilaire I can tell you that we worked a lot to improve it.

Stef

This is how I fell it, and apparently other feel the same.
No doubt a lot of care is put into it, a reliable (or unreliable)
browser is the first things developpers notice.

Hilaire

Re: [Pharo-users] Multiple method deletion

[stepharo]

Le 10/10/15 12:38, Peter Uhnák a écrit :
I've been experiencing something similar, but I am using older Pharo 
( 50287 ) and I wasn't quite able to precisely observe the reason for 
the error. There the problem was that I deleted a method, but the 
previously selected method was actually deleted, so there were some 
selection inconsistencies... (so I just got into the habit of 
reselecting...)


Thanks this is interesting to spot the problem.

Stef


P

On Sat, Oct 10, 2015 at 11:35 AM, Hilaire > wrote:


Le 10/10/2015 09:57, stepharo a écrit :
> Are you sure?
> Because I code daily with it and I never got this behavior.
> I will try.
> Hilaire I can tell you that we worked a lot to improve it.
>
> Stef

This is how I fell it, and apparently other feel the same.
No doubt a lot of care is put into it, a reliable (or unreliable)
browser is the first things developpers notice.

Hilaire

--
Dr. Geo
http://drgeo.eu
http://google.com/+DrgeoEu

Re: [Pharo-users] Multiple method deletion

[stepharo]

Thanks cyril
I tried and I will try to reproduce it.
If this happens again please try to tell us

- was it when you removed one method?
- was it when you removed multiple methods?

Le 10/10/15 12:24, Ferlicot D. Cyril a écrit :

Le 10/10/2015 07:57, stepharo a écrit :

Are you sure?
Because I code daily with it and I never got this behavior.
I will try.
Hilaire I can tell you that we worked a lot to improve it.

Stef



I experienced it 4-5 times this week.

Re: [Pharo-users] Multiple method deletion

[Peter Uhnák]

I've been experiencing something similar, but I am using older Pharo
( 50287 ) and I wasn't quite able to precisely observe the reason for the
error. There the problem was that I deleted a method, but the previously
selected method was actually deleted, so there were some selection
inconsistencies... (so I just got into the habit of reselecting...)

P

On Sat, Oct 10, 2015 at 11:35 AM, Hilaire  wrote:

> Le 10/10/2015 09:57, stepharo a écrit :
> > Are you sure?
> > Because I code daily with it and I never got this behavior.
> > I will try.
> > Hilaire I can tell you that we worked a lot to improve it.
> >
> > Stef
>
> This is how I fell it, and apparently other feel the same.
> No doubt a lot of care is put into it, a reliable (or unreliable)
> browser is the first things developpers notice.
>
> Hilaire
>
> --
> Dr. Geo
> http://drgeo.eu
> http://google.com/+DrgeoEu
>
>
>
>

Re: [Pharo-users] Multiple method deletion

[Hilaire]

Le 10/10/2015 09:57, stepharo a écrit :
> Are you sure?
> Because I code daily with it and I never got this behavior.
> I will try.
> Hilaire I can tell you that we worked a lot to improve it.
>
> Stef

This is how I fell it, and apparently other feel the same.
No doubt a lot of care is put into it, a reliable (or unreliable)
browser is the first things developpers notice.

Hilaire

-- 
Dr. Geo
http://drgeo.eu
http://google.com/+DrgeoEu

Re: [Pharo-users] Multiple method deletion

[Ferlicot D. Cyril]

Le 10/10/2015 07:57, stepharo a écrit :
> Are you sure?
> Because I code daily with it and I never got this behavior.
> I will try.
> Hilaire I can tell you that we worked a lot to improve it.
> 
> Stef
> 
> 

I experienced it 4-5 times this week.

-- 

Cyril Ferlicot

http://www.synectique.eu

165 Avenue Bretagne
Lille 59000 France



signature.asc
Description: OpenPGP digital signature

Re: [Pharo-users] Multiple method deletion

[stepharo]

Are you sure?
Because I code daily with it and I never got this behavior.
I will try.
Hilaire I can tell you that we worked a lot to improve it.

Stef


Le 9/10/15 19:10, Alexandre Bergel a écrit :

Pharo 5, lastest version

Alexandre
--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.



On Oct 9, 2015, at 1:00 PM, Hilaire > wrote:


Which Pharo, Pharo4 ?
I loose confident in the Pharo class browser since mark 3. I hope it
will get better.

Hilaire

Le 09/10/2015 16:44, Alexandre Bergel a écrit :

Hi!

When I select several methods in Nautilus, and press cmd-m-x it seems
to delete more method that I have selected. It makes me lose code :-(

Cheers,
Alexandre
--
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.






--
Dr. Geo
http://drgeo.eu
http://google.com/+DrgeoEu

Re: [Pharo-users] Multiple method deletion

[Alexandre Bergel]

Pharo 5, lastest version

Alexandre
-- 
_,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
Alexandre Bergel  http://www.bergel.eu
^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.



> On Oct 9, 2015, at 1:00 PM, Hilaire  wrote:
> 
> Which Pharo, Pharo4 ?
> I loose confident in the Pharo class browser since mark 3. I hope it
> will get better.
> 
> Hilaire
> 
> Le 09/10/2015 16:44, Alexandre Bergel a écrit :
>> Hi!
>> 
>> When I select several methods in Nautilus, and press cmd-m-x it seems
>> to delete more method that I have selected. It makes me lose code :-(
>> 
>> Cheers,
>> Alexandre
>> -- 
>> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
>> Alexandre Bergel  http://www.bergel.eu
>> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>> 
>> 
>> 
> 
> 
> -- 
> Dr. Geo
> http://drgeo.eu
> http://google.com/+DrgeoEu
> 
> 
> 

Re: [Pharo-users] Multiple method deletion

[Hilaire]

Which Pharo, Pharo4 ?
I loose confident in the Pharo class browser since mark 3. I hope it
will get better.

Hilaire

Le 09/10/2015 16:44, Alexandre Bergel a écrit :
> Hi!
>
> When I select several methods in Nautilus, and press cmd-m-x it seems
> to delete more method that I have selected. It makes me lose code :-(
>
> Cheers,
> Alexandre
> -- 
> _,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:
> Alexandre Bergel  http://www.bergel.eu
> ^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;._,.;:~^~:;.
>
>
>


-- 
Dr. Geo
http://drgeo.eu
http://google.com/+DrgeoEu