Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/standard config.m4 css.ccss.h info.c /main php_ini.c /sapi/aolserver aolserver.c /sapi/apachephp_apache.c

2002-09-23 Thread Sebastian Bergmann 

Jani Taskinen wrote:
> It obviously is not compatible with current browsers as it
> is really ugly in IE and NS.

  Looks good here in IE

http://www.sebastian-bergmann.de/stuff/msie.jpg

  And Mozilla

http://www.sebastian-bergmann.de/stuff/mozilla.jpg

  So a *current* Netscape should look good, too, since it's based on
  Mozilla.

-- 
  Sebastian Bergmann
  http://sebastian-bergmann.de/ http://phpOpenTracker.de/

  Did I help you? Consider a gift: http://wishlist.sebastian-bergmann.de/

-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/standard config.m4 css.ccss.h info.c /main php_ini.c /sapi/aolserver aolserver.c /sapi/apachephp_apache.c

2002-09-23 Thread Jani Taskinen 

On Mon, 23 Sep 2002, Colin Viebrock wrote:

>generated, and moving to a CSS formatting model acheived that while
>still maintaining "compatability" for current browsers.

It obviously is not compatible with current browsers as it
is really ugly in IE and NS.

>My question back would be how many people here *really* care what the
>output looks like?  Is anyone making that info available in a production

Indeed, why did you have to change it? Just to get CSS in there?

>for debugging purposes by site developers, or other diagnostic reasons
>... in which case as long as the info is there and legible, I don't see
>the issue.

Exactly my point. Why did it have to be changed?

>However, if there are, then you can easily replace the stylesheet with
>your own style to "skin" the page ... something that would've been much

Only thing I'm gonna do is revert your patch..if you don't fix
the CSS to work with any browser, that is. I'm not gonna waste
my time on this thing more than doing that revert.

>If we want a truly cross-browser phpinfo() page, it should be text-only
>or plain, unformatted, uncoloured tables.

Yes please.

--Jani



-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: sticky perms in CVS?

2002-09-23 Thread Wez Furlong 

On 09/23/02, "Jim Winstead" <[EMAIL PROTECTED]> wrote:
> Wez Furlong <[EMAIL PROTECTED]> wrote:
> > Am I the only one who is getting their files chmod'ed to read-only
> > every time I do a CVS commit?
> this happens when someone does a 'cvs watch on'. i'm not sure how (or
> if) this can be disabled on the server. i've fixed things for now.

Thanks, that saves a few :w! in vim, followed by a selection of curses
and chmod's :-)

--Wez.


-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

RE: [PHP-DEV] compilation order platform dependent?

2002-09-23 Thread David Viner 

not of the straight source... but a patch that i'm developing works on one
platform but not on the other (relies on a generated header file in Zend/).

dave

-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
Sent: Monday, September 23, 2002 12:06 PM
To: David Viner
Cc: Php-Dev@lists. php. net
Subject: Re: [PHP-DEV] compilation order platform dependent?


On Mon, 23 Sep 2002, David Viner wrote:

> Hi,
>   I noticed that when I build php from the CVS source on Windows, the Zend/
> directory is always compiled before the main/ directory.  But on FreeBSD,
> it's the other way around.  Is this intentional? or have I messed up my
> build environment somehow?

This is very normal. Do you have any problems compiling?

Derick

--

---
 Derick Rethans   http://derickrethans.nl/
 JDI Media Solutions
--[ if you hold a unix shell to your ear, do you hear the c? ]-



-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

RE: [PHP-DEV] sticky perms in CVS?

2002-09-23 Thread James Cox 

nope.
> 
> But aren't all the other files -rw-r--r-- ?
> 
> On 09/23/02, "James Cox" <[EMAIL PROTECTED]> wrote:
> > The perms are fine in cvs:
> > 
> > -r--r--r--  1 cvs  cvs   24388 Sep 23 14:18 user_streams.c,v
> 
> 
> 
> 


--
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: sticky perms in CVS?

2002-09-23 Thread Jim Winstead 

Wez Furlong <[EMAIL PROTECTED]> wrote:
> Am I the only one who is getting their files chmod'ed to read-only
> every time I do a CVS commit?
> In particular, main/user_streams.c keeps doing this which is quite
> annoying - is there some setting on the server side that affects this?
> (and do we want it switched on?)

this happens when someone does a 'cvs watch on'. i'm not sure how (or
if) this can be disabled on the server. i've fixed things for now.

jim

-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

RE: [PHP-DEV] sticky perms in CVS?

2002-09-23 Thread Wez Furlong 

But aren't all the other files -rw-r--r-- ?

On 09/23/02, "James Cox" <[EMAIL PROTECTED]> wrote:
> The perms are fine in cvs:
> 
> -r--r--r--  1 cvs  cvs   24388 Sep 23 14:18 user_streams.c,v




-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] compilation order platform dependent?

2002-09-23 Thread derick 

On Mon, 23 Sep 2002, David Viner wrote:

> Hi,
>   I noticed that when I build php from the CVS source on Windows, the Zend/
> directory is always compiled before the main/ directory.  But on FreeBSD,
> it's the other way around.  Is this intentional? or have I messed up my
> build environment somehow?

This is very normal. Do you have any problems compiling?

Derick

--

---
 Derick Rethans   http://derickrethans.nl/ 
 JDI Media Solutions
--[ if you hold a unix shell to your ear, do you hear the c? ]-


-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] compilation order platform dependent?

2002-09-23 Thread David Viner 

Hi,
I noticed that when I build php from the CVS source on Windows, the Zend/
directory is always compiled before the main/ directory.  But on FreeBSD,
it's the other way around.  Is this intentional? or have I messed up my
build environment somehow?

thanks
dave


-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

RE: [PHP-DEV] sticky perms in CVS?

2002-09-23 Thread James Cox 

The perms are fine in cvs:

-r--r--r--  1 cvs  cvs   24388 Sep 23 14:18 user_streams.c,v

 -- james 
> 
> My umask is 022 (and I've never changed it, not since my early uni days
> on those old SGI Indigos when I was paranoid).
> I'm wondering if somehow the file was originally created 
> read-only (I can't
> think why that might be!?) and that CVS is remembering it?
> 
> Karl Fogels "Open Source Development with CVS" suggests that this might
> be the case and that the repository option PreservePermissions might
> have something to do with it.
> 
> It looks like the solution (aside from me chmod'ing the files +w each
> time I make a change) is to either set the permissions in the repository
> itself, or to enable the PreservePermissions setting on the server side
> (although he hints at some other implications).
> 
> --Wez.
> 
> On 09/23/02, "Andi Gutmans" <[EMAIL PROTECTED]> wrote:
> > At 07:22 PM 9/23/2002 +0100, Wez Furlong wrote:
> > >Am I the only one who is getting their files chmod'ed to read-only
> > >every time I do a CVS commit?
> > >In particular, main/user_streams.c keeps doing this which is quite
> > >annoying - is there some setting on the server side that affects this?
> > >(and do we want it switched on?)
> > 
> > No idea. It's never happened to me. Not that I think it can 
> have anything 
> > to do with it but is your umask OK?
> 
> 
> 
> -- 
> PHP Development Mailing List 
> To unsubscribe, visit: http://www.php.net/unsub.php
> 
> 


--
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] sticky perms in CVS?

2002-09-23 Thread Wez Furlong 

My umask is 022 (and I've never changed it, not since my early uni days
on those old SGI Indigos when I was paranoid).
I'm wondering if somehow the file was originally created read-only (I can't
think why that might be!?) and that CVS is remembering it?

Karl Fogels "Open Source Development with CVS" suggests that this might
be the case and that the repository option PreservePermissions might
have something to do with it.

It looks like the solution (aside from me chmod'ing the files +w each
time I make a change) is to either set the permissions in the repository
itself, or to enable the PreservePermissions setting on the server side
(although he hints at some other implications).

--Wez.

On 09/23/02, "Andi Gutmans" <[EMAIL PROTECTED]> wrote:
> At 07:22 PM 9/23/2002 +0100, Wez Furlong wrote:
> >Am I the only one who is getting their files chmod'ed to read-only
> >every time I do a CVS commit?
> >In particular, main/user_streams.c keeps doing this which is quite
> >annoying - is there some setting on the server side that affects this?
> >(and do we want it switched on?)
> 
> No idea. It's never happened to me. Not that I think it can have anything 
> to do with it but is your umask OK?



-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] sticky perms in CVS?

2002-09-23 Thread Andi Gutmans 

At 07:22 PM 9/23/2002 +0100, Wez Furlong wrote:
>Am I the only one who is getting their files chmod'ed to read-only
>every time I do a CVS commit?
>In particular, main/user_streams.c keeps doing this which is quite
>annoying - is there some setting on the server side that affects this?
>(and do we want it switched on?)

No idea. It's never happened to me. Not that I think it can have anything 
to do with it but is your umask OK?

Andi


-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] sticky perms in CVS?

2002-09-23 Thread Wez Furlong 

Am I the only one who is getting their files chmod'ed to read-only
every time I do a CVS commit?
In particular, main/user_streams.c keeps doing this which is quite
annoying - is there some setting on the server side that affects this?
(and do we want it switched on?)

--Wez.

-- 
Wez Furlong
The Brain Room Ltd.


-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [PATCH] [ZE] More useful error message for class redeclaration

2002-09-23 Thread Andi Gutmans 

If the zend_hash_add() fails then you can do a zend_hash_find() to retreive 
the class which is in the hash and print its information. If its 
information is NULL (we have to make sure we init it) then you can print 
out a message that it's an internal class. Does that make sense?

Andi

At 06:26 PM 9/23/2002 +0100, Wez Furlong wrote:
>The problem is (as I understand it!) that the ZEND_DECLARE_CLASS case in 
>do_bind_function_or_class retrieves the class entry for the user-defined
>class and not the internal class, and that is why the message reflects
>the user class.
>
>I can't really see why this is the case, but then I haven't really delved
>into how it all works :-/
>
>--Wez.
>
>
>On 09/23/02, "Andi Gutmans" <[EMAIL PROTECTED]> wrote:
> > Can't you make sure that the filename of internal classes will be NULL and
> > then we can check for it and say it's an internal class?
> >
> > Andi
> >
> > At 03:59 PM 9/23/2002 +0100, Wez Furlong wrote:
> > >Caveat Emptor: if someone tries to redeclare an internal/builtin class
> > >such as Directory, the previous declaration will appear to be the
> > >actual declaration in the script.  I'm not sure of the best way to
> > >resolve this.


-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main streams.c

2002-09-23 Thread Sebastian Bergmann 

Wez Furlong wrote:
> It's looking really ugly - maybe there is a better way?

  No warning :)

-- 
  Sebastian Bergmann
  http://sebastian-bergmann.de/ http://phpOpenTracker.de/

  Did I help you? Consider a gift: http://wishlist.sebastian-bergmann.de/

-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [PATCH] [ZE] More useful error message for class redeclaration

2002-09-23 Thread Wez Furlong 

The problem is (as I understand it!) that the ZEND_DECLARE_CLASS case in 
do_bind_function_or_class retrieves the class entry for the user-defined
class and not the internal class, and that is why the message reflects
the user class.

I can't really see why this is the case, but then I haven't really delved
into how it all works :-/

--Wez.


On 09/23/02, "Andi Gutmans" <[EMAIL PROTECTED]> wrote:
> Can't you make sure that the filename of internal classes will be NULL and 
> then we can check for it and say it's an internal class?
> 
> Andi
> 
> At 03:59 PM 9/23/2002 +0100, Wez Furlong wrote:
> >Caveat Emptor: if someone tries to redeclare an internal/builtin class
> >such as Directory, the previous declaration will appear to be the
> >actual declaration in the script.  I'm not sure of the best way to
> >resolve this.



-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /main streams.c

2002-09-23 Thread Wez Furlong 

Can you try this instead:

if (eol && (size_t)((ptrdiff_t)eol + 1 - (ptrdiff_t)readptr) <= maxlen - 1) {
   justread = eol + 1 - readptr;

It's looking really ugly - maybe there is a better way?

--Wez.

On 09/23/02, "Sebastian Bergmann" <[EMAIL PROTECTED]> wrote:
>   It compiles again, but:
> 
> c:\home\php\php4\main\streams.c(517): warning C4018:
> '<=': Conflict between signed and unsigned



-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [PATCH] [ZE] More useful error message for class redeclaration

2002-09-23 Thread Andi Gutmans 

Can't you make sure that the filename of internal classes will be NULL and 
then we can check for it and say it's an internal class?

Andi

At 03:59 PM 9/23/2002 +0100, Wez Furlong wrote:
>X-Managedo-partname: name="1.1"; mimetype="text/plain"
>Content-Type: text/plain; charset="iso-8859-1"
>Content-Transfer-Encoding: 7bit
>
>I'm resubmitting this little patch for the ZE; when presented with
>code like this:
>
>class Foo {
>}
>
>class Foo {
>}
>?>
>
>The engine will generate an error message like this:
>
>Cannot redeclare class Foo (previously declared in file.php:2)
>
>Caveat Emptor: if someone tries to redeclare an internal/builtin class
>such as Directory, the previous declaration will appear to be the
>actual declaration in the script.  I'm not sure of the best way to
>resolve this.
>
>--Wez.
>
>--
>Wez Furlong
>The Brain Room Ltd.
>
>X-Managedo-partname: name="1.2"; mimetype="text/plain"
>Content-Type: text/plain
>Content-Transfer-Encoding: 7bit
>Content-Disposition: attachment;
>  filename="redclare_class.diff.txt"
>
>--
>PHP Development Mailing List 
>To unsubscribe, visit: http://www.php.net/unsub.php


-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/standard config.m4 css.c css.h info.c /main php_ini.c /sapi/aolserver aolserver.c /sapi/apache php_apache.c

2002-09-23 Thread Colin Viebrock 

> I must have missed some discussion where it was decided to change
> this..? Can't seem to find any in the archives either.

There wasn't.

> And why is there even need to change it? It has worked fine (for ANY
> browser) for very long time now.

I was simply trying to reduce the amount of HTML that phpinfo()
generated, and moving to a CSS formatting model acheived that while
still maintaining "compatability" for current browsers.

My question back would be how many people here *really* care what the
output looks like?  Is anyone making that info available in a production
 site?  I doubt it.  I'm guessing this page is almost exclusively used
for debugging purposes by site developers, or other diagnostic reasons
... in which case as long as the info is there and legible, I don't see
the issue.

However, if there are, then you can easily replace the stylesheet with
your own style to "skin" the page ... something that would've been much
more difficult with the old version.  The HTML itself in the current
page is as plain as it gets, pretty much.

If we want a truly cross-browser phpinfo() page, it should be text-only
or plain, unformatted, uncoloured tables.

- Colin



-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/standard config.m4 css.c css.h info.c/main php_ini.c /sapi/aolserver aolserver.c /sapi/apache php_apache.c

2002-09-23 Thread Sebastian Bergmann 

Jani Taskinen wrote:
> And why is there even need to change it? It has worked fine (for ANY
> browser) for very long time now.

  The latest changes by Colin are a big improvement, IMHO. It really
  looks better now.

-- 
  Sebastian Bergmann
  http://sebastian-bergmann.de/ http://phpOpenTracker.de/

  Did I help you? Consider a gift: http://wishlist.sebastian-bergmann.de/

-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/standard config.m4 css.c css.h info.c /main php_ini.c /sapi/aolserver aolserver.c /sapi/apache php_apache.c

2002-09-23 Thread Jani Taskinen 

On Mon, 23 Sep 2002, Colin Viebrock wrote:

>[EMAIL PROTECTED] wrote:
>> "render nicely" is something else than "total unreadable" to me. Did you 
>> have a look at it with Netscape Navigator 4? Please fix something for 
>> it, as it's pretty horrible now.
>
>Can you send me a screen grab?  I did test it under NS 4.7 (Win), and I
>think you're exaggerating a bit, because it's hardly unreadable.
>
>I guess my other question is how far back are we willing to care about
>browser compatability?  Netscape 4.7 is now 3 years old and accounts for
>less 5% of the traffic we've seen at easyDNS in the last year (I don't
>think the stats program at www.php.net tracks browsers unfortunately).

I must have missed some discussion where it was decided to change
this..? Can't seem to find any in the archives either.

And why is there even need to change it? It has worked fine (for ANY
browser) for very long time now.

--Jani



-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /main streams.c

2002-09-23 Thread Sebastian Bergmann 

Wez Furlong wrote:
> wez Mon Sep 23 11:21:17 2002 EDT
>
>   Modified files:
> /php4/main  streams.c
>   Log:
>   Hopefully fix the other warnings that my last warning-fixing commit 
>   caused.

  It compiles again, but:

c:\home\php\php4\main\streams.c(517): warning C4018:
'<=': Conflict between signed and unsigned

-- 
  Sebastian Bergmann
  http://sebastian-bergmann.de/ http://phpOpenTracker.de/

  Did I help you? Consider a gift: http://wishlist.sebastian-bergmann.de/

-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Binary Safety, Sockets and Raw sockets

2002-09-23 Thread Jason T. Greene 

On Sat, 2002-09-21 at 00:21, Hans Zaunere wrote:
> 
> 4.2.3 on FreeBSD 4.6.2  (--enable-cli,--enable-sockets,etc)
> 
> I've been taking a look at the socket_* functions in PHP, and
> specifically using raw sockets.  I've started out with ICMP, and I can
> form the ICMP header (more or less) and send it out with an
> insufficient TTL; and as expected I get a ICMP 11 (Time Exceeded)
> response from an enroute gateway.  However, when I set a proper TTL
> (32, for example) I see the packet arrive at the remote host, however
> it is apparently dropped.
> 
> So a couple things have come up:
> 
> -- I'm guessing that the socket_* functions, except socket_read() and
> socket_write(), are not binary safe?

socket_read() and socket_write() are binary safe, but there was a binary
safety issue in socket_recvfrom that is fixed in CVS

> -- While it seems the STREAM and DGRAM sockets work as expected for the
> most part, what about RAW sockets?  I find that the underlying
> functions work fine to create the socket, etc, however I'm having a
> hard time working with the binary data in PHP.  For instance, creating
> the header and then reading it seems tortuous.  Any hints/remedies for
> this?  I think sockets, and especially raw, could be very handy in PHP,
> and would like to know how/if this functionality will be expanded (hey,
> the world needs another traceroute/ping program right?).  I was on my
> way to writing this in PHP, but have fell on hard times with binary
> manipulation.
> 

The best way to do this kind of thing is to use the pack/unpack
functions. _HOWEVER_, php internally treats all numbers as signed
values. Which will make what you are doing almost impossible. pack could
be modified to correct this, but it could be lost if you did something
like a right shift on the value. (PHP currently only supports an
arithmetic right shift).

> -- Another problem I've run into, and again concerning binary
> manipulation, is forming the correct Internet Checksum (rfc1071).  I'm
> not the handiest with bit tricks, but I tried to model the in_cksum()
> function and just couldn't get very far.  Any ideas/tips on this?

This is most likely because of the right shift problem I mentioned
above. However, it would probably be better to just make a php function
which performs an internet checksum.

 
> A clean, but at the same time low-level/raw socket interface I think
> would be extremely useful and I'd like to help in any way I can.

To be honest, I haven't spent much time on making sure that all the
functionality with RAW sockets is there. However, not considering signed
issues, pack/unpack, /ext/sockets, and that checksum function should
give you the functionality you need.

If you notice any issues with the sockets extension in this area, email
me and I will fix them. Also, if you have come up with, or are planning
on making patches in this area, I would gladly accept them : )

Thanks,

-Jason



 
> Thanks!
> 
> Hans
> 
> 
> 
> 
> 
> 
> __
> Do you Yahoo!?
> New DSL Internet Access from SBC & Yahoo!
> http://sbc.yahoo.com
> 
> -- 
> PHP Development Mailing List 
> To unsubscribe, visit: http://www.php.net/unsub.php
> 



-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] [PATCH] [ZE] More useful error message for class redeclaration

2002-09-23 Thread Wez Furlong 

I'm resubmitting this little patch for the ZE; when presented with
code like this:



The engine will generate an error message like this:

Cannot redeclare class Foo (previously declared in file.php:2)

Caveat Emptor: if someone tries to redeclare an internal/builtin class
such as Directory, the previous declaration will appear to be the
actual declaration in the script.  I'm not sure of the best way to
resolve this.

--Wez.

-- 
Wez Furlong
The Brain Room Ltd.



Index: Zend/zend.h
===
RCS file: /repository/Zend/zend.h,v
retrieving revision 1.161
diff -u -r1.161 zend.h
--- Zend/zend.h 19 Sep 2002 15:54:10 -  1.161
+++ Zend/zend.h 23 Sep 2002 14:51:44 -
@@ -275,6 +275,10 @@
void (*handle_function_call)(INTERNAL_FUNCTION_PARAMETERS, 
zend_property_reference *property_reference);
zval (*handle_property_get)(zend_property_reference *property_reference);
int (*handle_property_set)(zend_property_reference *property_reference, zval 
*value);
+
+   /* location of definition of this class */
+   char *def_file;
+   int def_lineno;
 };
 
 
Index: Zend/zend_compile.c
===
RCS file: /repository/Zend/zend_compile.c,v
retrieving revision 1.236
diff -u -r1.236 zend_compile.c
--- Zend/zend_compile.c 20 Aug 2002 14:26:31 -  1.236
+++ Zend/zend_compile.c 23 Sep 2002 14:51:45 -
@@ -1190,7 +1190,10 @@
if (zend_hash_add(class_table, 
opline->op2.u.constant.value.str.val, opline->op2.u.constant.value.str.len+1, ce, 
sizeof(zend_class_entry), NULL)==FAILURE) {
(*ce->refcount)--;
if (!compile_time) {
-   zend_error(E_ERROR, "Cannot redeclare 
class %s", opline->op2.u.constant.value.str.val);
+   zend_error(E_ERROR, "Cannot redeclare 
+class %s (previously declared in %s:%d)",
+   
+opline->op2.u.constant.value.str.val,
+   ce->def_file,
+   ce->def_lineno);
}
return FAILURE;
} else {
@@ -1581,6 +1584,9 @@
CG(class_entry).handle_property_set = NULL;
CG(class_entry).handle_property_get = NULL;
 
+   CG(class_entry).def_file = estrdup(zend_get_compiled_filename(TSRMLS_C));
+   CG(class_entry).def_lineno = CG(zend_lineno);
+   
/* code for inheritance from parent class */
if (parent_class_name) {
zend_class_entry *parent_class;
Index: Zend/zend_opcode.c
===
RCS file: /repository/Zend/zend_opcode.c,v
retrieving revision 1.56
diff -u -r1.56 zend_opcode.c
--- Zend/zend_opcode.c  6 Jan 2002 15:21:09 -   1.56
+++ Zend/zend_opcode.c  23 Sep 2002 14:51:46 -
@@ -115,6 +115,7 @@
case ZEND_USER_CLASS:
efree(ce->name);
efree(ce->refcount);
+   efree(ce->def_file);
zend_hash_destroy(&ce->function_table);
zend_hash_destroy(&ce->default_properties);
break;





-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/ftp ftp.c /main php_streams.h streams.c

2002-09-23 Thread Sebastian Bergmann 

Wez Furlong wrote:
> -   if (eol && (eol + 1 - readptr) <= maxlen - 1) {
> +   if (eol && ((ptrdiff_t)eol + 1 - (ptrdiff_t)readptr) <= 

  Now I get the following

c:\home\php\php4\main\streams.c(323): warning C4018:
'<': Conflict between signed and unsigned

c:\home\php\php4\main\streams.c(393): warning C4018: '>':
'>': Conflict between signed and unsigned

c:\home\php\php4\main\streams.c(515): error C2065:
'ptrdiff_t': Undeclared identifier

-- 
  Sebastian Bergmann
  http://sebastian-bergmann.de/ http://phpOpenTracker.de/

  Did I help you? Consider a gift: http://wishlist.sebastian-bergmann.de/

-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [PHP-CVS] cvs: php4 /main output.c

2002-09-23 Thread Sebastian Bergmann 

Zeev Suraski wrote:
> zeevMon Sep 23 10:18:43 2002 EDT
>
>   Modified files:
> /php4/main  output.c
>   Log:
>   Fix bug #19525


echo 'test';

  now prints in HEAD

Cannot use output buffering in output buffering display handlers

  as it already does in the 4.2.3 release.

  How am I supposed to catch the result of an eval() command inside an
  output buffer?

  A possibility would be to change the behaviour of eval() and let it
  return an array with both output and return value of the evaluated
  code.

-- 
  Sebastian Bergmann
  http://sebastian-bergmann.de/ http://phpOpenTracker.de/

  Did I help you? Consider a gift: http://wishlist.sebastian-bergmann.de/

-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Warning in reg.c

2002-09-23 Thread Sebastian Bergmann 

  Warning in reg.c

c:\home\php\php4\ext\standard\reg.c(374): warning C4018:
'<=': Conflict between signed and unsigned

-- 
  Sebastian Bergmann
  http://sebastian-bergmann.de/ http://phpOpenTracker.de/

  Did I help you? Consider a gift: http://wishlist.sebastian-bergmann.de/

-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Warnings in streams.c

2002-09-23 Thread Sebastian Bergmann 

  Warnings in streams.c

c:\home\php\php4\main\streams.c(515): warning C4018:
'<=': Conflict between signed and unsigned
  
c:\home\php\php4\main\streams.c(588): warning C4018:
'<=': Conflict between signed and unsigned
  
c:\home\php\php4\main\streams.c(596): warning C4018:
'<=': Conflict between signed and unsigned

-- 
  Sebastian Bergmann
  http://sebastian-bergmann.de/ http://phpOpenTracker.de/

  Did I help you? Consider a gift: http://wishlist.sebastian-bergmann.de/

-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Warnings in ftp.c

2002-09-23 Thread Sebastian Bergmann 

  Warnings in ftp.c

c:\home\php\php4\ext\ftp\ftp.c(626): warning C4018:
'!=': Conflict between signed and unsigned

c:\home\php\php4\ext\ftp\ftp.c(1475): warning C4018:
'!=': Conflict between signed and unsigned

-- 
  Sebastian Bergmann
  http://sebastian-bergmann.de/ http://phpOpenTracker.de/

  Did I help you? Consider a gift: http://wishlist.sebastian-bergmann.de/

-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Warnings in basic_functions.c

2002-09-23 Thread Sebastian Bergmann 

  Warnings in basic_functions.c

c:\home\php\php4\ext\standard\basic_functions.c(2072): warning C4047:
'function': Count of dereferences different between
'struct _hashtable *' and 'struct _hashtable ** '

c:\home\php\php4\ext\standard\basic_functions.c(2072): warning C4024:
'zend_hash_apply_with_arguments': Different types for formal and
given parameter 1

-- 
  Sebastian Bergmann
  http://sebastian-bergmann.de/ http://phpOpenTracker.de/

  Did I help you? Consider a gift: http://wishlist.sebastian-bergmann.de/

-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

RE: [PHP-DEV] Re: Object Overloading

2002-09-23 Thread Zeev Suraski 

At 11:42 23/09/2002, Sam Liddicott wrote:
>Is there any chance I can look at some zend 5 code to see the new model, and
>how it might fit with SWIG?

Sure, just checkout the ZendEngine2 repository...

>Also, overloaded objects are good, what do you think about overloaded
>variables? (And with references these might just become overloaded zvals...
>Hmm...) Anyway...

Our variables have no type, so overloading can only be done on the value 
level.  We don't want to overload any non-OO syntax.

Zeev


-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

RE: [PHP-DEV] Re: Object Overloading

2002-09-23 Thread Sam Liddicott 



> -Original Message-
> From: Zeev Suraski [mailto:[EMAIL PROTECTED]]
> Sent: 23 August 2002 18:59
> To: Sam Liddicott
> Cc: [EMAIL PROTECTED]
> Subject: RE: [PHP-DEV] Re: Object Overloading
> 
> 
> At 17:09 23/08/2002, Sam Liddicott wrote:
> >Or am I missing something obvious?
> 
> ZE2 objects are not at all like ZE1 objects.  We're way 
> beyond that point 
> there now :)

Is there any chance I can look at some zend 5 code to see the new model, and
how it might fit with SWIG?

Also, overloaded objects are good, what do you think about overloaded
variables? (And with references these might just become overloaded zvals...
Hmm...) Anyway...

Sam




-- 
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Sound Extension proposed API

2002-09-23 Thread DJ Anubis 

Le Dimanche 22 Septembre 2002 14:25, vous avez écrit :

> Hi
>
> I have finished my first release of the audio extension, details at
> http://www.webwise-data.co.uk/php_audio/php_audio_extension.html

Hi,

Cool, I'll read it ASAP ;-)

> I am now planning to write some higher level functions, do you have any
> ideas in mind how a unified wrapper could work? I like the sound of it
> so we don't end up with a confusing mess of multimedia functions.

Well, we could think of something like Metabase from Manuel Lemos, which is a 
really great database abstraction. Let's think for a while. Why not some 
common methods like open, close, play, playlist... and wrap those to 
peculiarities of say ecasound, xmms, xine, and whatever we can imagine.

This is not trivial and needs a very high level of abstraction, but should 
work.

> I will take a look at your XMMS extension and see if I get any ideas.

For the moment, this is experimental and only a wrapping class around xmms. We 
should start a reflexion about media abstraction and define a common layer 
for this. Then write module classes.

DJ Anubis.


--
PHP Development Mailing List 
To unsubscribe, visit: http://www.php.net/unsub.php