Re: [PHP-DEV] register_shutdown_function = register_offline_function

2002-12-06 Thread Zeev Suraski
Brian,

BC is an issue, always, but as the person who wrote both the original 
version and the fix, I can tell you that the original behavior was not 
intended to begin with, and because it couldn't be duplicated on any other 
server than Apache, it was changed to both reflect the intended behavior, 
and allow us to implement it properly on all web servers.

Zeev

At 17:56 05/12/2002, Brian Moon wrote:
Has the new function been created yet and if not when?

We have just spent 2 weeks investigating why our pages started dragging to
find out that register_shutdown_function is BROKE.  I am a little
discouraged from what I have read on this.  It seems that BC is only a
concern when the right person likes the old way it worked.  When the right
people don't like the way things work, BC is thrown out the window and code
is broken.  fgetcsv is broke and has been broke IMO.  It causes segfaults.
Read the archives.  But because it would break BC (and the orig author likes
the way it workds) it stays unchanged.

As for the new function,If we are creating a new function, we should create
a new one for the NEW behavior.  This is the same thing that happened with
mysql_fetch_array.  At first, it returned an associative array and
mysql_fetch_row returned a numerical array.  Then someone said, I want both
in one call, so, someone decided that mysql_fetch_array should return both.
Well, people complained (me included) and the solution was make it take an
optional param to designate the array type with both being the default.
Now, we all know that assoc should have been the default. So, i wrote
mysql_fetch_assoc, got it commited and never looked back on that one.

Thanks for the time.

Brian Moon
dealnews.com




--
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php



--
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php




[PHP-DEV] register_shutdown_function = register_offline_function

2002-12-05 Thread Brian Moon
Has the new function been created yet and if not when?

We have just spent 2 weeks investigating why our pages started dragging to
find out that register_shutdown_function is BROKE.  I am a little
discouraged from what I have read on this.  It seems that BC is only a
concern when the right person likes the old way it worked.  When the right
people don't like the way things work, BC is thrown out the window and code
is broken.  fgetcsv is broke and has been broke IMO.  It causes segfaults.
Read the archives.  But because it would break BC (and the orig author likes
the way it workds) it stays unchanged.

As for the new function,If we are creating a new function, we should create
a new one for the NEW behavior.  This is the same thing that happened with
mysql_fetch_array.  At first, it returned an associative array and
mysql_fetch_row returned a numerical array.  Then someone said, I want both
in one call, so, someone decided that mysql_fetch_array should return both.
Well, people complained (me included) and the solution was make it take an
optional param to designate the array type with both being the default.
Now, we all know that assoc should have been the default. So, i wrote
mysql_fetch_assoc, got it commited and never looked back on that one.

Thanks for the time.

Brian Moon
dealnews.com




-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php




Re: [PHP-DEV] register_shutdown_function = register_offline_function

2002-12-05 Thread Brian Moon
Ok, I reopened the bug.  It fails with latest CVS.

[root@dealnews php4-200212051430]# ./sapi/cgi/php-cgi csv.php

Content-type: text/html
X-Powered-By: PHP/4.4.0-dev

Array
(
[0] = 6
[1] = 7
[2] = 8
[3] = line1
)
Segmentation fault

Brian Moon
dealnews.com


- Original Message -
From: Derick Rethans [EMAIL PROTECTED]
To: Brian Moon [EMAIL PROTECTED]
Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]
Sent: Thursday, December 05, 2002 10:00 AM
Subject: Re: [PHP-DEV] register_shutdown_function =
register_offline_function


| Hey Brain,
|
| watch your attitude, we're not here to solve your problems. fgetcvs is
| not broken at all, it has been fixed recently. If you still think it's
| broken file a bugreport.
|
| Derick
|
|
| On Thu, 5 Dec 2002, Brian Moon wrote:
|
|  Has the new function been created yet and if not when?
| 
|  We have just spent 2 weeks investigating why our pages started dragging
to
|  find out that register_shutdown_function is BROKE.  I am a little
|  discouraged from what I have read on this.  It seems that BC is only a
|  concern when the right person likes the old way it worked.  When the
right
|  people don't like the way things work, BC is thrown out the window and
code
|  is broken.  fgetcsv is broke and has been broke IMO.  It causes
segfaults.
|  Read the archives.  But because it would break BC (and the orig author
likes
|  the way it workds) it stays unchanged.
| 
|  As for the new function,If we are creating a new function, we should
create
|  a new one for the NEW behavior.  This is the same thing that happened
with
|  mysql_fetch_array.  At first, it returned an associative array and
|  mysql_fetch_row returned a numerical array.  Then someone said, I want
both
|  in one call, so, someone decided that mysql_fetch_array should return
both.
|  Well, people complained (me included) and the solution was make it take
an
|  optional param to designate the array type with both being the default.
|  Now, we all know that assoc should have been the default. So, i wrote
|  mysql_fetch_assoc, got it commited and never looked back on that one.
| 
|  Thanks for the time.
| 
|  Brian Moon
|  dealnews.com
| 
| 
| 
| 
|  --
|  PHP Development Mailing List http://www.php.net/
|  To unsubscribe, visit: http://www.php.net/unsub.php
| 
|
| --
|
| -
|  Derick Rethans http://derickrethans.nl/
|  PHP Magazine - PHP Magazine for Professionals   http://php-mag.net/
| -
|
|
|


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php




Re: [PHP-DEV] register_shutdown_function = register_offline_function

2002-12-05 Thread Ilia A.
Known issue, the original patch for this problem had to be reveted since it 
broke the handling of mulit-line CVS fields that are quoted. I am now working 
on a more permanent fix.

Ilia

On December 5, 2002 11:39 am, Brian Moon wrote:
 Ok, I reopened the bug.  It fails with latest CVS.

 [root@dealnews php4-200212051430]# ./sapi/cgi/php-cgi csv.php

 Content-type: text/html
 X-Powered-By: PHP/4.4.0-dev

 Array
 (
 [0] = 6
 [1] = 7
 [2] = 8
 [3] = line1
 )
 Segmentation fault

 Brian Moon
 dealnews.com


 - Original Message -
 From: Derick Rethans [EMAIL PROTECTED]
 To: Brian Moon [EMAIL PROTECTED]
 Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]
 Sent: Thursday, December 05, 2002 10:00 AM
 Subject: Re: [PHP-DEV] register_shutdown_function =
 register_offline_function

 | Hey Brain,
 |
 | watch your attitude, we're not here to solve your problems. fgetcvs is
 | not broken at all, it has been fixed recently. If you still think it's
 | broken file a bugreport.
 |
 | Derick
 |
 | On Thu, 5 Dec 2002, Brian Moon wrote:
 |  Has the new function been created yet and if not when?
 | 
 |  We have just spent 2 weeks investigating why our pages started dragging

 to

 |  find out that register_shutdown_function is BROKE.  I am a little
 |  discouraged from what I have read on this.  It seems that BC is only a
 |  concern when the right person likes the old way it worked.  When the

 right

 |  people don't like the way things work, BC is thrown out the window and

 code

 |  is broken.  fgetcsv is broke and has been broke IMO.  It causes

 segfaults.

 |  Read the archives.  But because it would break BC (and the orig author

 likes

 |  the way it workds) it stays unchanged.
 | 
 |  As for the new function,If we are creating a new function, we should

 create

 |  a new one for the NEW behavior.  This is the same thing that happened

 with

 |  mysql_fetch_array.  At first, it returned an associative array and
 |  mysql_fetch_row returned a numerical array.  Then someone said, I want

 both

 |  in one call, so, someone decided that mysql_fetch_array should return

 both.

 |  Well, people complained (me included) and the solution was make it take

 an

 |  optional param to designate the array type with both being the default.
 |  Now, we all know that assoc should have been the default. So, i wrote
 |  mysql_fetch_assoc, got it commited and never looked back on that one.
 | 
 |  Thanks for the time.
 | 
 |  Brian Moon
 |  dealnews.com
 | 
 | 
 | 
 | 
 |  --
 |  PHP Development Mailing List http://www.php.net/
 |  To unsubscribe, visit: http://www.php.net/unsub.php
 |
 | --
 |
 | -
 |  Derick Rethans http://derickrethans.nl/
 |  PHP Magazine - PHP Magazine for Professionals   http://php-mag.net/
 | -


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php