Re: [PHP-DEV] Re: cvs: php4 /ext/mbstring config.m4

2002-07-15 Thread Edin Kadribasic

 I asked to php-dev and nobody objects enabling mbstirng by
 default. This allow some modules (extif, mailparse(?), for example)
 to use multibyte feature.

No objections here.

 multibyte regular expression is must have feature for
 ease of use. (preg supports UTF-8, but it requires conversion
 in many cases)

 mbstr-enc-trans is enabled, since it's does not require
 much performenace penalty and most multibyte aware installations
 enable this option, I think. This option is subject to be
 discussed.

I think this should be turned off by default. I don't know how big is the
performance penalty, but any unneeded slowdown is a bad thing.

This also make bug chasing more difficult and as we have to maintain two
separate pieces of code that do the same thing. Just have a look at
http://bugs.php.net/bug.php?id=16985 which is caused by different behaviour
of main/php_variables.c and ext/mbstring/mbstring.c.

Could we please turn this feature off by default?

Edin



-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php




RE: [PHP-DEV] Re: cvs: php4 /ext/mbstring config.m4

2002-07-15 Thread Robinson, Mike
Title: RE: [PHP-DEV] Re: cvs: php4 /ext/mbstring config.m4 






Edin Kadribasic writes:


 Sent: Monday, July 15, 2002 12:05 PM
 To: [EMAIL PROTECTED]; Jani Taskinen; Yasuo Ohgaki
 Subject: Re: [PHP-DEV] Re: cvs: php4 /ext/mbstring config.m4 
 
 
  I asked to php-dev and nobody objects enabling mbstirng by
  default. This allow some modules (extif, mailparse(?), for example)
  to use multibyte feature.
 
 No objections here.


Frankly, I don't think mbstring should be enabled by default.


If a user wants mbstring support, is it too much to ask to
have them add --enable-mbstring to their config line? Once
we go down this road, turning it off by default is a huge wtf.


IMHO that is.


Regards


Mike Robinson
IT/Developer - Torstar Media Group Television
Phone: 416.945.8786 Fax: 416.869.4566
Email: [EMAIL PROTECTED]




To find out more about what we can do for you, please visit us at:
http://www.tmgtv.ca/ and http://www.thestar.com/



-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php


Re: [PHP-DEV] Re: cvs: php4 /ext/mbstring config.m4

2002-07-15 Thread Yasuo Ohgaki

Robinson, Mike wrote:
 
 Edin Kadribasic writes:
 
   Sent: Monday, July 15, 2002 12:05 PM
   To: [EMAIL PROTECTED]; Jani Taskinen; Yasuo Ohgaki
   Subject: Re: [PHP-DEV] Re: cvs: php4 /ext/mbstring config.m4
  
  
I asked to php-dev and nobody objects enabling mbstirng by
default. This allow some modules (extif, mailparse(?), for example)
to use multibyte feature.
  
   No objections here.
 
 Frankly, I don't think mbstring should be enabled by default.

  If a user wants mbstring support, is it too much to ask to
  have them add --enable-mbstring to their config line? Once
  we go down this road, turning it off by default is a huge wtf.

You missed the fact PHP module loader/PHP ini parser do not
understand dependency at all.

We don't want bug reports such as PHP does not compile
module ABC and/or XYZ, PHP won't start for some reason,
etc.

I18N feature is must have core feature for modern languages,
IMHO, but it's free to add --disable-mbstring in users'
configure line if users understand consequences.

Anyway, automatic input tranlasation overhead is rather
small. It may be disabled manually using multipart/form-data
encoding, but it could be annoying when we are developing
true I18N website. I'll disable input encoding tranlation by
default, objections?

--
Yasuo Ohgaki



-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php




Re: [PHP-DEV] Re: cvs: php4 /ext/mbstring config.m4

2002-07-15 Thread fabwash

My point of view is that:

If it's not experimental
If it compiles and runs cross platform without error
If it doesn't require external libraries
If it is properly documented
If it doesn't significantly impact performance

Then enable by default. ISPs will usually use the default options, and if
you try to get them to recompile to enable something, they will either not
do it, or take their time.

Fab.
- Original Message -
From: Yasuo Ohgaki [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Cc: Robinson, Mike [EMAIL PROTECTED]; 'Edin Kadribasic'
[EMAIL PROTECTED]; Jani Taskinen [EMAIL PROTECTED]
Sent: Monday, July 15, 2002 9:03 PM
Subject: Re: [PHP-DEV] Re: cvs: php4 /ext/mbstring config.m4


 Robinson, Mike wrote:
 
  Edin Kadribasic writes:
 
Sent: Monday, July 15, 2002 12:05 PM
To: [EMAIL PROTECTED]; Jani Taskinen; Yasuo Ohgaki
Subject: Re: [PHP-DEV] Re: cvs: php4 /ext/mbstring config.m4
   
   
 I asked to php-dev and nobody objects enabling mbstirng by
 default. This allow some modules (extif, mailparse(?), for example)
 to use multibyte feature.
   
No objections here.
 
  Frankly, I don't think mbstring should be enabled by default.
 
   If a user wants mbstring support, is it too much to ask to
   have them add --enable-mbstring to their config line? Once
   we go down this road, turning it off by default is a huge wtf.

 You missed the fact PHP module loader/PHP ini parser do not
 understand dependency at all.

 We don't want bug reports such as PHP does not compile
 module ABC and/or XYZ, PHP won't start for some reason,
 etc.

 I18N feature is must have core feature for modern languages,
 IMHO, but it's free to add --disable-mbstring in users'
 configure line if users understand consequences.

 Anyway, automatic input tranlasation overhead is rather
 small. It may be disabled manually using multipart/form-data
 encoding, but it could be annoying when we are developing
 true I18N website. I'll disable input encoding tranlation by
 default, objections?

 --
 Yasuo Ohgaki



 --
 PHP Development Mailing List http://www.php.net/
 To unsubscribe, visit: http://www.php.net/unsub.php



-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php