[PHP-WEBMASTER] com web/bugs: Refactor each() function to foreach(): include/functions.php

2018-11-23 Thread Peter Kokot 
Commit:38212625bd3c4356c1173c0ef4fd3af76f404fb5
Author:Peter Kokot  Sat, 24 Nov 2018 02:25:23 
+0100
Parents:   0818111ce98a81dcf40ec23c7707ae7804443567
Branches:  master

Link:   
http://git.php.net/?p=web/bugs.git;a=commitdiff;h=38212625bd3c4356c1173c0ef4fd3af76f404fb5

Log:
Refactor each() function to foreach()

The each() function has been deprecated since PHP 7.2 and shouldn't be
used anymore:
- http://php.net/manual/en/function.each.php

Changed paths:
  M  include/functions.php


Diff:
diff --git a/include/functions.php b/include/functions.php
index 13b9c64..cb6d6aa 100644
--- a/include/functions.php
+++ b/include/functions.php
@@ -498,7 +498,7 @@ function show_byage_options($current)
'30' => '30 days ago',
'90' => '90 days ago',
];
-   while (list($k,$v) = each($opts)) {
+   foreach ($opts as $k => $v) {
echo "$v\n";
}
 }
@@ -784,7 +784,7 @@ function show_package_options($current, $show_any, $default 
= '')
 function show_boolean_options($current)
 {
$options = ['any', 'all', 'raw'];
-   while (list($val, $type) = each($options)) {
+   foreach ($options as $val => $type) {
echo 'http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] com web/bugs: Bump minimal required PHP version: README.md

2018-11-23 Thread Peter Kokot 
Commit:0818111ce98a81dcf40ec23c7707ae7804443567
Author:Peter Kokot  Sat, 24 Nov 2018 02:10:34 
+0100
Parents:   13ecc0245ad34f8af7e955064bc7d6c2f6240c17
Branches:  master

Link:   
http://git.php.net/?p=web/bugs.git;a=commitdiff;h=0818111ce98a81dcf40ec23c7707ae7804443567

Log:
Bump minimal required PHP version

Changed paths:
  M  README.md


Diff:
diff --git a/README.md b/README.md
index 20299a8..555a497 100644
--- a/README.md
+++ b/README.md
@@ -5,7 +5,7 @@ This is a unified bug tracking system for PHP hosted online at
 
 ## Requirements
 
-- PHP 5.4+
+- PHP 7.2+
 - ext/pdo
 - ext/pdo_mysql
 - ext/openssl (for https:// fopen wrapper)


--
PHP Webmaster List Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] Bug #76961 [Com]: https://bugs.php.net/vote.php throws a Server Error over ipv6

2018-11-23 Thread p...@php.net 
Edit report at https://bugs.php.net/bug.php?id=76961=1

 ID: 76961
 Comment by: p...@php.net
 Reported by:sjon at hortensius dot net
 Summary:https://bugs.php.net/vote.php throws a Server Error
 over ipv6
 Status: Verified
 Type:   Bug
 Package:Website problem
 PHP Version:Irrelevant
 Block user comment: N
 Private report: N

 New Comment:

I've attached a pull request https://github.com/php/web-bugs/pull/53

This will also require to change the database schema where the ip column is 
currently integer to a new varbinary(16) type. Additionally current values 
should be converted accordingly... Maybe someone with server access can give 
some more pointers this could be approached and fixed.

Thanks.


Previous Comments:

[2018-11-15 14:15:04] c...@php.net

Oops, I've meant .  Before
I voted, there was only a single vote.

Just voted on  (also while
being logged out), and it worked fine.

> The code uses ip2long which doesn't work for ipv6 - also, the
> schema uses int(10) instead of varbinary(16) 

Aha!  Re-opening.


[2018-11-15 14:10:29] sjon at hortensius dot net

Maybe this is caused by me using ipv6. The code uses ip2long which doesn't work 
for ipv6 - also, the schema uses int(10) instead of varbinary(16)


[2018-11-15 14:05:19] sjon at hortensius dot net

are you sure? Because your vote doesn't show in that bugreport? I tried voting 
on https://bugs.php.net/bug.php?id=77163 but I get a 500-server-error. There 
should be an exception logged somewhere accordingly?


[2018-11-15 13:43:29] c...@php.net

While being logged out, I just voted on bug 77155, and it worked
as expected.


[2018-11-15 12:47:32] sjon at hortensius dot net

Hi petk, thanks for your fix. However, this issue still / again exists




The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

https://bugs.php.net/bug.php?id=76961


--
Edit this bug report at https://bugs.php.net/bug.php?id=76961=1

-- 
PHP Webmaster List Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] Bug #76961 [ReO->Ver]: https://bugs.php.net/vote.php throws a Server Error over ipv6

2018-11-23 Thread petk 
Edit report at https://bugs.php.net/bug.php?id=76961=1

 ID: 76961
 Updated by: p...@php.net
 Reported by:sjon at hortensius dot net
 Summary:https://bugs.php.net/vote.php throws a Server Error
 over ipv6
-Status: Re-Opened
+Status: Verified
 Type:   Bug
 Package:Website problem
 PHP Version:Irrelevant
-Assigned To:petk
+Assigned To:
 Block user comment: N
 Private report: N



Previous Comments:

[2018-11-15 14:15:04] c...@php.net

Oops, I've meant .  Before
I voted, there was only a single vote.

Just voted on  (also while
being logged out), and it worked fine.

> The code uses ip2long which doesn't work for ipv6 - also, the
> schema uses int(10) instead of varbinary(16) 

Aha!  Re-opening.


[2018-11-15 14:10:29] sjon at hortensius dot net

Maybe this is caused by me using ipv6. The code uses ip2long which doesn't work 
for ipv6 - also, the schema uses int(10) instead of varbinary(16)


[2018-11-15 14:05:19] sjon at hortensius dot net

are you sure? Because your vote doesn't show in that bugreport? I tried voting 
on https://bugs.php.net/bug.php?id=77163 but I get a 500-server-error. There 
should be an exception logged somewhere accordingly?


[2018-11-15 13:43:29] c...@php.net

While being logged out, I just voted on bug 77155, and it worked
as expected.


[2018-11-15 12:47:32] sjon at hortensius dot net

Hi petk, thanks for your fix. However, this issue still / again exists




The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

https://bugs.php.net/bug.php?id=76961


--
Edit this bug report at https://bugs.php.net/bug.php?id=76961=1

-- 
PHP Webmaster List Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-WEBMASTER] PHP version upgrade on pecl.php.net

2018-11-23 Thread Peter Kokot 
Hello,

worth noting that the web application
https://git.php.net/?p=web/pecl.git has been adjusted to work on PHP
7.2 and even 7.3 already.

There are some warnings and notices thrown by some outdated PEAR code
here and there (part of the PEAR core package that comes with a system
PHP installation on the server) but nothing that would stop app from
running. Current code is written for 5.6+ and it would help bring app
a bit further.

With few remaining tweaks in the code, in this phase I'm just checking
if this is something doable and planned one day...

Would it be possible to upgrade PHP on the server to 7.2 or 7.3?

Thank you for any possible info on this.

--
Peter Kokot

-- 
PHP Webmaster List Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php