Re: [PHP-DOC] Doc for Pecl PHP Judy
Hmm, I messed up something... :/ There is definitely some installation step, there is a configure.xml in the doc. I probably did a wrong link somewhere, I will take a look later today. On Tue, Oct 26, 2010 at 5:02 AM, Richard Quadling rquadl...@gmail.com wrote: On 25 October 2010 19:48, Nicolas Brousse nico...@brousse.info wrote: Thanks Philip for the feedback. I started to do all the clean up you suggested. I will continue to document later tonight. On Mon, Oct 25, 2010 at 9:51 AM, Philip Olson phi...@roshambo.org wrote: On Oct 24, 2010, at 5:00 PM, Nicolas Brousse wrote: Hi, Last month I did a php binding for the libJudy, It's in pecl, I also started to do the doc, you can find it here : http://svn.php.net/viewvc/pecl/judy/trunk/doc/ Is there any requirement to get this on the site ? Should I commit the chunked xhtml version ? Btw, I could do the doc in English and French if needed. Greetings Nicolas, Please commit the XML as we generate the HTML every week. Also it looks good but a few minor notes: - Please fix the whitespace. One space, no tabs, and lines should be around 80 characters although not a major deal (just not 200... ;) - Don't commit entities.* files or book.developer.xml - Please change the ReturnType and Description place holders before committing - And please update the versions.xml before committing Then, commit as phpdoc/en/trunk/reference/judy/, and the doc-base/manual.xml.in change. Excellent :) Regards, Philip The Installation page for Judy [1] says ... There is no installation needed to use these functions; they are part of the PHP core. I thought Judy is PECL extension and not part of core (at least not in the 5.3 branch [2] or trunk [3]), and as such, the expected xml would be ... section xml:id=judy.installation reftitle.install; para pecl.info; link xlink:href=url.pecl.package;judyurl.pecl.package;judy/link /para /section Richard. [1] http://docs.php.net/manual/en/judy.installation.php [2] http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/ext/ [3] http://svn.php.net/viewvc/php/php-src/trunk/ext/ -- Richard Quadling Twitter : EE : Zend @RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY
Re: [PHP-DOC] Doc for Pecl PHP Judy
I just commited a fix to the doc. I will update the wiki too. On Tue, Oct 26, 2010 at 9:12 AM, Nicolas Brousse nico...@brousse.info wrote: Hmm, I messed up something... :/ There is definitely some installation step, there is a configure.xml in the doc. I probably did a wrong link somewhere, I will take a look later today. On Tue, Oct 26, 2010 at 5:02 AM, Richard Quadling rquadl...@gmail.com wrote: On 25 October 2010 19:48, Nicolas Brousse nico...@brousse.info wrote: Thanks Philip for the feedback. I started to do all the clean up you suggested. I will continue to document later tonight. On Mon, Oct 25, 2010 at 9:51 AM, Philip Olson phi...@roshambo.org wrote: On Oct 24, 2010, at 5:00 PM, Nicolas Brousse wrote: Hi, Last month I did a php binding for the libJudy, It's in pecl, I also started to do the doc, you can find it here : http://svn.php.net/viewvc/pecl/judy/trunk/doc/ Is there any requirement to get this on the site ? Should I commit the chunked xhtml version ? Btw, I could do the doc in English and French if needed. Greetings Nicolas, Please commit the XML as we generate the HTML every week. Also it looks good but a few minor notes: - Please fix the whitespace. One space, no tabs, and lines should be around 80 characters although not a major deal (just not 200... ;) - Don't commit entities.* files or book.developer.xml - Please change the ReturnType and Description place holders before committing - And please update the versions.xml before committing Then, commit as phpdoc/en/trunk/reference/judy/, and the doc-base/manual.xml.in change. Excellent :) Regards, Philip The Installation page for Judy [1] says ... There is no installation needed to use these functions; they are part of the PHP core. I thought Judy is PECL extension and not part of core (at least not in the 5.3 branch [2] or trunk [3]), and as such, the expected xml would be ... section xml:id=judy.installation reftitle.install; para pecl.info; link xlink:href=url.pecl.package;judyurl.pecl.package;judy/link /para /section Richard. [1] http://docs.php.net/manual/en/judy.installation.php [2] http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/ext/ [3] http://svn.php.net/viewvc/php/php-src/trunk/ext/ -- Richard Quadling Twitter : EE : Zend @RQuadling : e-e.com/M_248814.html : bit.ly/9O8vFY
Re: [PHP-DOC] Doc for Pecl PHP Judy
Thanks Philip for the feedback. I started to do all the clean up you suggested. I will continue to document later tonight. On Mon, Oct 25, 2010 at 9:51 AM, Philip Olson phi...@roshambo.org wrote: On Oct 24, 2010, at 5:00 PM, Nicolas Brousse wrote: Hi, Last month I did a php binding for the libJudy, It's in pecl, I also started to do the doc, you can find it here : http://svn.php.net/viewvc/pecl/judy/trunk/doc/ Is there any requirement to get this on the site ? Should I commit the chunked xhtml version ? Btw, I could do the doc in English and French if needed. Greetings Nicolas, Please commit the XML as we generate the HTML every week. Also it looks good but a few minor notes: - Please fix the whitespace. One space, no tabs, and lines should be around 80 characters although not a major deal (just not 200... ;) - Don't commit entities.* files or book.developer.xml - Please change the ReturnType and Description place holders before committing - And please update the versions.xml before committing Then, commit as phpdoc/en/trunk/reference/judy/, and the doc-base/manual.xml.in change. Excellent :) Regards, Philip
[PHP-DOC] Doc for Pecl PHP Judy
Hi, Last month I did a php binding for the libJudy, It's in pecl, I also started to do the doc, you can find it here : http://svn.php.net/viewvc/pecl/judy/trunk/doc/ Is there any requirement to get this on the site ? Should I commit the chunked xhtml version ? Btw, I could do the doc in English and French if needed. Regards, Nicolas
