Re: [PHP-DOC] Indentation in mysql examples

2002-05-04 Thread Gabor Hojtsy

  ANyway, I think indenting everything with four spaces adds a lot to
  readbility in code, as your left margin is usually the most left
  pixel of your screen. 
  Derick
 
 But couldn't it be done automagically during html generation process?

Part of the things can be done. If guys decide to indent all lines with
two spaces, we can do the indentation. There's no need to indent all
example lines with 1-2-3-4 spaces, if we can do it while generating...

Goba





Re: [PHP-DOC] Indentation in mysql examples

2002-05-03 Thread derick

On Fri, 3 May 2002, Egon Schmid wrote:

 From: Simone Cortesi [EMAIL PROTECTED]
  At 00.24 03/05/02 +0200, =?iso-8859-2?Q?S=B3awomir_Pucia?= wrote:
 
  Probably you didn't get the point.
  
  Since 1.101 many examples look like...
  
  ?php
   /* Connecting, selecting database */
   $link = mysql_connect(mysql_host, mysql_user,
 mysql_password)
   or die(Could not connect);
   print Connected successfully;
  [...]
  
  Until 1.101 they looked like...
  
  ?php
  /* Connecting, selecting database */
  $link = mysql_connect(mysql_host, mysql_user,
 mysql_password)
   or die(Could not connect);
  print Connected successfully;
  [...]
  
  The question is whether or not to use these 4 spaces in each
 line. If yes, I
  will correct the rest of mysql related files, and use it in pl/.
 
  I've read that we should start at column 1 in examples:
 
  Take a look at: /phpdoc/RFC/coding_standards
 
 Oh, it seems that Derick haven´t read the coding_standards :(

Oh, btw, it sais 3. The contents of examples with programlistings start 
on column 0 in the XML code. IMO ?php is also code, and just like { or } 
and thus need indentation, but that is my opinion. ANyway, I think 
indenting everything with four spaces adds a lot to readbility in code, as 
your left margin is usually the most left pixel of your screen. 

Derick

---
 Did I help you? http://www.amazon.co.uk/exec/obidos/registry/SLCB276UZU8B
 Frequent ranting: http://www.jdimedia.nl/derick/
---
 PHP: Scripting the Web - [EMAIL PROTECTED]
All your branches are belong to me!
SRM: Script Running Machine - www.vl-srm.net
---




Re: [PHP-DOC] Indentation in mysql examples

2002-05-03 Thread Georg Richter

On Friday, 3. May 2002 08:25, [EMAIL PROTECTED] wrote:

 Oh, btw, it sais 3. The contents of examples with programlistings start
 on column 0 in the XML code. IMO ?php is also code, and just like { or }
 and thus need indentation, but that is my opinion. ANyway, I think
 indenting everything with four spaces adds a lot to readbility in code, as
 your left margin is usually the most left pixel of your screen.

 Derick

+1
Its easier to read, when the lines between ?php and ? are indented.
It could be only a problem, when the lines are too long.

Some weeks before I made a workaround, but didn't changed the complete 
identation (only these examples, which are wrong or had to be corrected).

Georg



Re: [PHP-DOC] Indentation in mysql examples

2002-05-03 Thread Friedhelm Betz


Hi,

 On Fri, 3 May 2002, Egon Schmid wrote:

 From: Simone Cortesi [EMAIL PROTECTED]
  At 00.24 03/05/02 +0200, =?iso-8859-2?Q?S=B3awomir_Pucia?= wrote:
 
  Probably you didn't get the point.
  
  Since 1.101 many examples look like...
  
  ?php
   /* Connecting, selecting database */
   $link = mysql_connect(mysql_host, mysql_user,
 mysql_password)
   or die(Could not connect);
   print Connected successfully;
  [...]
  
  Until 1.101 they looked like...
  
  ?php
  /* Connecting, selecting database */
  $link = mysql_connect(mysql_host, mysql_user,
 mysql_password)
   or die(Could not connect);
  print Connected successfully;
  [...]
  
  The question is whether or not to use these 4 spaces in each
 line. If yes, I
  will correct the rest of mysql related files, and use it in pl/.
 
  I've read that we should start at column 1 in examples:
 
  Take a look at: /phpdoc/RFC/coding_standards
 
 Oh, it seems that Derick haven´t read the coding_standards :(

 Oh, btw, it sais 3. The contents of examples with programlistings start 
 on column 0 in the XML code. IMO ?php is also code, and just like { or } 
 and thus need indentation, but that is my opinion. ANyway, I think 
 indenting everything with four spaces adds a lot to readbility in code, as 
 your left margin is usually the most left pixel of your screen. 

Hey, it was me who collected some mails from the list and from the
howto. This coding_standard in RFC is only a draft and starting point for
discussions. Once a descision is made (if ever), the things should go into the
howto. So far I understand this RFC directory:-)

From the protocol of the meeting in Stuttgart:
17. Examples
The examples in the manual should be more consistent and useful. A
draft styleguide alredy exists under phpdoc/RFC/coding_standards.

officially identation is not descided.. :-)
If the examples are more useful with identation everything it's ok,
why not?
The only thing to keep in mind is: there are some examples with very
long lines and ident everything (also ?php) could probably break the
layout.

What about starting with ?php at column 2 and ident everything else
with 4 spaces?

 Friedhelm   




Re: [PHP-DOC] Indentation in mysql examples

2002-05-03 Thread Slawomir Pucia

 ANyway, I think indenting everything with four spaces adds a lot to
 readbility in code, as your left margin is usually the most left
 pixel of your screen. 
 Derick

But couldn't it be done automagically during html generation process?


slawek-






[PHP-DOC] Indentation in mysql examples

2002-05-02 Thread Sawomir Pucia

Could someone (maybe Derick) please explain why indentation of many (half?)
examples in mysql.xml (revision 1.101) have been changed? Now we have half
of the examples indented (4 spaces) and half not. Now I'm confused with
applying these changes to pl/. IMHO we should go back to non-indented
examples (as in the rest of chapters).

slawek-





Re: [PHP-DOC] Indentation in mysql examples

2002-05-02 Thread Egon Schmid

From: Sawomir Pucia [EMAIL PROTECTED]

 Could someone (maybe Derick) please explain why indentation of
many (half?)
 examples in mysql.xml (revision 1.101) have been changed? Now we
have half
 of the examples indented (4 spaces) and half not. Now I'm confused
with
 applying these changes to pl/. IMHO we should go back to
non-indented
 examples (as in the rest of chapters).

Since the beginning of the English PHP Manual, there have been 4
spaces in examples. You can correct this in en/ and use it in the
pl/ tree.

-Egon




Re: [PHP-DOC] Indentation in mysql examples

2002-05-02 Thread Sawomir Pucia

 Could someone (maybe Derick) please explain why indentation of many
 (half?) examples in mysql.xml (revision 1.101) have been changed?
 Now we have half of the examples indented (4 spaces) and half not.
 Now I'm confused with applying these changes to pl/. IMHO we should
 go back to non-indented examples (as in the rest of chapters).

 Since the beginning of the English PHP Manual, there have been 4
 spaces in examples. You can correct this in en/ and use it in the
 pl/ tree.

Probably you didn't get the point.

Since 1.101 many examples look like...

?php
/* Connecting, selecting database */
$link = mysql_connect(mysql_host, mysql_user, mysql_password)
or die(Could not connect);
print Connected successfully;
[...]

Until 1.101 they looked like...

?php
/* Connecting, selecting database */
$link = mysql_connect(mysql_host, mysql_user, mysql_password)
or die(Could not connect);
print Connected successfully;
[...]

The question is whether or not to use these 4 spaces in each line. If yes, I
will correct the rest of mysql related files, and use it in pl/.

slawek-





Re: [PHP-DOC] Indentation in mysql examples

2002-05-02 Thread Simone Cortesi

At 00.24 03/05/02 +0200, =?iso-8859-2?Q?S=B3awomir_Pucia?= wrote:

Probably you didn't get the point.

Since 1.101 many examples look like...

?php
 /* Connecting, selecting database */
 $link = mysql_connect(mysql_host, mysql_user, mysql_password)
 or die(Could not connect);
 print Connected successfully;
[...]

Until 1.101 they looked like...

?php
/* Connecting, selecting database */
$link = mysql_connect(mysql_host, mysql_user, mysql_password)
 or die(Could not connect);
print Connected successfully;
[...]

The question is whether or not to use these 4 spaces in each line. If yes, I
will correct the rest of mysql related files, and use it in pl/.

I've read that we should start at column 1 in examples:

Take a look at: /phpdoc/RFC/coding_standards


-- 
Tutto e' possibile in Maggio.
   In May, everything is possible. -- Mario Bisio.




Re: [PHP-DOC] Indentation in mysql examples

2002-05-02 Thread Egon Schmid

From: Simone Cortesi [EMAIL PROTECTED]
 At 00.24 03/05/02 +0200, =?iso-8859-2?Q?S=B3awomir_Pucia?= wrote:

 Probably you didn't get the point.
 
 Since 1.101 many examples look like...
 
 ?php
  /* Connecting, selecting database */
  $link = mysql_connect(mysql_host, mysql_user,
mysql_password)
  or die(Could not connect);
  print Connected successfully;
 [...]
 
 Until 1.101 they looked like...
 
 ?php
 /* Connecting, selecting database */
 $link = mysql_connect(mysql_host, mysql_user,
mysql_password)
  or die(Could not connect);
 print Connected successfully;
 [...]
 
 The question is whether or not to use these 4 spaces in each
line. If yes, I
 will correct the rest of mysql related files, and use it in pl/.

 I've read that we should start at column 1 in examples:

 Take a look at: /phpdoc/RFC/coding_standards

Oh, it seems that Derick haven´t read the coding_standards :(

-Egon




Re: [PHP-DOC] Indentation in mysql examples

2002-05-02 Thread derick

On Fri, 3 May 2002, Egon Schmid wrote:

 From: Simone Cortesi [EMAIL PROTECTED]
  At 00.24 03/05/02 +0200, =?iso-8859-2?Q?S=B3awomir_Pucia?= wrote:
 
  Probably you didn't get the point.
  
  Since 1.101 many examples look like...
  
  ?php
   /* Connecting, selecting database */
   $link = mysql_connect(mysql_host, mysql_user,
 mysql_password)
   or die(Could not connect);
   print Connected successfully;
  [...]
  
  Until 1.101 they looked like...
  
  ?php
  /* Connecting, selecting database */
  $link = mysql_connect(mysql_host, mysql_user,
 mysql_password)
   or die(Could not connect);
  print Connected successfully;
  [...]
  
  The question is whether or not to use these 4 spaces in each
 line. If yes, I
  will correct the rest of mysql related files, and use it in pl/.
 
  I've read that we should start at column 1 in examples:
 
  Take a look at: /phpdoc/RFC/coding_standards
 
 Oh, it seems that Derick haven´t read the coding_standards :(

I did, but it just sucks :) The four spaces indent looks much better.

Derick

---
 Did I help you? http://www.amazon.co.uk/exec/obidos/registry/SLCB276UZU8B
 Frequent ranting: http://www.jdimedia.nl/derick/
---
 PHP: Scripting the Web - [EMAIL PROTECTED]
All your branches are belong to me!
SRM: Script Running Machine - www.vl-srm.net
---