Re: [PHP-DOC] Improvements on revcheck.php script

2010-10-14 Thread Alexey Shein
One more little fix for revcheck.php: fixes directory name for files
situated in the root translation dir, was: ./en, now / (see Files
section).
Index: doc-base/scripts/revcheck.php
===
--- doc-base/scripts/revcheck.php	(revision 304390)
+++ doc-base/scripts/revcheck.php	(working copy)
@@ -897,8 +897,8 @@
   // Store the new actual directory
   $prev_dir = $new_dir;
 }
-// Drop out the unneeded parts from the dirname...
-$display_dir = str_replace($DOCDIR.en/, , dirname($file[full_name]));
+// Drop out the unneeded parts from the dirname, special case for root dir...
+$display_dir = str_replace(array($DOCDIR.en/, $DOCDIR.en), array(, '/'), dirname($file[full_name]));
 $prev_diplay_dir = tr class=blueth colspan=12$display_dir;
 
 // Save the line for the current file (get file name shorter)


Re: [PHP-DOC] Improvements on revcheck.php script

2010-10-11 Thread Philip Olson

On Oct 11, 2010, at 1:05 AM, Alexey Shein wrote:

 Hello!
 I've made some improvements of revcheck.php script and hope you'll
 like them too so they could be taken into the svn:
 1) fixed E_NOTICE errors
 2) added console option --show-uptodate, which if supplied will also
 show all up-to-date files in documentation. It can be useful to track
 the translation progress with very obsolete status (as Russian one,
 for example) so after some change translator will see one more green
 (up-to-date) file than one less orange (untranslated) file from other
 same orange 8.
 I tried to keep BC as much as possible, hope there is no errors (at
 least new :)).

Greetings Alexey,

Looks good, this patch has been committed. Thanks for improving the PHP 
Documentation, and looking forward to seeing more ;)

Regards,
Philip



Re: [PHP-DOC] Improvements on revcheck.php script

2010-10-11 Thread Alexey Shein
2010/10/12 Philip Olson phi...@roshambo.org:

 On Oct 11, 2010, at 1:05 AM, Alexey Shein wrote:

 Hello!
 I've made some improvements of revcheck.php script and hope you'll
 like them too so they could be taken into the svn:
 1) fixed E_NOTICE errors
 2) added console option --show-uptodate, which if supplied will also
 show all up-to-date files in documentation. It can be useful to track
 the translation progress with very obsolete status (as Russian one,
 for example) so after some change translator will see one more green
 (up-to-date) file than one less orange (untranslated) file from other
 same orange 8.
 I tried to keep BC as much as possible, hope there is no errors (at
 least new :)).

 Greetings Alexey,

 Looks good, this patch has been committed. Thanks for improving the PHP 
 Documentation, and looking forward to seeing more ;)

 Regards,
 Philip



Thanks.


-- 
Regards,
Shein Alexey