Re: [piccolo2d-dev] Re: Release Piccolo2D.Java 1.3
Chris wrote: This release is generally solid, with the exception of the pswing package. Since issue 163 has been reopened, and since I've investigated further, I think that pswing has some new problems that weren't in 1.2 (issue 163 being an example). I can't +1 the release, since my client (PhET) relies heavily on pswing. But I can't -1 the release because I think that fixing pswing and bringing it up to the same standards as the reset of Piccolo2D is going to take considerable time, and I hate to see 1.3 delayed any longer. If issue 163 were fixed, would that change your vote to +1? I wouldn't mind waiting 1.3 until that were the case. If anyone else feels strongly about pswing, then my lack of confidence in its current state may influence your vote. Otherwise, I think PhET should take the lead in fixing improving whatever version of pswing ships with 1.3. PhET uses it heavily, in some complex situations, and contributed it in (more or less) its current state. I would prefer to see PhET using a proper Piccolo2D release rather than maintaining a private fork, let us know what it will take to make that happen. michael -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Release Piccolo2D.Java 1.3
Yes, if 163 were fixed, that would change my vote to +1. 163 is the only know problem with pswing. The other gripes I have with it are internals, and that can certainly wait. On Mar 9, 9:42 am, Michael Heuer heue...@gmail.com wrote: Chris wrote: This release is generally solid, with the exception of the pswing package. Since issue 163 has been reopened, and since I've investigated further, I think that pswing has some new problems that weren't in 1.2 (issue 163 being an example). I can't +1 the release, since my client (PhET) relies heavily on pswing. But I can't -1 the release because I think that fixing pswing and bringing it up to the same standards as the reset of Piccolo2D is going to take considerable time, and I hate to see 1.3 delayed any longer. If issue 163 were fixed, would that change your vote to +1? I wouldn't mind waiting 1.3 until that were the case. If anyone else feels strongly about pswing, then my lack of confidence in its current state may influence your vote. Otherwise, I think PhET should take the lead in fixing improving whatever version of pswing ships with 1.3. PhET uses it heavily, in some complex situations, and contributed it in (more or less) its current state. I would prefer to see PhET using a proper Piccolo2D release rather than maintaining a private fork, let us know what it will take to make that happen. michael -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly
Comment #23 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 component.revalidate calls PSwingRepaintManager.addInvalidComponent, which calls PSwing.updateBounds. So calls to revalidate will result in calls to updateBounds. In PSwing r930, there are 3 calls to updateBounds in listeners (lines 325,523,527). If I replace those calls with component.revalidate, things seem to work correctly, but the PSwing's components visibly changes its layout (looks jerky) when it's repainted. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
Re: [piccolo2d-dev] [VOTE] Release Piccolo2D.Java 1.3
--- [X ] +1 I support this release [ ] +0 [ ] -0 [ ] -1 I oppose this release because... -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly
Comment #24 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 More general issue... I don't understand why we need to explicitly call component.revalidate. When (for example) ComponentListener.componentResized is called, why is the component's size/preferredSize invalid? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 163 in piccolo2d: PSwing doesn't draw dynamic JComponent properly
Comment #25 on issue 163 by cmal...@pixelzoom.com: PSwing doesn't draw dynamic JComponent properly http://code.google.com/p/piccolo2d/issues/detail?id=163 TestPSwingDynamicComponent has a PSwing wrapping a JPanel, which contains 3 JComponents. I added this debug output to the ComponentListener added in PSwing.initializeComponent: System.out.println( PSwing$ComponentAdapter.componentResized + e.getComponent().getClass().getName() ); When the text of one of the panel's JComponents is changed, PSwing's ComponentListener.componentResized is called 4 times, here's the debug output: PSwing$ComponentAdapter.componentResized edu.colorado.phet.common.piccolophet.test.TestPSwingDynamicComponent$ComponentPanel PSwing$ComponentAdapter.componentResized javax.swing.JLabel PSwing$ComponentAdapter.componentResized javax.swing.JCheckBox PSwing$ComponentAdapter.componentResized javax.swing.JRadioButton So this is likely the source of the what I described as jerky behavior. It's described elsewhere in descriptions of revalidate/validate/invalidate as flickering. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
