[jira] Commented: (PIG-1596) NPE's thrown when attempting to load hbase columns containing null values

2010-09-05 Thread Jeff Zhang (JIRA)

[ 
https://issues.apache.org/jira/browse/PIG-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906418#action_12906418
 ] 

Jeff Zhang commented on PIG-1596:
-

Combine the new test case with existing ones. And commit the patch to both 
trunk and branch-0.8



> NPE's thrown when attempting to load hbase columns containing null values
> -
>
> Key: PIG-1596
> URL: https://issues.apache.org/jira/browse/PIG-1596
> Project: Pig
>  Issue Type: Bug
>  Components: data
>Affects Versions: 0.7.0
>Reporter: George P. Stathis
> Fix For: 0.8.0
>
> Attachments: null_hbase_records.patch, PIG_1596.patch, 
> PIG_1596_2.patch
>
>
> I'm not a committer, but I'd like to suggest the attached patch to handle 
> loading hbase rows containing null cell values (since hbase is all about 
> sparsly populated data rows). As it stands, a DataByteArray can be created 
> with a null mData if a cell has no value, which causes NPEs by simply 
> attempting to load a row containing the null cell in question.
> PS: the attached patch also contains a slight change to the bin/pig 
> executable to point to the build/pig\-\*\-SNAPSHOT.jar and not the 
> build/pig\-\*\-dev.jar (the latter no longer seems to exist). If you prefer a 
> separate patch for this, I'll be happy to submit it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Resolved: (PIG-1596) NPE's thrown when attempting to load hbase columns containing null values

2010-09-05 Thread Jeff Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIG-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Zhang resolved PIG-1596.
-

Fix Version/s: (was: 0.9.0)
   Resolution: Fixed

> NPE's thrown when attempting to load hbase columns containing null values
> -
>
> Key: PIG-1596
> URL: https://issues.apache.org/jira/browse/PIG-1596
> Project: Pig
>  Issue Type: Bug
>  Components: data
>Affects Versions: 0.7.0
>Reporter: George P. Stathis
> Fix For: 0.8.0
>
> Attachments: null_hbase_records.patch, PIG_1596.patch, 
> PIG_1596_2.patch
>
>
> I'm not a committer, but I'd like to suggest the attached patch to handle 
> loading hbase rows containing null cell values (since hbase is all about 
> sparsly populated data rows). As it stands, a DataByteArray can be created 
> with a null mData if a cell has no value, which causes NPEs by simply 
> attempting to load a row containing the null cell in question.
> PS: the attached patch also contains a slight change to the bin/pig 
> executable to point to the build/pig\-\*\-SNAPSHOT.jar and not the 
> build/pig\-\*\-dev.jar (the latter no longer seems to exist). If you prefer a 
> separate patch for this, I'll be happy to submit it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (PIG-1602) The .classpath of eclipse template still use hbase-0.20.0

2010-09-05 Thread Jeff Zhang (JIRA)
The .classpath of eclipse template still use hbase-0.20.0
-

 Key: PIG-1602
 URL: https://issues.apache.org/jira/browse/PIG-1602
 Project: Pig
  Issue Type: Bug
Affects Versions: 0.8.0
Reporter: Jeff Zhang
Assignee: Jeff Zhang
Priority: Minor
 Fix For: 0.8.0


The .classpath of eclipse template still use hbase-0.20.0, it should be updated 
to hbase-0.20.6

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (PIG-1602) The .classpath of eclipse template still use hbase-0.20.0

2010-09-05 Thread Jeff Zhang (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIG-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Zhang updated PIG-1602:


Attachment: PIG_1602.patch

> The .classpath of eclipse template still use hbase-0.20.0
> -
>
> Key: PIG-1602
> URL: https://issues.apache.org/jira/browse/PIG-1602
> Project: Pig
>  Issue Type: Bug
>Affects Versions: 0.8.0
>Reporter: Jeff Zhang
>Assignee: Jeff Zhang
>Priority: Minor
> Fix For: 0.8.0
>
> Attachments: PIG_1602.patch
>
>
> The .classpath of eclipse template still use hbase-0.20.0, it should be 
> updated to hbase-0.20.6

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (PIG-1575) Complete the migration of optimization rule PushUpFilter including missing test cases

2010-09-05 Thread Daniel Dai (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIG-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Dai updated PIG-1575:


  Status: Resolved  (was: Patch Available)
Hadoop Flags: [Reviewed]
  Resolution: Fixed

> Complete the migration of optimization rule PushUpFilter including missing 
> test cases
> -
>
> Key: PIG-1575
> URL: https://issues.apache.org/jira/browse/PIG-1575
> Project: Pig
>  Issue Type: Bug
>Reporter: Xuefu Zhang
>Assignee: Xuefu Zhang
> Fix For: 0.8.0
>
> Attachments: jira-1575-1.patch, jira-1575-2.patch, jira-1575-3.patch, 
> jira-1575-4.patch, jira-1575-5.patch
>
>
> The Optimization rule under the new logical plan, PushUpFilter, only does a 
> subset of optimization scenarios compared to the same rule under the old 
> logical plan. For instance, it only considers filter after join, but the old 
> optimization also considers other operators such as CoGroup, Union, Cross, 
> etc. The migration of the rule should be complete.
> Also, the test cases created for testing the old PushUpFilter wasn't migrated 
> to the new logical plan code base. It should be also migrated. (A few has 
> been migrated in JIRA-1574.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (PIG-1575) Complete the migration of optimization rule PushUpFilter including missing test cases

2010-09-05 Thread Daniel Dai (JIRA)

 [ 
https://issues.apache.org/jira/browse/PIG-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Dai updated PIG-1575:


Attachment: jira-1575-5.patch

Patch looks good. Attach the final patch. 

test patch result:
 [exec] +1 overall.  
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] +1 tests included.  The patch appears to include 6 new or 
modified tests.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.

All tests pass.

Patch committed to both trunk and 0.8 branch.

> Complete the migration of optimization rule PushUpFilter including missing 
> test cases
> -
>
> Key: PIG-1575
> URL: https://issues.apache.org/jira/browse/PIG-1575
> Project: Pig
>  Issue Type: Bug
>Reporter: Xuefu Zhang
>Assignee: Xuefu Zhang
> Fix For: 0.8.0
>
> Attachments: jira-1575-1.patch, jira-1575-2.patch, jira-1575-3.patch, 
> jira-1575-4.patch, jira-1575-5.patch
>
>
> The Optimization rule under the new logical plan, PushUpFilter, only does a 
> subset of optimization scenarios compared to the same rule under the old 
> logical plan. For instance, it only considers filter after join, but the old 
> optimization also considers other operators such as CoGroup, Union, Cross, 
> etc. The migration of the rule should be complete.
> Also, the test cases created for testing the old PushUpFilter wasn't migrated 
> to the new logical plan code base. It should be also migrated. (A few has 
> been migrated in JIRA-1574.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.