[jira] Commented: (PIG-1565) additional piggybank datetime and string UDFs
[ https://issues.apache.org/jira/browse/PIG-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903123#action_12903123 ] Alan Gates commented on PIG-1565: - Comments # ErrorCatchingBase swallows any non-ExecExceptions. It should print their messages out as warnings. Warnings are collated and the count reported at the end of the job. Details are only printed if the user asks for them. That way the user will still be informed that something unexpected happened and can investigate further if he wants to. # On the duplication, it looks to me like INDEX_OF and LAST_INDEX_OF are supersets of the functions already in Pig. You could submit a patch for those two functions (which are now builtins) to extend them to take the optional third argument. SPLIT_ON_REGEX looks like a subset of the existing SPLIT function that is built into Pig, so other than having it as an alias so that Amazon users who are used to calling SPLIT_ON_REGEX I'm not clear what the value is. Thanks for contributing all these, this is great. I'll run test-patch and the unit tests and post the results. > additional piggybank datetime and string UDFs > - > > Key: PIG-1565 > URL: https://issues.apache.org/jira/browse/PIG-1565 > Project: Pig > Issue Type: Improvement >Reporter: Andrew Hitchcock > Attachments: PIG-1565-1.patch > > > Pig is missing a variety of UDFs that might be helpful for users implementing > Pig scripts. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1565) additional piggybank datetime and string UDFs
[ https://issues.apache.org/jira/browse/PIG-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903140#action_12903140 ] Dmitriy V. Ryaboy commented on PIG-1565: Please note that there's an outstanding patch for INDEX_OF and LAST_INDEX_OF in PIG-1563 > additional piggybank datetime and string UDFs > - > > Key: PIG-1565 > URL: https://issues.apache.org/jira/browse/PIG-1565 > Project: Pig > Issue Type: Improvement >Reporter: Andrew Hitchcock >Assignee: Andrew Hitchcock > Fix For: 0.8.0 > > Attachments: PIG-1565-1.patch > > > Pig is missing a variety of UDFs that might be helpful for users implementing > Pig scripts. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1565) additional piggybank datetime and string UDFs
[ https://issues.apache.org/jira/browse/PIG-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903174#action_12903174 ] Alan Gates commented on PIG-1565: - [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 5 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] > additional piggybank datetime and string UDFs > - > > Key: PIG-1565 > URL: https://issues.apache.org/jira/browse/PIG-1565 > Project: Pig > Issue Type: Improvement >Reporter: Andrew Hitchcock >Assignee: Andrew Hitchcock > Fix For: 0.8.0 > > Attachments: PIG-1565-1.patch > > > Pig is missing a variety of UDFs that might be helpful for users implementing > Pig scripts. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1565) additional piggybank datetime and string UDFs
[
https://issues.apache.org/jira/browse/PIG-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903515#action_12903515
]
Alan Gates commented on PIG-1565:
-
Unit tests run fine.
When I run contrib tests, one of the tests in this patch fails:
{code}
Testsuite: org.apache.pig.piggybank.test.evaluation.string.TestString
Tests run: 2, Failures: 1, Errors: 0, Time elapsed: 0.751 sec
- Standard Error -
10/08/27 11:16:31 WARN string.SUBSTRING: invalid number of arguments to
SUBSTRING
- ---
Testcase: testSimple took 0.683 sec
FAILED
expected: but was:
junit.framework.AssertionFailedError: expected: but was:
at org.apache.pig.piggybank.test.evaluation.string.TestString.go(Unknown
Source)
at
org.apache.pig.piggybank.test.evaluation.string.TestString.testSimple(Unknown
Source)
Testcase: testFormatTypes took 0.048 sec
{code}
> additional piggybank datetime and string UDFs
> -
>
> Key: PIG-1565
> URL: https://issues.apache.org/jira/browse/PIG-1565
> Project: Pig
> Issue Type: Improvement
>Reporter: Andrew Hitchcock
>Assignee: Andrew Hitchcock
> Fix For: 0.8.0
>
> Attachments: PIG-1565-1.patch
>
>
> Pig is missing a variety of UDFs that might be helpful for users implementing
> Pig scripts.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1565) additional piggybank datetime and string UDFs
[ https://issues.apache.org/jira/browse/PIG-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913869#action_12913869 ] Alan Gates commented on PIG-1565: - I'll review this patch. > additional piggybank datetime and string UDFs > - > > Key: PIG-1565 > URL: https://issues.apache.org/jira/browse/PIG-1565 > Project: Pig > Issue Type: Improvement >Reporter: Andrew Hitchcock >Assignee: Andrew Hitchcock > Fix For: 0.8.0 > > Attachments: PIG-1565-1.patch, PIG-1565-2.patch > > > Pig is missing a variety of UDFs that might be helpful for users implementing > Pig scripts. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1565) additional piggybank datetime and string UDFs
[ https://issues.apache.org/jira/browse/PIG-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917081#action_12917081 ] Alan Gates commented on PIG-1565: - [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 8 new or modified tests. [exec] [exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] The javadoc warning is: [javadoc] /home/gates/src/pig/PIG-1565/trunk/src/org/apache/pig/builtin/INDEXOF.java:78: warning - Tag @link: can't find INDEX_OF(int, int) in java.lang.String Building Piggybank now fails as well, since some of the ErrorCatchingBase class was moved into main Pig. Also, the patch fails a couple of unit tests in TestStringUDFs. It fails testIndexOf and testLastIndexOf() because it doesn't properly handle the null case. I'll attach the output from running the tests. > additional piggybank datetime and string UDFs > - > > Key: PIG-1565 > URL: https://issues.apache.org/jira/browse/PIG-1565 > Project: Pig > Issue Type: Improvement >Reporter: Andrew Hitchcock >Assignee: Andrew Hitchcock > Fix For: 0.8.0 > > Attachments: PIG-1565-1.patch, PIG-1565-2.patch > > > Pig is missing a variety of UDFs that might be helpful for users implementing > Pig scripts. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
