Re: [Piglit] [PATCH 2/4] cmake: Don't rely on pkg-config for all Windows builds.
On 15/12/14 19:47, Emil Velikov wrote: On 15/12/14 12:19, Jose Fonseca wrote: From: José Fonseca jfons...@vmware.com Instead of just MSVC builds. Because pkg-config is not commonly available when compiling natively on Windows, and gives the wrong results (the host package instead of target package) when cross-compiling to Windows. Short version: Also might be worth checking Dylan's fixes (touching both waffle and piglit). And then build on top if needed. Yes, Dylan's changes eliminate the need of most of these. But I'm pushing this series as is for now, so I can upgrade all my build/test slave machines to start using waffle on Windows. Jose ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] glsl-deriv-varyings: Fixes recently introduced compilation warnings
---
tests/shaders/glsl-deriv-varyings.c | 86 -
1 file changed, 86 deletions(-)
diff --git a/tests/shaders/glsl-deriv-varyings.c
b/tests/shaders/glsl-deriv-varyings.c
index fa72eec..33511de 100644
--- a/tests/shaders/glsl-deriv-varyings.c
+++ b/tests/shaders/glsl-deriv-varyings.c
@@ -51,10 +51,6 @@ static GLint prog2;
static GLint fs2;
static GLint prog3;
static GLint fs3;
-static GLint prog4;
-static GLint fs4;
-static GLint prog5;
-static GLint fs5;
static GLfloat verts[12] = {175.0, 125.0, 0.0,
@@ -105,26 +101,6 @@ static const char *fragShaderText3 =
0.0, 1.0);\n
} \n;
-static const char *fragShaderText4 =
- uniform sampler2D tex2d;\n
- varying vec2 texCoords;\n
- void main()\n
- { \n
- gl_FragColor = vec4(dFdx(abs(-texCoords.x)) * 40.0,\n
- dFdy(abs(-texCoords.y)) * 40.0,\n
- 0.0, 1.0);\n
- } \n;
-
-static const char *fragShaderText5 =
- uniform sampler2D tex2d;\n
- varying vec2 texCoords;\n
- void main()\n
- { \n
- gl_FragColor = vec4(dFdx(-abs(texCoords.x)) * -40.0,\n
- dFdy(-abs(texCoords.y) * -40.0,\n
- 0.0, 1.0);\n
- } \n;
-
void
@@ -154,16 +130,10 @@ compileLinkProg(void)
fs3 = glCreateShader(GL_FRAGMENT_SHADER);
- fs4 = glCreateShader(GL_FRAGMENT_SHADER);
-
- fs5 = glCreateShader(GL_FRAGMENT_SHADER);
-
glShaderSource(vs1, 1, (const GLchar **) vertShaderText, NULL);
glShaderSource(fs1, 1, (const GLchar **) fragShaderText, NULL);
glShaderSource(fs2, 1, (const GLchar **) fragShaderText2, NULL);
glShaderSource(fs3, 1, (const GLchar **) fragShaderText3, NULL);
- glShaderSource(fs4, 1, (const GLchar **) fragShaderText3, NULL);
- glShaderSource(fs5, 1, (const GLchar **) fragShaderText3, NULL);
glCompileShader(vs1);
glGetShaderiv(vs1, GL_COMPILE_STATUS, stat);
@@ -193,20 +163,6 @@ compileLinkProg(void)
exit(1);
}
- glCompileShader(fs4);
- glGetShaderiv(fs4, GL_COMPILE_STATUS, stat);
- if (!stat) {
- printf(error compiling fragment shader4!\n);
- exit(1);
- }
-
- glCompileShader(fs5);
- glGetShaderiv(fs5, GL_COMPILE_STATUS, stat);
- if (!stat) {
- printf(error compiling fragment shader5!\n);
- exit(1);
- }
-
prog1 = glCreateProgram();
glAttachShader(prog1, vs1);
@@ -251,36 +207,6 @@ compileLinkProg(void)
texCoords);
glEnableVertexAttribArray(0);
glEnableVertexAttribArray(1);
-
-
- prog4 = glCreateProgram();
- glAttachShader(prog4, vs1);
- glAttachShader(prog4, fs4);
- glBindAttribLocation(prog4, 1, textureCoords);
- glLinkProgram(prog4);
- glUseProgram(prog4);
-
- glVertexAttribPointer(0, 3, GL_FLOAT, GL_FALSE, 3*sizeof(GLfloat),
- verts);
- glVertexAttribPointer(1, 2, GL_FLOAT, GL_FALSE, 2*sizeof(GLfloat),
- texCoords);
- glEnableVertexAttribArray(0);
- glEnableVertexAttribArray(1);
-
-
- prog5 = glCreateProgram();
- glAttachShader(prog5, vs1);
- glAttachShader(prog5, fs5);
- glBindAttribLocation(prog5, 1, textureCoords);
- glLinkProgram(prog5);
- glUseProgram(prog5);
-
- glVertexAttribPointer(0, 3, GL_FLOAT, GL_FALSE, 3*sizeof(GLfloat),
- verts);
- glVertexAttribPointer(1, 2, GL_FLOAT, GL_FALSE, 2*sizeof(GLfloat),
- texCoords);
- glEnableVertexAttribArray(0);
- glEnableVertexAttribArray(1);
}
static void
@@ -349,23 +275,11 @@ piglit_display(void)
glUseProgram(prog3);
glDrawArrays(GL_TRIANGLE_STRIP, 0, 4);
- glTranslatef(75.0, 0.0, 0.0);
-
- glUseProgram(prog4);
- glDrawArrays(GL_TRIANGLE_STRIP, 0, 4);
-
- glTranslatef(75.0, 0.0, 0.0);
-
- glUseProgram(prog5);
- glDrawArrays(GL_TRIANGLE_STRIP, 0, 4);
-
glPopMatrix();
pass = pass piglit_probe_pixel_rgb(132, 125, green);
pass = pass piglit_probe_pixel_rgb(205, 125, deriv);
pass = pass piglit_probe_pixel_rgb(280, 125, deriv);
- pass = pass piglit_probe_pixel_rgb(355, 125, deriv);
- pass = pass piglit_probe_pixel_rgb(430, 125, deriv);
glFinish();
piglit_present_results();
--
1.9.1
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] Fix recently introduced GCC warnings in glsl-deriv-varyings
Previous patch at: http://lists.freedesktop.org/archives/piglit/2014-December/013648.html Introduced a couple of GCC warnings in the last 2 newly introduced tests. After correcting the warnings I'm realizing these tests are exposing yet another bug, probably, in glReadPixels. This patch removes these 2 tests temporarily while I'm working in this new bug. I will re-introduce them once I have a solution for mesa. Andres Gomez (1): glsl-deriv-varyings: Fixes recently introduced compilation warnings tests/shaders/glsl-deriv-varyings.c | 86 - 1 file changed, 86 deletions(-) -- 1.9.1 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] deqp: Add test profile for external dEQP-GLES3 tests (v4)
Google opensourced the drawElements Quality Product Testsuite (dEQP) as part of the Android Lollipop release. It's git repo lives in the Android tree at [https://android.googlesource.com/platform/external/deqp/]. This patch adds a new module, deqp_gles3.py, that runs the dEQP-GLES3 tests. It queries the 'deqp-gles3' executable at runtime for the list of testcases. The module attempts queries the 'deqp-gles3' executable only if the environment variable PIGLIT_DEQP_GLES3_EXE or the piglit.conf option deqp-gles3.exe is set. Why do we need to use Pigit as the testrunner for dEQP? (After all, dEQP has its own testrunner). Because dEQP runs all tests in a single process. If test 17530 of 55409 crashes, then the dEQP testrunner crashes and the remaining tests never run. Piglit doesn't suffer from that problem, because it runs each test as a separate process. Tested on Intel Ivybridge by running the command piglit run -t dEQP-GLES3/info/vendor \ tests/deqp_gles3.py tests/quick.py results with and without PIGLIT_DEQP_GLES3_EXE set and with and without piglit.conf:deqp-gles.exe set. Also tested with various combinations of valid and invalid values for PIGLIT_DEQP_GLES_EXTRA_ARGS and piglit.conf:deqp-gles.extra_args. Cc: Dylan Baker dylanx.c.ba...@intel.com Cc: Michael W Mason michael.w.ma...@intel.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- v2: - Remove unused imports (dcbaker) - Remove extra newlines (dcbaker) - Don't use 'global' keyword (dcbaker) - Use global constant for DEQP_GLES3_EXE (dcbaker) - Fix DEQPTest.interpret_result to correctly parse test output. (mwmason) - Use 'super' keyword (dcbaker) v3: - Fix misnamed variable s/caselist_txt/caselist_path/. (mwmason) v4: - Add option piglit.conf:extra_args and env var PIGLIT_DEQP_GLES3_EXTRA_ARGS. (requested by mwmason) - Remove '--deqp-visibility=hidden'. (mwmason) - Fixed exception handling in func get_option. piglit.conf.example | 12 + tests/deqp_gles3.py | 139 2 files changed, 151 insertions(+) create mode 100644 tests/deqp_gles3.py diff --git a/piglit.conf.example b/piglit.conf.example index a864c01..b3869c2 100644 --- a/piglit.conf.example +++ b/piglit.conf.example @@ -33,6 +33,18 @@ bindir=/home/usr/oclconform testA testB +;[deqp-gles3] +; +; Path to the deqp-gles3 executable. You can also set this with the environment +; variable PIGLIT_DEQP_GLES3_EXE. Piglit will run the dEQP-GLES3 tests if and +; only if this option is set. +;exe=/home/knuth/deqp/modules/gles3/deqp-gles3 +; +; Space-separated list of extra command line arguments for deqp-gles3. The +; option is not required. The environment variable PIGLIT_DEQP_GLES3_EXTRA_ARGS +; overrides the value set here. +;extra_args=--deqp-visibility hidden + ; Section for specific oclconform test. One of these sections is required for ; each test list in the oclconform section and must be called: ; oclconform-$testname diff --git a/tests/deqp_gles3.py b/tests/deqp_gles3.py new file mode 100644 index 000..b1bb33b --- /dev/null +++ b/tests/deqp_gles3.py @@ -0,0 +1,139 @@ +# Copyright 2014 Intel Corporation +# +# Permission is hereby granted, free of charge, to any person obtaining a copy +# of this software and associated documentation files (the Software), to deal +# in the Software without restriction, including without limitation the rights +# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +# copies of the Software, and to permit persons to whom the Software is +# furnished to do so, subject to the following conditions: +# +# The above copyright notice and this permission notice shall be included in +# all copies or substantial portions of the Software. +# +# THE SOFTWARE IS PROVIDED AS IS, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +# SOFTWARE. + +import ConfigParser +import os +import subprocess + +# Piglit modules +import framework +from framework.profile import Test, TestProfile + +__all__ = ['profile'] + +def get_option(env_varname, config_option): +Query the given environment variable and then piglit.conf for the +option. Return None if the option is unset. + +opt = os.environ.get(env_varname, None) +if opt is not None: +return opt + +try: +opt = framework.core.PIGLIT_CONFIG.get(config_option[0], + config_option[1]) +except ConfigParser.NoSectionError: +pass +except ConfigParser.NoOptionError: +pass + +return opt + + +#
Re: [Piglit] [PATCH] deqp: Add test profile for external dEQP-GLES3 tests (v4)
On Tuesday, December 16, 2014 01:49:20 PM Chad Versace wrote: Google opensourced the drawElements Quality Product Testsuite (dEQP) as part of the Android Lollipop release. It's git repo lives in the Android tree at [https://android.googlesource.com/platform/external/deqp/]. This patch adds a new module, deqp_gles3.py, that runs the dEQP-GLES3 tests. It queries the 'deqp-gles3' executable at runtime for the list of testcases. The module attempts queries the 'deqp-gles3' executable only if the environment variable PIGLIT_DEQP_GLES3_EXE or the piglit.conf option deqp-gles3.exe is set. Why do we need to use Pigit as the testrunner for dEQP? (After all, dEQP has its own testrunner). Because dEQP runs all tests in a single process. If test 17530 of 55409 crashes, then the dEQP testrunner crashes and the remaining tests never run. Piglit doesn't suffer from that problem, because it runs each test as a separate process. Tested on Intel Ivybridge by running the command piglit run -t dEQP-GLES3/info/vendor \ tests/deqp_gles3.py tests/quick.py results with and without PIGLIT_DEQP_GLES3_EXE set and with and without piglit.conf:deqp-gles.exe set. Also tested with various combinations of valid and invalid values for PIGLIT_DEQP_GLES_EXTRA_ARGS and piglit.conf:deqp-gles.extra_args. Cc: Dylan Baker dylanx.c.ba...@intel.com Cc: Michael W Mason michael.w.ma...@intel.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- v2: - Remove unused imports (dcbaker) - Remove extra newlines (dcbaker) - Don't use 'global' keyword (dcbaker) - Use global constant for DEQP_GLES3_EXE (dcbaker) - Fix DEQPTest.interpret_result to correctly parse test output. (mwmason) - Use 'super' keyword (dcbaker) v3: - Fix misnamed variable s/caselist_txt/caselist_path/. (mwmason) v4: - Add option piglit.conf:extra_args and env var PIGLIT_DEQP_GLES3_EXTRA_ARGS. (requested by mwmason) - Remove '--deqp-visibility=hidden'. (mwmason) - Fixed exception handling in func get_option. piglit.conf.example | 12 + tests/deqp_gles3.py | 139 2 files changed, 151 insertions(+) create mode 100644 tests/deqp_gles3.py diff --git a/piglit.conf.example b/piglit.conf.example index a864c01..b3869c2 100644 --- a/piglit.conf.example +++ b/piglit.conf.example @@ -33,6 +33,18 @@ bindir=/home/usr/oclconform testA testB +;[deqp-gles3] +; +; Path to the deqp-gles3 executable. You can also set this with the environment +; variable PIGLIT_DEQP_GLES3_EXE. Piglit will run the dEQP-GLES3 tests if and +; only if this option is set. +;exe=/home/knuth/deqp/modules/gles3/deqp-gles3 +; +; Space-separated list of extra command line arguments for deqp-gles3. The +; option is not required. The environment variable PIGLIT_DEQP_GLES3_EXTRA_ARGS +; overrides the value set here. +;extra_args=--deqp-visibility hidden + ; Section for specific oclconform test. One of these sections is required for ; each test list in the oclconform section and must be called: ; oclconform-$testname diff --git a/tests/deqp_gles3.py b/tests/deqp_gles3.py new file mode 100644 index 000..b1bb33b --- /dev/null +++ b/tests/deqp_gles3.py @@ -0,0 +1,139 @@ +# Copyright 2014 Intel Corporation +# +# Permission is hereby granted, free of charge, to any person obtaining a copy +# of this software and associated documentation files (the Software), to deal +# in the Software without restriction, including without limitation the rights +# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +# copies of the Software, and to permit persons to whom the Software is +# furnished to do so, subject to the following conditions: +# +# The above copyright notice and this permission notice shall be included in +# all copies or substantial portions of the Software. +# +# THE SOFTWARE IS PROVIDED AS IS, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +# SOFTWARE. + +import ConfigParser +import os +import subprocess + +# Piglit modules +import framework +from framework.profile import Test, TestProfile + +__all__ = ['profile'] + +def get_option(env_varname, config_option): +Query the given environment variable and then piglit.conf for the +option. Return None if the option is unset. + +opt = os.environ.get(env_varname, None) +if opt is not None: +return opt + +try: +opt = framework.core.PIGLIT_CONFIG.get(config_option[0], +
Re: [Piglit] [PATCH] deqp: Add test profile for external dEQP-GLES3 tests (v4)
On 12/16/2014 02:10 PM, Dylan Baker wrote: On Tuesday, December 16, 2014 01:49:20 PM Chad Versace wrote: +try: +opt = framework.core.PIGLIT_CONFIG.get(config_option[0], + config_option[1]) +except ConfigParser.NoSectionError: +pass +except ConfigParser.NoOptionError: +pass You should combine these What's the syntax? I tried except ConfigParser.NoSectionError, ConfigParser.NoOptionError: pass but that failed to catch ConfigParser.NoOptionError. signature.asc Description: OpenPGP digital signature ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 3/3] cmake, gles: Remove target from the lib list
On Sun, 2014-12-14 at 16:16 +, Emil Velikov wrote:
On 12/12/14 19:33, Jan Vesely wrote:
Fixes Target links to itself cmake warnings
Signed-off-by: Jan Vesely jan.ves...@rutgers.edu
---
Hmm those seems exist since day 1, yet the intent seems to be missing.
Currently the library tries to link against itself, which is why cmake
is printing out the warnings.
Thanks for clearing this up :)
Reviewed-by: Emil Velikov emil.l.veli...@gmail.com
thanks, do you mind pushing it as well?
my account request bug is stuck
jan
compile tested. no missing symbols or libraries reported for
libpiglitutils_glesX.so
tests/util/CMakeLists.gles1.txt | 1 -
tests/util/CMakeLists.gles2.txt | 1 -
tests/util/CMakeLists.gles3.txt | 1 -
3 files changed, 3 deletions(-)
diff --git a/tests/util/CMakeLists.gles1.txt
b/tests/util/CMakeLists.gles1.txt
index 4342cf2..cd9e90d 100644
--- a/tests/util/CMakeLists.gles1.txt
+++ b/tests/util/CMakeLists.gles1.txt
@@ -4,7 +4,6 @@ include_directories(
link_libraries(
${UTIL_GL_LIBS}
- piglitutil_${piglit_target_api}
)
piglit_add_library(piglitutil_${piglit_target_api}
diff --git a/tests/util/CMakeLists.gles2.txt
b/tests/util/CMakeLists.gles2.txt
index 4342cf2..cd9e90d 100644
--- a/tests/util/CMakeLists.gles2.txt
+++ b/tests/util/CMakeLists.gles2.txt
@@ -4,7 +4,6 @@ include_directories(
link_libraries(
${UTIL_GL_LIBS}
- piglitutil_${piglit_target_api}
)
piglit_add_library(piglitutil_${piglit_target_api}
diff --git a/tests/util/CMakeLists.gles3.txt
b/tests/util/CMakeLists.gles3.txt
index fec284a..a23c0c7 100644
--- a/tests/util/CMakeLists.gles3.txt
+++ b/tests/util/CMakeLists.gles3.txt
@@ -4,7 +4,6 @@ include_directories(
link_libraries(
${UTIL_GL_LIBS}
- piglitutil_${piglit_target_api}
)
piglit_add_library(piglitutil_${piglit_target_api}
--
Jan Vesely jan.ves...@rutgers.edu
signature.asc
Description: This is a digitally signed message part
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] deqp: Add test profile for external dEQP-GLES3 tests (v4)
On Tuesday, December 16, 2014 02:52:08 PM Chad Versace wrote: On 12/16/2014 02:10 PM, Dylan Baker wrote: On Tuesday, December 16, 2014 01:49:20 PM Chad Versace wrote: +try: +opt = framework.core.PIGLIT_CONFIG.get(config_option[0], + config_option[1]) +except ConfigParser.NoSectionError: +pass +except ConfigParser.NoOptionError: +pass You should combine these What's the syntax? I tried except ConfigParser.NoSectionError, ConfigParser.NoOptionError: pass but that failed to catch ConfigParser.NoOptionError. It requires that the tuple have the () around it. except (ConfigParser.NoSectionError, ConfigParser.NoOptionError): pass This is because of the legacy except Exception, e syntax. signature.asc Description: This is a digitally signed message part. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [Bug 87391] New: [i965 Bisected]Piglit shaders_glsl-deriv-varyings fails on Mesa 10.4
https://bugs.freedesktop.org/show_bug.cgi?id=87391
Bug ID: 87391
Summary: [i965 Bisected]Piglit shaders_glsl-deriv-varyings
fails on Mesa 10.4
Product: piglit
Version: unspecified
Hardware: All
OS: Linux (All)
Status: NEW
Severity: normal
Priority: high
Component: tests
Assignee: piglit@lists.freedesktop.org
Reporter: huax...@intel.com
QA Contact: piglit@lists.freedesktop.org
CC: ago...@igalia.com, i...@freedesktop.org,
matts...@gmail.com
System Environment:
--
Platform: i965
Libdrm:
(master)libdrm-2.4.58-19-gf99522e678dbbaffeca9462a8edcbe900574dc12
Mesa:(10.4)bccfe7ae0f4e11a0219eb92f7070b1fc70bc6fd6
Xserver:(server-1.16-branch)xorg-server-1.16.2.901
Xf86_video_intel:(master)2.99.916-177-g99537089346ed7a1bc6b02349fad93845e865bb9
Libva:(master)8986ec692b19d8dd6bd2aa118b5dffbd05a8f909
Libva_intel_driver:(master)b5d6d9d425a6d539b27d22992bda05f79d1a0622
Kernel: (drm-intel-fixes)b0616c5306b342ceca07044dbc4f917d95c4f825
Piglit: f18b947d7c03b81b989ed47551dc24bcc29cc0fc
Bug detailed description:
---
This case fails on Mesa 10.4 branch and works well on Mesa master branch.Bisect
shows it's a Piglit regression.
Bisect shows: b1ee0f3214028cd724028f697ac5ee7b6240de10 is the first bad commit.
commit b1ee0f3214028cd724028f697ac5ee7b6240de10
Author: Andres Gomez ago...@igalia.com
AuthorDate: Fri Dec 12 17:13:55 2014 +0100
Commit: Matt Turner matts...@gmail.com
CommitDate: Mon Dec 15 11:41:54 2014 -0800
glsl-deriv-varyings: Added checks for derivatives on parameters with
negative or abs modifiers
Exposes a bug in the i965 driver.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82991
Reviewed-by: Matt Turner matts...@gmail.com
output:
libGL: screen 0 does not appear to be DRI3 capable
libGL: pci id for fd 4: 8086:0152, driver i965
libGL: OpenDriver: trying /opt/X11R7/lib/dri/tls/i965_dri.so
libGL: OpenDriver: trying /opt/X11R7/lib/dri/i965_dri.so
libGL: Error in /etc/drirc line 1, column 0: no element found.
libGL: Error in /root/.drirc line 1, column 0: no element found.
libGL: Error in /etc/drirc line 1, column 0: no element found.
libGL: Error in /root/.drirc line 1, column 0: no element found.
Probe color at (280,125)
Expected: 0.80 0.40 0.00
Observed: 0.00 0.00 0.00
PIGLIT: {result: fail }
Reproduce steps:
-
1. xinit
2. bin/glsl-deriv-varyings -auto -fbo
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [Bug 87391] [i965]Piglit shaders_glsl-deriv-varyings fails on Mesa 10.4
https://bugs.freedesktop.org/show_bug.cgi?id=87391 lu hua huax...@intel.com changed: What|Removed |Added Component|tests |Drivers/DRI/i965 Version|unspecified |10.4 Assignee|pig...@lists.freedesktop.or |i...@freedesktop.org |g | Product|piglit |Mesa Summary|[i965 Bisected]Piglit |[i965]Piglit |shaders_glsl-deriv-varyings |shaders_glsl-deriv-varyings |fails on Mesa 10.4 |fails on Mesa 10.4 QA Contact|pig...@lists.freedesktop.or |intel-3d-bugs@lists.freedes |g |ktop.org --- Comment #1 from lu hua huax...@intel.com --- As the patch's description, it only exposes Mesa issue. Reset to Mesa. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] arb_sample_shading-builtin-gl-num-samples: Use const reference.
Fix Coverity big parameter passed by value defect.
Signed-off-by: Vinson Lee v...@freedesktop.org
---
tests/spec/arb_sample_shading/execution/builtin-gl-num-samples.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/spec/arb_sample_shading/execution/builtin-gl-num-samples.cpp
b/tests/spec/arb_sample_shading/execution/builtin-gl-num-samples.cpp
index 620c12e..08bbea9 100644
--- a/tests/spec/arb_sample_shading/execution/builtin-gl-num-samples.cpp
+++ b/tests/spec/arb_sample_shading/execution/builtin-gl-num-samples.cpp
@@ -118,7 +118,7 @@ piglit_init(int argc, char **argv)
}
}
-bool test_builtin_num_samples(Fbo ms_fbo)
+bool test_builtin_num_samples(const Fbo ms_fbo)
{
GLint samples;
GLfloat expected[4] = {0.0, 1.0, 0.0, 1.0};
--
1.9.2
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] arb_sample_shading-builtin-gl-sample-mask: Use const reference.
Fix Coverity big parameter passed by value defect.
Signed-off-by: Vinson Lee v...@freedesktop.org
---
tests/spec/arb_sample_shading/execution/builtin-gl-sample-mask.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/spec/arb_sample_shading/execution/builtin-gl-sample-mask.cpp
b/tests/spec/arb_sample_shading/execution/builtin-gl-sample-mask.cpp
index 48a2ed7..6c6cf92 100644
--- a/tests/spec/arb_sample_shading/execution/builtin-gl-sample-mask.cpp
+++ b/tests/spec/arb_sample_shading/execution/builtin-gl-sample-mask.cpp
@@ -169,7 +169,7 @@ piglit_init(int argc, char **argv)
}
bool
-test_builtin_sample_mask(Fbo ms_fbo)
+test_builtin_sample_mask(const Fbo ms_fbo)
{
int samples;
bool result = true;
--
1.9.2
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] cl-api-create-image: Fix memory leak.
Fix Coverity resource leak defect.
Signed-off-by: Vinson Lee v...@freedesktop.org
---
tests/cl/api/create-image.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/cl/api/create-image.c b/tests/cl/api/create-image.c
index 46a98dd..a1e143b 100644
--- a/tests/cl/api/create-image.c
+++ b/tests/cl/api/create-image.c
@@ -44,8 +44,11 @@ static bool context_has_image_support(const
piglit_cl_context ctx)
piglit_cl_get_device_info(ctx-device_ids[i],
CL_DEVICE_IMAGE_SUPPORT);
if (*image_support) {
+ free(image_support);
return true;
}
+
+ free(image_support);
}
return false;
}
--
1.9.2
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] cl-api-get-platform-ids: Fix possible use after free.
Fixes Use after free defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- tests/cl/api/get-platform-ids.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/cl/api/get-platform-ids.c b/tests/cl/api/get-platform-ids.c index 6cc734a..ab3e4cd 100644 --- a/tests/cl/api/get-platform-ids.c +++ b/tests/cl/api/get-platform-ids.c @@ -80,6 +80,7 @@ piglit_cl_test(const int argc, piglit_merge_result(result, PIGLIT_FAIL); } free(platforms); + platforms = NULL; } } -- 1.8.3.2 ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] util-cl: Fix non-portable sizeof.
Fix Coverity sizeof not portable defect.
Signed-off-by: Vinson Lee v...@freedesktop.org
---
tests/util/piglit-framework-cl-program.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/util/piglit-framework-cl-program.c
b/tests/util/piglit-framework-cl-program.c
index d335486..f94525b 100644
--- a/tests/util/piglit-framework-cl-program.c
+++ b/tests/util/piglit-framework-cl-program.c
@@ -287,7 +287,7 @@ piglit_cl_program_test_run(const int argc,
} else if(config-program_binary_file != NULL) {
unsigned int length;
size_t* lengths = malloc(sizeof(size_t) *
env.context-num_devices);
- unsigned char** program_binaries = malloc(sizeof(unsigned
char**) * env.context-num_devices);
+ unsigned char** program_binaries = malloc(sizeof(unsigned
char*) * env.context-num_devices);
((char**)program_binaries)[0] =
piglit_load_text_file(config-program_binary_file,
length);
--
1.9.2
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
