Re: [Piglit] [PATCH] framework/backends/json: always flush the metadata to the disk
On 30/01/17 20:09, Dylan Baker wrote: Reviewed-by: Dylan Baker Thanks Dylan! Just pushed the patch :) ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] getteximage-formats: Disable dithering during glDrawPixels
Pushed. ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] getteximage-formats: Disable dithering during glDrawPixels
On Monday, January 30, 2017 11:12:44 AM PST Chad Versace wrote: > The test generates a mipmap by "copying" a client-array of pixels to > miplevel 0 with glDrawPixels, then calling glGenerateMipmap. The test > expects the rendered level 0 to match the client-array source. Dithering > during glDrawPixels inteferes with that expectation. > > Fixes on Intel Skylake: > spec.ext_framebuffer_object.getteximage-formats init-by-clear-and-render > spec.ext_framebuffer_object.getteximage-formats init-by-render > > Regressed by Mesa: > commit c4b87f129eb036c9615df3adcc1cebd9df10fc84 > Author: Chad Versace > Subject: meta: Disable dithering during glGenerateMipmap > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99266 > Cc: Mark Janes > Cc: Kenneth Graunke > --- > tests/texturing/getteximage-formats.c | 25 + > 1 file changed, 25 insertions(+) > > diff --git a/tests/texturing/getteximage-formats.c > b/tests/texturing/getteximage-formats.c > index 6f4fb029e..02d78d441 100644 > --- a/tests/texturing/getteximage-formats.c > +++ b/tests/texturing/getteximage-formats.c > @@ -110,8 +110,33 @@ make_texture_image(GLenum intFormat, GLubyte > upperRightTexel[4]) > > glViewport(0, 0, TEX_SIZE, TEX_SIZE); > > + /* Disable dithering during glDrawPixels to prevent > + * disagreement with glGenerateMipmap. The spec requires > + * glDrawPixels to respect the dither state, but the spec > + * strongly implies that glGenerateMipmap should not dither. > + * > + * On dithering and glDrawPixels, see the OpenGL 4.5 > + * Compatibility Specification, Section 18.1 Drawing Pixels, > + * p620: > + * > + * Once pixels are transferred, DrawPixels performs final > + * conversion on pixel values [...] which are processed in > + * the same fashion as fragments generated by rasterization > + * (see chapters 15 and 16). > + * > + * On dithering and glGenerateMipmap, see the Mesa commit > + * message in: > + * > + * commit c4b87f129eb036c9615df3adcc1cebd9df10fc84 > + * Author: Chad Versace > + * Date: Thu Dec 29 13:05:27 2016 -0800 > + * Subject: meta: Disable dithering during glGenerateMipmap > + */ > + glDisable(GL_DITHER); > glWindowPos2iARB(0, 0); > glDrawPixels(TEX_SIZE, TEX_SIZE, GL_RGBA, GL_UNSIGNED_BYTE, > tex); > + glEnable(GL_DITHER); > + > glGenerateMipmap(GL_TEXTURE_2D); > > glBindFramebufferEXT(GL_FRAMEBUFFER_EXT, piglit_winsys_fbo); > Thank you, Chad! Reviewed-by: Kenneth Graunke signature.asc Description: This is a digitally signed message part. ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] getteximage-formats: Disable dithering during glDrawPixels
Tested-by: Mark Janes Chad Versace writes: > The test generates a mipmap by "copying" a client-array of pixels to > miplevel 0 with glDrawPixels, then calling glGenerateMipmap. The test > expects the rendered level 0 to match the client-array source. Dithering > during glDrawPixels inteferes with that expectation. > > Fixes on Intel Skylake: > spec.ext_framebuffer_object.getteximage-formats init-by-clear-and-render > spec.ext_framebuffer_object.getteximage-formats init-by-render > > Regressed by Mesa: > commit c4b87f129eb036c9615df3adcc1cebd9df10fc84 > Author: Chad Versace > Subject: meta: Disable dithering during glGenerateMipmap > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99266 > Cc: Mark Janes > Cc: Kenneth Graunke > --- > tests/texturing/getteximage-formats.c | 25 + > 1 file changed, 25 insertions(+) > > diff --git a/tests/texturing/getteximage-formats.c > b/tests/texturing/getteximage-formats.c > index 6f4fb029e..02d78d441 100644 > --- a/tests/texturing/getteximage-formats.c > +++ b/tests/texturing/getteximage-formats.c > @@ -110,8 +110,33 @@ make_texture_image(GLenum intFormat, GLubyte > upperRightTexel[4]) > > glViewport(0, 0, TEX_SIZE, TEX_SIZE); > > + /* Disable dithering during glDrawPixels to prevent > + * disagreement with glGenerateMipmap. The spec requires > + * glDrawPixels to respect the dither state, but the spec > + * strongly implies that glGenerateMipmap should not dither. > + * > + * On dithering and glDrawPixels, see the OpenGL 4.5 > + * Compatibility Specification, Section 18.1 Drawing Pixels, > + * p620: > + * > + * Once pixels are transferred, DrawPixels performs final > + * conversion on pixel values [...] which are processed in > + * the same fashion as fragments generated by rasterization > + * (see chapters 15 and 16). > + * > + * On dithering and glGenerateMipmap, see the Mesa commit > + * message in: > + * > + * commit c4b87f129eb036c9615df3adcc1cebd9df10fc84 > + * Author: Chad Versace > + * Date: Thu Dec 29 13:05:27 2016 -0800 > + * Subject: meta: Disable dithering during glGenerateMipmap > + */ > + glDisable(GL_DITHER); > glWindowPos2iARB(0, 0); > glDrawPixels(TEX_SIZE, TEX_SIZE, GL_RGBA, GL_UNSIGNED_BYTE, > tex); > + glEnable(GL_DITHER); > + > glGenerateMipmap(GL_TEXTURE_2D); > > glBindFramebufferEXT(GL_FRAMEBUFFER_EXT, piglit_winsys_fbo); > -- > 2.11.0 ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] getteximage-formats: Disable dithering during glDrawPixels
The test generates a mipmap by "copying" a client-array of pixels to miplevel 0 with glDrawPixels, then calling glGenerateMipmap. The test expects the rendered level 0 to match the client-array source. Dithering during glDrawPixels inteferes with that expectation. Fixes on Intel Skylake: spec.ext_framebuffer_object.getteximage-formats init-by-clear-and-render spec.ext_framebuffer_object.getteximage-formats init-by-render Regressed by Mesa: commit c4b87f129eb036c9615df3adcc1cebd9df10fc84 Author: Chad Versace Subject: meta: Disable dithering during glGenerateMipmap Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99266 Cc: Mark Janes Cc: Kenneth Graunke --- tests/texturing/getteximage-formats.c | 25 + 1 file changed, 25 insertions(+) diff --git a/tests/texturing/getteximage-formats.c b/tests/texturing/getteximage-formats.c index 6f4fb029e..02d78d441 100644 --- a/tests/texturing/getteximage-formats.c +++ b/tests/texturing/getteximage-formats.c @@ -110,8 +110,33 @@ make_texture_image(GLenum intFormat, GLubyte upperRightTexel[4]) glViewport(0, 0, TEX_SIZE, TEX_SIZE); + /* Disable dithering during glDrawPixels to prevent +* disagreement with glGenerateMipmap. The spec requires +* glDrawPixels to respect the dither state, but the spec +* strongly implies that glGenerateMipmap should not dither. +* +* On dithering and glDrawPixels, see the OpenGL 4.5 +* Compatibility Specification, Section 18.1 Drawing Pixels, +* p620: +* +* Once pixels are transferred, DrawPixels performs final +* conversion on pixel values [...] which are processed in +* the same fashion as fragments generated by rasterization +* (see chapters 15 and 16). +* +* On dithering and glGenerateMipmap, see the Mesa commit +* message in: +* +* commit c4b87f129eb036c9615df3adcc1cebd9df10fc84 +* Author: Chad Versace +* Date: Thu Dec 29 13:05:27 2016 -0800 +* Subject: meta: Disable dithering during glGenerateMipmap +*/ + glDisable(GL_DITHER); glWindowPos2iARB(0, 0); glDrawPixels(TEX_SIZE, TEX_SIZE, GL_RGBA, GL_UNSIGNED_BYTE, tex); + glEnable(GL_DITHER); + glGenerateMipmap(GL_TEXTURE_2D); glBindFramebufferEXT(GL_FRAMEBUFFER_EXT, piglit_winsys_fbo); -- 2.11.0 ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 0/5] Add int64 conversion tests
I haven't looked to closely yet, though I'm planning to do so today or tomorrow. I do have one question, does this change the names of the fp64 tests? That would be less than ideal for us because of our CI system. Dylan Quoting Nicolai Hähnle (2017-01-26 10:59:21) > Hi all, > > increase the test coverage of GL_ARB_gpu_shader_int64 by testing various > conversions. To avoid reinventing the wheel or duplicating code, I've > extended the existing fp64 conversion test generation. The first couple > of patches simply move code around and rename things. The last patch adds > all the actual int64 tests. > > I verified using diff that the existing generated test files remain > unmodified. The only change is that more test files are generated in > spec/arb_gpu_shader_int64. Tested against radeonsi with the remaining > patches that I'm about to send to mesa-dev. Please review! > > Thanks, > Nicolai > > ___ > Piglit mailing list > Piglit@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/piglit signature.asc Description: signature ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] apitrace: update for new dump-images filenames
On Mon, Jan 23, 2017 at 1:51 PM, Eric Anholt wrote: > Rob Clark writes: > >> The 'retrace: support for dumping multiple snapshots' patch changes the >> output filenames for dumped images to have -mrtN/-z/-s suffixes. MRT #0 >> is equivalent to the old behavior. > > Reviewed-by: Eric Anholt note that we can drop this patch.. I sent a v3 of the apitrace patch that uses the old filenames if -f/--full not specified. BR, -R ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH] framework/backends/json: always flush the metadata to the disk
Reviewed-by: Dylan Baker Quoting Martin Peres (2017-01-30 04:26:25) > This guarantees that whatever the state we are in, we can always > continue the piglit run. Do not use FileBackend.__fsync as it would > not do the fsync call in the non-sync mode. > > This change makes it easier to integrate into a CI system that is > hard-reboot-resistant. > > Signed-off-by: Martin Peres > --- > framework/backends/json.py | 4 > 1 file changed, 4 insertions(+) > > diff --git a/framework/backends/json.py b/framework/backends/json.py > index 55169191d..174c0ca96 100644 > --- a/framework/backends/json.py > +++ b/framework/backends/json.py > @@ -108,6 +108,10 @@ class JSONBackend(FileBackend): > with open(os.path.join(self._dest, 'metadata.json'), 'w') as f: > json.dump(metadata, f, default=piglit_encoder) > > +# Flush the metadata to the disk, always > +f.flush() > +os.fsync(f.fileno()) > + > # make the directory for the tests > try: > os.mkdir(os.path.join(self._dest, 'tests')) > -- > 2.11.0 > > ___ > Piglit mailing list > Piglit@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/piglit signature.asc Description: signature ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
[Piglit] [PATCH] framework/backends/json: always flush the metadata to the disk
This guarantees that whatever the state we are in, we can always continue the piglit run. Do not use FileBackend.__fsync as it would not do the fsync call in the non-sync mode. This change makes it easier to integrate into a CI system that is hard-reboot-resistant. Signed-off-by: Martin Peres --- framework/backends/json.py | 4 1 file changed, 4 insertions(+) diff --git a/framework/backends/json.py b/framework/backends/json.py index 55169191d..174c0ca96 100644 --- a/framework/backends/json.py +++ b/framework/backends/json.py @@ -108,6 +108,10 @@ class JSONBackend(FileBackend): with open(os.path.join(self._dest, 'metadata.json'), 'w') as f: json.dump(metadata, f, default=piglit_encoder) +# Flush the metadata to the disk, always +f.flush() +os.fsync(f.fileno()) + # make the directory for the tests try: os.mkdir(os.path.join(self._dest, 'tests')) -- 2.11.0 ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit
