Re: [Piglit] [PATCH] Disable_early_z - Buffer lenght changed

[Dylan Baker]

Hi Sandra,

Thanks for reporting this bug, and even better, writing a patch!

Unfortunately providing patches as attachments makes them very hard to review,
but there is an useful tool called 'git-send-email', which is generally
installed as part of the git package. git-send-email puts the patch inline,
which is much more convenient for reviewing.

This page
(https://www.freedesktop.org/wiki/Software/PulseAudio/HowToUseGitSendEmail/) has
a nice, straightforward walk-through on git-send-email, the only thing you'll
want to do different is replace this:

git config sendemail.to pulseaudio-disc...@lists.freedesktop.org

With this:

git config sendemail.to piglit@lists.freedesktop.org

Dylan

Quoting sandra koroniewska (2017-02-24 09:13:47)
> Hi,
> The application crashes on the test "disable_early_z". There is a buffer 
> that's
> too small for the longest possible content. I appended a patch to fix this and
> I would like to ask for a review of these changes.
> 
> Regards,
> Sandra


signature.asc
Description: signature
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] Disable_early_z - Buffer lenght changed

[sandra koroniewska]

Hi,
The application crashes on the test "disable_early_z". There is a buffer
that's too small for the longest possible content. I appended a patch to
fix this and I would like to ask for a review of these changes.

Regards,
Sandra


0001-buffer-lenght-changed.patch
Description: Binary data
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 2/2] unittests: fix tests that check for tesselation

[Lionel Landwerlin]

Thanks!

I see an additional one in tests/spec/arb_internalformat_query2/common.c :)

Reviewed-by: Lionel Landwerlin 

On 24/02/17 01:52, Dylan Baker wrote:

This is a test fix for the practical fix in
e8fbd270b35b1bb927acc34383cbf9db95863a26.

Signed-off-by: Dylan Baker 
---
  unittests/generators/test_glsl.py | 16 
  1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/unittests/generators/test_glsl.py 
b/unittests/generators/test_glsl.py
index 66e3f66e1..5eec79484 100644
--- a/unittests/generators/test_glsl.py
+++ b/unittests/generators/test_glsl.py
@@ -300,18 +300,18 @@ class TestMinVersion_for_stage_with_ext(object):
  TCS (OpenGL)"""
  self._test('tesc', glsl.Version('410'), (glsl.Version('410'), None))
  self._test('tesc', glsl.Version('140'),
-   (glsl.Version('140'), 'GL_ARB_tesselation_shader'))
+   (glsl.Version('140'), 'GL_ARB_tessellation_shader'))
  self._test('tesc', glsl.Version('110'),
-   (glsl.Version('140'), 'GL_ARB_tesselation_shader'))
+   (glsl.Version('140'), 'GL_ARB_tessellation_shader'))
  
  def test_opengl_tese(self):

  """generated_tests.modules.glsl.MinVersion.for_stage_with_ext:
  TES (OpenGL)"""
  self._test('tese', glsl.Version('410'), (glsl.Version('410'), None))
  self._test('tese', glsl.Version('140'),
-   (glsl.Version('140'), 'GL_ARB_tesselation_shader'))
+   (glsl.Version('140'), 'GL_ARB_tessellation_shader'))
  self._test('tese', glsl.Version('110'),
-   (glsl.Version('140'), 'GL_ARB_tesselation_shader'))
+   (glsl.Version('140'), 'GL_ARB_tessellation_shader'))
  
  def test_opengl_comp(self):

  """generated_tests.modules.glsl.MinVersion.for_stage_with_ext:
@@ -352,9 +352,9 @@ class TestMinVersion_for_stage_with_ext(object):
  self._test('tesc', glsl.Version('320 es'),
 (glsl.Version('320 es'), None))
  self._test('tesc', glsl.Version('310 es'),
-   (glsl.Version('310 es'), 'GL_OES_tesselation_shader'))
+   (glsl.Version('310 es'), 'GL_OES_tessellation_shader'))
  self._test('tesc', glsl.Version('100'),
-   (glsl.Version('310 es'), 'GL_OES_tesselation_shader'))
+   (glsl.Version('310 es'), 'GL_OES_tessellation_shader'))
  
  def test_opengles_tese(self):

  """generated_tests.modules.glsl.MinVersion.for_stage_with_ext:
@@ -362,9 +362,9 @@ class TestMinVersion_for_stage_with_ext(object):
  self._test('tese', glsl.Version('320 es'),
 (glsl.Version('320 es'), None))
  self._test('tese', glsl.Version('310 es'),
-   (glsl.Version('310 es'), 'GL_OES_tesselation_shader'))
+   (glsl.Version('310 es'), 'GL_OES_tessellation_shader'))
  self._test('tese', glsl.Version('100'),
-   (glsl.Version('310 es'), 'GL_OES_tesselation_shader'))
+   (glsl.Version('310 es'), 'GL_OES_tessellation_shader'))
  
  def test_opengles_comp(self):

  """generated_tests.modules.glsl.MinVersion.for_stage_with_ext:



___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 1/2] unittests: Fix rename of gen_conversion -> gen_conversion_fp64

[Lionel Landwerlin]

Actually, that might explain Jason's failures :(

Reviewed-by: Lionel Landwerlin 

On 24/02/17 01:52, Dylan Baker wrote:

Signed-off-by: Dylan Baker 
---
  unittests/generators/test_generators.py | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/unittests/generators/test_generators.py 
b/unittests/generators/test_generators.py
index a3ea3e29e..5a129292e 100644
--- a/unittests/generators/test_generators.py
+++ b/unittests/generators/test_generators.py
@@ -48,7 +48,7 @@ import pytest
  'gen_cl_store_tests',
  'gen_const_builtin_equal_tests',
  'gen_constant_array_size_tests_fp64',
-'gen_conversion_fp64',
+'gen_conversion',
  'gen_extensions_defined',
  'gen_flat_interpolation_qualifier',
  'gen_inout_fp64',



___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] glsl-1.50: instance name is not used to match UBO/SSBOs shader interfaces

[Andres Gomez]

This adds tests to check that no link error occurs when two
differently named but equally instanced interface blocks differ in
some way.

From page 35 (page 41 of the PDF) of the GLSL 1.50, v11, spec:

"The block name (block-name) is used to match interfaces: an output
 block of one pipeline stage will be matched to an input block
 with the same name in the subsequent pipeline stage. For uniform
 blocks, the application uses the block name to identify the
 block.

 ...

 Outside the shading language (i.e., in the API), members are
 similarly identified except the block name is always used in
 place of the instance name (API accesses are to interfaces, not
 to shaders)."

Signed-off-by: Andres Gomez 
Cc: Timothy Arceri 
---
 ...age-blocks-align-qualifier-mismatch.shader_test | 54 +
 ...cks-member-align-qualifier-mismatch.shader_test | 54 +
 ...orm-blocks-align-qualifier-mismatch.shader_test | 51 
 ...cks-member-align-qualifier-mismatch.shader_test | 51 
 ...ks-member-offset-qualifier-mismatch.shader_test | 54 +
 ...ks-member-offset-qualifier-mismatch.shader_test | 51 
 ...-storage-blocks-array-size-mismatch.shader_test | 54 +
 ...e-blocks-binding-qualifier-mismatch.shader_test | 55 ++
 ...e-blocks-member-array-size-mismatch.shader_test | 52 
 ...torage-blocks-member-count-mismatch.shader_test | 53 +
 ...storage-blocks-member-name-mismatch.shader_test | 52 
 ...torage-blocks-member-order-mismatch.shader_test | 54 +
 ...ge-blocks-member-qualifier-mismatch.shader_test | 52 
 ...storage-blocks-member-type-mismatch.shader_test | 52 
 ...ge-blocks-memory-qualifier-mismatch.shader_test | 52 
 ...blocks-packaging-qualifier-mismatch.shader_test | 52 
 ...m-blocks-binding-qualifier-mismatch.shader_test | 52 
 ...-uniform-blocks-array-size-mismatch.shader_test | 50 
 ...m-blocks-member-array-size-mismatch.shader_test | 48 +++
 ...niform-blocks-member-count-mismatch.shader_test | 49 +++
 ...uniform-blocks-member-name-mismatch.shader_test | 48 +++
 ...niform-blocks-member-order-mismatch.shader_test | 50 
 ...rm-blocks-member-qualifier-mismatch.shader_test | 48 +++
 ...uniform-blocks-member-type-mismatch.shader_test | 48 +++
 ...rm-blocks-memory-qualifier-mismatch.shader_test | 48 +++
 ...blocks-packaging-qualifier-mismatch.shader_test | 48 +++
 26 files changed, 1332 insertions(+)
 create mode 100644 
tests/spec/arb_enhanced_layouts/linker/align-layout/instance-matching-shader-storage-blocks-align-qualifier-mismatch.shader_test
 create mode 100644 
tests/spec/arb_enhanced_layouts/linker/align-layout/instance-matching-shader-storage-blocks-member-align-qualifier-mismatch.shader_test
 create mode 100644 
tests/spec/arb_enhanced_layouts/linker/align-layout/instance-matching-uniform-blocks-align-qualifier-mismatch.shader_test
 create mode 100644 
tests/spec/arb_enhanced_layouts/linker/align-layout/instance-matching-uniform-blocks-member-align-qualifier-mismatch.shader_test
 create mode 100644 
tests/spec/arb_enhanced_layouts/linker/explicit-offsets/instance-matching-shader-storage-blocks-member-offset-qualifier-mismatch.shader_test
 create mode 100644 
tests/spec/arb_enhanced_layouts/linker/explicit-offsets/instance-matching-uniform-blocks-member-offset-qualifier-mismatch.shader_test
 create mode 100644 
tests/spec/arb_shader_storage_buffer_object/linker/instance-matching-shader-storage-blocks-array-size-mismatch.shader_test
 create mode 100644 
tests/spec/arb_shader_storage_buffer_object/linker/instance-matching-shader-storage-blocks-binding-qualifier-mismatch.shader_test
 create mode 100644 
tests/spec/arb_shader_storage_buffer_object/linker/instance-matching-shader-storage-blocks-member-array-size-mismatch.shader_test
 create mode 100644 
tests/spec/arb_shader_storage_buffer_object/linker/instance-matching-shader-storage-blocks-member-count-mismatch.shader_test
 create mode 100644 
tests/spec/arb_shader_storage_buffer_object/linker/instance-matching-shader-storage-blocks-member-name-mismatch.shader_test
 create mode 100644 
tests/spec/arb_shader_storage_buffer_object/linker/instance-matching-shader-storage-blocks-member-order-mismatch.shader_test
 create mode 100644 
tests/spec/arb_shader_storage_buffer_object/linker/instance-matching-shader-storage-blocks-member-qualifier-mismatch.shader_test
 create mode 100644 
tests/spec/arb_shader_storage_buffer_object/linker/instance-matching-shader-storage-blocks-member-type-mismatch.shader_test
 create mode 100644 

Re: [Piglit] [PATCH] builtin_functions: Add more 64-bit integers

[Lionel Landwerlin]

I thought these would have been caught by gen_conversion.py :/

Reviewed-by: Lionel Landwerlin 

On 24/02/17 01:20, Jason Ekstrand wrote:

Seriously, 1000 is not the only 64-bit integer.  We should test
a few more of them.

These new integers trigger a bug in the GLSL IR int64 lowering code.

Cc: Ian Romanick 
---
  generated_tests/builtin_function.py | 24 ++--
  1 file changed, 22 insertions(+), 2 deletions(-)

diff --git a/generated_tests/builtin_function.py 
b/generated_tests/builtin_function.py
index 663d9d8..a5eafb2 100644
--- a/generated_tests/builtin_function.py
+++ b/generated_tests/builtin_function.py
@@ -1309,8 +1309,28 @@ def _make_vector_or_matrix_test_vectors(test_suite_dict):
[ 0.14,  0.18, -0.56],
[ 0.40, -0.77,  1.76]]),  # mat3x4
  ]
-int64s = [np.int64(x) for x in [0, -1000, 1000]]
-uint64s = [np.uint64(x) for x in [0,  10, 1000]]
+
+int64s = [np.int64(x) for x in [
+   0,
+   3,
+   -1192,
+   1048576,
+   4251475,
+   29852643761,
+   -4398046511104,
+   -3948976685146,
+   -135763469567146206]]
+uint64s = [np.uint64(x) for x in [
+   0,
+   3,
+   1192,
+   1048576,
+   4251475,
+   29852643761,
+   4398046511104,
+   3948976685146,
+   135763469567146206,
+   11654173250180970009]]
  
  int64vecs = [

  np.array([-10, -12], dtype=np.int64),



___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit