Re: [Piglit] [PATCH] glsl 1.10: Fix broken ternary void test

2015-07-10 Thread Timothy Arceri
On Fri, 2015-07-10 at 16:52 +0200, Renaud Gaubert wrote:
 Now that this bug is fixed in the following commit sent to mesa-dev:
 glsl: avoid compiler's segfault when processing operators with void
 arguments
 
 This test proved to be broken:
 It did not set gl_Position
 It did not compare the right values

The first test hasn't been pushed yet you should merge this patch with
the previous one and send it as a version 2.

___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit


Re: [Piglit] [PATCH] glsl 1.10: Fix broken ternary void test

2015-07-10 Thread Chris Forbes
Seems reasonable to roll in with the first patch. Do you need someone to
push it for you?
On Jul 11, 2015 12:06 PM, Timothy Arceri t_arc...@yahoo.com.au wrote:

 On Fri, 2015-07-10 at 16:52 +0200, Renaud Gaubert wrote:
  Now that this bug is fixed in the following commit sent to mesa-dev:
  glsl: avoid compiler's segfault when processing operators with void
  arguments
 
  This test proved to be broken:
  It did not set gl_Position
  It did not compare the right values

 The first test hasn't been pushed yet you should merge this patch with
 the previous one and send it as a version 2.

 ___
 Piglit mailing list
 Piglit@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/piglit

___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit