Re: [Piglit] [PATCH 3/3] cmake, gles: Remove target from the lib list
On Fri, 2015-02-20 at 12:03 +, Jose Fonseca wrote:
> On 12/12/14 19:33, Jan Vesely wrote:
> > Fixes Target links to itself cmake warnings
> >
> > Signed-off-by: Jan Vesely
> > ---
> >
> > compile tested. no missing symbols or libraries reported for
> > libpiglitutils_glesX.so
> >
> > tests/util/CMakeLists.gles1.txt | 1 -
> > tests/util/CMakeLists.gles2.txt | 1 -
> > tests/util/CMakeLists.gles3.txt | 1 -
> > 3 files changed, 3 deletions(-)
> >
> > diff --git a/tests/util/CMakeLists.gles1.txt
> > b/tests/util/CMakeLists.gles1.txt
> > index 4342cf2..cd9e90d 100644
> > --- a/tests/util/CMakeLists.gles1.txt
> > +++ b/tests/util/CMakeLists.gles1.txt
> > @@ -4,7 +4,6 @@ include_directories(
> >
> > link_libraries(
> > ${UTIL_GL_LIBS}
> > - piglitutil_${piglit_target_api}
> > )
> >
> > piglit_add_library(piglitutil_${piglit_target_api}
> > diff --git a/tests/util/CMakeLists.gles2.txt
> > b/tests/util/CMakeLists.gles2.txt
> > index 4342cf2..cd9e90d 100644
> > --- a/tests/util/CMakeLists.gles2.txt
> > +++ b/tests/util/CMakeLists.gles2.txt
> > @@ -4,7 +4,6 @@ include_directories(
> >
> > link_libraries(
> > ${UTIL_GL_LIBS}
> > - piglitutil_${piglit_target_api}
> > )
> >
> > piglit_add_library(piglitutil_${piglit_target_api}
> > diff --git a/tests/util/CMakeLists.gles3.txt
> > b/tests/util/CMakeLists.gles3.txt
> > index fec284a..a23c0c7 100644
> > --- a/tests/util/CMakeLists.gles3.txt
> > +++ b/tests/util/CMakeLists.gles3.txt
> > @@ -4,7 +4,6 @@ include_directories(
> >
> > link_libraries(
> > ${UTIL_GL_LIBS}
> > - piglitutil_${piglit_target_api}
> > )
> >
> > piglit_add_library(piglitutil_${piglit_target_api}
> >
>
> Reviewed-by: Jose Fonseca
thanks, but this patch went in some time ago.
I pushed the other two and posted the correct warning->error one.
sorry for the hassle, I should have grouped them better.
jan
--
Jan Vesely
signature.asc
Description: This is a digitally signed message part
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 3/3] cmake, gles: Remove target from the lib list
On 12/12/14 19:33, Jan Vesely wrote:
Fixes Target links to itself cmake warnings
Signed-off-by: Jan Vesely
---
compile tested. no missing symbols or libraries reported for
libpiglitutils_glesX.so
tests/util/CMakeLists.gles1.txt | 1 -
tests/util/CMakeLists.gles2.txt | 1 -
tests/util/CMakeLists.gles3.txt | 1 -
3 files changed, 3 deletions(-)
diff --git a/tests/util/CMakeLists.gles1.txt b/tests/util/CMakeLists.gles1.txt
index 4342cf2..cd9e90d 100644
--- a/tests/util/CMakeLists.gles1.txt
+++ b/tests/util/CMakeLists.gles1.txt
@@ -4,7 +4,6 @@ include_directories(
link_libraries(
${UTIL_GL_LIBS}
- piglitutil_${piglit_target_api}
)
piglit_add_library(piglitutil_${piglit_target_api}
diff --git a/tests/util/CMakeLists.gles2.txt b/tests/util/CMakeLists.gles2.txt
index 4342cf2..cd9e90d 100644
--- a/tests/util/CMakeLists.gles2.txt
+++ b/tests/util/CMakeLists.gles2.txt
@@ -4,7 +4,6 @@ include_directories(
link_libraries(
${UTIL_GL_LIBS}
- piglitutil_${piglit_target_api}
)
piglit_add_library(piglitutil_${piglit_target_api}
diff --git a/tests/util/CMakeLists.gles3.txt b/tests/util/CMakeLists.gles3.txt
index fec284a..a23c0c7 100644
--- a/tests/util/CMakeLists.gles3.txt
+++ b/tests/util/CMakeLists.gles3.txt
@@ -4,7 +4,6 @@ include_directories(
link_libraries(
${UTIL_GL_LIBS}
- piglitutil_${piglit_target_api}
)
piglit_add_library(piglitutil_${piglit_target_api}
Reviewed-by: Jose Fonseca
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 3/3] cmake, gles: Remove target from the lib list
On Sun, 2014-12-21 at 18:41 +, Emil Velikov wrote: > On 16 December 2014 at 23:27, Jan Vesely wrote: > > On Sun, 2014-12-14 at 16:16 +, Emil Velikov wrote: > >> On 12/12/14 19:33, Jan Vesely wrote: > >> > Fixes Target links to itself cmake warnings > >> > > >> > Signed-off-by: Jan Vesely > >> > --- > >> > > >> Hmm those seems exist since day 1, yet the intent seems to be missing. > >> > >> Currently the library tries to link against itself, which is why cmake > >> is printing out the warnings. > >> > >> Thanks for clearing this up :) > >> > >> Reviewed-by: Emil Velikov > > > > thanks, do you mind pushing it as well? > > my account request bug is stuck > > > Done. Haven't touched/pushed patches 1 and 2, as afaics they're lacking r-b. thanks. that was the idea, as the first two might need a bit more discussion. jan > > -Emil -- Jan Vesely signature.asc Description: This is a digitally signed message part ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 3/3] cmake, gles: Remove target from the lib list
Cameron On 21 Dec 2014 11:41, "Emil Velikov" wrote: > On 16 December 2014 at 23:27, Jan Vesely wrote: > > On Sun, 2014-12-14 at 16:16 +, Emil Velikov wrote: > >> On 12/12/14 19:33, Jan Vesely wrote: > >> > Fixes Target links to itself cmake warnings > >> > > >> > Signed-off-by: Jan Vesely > >> > --- > >> > > >> Hmm those seems exist since day 1, yet the intent seems to be missing. > >> > >> Currently the library tries to link against itself, which is why cmake > >> is printing out the warnings. > >> > >> Thanks for clearing this up :) > >> > >> Reviewed-by: Emil Velikov > > > > thanks, do you mind pushing it as well? > > my account request bug is stuck > > > Done. Haven't touched/pushed patches 1 and 2, as afaics they're lacking > r-b. > > -Emil > ___ > Piglit mailing list > Piglit@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/piglit > ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 3/3] cmake, gles: Remove target from the lib list
On 16 December 2014 at 23:27, Jan Vesely wrote: > On Sun, 2014-12-14 at 16:16 +, Emil Velikov wrote: >> On 12/12/14 19:33, Jan Vesely wrote: >> > Fixes Target links to itself cmake warnings >> > >> > Signed-off-by: Jan Vesely >> > --- >> > >> Hmm those seems exist since day 1, yet the intent seems to be missing. >> >> Currently the library tries to link against itself, which is why cmake >> is printing out the warnings. >> >> Thanks for clearing this up :) >> >> Reviewed-by: Emil Velikov > > thanks, do you mind pushing it as well? > my account request bug is stuck > Done. Haven't touched/pushed patches 1 and 2, as afaics they're lacking r-b. -Emil ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 3/3] cmake, gles: Remove target from the lib list
On Sun, 2014-12-14 at 16:16 +, Emil Velikov wrote:
> On 12/12/14 19:33, Jan Vesely wrote:
> > Fixes Target links to itself cmake warnings
> >
> > Signed-off-by: Jan Vesely
> > ---
> >
> Hmm those seems exist since day 1, yet the intent seems to be missing.
>
> Currently the library tries to link against itself, which is why cmake
> is printing out the warnings.
>
> Thanks for clearing this up :)
>
> Reviewed-by: Emil Velikov
thanks, do you mind pushing it as well?
my account request bug is stuck
jan
>
> > compile tested. no missing symbols or libraries reported for
> > libpiglitutils_glesX.so
> >
> > tests/util/CMakeLists.gles1.txt | 1 -
> > tests/util/CMakeLists.gles2.txt | 1 -
> > tests/util/CMakeLists.gles3.txt | 1 -
> > 3 files changed, 3 deletions(-)
> >
> > diff --git a/tests/util/CMakeLists.gles1.txt
> > b/tests/util/CMakeLists.gles1.txt
> > index 4342cf2..cd9e90d 100644
> > --- a/tests/util/CMakeLists.gles1.txt
> > +++ b/tests/util/CMakeLists.gles1.txt
> > @@ -4,7 +4,6 @@ include_directories(
> >
> > link_libraries(
> > ${UTIL_GL_LIBS}
> > - piglitutil_${piglit_target_api}
> > )
> >
> > piglit_add_library(piglitutil_${piglit_target_api}
> > diff --git a/tests/util/CMakeLists.gles2.txt
> > b/tests/util/CMakeLists.gles2.txt
> > index 4342cf2..cd9e90d 100644
> > --- a/tests/util/CMakeLists.gles2.txt
> > +++ b/tests/util/CMakeLists.gles2.txt
> > @@ -4,7 +4,6 @@ include_directories(
> >
> > link_libraries(
> > ${UTIL_GL_LIBS}
> > - piglitutil_${piglit_target_api}
> > )
> >
> > piglit_add_library(piglitutil_${piglit_target_api}
> > diff --git a/tests/util/CMakeLists.gles3.txt
> > b/tests/util/CMakeLists.gles3.txt
> > index fec284a..a23c0c7 100644
> > --- a/tests/util/CMakeLists.gles3.txt
> > +++ b/tests/util/CMakeLists.gles3.txt
> > @@ -4,7 +4,6 @@ include_directories(
> >
> > link_libraries(
> > ${UTIL_GL_LIBS}
> > - piglitutil_${piglit_target_api}
> > )
> >
> > piglit_add_library(piglitutil_${piglit_target_api}
> >
>
--
Jan Vesely
signature.asc
Description: This is a digitally signed message part
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Re: [Piglit] [PATCH 3/3] cmake, gles: Remove target from the lib list
On 12/12/14 19:33, Jan Vesely wrote:
> Fixes Target links to itself cmake warnings
>
> Signed-off-by: Jan Vesely
> ---
>
Hmm those seems exist since day 1, yet the intent seems to be missing.
Currently the library tries to link against itself, which is why cmake
is printing out the warnings.
Thanks for clearing this up :)
Reviewed-by: Emil Velikov
> compile tested. no missing symbols or libraries reported for
> libpiglitutils_glesX.so
>
> tests/util/CMakeLists.gles1.txt | 1 -
> tests/util/CMakeLists.gles2.txt | 1 -
> tests/util/CMakeLists.gles3.txt | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/tests/util/CMakeLists.gles1.txt b/tests/util/CMakeLists.gles1.txt
> index 4342cf2..cd9e90d 100644
> --- a/tests/util/CMakeLists.gles1.txt
> +++ b/tests/util/CMakeLists.gles1.txt
> @@ -4,7 +4,6 @@ include_directories(
>
> link_libraries(
> ${UTIL_GL_LIBS}
> - piglitutil_${piglit_target_api}
> )
>
> piglit_add_library(piglitutil_${piglit_target_api}
> diff --git a/tests/util/CMakeLists.gles2.txt b/tests/util/CMakeLists.gles2.txt
> index 4342cf2..cd9e90d 100644
> --- a/tests/util/CMakeLists.gles2.txt
> +++ b/tests/util/CMakeLists.gles2.txt
> @@ -4,7 +4,6 @@ include_directories(
>
> link_libraries(
> ${UTIL_GL_LIBS}
> - piglitutil_${piglit_target_api}
> )
>
> piglit_add_library(piglitutil_${piglit_target_api}
> diff --git a/tests/util/CMakeLists.gles3.txt b/tests/util/CMakeLists.gles3.txt
> index fec284a..a23c0c7 100644
> --- a/tests/util/CMakeLists.gles3.txt
> +++ b/tests/util/CMakeLists.gles3.txt
> @@ -4,7 +4,6 @@ include_directories(
>
> link_libraries(
> ${UTIL_GL_LIBS}
> - piglitutil_${piglit_target_api}
> )
>
> piglit_add_library(piglitutil_${piglit_target_api}
>
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
