Bug#729943: jarwrapper: pass only 48 chars of Debian-Java-Parameters

2014-03-19 Thread Dmitry Smirnov
On Wed, 19 Mar 2014 06:52:56 Niels Thykier wrote:
 Why is perl needed rather than perl-base (which is essential).  The
 patch seems to be using none of the modules from perl or perl-modules

Good point. It's just that dependencies on perl-base are so rare probably 
because ${perl:Depends} never expands as perl-base but only as perl.

I'll update dependency to perl-base. I think it should be just enough.
Thanks.

-- 
Cheers,
 Dmitry Smirnov.

---

It is impossible to imagine Goethe or Beethoven being good at billiards
or golf.
-- H. L. Mencken


signature.asc
Description: This is a digitally signed message part.
__
This is the maintainer address of Debian's Java team
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#729943: jarwrapper: pass only 48 chars of Debian-Java-Parameters

2014-03-19 Thread Niels Thykier
On 2014-03-19 07:21, Dmitry Smirnov wrote:
 On Wed, 19 Mar 2014 06:52:56 Niels Thykier wrote:
 Why is perl needed rather than perl-base (which is essential).  The
 patch seems to be using none of the modules from perl or perl-modules
 
 Good point. It's just that dependencies on perl-base are so rare probably 
 because ${perl:Depends} never expands as perl-base but only as perl.
 
 I'll update dependency to perl-base. I think it should be just enough.
 Thanks.
 

Actually, you should probably just drop the dependency, since perl-base
is essential (and therefore causes a lintian error if you depend on it
without version).

~Niels

__
This is the maintainer address of Debian's Java team
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. 
Please use
debian-j...@lists.debian.org for discussions and questions.


Bug#729943: jarwrapper: pass only 48 chars of Debian-Java-Parameters

2014-03-19 Thread Dmitry Smirnov
On Wed, 19 Mar 2014 07:23:24 Niels Thykier wrote:
  because  never expands as perl-base but only as perl.
 Actually, you should probably just drop the dependency, since perl-base
 is essential (and therefore causes a lintian error if you depend on it
 without version).

You're right, depends-on-essential-package-without-using-version it is.
Perhaps the best would be to Depend on ${perl:Depends}. For jarwrapper it 
expands to empty string. 

Also ${perl:Depends} is missing from javahelper's Depends where (if added) 
it expands to perl. I'll add ${perl:Depends} to Depends of javahelper as 
the latter is actually using Perl scripts.

-- 
All the best,
 Dmitry Smirnov.


signature.asc
Description: This is a digitally signed message part.
__
This is the maintainer address of Debian's Java team
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#729943: jarwrapper: pass only 48 chars of Debian-Java-Parameters

2014-03-18 Thread Dmitry Smirnov
This bug (potentially) affect ~40 packages... Would you like a friendly NMU to 
fix it?

-- 
Regards,
 Dmitry Smirnov
 GPG key : 4096R/53968D1B

---

However beautiful the strategy, you should occasionally look at the
results.
-- Winston Churchill


signature.asc
Description: This is a digitally signed message part.
__
This is the maintainer address of Debian's Java team
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#729943: jarwrapper: pass only 48 chars of Debian-Java-Parameters

2014-03-18 Thread Emmanuel Bourg
Hi Dmitry,

I checked the suggested regexp and I confirm it parses properly the
manifest entries. It's a bit sad to add a dependency on perl just for
this though.

Could you please commit your changes on alioth and upload a regular
update instead? That would save the need to ack a NMU.

Emmanuel Bourg

__
This is the maintainer address of Debian's Java team
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. 
Please use
debian-j...@lists.debian.org for discussions and questions.


Bug#729943: jarwrapper: pass only 48 chars of Debian-Java-Parameters

2014-03-18 Thread Dmitry Smirnov
Hi Emmanuel,

On Wed, 19 Mar 2014 00:33:50 Emmanuel Bourg wrote:
 I checked the suggested regexp and I confirm it parses properly the
 manifest entries. It's a bit sad to add a dependency on perl just for
 this though.

Thanks for double-checking my fix. Although I added perl to Depends I'm not 
too sure if we have to add such explicit dependency since Perl is Priority: 
standard and therefore pretty much always installed.

I feel comfortable with Perl as dependency. I'm not too comfortable with sed 
that is (IMHO) much harder to use not to mention that sometimes it is just not 
sufficient...


 Could you please commit your changes on alioth and upload a regular
 update instead? That would save the need to ack a NMU.

Someone recently approved my request to join pkg-java (thanks if it were you) 
so I can do team uploads now. Perhaps I'll just include fix for #699180 as 
well...

I've made all the changes in my local git clone of javatools but Alioth still 
not allow me to push (perhaps because I was added just recently). I'll wait 
some hours and try again...

-- 
All the best,
 Dmitry Smirnov.


signature.asc
Description: This is a digitally signed message part.
__
This is the maintainer address of Debian's Java team
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Bug#729943: jarwrapper: pass only 48 chars of Debian-Java-Parameters

2014-03-18 Thread Niels Thykier
On 2014-03-19 02:23, Dmitry Smirnov wrote:
 Hi Emmanuel,
 

Hi,

 On Wed, 19 Mar 2014 00:33:50 Emmanuel Bourg wrote:
 I checked the suggested regexp and I confirm it parses properly the
 manifest entries. It's a bit sad to add a dependency on perl just for
 this though.
 
 Thanks for double-checking my fix. Although I added perl to Depends I'm not 
 too sure if we have to add such explicit dependency since Perl is Priority: 
 standard and therefore pretty much always installed.
 
 I feel comfortable with Perl as dependency. I'm not too comfortable with 
 sed 
 that is (IMHO) much harder to use not to mention that sometimes it is just 
 not 
 sufficient...
 
 
 [...]



Why is perl needed rather than perl-base (which is essential).  The
patch seems to be using none of the modules from perl or perl-modules

~Niels

__
This is the maintainer address of Debian's Java team
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers. 
Please use
debian-j...@lists.debian.org for discussions and questions.