Re: [Lame-dev] New lame upstream release?
I admit I am too lazy to install KDE (I am a GNOME user myself) and recompile lame with fileio=sndfile. But could some KDE user please test if the issue still persists with the patch that we apply to our lame package, i.e. the one that enables the frontend to read from stdin. Thanks Fabian Am Montag, den 01.08.2011, 10:52 +0200 schrieb Fabian Greffrath: Am 30.07.2011 14:54, schrieb Fabian Greffrath: I have investigated in this issue a bit last year and filed the following bug report against kdemultimedia-kio-plugins: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=592726 More background can be found there. IIRC, the culprit was the lame frontend's missing ability to read and encode from stdin if built against libsndfile. I have therefore applied the following patch from Gentoo to fix this issue: http://anonscm.debian.org/gitweb/?p=pkg-multimedia/lame.git;a=commitdiff;h=868416573bf09e4cc55861be42b0915ec151af8d However, on the very next day Andres changed the fileio back to lame again, so I assumed the fix was not sufficient for KDE: http://anonscm.debian.org/gitweb/?p=pkg-multimedia/lame.git;a=commitdiff;h=ad260a2893c9dac7fc1e87219fe438f92516abba Did someone actually try if the issue with KDE apps still occurs with this patch applied? - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
On Mon, Aug 1, 2011 at 2:05 PM, Andres Mejia mcita...@gmail.com wrote:
2011/7/29 Rogério Brito rbr...@ime.usp.br:
Hi there.
Just an update to the LAME-side of the discussion, LAME just got
accepted (with the replacement of the files by Apple) in Debian's
unstable distribution, by inclusion of the following patch of Andres:
2011/7/28 Andres Mejia mcita...@gmail.com:
https://sourceforge.net/tracker/?func=detailaid=3381198group_id=290atid=300290
This means that:
* LAME is available for a wider range of people, including its
function as an MP3 library;
* The inclusion process has followed an auditing process regarding to
Free Software compliance (which, in fact, required our change of some
of top level files and of the portableio.[ch] in the frontend
subdirectory);
* The availability of builds for many architectures, including some
which may have not seen too much testing so far, like mips, mipsel,
sparc, and s390;
* The revelation of a problem (race condition) in the parallel build
process of our source code.
I will commit some of the changes in the next few days. One question
here: is it worth rewriting the portableio.[ch] to be more portable,
as the name implies? I would love to know if he have broken the build
in platforms like, say, OS/2 or AmigaOS, which I've heard that people
use/used...
Regards,
--
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
Hi,
I just sent 6 patches against Rogério's git tree origin branch at
github. The first patch didn't make it through yet, but it's
essentially a patch that removes all files autogenerated by autotools.
Second patch would be useful as it will allow AM_PATH_GTK to be
defined without having to have a copy of gtk-1.2, which many people
will likely not have anymore.
Third patch changes how the debian directory is included in the
generated tarball using 'make dist'. This makes more sense, since
nothing is built from the debian directory when lame is being built.
Fourth patch is useful as it will include libtool macros in the source
tree. The only file in the m4 directory that should be tracked via CVS
is m4/acinclude.m4.
Fifth patch is the patch fixing parallel builds on i386.
And the sixth patch replaces the portableio code.
--
Regards,
Andres Mejia
Here's yet another patch.
This patch will fix builds on the alpha architecture. It does involve
the use of the new portableio code however.
--
Regards,
Andres Mejia
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
On Tue, Aug 9, 2011 at 6:41 PM, Andres Mejia mcita...@gmail.com wrote:
On Mon, Aug 1, 2011 at 2:05 PM, Andres Mejia mcita...@gmail.com wrote:
2011/7/29 Rogério Brito rbr...@ime.usp.br:
Hi there.
Just an update to the LAME-side of the discussion, LAME just got
accepted (with the replacement of the files by Apple) in Debian's
unstable distribution, by inclusion of the following patch of Andres:
2011/7/28 Andres Mejia mcita...@gmail.com:
https://sourceforge.net/tracker/?func=detailaid=3381198group_id=290atid=300290
This means that:
* LAME is available for a wider range of people, including its
function as an MP3 library;
* The inclusion process has followed an auditing process regarding to
Free Software compliance (which, in fact, required our change of some
of top level files and of the portableio.[ch] in the frontend
subdirectory);
* The availability of builds for many architectures, including some
which may have not seen too much testing so far, like mips, mipsel,
sparc, and s390;
* The revelation of a problem (race condition) in the parallel build
process of our source code.
I will commit some of the changes in the next few days. One question
here: is it worth rewriting the portableio.[ch] to be more portable,
as the name implies? I would love to know if he have broken the build
in platforms like, say, OS/2 or AmigaOS, which I've heard that people
use/used...
Regards,
--
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
Hi,
I just sent 6 patches against Rogério's git tree origin branch at
github. The first patch didn't make it through yet, but it's
essentially a patch that removes all files autogenerated by autotools.
Second patch would be useful as it will allow AM_PATH_GTK to be
defined without having to have a copy of gtk-1.2, which many people
will likely not have anymore.
Third patch changes how the debian directory is included in the
generated tarball using 'make dist'. This makes more sense, since
nothing is built from the debian directory when lame is being built.
Fourth patch is useful as it will include libtool macros in the source
tree. The only file in the m4 directory that should be tracked via CVS
is m4/acinclude.m4.
Fifth patch is the patch fixing parallel builds on i386.
And the sixth patch replaces the portableio code.
--
Regards,
Andres Mejia
Here's yet another patch.
This patch will fix builds on the alpha architecture. It does involve
the use of the new portableio code however.
--
Regards,
Andres Mejia
And the actual patch.
http://anonscm.debian.org/gitweb/?p=pkg-multimedia/lame.git;a=blob;f=debian/patches/alpha-build-fix.patch;h=1aa58535998ed3a26f9b2dd926bae4ae0afe1c30;hb=cbc873db2346e788eca96db7084be73fd1d4aa39
--
Regards,
Andres Mejia
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
Am 30.07.2011 14:54, schrieb Fabian Greffrath: I have investigated in this issue a bit last year and filed the following bug report against kdemultimedia-kio-plugins: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=592726 More background can be found there. IIRC, the culprit was the lame frontend's missing ability to read and encode from stdin if built against libsndfile. I have therefore applied the following patch from Gentoo to fix this issue: http://anonscm.debian.org/gitweb/?p=pkg-multimedia/lame.git;a=commitdiff;h=868416573bf09e4cc55861be42b0915ec151af8d However, on the very next day Andres changed the fileio back to lame again, so I assumed the fix was not sufficient for KDE: http://anonscm.debian.org/gitweb/?p=pkg-multimedia/lame.git;a=commitdiff;h=ad260a2893c9dac7fc1e87219fe438f92516abba Did someone actually try if the issue with KDE apps still occurs with this patch applied? - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
2011/7/29 Rogério Brito rbr...@ime.usp.br:
Hi there.
Just an update to the LAME-side of the discussion, LAME just got
accepted (with the replacement of the files by Apple) in Debian's
unstable distribution, by inclusion of the following patch of Andres:
2011/7/28 Andres Mejia mcita...@gmail.com:
https://sourceforge.net/tracker/?func=detailaid=3381198group_id=290atid=300290
This means that:
* LAME is available for a wider range of people, including its
function as an MP3 library;
* The inclusion process has followed an auditing process regarding to
Free Software compliance (which, in fact, required our change of some
of top level files and of the portableio.[ch] in the frontend
subdirectory);
* The availability of builds for many architectures, including some
which may have not seen too much testing so far, like mips, mipsel,
sparc, and s390;
* The revelation of a problem (race condition) in the parallel build
process of our source code.
I will commit some of the changes in the next few days. One question
here: is it worth rewriting the portableio.[ch] to be more portable,
as the name implies? I would love to know if he have broken the build
in platforms like, say, OS/2 or AmigaOS, which I've heard that people
use/used...
Regards,
--
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
Hi,
I just sent 6 patches against Rogério's git tree origin branch at
github. The first patch didn't make it through yet, but it's
essentially a patch that removes all files autogenerated by autotools.
Second patch would be useful as it will allow AM_PATH_GTK to be
defined without having to have a copy of gtk-1.2, which many people
will likely not have anymore.
Third patch changes how the debian directory is included in the
generated tarball using 'make dist'. This makes more sense, since
nothing is built from the debian directory when lame is being built.
Fourth patch is useful as it will include libtool macros in the source
tree. The only file in the m4 directory that should be tracked via CVS
is m4/acinclude.m4.
Fifth patch is the patch fixing parallel builds on i386.
And the sixth patch replaces the portableio code.
--
Regards,
Andres Mejia
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
On Sat, 30 Jul 2011 19:41:13 +0200 Reinhard Tartler siret...@tauware.de wrote: On Sat, Jul 30, 2011 at 17:40:13 (CEST), Alexander Leidinger wrote: * The revelation of a problem (race condition) in the parallel build process of our source code. Can you please give me the URL of this patch or send it to me directly? I would like to review it. See here: http://anonscm.debian.org/gitweb/?p=pkg-multimedia/lame.git;a=tree;f=debian/patches Thanks. The _DEPENDENCIES part seems to be the important part here (as I misuse some implementation details of automake). Did someone try to automatically generate the list of dependencies with the .libs directory prefix? If not, has someone a little bit of time to give it a try (this way we don't have to change the .nas.lo part, and we keep the object files where the auto* tools expect them)? Bye, Alexander. -- http://www.Leidinger.netAlexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
On Thu, 28 Jul 2011 18:09:29 -0400 Andres Mejia mcita...@gmail.com wrote: It's disabled because of the AM_PATH_GTK macro in configure.in. Perhaps the m4 file that defines this macro should be included with lame then. Uhm... the macro came with the official gtk1.x. I don't remember exactly the auto* behavior, but I thought it takes the macros into aclocal or some similar file inside the tree. So it should be either available in the CVS already and you should make sure you didn't overwrite it by accident, or you can copy it from the last official gtk1 release. Bye, Alexander. -- http://www.Leidinger.netAlexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
On Wed, 27 Jul 2011 18:26:23 -0400 Andres Mejia mcita...@gmail.com wrote: We outright disable the use of the GTK frontend, since it requires a very old version of GTK. I think there are better tools out now (audacity maybe). Perhaps the GTK frontend should be removed from lame entirely. The GTK frontend is a mp3-algorithm debugging frontend. IIRC there's a configure option to disable it, so I'm a little bit puzzled why you need to remove it from configure.in. The other change simply changes how the debian directory is included in the generated tarball. The debian directory still gets included, but there's no need to have any Makefile* files in the debian directory. This would remove our need to patch the build system for each release of lame. The Makefiles are there so that our release-tarball contains the debian directory (auto* magic) and everyone can create a debian package. If you (as the debian project) tell that this is not necessary anymore (because you will take care about it like I do it in the FreeBSD package system), we can either remove the makefiles, or the complete debian directory. What's the best way in your opinion? Bye, Alexander. -- http://www.Leidinger.netAlexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
Hi there.
Just an update to the LAME-side of the discussion, LAME just got
accepted (with the replacement of the files by Apple) in Debian's
unstable distribution, by inclusion of the following patch of Andres:
2011/7/28 Andres Mejia mcita...@gmail.com:
https://sourceforge.net/tracker/?func=detailaid=3381198group_id=290atid=300290
This means that:
* LAME is available for a wider range of people, including its
function as an MP3 library;
* The inclusion process has followed an auditing process regarding to
Free Software compliance (which, in fact, required our change of some
of top level files and of the portableio.[ch] in the frontend
subdirectory);
* The availability of builds for many architectures, including some
which may have not seen too much testing so far, like mips, mipsel,
sparc, and s390;
* The revelation of a problem (race condition) in the parallel build
process of our source code.
I will commit some of the changes in the next few days. One question
here: is it worth rewriting the portableio.[ch] to be more portable,
as the name implies? I would love to know if he have broken the build
in platforms like, say, OS/2 or AmigaOS, which I've heard that people
use/used...
Regards,
--
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
Hi, Andreas and others.
On Jul 27 2011, Andres Mejia wrote:
2011/7/27 Rogério Brito rbr...@ime.usp.br:
Oh, shit. I'll take a look at that... I thought that the code were
ifdef'ed... Isn't it?
I have a patch here with some changes we do to the build system.
OK.
We outright disable the use of the GTK frontend, since it requires a very
old version of GTK. I think there are better tools out now (audacity
maybe). Perhaps the GTK frontend should be removed from lame entirely.
Sure, it has not compiled for ages and I think that killing it leaves us
with less cruft. If someone happens to want to port it forward to GTK2 or
GTK3, though, we may reinstate it...
The other change simply changes how the debian directory is included
in the generated tarball. The debian directory still gets included,
but there's no need to have any Makefile* files in the debian
directory. This would remove our need to patch the build system for
each release of lame.
(...)
CLEANFILES = lclint.txt $(EXTRA_PROGRAMS)
Can you please send git format-patch/git send-email patches against my
github tree (branch origin), with one topic per patch?
Your patches came foo-bared and they are changing at least two things (the
GTK stuff and the debian subdir).
I've started replacing frontend/portableio.* code. I should have
something available later on tonight.
Please see the attached patch to kill portableio.c if you are using
libsndfile (which we should be in debian, anyway).
It *is* dirty and there's one function (the one to read stuff) that is not
used, but works for the purpose of decoding some files (I tested).
I should probably adapt something from a patch that I once wrote to mplayer
ages ago when I was trying to make the generated PCM files works for little
and big-endian arches (hey, I *care* about PowerPC).
Or if libsdnfile does that already, that's even better. But for the sake of
just shipping a first package in unstable, I am very anxious... :-) I want
to see this darn thing in Debian proper! :-)
One final thing, I delete the LICENSE file from the upstream tarball
since the COPYING file has the actual license text and the contents
of LICENSE seem to what is already said in the README file.
Perhaps you might want to look into that too.
Will look into that for the next release. Please, *do* ping me if I forget
about this.
Thanks,
--
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
diff --git a/frontend/Makefile.am b/frontend/Makefile.am
index 0ce4a64..215cdce 100644
--- a/frontend/Makefile.am
+++ b/frontend/Makefile.am
@@ -17,7 +17,6 @@ common_sources = \
get_audio.c \
lametime.c \
parse.c \
- portableio.c \
timestatus.c
noinst_HEADERS = \
@@ -29,7 +28,6 @@ noinst_HEADERS = \
lametime.h \
main.h \
parse.h \
- portableio.h \
timestatus.h
lame_SOURCES = lame_main.c $(common_sources)
diff --git a/frontend/Makefile.in b/frontend/Makefile.in
index 11d242a..7e415c4 100644
--- a/frontend/Makefile.in
+++ b/frontend/Makefile.in
@@ -54,7 +54,7 @@ am__installdirs = $(DESTDIR)$(bindir)
PROGRAMS = $(bin_PROGRAMS)
am__objects_1 = main$U.$(OBJEXT) brhist$U.$(OBJEXT) \
console$U.$(OBJEXT) get_audio$U.$(OBJEXT) lametime$U.$(OBJEXT) \
- parse$U.$(OBJEXT) portableio$U.$(OBJEXT) \
+ parse$U.$(OBJEXT) \
timestatus$U.$(OBJEXT)
am_lame_OBJECTS = lame_main$U.$(OBJEXT) $(am__objects_1)
lame_OBJECTS = $(am_lame_OBJECTS)
@@ -247,7 +247,6 @@ common_sources = \
get_audio.c \
lametime.c \
parse.c \
- portableio.c \
timestatus.c
noinst_HEADERS = \
@@ -259,7 +258,6 @@ noinst_HEADERS = \
lametime.h \
main.h \
parse.h \
- portableio.h \
timestatus.h
lame_SOURCES = lame_main.c $(common_sources)
@@ -386,7 +384,6 @@ mostlyclean-kr:
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/mp3rtp$U.Po@am__quote@
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/mp3x$U.Po@am__quote@
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/parse$U.Po@am__quote@
-@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/portableio$U.Po@am__quote@
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/rtp$U.Po@am__quote@
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/timestatus$U.Po@am__quote@
@@ -432,8 +429,6 @@ mp3x_.c: mp3x.c $(ANSI2KNR)
$(CPP) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) `if test -f $(srcdir)/mp3x.c; then echo $(srcdir)/mp3x.c; else echo mp3x.c; fi` | sed 's/^# \([0-9]\)/#line \1/' | $(ANSI2KNR) $@ || rm -f $@
parse_.c: parse.c $(ANSI2KNR)
$(CPP) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) `if test -f $(srcdir)/parse.c; then echo $(srcdir)/parse.c; else echo parse.c; fi` | sed 's/^# \([0-9]\)/#line \1/' | $(ANSI2KNR) $@ || rm -f $@
-portableio_.c: portableio.c $(ANSI2KNR)
- $(CPP) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) `if test -f
Re: [Lame-dev] New lame upstream release?
Hi, Andres
On Thu, Jul 28, 2011 at 13:26, Andres Mejia mcita...@gmail.com wrote:
On Jul 28, 2011 3:15 AM, Rogério Brito rbr...@ime.usp.br wrote:
Can you please send git format-patch/git send-email patches against my
github tree (branch origin), with one topic per patch?
Your patches came foo-bared and they are changing at least two things (the
GTK stuff and the debian subdir).
Just for the record, I don't know if I gave the one above proper
emphasis, but this way, I can give you proper attribution also (I hope
that this is possible with CVS).
Please see the attached patch to kill portableio.c if you are using
libsndfile (which we should be in debian, anyway).
Just for the record, did you receive the attachment that I sent? I'm
asking because I didn't. I have to fix some of my e-mail filtering of
attachments here...
Please note my earlier email about sndfile. Enabling sndfile for lame breaks
k3b and any app using kio slaves.
Oh, darn... Does that mean that Debian's lame will not be compiled
with sndfile? One question, though: what does k3b and the kio slaves
use lame for? For decoding MP3s? Shouldn't they be using a specialized
software for decoding files?
If you look around, the only fix is to use lame's internal io functions when
this breakage happens.
Well, the functions in the portableio (they aren't portable) are all
easy enough to be written... All they effectively do is write a given
short/int/long in little or big endian form to a C's FILE... I can
come up with another patch that reimplement that, but that's so silly
to have to rewrite... :-(
Regards,
--
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
On Jul 28, 2011 1:28 PM, Andres Mejia mcita...@gmail.com wrote:
On Jul 28, 2011 12:43 PM, Rogério Brito rbr...@ime.usp.br wrote:
Hi, Andres
On Thu, Jul 28, 2011 at 13:26, Andres Mejia mcita...@gmail.com wrote:
On Jul 28, 2011 3:15 AM, Rogério Brito rbr...@ime.usp.br wrote:
Can you please send git format-patch/git send-email patches against
my
github tree (branch origin), with one topic per patch?
Your patches came foo-bared and they are changing at least two things
(the
GTK stuff and the debian subdir).
Just for the record, I don't know if I gave the one above proper
emphasis, but this way, I can give you proper attribution also (I hope
that this is possible with CVS).
Please see the attached patch to kill portableio.c if you are using
libsndfile (which we should be in debian, anyway).
Just for the record, did you receive the attachment that I sent? I'm
asking because I didn't. I have to fix some of my e-mail filtering of
attachments here...
Yes, I got the attachment.
Please note my earlier email about sndfile. Enabling sndfile for lame
breaks
k3b and any app using kio slaves.
Oh, darn... Does that mean that Debian's lame will not be compiled
with sndfile?
Yes, lame is compiled using it's internal io functions.
One question, though: what does k3b and the kio slaves
use lame for? For decoding MP3s? Shouldn't they be using a specialized
software for decoding files?
K3b is a cd authoring app that also rips cds to mp3. Lame is used for mp3
encoding.
If you look around, the only fix is to use lame's internal io
functions when
this breakage happens.
Well, the functions in the portableio (they aren't portable) are all
easy enough to be written... All they effectively do is write a given
short/int/long in little or big endian form to a C's FILE... I can
come up with another patch that reimplement that, but that's so silly
to have to rewrite... :-(
I have a patch already submitted via the bug tracker. This was simple
enough to write, debug, and verify it works correctly.
Regards,
--
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
FYI for all
https://sourceforge.net/tracker/?func=detailaid=3381198group_id=290atid=300290
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
Rogério Brito a écrit : We outright disable the use of the GTK frontend, since it requires a very old version of GTK. I think there are better tools out now (audacity maybe). Perhaps the GTK frontend should be removed from lame entirely. Sure, it has not compiled for ages and I think that killing it leaves us with less cruft. If someone happens to want to port it forward to GTK2 or GTK3, though, we may reinstate it... If we are talking about MP3x (our GTK frame analyser): http://lame.sourceforge.net/images/gpsycho.gif then even though it's using a very old GTK version, I'd like to keep it in Lame. It's a very valuable tool, which can not be replaced by Audacity. That being said, it's a developper tool only, so excluding it of the Debian package has absolutely no incidence. Anyone wanting to use mp3x will also likely use a fresh build from the CVS repository instead of a package. -- Gabriel Bouvigne www.mp3-tech.org personal page: http://gabriel.mp3-tech.org ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
2011/7/28 Gabriel Bouvigne bouvi...@mp3-tech.org: Rogério Brito a écrit : We outright disable the use of the GTK frontend, since it requires a very old version of GTK. I think there are better tools out now (audacity maybe). Perhaps the GTK frontend should be removed from lame entirely. Sure, it has not compiled for ages and I think that killing it leaves us with less cruft. If someone happens to want to port it forward to GTK2 or GTK3, though, we may reinstate it... If we are talking about MP3x (our GTK frame analyser): http://lame.sourceforge.net/images/gpsycho.gif then even though it's using a very old GTK version, I'd like to keep it in Lame. It's a very valuable tool, which can not be replaced by Audacity. That being said, it's a developper tool only, so excluding it of the Debian package has absolutely no incidence. Anyone wanting to use mp3x will also likely use a fresh build from the CVS repository instead of a package. -- Gabriel Bouvigne www.mp3-tech.org personal page: http://gabriel.mp3-tech.org It's disabled because of the AM_PATH_GTK macro in configure.in. Perhaps the m4 file that defines this macro should be included with lame then. -- Regards, Andres Mejia ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
On Thu, Jul 28, 2011 at 6:09 PM, Andres Mejia mcita...@gmail.com wrote:
2011/7/28 Gabriel Bouvigne bouvi...@mp3-tech.org:
Rogério Brito a écrit :
We outright disable the use of the GTK frontend, since it requires a very
old version of GTK. I think there are better tools out now (audacity
maybe). Perhaps the GTK frontend should be removed from lame entirely.
Sure, it has not compiled for ages and I think that killing it leaves us
with less cruft. If someone happens to want to port it forward to GTK2 or
GTK3, though, we may reinstate it...
If we are talking about MP3x (our GTK frame analyser):
http://lame.sourceforge.net/images/gpsycho.gif
then even though it's using a very old GTK version, I'd like to keep it in
Lame. It's a very valuable tool, which can not be replaced by Audacity.
That being said, it's a developper tool only, so excluding it of the Debian
package has absolutely no incidence. Anyone wanting to use mp3x will also
likely use a fresh build from the CVS repository instead of a package.
--
Gabriel Bouvigne
www.mp3-tech.org
personal page: http://gabriel.mp3-tech.org
It's disabled because of the AM_PATH_GTK macro in configure.in.
Perhaps the m4 file that defines this macro should be included with
lame then.
--
Regards,
Andres Mejia
Hello all,
I'm going to go ahead and repackage lame again to include the
portableio replacement code I submitted. I've attached the files in
this email, in case any of you have problems viewing the patch at the
sourceforge link I provided earlier.
Hopefully, this is the last such change we need to provide in order to
upload lame.
--
Regards,
Andres Mejia
diff --git a/frontend/Makefile.am b/frontend/Makefile.am
index 0ce4a64..7dc34de 100644
--- a/frontend/Makefile.am
+++ b/frontend/Makefile.am
@@ -17,7 +17,6 @@ common_sources = \
get_audio.c \
lametime.c \
parse.c \
- portableio.c \
timestatus.c
noinst_HEADERS = \
diff --git a/frontend/portableio.h b/frontend/portableio.h
index 98cc048..d63cd84 100644
--- a/frontend/portableio.h
+++ b/frontend/portableio.h
@@ -1,94 +1,183 @@
-#ifndef LAME_PORTABLEIO_H
-#define LAME_PORTABLEIO_H
-/* Copyright (C) 1988-1991 Apple Computer, Inc.
- * All Rights Reserved.
- *
- * Warranty Information
- * Even though Apple has reviewed this software, Apple makes no warranty
- * or representation, either express or implied, with respect to this
- * software, its quality, accuracy, merchantability, or fitness for a
- * particular purpose. As a result, this software is provided as is,
- * and you, its user, are assuming the entire risk as to its quality
- * and accuracy.
- *
- * This code may be used and freely distributed as long as it includes
- * this copyright notice and the warranty information.
- *
- * Machine-independent I/O routines for 8-, 16-, 24-, and 32-bit integers.
- *
- * Motorola processors (Macintosh, Sun, Sparc, MIPS, etc)
- * pack bytes from high to low (they are big-endian).
- * Use the HighLow routines to match the native format
- * of these machines.
+/* Simple I/O Function header file
*
- * Intel-like machines (PCs, Sequent)
- * pack bytes from low to high (the are little-endian).
- * Use the LowHigh routines to match the native format
- * of these machines.
+ * Copyright (C) 2011 Andres Mejia
*
- * These routines have been tested on the following machines:
- * Apple Macintosh, MPW 3.1 C compiler
- * Apple Macintosh, THINK C compiler
- * Silicon Graphics IRIS, MIPS compiler
- * Cray X/MP and Y/MP
- * Digital Equipment VAX
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Library General Public
+ * License as published by the Free Software Foundation; either
+ * version 2 of the License, or (at your option) any later version.
*
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Library General Public License for more details.
*
- * Implemented by Malcolm Slaney and Ken Turkowski.
- *
- * Malcolm Slaney contributions during 1988-1990 include big- and little-
- * endian file I/O, conversion to and from Motorola's extended 80-bit
- * floating-point format, and conversions to and from IEEE single-
- * precision floating-point format.
- *
- * In 1991, Ken Turkowski implemented the conversions to and from
- * IEEE double-precision format, added more precision to the extended
- * conversions, and accommodated conversions involving +/- infinity,
- * NaN's, and denormalized numbers.
- *
- * $Id$
+ * You should have received a copy of the GNU Library General Public License
+ * along with this program. If not, see http://www.gnu.org/licenses/.
*/
+#ifndef LAME_PORTABLEIO_H
+#define LAME_PORTABLEIO_H
+
#include stdio.h
+#include stdint.h
+#include math.h
-#if defined(__cplusplus)
-extern C {
-#endif
+#include config.h
+
+static inline int ReadByte(FILE *
Re: [Lame-dev] New lame upstream release?
Dear people,
I'm in the middle of a power outage right now, using the last few
drops of energy of notebook battery and a 3G connection, so I will be
brief. (Oh, please keep in the CC'ies to me).
On Tue, Jul 26, 2011 at 14:41, Andres Mejia mcita...@gmail.com wrote:
On Jul 26, 2011 12:49 PM, robert robert.hegem...@gmx.de wrote:
Hi Rogério.
Am 26.07.2011, 16:24 Uhr, schrieb Rogério Brito rbr...@ime.usp.br:
We're just waiting for a new release of lame with all the license
clarification changes before uploading lame to Debian. :-)
I don't think that we will be able to release anything in time for
DebConf,
as LAME is just beginning to get into the beta stage.
What time frame are we talking about?
From my point of view, there may be some small patches to apply
and then release 3.99:
1 - pending LGPL patch
2 - eventually changing default behaviour for ID3v2 unicode tags.
What do the others think?
Robert, it seems that Andres just adopted the suggestion that I gave
him of backporting some changes. Regarding a new release, I think that
we may need to include one extra thing in our TODO list. See below.
I was simply going to backport the lgpl patches and upload the last release.
I suppose there's no need to wait for a new release now.
Andres, I just saw that LAME was rejected by the FTP masters:
http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/2011-July/020498.html
That part is only used if we use lame's internal IO routines. Just rip
that apart and link with libsndfile and we're done. Please reupload
that...
I am motivated enough to get LAME into Debian that I am *seriously*
planning to rewrite that portion of the code for the next stable
release, implementing just the bare minimum that is needed for LAME to
work (and, of course, not reproducing Erik Castro's work with
sndfile).
Most of the functions in portableio.[ch] are quite trivial, anyway...
You can tell that I *badly* want LAME in Debian, can't you?
(Especially now that it seems that the FTP masters are convinced that
such software is Free Software).
Oh, hint, hint for the multimedia maintainers: what about uploading my
already packaged mp3packer from my launchpad PPA? [0]
[0]:
https://launchpad.net/~rbrito/+archive/ppa/+files/mp3packer_1.20-1~ubuntu1.dsc
OK, the battery of my laptop is running out... :-(
Regards,
--
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
On Jul 27, 2011 1:48 PM, Rogério Brito rbr...@ime.usp.br wrote:
Dear people,
I'm in the middle of a power outage right now, using the last few
drops of energy of notebook battery and a 3G connection, so I will be
brief. (Oh, please keep in the CC'ies to me).
On Tue, Jul 26, 2011 at 14:41, Andres Mejia mcita...@gmail.com wrote:
On Jul 26, 2011 12:49 PM, robert robert.hegem...@gmx.de wrote:
Hi Rogério.
Am 26.07.2011, 16:24 Uhr, schrieb Rogério Brito rbr...@ime.usp.br:
We're just waiting for a new release of lame with all the license
clarification changes before uploading lame to Debian. :-)
I don't think that we will be able to release anything in time for
DebConf,
as LAME is just beginning to get into the beta stage.
What time frame are we talking about?
From my point of view, there may be some small patches to apply
and then release 3.99:
1 - pending LGPL patch
2 - eventually changing default behaviour for ID3v2 unicode tags.
What do the others think?
Robert, it seems that Andres just adopted the suggestion that I gave
him of backporting some changes. Regarding a new release, I think that
we may need to include one extra thing in our TODO list. See below.
I was simply going to backport the lgpl patches and upload the last
release.
I suppose there's no need to wait for a new release now.
Andres, I just saw that LAME was rejected by the FTP masters:
http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/2011-July/020498.html
That part is only used if we use lame's internal IO routines. Just rip
that apart and link with libsndfile and we're done. Please reupload
that...
I am motivated enough to get LAME into Debian that I am *seriously*
planning to rewrite that portion of the code for the next stable
release, implementing just the bare minimum that is needed for LAME to
work (and, of course, not reproducing Erik Castro's work with
sndfile).
Most of the functions in portableio.[ch] are quite trivial, anyway...
You can tell that I *badly* want LAME in Debian, can't you?
(Especially now that it seems that the FTP masters are convinced that
such software is Free Software).
Oh, hint, hint for the multimedia maintainers: what about uploading my
already packaged mp3packer from my launchpad PPA? [0]
[0]:
https://launchpad.net/~rbrito/+archive/ppa/+files/mp3packer_1.20-1~ubuntu1.dsc
OK, the battery of my laptop is running out... :-(
Regards,
--
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
I was going to replace that code myself actually. I had the idea of using
only portableio.h with inline functions and removing portableio.c.
Also, i've had a problem before with using sndfile with lame and k3b. Not
sure if that's been resolved by now.
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
On Wed, Jul 27, 2011 at 19:48:05 (CEST), Rogério Brito wrote: Dear people, I'm in the middle of a power outage right now, using the last few drops of energy of notebook battery and a 3G connection, so I will be brief. (Oh, please keep in the CC'ies to me). On Tue, Jul 26, 2011 at 14:41, Andres Mejia mcita...@gmail.com wrote: On Jul 26, 2011 12:49 PM, robert robert.hegem...@gmx.de wrote: Hi Rogério. Am 26.07.2011, 16:24 Uhr, schrieb Rogério Brito rbr...@ime.usp.br: We're just waiting for a new release of lame with all the license clarification changes before uploading lame to Debian. :-) I don't think that we will be able to release anything in time for DebConf, as LAME is just beginning to get into the beta stage. What time frame are we talking about? From my point of view, there may be some small patches to apply and then release 3.99: 1 - pending LGPL patch 2 - eventually changing default behaviour for ID3v2 unicode tags. What do the others think? Robert, it seems that Andres just adopted the suggestion that I gave him of backporting some changes. Regarding a new release, I think that we may need to include one extra thing in our TODO list. See below. Andres, may I suggest that instead of placing patches inline in debian/lame-get-orig-source.sh, we create an 'upstream-dfsg' branch, do modifications there directly and roll tarballs from that? I was simply going to backport the lgpl patches and upload the last release. I suppose there's no need to wait for a new release now. Andres, I just saw that LAME was rejected by the FTP masters: http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/2011-July/020498.html That part is only used if we use lame's internal IO routines. Just rip that apart and link with libsndfile and we're done. Please reupload that... Unforunately, this won't work easily because frontend/main.c uses functions from portableio.h unconditionally. We'd therefore need some more patches. Anyone familiar with the codebase and willing to contribute that patch? I am motivated enough to get LAME into Debian that I am *seriously* planning to rewrite that portion of the code for the next stable release, implementing just the bare minimum that is needed for LAME to work (and, of course, not reproducing Erik Castro's work with sndfile). Most of the functions in portableio.[ch] are quite trivial, anyway... You can tell that I *badly* want LAME in Debian, can't you? (Especially now that it seems that the FTP masters are convinced that such software is Free Software). Oh, hint, hint for the multimedia maintainers: what about uploading my already packaged mp3packer from my launchpad PPA? [0] [0]: https://launchpad.net/~rbrito/+archive/ppa/+files/mp3packer_1.20-1~ubuntu1.dsc OK, the battery of my laptop is running out... :-( Doesn't the package lack a dependency on lame? AFAIUI it is a tool to reencode .mp3 files. I persume that it uses lame for that, but the documentatin isn't entirely clear on that. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
Hi, Reinhard.
I hope that you're having a good DebConf... I miss chatting with you...
On 2011-07-27, at 16:22, Reinhard Tartler wrote:
On Wed, Jul 27, 2011 at 19:48:05 (CEST), Rogério Brito wrote:
I'm in the middle of a power outage right now, using the last few
drops of energy of notebook battery and a 3G connection, so I will be
brief. (Oh, please keep in the CC'ies to me).
The energy just came back and I'm taking that time to charge my
battery, but I won't be able to compile stuff here.
On Tue, Jul 26, 2011 at 14:41, Andres Mejia mcita...@gmail.com
wrote:
On Jul 26, 2011 12:49 PM, robert robert.hegem...@gmx.de wrote:
From my point of view, there may be some small patches to apply
and then release 3.99:
1 - pending LGPL patch
2 - eventually changing default behaviour for ID3v2 unicode tags.
Robert, it seems that Andres just adopted the suggestion that I gave
him of backporting some changes. Regarding a new release, I think
that
we may need to include one extra thing in our TODO list. See below.
Andres, may I suggest that instead of placing patches inline in
debian/lame-get-orig-source.sh, we create an 'upstream-dfsg'
branch, do
modifications there directly and roll tarballs from that?
I would like to take a peek at how you guys are packaging it... Will
do as soon as the power is back.
Andres, I just saw that LAME was rejected by the FTP masters:
http://lists.alioth.debian.org/pipermail/pkg-multimedia-
maintainers/2011-July/020498.html
That part is only used if we use lame's internal IO routines. Just
rip
that apart and link with libsndfile and we're done. Please reupload
that...
Unforunately, this won't work easily because frontend/main.c uses
functions from portableio.h unconditionally. We'd therefore need some
more patches. Anyone familiar with the codebase and willing to
contribute that patch?
Oh, shit. I'll take a look at that... I thought that the code were
ifdef'ed... Isn't it?
Most of the functions in portableio.[ch] are quite trivial, anyway...
You can tell that I *badly* want LAME in Debian, can't you?
(Especially now that it seems that the FTP masters are convinced that
such software is Free Software).
Oh, hint, hint for the multimedia maintainers: what about
uploading my
already packaged mp3packer from my launchpad PPA? [0]
[0]: https://launchpad.net/~rbrito/+archive/ppa/+files/
mp3packer_1.20-1~ubuntu1.dsc
OK, the battery of my laptop is running out... :-(
Doesn't the package lack a dependency on lame?
No, absolutely *no* dependency on LAME.
AFAIUI it is a tool to
reencode .mp3 files. I persume that it uses lame for that, but the
documentatin isn't entirely clear on that.
It doesn't reencode. It only rearranges the frames in a lossless
manner. Like, for instance, getting the bits that are already
produced by an MP3 encoder (any one) and putting them in bins so as
to make the files smaller (taking a better advantage of the bit
reservoir, etc).
The program is so darned cool... The best thing with this MP3 thing
is that even though you already have a file that is encoded by
anyone, it is possible to a great extent to manipulate it losslessly:
* mp3gain, to avoid clipping while decoding (of course, clipping
before encoding is not remediable);
* mp3packer, to squeeze some extra bits and make the files smaller
(reduding the bitrate).
In my very humble opinion, the combo (mp3packer, LAME) breathes at
least a little bit of life in a format that many already thought that
was dead, while still being, say, universally compatible... With
them, you can raise the bitrate of your encodes a notch to get better
sound and then losslessly rearrange the file to a lower bitrate...
A side effect of it is that it also fixes many old VBR files that may
have incorrect lengths reported (and, thus, renders my package vbrfix
obsolete).
OK, enough blurb. The packaging of mp3packer is really trivial (as
you can see) and I would volunteer to maintain it under the pkg-
multimedia umbrella.
Regards,
--
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
2011/7/27 Rogério Brito rbr...@ime.usp.br:
Hi, Reinhard.
I hope that you're having a good DebConf... I miss chatting with you...
On 2011-07-27, at 16:22, Reinhard Tartler wrote:
On Wed, Jul 27, 2011 at 19:48:05 (CEST), Rogério Brito wrote:
I'm in the middle of a power outage right now, using the last few
drops of energy of notebook battery and a 3G connection, so I will be
brief. (Oh, please keep in the CC'ies to me).
The energy just came back and I'm taking that time to charge my battery, but
I won't be able to compile stuff here.
On Tue, Jul 26, 2011 at 14:41, Andres Mejia mcita...@gmail.com wrote:
On Jul 26, 2011 12:49 PM, robert robert.hegem...@gmx.de wrote:
From my point of view, there may be some small patches to apply
and then release 3.99:
1 - pending LGPL patch
2 - eventually changing default behaviour for ID3v2 unicode tags.
Robert, it seems that Andres just adopted the suggestion that I gave
him of backporting some changes. Regarding a new release, I think that
we may need to include one extra thing in our TODO list. See below.
Andres, may I suggest that instead of placing patches inline in
debian/lame-get-orig-source.sh, we create an 'upstream-dfsg' branch, do
modifications there directly and roll tarballs from that?
I would like to take a peek at how you guys are packaging it... Will do as
soon as the power is back.
Andres, I just saw that LAME was rejected by the FTP masters:
http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/2011-July/020498.html
That part is only used if we use lame's internal IO routines. Just rip
that apart and link with libsndfile and we're done. Please reupload
that...
Unforunately, this won't work easily because frontend/main.c uses
functions from portableio.h unconditionally. We'd therefore need some
more patches. Anyone familiar with the codebase and willing to
contribute that patch?
Oh, shit. I'll take a look at that... I thought that the code were
ifdef'ed... Isn't it?
Most of the functions in portableio.[ch] are quite trivial, anyway...
You can tell that I *badly* want LAME in Debian, can't you?
(Especially now that it seems that the FTP masters are convinced that
such software is Free Software).
Oh, hint, hint for the multimedia maintainers: what about uploading my
already packaged mp3packer from my launchpad PPA? [0]
[0]:
https://launchpad.net/~rbrito/+archive/ppa/+files/mp3packer_1.20-1~ubuntu1.dsc
OK, the battery of my laptop is running out... :-(
Doesn't the package lack a dependency on lame?
No, absolutely *no* dependency on LAME.
AFAIUI it is a tool to
reencode .mp3 files. I persume that it uses lame for that, but the
documentatin isn't entirely clear on that.
It doesn't reencode. It only rearranges the frames in a lossless manner.
Like, for instance, getting the bits that are already produced by an MP3
encoder (any one) and putting them in bins so as to make the files smaller
(taking a better advantage of the bit reservoir, etc).
The program is so darned cool... The best thing with this MP3 thing is that
even though you already have a file that is encoded by anyone, it is
possible to a great extent to manipulate it losslessly:
* mp3gain, to avoid clipping while decoding (of course, clipping before
encoding is not remediable);
* mp3packer, to squeeze some extra bits and make the files smaller (reduding
the bitrate).
In my very humble opinion, the combo (mp3packer, LAME) breathes at least a
little bit of life in a format that many already thought that was dead,
while still being, say, universally compatible... With them, you can raise
the bitrate of your encodes a notch to get better sound and then losslessly
rearrange the file to a lower bitrate...
A side effect of it is that it also fixes many old VBR files that may have
incorrect lengths reported (and, thus, renders my package vbrfix obsolete).
OK, enough blurb. The packaging of mp3packer is really trivial (as you can
see) and I would volunteer to maintain it under the pkg-multimedia umbrella.
Regards,
--
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
Hi Rogério,
I have a patch here with some changes we do to the build system.
We outright disable the use of the GTK frontend, since it requires a
very old version of GTK. I think there are better tools out now
(audacity maybe). Perhaps the GTK frontend should be removed from lame
entirely.
The other change simply changes how the debian directory is included
in the generated tarball. The debian directory still gets included,
but there's no need to have any Makefile* files in the debian
directory. This would remove our need to patch the build system for
each release of lame.
Index: configure.in
===
RCS
Re: [Lame-dev] New lame upstream release?
On Wed, Jul 27, 2011 at 23:48:26 (CEST), Andres Mejia wrote: Andres, may I suggest that instead of placing patches inline in debian/lame-get-orig-source.sh, we create an 'upstream-dfsg' branch, do modifications there directly and roll tarballs from that? I suppose this can be done, though once all licensing related problems are resolved upstream, there would be little use for this branch. I created the script to be (hopefully) a one time fix for the last stable release of lame. Yes, I didn't mean to imply to maintain that branch indefinitely, but only until all changes have been merged upstream. Ideally this happens before the next upstream release, but as we have learned, we cannot expect this to happen (really) soon from now. Until then, it will be easier for lame upstream to review your/our changes in the gitweb on git.debian.org and incorporate them in the upstream CVS repository. -- Gruesse/greetings, Reinhard Tartler, KeyID 945348A4 ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
Hi, Andres.
On Jul 25 2011, Andres Mejia wrote:
I'm curious to know if there will be another release of lame soon. I
ask since it seems with some recent activity in Debian, lame will
finally be allowed to be distributed in Debian.
Gee, I just saw that x264 entered and that xvid is getting in. :-) That's so
darned good. I wish that I were at this year's debconf...
Regarding a release, the best thing would, perhaps, to backport a few select
patches to the version 3.98.4, as the code is entering a beta phase and we
have not done much coordination---well, actually, Robert already tagged a
3.99b0 release, but he said not so much ago that we would be on vacation...
For the record, I am maintaining a git mirror of the CVS repository at:
https://github.com/rbrito/lame/tree/origin
For some weird reason when I converted the repository with git cvsimport,
the right branch where everything is happening is the branch `origin`.
Don't use `master`.
Also, could this patch be committed for the next release? It would
leave no doubt that lame is licensed under LGPL-2.
The patch came word-wraped (perhaps that's SF mailing list software?), but I
fixed it and then applied. See commit e8e86c0d.
Thanks.
--
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
On Jul 26, 2011 10:24 AM, Rogério Brito rbr...@ime.usp.br wrote:
Hi, Andres.
On Jul 26 2011, Andres Mejia wrote:
On Mon, Jul 25, 2011 at 9:59 PM, Andres Mejia mcita...@gmail.com
wrote:
x264 which was in a similar situation as lame was just accepted into
Debian.
http://lists.debian.org/debian-devel-changes/2011/07/msg02178.html
Did you receive my email from a few minutes ago regarding the patch?
We're just waiting for a new release of lame with all the license
clarification changes before uploading lame to Debian. :-)
I don't think that we will be able to release anything in time for
DebConf,
as LAME is just beginning to get into the beta stage.
My advice would be to just grab the latest stable release, backport
whatever
patches would be useful and just upload that to the archive.
BTW, if you have other patches, please don't forget to forward them to me.
Regards,
--
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFC
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
Ok thanks. I'll get to this tonight.
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
On Jul 26, 2011 12:49 PM, robert robert.hegem...@gmx.de wrote: Hi Rogério. Am 26.07.2011, 16:24 Uhr, schrieb Rogério Brito rbr...@ime.usp.br: We're just waiting for a new release of lame with all the license clarification changes before uploading lame to Debian. :-) I don't think that we will be able to release anything in time for DebConf, as LAME is just beginning to get into the beta stage. What time frame are we talking about? From my point of view, there may be some small patches to apply and then release 3.99: 1 - pending LGPL patch 2 - eventually changing default behaviour for ID3v2 unicode tags. What do the others think? Ciao Robert I was simply going to backport the lgpl patches and upload the last release. I suppose there's no need to wait for a new release now. On Jul 26, 2011 12:49 PM, robert robert.hegem...@gmx.de wrote: Hi Rogério. Am 26.07.2011, 16:24 Uhr, schrieb Rogério Brito rbr...@ime.usp.br: We're just waiting for a new release of lame with all the license clarification changes before uploading lame to Debian. :-) I don't think that we will be able to release anything in time for DebConf, as LAME is just beginning to get into the beta stage. What time frame are we talking about? From my point of view, there may be some small patches to apply and then release 3.99: 1 - pending LGPL patch 2 - eventually changing default behaviour for ID3v2 unicode tags. What do the others think? Ciao Robert ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [Lame-dev] New lame upstream release?
Hi Rogério. Am 26.07.2011, 16:24 Uhr, schrieb Rogério Brito rbr...@ime.usp.br: We're just waiting for a new release of lame with all the license clarification changes before uploading lame to Debian. :-) I don't think that we will be able to release anything in time for DebConf, as LAME is just beginning to get into the beta stage. What time frame are we talking about? From my point of view, there may be some small patches to apply and then release 3.99: 1 - pending LGPL patch 2 - eventually changing default behaviour for ID3v2 unicode tags. What do the others think? Ciao Robert ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
