Re: [SCM] libdvdcss/master: Update changelog.
On Sat, Mar 17, 2012 at 2:37 PM, wrote: > The following commit has been merged in the master branch: > commit 15c3fdd600ad05440cfc3b9016897c523de68c0d > Author: Andres Mejia > Date: Sat Mar 17 14:36:37 2012 -0400 > > Update changelog. > > diff --git a/debian/changelog b/debian/changelog > index 2fbd94f..b93d409 100644 > --- a/debian/changelog > +++ b/debian/changelog > @@ -5,8 +5,10 @@ libdvdcss (1.2.12-2) UNRELEASED; urgency=low > * Add myself to Uploaders field. > * Bump to Standards-Version 3.9.3. > * Make dev package multiarch installable installable. > + * Ignore package-needs-versioned-debhelper-build-depends 9 lintian warning. > + * Support parallel builds. > > - -- Andres Mejia Sat, 17 Mar 2012 14:29:56 -0400 > + -- Andres Mejia Sat, 17 Mar 2012 14:36:21 -0400 > > libdvdcss (1.2.12-1) unstable; urgency=low > > > -- > libdvdcss packaging > > ___ > pkg-multimedia-commits mailing list > pkg-multimedia-comm...@lists.alioth.debian.org > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-commits About these latest changes, I removed the build dependency on dh-autoreconf because a) it wasn't necessary, and b) because if we are to provide some install-css.sh script, it would be better if libdvdcss had as few build dependencies as possible. With this it only has two, debhelper (>= 8.1.3~) and build-essential of course. That pretty much means libdvdcss can be compiled on Debian down to old-stable (if backports is used) and Ubuntu oneiric. For supporting Ubuntu suites before oneiric, we could use a seperate branch and modify the install-css.sh script accordingly. -- ~ Andres ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] libdvdcss/master: Update changelog.
> About these latest changes, I removed the build dependency on > dh-autoreconf because a) it wasn't necessary, and b) because if we are It is, because we add libdvdcss_la_CFLAGS = -fvisibility=hidden in src/Makefile.am through debian/patches/symbol-visibility.patch. Please get this right again. The flag could get added globally to CFLAGS in debian/rules, for example. - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] libdvdcss/master: Update changelog.
On Sun, Mar 18, 2012 at 5:35 AM, Fabian Greffrath wrote:
>
>> About these latest changes, I removed the build dependency on
>> dh-autoreconf because a) it wasn't necessary, and b) because if we are
>
> It is, because we add
> libdvdcss_la_CFLAGS = -fvisibility=hidden
> in src/Makefile.am
> through debian/patches/symbol-visibility.patch.
>
> Please get this right again. The flag could get added globally to CFLAGS
> in debian/rules, for example.
>
> - Fabian
>
Ok, done.
About your patch, you could do the same for private symbols with a
#define, thus your change doesn't have to be gcc specific. For
example.
#if defined(__GNUC__) && __GNUC__ >= 4
#define LIBDVDCSS_PRIVATE __attribute__((visibility("hidden")))
#else
#define LIBDVDCSS_PRIVATE
#endif
And prepend all private symbols with LIBDVDCSS_PRIVATE.
--
~ Andres
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] libdvdcss/master: Update changelog.
On 12-03-17 at 02:49pm, Andres Mejia wrote: > That pretty much means libdvdcss can be compiled on Debian down to > old-stable (if backports is used) and Ubuntu oneiric. For supporting > Ubuntu suites before oneiric, we could use a seperate branch and > modify the install-css.sh script accordingly. backports.debian.org is a *specific* add-on branch. Relying in backports.d.o really means that the package does *not* support backporting to oldstable+backports (not plain oldstable). Some (myself included) choose to locally backport _instead_ of mixing with backports.d.o. The package can be made to truly support backporting to pure oldstable using CDBS. I'd be happy to do that (or guide on how to do it), if that is of any interest. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] libdvdcss/master: Update changelog.
On Sun, Mar 18, 2012 at 12:09 PM, Jonas Smedegaard wrote: > On 12-03-17 at 02:49pm, Andres Mejia wrote: >> That pretty much means libdvdcss can be compiled on Debian down to >> old-stable (if backports is used) and Ubuntu oneiric. For supporting >> Ubuntu suites before oneiric, we could use a seperate branch and >> modify the install-css.sh script accordingly. > > backports.debian.org is a *specific* add-on branch. Relying in > backports.d.o really means that the package does *not* support > backporting to oldstable+backports (not plain oldstable). Some (myself > included) choose to locally backport _instead_ of mixing with > backports.d.o. > > The package can be made to truly support backporting to pure oldstable > using CDBS. I'd be happy to do that (or guide on how to do it), if that > is of any interest. > > > - Jonas > > -- > * Jonas Smedegaard - idealist & Internet-arkitekt > * Tlf.: +45 40843136 Website: http://dr.jones.dk/ > > [x] quote me freely [ ] ask before reusing [ ] keep private > > ___ > pkg-multimedia-maintainers mailing list > pkg-multimedia-maintainers@lists.alioth.debian.org > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers That's ok, was going to mention this will only work down to stable+backports and Ubuntu oneiric. I changed to debhelper (>= 8.1.3~) to support multiarch. Should oldstable be supported? -- ~ Andres ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] libdvdcss/master: Update changelog.
On 12-03-18 at 12:22pm, Andres Mejia wrote: > On Sun, Mar 18, 2012 at 12:09 PM, Jonas Smedegaard > wrote: > > On 12-03-17 at 02:49pm, Andres Mejia wrote: > >> That pretty much means libdvdcss can be compiled on Debian down to > >> old-stable (if backports is used) and Ubuntu oneiric. For > >> supporting Ubuntu suites before oneiric, we could use a seperate > >> branch and modify the install-css.sh script accordingly. > > > > backports.debian.org is a *specific* add-on branch. Relying in > > backports.d.o really means that the package does *not* support > > backporting to oldstable+backports (not plain oldstable). Some > > (myself included) choose to locally backport _instead_ of mixing > > with backports.d.o. > > > > The package can be made to truly support backporting to pure > > oldstable using CDBS. I'd be happy to do that (or guide on how to > > do it), if that is of any interest. [snip] > That's ok, was going to mention this will only work down to > stable+backports and Ubuntu oneiric. I changed to debhelper (>= > 8.1.3~) to support multiarch. Should oldstable be supported? You answer a question with a question :-) When you initially wrote "that's ok" above, did you then mean a) it is ok with me that the packaging be "infected" with CDBS to improve backportability? Or did you instead mean that b) it is ok that the packaging is "infected" with short-form dh even though limiting backportability to stable+backports, oldstable+backports and similar. Packaging can support *both* multiarch *and* backportability to pure oldstable. I do recognize, however, that the use of CDBS is considered controversial by some, hence my asking instead of just doing it. - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] libdvdcss/master: Update changelog.
On Sun, Mar 18, 2012 at 12:43 PM, Jonas Smedegaard wrote: > On 12-03-18 at 12:22pm, Andres Mejia wrote: >> On Sun, Mar 18, 2012 at 12:09 PM, Jonas Smedegaard >> wrote: >> > On 12-03-17 at 02:49pm, Andres Mejia wrote: >> >> That pretty much means libdvdcss can be compiled on Debian down to >> >> old-stable (if backports is used) and Ubuntu oneiric. For >> >> supporting Ubuntu suites before oneiric, we could use a seperate >> >> branch and modify the install-css.sh script accordingly. >> > >> > backports.debian.org is a *specific* add-on branch. Relying in >> > backports.d.o really means that the package does *not* support >> > backporting to oldstable+backports (not plain oldstable). Some >> > (myself included) choose to locally backport _instead_ of mixing >> > with backports.d.o. >> > >> > The package can be made to truly support backporting to pure >> > oldstable using CDBS. I'd be happy to do that (or guide on how to >> > do it), if that is of any interest. > > [snip] > >> That's ok, was going to mention this will only work down to >> stable+backports and Ubuntu oneiric. I changed to debhelper (>= >> 8.1.3~) to support multiarch. Should oldstable be supported? > > You answer a question with a question :-) > > When you initially wrote "that's ok" above, did you then mean a) it is > ok with me that the packaging be "infected" with CDBS to improve > backportability? > > Or did you instead mean that b) it is ok that the packaging is > "infected" with short-form dh even though limiting backportability to > stable+backports, oldstable+backports and similar. > > > Packaging can support *both* multiarch *and* backportability to pure > oldstable. I do recognize, however, that the use of CDBS is considered > controversial by some, hence my asking instead of just doing it. > > > - Jonas > > -- > * Jonas Smedegaard - idealist & Internet-arkitekt > * Tlf.: +45 40843136 Website: http://dr.jones.dk/ > > [x] quote me freely [ ] ask before reusing [ ] keep private > > ___ > pkg-multimedia-maintainers mailing list > pkg-multimedia-maintainers@lists.alioth.debian.org > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers I meant that's ok, you don't have to convert libdvdcss to cdbs. I want to keep libdvdcss build dependencies as minimal as possible, hence why dh-autoreconf was removed. The reason to keep them minimal is because the installer script builds the package on the user's system. Thus the installer would only need debhelper (>= 8.1.3~), wget to get a snapshot of the git repository, apt for apt-get, and build-essential in order to build libdvdcss. -- ~ Andres ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] libdvdcss/master: Update changelog.
Am 18.03.2012 15:26, schrieb Andres Mejia: And prepend all private symbols with LIBDVDCSS_PRIVATE. Yes, sure, but that's tedious. I'd prefer to say "they are all private symbols, except for this and that one." ;) - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] libdvdcss/master: Update changelog.
Am 18.03.2012 17:43, schrieb Jonas Smedegaard: Packaging can support *both* multiarch *and* backportability to pure oldstable. I do recognize, however, that the use of CDBS is considered controversial by some, hence my asking instead of just doing it. Me included, so please resist the urge. ;) - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] libdvdcss/master: Update changelog.
Am 18.03.2012 17:22, schrieb Andres Mejia: 8.1.3~) to support multiarch. Should oldstable be supported? IMHO not, It has been EOL'ed a few weeks ago and, honestly, who is still watching DVDs with oldstable and hasn't found a proper solution until today? ;) - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] libdvdcss/master: Update changelog.
On 12-03-19 at 10:14am, Fabian Greffrath wrote: > Am 18.03.2012 17:22, schrieb Andres Mejia: > >8.1.3~) to support multiarch. Should oldstable be supported? > > IMHO not, It has been EOL'ed a few weeks ago and, honestly, who is > still watching DVDs with oldstable and hasn't found a proper solution > until today? ;) Should stable be supported? - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ [x] quote me freely [ ] ask before reusing [ ] keep private signature.asc Description: Digital signature ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] libdvdcss/master: Update changelog.
Am 19.03.2012 13:53, schrieb Jonas Smedegaard: Should stable be supported? I think so, but not necessarily without minor changes to the packaging. A package with minor adaption on backports.d.o would be sufficient IMHO. We should concentrate on unstable as our main development platform. - Fabian ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
Re: [SCM] libdvdcss/master: Update changelog.
On Mon, Mar 19, 2012 at 9:03 AM, Fabian Greffrath wrote: > Am 19.03.2012 13:53, schrieb Jonas Smedegaard: >> >> Should stable be supported? > > > I think so, but not necessarily without minor changes to the packaging. A > package with minor adaption on backports.d.o would be sufficient IMHO. We > should concentrate on unstable as our main development platform. > > > - Fabian I believe stable should definitely be supported. -- ~ Andres ___ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
