Re: flumotion (ITA)

2012-03-07 Thread Jonas Smedegaard
On 12-03-07 at 12:41pm, IOhannes m zmoelnig wrote:
> On 2012-03-07 10:54, Loïc Minier wrote:
>> if you find the CDBS documentation, please tell me so i can check 
>> myself...
> the only documentation i know of lives in denmark and expressed 
> willingness to "have a look" :-)

Ouch! :-D

I apologize that my girlfriend came home early last night, so I did not 
get the quality time alone with my laptop as expected :-P

I'll hopefully make up for it tonight!


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: Digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: flumotion (ITA)

2012-03-07 Thread Loïc Minier
On Wed, Mar 07, 2012, IOhannes m zmoelnig wrote:
> now update-rc.d doesn't restart anything.

 Oh right, it's just update-rc.d that you changed; nevermind

> if you find the CDBS documentation, please tell me so i can check
> myself... the only documentation i know of lives in denmark and
> expressed willingness to "have a look" :-)

 haha -- yeah, CDBS doc is best accessed with `rgrep /usr/share/cdbs`
 :-)

-- 
Loïc Minier

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers


Re: flumotion (ITA)

2012-03-07 Thread Fabian Greffrath

Am 07.03.2012 12:41, schrieb IOhannes m zmoelnig:

if you find the CDBS documentation, please tell me so i can check
myself... the only documentation i know of lives in denmark and
expressed willingness to "have a look" :-)


Not perfectly up-to-date, but a beginning:
http://cdbs-doc.duckcorp.org/

Also, there is a doc/ directory in the cdbs sources in which you can 
run "make". ;)


___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers


Re: flumotion (ITA)

2012-03-07 Thread IOhannes m zmoelnig
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

salut!

On 2012-03-07 10:54, Loïc Minier wrote:
>  I've had a look at the changes; thanks for moving to latest packaging

thanks for reviewing!

>  standards (3.0 (quilt), git-bp, pycompat and such) and thanks for
>  adding the history of uploads by importing the .dsc files.
> 
>  I checked your new changes, and most seem good, concerning:
> 4fe1e976fd8b49ff2511f7170a13d5ff6de6d2ac
> update-rc.d is automagically called by dh_installinit
> 
>  IIRC, the byte-compilation was happening by some stanza inserted in
>  #DEBHELPER# back then, and it was good to restart flumotion after the
>  byte-compilation had taken place.  Otherwise, dh_installinit might
>  insert the restart snippet before or after byte-compilation, but not
>  consistenly restart flumotion after byte-compilation.  Nowadays, I'm
>  not sure how to ensure that the daemon is started with the .py files
>  already byte-compiled.


afaics, there is no problem.

the original code was something like:

 DH_MAGIC
 call update-rc.d
 restart the init.d script


this got me lintian _errors_ due to duplicate calls of update-rc.d.
close inspection of final postinst script revealed, that DH_MAGIC adds
an update-rc.d stanza and starts byte-compilation, so we get:

 call update-rc.d
 do byte-compilation
 call update-rc.d
 restart the init.d script


now update-rc.d doesn't restart anything.
it only makes sure that the init.d script is called at various runlevels
(or however this is called nowadays)

therefore, removing the 2nd call to update-rc.d is not harmful, esp.
since the code that restarts flumotion after byte-compilation is still
there.

>  The other packaging changes also relate to packaging style, and made
>  sense in my reading, but I didn't check every single change against the
>  CDBS documentation or such.

if you find the CDBS documentation, please tell me so i can check
myself... the only documentation i know of lives in denmark and
expressed willingness to "have a look" :-)


fgasmdr
IOhannes
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk9XSUsACgkQkX2Xpv6ydvRo0wCeMLaeO9J/BvnVH3Yq/1/HOzzA
I3wAoJVaCwvnqQf8lLSn/tsNZLlm2tzy
=LZRZ
-END PGP SIGNATURE-



smime.p7s
Description: S/MIME Cryptographic Signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Re: flumotion (ITA)

2012-03-07 Thread Loïc Minier
Hey,

On Tue, Mar 06, 2012, forum::für::umläute wrote:
> the "flumotion" package has been in a bad state for some years now.
> i talked with it's current maintainer (CC: Loïc Minier) at IRC and he
> said he would not spend much more time on this package, and would be ok,
> if i adapted the package.

 yeah; thanks a lot for stepping up to take it!

>   git+ssh://git.debian.org/git/pkg-multimedia/flumotion

 I've had a look at the changes; thanks for moving to latest packaging
 standards (3.0 (quilt), git-bp, pycompat and such) and thanks for
 adding the history of uploads by importing the .dsc files.

 I checked your new changes, and most seem good, concerning:
4fe1e976fd8b49ff2511f7170a13d5ff6de6d2ac
update-rc.d is automagically called by dh_installinit

 IIRC, the byte-compilation was happening by some stanza inserted in
 #DEBHELPER# back then, and it was good to restart flumotion after the
 byte-compilation had taken place.  Otherwise, dh_installinit might
 insert the restart snippet before or after byte-compilation, but not
 consistenly restart flumotion after byte-compilation.  Nowadays, I'm
 not sure how to ensure that the daemon is started with the .py files
 already byte-compiled.

 The other packaging changes also relate to packaging style, and made
 sense in my reading, but I didn't check every single change against the
 CDBS documentation or such.

> PS: the package has not gone through a regular orphanage/ITA cycle. is
> this necessary?

 Nope; I wont complain  :-)

   Thanks!
-- 
Loïc Minier

___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers


Re: flumotion (ITA)

2012-03-06 Thread Jonas Smedegaard
On 12-03-06 at 12:50pm, forum::für::umläute wrote:
> the "flumotion" package has been in a bad state for some years now. i 
> talked with it's current maintainer (CC: Loïc Minier) at IRC and he 
> said he would not spend much more time on this package, and would be 
> ok, if i adapted the package.
> 
> given the nature of fluotion ("Fluendo Streaming Server - manager, 
> worker and admin"), i'd rather do this under the hood of 
> pkg-multimedia-maintainers.
> i hope this is ok with all of you (if not, i can move the package-git 
> to collab-maint)

Great!  I'd be happy to help maintain it.


> so far i have imported the packaging history into a new git, and
> imported the latest upstream release.
> i upgraded - to the best of my knowledge - the cdbs buildsystem, 
> converted the copyright to DEP-5 and whatnot (for details see 
> debian/changelog)
> 
> it's all pushed to:
>   git+ssh://git.debian.org/git/pkg-multimedia/flumotion
> 
> if somebody would like to have a look and/or upload, i'd be greatful.

I'll have a look at it later today...!


> PS: the package has not gone through a regular orphanage/ITA cycle. is 
> this necessary?

No need.  The important part is that the former maintainer is ok with 
the handover.


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: Digital signature
___
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers