Re: Review Request: Add support for KUrl config values in javascript
On 2009-04-01 11:48:20, Aaron Seigo wrote: /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/simplejavascriptapplet.h, line 52 http://reviewboard.kde.org/r/496/diff/1/?file=4641#file4641line52 maybe a good opportunity to get rid of the '2' in the name and just make it variantToScriptValue everywhere. renamed to variantToScriptValue On 2009-04-01 11:48:20, Aaron Seigo wrote: /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/simplejavascriptapplet.cpp, line 113 http://reviewboard.kde.org/r/496/diff/1/?file=4642#file4642line113 how about QUrl too? Added QUrl and QColor On 2009-04-01 11:48:20, Aaron Seigo wrote: /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/simplejavascriptapplet.cpp, line 757 http://reviewboard.kde.org/r/496/diff/1/?file=4642#file4642line757 this could just become a (static?) member of the class instead of having a member method that calls a file global function? AppletInterface needs non static and other global functions need static/global version. - Petri --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/496/#review777 --- On 2009-04-01 06:51:44, Petri Damstén wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/496/ --- (Updated 2009-04-01 06:51:44) Review request for Plasma. Summary --- Add support for KUrl config values. Needed e.g. if ui file has KUrlRequester. Diffs - /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/appletinterface.h 947782 /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/appletinterface.cpp 947782 /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/simplejavascriptapplet.h 947782 /trunk/KDE/kdebase/workspace/plasma/scriptengines/javascript/simplejavascriptapplet.cpp 947782 Diff: http://reviewboard.kde.org/r/496/diff Testing --- Thanks, Petri ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasma Notes bug and wish
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/417/ --- (Updated 2009-04-01 06:08:43.243577) Review request for Plasma. Changes --- Here it is the last changes I had to make. Now everything seems good. Summary --- I made changes that were whished by the refered bug I just need to send the patch to someone how can commit because I change a .svgz file to add the transparency. Thanks This addresses bug 179170. https://bugs.kde.org/show_bug.cgi?id=179170 Diffs (updated) - trunk/KDE/kdeplasma-addons/applets/notes/notes.h 947761 trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 947761 Diff: http://reviewboard.kde.org/r/417/diff Testing --- Screenshots --- Visuals of corrections http://reviewboard.kde.org/r/417/s/74/ Thanks, Maxime ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: April 7 soft feature freeze
On Wednesday 01 April 2009 01:29:48 Aaron J. Seigo wrote: hi all just a quick reminding there April 7 is the soft feature freeze for 4.3. that means that a feature must at least be on the feature plan, and best is if they are at least started in svn. If geoclue has too much dependencies for plasma should I then move geolocation dataengine to kdereview. It currently supports gpsd and hostip.info and I use it in lcd weather widget to get initial place. Should it support something else before kdereview? Petri signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: April 7 soft feature freeze
On Thursday 02 April 2009, Petri Damstén wrote: On Wednesday 01 April 2009 01:29:48 Aaron J. Seigo wrote: hi all just a quick reminding there April 7 is the soft feature freeze for 4.3. that means that a feature must at least be on the feature plan, and best is if they are at least started in svn. If geoclue has too much dependencies for plasma should I then move geolocation dataengine to kdereview. It currently supports gpsd and hostip.info and I use it in lcd weather widget to get initial place. Should it support something else before kdereview? no, that's a good start. :)) please move it on over... -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
geolocation dataengine moved to kdereview
Hi, geolocation dataengine is now in kdereview. Petri signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [GSoC] (One more) Proposal for Plasmate
Hi its me again :P I updated my proposal based on feedback and it is now nearly finalized. Main updates include moving widget previewing to 'compulsory milestones' and updating my mockups as Aaron suggested (including getting rid of the terminal :P). I have the draft up on the GSoC site as requested here : http://socghop.appspot.com/student_proposal/show/google/gsoc2009/moofang/t123854512734 Also available @ googledocs here : http://docs.google.com/Doc?id=dvjmcm4_16hjv6txcf If anyone has any final comments for me please shout! Thanks a bunch for all the feedback so far :) On 4/1/09, Yuen Hoe Lim yuenho...@gmail.com wrote: we already have a previewer started in playground; showing a plasmoid in a little window by itself is a tiny amount of code, really. :) don't need to; we know where the code is on disk, and you can just pass that path directly to the Package which would then be used by the Applet object to run the widget. Evidently I have yet much to learn about the platform and available code :) * if the user needs an embedded terminal to make plasmate useful, something's horribly wrong :) it's all based on managing the contents of a Package and that's all automated / automatable So happened that when I was telling a friend about Plasmate he exclaimed 'What, no terminal!?' :P I agree completely that Plasmate should not need to rely on the terminal emulator at all, but I was just thinking that it might be handy (I use Kate's terminal for all kinds of things). Hmmm, then again Plasmate will probably be maintaining the 'project files' somewhere out of sight so maybe its not such a good idea to let the user have terminal access to that location after all. * for the diff viewer, we could probably use the kdiff kpart that comes with kde if it's available on the system (otherwise just show it in a plain text editor, i suppose) Yeah, was thinking the same thing. Wonder how much work will it be though to manually produce one from a text diff file. Since it doesn't need to be editable, the hardest part would probably be parsing the diff file Thanks a lot for the comments by the way :) Will have them addressed before the deadline this friday . *fingers crossed* Lim Yuen Hoe http://yuenhoe.co.cc/ -- Lim Yuen Hoe http://yuenhoe.co.cc/ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Google Summer of Code 2009 : D-Bus Interface Project
Hello, my name is Thomas Dziedzic. I am attending UIUC www.uiuc.edu and I am a sophomore majoring in Computer Science. I'm interested in the following project: http://techbase.kde.org/index.php?title=Projects/Summer_of_Code/2009/Ideas#Project:_D-Bus_Interface I really like this idea because adding a D-Bus interface to the plasma-desktop would really make the desktop more flexible and open up more possibilities for the desktop. I would really like to work on this but I was wondering if there was anyone willing to mentor me. I would love to contribute to the KDE project in a way that would give it one more feature to make it more appealing. Sorry if this is a little late, but I had tests this week. Anyways I am working on my proposal and if anyone wants to take a look at it, I'll be happy to post it up for you, since I'm not done at the moment. -Thomas Dziedzic ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: GSoC: Educational layout (revised)
On Wednesday 01 April 2009, lauri wrote: Hi, I am trying to take part of GSoC with Educational layout project. I have put my revised proposal here: http://v6sa.itcollege.ee/GSoC/2009/educational_layout.html i like the project very much, but i wondoer if it could be a problem the fact that many parts of it are kinda overlapping, or at least very dependent from other soc projects, like the blackboard-network transparency the buddy list - telepathy integration and we have also a dock with some more capabilities that said i hope it can make it eh :) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: kde 4.3 wallpaper extravaganza?
On Thursday 02 April 2009 11:28:34 you wrote: Hi Sascha, awesome and thanks for taking over! What do you plan to change for 4.3? I'm only aware of minor annoyances such as opening the configure wallpapers dialog resetting the zoom and position. Not much, I think fixing all remaining bugs is enough for know, it can still be feature-extended later on. Greetings, Frederik On Thursday 02 April 2009 11:19:53 Sascha Peilicke wrote: On Thursday 02 April 2009 05:36:49 you wrote: hello everyone ... we have no fewer than SIX cool wallpapers sitting in playground right now: mandelbrot marble pattern qedje virus weather you know which of those you are responsible for. ;) i'd like to see as many of the as reasonable migrate into kdeplasma-addons for 4.3; if you agree, please respond letting me know and i'll move it on in or conversely you can do it yourself. i also see that there is quite a bit of code duplication happening right now between the image file based ones. i'll try and sort that out by making Plasma::Wallpaper a little less skeletal :) Hi, I'm currently responsible for the marble wallpaper, it's mostly done, only minor bugs here and there, Altough I haven't touched it for a while (due to too infrequent web access), I'll move it by myself then. -- Sascha Peilicke http://saschpe.wordpress.com signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Summer of Code [Desktop Dock]
On Thu, Apr 2, 2009 at 2:56 AM, plasma-devel-requ...@kde.org wrote: Message: 1 Date: Wed, 1 Apr 2009 18:01:13 -0600 From: Aaron J. Seigo ase...@kde.org Subject: Re: Summer Of Code [Desktop Dock] To: plasma-devel@kde.org Message-ID: 200904011801.17152.ase...@kde.org Content-Type: text/plain; charset=us-ascii On Wednesday 01 April 2009, Alexander Shenoy wrote: Hello, My name is Alexander Shenoy. I am a student at the University of Pittsburgh at Bradford and I was considering a summer of code project. I have also been looking for a way to contribute to the KDE community. I was wondering if there had been any proposals submitted for the Desktop Dock Plasmoid idea. This project really interests me and would give me the opportunity to contribute to the KDE community. I am preparing a propasal right now, but great :) :) I wanted to contact the plasma team to see if there was any other information that I should be aware of. just that we have a *lot* of people applying this year for plasma work apparently. so proposals will need to really shine and stand out content-wise this year, i think. Thanks for the info. :) I have long wanted a dock for the KDE desktop. Also, I have some interesting ideas about the dock. One of the things about the Mac Dock that has always annoyed me was the thumbnail when minimizing windows. The thumbnail looks out of place when side by side with beautiful icons. Instead, I propose to use Present Windows to show the windows in that application on a hover of the icon within the dock. sounds interesting ... Interesting, bad? I was thinking that it would be probably the hardest part of my proposal. Especially because it wont be as simple as just invoking the Present Windows effect. The main problem is that Present Windows clears panels and takes focus. For this to work the Dock would need to retain focus so that switching between applications would enable the effect for the new application. The way I wanted to handle this for people who don't have effects enabled was a pop up menu with window title names or thumbnails. The primary motivation for my thinking is that the user should be able to look once and get to what they need. I also thought of having a small area on the right of the dock that would allow users to use keyboard inputs to launch applications and find documents. The basic idea is that you would click this and the dock becomes a search tool. Then the user can type in a phrase and get search results in a pop up(or drop-down) menu and applications in the dock. While this idea might be beyond the scope of the Google Summer of Code, I believe that it would improve usability substantially as far as the Dock is concerned. we already have such a plasmoid in playground so i don't think it would be much work to integrate it nicely ;) Great! To elaborate on my original idea(or the way I saw it in my head), when you enter text in the search box, the icons on the dock are replaced with icons that match the search criteria. and the pop-menu would contain documents that meet the search criteria. This allows users to launch any application from the Dock. Although there could be an option that just adds the search criteria programs to the dock and then removes them after one is launched. That way, the user could decide which functionality they liked best. This is also a project that I would be interested in working on even past my summer of code obligations, should I get accepted. :) I have been looking for a KDE project to sink my teeth into and this is a great opportunity. Anyone have any questions or comments before I make my final proposal please put your proposal up sooner rather than later. you can still edit it until the 3rd after you submit it, but google is wanting students to put their draft proposals online ASAP Already done. Continuing to edit though, especially trying to work out milestone dates. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 197 bytes Desc: This is a digitally signed message part. Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090401/8caa88e2/attachment-0001.sig -- ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Google Summer of Code 2009 : D-Bus Interface Project
Hi and welcome to plasma and KDE =) On Thursday 02 April 2009 05:54:31 tdzie...@illinois.edu wrote: Sorry if this is a little late, but I had tests this week. Anyways I am working on my proposal and if anyone wants to take a look at it, I'll be happy to post it up for you, since I'm not done at the moment. -Thomas Dziedzic Please, submit your proposal to google's website and you can keep editing it there until the 3rd (tomorrow). Then just send the link to us and we can help you with some feedback... Cheers! -- Artur Duque de Souza OpenBossa Research Labs INdT - Instituto Nokia de Tecnologia -- Blog: http://labs.morpheuz.eng.br/blog/ GPG: 0xDBEEAAC3 @ wwwkeys.pgp.net -- signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Systemtray benchmarks
On Thursday 02 April 2009, Marco Martin wrote: agreed. it's guaranteed to be usable by everyone, even weirdos without png support ;) , and looks faster. so +1 for that. to be really portable is enough as is now that assumes argb32 images or an overcomplication like galago? assuming 32 bbp images in argb format is safe. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add keyboard navigation to plasma applet Folder View
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/ --- (Updated 2009-04-02 08:55:49.469863) Review request for Plasma. Changes --- Provided support for keyboard navigation even if the user has made the view unsorted. Please try it out and report any issues that you may encounter. I've tried to adhere with the kdelibs coding style, hope its all right. :) Summary --- This partly addresses the above bug, adding keyboard navigation and launch using Enter key. Please report if the code is too complex, I've tried my best to keep it to the point. This addresses bug 187241. https://bugs.kde.org/show_bug.cgi?id=187241 Diffs (updated) - /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 947761 /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 947761 Diff: http://reviewboard.kde.org/r/368/diff Testing --- Tested on latest SVN build. Navigation and launch work fine. The problem is with movement of the scrollbar with the keyboard focus, the scrollbar refuses to go to minimum value when m_scrollBar-setValue( m_scrollBar-minimum() ); is used. What am I doing wrong? Thanks, Shantanu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/441/ --- (Updated 2009-04-02 09:33:32.533793) Review request for Plasma. Changes --- Have a look at this diff :) Summary --- As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia section he/she can see Audio Player - Amarok. But he requested it to be in other way Amarok - Audio Player. Hence as an initial step he asked me to add a check box similar to Switch tabs on hover. I had added a check box for this. I am a newbie in KDE. Hence would like to know what next should I do to accomplish the task. Diffs (updated) - /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244 Diff: http://reviewboard.kde.org/r/441/diff Testing --- I had compiled the above patch in my build directory. It compiled without any errors. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add keyboard navigation to plasma applet Folder View
On 2009-03-20 14:07:32, Fredrik Höglund wrote:
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1208
http://reviewboard.kde.org/r/368/diff/2/?file=3392#file3392line1208
A problem with the way this function is implemented is that it assumes
that the view is always sorted and that the icons always flow from left to
right.
When the user has rearranged the icons (m_layoutBroken is true), you
have to assume that the icons are no longer arranged in a grid and that the
visual order no longer matches the order in the model.
When this is the case, and the user has pressed the up key for example,
you have to iterate over all the icons and find the one that is closest to
the current icon while still being above it.
wrote:
you have to iterate over all the icons. I'm working on this by
iterating all icons and finding the nearest one to the current selection
according to the key pressed, but the code is getting really complex in terms
of calculations. I was wondering if there is any other way of doing this? If
anyone has an idea, please let me know. Till then I'm working on it.
wrote:
I would do something like this (the example is for the up key only):
QModelIndex nextIndex = QModelIndex();
QPoint currentPos = visualRect(currentIndex).center();
int lastDistance = 0;
for (int i = 0; i m_validRows; i++) {
const QModelIndex index = m_model-index(i, 0);
const QPoint pos = visualRect(index).center();
if (pos.y() currentPos.y()) {
int distance = (pos - currentPos).manhattanLength();
if (distance lastDistance || !currentIndex.isValid()) {
nextIndex = index;
lastDistance = distance;
}
}
}
If nextIndex is valid when you get here, it's the index you should move
to.
If it isn't valid there are no icons above the current icon.
Thanks for working on this feature :)
wrote:
Ok, thanks for the help, that was less complex then mine ;) Its almost
done, just a few minor issues remaining.
But, I'm unable to understand why you're using `!currentIndex.isValid()`
in if (distance lastDistance || !currentIndex.isValid()) ?
Why do we need to validate the currentIndex ?
Oh right, that should actually be nextIndex, not currentIndex.
I guess should read what I wrote more carefully before pressing publish :)
- Fredrik
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/#review541
---
On 2009-04-02 08:55:49, Shantanu Tushar Jha wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/
---
(Updated 2009-04-02 08:55:49)
Review request for Plasma.
Summary
---
This partly addresses the above bug, adding keyboard navigation and launch
using Enter key.
Please report if the code is too complex, I've tried my best to keep it to
the point.
This addresses bug 187241.
https://bugs.kde.org/show_bug.cgi?id=187241
Diffs
-
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 947761
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 947761
Diff: http://reviewboard.kde.org/r/368/diff
Testing
---
Tested on latest SVN build. Navigation and launch work fine. The problem is
with movement of the scrollbar with the keyboard focus, the scrollbar refuses
to go to minimum value when m_scrollBar-setValue( m_scrollBar-minimum() );
is used. What am I doing wrong?
Thanks,
Shantanu
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/441/#review785 --- getting closer :) /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp http://reviewboard.kde.org/r/441/#comment469 this is still calling the wrong method. it shouldn't be calling switchTabsOnHover, it should be calling d-launcher-showAppsByName(); /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp http://reviewboard.kde.org/r/441/#comment470 this will create a new ApplicationModel object, not modify the one that is actually in use already. there is an ApplicationModel object created earlier in this file; that object should be kept in a member variable (e.g. m_applicationModel) and used here. /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp http://reviewboard.kde.org/r/441/#comment471 this should be: return m_applicationModel-nameDisplayOrder() == ApplicationModel::NameBeforeDescription; /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp http://reviewboard.kde.org/r/441/#comment472 don't need this line. - Aaron On 2009-04-02 09:33:32, Sujith H wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/441/ --- (Updated 2009-04-02 09:33:32) Review request for Plasma. Summary --- As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia section he/she can see Audio Player - Amarok. But he requested it to be in other way Amarok - Audio Player. Hence as an initial step he asked me to add a check box similar to Switch tabs on hover. I had added a check box for this. I am a newbie in KDE. Hence would like to know what next should I do to accomplish the task. Diffs - /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244 Diff: http://reviewboard.kde.org/r/441/diff Testing --- I had compiled the above patch in my build directory. It compiled without any errors. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Systemtray benchmarks
On Thursday 02 April 2009, Aaron J. Seigo wrote: On Thursday 02 April 2009, Marco Martin wrote: agreed. it's guaranteed to be usable by everyone, even weirdos without png support ;) , and looks faster. so +1 for that. to be really portable is enough as is now that assumes argb32 images or an overcomplication like galago? assuming 32 bbp images in argb format is safe. ok soo, that's basically it... only thing i was thinking about was if shouldn't be the case of putting the dbus interface on another file, so removing the properties called by dbus from the public api... would be cleaner but also a quite big amount of duplication... ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Systemtray benchmarks
On Thursday 02 April 2009, Marco Martin wrote: On Thursday 02 April 2009, Aaron J. Seigo wrote: On Thursday 02 April 2009, Marco Martin wrote: agreed. it's guaranteed to be usable by everyone, even weirdos without png support ;) , and looks faster. so +1 for that. to be really portable is enough as is now that assumes argb32 images or an overcomplication like galago? assuming 32 bbp images in argb format is safe. ok soo, that's basically it... only thing i was thinking about was if shouldn't be the case of putting the dbus interface on another file, so removing the properties called by dbus from the public api... would be cleaner but also a quite big amount of duplication... for a class that we'd like to export as part of a public API, it's probably worth it. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: IconWidget DragDrop visual feedback.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/507/ --- Review request for Plasma. Summary --- Use the hover background also for the dragdrop. This addresses bug 110952. https://bugs.kde.org/show_bug.cgi?id=110952 Diffs - trunk/KDE/kdelibs/plasma/widgets/iconwidget.h 948167 trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp 948167 Diff: http://reviewboard.kde.org/r/507/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: IconWidget DragDrop visual feedback.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/507/#review788 --- Ship it! one very minor change, but then it's good to go! trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp http://reviewboard.kde.org/r/507/#comment476 this should probably be left up to the user of the IconWidget; by default, the icon widget doesn't actually do anything with drops and we don't suddenly want every icon looking like it does ;) - Aaron On 2009-04-02 10:53:58, Davide Bettio wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/507/ --- (Updated 2009-04-02 10:53:58) Review request for Plasma. Summary --- Use the hover background also for the dragdrop. This addresses bug 110952. https://bugs.kde.org/show_bug.cgi?id=110952 Diffs - trunk/KDE/kdelibs/plasma/widgets/iconwidget.h 948167 trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp 948167 Diff: http://reviewboard.kde.org/r/507/diff Testing --- Thanks, Davide ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)
On 2009-04-02 10:06:27, Aaron Seigo wrote: /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp, line 611 http://reviewboard.kde.org/r/441/diff/5/?file=4680#file4680line611 this should be: return m_applicationModel-nameDisplayOrder() == ApplicationModel::NameBeforeDescription; wrote: nameDisplayOrder()? So that means I would have to write a function nameDisplayOrder() function? yes: bool nameDisplayOrder() const; On 2009-04-02 10:06:27, Aaron Seigo wrote: /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp, line 596 http://reviewboard.kde.org/r/441/diff/5/?file=4680#file4680line596 this will create a new ApplicationModel object, not modify the one that is actually in use already. there is an ApplicationModel object created earlier in this file; that object should be kept in a member variable (e.g. m_applicationModel) and used here. wrote: There is a line ApplicationModel *applicationModel = new ApplicationModel(q); in function: void setupAllProgramsView() Ahh this would be little tricky for me (in this learning phase :)) so you found where it is, that's good. now add: ApplicationModel *applicationModel; as a member of the Launcher::Private class, so that the line becomes: applicationModel = new ApplicationModel(q); then you can access it from Launcher via d-applicationModel :) - Aaron --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/441/#review785 --- On 2009-04-02 09:33:32, Sujith H wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/441/ --- (Updated 2009-04-02 09:33:32) Review request for Plasma. Summary --- As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia section he/she can see Audio Player - Amarok. But he requested it to be in other way Amarok - Audio Player. Hence as an initial step he asked me to add a check box similar to Switch tabs on hover. I had added a check box for this. I am a newbie in KDE. Hence would like to know what next should I do to accomplish the task. Diffs - /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244 Diff: http://reviewboard.kde.org/r/441/diff Testing --- I had compiled the above patch in my build directory. It compiled without any errors. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/#review790
---
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp
http://reviewboard.kde.org/r/441/#comment480
Maybe we can have a member variable m_showAppsByName which is used inside
setupAllProgramsView() to set setNameDisplayOrder -
if(m_showAppsByName) {
applicationModel-setNameDisplayOrder(ApplicationModel::NameBeforeDescription);
} else {
applicationModel-setNameDisplayOrder(ApplicationModel::NameAfterDescription);
}
and Launcher::setShowAppsByName(bool showAppByName) just sets
m_showAppsByName = showAppByName;
and bool Launcher::showAppsByName() returns m_showAppsByName
this will be better than making applicationModel as a private member, am I
right Aaron?
- Shantanu
On 2009-04-02 09:33:32, Sujith H wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/
---
(Updated 2009-04-02 09:33:32)
Review request for Plasma.
Summary
---
As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia
section he/she can see Audio Player - Amarok. But he requested it to be in
other way Amarok - Audio Player. Hence as an initial step he asked me to
add a check box similar to Switch tabs on hover. I had added a check box
for this. I am a newbie in KDE. Hence would like to know what next should I
do to accomplish the task.
Diffs
-
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp
947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h
947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp
947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244
Diff: http://reviewboard.kde.org/r/441/diff
Testing
---
I had compiled the above patch in my build directory. It compiled without any
errors.
Thanks,
Sujith
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)
On 2009-04-02 11:55:26, Shantanu Tushar Jha wrote:
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp, lines
596-597
http://reviewboard.kde.org/r/441/diff/5/?file=4680#file4680line596
Maybe we can have a member variable m_showAppsByName which is used
inside setupAllProgramsView() to set setNameDisplayOrder -
if(m_showAppsByName) {
applicationModel-setNameDisplayOrder(ApplicationModel::NameBeforeDescription);
} else {
applicationModel-setNameDisplayOrder(ApplicationModel::NameAfterDescription);
}
and Launcher::setShowAppsByName(bool showAppByName) just sets
m_showAppsByName = showAppByName;
and bool Launcher::showAppsByName() returns m_showAppsByName
this will be better than making applicationModel as a private member,
am I right Aaron?
that won't work because the setting can be changed at runtime via the settings
dialog and after setupAllProgramsView is called, so you either need to
re-create the application model (rather wasteful) or else hang onto the pointer
to it.
- Aaron
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/#review790
---
On 2009-04-02 09:33:32, Sujith H wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/
---
(Updated 2009-04-02 09:33:32)
Review request for Plasma.
Summary
---
As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia
section he/she can see Audio Player - Amarok. But he requested it to be in
other way Amarok - Audio Player. Hence as an initial step he asked me to
add a check box similar to Switch tabs on hover. I had added a check box
for this. I am a newbie in KDE. Hence would like to know what next should I
do to accomplish the task.
Diffs
-
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp
947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h
947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp
947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244
Diff: http://reviewboard.kde.org/r/441/diff
Testing
---
I had compiled the above patch in my build directory. It compiled without any
errors.
Thanks,
Sujith
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)
On 2009-04-02 11:55:26, Shantanu Tushar Jha wrote:
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp, lines
596-597
http://reviewboard.kde.org/r/441/diff/5/?file=4680#file4680line596
Maybe we can have a member variable m_showAppsByName which is used
inside setupAllProgramsView() to set setNameDisplayOrder -
if(m_showAppsByName) {
applicationModel-setNameDisplayOrder(ApplicationModel::NameBeforeDescription);
} else {
applicationModel-setNameDisplayOrder(ApplicationModel::NameAfterDescription);
}
and Launcher::setShowAppsByName(bool showAppByName) just sets
m_showAppsByName = showAppByName;
and bool Launcher::showAppsByName() returns m_showAppsByName
this will be better than making applicationModel as a private member,
am I right Aaron?
wrote:
that won't work because the setting can be changed at runtime via the
settings dialog and after setupAllProgramsView is called, so you either need
to re-create the application model (rather wasteful) or else hang onto the
pointer to it.
ohkay, got it :)
- Shantanu
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/#review790
---
On 2009-04-02 09:33:32, Sujith H wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/
---
(Updated 2009-04-02 09:33:32)
Review request for Plasma.
Summary
---
As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia
section he/she can see Audio Player - Amarok. But he requested it to be in
other way Amarok - Audio Player. Hence as an initial step he asked me to
add a check box similar to Switch tabs on hover. I had added a check box
for this. I am a newbie in KDE. Hence would like to know what next should I
do to accomplish the task.
Diffs
-
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp
947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h
947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp
947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244
Diff: http://reviewboard.kde.org/r/441/diff
Testing
---
I had compiled the above patch in my build directory. It compiled without any
errors.
Thanks,
Sujith
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)
On 2009-04-02 10:06:27, Aaron Seigo wrote:
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp, line
611
http://reviewboard.kde.org/r/441/diff/5/?file=4680#file4680line611
this should be:
return m_applicationModel-nameDisplayOrder() ==
ApplicationModel::NameBeforeDescription;
wrote:
nameDisplayOrder()? So that means I would have to write a function
nameDisplayOrder() function?
wrote:
yes: bool nameDisplayOrder() const;
so it should be :
bool nameDisplayOrder() const
{
return ApplicationModel::NameBeforeDescription;
}
right?
- Sujith
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/#review785
---
On 2009-04-02 09:33:32, Sujith H wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/
---
(Updated 2009-04-02 09:33:32)
Review request for Plasma.
Summary
---
As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia
section he/she can see Audio Player - Amarok. But he requested it to be in
other way Amarok - Audio Player. Hence as an initial step he asked me to
add a check box similar to Switch tabs on hover. I had added a check box
for this. I am a newbie in KDE. Hence would like to know what next should I
do to accomplish the task.
Diffs
-
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp
947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h
947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp
947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244
Diff: http://reviewboard.kde.org/r/441/diff
Testing
---
I had compiled the above patch in my build directory. It compiled without any
errors.
Thanks,
Sujith
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/441/ --- (Updated 2009-04-02 12:34:04.446635) Review request for Plasma. Changes --- I hope this time its ok :) Summary --- As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia section he/she can see Audio Player - Amarok. But he requested it to be in other way Amarok - Audio Player. Hence as an initial step he asked me to add a check box similar to Switch tabs on hover. I had added a check box for this. I am a newbie in KDE. Hence would like to know what next should I do to accomplish the task. Diffs (updated) - /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244 Diff: http://reviewboard.kde.org/r/441/diff Testing --- I had compiled the above patch in my build directory. It compiled without any errors. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add keyboard navigation to plasma applet Folder View
On 2009-03-20 14:07:32, Fredrik Höglund wrote:
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1208
http://reviewboard.kde.org/r/368/diff/2/?file=3392#file3392line1208
A problem with the way this function is implemented is that it assumes
that the view is always sorted and that the icons always flow from left to
right.
When the user has rearranged the icons (m_layoutBroken is true), you
have to assume that the icons are no longer arranged in a grid and that the
visual order no longer matches the order in the model.
When this is the case, and the user has pressed the up key for example,
you have to iterate over all the icons and find the one that is closest to
the current icon while still being above it.
wrote:
you have to iterate over all the icons. I'm working on this by
iterating all icons and finding the nearest one to the current selection
according to the key pressed, but the code is getting really complex in terms
of calculations. I was wondering if there is any other way of doing this? If
anyone has an idea, please let me know. Till then I'm working on it.
wrote:
I would do something like this (the example is for the up key only):
QModelIndex nextIndex = QModelIndex();
QPoint currentPos = visualRect(currentIndex).center();
int lastDistance = 0;
for (int i = 0; i m_validRows; i++) {
const QModelIndex index = m_model-index(i, 0);
const QPoint pos = visualRect(index).center();
if (pos.y() currentPos.y()) {
int distance = (pos - currentPos).manhattanLength();
if (distance lastDistance || !currentIndex.isValid()) {
nextIndex = index;
lastDistance = distance;
}
}
}
If nextIndex is valid when you get here, it's the index you should move
to.
If it isn't valid there are no icons above the current icon.
Thanks for working on this feature :)
wrote:
Ok, thanks for the help, that was less complex then mine ;) Its almost
done, just a few minor issues remaining.
But, I'm unable to understand why you're using `!currentIndex.isValid()`
in if (distance lastDistance || !currentIndex.isValid()) ?
Why do we need to validate the currentIndex ?
wrote:
Oh right, that should actually be nextIndex, not currentIndex.
I guess should read what I wrote more carefully before pressing publish
:)
But still, why we need to validate (or, invalidate) nextIndex
`!currentIndex.isValid()` ? I tried to figure out, but failed. A little help
here :)
- Shantanu
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/#review541
---
On 2009-04-02 08:55:49, Shantanu Tushar Jha wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/
---
(Updated 2009-04-02 08:55:49)
Review request for Plasma.
Summary
---
This partly addresses the above bug, adding keyboard navigation and launch
using Enter key.
Please report if the code is too complex, I've tried my best to keep it to
the point.
This addresses bug 187241.
https://bugs.kde.org/show_bug.cgi?id=187241
Diffs
-
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 947761
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 947761
Diff: http://reviewboard.kde.org/r/368/diff
Testing
---
Tested on latest SVN build. Navigation and launch work fine. The problem is
with movement of the scrollbar with the keyboard focus, the scrollbar refuses
to go to minimum value when m_scrollBar-setValue( m_scrollBar-minimum() );
is used. What am I doing wrong?
Thanks,
Shantanu
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add keyboard navigation to plasma applet Folder View
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/ --- (Updated 2009-04-02 13:21:02.238361) Review request for Plasma. Changes --- Its ok, I figured it out why was !nextIndex.isValid() required and have updated the Diff accordingly. Please check it and see if there are any issues and if this is ok to commit ... Summary --- This partly addresses the above bug, adding keyboard navigation and launch using Enter key. Please report if the code is too complex, I've tried my best to keep it to the point. This addresses bug 187241. https://bugs.kde.org/show_bug.cgi?id=187241 Diffs (updated) - /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 948236 /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 948236 Diff: http://reviewboard.kde.org/r/368/diff Testing --- Tested on latest SVN build. Navigation and launch work fine. The problem is with movement of the scrollbar with the keyboard focus, the scrollbar refuses to go to minimum value when m_scrollBar-setValue( m_scrollBar-minimum() ); is used. What am I doing wrong? Thanks, Shantanu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add keyboard navigation to plasma applet Folder View
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/#review796 --- I think in general the code looks good, but there are still numerous coding style issues, especially with the way the code is indented. /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h http://reviewboard.kde.org/r/368/#comment486 I'd prefer it if this function was in AbstractItemView instead, since the code will work for the ListView class as well. /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp http://reviewboard.kde.org/r/368/#comment489 IconView already sets the focus policy to StrongFocus at the top of the constructor (as of today). /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp http://reviewboard.kde.org/r/368/#comment487 This could result in a division by zero. /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp http://reviewboard.kde.org/r/368/#comment488 This code still doesn't take the flow into account. The icons can flow from left to right, right to left, top to bottom and so on, as indicated by m_flow. - Fredrik On 2009-04-02 13:21:02, Shantanu Tushar Jha wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/ --- (Updated 2009-04-02 13:21:02) Review request for Plasma. Summary --- This partly addresses the above bug, adding keyboard navigation and launch using Enter key. Please report if the code is too complex, I've tried my best to keep it to the point. This addresses bug 187241. https://bugs.kde.org/show_bug.cgi?id=187241 Diffs - /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 948236 /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 948236 Diff: http://reviewboard.kde.org/r/368/diff Testing --- Tested on latest SVN build. Navigation and launch work fine. The problem is with movement of the scrollbar with the keyboard focus, the scrollbar refuses to go to minimum value when m_scrollBar-setValue( m_scrollBar-minimum() ); is used. What am I doing wrong? Thanks, Shantanu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add keyboard navigation to plasma applet Folder View
On 2009-03-20 14:07:32, Fredrik Höglund wrote:
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1208
http://reviewboard.kde.org/r/368/diff/2/?file=3392#file3392line1208
A problem with the way this function is implemented is that it assumes
that the view is always sorted and that the icons always flow from left to
right.
When the user has rearranged the icons (m_layoutBroken is true), you
have to assume that the icons are no longer arranged in a grid and that the
visual order no longer matches the order in the model.
When this is the case, and the user has pressed the up key for example,
you have to iterate over all the icons and find the one that is closest to
the current icon while still being above it.
wrote:
you have to iterate over all the icons. I'm working on this by
iterating all icons and finding the nearest one to the current selection
according to the key pressed, but the code is getting really complex in terms
of calculations. I was wondering if there is any other way of doing this? If
anyone has an idea, please let me know. Till then I'm working on it.
wrote:
I would do something like this (the example is for the up key only):
QModelIndex nextIndex = QModelIndex();
QPoint currentPos = visualRect(currentIndex).center();
int lastDistance = 0;
for (int i = 0; i m_validRows; i++) {
const QModelIndex index = m_model-index(i, 0);
const QPoint pos = visualRect(index).center();
if (pos.y() currentPos.y()) {
int distance = (pos - currentPos).manhattanLength();
if (distance lastDistance || !currentIndex.isValid()) {
nextIndex = index;
lastDistance = distance;
}
}
}
If nextIndex is valid when you get here, it's the index you should move
to.
If it isn't valid there are no icons above the current icon.
Thanks for working on this feature :)
wrote:
Ok, thanks for the help, that was less complex then mine ;) Its almost
done, just a few minor issues remaining.
But, I'm unable to understand why you're using `!currentIndex.isValid()`
in if (distance lastDistance || !currentIndex.isValid()) ?
Why do we need to validate the currentIndex ?
wrote:
Oh right, that should actually be nextIndex, not currentIndex.
I guess should read what I wrote more carefully before pressing publish
:)
wrote:
But still, why we need to validate (or, invalidate) nextIndex
`!currentIndex.isValid()` ? I tried to figure out, but failed. A little help
here :)
Because in the first iteration of the loop, lastDistance is 0, so 'distance
lastDistance' will be false.
Adding '|| nextIndex.isValid()' causes nextIndex and lastDistance to be
initialized to the values for the first item in the view.
Assigning QModelIndex() to an index makes the index invalid.
- Fredrik
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/#review541
---
On 2009-04-02 13:21:02, Shantanu Tushar Jha wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/
---
(Updated 2009-04-02 13:21:02)
Review request for Plasma.
Summary
---
This partly addresses the above bug, adding keyboard navigation and launch
using Enter key.
Please report if the code is too complex, I've tried my best to keep it to
the point.
This addresses bug 187241.
https://bugs.kde.org/show_bug.cgi?id=187241
Diffs
-
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.h 948236
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 948236
Diff: http://reviewboard.kde.org/r/368/diff
Testing
---
Tested on latest SVN build. Navigation and launch work fine. The problem is
with movement of the scrollbar with the keyboard focus, the scrollbar refuses
to go to minimum value when m_scrollBar-setValue( m_scrollBar-minimum() );
is used. What am I doing wrong?
Thanks,
Shantanu
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
PlasMate, final retouching
Hi everybody, based on your feedbaks in the mailing list, I've made some changes in my proposal. I think it coul be quite complete now, let me know if I have to be more detailed, and which subjects improve. http://socghop.appspot.com/student_proposal/show/google/gsoc2009/diego_casella/t123861443383 Cheers! Diego ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Makes the configuration of the comic plasmoid easier to use
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/461/#review800 --- Screenshot: http://reviewboard.kde.org//r/461/#scomment25 You should move it on top of the list. Screenshot: http://reviewboard.kde.org//r/461/#scomment26 I think that you may try to add a checkbox to enable autoswitch. - Davide On 2009-03-29 04:33:47, Matthias Fuchs wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/461/ --- (Updated 2009-03-29 04:33:47) Review request for Plasma and Davide Bettio. Summary --- Whenever the user ticks Use Tabs the view changes and the available comics are displayed in a listview, clicking at them marks them and adds them as tabs if ok is pressed. Otherwise it is similar to the current situation. I'm not sure if I should add Select All-, Deselect All-Buttons. What do you think? Diffs - /trunk/KDE/kdeplasma-addons/applets/comic/comic.h 946187 /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 946187 /trunk/KDE/kdeplasma-addons/applets/comic/comicSettings.ui 946187 /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.h 946187 /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.cpp 946187 Diff: http://reviewboard.kde.org/r/461/diff Testing --- Screenshots --- http://reviewboard.kde.org/r/461/s/82/ http://reviewboard.kde.org/r/461/s/83/ Thanks, Matthias ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: summer of code application
Hi ! On Thursday 02 April 2009 15:27:32 agnibha nath wrote: I have attached futher details and my resume. You need to fill gsoc's web form and actually propose a project, and not just send a CV ;) Check this websites for more information but be aware that the deadline is tomorrow (3rd of April).. http://tinyurl.com/kdesoc | http://tinyurl.com/soctimeline2 | http://tinyurl.com/soc-sample | http://tinyurl.com/soc-sample2 Cheers, --- Artur Duque de Souza OpenBossa Research Labs INdT - Instituto Nokia de Tecnologia --- Blog: http://labs.morpheuz.eng.br/blog/ GPG: 0xDBEEAAC3 @ wwwkeys.pgp.net --- signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Makes the configuration of the comic plasmoid easier to use
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/461/ --- (Updated 2009-04-02 17:20:21.771069) Review request for Plasma and Davide Bettio. Summary --- Whenever the user ticks Use Tabs the view changes and the available comics are displayed in a listview, clicking at them marks them and adds them as tabs if ok is pressed. Otherwise it is similar to the current situation. I'm not sure if I should add Select All-, Deselect All-Buttons. What do you think? Diffs - /trunk/KDE/kdeplasma-addons/applets/comic/comic.h 946187 /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 946187 /trunk/KDE/kdeplasma-addons/applets/comic/comicSettings.ui 946187 /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.h 946187 /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.cpp 946187 Diff: http://reviewboard.kde.org/r/461/diff Testing --- Screenshots --- http://reviewboard.kde.org/r/461/s/82/ http://reviewboard.kde.org/r/461/s/83/ http://reviewboard.kde.org/r/461/s/92/ Thanks, Matthias ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Makes the configuration of the comic plasmoid easier to use
On 2009-04-02 15:56:56, Davide Bettio wrote: Screenshot: http://reviewboard.kde.org You should move it on top of the list. And then having the Label, the ListView and the Button spanning two columns? See the new screenshot. On 2009-04-02 15:56:56, Davide Bettio wrote: Screenshot: http://reviewboard.kde.org I think that you may try to add a checkbox to enable autoswitch. You mean to make it more clear, that the default setting (0) does nothing? With a checkbox I'd change the default in fact. - Matthias --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/461/#review800 --- On 2009-04-02 17:20:21, Matthias Fuchs wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/461/ --- (Updated 2009-04-02 17:20:21) Review request for Plasma and Davide Bettio. Summary --- Whenever the user ticks Use Tabs the view changes and the available comics are displayed in a listview, clicking at them marks them and adds them as tabs if ok is pressed. Otherwise it is similar to the current situation. I'm not sure if I should add Select All-, Deselect All-Buttons. What do you think? Diffs - /trunk/KDE/kdeplasma-addons/applets/comic/comic.h 946187 /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 946187 /trunk/KDE/kdeplasma-addons/applets/comic/comicSettings.ui 946187 /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.h 946187 /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.cpp 946187 Diff: http://reviewboard.kde.org/r/461/diff Testing --- Screenshots --- http://reviewboard.kde.org/r/461/s/82/ http://reviewboard.kde.org/r/461/s/83/ http://reviewboard.kde.org/r/461/s/92/ Thanks, Matthias ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
