Re: Review Request: Patch to add free space indicator into device notifier plasmoid

2009-05-06 Thread martin . klapetek


> On 2009-05-05 15:56:22, Aaron Seigo wrote:
> > what's the status of this patch?

Almost finished, it just need a little visual polishing and also some code 
polishing. I've been too busy lately to finish it, but I'll post the final 
version tomorrow. Hopefully.


- mck182


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/632/#review1068
---


On 2009-04-28 04:29:44, mck182 wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/632/
> ---
> 
> (Updated 2009-04-28 04:29:44)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This is more like a proof of concept, for me to see if I'm on the right way 
> with this one
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 
> 958067 
>   trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h 
> 958067 
>   
> trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 
> 958067 
>   trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfo.h 
> PRE-CREATION 
>   
> trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfo.cpp 
> PRE-CREATION 
>   
> trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h
>  PRE-CREATION 
>   
> trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp
>  PRE-CREATION 
>   trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 
> 958067 
>   
> trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 
> 958067 
>   trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h 
> 958067 
>   trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 
> 958067 
> 
> Diff: http://reviewboard.kde.org/r/632/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> mck182
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Separator widget.

2009-05-06 Thread Ivan Cukic


> On 2009-05-05 15:55:37, Aaron Seigo wrote:
> > this will have to wait for 4.4 at this point, but it seems like a good 
> > idea. any reason why this would use an svg? could we get away with a simple 
> > QPainter drawing using Theme colours?

Using a hard-coded painting would be strange concerning that everything else is 
themable.

As for use-cases, one theme would want to show a dot (or three dots - like 
Oxygen had for toolbar separators before 4.0, and before the Great Divide), and 
not a line, one theme would like to show a gradient line (most opaque in the 
middle), or a perspective rectangle to give a feel of depth...


- Ivan


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/672/#review1067
---


On 2009-05-05 08:36:37, Davide Bettio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/672/
> ---
> 
> (Updated 2009-05-05 08:36:37)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> Separator widget is a separator line widget.
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdelibs/plasma/CMakeLists.txt 963819 
>   /trunk/KDE/kdelibs/plasma/widgets/separator.h PRE-CREATION 
>   /trunk/KDE/kdelibs/plasma/widgets/separator.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/672/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Davide
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Moving code for "Open With" and ServiceMenu actions to kdelibs

2009-05-06 Thread David Faure
On Tuesday 05 May 2009, Allen Winter wrote:
> On Tuesday 17 March 2009 4:03:03 pm David Faure wrote:
> > The code for handling "open with" action/submenus and servicemenus (RMB / 
> > Actions / ...)
> > is currently in libkonq (and used by dolphin and konqueror), but I have 
> > received a number
> > of requests for moving that code up to kdelibs.
> > It is already used by the plasma "Locations" runner AFAIK, which won't have 
> > to link to libkonq
> > anymore, and at least "Open With " will be used in 
> > KFileDialog,
> > and I'm sure there are more potential users of "open with" and servicemenus.
> > 
> > The attached patch adds two classes to kdelibs:
> > * KFileItemListProperties (which stores common properties for a list of 
> > items,
> >  and determines which capabilities are available, like all-readable, 
> > all-writable, etc.). Unittest included.
> > * KFileItemActions - the class which implements "Open with" and servicemenu 
> > actions.
> > 
> > The first one belongs obviously to kio (could even have been part of 
> > KFileItemList
> > if had a d pointer... that's for kde5); I wasn't exactly sure about the 
> > second one,
> > could have been for libkfile too. OTOH the goal of this move is do 
> > generalize
> > the use of those actions outside of file managers, so libkio is probably 
> > better.
> > 
> > Thanks for reviewing the patch (especially the API, which I already cleaned 
> > up
> > compared to what was in libkonq).
> > 
> > Of course I also ported the libkonq classes to those new classes (can't 
> > remove
> > them, for BC reasons, but they are now mere wrappers).
> > 
> David,
> 
> You finished and committed this, right?

Yep.

-- 
David Faure, fa...@kde.org, sponsored by Qt Software @ Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


sytem tray jobs/notifications icon

2009-05-06 Thread Aaron J. Seigo
hi...

i've been getting various bits of feedback on the notification/jobs icon in 
the tray, such as:

* it moves icons when it appears
* when it's not there there's an ugly space showing

tonight i played with just always showing it, and i think this might work out. 
this resulted in a couple of observations:

* BusyWidget::setRunning(false) puts it into an ugly state. it just looks 
frozen. any ideas on a "this busy widget isn't busy" visual?

* when an extender has groups, attachedItems() will return those groups as 
items. in turn, that makes the "don't show the popup if we have nothing in it" 
test in PopupAppletPrivate::internalTogglePopup fail because there's always 
something there, even though the groups are no visible. i think we either need 
to keep groups out of attachedItems() (what would that break if anything?) or 
else have a "bool isEmpty() const" method that takes into consideration things 
like empty groups.

thoughts on any/all of the above?
'
-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: sytem tray jobs/notifications icon

2009-05-06 Thread Aaron J. Seigo
On Wednesday 06 May 2009, Aaron J. Seigo wrote:
> out. this resulted in a couple of observations:

two more:

* the cursor should change to the clickable link hand when the 
job/notifications widget is visible in the system tray (i've implemented this 
locally already)

* the dark background behind the jobs widget now is pretty "heavy" visually 
since it's always visible there. maybe just a nice simple divider line?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: sytem tray jobs/notifications icon

2009-05-06 Thread Marco Martin
On Wednesday 06 May 2009, Aaron J. Seigo wrote:
> hi...
>
> i've been getting various bits of feedback on the notification/jobs icon in
> the tray, such as:
>
> * it moves icons when it appears
> * when it's not there there's an ugly space showing
>
> tonight i played with just always showing it, and i think this might work
> out. this resulted in a couple of observations:
>
> * BusyWidget::setRunning(false) puts it into an ugly state. it just looks
> frozen. any ideas on a "this busy widget isn't busy" visual?
i think the old info icon when the thing is not spinning would look better, 
makes also sense, because it says: now it's not working, but if you click here 
you'll get informations

>
> * when an extender has groups, attachedItems() will return those groups as
> items. in turn, that makes the "don't show the popup if we have nothing in
> it" test in PopupAppletPrivate::internalTogglePopup fail because there's
> always something there, even though the groups are no visible. i think we
> either need to keep groups out of attachedItems() (what would that break if
> anything?) or else have a "bool isEmpty() const" method that takes into
> consideration things like empty groups.

having attachedItems() and visibleItems()?
>
> thoughts on any/all of the above?
> '


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: sytem tray jobs/notifications icon

2009-05-06 Thread Marco Martin
On Wednesday 06 May 2009, Aaron J. Seigo wrote:
> On Wednesday 06 May 2009, Aaron J. Seigo wrote:
> > out. this resulted in a couple of observations:
>
> two more:
>
> * the cursor should change to the clickable link hand when the
> job/notifications widget is visible in the system tray (i've implemented
> this locally already)
uuh, so be an hand on every icon? (the ones we can control, so this and 
knotificationitem ones) perhaps the highhlight on mouse over is enough to tell 
that the thing is clickable?
> * the dark background behind the jobs widget now is pretty "heavy" visually
> since it's always visible there. maybe just a nice simple divider line?
uhm, outdated air theme? now the background should be light and only a few % 
more opaque than the normal area

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: sytem tray jobs/notifications icon

2009-05-06 Thread Rob Scheepmaker
On Wednesday 06 May 2009 10:35:32 Aaron J. Seigo wrote:
> * when an extender has groups, attachedItems() will return those groups as
> items. in turn, that makes the "don't show the popup if we have nothing in
> it" test in PopupAppletPrivate::internalTogglePopup fail because there's
> always something there, even though the groups are no visible. i think we
> either need to keep groups out of attachedItems() (what would that break if
> anything?) or else have a "bool isEmpty() const" method that takes into
> consideration things like empty groups.

I also do some is empty checks in Extender, and I had added a private isEmpty 
function to Extender that does just that. PopupApplet is already homies with 
Extender IIRC, so that function can be used there.

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: sytem tray jobs/notifications icon

2009-05-06 Thread Rob Scheepmaker
On Wednesday 06 May 2009 10:35:32 Aaron J. Seigo wrote:
> hi...
>
> i've been getting various bits of feedback on the notification/jobs icon in
> the tray, such as:
>
> * it moves icons when it appears
> * when it's not there there's an ugly space showing
>
> tonight i played with just always showing it, and i think this might work
> out. this resulted in a couple of observations:

Now that I'm thinking some more about this: this could work, but I think it 
would be very helpful if there was some clear difference between the icon if 
there are 0 items, and the icon if there are items. Like a different color, or 
something else that allows you to instantly notice that there are item there.

Regards,
Rob
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


KNotificationItem::showMessage

2009-05-06 Thread Aaron J. Seigo
hi

right now KNotificationItem::showMessage creates a visual notification. while 
simple to achieve, i'm wondering if it should be doing something a little more 
like a balloon message which shows some affinity to the item in the system 
tray itself? otherwise the application could just make a call to the visual 
notifications system itself without using the KNotificationItem API. 

thoughts?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: sytem tray jobs/notifications icon

2009-05-06 Thread Aaron J. Seigo
On Wednesday 06 May 2009, Marco Martin wrote:
> On Wednesday 06 May 2009, Aaron J. Seigo wrote:
> > On Wednesday 06 May 2009, Aaron J. Seigo wrote:
> > > out. this resulted in a couple of observations:
> >
> > two more:
> >
> > * the cursor should change to the clickable link hand when the
> > job/notifications widget is visible in the system tray (i've implemented
> > this locally already)
>
> uuh, so be an hand on every icon? (the ones we can control, so this and
> knotificationitem ones) perhaps the highhlight on mouse over is enough to
> tell that the thing is clickable?

the problem is that it doesn't highlight on mouse over and doesn't look 
immediately like something i'd click on; an icon "feels" clickable, while a 
busy spinner .. not so much.

> > * the dark background behind the jobs widget now is pretty "heavy"
> > visually since it's always visible there. maybe just a nice simple
> > divider line?
>
> uhm, outdated air theme? now the background should be light and only a few
> % more opaque than the normal area

hm... yes, it's pretty much imperceptible now.

(speaking of which, the opaque version of the panel provides very, very low 
contrast :/ )

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: sytem tray jobs/notifications icon

2009-05-06 Thread Aaron J. Seigo
On Wednesday 06 May 2009, Marco Martin wrote:
> i think the old info icon when the thing is not spinning would look better,
> makes also sense, because it says: now it's not working, but if you click
> here you'll get informations

of course, there is no information to had at that point. maybe a disabled info 
icon? :)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: sytem tray jobs/notifications icon

2009-05-06 Thread Aaron J. Seigo
On Wednesday 06 May 2009, Rob Scheepmaker wrote:
> On Wednesday 06 May 2009 10:35:32 Aaron J. Seigo wrote:
> > * when an extender has groups, attachedItems() will return those groups
> > as items. in turn, that makes the "don't show the popup if we have
> > nothing in it" test in PopupAppletPrivate::internalTogglePopup fail
> > because there's always something there, even though the groups are no
> > visible. i think we either need to keep groups out of attachedItems()
> > (what would that break if anything?) or else have a "bool isEmpty()
> > const" method that takes into consideration things like empty groups.
>
> I also do some is empty checks in Extender, and I had added a private
> isEmpty function to Extender that does just that. PopupApplet is already
> homies with Extender IIRC, so that function can be used there.

no, they aren't friends. i instead made isEmpty() part of the public API of 
extender. seems like the sort of things that's generally useful.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request: Jobs/Notifications button always visible

2009-05-06 Thread Aaron Seigo

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/675/
---

Review request for Plasma.


Summary
---

Make the ExtenderTask, responsible for showing job/notification status always 
visible so that it isn't jostling items around in the tray as it comes and goes.

Perhaps unrelated, there's a "gap" between the unhide icon and the first entry 
in the tray which is rather unsightly. not sure where that's coming from 


Diffs
-

  trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/taskarea.h 964316 
  trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/taskarea.cpp 964316 
  trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/extendertask.h 
964316 
  trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/extendertask.cpp 
964316 
  trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.h 964316 
  trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpp 964316 

Diff: http://reviewboard.kde.org/r/675/diff


Testing
---


Thanks,

Aaron

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: sytem tray jobs/notifications icon

2009-05-06 Thread Marco Martin
On Wednesday 06 May 2009, Aaron J. Seigo wrote:
> On Wednesday 06 May 2009, Marco Martin wrote:
> > i think the old info icon when the thing is not spinning would look
> > better, makes also sense, because it says: now it's not working, but if
> > you click here you'll get informations
>
> of course, there is no information to had at that point. maybe a disabled
> info icon? :)
sounds good

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: sytem tray jobs/notifications icon

2009-05-06 Thread Marco Martin
On Wednesday 06 May 2009, Aaron J. Seigo wrote:
> On Wednesday 06 May 2009, Marco Martin wrote:
> > On Wednesday 06 May 2009, Aaron J. Seigo wrote:
> > > On Wednesday 06 May 2009, Aaron J. Seigo wrote:
> > > > out. this resulted in a couple of observations:
> > >
> > > two more:
> > >
> > > * the cursor should change to the clickable link hand when the
> > > job/notifications widget is visible in the system tray (i've
> > > implemented this locally already)
> >
> > uuh, so be an hand on every icon? (the ones we can control, so this and
> > knotificationitem ones) perhaps the highhlight on mouse over is enough to
> > tell that the thing is clickable?
>
> the problem is that it doesn't highlight on mouse over and doesn't look
> immediately like something i'd click on; an icon "feels" clickable, while a
> busy spinner .. not so much.
oh, right.
i would perhaps as i said go with the info icon (maybe enabled/disabled) a 
stopped spinner feels a bit "broken" indeed :)
>
> > > * the dark background behind the jobs widget now is pretty "heavy"
> > > visually since it's always visible there. maybe just a nice simple
> > > divider line?
> >
> > uhm, outdated air theme? now the background should be light and only a
> > few % more opaque than the normal area
>
> hm... yes, it's pretty much imperceptible now.
>
> (speaking of which, the opaque version of the panel provides very, very low
> contrast :/ )
uuh whith what? with the last area of the systray? i will make it slightly 
more opaque, but i think it's good if it's quite subtle actually

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: KNotificationItem::showMessage

2009-05-06 Thread Marco Martin
On Wednesday 06 May 2009, Aaron J. Seigo wrote:
> hi
>
> right now KNotificationItem::showMessage creates a visual notification.
> while simple to achieve, i'm wondering if it should be doing something a
> little more like a balloon message which shows some affinity to the item in
> the system tray itself? otherwise the application could just make a call to
> the visual notifications system itself without using the KNotificationItem
> API.
>
> thoughts?
hmm i wasn't unsure in the first place about provide that function or not, in 
the end we decided to provide it just to make easier to port already existing 
apps, that saidi think it's good that all passive messages looks the same, 
making it an alien just because is reachable trough another code path doesn't 
seem really good to me (maybe usability wise is good or terribly bad, can't 
really say about that)

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Jobs/Notifications button always visible

2009-05-06 Thread Rob Scheepmaker

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/675/#review1078
---

Ship it!


Looks good to me... this is indeed much less 'stressfull'. I was wondering 
though: wouldn't it make sense to use a an enabled info icon in case there are 
only notifications and/or completed jobs? Still paint the number in front of 
it, but don't use a stopped spinner, but the I icon when no jobs are running.

- Rob


On 2009-05-06 08:14:43, Aaron Seigo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/675/
> ---
> 
> (Updated 2009-05-06 08:14:43)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> Make the ExtenderTask, responsible for showing job/notification status always 
> visible so that it isn't jostling items around in the tray as it comes and 
> goes.
> 
> Perhaps unrelated, there's a "gap" between the unhide icon and the first 
> entry in the tray which is rather unsightly. not sure where that's coming 
> from 
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/taskarea.h 964316 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/taskarea.cpp 
> 964316 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/extendertask.h 
> 964316 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/extendertask.cpp 
> 964316 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.h 964316 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpp 964316 
> 
> Diff: http://reviewboard.kde.org/r/675/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aaron
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Systray jobs

2009-05-06 Thread Rob Scheepmaker
On Tuesday 05 May 2009 18:57:49 Dario Freddi wrote:
> There is not a DBus interface exportable, however for 4.4 it would be nice
> if we could remove that code from PowerDevil and put it somewhere else
> (ideas, anyone?)
>
> Rob, feel free to contact me for more clarification on this. I really think
> you should use XSync over XScreensaver.

Currently, I use XScreensaverQueryInfo to obtain the idle time, something that 
rsibreak uses too, but I totally agree that for 4.4 it would be very useful to 
have some class in kdelibs (or some addition to a class already there, I'm not 
very sure where this would belong) to do exactly this. There seem to be quite 
some applications that need this information and this should also work on 
systems that don't use X11.

Regards,
Rob
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: sytem tray jobs/notifications icon

2009-05-06 Thread Aaron J. Seigo
On Wednesday 06 May 2009, Marco Martin wrote:
> > (speaking of which, the opaque version of the panel provides very, very
> > low contrast :/ )
>
> uuh whith what? with the last area of the systray? i will make it slightly
> more opaque, but i think it's good if it's quite subtle actually

no, opaque/widgets/panel-background.svg. it's a bland, blank grey now :)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Device Notifier - Western Digital USB drive not recognised

2009-05-06 Thread Mr Fixit

I'm not sure if this is an openSUSE problem or a KDE4 problem, so please excuse 
me if I have posted in the wrong area.

Since I updated to KDE4.2.2 my external USB drive no longer shows up in device 
notifier when I plug it in.

CDs and other USB memory sticks work perfectly, but not my USB drive.

The drive appears in Dolphin's list, and once I have clicked on it in Dolphin 
and entered the LUKS password, it then appears in the device notifier list.

The drive has only 1 partition, it is an encrypted (LUKS) Reiser partition if 
that makes any difference.

Another odd thing is that the drive automatically unmounts itself after use, ie 
I watch a movie from the drive, then when the movie is finished, the drive is 
automatically unmounted.  Even though I still have an open Dolphin window on 
the drive.

The device notifier plasmoid functioned normally before I updated from KDE 4.1 
to 4.2.2.

Details:

KDE version 4.2.2 (KDE 4.2.2) "release 114"
openSUSE 11.1 64 bit (plain KDE4.1 installed version updated to KDE 
4.2.2)Western Digital "MyBook" 1tg USB hard drive, lsusb shows - Bus 001 Device 
007: ID 1058:1100 Western Digital Technologies, Inc.
HP dv6645 Laptop
Kernel - 2.6.27.21-0.1-default

If you need anymore details, please ask as I am more than willing to help out 
if I can.

Thankyou.

_
Looking to move somewhere new this winter? Let ninemsn property help
http://a.ninemsn.com.au/b.aspx?URL=http%3A%2F%2Fninemsn%2Edomain%2Ecom%2Eau%2F%3Fs%5Fcid%3DFDMedia%3ANineMSN%5FHotmail%5FTagline&_t=774152450&_r=Domain_tagline&_m=EXT___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Jobs/Notifications button always visible

2009-05-06 Thread Aaron Seigo


> On 2009-05-06 09:03:09, Rob Scheepmaker wrote:
> > Looks good to me... this is indeed much less 'stressfull'. I was wondering 
> > though: wouldn't it make sense to use a an enabled info icon in case there 
> > are only notifications and/or completed jobs? Still paint the number in 
> > front of it, but don't use a stopped spinner, but the I icon when no jobs 
> > are running.

problem with the info icon + text on top is that you can't read the text very 
well and it looks messy; i've taken a slightly different approach, but which 
introduces this "tristate" system. let me know what you think on the mailing 
list or irc :)


- Aaron


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/675/#review1078
---


On 2009-05-06 08:14:43, Aaron Seigo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/675/
> ---
> 
> (Updated 2009-05-06 08:14:43)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> Make the ExtenderTask, responsible for showing job/notification status always 
> visible so that it isn't jostling items around in the tray as it comes and 
> goes.
> 
> Perhaps unrelated, there's a "gap" between the unhide icon and the first 
> entry in the tray which is rather unsightly. not sure where that's coming 
> from 
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/taskarea.h 964316 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/taskarea.cpp 
> 964316 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/extendertask.h 
> 964316 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/extendertask.cpp 
> 964316 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.h 964316 
>   trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpp 964316 
> 
> Diff: http://reviewboard.kde.org/r/675/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aaron
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Notifications Features

2009-05-06 Thread Celeste Lyn Paul
On Sunday 03 May 2009 03:43:42 am Marco Martin wrote:
> On 5/2/09, Celeste Lyn Paul  wrote:
> >  Some of you may or may not remember that I've also been working on
> >  interruptions and notifications; however as part of a uni project rather
> > than for an open source project.
> >
> >  Part of the project is for designing an empirical experiment to explore
> >  different features in notifications. I would like to look at features
> > which KDE would find useful to make the study more valuable.
>
> like putting some users in front of different systems and see the
> reactions? or a more theoretical thing?

Yes, putting users infront of different features to see which ones are better, 
etc. More empirical research than usability testing though.

> >  What types of questions do you regarding notifications? I've seen some
> >  questions regarding the amount of time a message should be displayed,
> > how long a message history should last, etc.
>
> yeah, interesting questions indeed, also interesting is how much
> screen size they can take up before becoming annoying
> also what is the better way tp display the history? alongside fresh
> notifications? in another interface?

Right, these are all things I'd eventually like to look into more, but I can 
only test a few features at a time without the experimental design becoming 
insane.

> >  I'm also thinking about looking at ways we can mediate notifications,
> > that is, instead of immediately displaying a notification, assess the
> > user and the environment and decide if it would be better to postpone the
> > notification for a short time. (For example, if a user currently has a
> > context or window menu open, postpone the notification until the menu is
> > closed or until n seconds)
>
> good idea, even if i don't have a clear idea how to do it technically
> one could push it as far as delaying the notification until there is a
> second without input from the user (or some amount of time passed)
> this suggests also dividing notifications by severity or category:
> changes the delay poicy or even how they are displayed

One guideline I found was that interruptions were more disruptive when users 
were directly interacting with an application (such as an app menu or context 
menu). I was trying to find out from the kwin people to see what type of 
information is available to the environment. I think we can tell when a user 
has one of those menus open, and so a "mediated" improvement would be to 
postpone an interruption until the user is out of the menu, or up to n 
seconds.

I would like to test a lot of those sorts of guidelines, because then we can 
come up with a set of rules for how notifications behave. Even if the effect is 
small, those small tweaks make the difference between a Good and Great system.

-- 
Celeste Lyn Paul
KDE Usability Project
usability.kde.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: FIXME part of quicklaunch

2009-05-06 Thread Sujith H


> On 2009-05-05 16:14:28, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp,
> >  lines 379-381
> > 
> >
> > the easiest way i can think of doing this (even if its not super fast, 
> > which doesn't matter because there are small #s of items here):
> > 
> > for (int i = 0; i < m_dialogLayout->count(); ++i) {
> > QGraphicsLayoutItem *item = m_dialogLayout->itemAt(i);
> > if (item->geometry().contains(pos)) {
> > m_dialogLayout->insertItem(dropedItem, i + 1);
> > break;
> > }
> > }

dropItem is Plasma::IconWidget right? err thats again confusing :( And the 
insertItem would call addItem method of QGraphicsGridLayout. 


- Sujith


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/649/#review1070
---


On 2009-05-05 12:28:07, Sujith  H wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/649/
> ---
> 
> (Updated 2009-05-05 12:28:07)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> ---
> 
> This patch is regarding the FIXME part of the quicklaunchApplet.cpp. I had 
> added one more method named dropApp. Added the processDrop as per Aaron 
> seigo. 
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 
> 963461 
>   
> trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 
> 963461 
> 
> Diff: http://reviewboard.kde.org/r/649/diff
> 
> 
> Testing
> ---
> 
> Done basic testing and it works.
> 
> 
> Thanks,
> 
> Sujith
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Notifications Features

2009-05-06 Thread Marco Martin
On Wednesday 06 May 2009, Celeste Lyn Paul wrote:
> On Sunday 03 May 2009 03:43:42 am Marco Martin wrote:
> > On 5/2/09, Celeste Lyn Paul  wrote:
> > >  Some of you may or may not remember that I've also been working on
> > >  interruptions and notifications; however as part of a uni project
> > > rather than for an open source project.
> > >
> > >  Part of the project is for designing an empirical experiment to
> > > explore different features in notifications. I would like to look at
> > > features which KDE would find useful to make the study more valuable.
> >
> > like putting some users in front of different systems and see the
> > reactions? or a more theoretical thing?
>
> Yes, putting users infront of different features to see which ones are
> better, etc. More empirical research than usability testing though.
>
> > >  What types of questions do you regarding notifications? I've seen some
> > >  questions regarding the amount of time a message should be displayed,
> > > how long a message history should last, etc.
> >
> > yeah, interesting questions indeed, also interesting is how much
> > screen size they can take up before becoming annoying
> > also what is the better way tp display the history? alongside fresh
> > notifications? in another interface?
>
> Right, these are all things I'd eventually like to look into more, but I
> can only test a few features at a time without the experimental design
> becoming insane.
>
> > >  I'm also thinking about looking at ways we can mediate notifications,
> > > that is, instead of immediately displaying a notification, assess the
> > > user and the environment and decide if it would be better to postpone
> > > the notification for a short time. (For example, if a user currently
> > > has a context or window menu open, postpone the notification until the
> > > menu is closed or until n seconds)
> >
> > good idea, even if i don't have a clear idea how to do it technically
> > one could push it as far as delaying the notification until there is a
> > second without input from the user (or some amount of time passed)
> > this suggests also dividing notifications by severity or category:
> > changes the delay poicy or even how they are displayed
>
> One guideline I found was that interruptions were more disruptive when
> users were directly interacting with an application (such as an app menu or
> context menu). I was trying to find out from the kwin people to see what
> type of information is available to the environment. I think we can tell

or  simply if the user is using the mouse/keyboard at all?
this could be done by quering the info used for screensaver triggering (as is 
discussed in systray jobs thread here)
that would be quite feasible i think
> when a user has one of those menus open, and so a "mediated" 
improvement
> would be to postpone an interruption until the user is out of the menu, or
> up to n seconds.
>
> I would like to test a lot of those sorts of guidelines, because then we
> can come up with a set of rules for how notifications behave. Even if the
> effect is small, those small tweaks make the difference between a Good and
> Great system.


___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Plasma crashing with QGraphicsLinearLayout.addStretch

2009-05-06 Thread Johannes Wolter
Hello,

I just got started with a simple Python-based Plasma widget. Right now I'm 
getting segfaults I cannot explain; so maybe someone could give me a hint, 
whether this is really a bug or a my fault.

I roughly followed an howto from techbase and everything works fine until I 
call "addStretch" on a QGraphicsLinearLayout instance. Then I'm getting a 
segfault with the following backtrace:

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xb3db9720 (LWP 11622)]
0xb741e737 in QGraphicsLayoutItem::isLayout () from /usr/lib/libQtGui.so.4
(gdb) bt
#0  0xb741e737 in QGraphicsLayoutItem::isLayout () from /usr/lib/libQtGui.so.4
#1  0xa85debf1 in ?? () from /usr/lib/pymodules/python2.5/PyQt4/QtGui.so
#2  0xa8b60bdd in PyCFunction_Call (func=0xa7078a6c, arg=0xa772a48c, kw=0x0) at 
../Objects/methodobject.c:73
#3  0xa8bb2f09 in PyEval_EvalFrameEx (f=0x846620c, throwflag=0) at 
../Python/ceval.c:3612
#4  0xa8bb3e3f in PyEval_EvalFrameEx (f=0x84012cc, throwflag=0) at 
../Python/ceval.c:3698
#5  0xa8bb488d in PyEval_EvalCodeEx (co=0xa8a8f800, globals=0xa8a9e3e4, 
locals=0x0, args=0xa772a738, argcount=1, kws=0x0, kwcount=0, defs=0x0, 
defcount=0, closure=0x0)
at ../Python/ceval.c:2875
#6  0xa8b4b5fa in function_call (func=0xa7fd5bc4, arg=0xa772a72c, kw=0x0) at 
../Objects/funcobject.c:517
#7  0xa8b27a47 in PyObject_Call (func=0x0, arg=0xa772a72c, kw=0x0) at 
../Objects/abstract.c:1861
#8  0xa8b2f875 in instancemethod_call (func=0xa7fd5bc4, arg=0xa772a72c, kw=0x0) 
at ../Objects/classobject.c:2519
#9  0xa8b27a47 in PyObject_Call (func=0x0, arg=0xa8ac502c, kw=0x0) at 
../Objects/abstract.c:1861
#10 0xa8bacb8c in PyEval_CallObjectWithKeywords (func=0xa772966c, 
arg=0xa8ac502c, kw=0x0) at ../Python/ceval.c:3481
#11 0xb3b2e883 in ?? () from /usr/lib/python2.5/site-packages/sip.so
#12 0xa772966c in ?? ()
#13 0xa8ac502c in ?? ()
#14 0x in ?? ()

And here is the actual code.

class LosungApplet(plasmascript.Applet):
def __init__(self,parent,args=None):
plasmascript.Applet.__init__(self,parent)
@pyqtSignature("strLinkClicked(const QString &)")
def strLinkClicked(self, url):
self.linkClicked(QUrl(url))
@pyqtSignature("linkClicked(const QUrl &)")
def linkClicked(self, url):
#webbrowser.open(url.toString(), new=2)
kio.KRun.runUrl(kdecore.KUrl(url), "text/html", None)
def _setupWebView(self, losung):
webView = Plasma.WebView(self.applet)
webView.page().setLinkDelegationPolicy(QWebPage.DelegateAllLinks)
QObject.connect(webView.page(), SIGNAL("linkClicked( const QUrl & )"), 
self.linkClicked)
r = LosungenRenderer()
webView.setHtml(r.renderLosung(losung))
return webView
def _setupLabel(self, losung):
label = Plasma.Label()
nw = label.nativeWidget()
nw.setTextInteractionFlags(Qt.TextBrowserInteraction)
QObject.connect(label, SIGNAL("linkActivated( const QString & )"), 
self.strLinkClicked)
r = LosungenRenderer()
label.setText(r.renderLosung(losung))
return label
def init(self):
self.setHasConfigurationInterface(True)
self.setAspectRatioMode(Plasma.IgnoreAspectRatio) 

self.losungenDB = LosungenDB("%s%s"%(self.package().path(), 
LOSUNGEN_CSV))

self.theme = Plasma.Svg(self)
self.theme.setImagePath("widgets/background")
self.setBackgroundHints(Plasma.Applet.DefaultBackground)

arrowLeftIcon = kdeui.KIcon("arrow-left")
arrowRightIcon = kdeui.KIcon("arrow-right")
goTodayIcon = kdeui.KIcon("go-jump-today")
self.arrowLeft = Plasma.ToolButton()
self.arrowLeft.nativeWidget().setIcon(arrowLeftIcon)
self.arrowLeft.setSizePolicy(QSizePolicy.Fixed, QSizePolicy.Fixed)
self.arrowRight = Plasma.ToolButton()
self.arrowRight.nativeWidget().setIcon(arrowRightIcon)
self.goToday = Plasma.ToolButton()
self.goToday.nativeWidget().setIcon(goTodayIcon)

losung = self.losungenDB.getLosung(datetime.date.today())
self.contentWidget = self._setupLabel(losung)

#self.layout = QGraphicsLinearLayout(Qt.Vertical, self.applet)

buttons = QGraphicsLinearLayout(Qt.Horizontal, self.applet)
buttons.addItem(self.arrowLeft)
buttons.addStretch()
buttons.addItem(self.goToday)
buttons.addStretch()
buttons.addItem(self.arrowRight)

#self.layout.addItem(self.contentWidget)
#self.layout.addItem(buttons)
self.setLayout(buttons)
self.resize(350,200)
def paintInterface(self, painter, option, rect):
pass

def CreateApplet(parent):
return LosungApplet(parent)

Thanks a lot for any hints,
Johannes Wolter
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Plasma crashing with QGraphicsLinearLayout.addStretch

2009-05-06 Thread Aaron J. Seigo
On Wednesday 06 May 2009, Johannes Wolter wrote:
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0xb3db9720 (LWP 11622)]
> 0xb741e737 in QGraphicsLayoutItem::isLayout () from /usr/lib/libQtGui.so.4
> (gdb) bt
> #0  0xb741e737 in QGraphicsLayoutItem::isLayout () from
> /usr/lib/libQtGui.so.4 #1  0xa85debf1 in ?? () from
> /usr/lib/pymodules/python2.5/PyQt4/QtGui.so #2  0xa8b60bdd in
> PyCFunction_Call (func=0xa7078a6c, arg=0xa772a48c, kw=0x0) at
> ../Objects/methodobject.c:73 #3  0xa8bb2f09 in PyEval_EvalFrameEx
> (f=0x846620c, throwflag=0) at ../Python/ceval.c:3612 #4  0xa8bb3e3f in

looks like a bug in the python bindings, perhaps?

(others on the list: note that Johannes is not sub'd to the list and so would 
probably appreciate being kept in the CC's)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


JS Scriptengine in libplasma

2009-05-06 Thread Leonardo Franchi
hola folks,

so i'm (finally) looking into adding scripted applet/dataengine support to 
amarok. it's really easy and transparent and all of that (yay plasma!) but we 
have a minor issue. we depend only on kdelibs, and the scriptengines are in 
kdebase/workspace.

i understand that most of them have external deps, which may be undesirable. 
Indeed, we'll most likely restrict all applets/engines to being javascript, so 
as to not require the user to install random *-bindings package. But moving 
the javascript dataengine to the plasma in  kdelibs would really be nice.

thoughts/comments/etc?

also, please CC me, i'm not subscribed.

cheers,
leo

-
lfran...@kde.orgTufts  University 2010
leonardo.fran...@tufts.edu The KDE Project
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: FIXME part of quicklaunch

2009-05-06 Thread Sujith H


> On 2009-05-05 16:14:28, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp,
> >  lines 379-381
> > 
> >
> > the easiest way i can think of doing this (even if its not super fast, 
> > which doesn't matter because there are small #s of items here):
> > 
> > for (int i = 0; i < m_dialogLayout->count(); ++i) {
> > QGraphicsLayoutItem *item = m_dialogLayout->itemAt(i);
> > if (item->geometry().contains(pos)) {
> > m_dialogLayout->insertItem(dropedItem, i + 1);
> > break;
> > }
> > }
> 
>  wrote:
> dropItem is Plasma::IconWidget right? err thats again confusing :( And 
> the insertItem would call addItem method of QGraphicsGridLayout.

May I know how to get the droped item(or object)? Because dropApp method uses 
"QGraphicsSceneDragDropEvent *event".


- Sujith


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/649/#review1070
---


On 2009-05-05 12:28:07, Sujith  H wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/649/
> ---
> 
> (Updated 2009-05-05 12:28:07)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> ---
> 
> This patch is regarding the FIXME part of the quicklaunchApplet.cpp. I had 
> added one more method named dropApp. Added the processDrop as per Aaron 
> seigo. 
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 
> 963461 
>   
> trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 
> 963461 
> 
> Diff: http://reviewboard.kde.org/r/649/diff
> 
> 
> Testing
> ---
> 
> Done basic testing and it works.
> 
> 
> Thanks,
> 
> Sujith
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: FIXME part of quicklaunch

2009-05-06 Thread Aaron Seigo


> On 2009-05-05 16:14:28, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp,
> >  lines 379-381
> > 
> >
> > the easiest way i can think of doing this (even if its not super fast, 
> > which doesn't matter because there are small #s of items here):
> > 
> > for (int i = 0; i < m_dialogLayout->count(); ++i) {
> > QGraphicsLayoutItem *item = m_dialogLayout->itemAt(i);
> > if (item->geometry().contains(pos)) {
> > m_dialogLayout->insertItem(dropedItem, i + 1);
> > break;
> > }
> > }
> 
>  wrote:
> dropItem is Plasma::IconWidget right? err thats again confusing :( And 
> the insertItem would call addItem method of QGraphicsGridLayout.
> 
>  wrote:
> May I know how to get the droped item(or object)? Because dropApp method 
> uses "QGraphicsSceneDragDropEvent *event".

looking at the code, all you need to do is this:

dropHandler(i + 1, event->mimeData());


- Aaron


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/649/#review1070
---


On 2009-05-05 12:28:07, Sujith  H wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/649/
> ---
> 
> (Updated 2009-05-05 12:28:07)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> ---
> 
> This patch is regarding the FIXME part of the quicklaunchApplet.cpp. I had 
> added one more method named dropApp. Added the processDrop as per Aaron 
> seigo. 
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 
> 963461 
>   
> trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 
> 963461 
> 
> Diff: http://reviewboard.kde.org/r/649/diff
> 
> 
> Testing
> ---
> 
> Done basic testing and it works.
> 
> 
> Thanks,
> 
> Sujith
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: JS Scriptengine in libplasma

2009-05-06 Thread Aaron J. Seigo
On Wednesday 06 May 2009, Leonardo Franchi wrote:
> *-bindings package. But moving the javascript dataengine to the plasma in 
> kdelibs would really be nice.

it would probably belong in runtime, actually. 
kdebase/runtime/plasma/javascript?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: JS Scriptengine in libplasma

2009-05-06 Thread Leonardo Franchi
On Wednesday 06 May 2009 21:54:19 Aaron J. Seigo wrote:
> On Wednesday 06 May 2009, Leonardo Franchi wrote:
> > *-bindings package. But moving the javascript dataengine to the plasma in
> > kdelibs would really be nice.
>
> it would probably belong in runtime, actually.
> kdebase/runtime/plasma/javascript?

Makes sense to me. Although technically we no longer depend on kdebase/runtime 
(we just required oxygen which moved to kdesupport).

leo

-
lfran...@kde.orgTufts  University 2010
leonardo.fran...@tufts.edu The KDE Project
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: JS Scriptengine in libplasma

2009-05-06 Thread Aaron J. Seigo
On Wednesday 06 May 2009, Leonardo Franchi wrote:
> On Wednesday 06 May 2009 21:54:19 Aaron J. Seigo wrote:
> > On Wednesday 06 May 2009, Leonardo Franchi wrote:
> > > *-bindings package. But moving the javascript dataengine to the plasma
> > > in kdelibs would really be nice.
> >
> > it would probably belong in runtime, actually.
> > kdebase/runtime/plasma/javascript?
>
> Makes sense to me. Although technically we no longer depend on
> kdebase/runtime (we just required oxygen which moved to kdesupport).

technically, all kde apps depend on kdebase-runtime. :)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software



signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Plasma crashing with QGraphicsLinearLayout.addStretch

2009-05-06 Thread Johannes Wolter
Johannes Wolter  inutil.org> writes:
> I just got started with a simple Python-based Plasma widget. Right now I'm 
> getting segfaults I cannot explain; so maybe someone could give me a hint, 
> whether this is really a bug or a my fault.
[...]

Sorry I forgot... I'm using Debian (mostly unstable):
libplasma3 4:4.2.2-2
plasma-scriptengine-webkit 4:4.2.2-2
plasma-scriptengine-python 4:4.2.2-2
libqt4-*   4.5.1-2

Johannes

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: JS Scriptengine in libplasma

2009-05-06 Thread Andreas Stricker
Hi

>>> it would probably belong in runtime, actually.
>>> kdebase/runtime/plasma/javascript?

Yes, I'll appreciate this. This allows applications with
Applet containers without the need for workspace.

Plasma is a great Widget framework not stricly bound to be
only usable for desktop environments...

>> Makes sense to me. Although technically we no longer depend on
>> kdebase/runtime (we just required oxygen which moved to kdesupport).
> 
> technically, all kde apps depend on kdebase-runtime. :)

Yes because most of the applets, containments, shells, etc there
depend on resources from kdebase-runtime.
Only the script engines there are more independed and may be
moved further down?


Regards, Andy



signature.asc
Description: OpenPGP digital signature
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: FIXME part of quicklaunch

2009-05-06 Thread Sujith H


> On 2009-05-05 16:14:28, Aaron Seigo wrote:
> > trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp,
> >  lines 379-381
> > 
> >
> > the easiest way i can think of doing this (even if its not super fast, 
> > which doesn't matter because there are small #s of items here):
> > 
> > for (int i = 0; i < m_dialogLayout->count(); ++i) {
> > QGraphicsLayoutItem *item = m_dialogLayout->itemAt(i);
> > if (item->geometry().contains(pos)) {
> > m_dialogLayout->insertItem(dropedItem, i + 1);
> > break;
> > }
> > }
> 
>  wrote:
> dropItem is Plasma::IconWidget right? err thats again confusing :( And 
> the insertItem would call addItem method of QGraphicsGridLayout.
> 
>  wrote:
> May I know how to get the droped item(or object)? Because dropApp method 
> uses "QGraphicsSceneDragDropEvent *event".
> 
>  wrote:
> looking at the code, all you need to do is this:
> 
> dropHandler(i + 1, event->mimeData());

The position used i.e, i+1, I think should be (i + 1 + m_visibleIcons). Else 
the issue is if I don't use m_visibleIcons, then :
If i is 0, then position becomes 1. And hence the dropedItem gets added in the 
applet not in the dialog box.


- Sujith


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/649/#review1070
---


On 2009-05-05 12:28:07, Sujith  H wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/649/
> ---
> 
> (Updated 2009-05-05 12:28:07)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> ---
> 
> This patch is regarding the FIXME part of the quicklaunchApplet.cpp. I had 
> added one more method named dropApp. Added the processDrop as per Aaron 
> seigo. 
> 
> 
> Diffs
> -
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 
> 963461 
>   
> trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 
> 963461 
> 
> Diff: http://reviewboard.kde.org/r/649/diff
> 
> 
> Testing
> ---
> 
> Done basic testing and it works.
> 
> 
> Thanks,
> 
> Sujith
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel