Re: tokamak planning
On Thursday 30 July 2009 21.22:48 Aaron J. Seigo wrote: hi all .. with tokamak getting closer, i'd like to start working on the content part of the planning for it. on the T3 page on Techbase there's the Topics section: http://techbase.kde.org/Projects/Plasma/Tokamak3#Topics Hello, this is my first post on this mailing list, so don't slap me :) I've read this thread with interest, as I really want to contribute to KDE but i'm a littlebit lost and don't know where to start from (Yes, I've read techbase getting started and friends, but KDE is huge isn't it?) As Tokamak3 will take place at some 3 hours by train from where I live (Neuchatel) I thought: Hey! I could 'sneak' in, meet people, look how they work and maybe ask someone to explain me shortly the big picture behind plasma! So I put my name on the list. I don't think i can really contribute with some code but I can handle the cooking things (what about some superb house-made pizza?) and alikes. Maybe I could also write down some report for a french magazine or help with (italian|french) translations... Is this ok for you guys? Best wishes and keep on the good work! -- Ilya Cassina signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: windows port of taskmanager library
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1101/#review1881 --- trunk/KDE/kdebase/workspace/libs/taskmanager/task.cpp http://reviewboard.kde.org/r/1101/#comment1229 Given there's a separate task_win.cpp, IMHO would be more clean adding Windows-specific includes only there. (The same could apply to the X11 headers for the _x11.cpp variant, but that can be done later.) trunk/KDE/kdebase/workspace/libs/taskmanager/task_win.cpp http://reviewboard.kde.org/r/1101/#comment1226 I suppose those should be replaced by your copyright? trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.h http://reviewboard.kde.org/r/1101/#comment1228 This could go in, I'd say. - Pino On 2009-07-22 23:57:29, Patrick Spendrin wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1101/ --- (Updated 2009-07-22 23:57:29) Review request for Plasma. Summary --- I want to add some missing functionality to the taskmanager library on the windows platform. As the code has some more X11 dependencies, I decided to make up two files for tasks.cpp which contain the functions that differ on Windows and X11. The only thing that should affect X11-builds in the end should be the change from class to struct for QUuid. There should be no other changes regarding the X11 platform. Diffs - trunk/KDE/kdebase/workspace/libs/CMakeLists.txt 1000690 trunk/KDE/kdebase/workspace/libs/taskmanager/task.h 1000690 trunk/KDE/kdebase/workspace/libs/taskmanager/task.cpp 1000690 trunk/KDE/kdebase/workspace/libs/taskmanager/task_win.cpp PRE-CREATION trunk/KDE/kdebase/workspace/libs/taskmanager/task_x11.cpp PRE-CREATION trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.h 1000690 trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.cpp 1000690 Diff: http://reviewboard.kde.org/r/1101/diff Testing --- I tested this on windows with both gcc and msvc compilers. Thanks, Patrick ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: tokamak planning
A Sábado, 1 de Agosto de 2009 19:34:25 Ilya M. Cassina você escreveu: On Thursday 30 July 2009 21.22:48 Aaron J. Seigo wrote: hi all .. with tokamak getting closer, i'd like to start working on the content part of the planning for it. on the T3 page on Techbase there's the Topics section: http://techbase.kde.org/Projects/Plasma/Tokamak3#Topics Hello, this is my first post on this mailing list, so don't slap me :) I've read this thread with interest, as I really want to contribute to KDE but i'm a littlebit lost and don't know where to start from (Yes, I've read techbase getting started and friends, but KDE is huge isn't it?) As Tokamak3 will take place at some 3 hours by train from where I live (Neuchatel) I thought: Hey! I could 'sneak' in, meet people, look how they work and maybe ask someone to explain me shortly the big picture behind plasma! So I put my name on the list. I don't think i can really contribute with some code but I can handle the cooking things (what about some superb house-made pizza?) and alikes. Maybe I could also write down some report for a french magazine or help with (italian|french) translations... Is this ok for you guys? Best wishes and keep on the good work! -- Ilya Cassina IM probably not going to be able to come but your post just put a good smile on my face. I just love OSS people and all the good energy it creates around it. -- Oxygen coordinator ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: tokamak planning
On Saturday 01 August 2009, 15:34 Ilya M. Cassina wrote: As Tokamak3 will take place at some 3 hours by train from where I live (Neuchatel) I thought: Hey! I could 'sneak' in, meet people, look how they work and maybe ask someone to explain me shortly the big picture behind plasma! [...snip...] You're more than welcome to come in and meet us. Any kind of help is appreciated and maybe after this meeting you'll be able to contribute back do KDE in may different forms: food, translations, marketing and code ;) Cheers and looking forward meeting you there! Cheres, -- Artur Duque de Souza openBossa Research Labs INdT - Instituto Nokia de Tecnologia -- Blog: http://blog.morpheuz.cc PGP: 0xDBEEAAC3 @ wwwkeys.pgp.net -- signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Please review: Virtual keyboard plasmoid - Plasmaboard
Hello, after some final polishment I want you to have a look at plasmaboard in kdereview/plasma/applets/plasmaboard It's a virtual keyboard plasmoid made for every KDE user with a touchscreen. My last addition was this tooltip, which shows the key you last hit. That's probably no optimal solution but I failed finding a better one. If someone can give me some hints how I can implement a popup like on the iphone virtual keyboard, I'm thankful. But I think the current solution is useable, too. I want to place this plasmoid in kdeplasma-addons for KDE 4.4. Fits great to the netbook stuff. Greetings, Björn ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: tokamak planning
hi Ilya ... On Saturday 01 August 2009, Ilya M. Cassina wrote: As Tokamak3 will take place at some 3 hours by train from where I live (Neuchatel) I thought: Hey! I could 'sneak' in, meet people, look how they work and maybe ask someone to explain me shortly the big picture behind plasma! while it would be great to have you as a guest (as it would be for anyone who is part of our community), there are some constraints on this event. there are the simple physical constraints of food and sleeping areas (for which we have a well defined and limited budget for). there's also the issue of time availability of both our host and the Plasma team. we're there to get work done in a face-to-face setting, something we only get to do a couple times a year. this means we're pretty busy and focused on the projects at hand. so while it would be great to have you there, i think Mario really needs to have the final say in this (for all i know, he may welcome a helping hand; just as equally likely, more people could just be more responsibility and work for him). you'd also have to take care of any expenses that you incur. personally, at least for this time around, and again only if it's ok with our host, i'd recommend coming out for maybe just a day or two (we might be able to put you up for the night as well, 6 hrs of train in one day is probably a bit much). if that's ok with Mario, you could come out, join us as an observer during the sessions and maybe get some pointers during the evenings / between work sessions. regardless of what happens this time around, if you do end up getting involved with Plasma in the future, we hold Tokamak 1-2 times a year and so far they've all been in Europe (and i don't really see that changing unless even more of our contributors start living in the Americas ;) so you could join us for one of those quite easily in the future. :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: windows port of taskmanager library
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1101/#review1884 --- with a bit more work, the TaskManager class could also be made ifdef free. there are two blocks of code that need to be ifdef'd as far as i can see, and in them they check for just a few things: is the window set to skip the pager? is the window mapped? should the window be included in the task manager? a similar approach taken with Task could be taken with TaskManager. personally, i far prefer separating out the platform specific code like that; ifdef's tend to lead to untested branches and compile errors due to bit rot. anyways, with a few more changes (noted below) this can go in. thanks for the patch :) trunk/KDE/kdebase/workspace/libs/taskmanager/task.h http://reviewboard.kde.org/r/1101/#comment1236 this could easily be changed to: void addTransient(WId w, bool demandingAttention) the only thing that the NETWinInfo object is used for in addTransient is to check for attention demanding. that would allow addTransient to be in both unix and win builds and one less ifdef. trunk/KDE/kdebase/workspace/libs/taskmanager/task.cpp http://reviewboard.kde.org/r/1101/#comment1233 agreed trunk/KDE/kdebase/workspace/libs/taskmanager/task.cpp http://reviewboard.kde.org/r/1101/#comment1232 instead of #include'ing the files here, this should be done in the CMakeLists.txt file trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.cpp http://reviewboard.kde.org/r/1101/#comment1235 is this needed? trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.cpp http://reviewboard.kde.org/r/1101/#comment1234 why is this #ifndef'd? - Aaron On 2009-07-22 23:57:29, Patrick Spendrin wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1101/ --- (Updated 2009-07-22 23:57:29) Review request for Plasma. Summary --- I want to add some missing functionality to the taskmanager library on the windows platform. As the code has some more X11 dependencies, I decided to make up two files for tasks.cpp which contain the functions that differ on Windows and X11. The only thing that should affect X11-builds in the end should be the change from class to struct for QUuid. There should be no other changes regarding the X11 platform. Diffs - trunk/KDE/kdebase/workspace/libs/CMakeLists.txt 1000690 trunk/KDE/kdebase/workspace/libs/taskmanager/task.h 1000690 trunk/KDE/kdebase/workspace/libs/taskmanager/task.cpp 1000690 trunk/KDE/kdebase/workspace/libs/taskmanager/task_win.cpp PRE-CREATION trunk/KDE/kdebase/workspace/libs/taskmanager/task_x11.cpp PRE-CREATION trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.h 1000690 trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.cpp 1000690 Diff: http://reviewboard.kde.org/r/1101/diff Testing --- I tested this on windows with both gcc and msvc compilers. Thanks, Patrick ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Quicklaunch: Fix bugs related to having unlimited visible icons
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1220/ --- Review request for Plasma. Summary --- This patch fixes a couple of bugs when having unlimited visible icons in the quicklaunch plasmoid. They were: - Having a vertical panel with unlimited number of icons resulted in just one row of squashed icons - Having unlimited icons gives a bigger width for no reason This should be backported to 4.3 Diffs - /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 1004927 Diff: http://reviewboard.kde.org/r/1220/diff Testing --- tested and compiled on trunk Thanks, Shafqat ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Please review: Virtual keyboard plasmoid - Plasmaboard
On Sunday 02 August 2009, Björn Ruberg wrote:
after some final polishment I want you to have a look at plasmaboard in
kdereview/plasma/applets/plasmaboard
It's a virtual keyboard plasmoid made for every KDE user with a
touchscreen.
cool; some initial comments/observations:
* there's a mix of whitespace usage in there; sometimes tabs are used to
indent, sometimes spaces. your goal is kdeplasma-addons, so you aren't
required to follow the kdelibs coding style (though you get extra cookies for
doing so ;) but could you use just one formatting style? throughout the code
* the tab key, when pressed, just keeps pressing tab over and over :)
* lots of magic numbers; e.g. FuncKey *funcKeys[14] in the header file and
then this in the implementation:
· · i = 0;
· · while ( i 14 ) {
· · · delete funcKeys[i];
· · · i++;
· · }
perhaps it makes sense to use a QVector here instead. that way you can replace
the above with:
qDeleteAll(funcKeys);
funcKeys.clear();
no magic numbers :)
* it'd be great if the keyboard modifier state was harmonized; e.g. if i press
CAPS LOCK on my keyboard, it would set this on the virtual keyboard and vice
versa. note that there is a keystate DataEngine that makes this all very
easy and cross-platform (it has serviceForSource() which lets you modify the
global state of modifiers)
* in FunkKey::toggleOn there is this:
· Plasma::PushButton::setStyleSheet(oldStyle + color:red;text-
align:center;); // sorry, but I need some visual confirmation
that color should really be coming out of the Plasma::Theme::colorScheme so it
works with all themes. in any case, i don't ever see the red color? is it
really needed?
* the biggest challenge i see is that there's no support (that i could see?)
for keyboard layouts. this will make our friends around the world sad. :) i
can think of various ways of accomplishing this but probably the most sane one
is to just follow xkb:
http://hektor.umcs.lublin.pl/~mikosmul/computing/articles/custom-keyboard-
layouts-xkb.html
the upside to this is that we can just use what's already there and follow the
system layout settings
My last addition was this tooltip, which shows the key you last hit. That's
probably no optimal solution but I failed finding a better one. If someone
can give me some hints how I can implement a popup like on the iphone
virtual keyboard, I'm thankful.
what sort of popup are thinking of or wanting? if you can give me a mockup or
a screenshot, i'm sure we can make it happen ;)
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Qt Software
signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Quicklaunch: Fix bugs related to having unlimited visible icons
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1220/#review1885 --- Ship it! looks fine; perhaps all the instances of -1 should be replaced with a `static const int UNLIMITED_ICONS = -1` in the header file? :) - Aaron On 2009-08-02 23:33:23, Shafqat Bhuiyan wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1220/ --- (Updated 2009-08-02 23:33:23) Review request for Plasma. Summary --- This patch fixes a couple of bugs when having unlimited visible icons in the quicklaunch plasmoid. They were: - Having a vertical panel with unlimited number of icons resulted in just one row of squashed icons - Having unlimited icons gives a bigger width for no reason This should be backported to 4.3 Diffs - /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 1004927 Diff: http://reviewboard.kde.org/r/1220/diff Testing --- tested and compiled on trunk Thanks, Shafqat ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Quicklaunch: Fix config UI where mouse wheeling on slider does not change spinbox value
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1221/#review1886 --- Ship it! good catch :) - Aaron On 2009-08-02 23:42:14, Shafqat Bhuiyan wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1221/ --- (Updated 2009-08-02 23:42:14) Review request for Plasma. Summary --- This changes the slider signals which connect to the spinboxes from sliderMoved(int) to valueChanged(int) in the quicklaunch configuration window. This fixes the problem where mouse wheeling on the slider does not change the spinbox. This should be backported to 4.3 Diffs - /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchConfig.ui 1004927 Diff: http://reviewboard.kde.org/r/1221/diff Testing --- Tested on trunk Thanks, Shafqat ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Quicklaunch: Fix config UI where mouse wheeling on slider does not change spinbox value
On 2009-08-02 23:52:28, Aaron Seigo wrote: good catch :) Thanks :) It would be great if you could commit this one as well :) - Shafqat --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1221/#review1886 --- On 2009-08-02 23:42:14, Shafqat Bhuiyan wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1221/ --- (Updated 2009-08-02 23:42:14) Review request for Plasma. Summary --- This changes the slider signals which connect to the spinboxes from sliderMoved(int) to valueChanged(int) in the quicklaunch configuration window. This fixes the problem where mouse wheeling on the slider does not change the spinbox. This should be backported to 4.3 Diffs - /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchConfig.ui 1004927 Diff: http://reviewboard.kde.org/r/1221/diff Testing --- Tested on trunk Thanks, Shafqat ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Quicklaunch: Fix bugs related to having unlimited visible icons
On 2009-08-02 23:51:37, Aaron Seigo wrote: looks fine; perhaps all the instances of -1 should be replaced with a `static const int UNLIMITED_ICONS = -1` in the header file? :) Ok I added the UNLIMITED_ICONS = -1 :) PS. Could you please commit this because my SVN account still isn't working :S - Shafqat --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1220/#review1885 --- On 2009-08-02 23:33:23, Shafqat Bhuiyan wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1220/ --- (Updated 2009-08-02 23:33:23) Review request for Plasma. Summary --- This patch fixes a couple of bugs when having unlimited visible icons in the quicklaunch plasmoid. They were: - Having a vertical panel with unlimited number of icons resulted in just one row of squashed icons - Having unlimited icons gives a bigger width for no reason This should be backported to 4.3 Diffs - /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 1004927 Diff: http://reviewboard.kde.org/r/1220/diff Testing --- tested and compiled on trunk Thanks, Shafqat ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Quicklaunch: Fix bugs related to having unlimited visible icons
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1220/ --- (Updated 2009-08-03 00:13:19.779107) Review request for Plasma. Changes --- Use static const int UNLIMITED_ICONS = -1 Summary --- This patch fixes a couple of bugs when having unlimited visible icons in the quicklaunch plasmoid. They were: - Having a vertical panel with unlimited number of icons resulted in just one row of squashed icons - Having unlimited icons gives a bigger width for no reason This should be backported to 4.3 Diffs (updated) - /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 1004927 Diff: http://reviewboard.kde.org/r/1220/diff Testing --- tested and compiled on trunk Thanks, Shafqat ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Quicklaunch: Fix bugs related to having unlimited visible icons
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1220/ --- (Updated 2009-08-03 00:17:24.088488) Review request for Plasma. Changes --- Forgot to replace a -1 with UNLIMTED_ICONS Summary --- This patch fixes a couple of bugs when having unlimited visible icons in the quicklaunch plasmoid. They were: - Having a vertical panel with unlimited number of icons resulted in just one row of squashed icons - Having unlimited icons gives a bigger width for no reason This should be backported to 4.3 Diffs (updated) - /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 1004927 Diff: http://reviewboard.kde.org/r/1220/diff Testing --- tested and compiled on trunk Thanks, Shafqat ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[PATCH] BUG 184905 Size of the panel changes when the plasma theme changes
Hi, all
These days I've been working on BUG 184905.
I found that the size of panel changes when it receives a thememChanged
signal from Plasma::Theme::defaultTheme(). And this signal is sended
when we change the plasma theme or enable/disable window effects.
The reason is that the margins of panel's layout isn't equal to the
margins of panel's background.
(kdebase/workspace/plasma/containments/panel/panel.cpp line 678-684)
And I found that it is not necessary to adjust margins for toolBoxItem,
(kdebase/workspace/plasma/containments/panel/panel.cpp line 553-568)
because the geometry of toolBoxItem is controlled by Plasma::Containment.
I'm not sure whether my understanding is correct. ):
Regards
--
潘卫平(Peter Pan)
Red Flag Software Co., Ltd
Index: panel.cpp
===
--- panel.cpp ï¼çæ¬ 1006104ï¼
+++ panel.cpp ï¼å·¥ä½å¯æ¬ï¼
@@ -550,23 +550,6 @@
//invalidate the layout and set again
if (layout()) {
-switch (location()) {
-case LeftEdge:
-rightWidth = qMin(rightWidth, qMax(qreal(1), size().width() - KIconLoader::SizeMedium));
-break;
-case RightEdge:
-leftWidth = qMin(leftWidth, qMax(qreal(1), size().width() - KIconLoader::SizeMedium));
-break;
-case TopEdge:
-bottomHeight = qMin(bottomHeight, qMax(qreal(1), size().height() - KIconLoader::SizeMedium));
-break;
-case BottomEdge:
-topHeight = qMin(topHeight, qMax(qreal(1), size().height() - KIconLoader::SizeMedium));
-break;
-default:
-break;
-}
-
qreal oldLeft = leftWidth;
qreal oldTop = topHeight;
qreal oldRight = rightWidth;
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] BUG 184905 Size of the panel changes when the plasma theme changes
On Sunday 02 August 2009, 潘卫平(Peter Pan) wrote: The reason is that the margins of panel's layout isn't equal to the margins of panel's background. (kdebase/workspace/plasma/containments/panel/panel.cpp line 678-684) yes, i think your patch is correct. nice one :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
