Review Request: Make folderview plasmoid to select first item if user press right key. Just like dolphin do.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1564/ --- Review request for Plasma. Summary --- Make folderview plasmoid to select first item if user press right key. Just like dolphin do. Diffs - /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1021815 Diff: http://reviewboard.kde.org/r/1564/diff Testing --- Thanks, Reza ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Replacement for knewsticker
Hi I have a question. Is there a real replacement for knewsticker in the pipeline? I and many of my friend find the actual rss-readers not so good like knewsticker. No one of them works in the toolbar and opens wiht one klick the feed in a browser. :-( Thanks Frank ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Replacement for knewsticker
On September 10, 2009, Frank Noack wrote: pipeline? I and many of my friend find the actual rss-readers not so good like knewsticker. No one of them works in the toolbar and opens wiht one klick the feed in a browser. :-( it's true that the News applet collapses to an icon and the RSS Now layout in very small spaces isn't great. both open the feed on click, however. feel free to supply patches to improve the layouts i panels. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Replacement for knewsticker
On Thursday 10 September 2009, Frank Noack wrote: Hi I have a question. Is there a real replacement for knewsticker in the pipeline? I and many of my friend find the actual rss-readers not so good like knewsticker. No one of them works in the toolbar and opens wiht one klick the feed in a browser. :-( the most near is rssnow. it should just be prettier in panels, but not really bad now, patches are welcome of course :) Thanks Frank ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Replacement for knewsticker
On Thursday 10 September 2009 16:23:40 Marco Martin wrote: On Thursday 10 September 2009, Frank Noack wrote: Hi I have a question. Is there a real replacement for knewsticker in the pipeline? I and many of my friend find the actual rss-readers not so good like knewsticker. No one of them works in the toolbar and opens wiht one klick the feed in a browser. :-( the most near is rssnow. it should just be prettier in panels, but not really bad now, patches are welcome of course :) I've actually submitted a patch to make RSSnow work better in small panel, I *think*. I'm also not sure wether it was before or after tagging 4.3, and if I backported it. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Plasmate previewer, again =P
As we could not have the meeting on that time as Diego and Aaron were busy at Tokamak, It'll be nice to have some status update. Diego what things are remaining to be implemented, i.e. which were planned but are not yet implemented? Just wanted a brief idea about the current status so that i could help :) Cheers On Wed, Aug 26, 2009 at 1:55 PM, Shantanu Tushar Jha jhahon...@gmail.comwrote: Ok, so we'll have an IRC meeting over Plasmate on 1430 UTC on Saturday . On Wed, Aug 26, 2009 at 1:26 PM, Diego Casella ([Po]lentino) polentino...@gmail.com wrote: -- Messaggio inoltrato -- From: Aaron J. Seigo ase...@kde.org To: plasma-devel@kde.org Date: Tue, 25 Aug 2009 10:15:42 -0600 Subject: Re: Plasmate previewer, again =P On Tuesday 25 August 2009, Shantanu Tushar Jha wrote: So guys, how about 1430 UTC on Saturday ? works great for me if it works for you gusy great for me too ! -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasmate previewer, again =P
On September 10, 2009, Shantanu Tushar Jha wrote: As we could not have the meeting on that time as Diego and Aaron were busy at Tokamak, actually, we showed up on irc at the stated time and waited around ... :/ It'll be nice to have some status update. Diego what things are remaining to be implemented, i.e. which were planned but are not yet implemented? we put together a really short list of things to do next; Diego, do you have that still? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: big revamp of Device Notifier
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2266 --- Much better as for code and configuration, there are just a few remarks down here I'd like you to have a look at /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui http://reviewboard.kde.org/r/1370/#comment1594 I am not a native speaker either.. but this the seems strange to me /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp http://reviewboard.kde.org/r/1370/#comment1595 These includes are not needed /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp http://reviewboard.kde.org/r/1370/#comment1596 Please remove this bit of code, it is most probably a leftover from some previous trunk revisions. /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp http://reviewboard.kde.org/r/1370/#comment1597 May I ask why do you need to go backward? /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp http://reviewboard.kde.org/r/1370/#comment1566 ManagerDialog should be NotifierDialog i suppose, here I still don't like the fact that you have to click twice to select the action if there is only one available action.. we should find a solution for this.. - Jacopo On 2009-09-01 16:55:56, Giulio Camuffo wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/ --- (Updated 2009-09-01 16:55:56) Review request for Plasma. Summary --- This is a patch that modifies quite heavily the behaviour of the Device Notifier. It comes from here: http://kde-look.org/content/show.php/Device+Manager?content=106051 It can show the not removable devices too, it can mount them automatically or with a click, since the eject button is a mount button when the volume is umounted. So that guy on the dot will be ok. It can hide some items in the same way as Dolphin's places (hide item/ show all). Finally, it shows the various opening actions under the device instead of calling that xp-ish window. Diffs - /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h 1013960 /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 1013960 /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 1013960 /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui PRE-CREATION /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h 1013960 /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp 1013960 /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 1013960 /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 1013960 /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h 1013960 /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 1013960 Diff: http://reviewboard.kde.org/r/1370/diff Testing --- I'm using it every day since I released 0.1 on Kde-look. I tried all the options on my pc and they work. Some people on kde-look posted some comments about some problems, but it seems to me they are very particular cases, so in my opinion it is quite stable to go in trunk, but anyway review it! :) Screenshots --- screen http://reviewboard.kde.org/r/1370/s/183/ Thanks, Giulio ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
more info on the TaskGroupItem crash
I finally took the time to investigate the plasma crash that was happening so often to me. Almost reproduceable testcase: 4.3 branch, enable task grouping, have some grouping in one desktop, then hit the next desktop key shortcut like a mad man (but at varying speeds) until it crashes. Well... last week this was quite reproduceable this way. This week I can't do it that way, I can only use kde and wait until it crashes again. Weird. Anyway. As suspected from the start, the problem was in the task group item code, and timing-related (so the deleteLater looked suspicious), but my earlier backtraces weren't really enough to figure out the problem. Now after valgrind'ing and adding tons of kDebug, I found the problem. It's a race between the deleteLater and the actual deletion. In between those two events, the item is re-added to the layout. So just after the actual deletion takes place, we have a dangling pointer in the layout's m_itemPositions list. TaskGroupItem::itemRemoved: groupItem= 0x202db80 item= 0x3a48370 m_tasksLayout= 0x202e6a0 TaskItemLayout::remove: this= 0x202e6a0 removing AbstractTaskItem 0x3a48370 TaskGroupItem::itemRemoved: Calling deleteLater on item 0x3a48370 m_applet= 0x1d07380 [...] QGraphicsScene::removeItem: item 0x3a48380's scene (0x0) is different from this scene (0x19e80d0) interesting, a QGraphicsScene warning too TaskItemLayout::insert: this= 0x202e6a0 inserting item 0x3a48370 into m_itemPositions TaskItemLayout::preferredColumns: 0x202e6a0 First AbstractTaskItem in m_itemPositions: 0x3a48370 [...] [then the deleteLater kicks in] WindowTaskItem::~WindowTaskItem: 0x3a48370 AbstractTaskItem::~AbstractTaskItem: Deleting taskitem 0x3a48370 m_applet= 0x1d07380 TaskItemLayout::preferredColumns: 0x202e6a0 First AbstractTaskItem in m_itemPositions: 0x3a48370 AbstractTaskItem::basicPreferredSize: 0x3a48370 CRASH. (0x3a48370 is a dangling pointer to a deleted item) The only part that is not clear to me is where the insert() comes from, but maybe you guys know that part anyway? Any ideas? PS: please CC me on replies. -- David Faure, fa...@kde.org, sponsored by Nokia to work on KDE, Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org). ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Kickoff Krunner whitelist
On September 9, 2009, Ivan Čukić wrote: Here is the list of current runners (that I have installed) http://pastebin.ca/1560026 Which ones should be enabled in kickoff? i think just the locations, shell, services and webshortcuts ones should be enabled by default... that replicates what's there right now with some slightly nicer features... -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Stylesheets and plasma widgets
I have a plasmoid (in Python) which uses Plasma.ToolButton widgets. I would like to allow the user to override the default style (taken from the plasma theme) of the buttons (for instance, to change font/size/colors). I have two problems/misunderstandings I need help with here: - First, I find that if I give the button a stylesheet using setStyleSheet(), the style sheet in use is totally blown away. Is there any way to just append or override settings of the stylesheet in use? I tried this: button = Plasma.PushButton() bstyle = button.styleSheet() bstyle += font: 8pt; button.setStyleSheet(bstyle) But that doesn't work -- it sets the font size alright, but the other style aspects set by the plasma theme (font, color, etc) are gone. Interestingly, button.styleSheet() returns an empty string. - Second, if I must override the entire style sheet for the button, how do I set the hover style of the button? setStyle() on the button object only seems to allow me to set the default style for the button. I would assume I could do this in the master stylesheet if I could access it, but I'm not sure how to get at it or change it. Is there an object I can call styleSheet() on to get the master stylesheet in use? Or... are style sheets just the wrong way to go about this? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Stylesheets and plasma widgets
On Thursday 10 September 2009, alanm wrote: I have a plasmoid (in Python) which uses Plasma.ToolButton widgets. I would like to allow the user to override the default style (taken from the plasma theme) of the buttons (for instance, to change font/size/colors). I have two problems/misunderstandings I need help with here: - First, I find that if I give the button a stylesheet using setStyleSheet(), the style sheet in use is totally blown away. Is there any way to just append or override settings of the stylesheet in use? I tried this: button = Plasma.PushButton() bstyle = button.styleSheet() bstyle += font: 8pt; button.setStyleSheet(bstyle) But that doesn't work -- it sets the font size alright, but the other style aspects set by the plasma theme (font, color, etc) are gone. Interestingly, button.styleSheet() returns an empty string. it's weird that is an empty string but yes, plasma widgets don't even try to parse stylesheets, if any is set they just pass the rendering to the underlying qwidget - Second, if I must override the entire style sheet for the button, how do I set the hover style of the button? setStyle() on the button object only seems to allow me to set the default style for the button. I would assume I could do this in the master stylesheet if I could access it, but I'm not sure how to get at it or change it. Is there an object I can call styleSheet() on to get the master stylesheet in use? Or... are style sheets just the wrong way to go about this? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Kickoff Krunner whitelist
On Thursday 10 September 2009 21:13:38 Aaron J. Seigo wrote: On September 9, 2009, Ivan Čukić wrote: Here is the list of current runners (that I have installed) http://pastebin.ca/1560026 Which ones should be enabled in kickoff? i think just the locations, shell, services and webshortcuts ones should be enabled by default... that replicates what's there right now with some slightly nicer features... I've placed these for the time being - I think those are really needed places shell services bookmarks recentdocuments locations; The problem is that it doesn't really work (for me, the configuration in KRunner - choosing which runners to use doesn't work neither) One of the problems I see is that the configuration file contains entries like pluginnameEnabled=value while setAllowedRunners makes pluginname=value http://reviewboard.kde.org/r/1565/diff/# ^^ makes kickoff and setAllowedRunners work ok, but KRunner still doesn't filter the runners (krunner uses the pluginnameEnabled=value and doesn't specify the field I've introduced - filterAllowedRunners=true) So, I'm concerned that I'm missing a greater plan you had while making the loadRunners() cheers ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: RunnerManager: Whitelist enforcement (bugfix)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1565/#review2278 --- when setAllowedRunners is called, it removes any instantiated runners, resets the config values and then on next run the runners should be loaded based on that. where is this currently failing? - Aaron On 2009-09-10 19:19:21, Ivan Cukic wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1565/ --- (Updated 2009-09-10 19:19:21) Review request for Plasma. Summary --- Whitelist enforcement - if the whitelist is set, then the runners are filtered by it (this is mainly a fix) Diffs - /trunk/KDE/kdelibs/plasma/runnermanager.cpp 1021493 Diff: http://reviewboard.kde.org/r/1565/diff Testing --- done testing in KRunner and Kickoff Thanks, Ivan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Stylesheets and plasma widgets
On September 10, 2009, alanm wrote: I have a plasmoid (in Python) which uses Plasma.ToolButton widgets. I would like to allow the user to override the default style (taken from the plasma theme) of the buttons (for instance, to change font/size/colors). why? - First, I find that if I give the button a stylesheet using setStyleSheet(), the style sheet in use is totally blown away. Is there yes; that's due to how it works in Qt (which is not overly well). stylesheets are orthogonal to the svg styles we currently use, so we fall back to what Qt can provide when it comes to style sheets. you are then within the limitations of Qt at that point. - Second, if I must override the entire style sheet for the button, how do I set the hover style of the button? what exactly are you trying to achieve? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: more info on the TaskGroupItem crash
On September 10, 2009, David Faure wrote: It's a race between the deleteLater and the actual deletion. In between so exactly the same kind of problem i fixed in libtaskmanager for 4.3.0, but this time it's in the applet. thanks for your work on tracking this down. The only part that is not clear to me is where the insert() comes from, but maybe you guys know that part anyway? Any ideas? i'll take a look this afternoon and see if i can't come up with a patch for you. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: RunnerManager: Whitelist enforcement (bugfix)
On 2009-09-10 19:28:38, Aaron Seigo wrote: when setAllowedRunners is called, it removes any instantiated runners, resets the config values and then on next run the runners should be loaded based on that. where is this currently failing? the description.isPluginEnabled() is loaded from plugin info and (for me) doesn't work with the local config - Ivan --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1565/#review2278 --- On 2009-09-10 19:19:21, Ivan Cukic wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1565/ --- (Updated 2009-09-10 19:19:21) Review request for Plasma. Summary --- Whitelist enforcement - if the whitelist is set, then the runners are filtered by it (this is mainly a fix) Diffs - /trunk/KDE/kdelibs/plasma/runnermanager.cpp 1021493 Diff: http://reviewboard.kde.org/r/1565/diff Testing --- done testing in KRunner and Kickoff Thanks, Ivan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make folderview plasmoid to select first item if user press right key. Just like dolphin do.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1564/#review2281 --- Ship it! Looks good to me. - Fredrik On 2009-09-10 07:44:38, Reza Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1564/ --- (Updated 2009-09-10 07:44:38) Review request for Plasma. Summary --- Make folderview plasmoid to select first item if user press right key. Just like dolphin do. Diffs - /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1021815 Diff: http://reviewboard.kde.org/r/1564/diff Testing --- Thanks, Reza ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Stylesheets and plasma widgets
On Thursday 10 September 2009 2:29:09 pm Aaron J. Seigo wrote: On September 10, 2009, alanm wrote: I have a plasmoid (in Python) which uses Plasma.ToolButton widgets. I would like to allow the user to override the default style (taken from the plasma theme) of the buttons (for instance, to change font/size/colors). why? Basically, I'm creating a launcher something like quicklaunch that allows you to use text instead of icons. Since the text is the main focus of the plasmoid, I wanted to give the user the ability to customize it a bit. Using the built in style works OK, but depending on screen size/font size/plasma theme it might be nice to adjust this (cf. the digital clock plasmoid). - First, I find that if I give the button a stylesheet using setStyleSheet(), the style sheet in use is totally blown away. Is there yes; that's due to how it works in Qt (which is not overly well). stylesheets are orthogonal to the svg styles we currently use, so we fall back to what Qt can provide when it comes to style sheets. you are then within the limitations of Qt at that point. Is there a better way to make these kinds of small adjustments apart from style sheets? - Second, if I must override the entire style sheet for the button, how do I set the hover style of the button? what exactly are you trying to achieve? I don't really need to adjust the hover style and whatnot, but if I have to recreate the whole stylesheet to adjust anything, I wasn't sure how to go about recreating those sorts of things. If there's a better way to accomplish all of this without style sheets then it's moot. Thanks . ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Kickoff Krunner whitelist
Hello Ivan, Thanks for looking into this. A couple of notes about Kickoff / KRunner integration: 1. Keyboard navigation of the search results appears to have broken, can you please have a look at that. 2. The search results for applications now take longer to appear than they used to by a third to half a second. Launching applications I think it is very important that the results come back quickly. 3. What controls the sorting of the results? Regards, Robert. 2009/9/10 Ivan Čukić ivan.cu...@gmail.com: On Thursday 10 September 2009 21:13:38 Aaron J. Seigo wrote: On September 9, 2009, Ivan Čukić wrote: Here is the list of current runners (that I have installed) http://pastebin.ca/1560026 Which ones should be enabled in kickoff? i think just the locations, shell, services and webshortcuts ones should be enabled by default... that replicates what's there right now with some slightly nicer features... I've placed these for the time being - I think those are really needed places shell services bookmarks recentdocuments locations; The problem is that it doesn't really work (for me, the configuration in KRunner - choosing which runners to use doesn't work neither) One of the problems I see is that the configuration file contains entries like pluginnameEnabled=value while setAllowedRunners makes pluginname=value http://reviewboard.kde.org/r/1565/diff/# ^^ makes kickoff and setAllowedRunners work ok, but KRunner still doesn't filter the runners (krunner uses the pluginnameEnabled=value and doesn't specify the field I've introduced - filterAllowedRunners=true) So, I'm concerned that I'm missing a greater plan you had while making the loadRunners() cheers ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: RunnerManager: Whitelist enforcement (bugfix)
On September 10, 2009, you wrote: On 2009-09-10 19:28:38, Aaron Seigo wrote: when setAllowedRunners is called, it removes any instantiated runners, resets the config values and then on next run the runners should be loaded based on that. where is this currently failing? the description.isPluginEnabled() is loaded from plugin info and (for me) doesn't work with the local config right, because isPluginEnabled takes its default from the .desktop file. hm. so setAllowedPlugins probably needs to store its list in a separate key and compare against it first. will commit a patch shortly. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Stylesheets and plasma widgets
On September 10, 2009, alanm wrote: Is there a better way to make these kinds of small adjustments apart from style sheets? set the font style/face/color on the nativeWidget()? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Plasmate previewer, again =P
-- Messaggio inoltrato --
From: Aaron J. Seigo ase...@kde.org
To: plasma-devel@kde.org
Date: Thu, 10 Sep 2009 11:23:26 -0600
Subject: Re: Plasmate previewer, again =P
On September 10, 2009, Shantanu Tushar Jha wrote:
As we could not have the meeting on that time as Diego and Aaron were
busy
at Tokamak,
actually, we showed up on irc at the stated time and waited around ... :/
yup ...
It'll be nice to have some status update. Diego what things are
remaining to be implemented, i.e. which were planned but are not yet
implemented?
we put together a really short list of things to do next; Diego, do you
have
that still?
Of course !
Since up to now the code structure is not as good as we want, the basic idea
was to build a core class that handles our UI stuff, a ProjectManager class
to create/load projects and keep track of its files, and other stuffs.
As soon as everything works well, first we have to provide a secure way to
upload the package ( the idea is to use QCA to sign the package ); second,
that is, when an user download a package from our server, we have to alert
the user with one of these signals ( iirc :P ):
- Green flag: package signed by both KDE and the developer ( = completely
trusted );
- Blue flag: package signed by KDE, but not by the developer;
- Yellow flag: package signed by the developer, but not by KDE;
- Red flag: package is not signed ( = install it at your own risk ).
Also, some improvements on Plasma::PackageMetadata should be done ( if there
are no issues with BC ):
- Made method's name more coherent ( for example, if the entry we want to
retrieve is X-KDE-PluginInfo-Name and the getter is called PluginName(),
why the setter is named setName() ? it should be setPluginName() ! );
- extend the API in order to handle more entries ( for example, up to now
there is no API call to write the X-Plasma-MainScript entry, so i'm forced
to use QFile to open the metadata.desktop file, and then append that string
manually O_o )
Actual state of PlasMate:
* At present, the TimeLine is broken again because the regexp fix made @
Tokamak was wrong: in fact the regexp ^commit [0-9a-ef]+$ always returns
the entire list of commits! I've adjusted it with commit\\s[0-9a-f]{40}\\n
and now works perfectly but, since splitting a string with a regexp also
removes the matched expressions, the sha1hash is not present in the
resulting list so I'm waiting to write an elegant solution before committing
:P
* The editor works pretty good, I tried it and works perfectly.
* The previewer is awesome, but its possible to test it with a fake
package and see if it load it correctly ?
Ok, i think that's all, now i want your opinion/ideas =)
Have a nice day,
Cheers !!!
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Qt Development Frameworks
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasmate previewer, again =P
On September 10, 2009, Diego Casella ([Po]lentino) wrote:
-- Messaggio inoltrato --
From: Aaron J. Seigo ase...@kde.org
To: plasma-devel@kde.org
Date: Thu, 10 Sep 2009 11:23:26 -0600
Subject: Re: Plasmate previewer, again =P
On September 10, 2009, Shantanu Tushar Jha wrote:
As we could not have the meeting on that time as Diego and Aaron were
busy
at Tokamak,
actually, we showed up on irc at the stated time and waited around ... :/
yup ...
It'll be nice to have some status update. Diego what things are
remaining to be implemented, i.e. which were planned but are not yet
implemented?
we put together a really short list of things to do next; Diego, do you
have
that still?
Of course !
Since up to now the code structure is not as good as we want, the basic
idea was to build a core class that handles our UI stuff, a ProjectManager
class to create/load projects and keep track of its files, and other
stuffs. As soon as everything works well, first we have to provide a
secure way to upload the package ( the idea is to use QCA to sign the
package ); second, that is, when an user download a package from our
server, we have to alert the user with one of these signals ( iirc :P ):
- Green flag: package signed by both KDE and the developer ( =
completely trusted );
- Blue flag: package signed by KDE, but not by the developer;
- Yellow flag: package signed by the developer, but not by KDE;
- Red flag: package is not signed ( = install it at your own risk ).
Also, some improvements on Plasma::PackageMetadata should be done ( if
there are no issues with BC ):
- Made method's name more coherent ( for example, if the entry we want
to retrieve is X-KDE-PluginInfo-Name and the getter is called
PluginName(), why the setter is named setName() ? it should be
setPluginName() ! )
it is setPluginName().
; - extend the API in order to handle more entries (
for example, up to now there is no API call to write the
X-Plasma-MainScript entry, so i'm forced to use QFile to open the
metadata.desktop file, and then append that string manually O_o )
that probably belongs either in a subclass or via a
PackageMetaData::setProperty(const QString key, const QVariant value) method
since X-Plasma-MainScript is specific to plasmoid scripting and not to
packages in general.
* At present, the TimeLine is broken again because the regexp fix made @
Tokamak was wrong: in fact the regexp ^commit [0-9a-ef]+$ always returns
the entire list of commits! I've adjusted it with
hm. try setMinimal(true) on the QRegExp object.
as for the sha1 hash, try:
^commit ([0-9a-f])+$
and then you can use QRegExp::cap(int), and use a while loop like the one in
the QRegExp docu:
while ((pos = rx.indexIn(str, pos)) != -1) {
list rx.cap(1);
pos += rx.matchedLength();
}
and cut up the list as you go.
* The editor works pretty good, I tried it and works perfectly.
great :)
* The previewer is awesome, but its possible to test it with a fake
package and see if it load it correctly ?
can you try it on a real package loaded in plasmate?
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Qt Development Frameworks
signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: more info on the TaskGroupItem crash
On September 10, 2009, David Faure wrote:
I finally took the time to investigate the plasma crash that was happening
so often to me.
can you try the attached patch? thanks.
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Qt Development Frameworks
Index: taskgroupitem.cpp
===
--- taskgroupitem.cpp (revision 1019907)
+++ taskgroupitem.cpp (working copy)
@@ -105,7 +105,8 @@
if (!m_childSplitGroup) {
return;
}
-m_childSplitGroup-deleteLater();
+
+m_childSplitGroup-destroy();
m_childSplitGroup = 0;
m_splitPosition = 0;
reload();
@@ -535,7 +536,7 @@
}
item-close();
-item-deleteLater();
+item-destroy();
}
bool TaskGroupItem::isWindowItem() const
@@ -978,7 +979,6 @@
}
AbstractTaskItem *taskItem = abstractTaskItem(item);
-
m_tasksLayout-removeTaskItem(taskItem);
if (m_group) {
Index: abstracttaskitem.cpp
===
--- abstracttaskitem.cpp (revision 1019907)
+++ abstracttaskitem.cpp (working copy)
@@ -76,7 +76,8 @@
m_hoverEffectTimerId(0),
m_attentionTimerId(0),
m_attentionTicks(0),
- m_fadeIn(true)
+ m_fadeIn(true),
+ m_destroyed(false)
{
setSizePolicy(QSizePolicy(QSizePolicy::Expanding,QSizePolicy::Expanding));
setAcceptsHoverEvents(true);
@@ -92,6 +93,15 @@
connect(applet, SIGNAL(settingsChanged()), this, SLOT(checkSettings()));
}
+AbstractTaskItem::~AbstractTaskItem()
+{
+if (m_animId) {
+Plasma::Animator::self()-stopCustomAnimation(m_animId);
+}
+
+Plasma::ToolTipManager::self()-unregisterWidget(this);
+}
+
QSize AbstractTaskItem::basicPreferredSize() const
{
QFontMetrics fm(KGlobalSettings::taskbarFont());
@@ -140,13 +150,15 @@
setPreferredSize(basicPreferredSize());
}
-AbstractTaskItem::~AbstractTaskItem()
+void AbstractTaskItem::destroy()
{
-if (m_animId) {
-Plasma::Animator::self()-stopCustomAnimation(m_animId);
-}
+m_destroyed = true;
+QObject::deleteLater();
+}
-Plasma::ToolTipManager::self()-unregisterWidget(this);
+bool AbstractTaskItem::isDestroyed() const
+{
+return m_destroyed;
}
void AbstractTaskItem::checkSettings()
Index: abstracttaskitem.h
===
--- abstracttaskitem.h (revision 1019907)
+++ abstracttaskitem.h (working copy)
@@ -129,6 +129,9 @@
void setPreferredOffscreenSize();
void setPreferredOnscreenSize();
+void destroy();
+bool isDestroyed() const;
+
Q_SIGNALS:
void activated(AbstractTaskItem *);
@@ -232,11 +235,15 @@
int m_attentionTicks;
bool m_fadeIn : 1;
+bool m_destroyed : 1;
// distance (in pixels) between a task's icon and its text
static const int IconTextSpacing = 4;
static const int TaskItemHorizontalMargin = 4;
static const int TaskItemVerticalMargin = 4;
+
+private:
+void deleteLater();
};
#endif
Index: taskitemlayout.cpp
===
--- taskitemlayout.cpp (revision 1019907)
+++ taskitemlayout.cpp (working copy)
@@ -106,7 +106,7 @@
bool TaskItemLayout::insert(int index, AbstractTaskItem* item)
{
//kDebug() item-text() index;
-if (!item ) {
+if (!item || item-isDestroyed()) {
kDebug() error;
return false;
}
signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Stylesheets and plasma widgets
Aaron J. Seigo wrote: On September 10, 2009, alanm wrote: Is there a better way to make these kinds of small adjustments apart from style sheets? set the font style/face/color on the nativeWidget()? Thanks; I tried this, but it didn't work (or else I'm doing it wrong). My code is: button.nativeWidget().setFont(QFont(sans,6)) What happens is the button shrinks down to the size it would be if the font were actually 6 point font, but the text is then drawn according to the size/face settings for plasma/KDE (which results in the text getting cut off). Sorry in advance if I'm doing something painfully obviously wrong. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Stylesheets and plasma widgets
On September 10, 2009, alan moore wrote: Thanks; I tried this, but it didn't work (or else I'm doing it wrong). looking at Plasma::PushButton, it doesn't allow setting the font directly. it uses the theme's font. it should probably not do so if a font is set (e.g. receives a FontChange event).. so some work needed in libplasma -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Make folderview plasmoid to select first item if user press right key. Just like dolphin do.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1564/#review2283 --- Ship it! Looks fine, go for it ! - Shantanu On 2009-09-10 07:44:38, Reza Shah wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1564/ --- (Updated 2009-09-10 07:44:38) Review request for Plasma. Summary --- Make folderview plasmoid to select first item if user press right key. Just like dolphin do. Diffs - /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp 1021815 Diff: http://reviewboard.kde.org/r/1564/diff Testing --- Thanks, Reza ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasmate previewer, again =P
On Thu, Sep 10, 2009 at 10:53 PM, Aaron J. Seigo ase...@kde.org wrote: On September 10, 2009, Shantanu Tushar Jha wrote: As we could not have the meeting on that time as Diego and Aaron were busy at Tokamak, actually, we showed up on irc at the stated time and waited around ... :/ Err, thats weird because we all (count = 4) were on IRC that time and Deigo told me that you'll be joining in few minutes. No activity till 2 hours. Anyway, maybe a time mismatch :P It'll be nice to have some status update. Diego what things are remaining to be implemented, i.e. which were planned but are not yet implemented? we put together a really short list of things to do next; Diego, do you have that still? -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Plasmate previewer, again =P
On Fri, Sep 11, 2009 at 4:02 AM, Diego Casella ([Po]lentino)
polentino...@gmail.com wrote:
-- Messaggio inoltrato --
From: Aaron J. Seigo ase...@kde.org
To: plasma-devel@kde.org
Date: Thu, 10 Sep 2009 11:23:26 -0600
Subject: Re: Plasmate previewer, again =P
On September 10, 2009, Shantanu Tushar Jha wrote:
As we could not have the meeting on that time as Diego and Aaron were
busy
at Tokamak,
actually, we showed up on irc at the stated time and waited around ... :/
yup ...
It'll be nice to have some status update. Diego what things are
remaining to be implemented, i.e. which were planned but are not yet
implemented?
we put together a really short list of things to do next; Diego, do you
have
that still?
Of course !
Since up to now the code structure is not as good as we want, the basic
idea was to build a core class that handles our UI stuff, a ProjectManager
class to create/load projects and keep track of its files, and other stuffs.
As soon as everything works well, first we have to provide a secure way to
upload the package ( the idea is to use QCA to sign the package ); second,
that is, when an user download a package from our server, we have to alert
the user with one of these signals ( iirc :P ):
- Green flag: package signed by both KDE and the developer ( =
completely trusted );
- Blue flag: package signed by KDE, but not by the developer;
- Yellow flag: package signed by the developer, but not by KDE;
- Red flag: package is not signed ( = install it at your own risk ).
How is it known that a package is signed by KDE? Is there some existing
mechanism or it has to be worked on?
Also, some improvements on Plasma::PackageMetadata should be done ( if
there are no issues with BC ):
- Made method's name more coherent ( for example, if the entry we want
to retrieve is X-KDE-PluginInfo-Name and the getter is called
PluginName(), why the setter is named setName() ? it should be
setPluginName() ! );
- extend the API in order to handle more entries ( for example, up to
now there is no API call to write the X-Plasma-MainScript entry, so i'm
forced to use QFile to open the metadata.desktop file, and then append that
string manually O_o )
Actual state of PlasMate:
* At present, the TimeLine is broken again because the regexp fix made @
Tokamak was wrong: in fact the regexp ^commit [0-9a-ef]+$ always returns
the entire list of commits! I've adjusted it with commit\\s[0-9a-f]{40}\\n
and now works perfectly but, since splitting a string with a regexp also
removes the matched expressions, the sha1hash is not present in the
resulting list so I'm waiting to write an elegant solution before committing
:P
* The editor works pretty good, I tried it and works perfectly.
Nice, I see that its now opening the dialog in the project's dir, sweet :)
* The previewer is awesome, but its possible to test it with a fake
package and see if it load it correctly ?
Right now previewer/test can be used to view installed applets. We are
unable to execute an applet currently.
Ok, i think that's all, now i want your opinion/ideas =)
Have a nice day,
Cheers !!!
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Qt Development Frameworks
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
--
Shantanu Tushar(UTC +0530)
http://www.shantanutushar.com
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
