kwin animated show only for windows on all desktops?

[Aaron J. Seigo]

hi ...

i just noticed that kwin's animated show effect only seems to work when i do:

KWindowSystem::setOnAllDesktops(window->winId(), true);

any particular reason for that?

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: forgetten slot defination

[Aaron Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1569/#review2305
---

Ship it!


- Aaron


On 2009-09-11 22:10:15, Omer F. USTA wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1569/
> ---
> 
> (Updated 2009-09-11 22:10:15)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> ---
> 
> checkAvailability must be a slot because it was used by connect(  in 
> plasma-desktop-runner.cpp:45
> QObject::connect(QDBusConnection::sessionBus().interface(), 
> SIGNAL(serviceOwnerChanged(QString,QString,QString)),
>  this, SLOT(checkAvailability(QString,QString,QString)));
> 
> 
> Diffs
> -
> 
>   
> trunk/KDE/kdebase/workspace/plasma/runners/plasma-desktop/plasma-desktop-runner.h
>  1022509 
> 
> Diff: http://reviewboard.kde.org/r/1569/diff
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Omer F.
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: forgetten slot defination

[Omer F. USTA]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1569/
---

(Updated 2009-09-11 22:10:15.009367)


Review request for Plasma and Aaron Seigo.


Summary
---

checkAvailability must be a slot because it was used by connect(  in 
plasma-desktop-runner.cpp:45
QObject::connect(QDBusConnection::sessionBus().interface(), 
SIGNAL(serviceOwnerChanged(QString,QString,QString)),
 this, SLOT(checkAvailability(QString,QString,QString)));


Diffs
-

  
trunk/KDE/kdebase/workspace/plasma/runners/plasma-desktop/plasma-desktop-runner.h
 1022509 

Diff: http://reviewboard.kde.org/r/1569/diff


Testing
---


Thanks,

Omer F.

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: forgetten slot defination

[Omer F. USTA]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1569/
---

Review request for Plasma and Aaron Seigo.


Summary
---

checkAvailability must be a slot because it was used by connect(  in 
plasma-desktop-runner.cpp:45
QObject::connect(QDBusConnection::sessionBus().interface(), 
SIGNAL(serviceOwnerChanged(QString,QString,QString)),
 this, SLOT(checkAvailability(QString,QString,QString)));


This addresses bugs a, be, checkAvailability, instead, method, must, normal, 
of, and slot.
https://bugs.kde.org/show_bug.cgi?id=a
https://bugs.kde.org/show_bug.cgi?id=be
https://bugs.kde.org/show_bug.cgi?id=checkAvailability
https://bugs.kde.org/show_bug.cgi?id=instead
https://bugs.kde.org/show_bug.cgi?id=method
https://bugs.kde.org/show_bug.cgi?id=must
https://bugs.kde.org/show_bug.cgi?id=normal
https://bugs.kde.org/show_bug.cgi?id=of
https://bugs.kde.org/show_bug.cgi?id=slot


Diffs
-

  
trunk/KDE/kdebase/workspace/plasma/runners/plasma-desktop/plasma-desktop-runner.h
 1022509 

Diff: http://reviewboard.kde.org/r/1569/diff


Testing
---


Thanks,

Omer F.

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: big revamp of Device Notifier

[Aaron Seigo]

> On 2009-09-11 19:47:12, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp,
> >  line 87
> > 
> >
> > when is this not the case?
> 
>  wrote:
> i took that piece of code from plasmadelegate.cpp. i suppose when 
> composite is disabled?

no, it doesn't have to do with compositing. alpha() == 0 means that the Base 
color in the Palette is transparent, so this seems to say "if the base color in 
the palette is set, don't paint the svg". i think we can safely discard that 
here. we always want to paint this svg.


- Aaron


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1370/#review2300
---


On 2009-09-11 21:32:17, Giulio Camuffo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1370/
> ---
> 
> (Updated 2009-09-11 21:32:17)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This is a patch that modifies quite heavily the behaviour of the Device 
> Notifier.
> It comes from here: 
> http://kde-look.org/content/show.php/Device+Manager?content=106051
> It can show the not removable devices too, it can mount them automatically or 
> with a click, since the "eject" button is a "mount" button when the volume is 
> umounted. So that guy on the dot will be ok.
> It can hide some items in the same way as Dolphin's places (hide item/ show 
> all).
> Finally, it shows the various opening actions under the device instead of 
> calling that xp-ish window.
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 
> 1022457 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp
>  1022457 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h
>  1022457 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 
> 1022457 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 
> 1022457 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui
>  PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h 
> 1022457 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 
> 1022457 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h 
> 1022457 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 
> 1022457 
> 
> Diff: http://reviewboard.kde.org/r/1370/diff
> 
> 
> Testing
> ---
> 
> I'm using it every day since I released 0.1 on Kde-look. I tried all the 
> options on my pc and they work. Some people on kde-look posted some comments 
> about some problems, but it seems to me they are very particular cases, so in 
> my opinion it is quite stable to go in trunk, but anyway review it! :)
> 
> 
> Screenshots
> ---
> 
> screen
>   http://reviewboard.kde.org/r/1370/s/183/
> 
> 
> Thanks,
> 
> Giulio
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: big revamp of Device Notifier

[Giulio Camuffo]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1370/
---

(Updated 2009-09-11 21:32:17.946758)


Review request for Plasma.


Changes
---

-updated the patch to the latest svn
-using Plasma::Applet::showMessage instead of KMessageBox
-removed hidePopupAfter(int)
-change icon on the insertion of a new device even if the popup is shown
-many others style issues and oversights fixed


Summary
---

This is a patch that modifies quite heavily the behaviour of the Device 
Notifier.
It comes from here: 
http://kde-look.org/content/show.php/Device+Manager?content=106051
It can show the not removable devices too, it can mount them automatically or 
with a click, since the "eject" button is a "mount" button when the volume is 
umounted. So that guy on the dot will be ok.
It can hide some items in the same way as Dolphin's places (hide item/ show 
all).
Finally, it shows the various opening actions under the device instead of 
calling that xp-ish window.


Diffs (updated)
-

  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 
1022457 
  
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp
 1022457 
  
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h
 1022457 
  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 
1022457 
  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 
1022457 
  
/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui 
PRE-CREATION 
  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h 
1022457 
  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 
1022457 
  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h 
1022457 
  /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 
1022457 

Diff: http://reviewboard.kde.org/r/1370/diff


Testing
---

I'm using it every day since I released 0.1 on Kde-look. I tried all the 
options on my pc and they work. Some people on kde-look posted some comments 
about some problems, but it seems to me they are very particular cases, so in 
my opinion it is quite stable to go in trunk, but anyway review it! :)


Screenshots
---

screen
  http://reviewboard.kde.org/r/1370/s/183/


Thanks,

Giulio

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: big revamp of Device Notifier

[Giulio Camuffo]

> On 2009-09-11 19:47:12, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp,
> >  line 87
> > 
> >
> > when is this not the case?

i took that piece of code from plasmadelegate.cpp. i suppose when composite is 
disabled?


- Giulio


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1370/#review2300
---


On 2009-09-01 16:55:56, Giulio Camuffo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1370/
> ---
> 
> (Updated 2009-09-01 16:55:56)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This is a patch that modifies quite heavily the behaviour of the Device 
> Notifier.
> It comes from here: 
> http://kde-look.org/content/show.php/Device+Manager?content=106051
> It can show the not removable devices too, it can mount them automatically or 
> with a click, since the "eject" button is a "mount" button when the volume is 
> umounted. So that guy on the dot will be ok.
> It can hide some items in the same way as Dolphin's places (hide item/ show 
> all).
> Finally, it shows the various opening actions under the device instead of 
> calling that xp-ish window.
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui
>  PRE-CREATION 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h
>  1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp
>  1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 
> 1013960 
> 
> Diff: http://reviewboard.kde.org/r/1370/diff
> 
> 
> Testing
> ---
> 
> I'm using it every day since I released 0.1 on Kde-look. I tried all the 
> options on my pc and they work. Some people on kde-look posted some comments 
> about some problems, but it seems to me they are very particular cases, so in 
> my opinion it is quite stable to go in trunk, but anyway review it! :)
> 
> 
> Screenshots
> ---
> 
> screen
>   http://reviewboard.kde.org/r/1370/s/183/
> 
> 
> Thanks,
> 
> Giulio
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: big revamp of Device Notifier

[Aaron Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1370/#review2300
---



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp


when is this not the case?



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp


{ should be on a new line



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp


{}s even on one-liners



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp


{ should be on a new line


- Aaron


On 2009-09-01 16:55:56, Giulio Camuffo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1370/
> ---
> 
> (Updated 2009-09-01 16:55:56)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This is a patch that modifies quite heavily the behaviour of the Device 
> Notifier.
> It comes from here: 
> http://kde-look.org/content/show.php/Device+Manager?content=106051
> It can show the not removable devices too, it can mount them automatically or 
> with a click, since the "eject" button is a "mount" button when the volume is 
> umounted. So that guy on the dot will be ok.
> It can hide some items in the same way as Dolphin's places (hide item/ show 
> all).
> Finally, it shows the various opening actions under the device instead of 
> calling that xp-ish window.
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui
>  PRE-CREATION 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h
>  1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp
>  1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 
> 1013960 
> 
> Diff: http://reviewboard.kde.org/r/1370/diff
> 
> 
> Testing
> ---
> 
> I'm using it every day since I released 0.1 on Kde-look. I tried all the 
> options on my pc and they work. Some people on kde-look posted some comments 
> about some problems, but it seems to me they are very particular cases, so in 
> my opinion it is quite stable to go in trunk, but anyway review it! :)
> 
> 
> Screenshots
> ---
> 
> screen
>   http://reviewboard.kde.org/r/1370/s/183/
> 
> 
> Thanks,
> 
> Giulio
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: big revamp of Device Notifier

[Aaron Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1370/#review2298
---


is the latest version the most recent available version of the patch? because 
it doesn't apply cleanly to trunk.

anyways ... i really don't like the "how long to show the popup" configuration 
item and the other 2 config items do need seem linguistic and layout 
adjustments, but that's easy to do once this is in. "how long" could remain 
configurable in the config file, but i don't think it belongs in the UI; that's 
just an excuse not to make a good default.

having to click twice for items with one action is not great. instead, when 
there is just one item how about just putting the action description as the 
sub-title text for the main item and launch it on click/select? so it would be:

ICON Camera
ICON Open with Digikam...

in the case of multiple items, it could look like:

ICON USB Storage Device
ICON 2 available actions ...

and when it's clicked then the options show up. it could happen on hover, but 
i'm not sure that makes sense in this case.

if the options could also be made smaller that would also help show that these 
are "detail items that belong to the item above" better IMO; the icon should 
probably only need to be roughly as tall as the line of text?




/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp


the icon should probably change whether or not the popup is shown. this is 
more consistent and gives nice visual cues.



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp


the opening { of methods belongs on its own line



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp


not that it matters much here (not a hot path or a big list) but this would 
probably be more efficient as sth like:

foreach (const QString &name, m_lastPlugged) {
onSourceRemoved(name);
}
m_lastPlugged.clear();

if m_lastPlugged must be reset for onSourceRemoved, then sth like:

QStringList lastPlugged = m_lastPlugged;
m_lastPlugged.clear();
foreach (const QString &name, lastPlugged) {
onSourceRemoved(name);
}



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp


the opening { of methods belongs on its own line



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp


the opening { of methods belongs on its own line



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp


this is only needed if m_showOnlyRemovable changes, correct?



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp


this method is only used once and is a one-liner, it probably could be 
folded back into that location. easier to read than jumping around the sources 
chasing one-liner methods that are rarely used anyways ;)



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp


the opening { of methods belongs on its own line



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp


&& not 'and'



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp


the opening { of methods belongs on its own line



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h


unnecessary newline



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp


replace the tab with 4 four spaces



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp


replace the tab with 4 four spaces



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp


KMessageBox blocks all of plasma when used; use Plasma::Applet::showMessage 
instead.


- Aaron


On 2009-09-01 16:55:56, Giulio Camuffo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1370/
> ---
> 
> (Updated 2009-09-01 16:55:56)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---

Re: Stylesheets and plasma widgets

[Aaron J. Seigo]

On September 11, 2009, Marco Martin wrote:
> but the ones thatreally have to use the proxywidget to paint, like the ones
> that have to layout text there wouldn't be much we can do about (maybe
>  syncing the nativewidget font with the plasma theme one?)

that'd probably be the best we could do...

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Stylesheets and plasma widgets

[Marco Martin]

On Friday 11 September 2009, Aaron J. Seigo wrote:
> On September 11, 2009, Marco Martin wrote:
> > On Friday 11 September 2009, Aaron J. Seigo wrote:
> > > On September 10, 2009, alan moore wrote:
> > > > Thanks; I tried this, but it didn't work (or else I'm doing it
> > > > wrong).
> > >
> > > looking at Plasma::PushButton, it doesn't allow setting the font
> > > directly. it uses the theme's font. it should probably not do so if a
> > > font is set (e.g. receives a FontChange event).. so some work needed in
> > > libplasma
> >
> > yeah, i'm not too happy about font and colors management in plasma..
> > for fonts, now we have:
> >
> > -Plasma::Theme::font(type)
> > -nativeWidget()->font()
> > -QGraphicsWidget::font();
>
> for our widgets that paint their own UI, e.g. pushbuttons, they should
> probably default to Plasma::Theme::font (which itself defaults back to the
> desktop defaults) and use QGraphicsWidget::font() if it has been explicitly
> set. nativeWidget()->font() can probably be ignored unless we're painting
> "native" style.
>
> what do you think?

so:
-use the plasma::teme::font
-at the first fontChange event set a bool and start to use 
QGraphicsWidget::font() instead after that

will do a first patch for the pushbutton and then start to fix the oher 
widgets..
but the ones thatreally have to use the proxywidget to paint, like the ones 
that have to layout text there wouldn't be much we can do about (maybe syncing 
the nativewidget font with the plasma theme one?)

> > now, i'm not sure if QGraphicsProxyWidget::font() is syncronized with
> > nativeWidget()->font(),
>
> afaik it is not.
>
> > but it should be used the one from plasma::teme
> >  unless a font is set, but is it possible at all to know if a non default
> >  font was set?
>
> probably by watching for FontChanged events. see the docu for
> QGraphicsWidget::setFont


-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Stylesheets and plasma widgets

[Aaron J. Seigo]

On September 11, 2009, Marco Martin wrote:
> On Friday 11 September 2009, Aaron J. Seigo wrote:
> > On September 10, 2009, alan moore wrote:
> > > Thanks; I tried this, but it didn't work (or else I'm doing it wrong).
> >
> > looking at Plasma::PushButton, it doesn't allow setting the font
> > directly. it uses the theme's font. it should probably not do so if a
> > font is set (e.g. receives a FontChange event).. so some work needed in
> > libplasma
> 
> yeah, i'm not too happy about font and colors management in plasma..
> for fonts, now we have:
> 
> -Plasma::Theme::font(type)
> -nativeWidget()->font()
> -QGraphicsWidget::font();

for our widgets that paint their own UI, e.g. pushbuttons, they should 
probably default to Plasma::Theme::font (which itself defaults back to the 
desktop defaults) and use QGraphicsWidget::font() if it has been explicitly 
set. nativeWidget()->font() can probably be ignored unless we're painting 
"native" style.

what do you think?

> now, i'm not sure if QGraphicsProxyWidget::font() is syncronized with
> nativeWidget()->font(),

afaik it is not.

> but it should be used the one from plasma::teme
>  unless a font is set, but is it possible at all to know if a non default
>  font was set?

probably by watching for FontChanged events. see the docu for 
QGraphicsWidget::setFont

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: big revamp of Device Notifier

[Aaron Seigo]

On 2009-09-10 18:18:27, Giulio Camuffo wrote:
> > I still don't like the fact that you have to click twice to select the 
> > action if there is only one available action.. we should find a solution 
> > for this..
> 
> Giulio Camuffo wrote:
> I agree.
> Maybe we could show the actions on hover. This would require then a 
> single click, but on the other hand it could be a bit annoying if you have 
> many devices and you have to get to the one on the other side of the applet.
> 
> Michal Dutkiewicz wrote:
> > Maybe we could show the actions on hover.
> 
> What about showing them with delay (so fast mouse move won't trigger 
> showing)?
> 
> Giulio Camuffo wrote:
> This could be a solution, but could make this feature less discoverable
> 
> Michal Dutkiewicz wrote:
> > This could be a solution, but could make this feature less discoverable
> 
> Depends how long is that delay. ;-)
> I think that it could be something like 200 milliseconds, but could be 
> adjusted after some testing.

300ms is the standard we tend to use in Plasma, and this is based on quite a 
bit of testing. having things show just when you move the mouse through them to 
get to something else is visually annoying/tiring, but you don't want to 
"wait". 300ms (just under a 1/3rd of a second) seems to be a fairly "magic" 
compromise that works well.

in any case, i need to download and try the latest version of this patch to see 
how it's going will do so today.


- Aaron


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1370/#review2266
---


On 2009-09-01 16:55:56, Giulio Camuffo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1370/
> ---
> 
> (Updated 2009-09-01 16:55:56)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This is a patch that modifies quite heavily the behaviour of the Device 
> Notifier.
> It comes from here: 
> http://kde-look.org/content/show.php/Device+Manager?content=106051
> It can show the not removable devices too, it can mount them automatically or 
> with a click, since the "eject" button is a "mount" button when the volume is 
> umounted. So that guy on the dot will be ok.
> It can hide some items in the same way as Dolphin's places (hide item/ show 
> all).
> Finally, it shows the various opening actions under the device instead of 
> calling that xp-ish window.
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui
>  PRE-CREATION 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h
>  1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp
>  1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 
> 1013960 
> 
> Diff: http://reviewboard.kde.org/r/1370/diff
> 
> 
> Testing
> ---
> 
> I'm using it every day since I released 0.1 on Kde-look. I tried all the 
> options on my pc and they work. Some people on kde-look posted some comments 
> about some problems, but it seems to me they are very particular cases, so in 
> my opinion it is quite stable to go in trunk, but anyway review it! :)
> 
> 
> Screenshots
> ---
> 
> screen
>   http://reviewboard.kde.org/r/1370/s/183/
> 
> 
> Thanks,
> 
> Giulio
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: big revamp of Device Notifier

[Gilles CHAUVIN]

---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1370/#review2289
---



/trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui


Just my 2 cents: s/insterted/inserted/


- Gilles


On 2009-09-01 16:55:56, Giulio Camuffo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1370/
> ---
> 
> (Updated 2009-09-01 16:55:56)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This is a patch that modifies quite heavily the behaviour of the Device 
> Notifier.
> It comes from here: 
> http://kde-look.org/content/show.php/Device+Manager?content=106051
> It can show the not removable devices too, it can mount them automatically or 
> with a click, since the "eject" button is a "mount" button when the volume is 
> umounted. So that guy on the dot will be ok.
> It can hide some items in the same way as Dolphin's places (hide item/ show 
> all).
> Finally, it shows the various opening actions under the device instead of 
> calling that xp-ish window.
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui
>  PRE-CREATION 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h
>  1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp
>  1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 
> 1013960 
> 
> Diff: http://reviewboard.kde.org/r/1370/diff
> 
> 
> Testing
> ---
> 
> I'm using it every day since I released 0.1 on Kde-look. I tried all the 
> options on my pc and they work. Some people on kde-look posted some comments 
> about some problems, but it seems to me they are very particular cases, so in 
> my opinion it is quite stable to go in trunk, but anyway review it! :)
> 
> 
> Screenshots
> ---
> 
> screen
>   http://reviewboard.kde.org/r/1370/s/183/
> 
> 
> Thanks,
> 
> Giulio
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: big revamp of Device Notifier

[Michal Dutkiewicz]

On 2009-09-10 18:18:27, Giulio Camuffo wrote:
> > I still don't like the fact that you have to click twice to select the 
> > action if there is only one available action.. we should find a solution 
> > for this..
> 
> Giulio Camuffo wrote:
> I agree.
> Maybe we could show the actions on hover. This would require then a 
> single click, but on the other hand it could be a bit annoying if you have 
> many devices and you have to get to the one on the other side of the applet.
> 
> Michal Dutkiewicz wrote:
> > Maybe we could show the actions on hover.
> 
> What about showing them with delay (so fast mouse move won't trigger 
> showing)?
> 
> Giulio Camuffo wrote:
> This could be a solution, but could make this feature less discoverable

> This could be a solution, but could make this feature less discoverable

Depends how long is that delay. ;-)
I think that it could be something like 200 milliseconds, but could be adjusted 
after some testing.


- Michal


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1370/#review2266
---


On 2009-09-01 16:55:56, Giulio Camuffo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1370/
> ---
> 
> (Updated 2009-09-01 16:55:56)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This is a patch that modifies quite heavily the behaviour of the Device 
> Notifier.
> It comes from here: 
> http://kde-look.org/content/show.php/Device+Manager?content=106051
> It can show the not removable devices too, it can mount them automatically or 
> with a click, since the "eject" button is a "mount" button when the volume is 
> umounted. So that guy on the dot will be ok.
> It can hide some items in the same way as Dolphin's places (hide item/ show 
> all).
> Finally, it shows the various opening actions under the device instead of 
> calling that xp-ish window.
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui
>  PRE-CREATION 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h
>  1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp
>  1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 
> 1013960 
> 
> Diff: http://reviewboard.kde.org/r/1370/diff
> 
> 
> Testing
> ---
> 
> I'm using it every day since I released 0.1 on Kde-look. I tried all the 
> options on my pc and they work. Some people on kde-look posted some comments 
> about some problems, but it seems to me they are very particular cases, so in 
> my opinion it is quite stable to go in trunk, but anyway review it! :)
> 
> 
> Screenshots
> ---
> 
> screen
>   http://reviewboard.kde.org/r/1370/s/183/
> 
> 
> Thanks,
> 
> Giulio
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: big revamp of Device Notifier

[Giulio Camuffo]

> On 2009-09-10 18:18:27, Jacopo De Simoi wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp,
> >  line 194
> > 
> >
> > May I ask why do you need to go backward?
> 
>  wrote:
> Sincerely, I don't know. I changed this months ago and I don't remember 
> why. But now i tried to revert it and it seems to work anyway. 
> I really should comment more the code!

i noticed now that after i modified the cycle to go forward the button to mount 
or eject the volume is printed on the row under the device. 
this happens because going forward the view calculates the rect of the device 
item, than the ones of its actions. But the actions are painted under the 
device, so when it starts calculating the button, it puts it under them because 
the actions increase the verticalOffset' s value.
Calculating the button' s rect first and then the devices' and their actions' 
solves this.


On 2009-09-10 18:18:27, Giulio Camuffo wrote:
> > I still don't like the fact that you have to click twice to select the 
> > action if there is only one available action.. we should find a solution 
> > for this..
> 
> Giulio Camuffo wrote:
> I agree.
> Maybe we could show the actions on hover. This would require then a 
> single click, but on the other hand it could be a bit annoying if you have 
> many devices and you have to get to the one on the other side of the applet.
> 
> Michal Dutkiewicz wrote:
> > Maybe we could show the actions on hover.
> 
> What about showing them with delay (so fast mouse move won't trigger 
> showing)?

This could be a solution, but could make this feature less discoverable


- Giulio


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1370/#review2266
---


On 2009-09-01 16:55:56, Giulio Camuffo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1370/
> ---
> 
> (Updated 2009-09-01 16:55:56)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This is a patch that modifies quite heavily the behaviour of the Device 
> Notifier.
> It comes from here: 
> http://kde-look.org/content/show.php/Device+Manager?content=106051
> It can show the not removable devices too, it can mount them automatically or 
> with a click, since the "eject" button is a "mount" button when the volume is 
> umounted. So that guy on the dot will be ok.
> It can hide some items in the same way as Dolphin's places (hide item/ show 
> all).
> Finally, it shows the various opening actions under the device instead of 
> calling that xp-ish window.
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui
>  PRE-CREATION 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h
>  1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp
>  1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 
> 1013960 
> 
> Diff: http://reviewboard.kde.org/r/1370/diff
> 
> 
> Testing
> ---
> 
> I'm using it every day since I released 0.1 on Kde-look. I tried all the 
> options on my pc and they work. Some people on kde-look posted some comments 
> about some problems, but it seems to me they are very particular cases, so in 
> my opinion it is quite stable to go in trunk, but anyway review it! :)
> 
> 
> Screenshots
> ---
> 
> screen
>   http://reviewboard.kde.org/r/1370/s/183/
> 
> 
> Thanks,
> 
> Giulio
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: big revamp of Device Notifier

[Matthew Dawson]

On Friday 11 September 2009 05:56:52 Giulio Camuffo wrote:
> 
> > On 2009-09-10 18:18:27, Jacopo De Simoi wrote:
> > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui,
> > >  line 63
> > > 
> > >
> > > I am not a native speaker either.. but this "the" seems strange to me
> 
> well, i tried with google translate but it leaves me quite confused: 
> http://translate.google.it/translate_t?hl=it&ie=UTF-8&text=mostra+le+periferiche+rimovibili&sl=it&tl=en#it|en|mostra%20anche%20le%20periferiche%20rimovibili
>  and 
> http://translate.google.it/translate_t?hl=it&ie=UTF-8&text=mostra+le+periferiche+rimovibili&sl=it&tl=en#it|en|mostra%20le%20periferiche%20rimovibili.
>  I suppose we need to wait for a native speaker :)
> 
IMH(native speaker's)O, that "the" should not be there, as it makes it sound 
like there is only one particular removable device that the user wishes to be 
shown.


Matthew


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Stylesheets and plasma widgets

[Marco Martin]

On Friday 11 September 2009, Aaron J. Seigo wrote:
> On September 10, 2009, alan moore wrote:
> > Thanks; I tried this, but it didn't work (or else I'm doing it wrong).
>
> looking at Plasma::PushButton, it doesn't allow setting the font directly.
> it uses the theme's font. it should probably not do so if a font is set
> (e.g. receives a FontChange event).. so some work needed in libplasma
yeah, i'm not too happy about font and colors management in plasma..
for fonts, now we have:

-Plasma::Theme::font(type)
-nativeWidget()->font()
-QGraphicsWidget::font();

i think it's quite important to define what should be used and when and then 
go hunting all widgets in libplasma and do the right thing (tm)

now, i'm not sure if QGraphicsProxyWidget::font() is syncronized with 
nativeWidget()->font(), but it should be used the one from plasma::teme unless 
a font is set, but is it possible at all to know if a non default font was 
set? font() will always return a QFont copy, soo, comparing some attributes 
like family and size with QApplication::font?


Cheers,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: more info on the TaskGroupItem crash

[David Faure]

On Friday 11 September 2009, Aaron J. Seigo wrote:
> On September 10, 2009, David Faure wrote:
> > I finally took the time to investigate the plasma crash that was
> > happening so often to me.
> 
> can you try the attached patch? thanks.

It definitely hits this code path often...

QGraphicsScene::removeItem: item 0x2e2c360's scene (0x0) is different from this 
scene (0x260efa0)
plasma-desktop(12139)/plasma TaskItemLayout::insert: error
QGraphicsScene::removeItem: item 0x316feb0's scene (0x0) is different from this 
scene (0x260efa0)
plasma-desktop(12139)/plasma TaskItemLayout::insert: error
QGraphicsScene::removeItem: item 0x2bdf3d0's scene (0x0) is different from this 
scene (0x260efa0)
plasma-desktop(12139)/plasma TaskItemLayout::insert: error

in just 30 minutes.


btw, unrelated, but while I'm here:
QObject::connect: No such signal 
SystemTray::Manager::jobStateChanged(SystemTray::Job*) in 
/d/kde/src/4/kdebase/workspace/plasma/applets/systemtray/core/extendertask.cpp:67
  

-- 
David Faure, fa...@kde.org, sponsored by Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: more info on the TaskGroupItem crash

[David Faure]

On Friday 11 September 2009, Aaron J. Seigo wrote:
> On September 10, 2009, David Faure wrote:
> > I finally took the time to investigate the plasma crash that was
> > happening so often to me.
> 
> can you try the attached patch? thanks.

The patch fits exactly my analysis of the problem, but it looks a bit...
hackish to me. Isn't there a way to make sure the item is "forgotten"
from whatever knows about it, so that it doesn't get inserted back into the 
layout? Marking it as "deleted" seems. well... it's your code so it's your 
call, but I'm a bit surprised ;)

-- 
David Faure, fa...@kde.org, sponsored by Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: big revamp of Device Notifier

[Michal Dutkiewicz]

On 2009-09-10 18:18:27, Giulio Camuffo wrote:
> > I still don't like the fact that you have to click twice to select the 
> > action if there is only one available action.. we should find a solution 
> > for this..
> 
> Giulio Camuffo wrote:
> I agree.
> Maybe we could show the actions on hover. This would require then a 
> single click, but on the other hand it could be a bit annoying if you have 
> many devices and you have to get to the one on the other side of the applet.

> Maybe we could show the actions on hover.

What about showing them with delay (so fast mouse move won't trigger showing)?


- Michal


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1370/#review2266
---


On 2009-09-01 16:55:56, Giulio Camuffo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1370/
> ---
> 
> (Updated 2009-09-01 16:55:56)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This is a patch that modifies quite heavily the behaviour of the Device 
> Notifier.
> It comes from here: 
> http://kde-look.org/content/show.php/Device+Manager?content=106051
> It can show the not removable devices too, it can mount them automatically or 
> with a click, since the "eject" button is a "mount" button when the volume is 
> umounted. So that guy on the dot will be ok.
> It can hide some items in the same way as Dolphin's places (hide item/ show 
> all).
> Finally, it shows the various opening actions under the device instead of 
> calling that xp-ish window.
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui
>  PRE-CREATION 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h
>  1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp
>  1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 
> 1013960 
> 
> Diff: http://reviewboard.kde.org/r/1370/diff
> 
> 
> Testing
> ---
> 
> I'm using it every day since I released 0.1 on Kde-look. I tried all the 
> options on my pc and they work. Some people on kde-look posted some comments 
> about some problems, but it seems to me they are very particular cases, so in 
> my opinion it is quite stable to go in trunk, but anyway review it! :)
> 
> 
> Screenshots
> ---
> 
> screen
>   http://reviewboard.kde.org/r/1370/s/183/
> 
> 
> Thanks,
> 
> Giulio
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: big revamp of Device Notifier

[Giulio Camuffo]

> On 2009-09-10 18:18:27, Jacopo De Simoi wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui,
> >  line 63
> > 
> >
> > I am not a native speaker either.. but this "the" seems strange to me

well, i tried with google translate but it leaves me quite confused: 
http://translate.google.it/translate_t?hl=it&ie=UTF-8&text=mostra+le+periferiche+rimovibili&sl=it&tl=en#it|en|mostra%20anche%20le%20periferiche%20rimovibili
 and 
http://translate.google.it/translate_t?hl=it&ie=UTF-8&text=mostra+le+periferiche+rimovibili&sl=it&tl=en#it|en|mostra%20le%20periferiche%20rimovibili.
 I suppose we need to wait for a native speaker :)


> On 2009-09-10 18:18:27, Jacopo De Simoi wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp,
> >  line 194
> > 
> >
> > May I ask why do you need to go backward?

Sincerely, I don't know. I changed this months ago and I don't remember why. 
But now i tried to revert it and it seems to work anyway. 
I really should comment more the code!


> On 2009-09-10 18:18:27, Jacopo De Simoi wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp,
> >  line 342
> > 
> >
> > ManagerDialog should be NotifierDialog i suppose, here
> >

yes, a little oversight.


On 2009-09-10 18:18:27, Giulio Camuffo wrote:
> > I still don't like the fact that you have to click twice to select the 
> > action if there is only one available action.. we should find a solution 
> > for this..

I agree.
Maybe we could show the actions on hover. This would require then a single 
click, but on the other hand it could be a bit annoying if you have many 
devices and you have to get to the one on the other side of the applet.


- Giulio


---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1370/#review2266
---


On 2009-09-01 16:55:56, Giulio Camuffo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1370/
> ---
> 
> (Updated 2009-09-01 16:55:56)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> ---
> 
> This is a patch that modifies quite heavily the behaviour of the Device 
> Notifier.
> It comes from here: 
> http://kde-look.org/content/show.php/Device+Manager?content=106051
> It can show the not removable devices too, it can mount them automatically or 
> with a click, since the "eject" button is a "mount" button when the volume is 
> umounted. So that guy on the dot will be ok.
> It can hide some items in the same way as Dolphin's places (hide item/ show 
> all).
> Finally, it shows the various opening actions under the device instead of 
> calling that xp-ish window.
> 
> 
> Diffs
> -
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui
>  PRE-CREATION 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h
>  1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp
>  1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 
> 1013960 
>   
> /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h 
> 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 
> 1013960 
> 
> Diff: http://reviewboard.kde.org/r/1370/diff
> 
> 
> Testing
> ---
> 
> I'm using it every day since I released 0.1 on Kde-look. I tried all the 
> options on my pc and they work. Some people on kde-look posted some comments 
> about some problems, but it seems to me they are very particular cases, so in 
> my opinion it is quite stable to go in trunk, but anyway review it! :)
> 
> 
> Screenshots
> ---
> 
> screen
>   http://reviewboard.kde.org/r/1370/s/183/
> 
> 
> Thanks,
> 
> Giulio
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Knowledgebase plasmoid in kdeplasma-addons

[Marco Martin]

Hi all,
it's a while the knowledge base plasmoid (used to query the opendesktop.org 
knowledge base) is in kdereview.
i plan to move it now in kdeplasmaaddons.
is it ok? any objections?

Cheers,
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: RunnerManager: Whitelist enforcement (bugfix)

[Ivan Čukić]

> so setAllowedPlugins probably needs to store its list in a separate key and
> compare against it first. will commit a patch shortly.
> 

OK, I'll cancel the review request
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Re: Plasmate previewer, again =P

[Diego Casella ([Po]lentino)]

>
> -- Messaggio inoltrato --
> From: Shantanu Tushar Jha 
> To: plasma-devel@kde.org
> Date: Fri, 11 Sep 2009 09:53:37 +0530
> Subject: Re: Re: Plasmate previewer, again =P
>
>
>>- Green flag: package signed by both KDE and the developer ( =
>>completely trusted );
>>- Blue flag: package signed by KDE, but not by the developer;
>>- Yellow flag: package signed by the developer, but not by KDE;
>>- Red flag: package is not signed ( = install it at your own risk ).
>>
>> How is it known that a package is signed by KDE? Is there some existing
> mechanism or it has to be worked on?
>

This is a new feature, so we have to work on it, sooner or later :P

>
>
>>
>> * The editor works pretty good, I tried it and works perfectly.
>>
> Nice, I see that its now opening the dialog in the project's dir, sweet :)
>

Yes, its a tiny improvement I made some time ago =)
It should also load the project name in the title bar iirc, but when opening
the editor, it disappear ... I have to investigate also on this !

>
>
>> * The previewer is awesome, but its possible to test it with a "fake"
>> package and see if it load it correctly ?
>>
> Right now previewer/test can be used to view installed applets. We are
> unable to "execute" an applet currently.
>
>
>> Ok, i think that's all, now i want your opinion/ideas =)
>> Have a nice day,
>>
>> Cheers !!!
>>
>> --
>>> Aaron J. Seigo
>>> humru othro a kohnu se
>>> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>>>
>>> KDE core developer sponsored by Qt Development Frameworks
>>>
>>
>> ___
>> Plasma-devel mailing list
>> Plasma-devel@kde.org
>> https://mail.kde.org/mailman/listinfo/plasma-devel
>>
>>
>
>
> --
> Shantanu Tushar(UTC +0530)
> http://www.shantanutushar.com
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Kickoff Krunner whitelist

[Ivan Čukić]

> 1.  Keyboard navigation of the search results appears to have broken,
> can you please have a look at that.
The only thing changed is the data model. Do you have any idea how that could 
screw up the keybd nav?

> 2.  The search results for applications now take longer to appear than
> they used to by a third to half a second.
Changed the delay to 1/20 sec

> 3.  What controls the sorting of the results?
KRunner rating

cheers
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Plasmate previewer, again =P

[Yuen Hoe Lim]

> Right now previewer/test can be used to view installed applets. We are
> unable to "execute" an applet currently.
>
>
 We can, at least for plasmoids :) The previewer class has a method that
takes a system path, which 'executes' non-installed plasmoids from source.



Jason "moofang" Lim Yuen Hoe
http://yuenhoe.co.cc/
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma-devel Digest, Vol 15, Issue 25

[Diego Casella ([Po]lentino)]

>
> -- Messaggio inoltrato --
> From: Yuen Hoe Lim 
> To: plasma-devel@kde.org
> Date: Fri, 11 Sep 2009 10:56:09 +0800
> Subject: Re: Plasmate previewer, again =P
> >> * The previewer is awesome, but its possible to test it with a "fake"
> >> package and see if it load it correctly ?
>
> > can you try it on a real package loaded in plasmate?
>
> Back awhile I tried pointing it to some of my plasmoid source code before
> and it worked, so assuming the timeline/git mechanism stores the packages in
> identical format it should just be a matter of passing in the path as
> argument :P
>

Good :)

>
> I'm a little lost with the other stuff though. Will do some ploughing
> through the current code this weekend :)
>
> 
> Jason "moofang" Lim Yuen Hoe
> http://yuenhoe.co.cc/
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Plasmate previewer, again =P

[Diego Casella ([Po]lentino)]

>
> -- Messaggio inoltrato --
> From: "Aaron J. Seigo" 
> To: plasma-devel@kde.org
> Date: Thu, 10 Sep 2009 16:53:48 -0600
> Subject: Re: Plasmate previewer, again =P
> On September 10, 2009, Diego Casella ([Po]lentino) wrote:
> > > -- Messaggio inoltrato --
> > > From: "Aaron J. Seigo" 
> > > To: plasma-devel@kde.org
> > > Date: Thu, 10 Sep 2009 11:23:26 -0600
> > > Subject: Re: Plasmate previewer, again =P
> > >
> > > On September 10, 2009, Shantanu Tushar Jha wrote:
> > > > As we could not have the meeting on that time as Diego and Aaron were
> > >
> > > busy
> > >
> > > > at Tokamak,
> > >
> > > actually, we showed up on irc at the stated time and waited around ...
> :/
> >
> > yup ...
> >
> > > > It'll be nice to have some status update. Diego what things are
> > > > remaining to be implemented, i.e. which were planned but are not yet
> > > > implemented?
> > >
> > > we put together a really short list of "things to do next"; Diego, do
> you
> > > have
> > > that still?
> > >
> > > Of course !
> >
> > Since up to now the code structure is not as good as we want, the basic
> >  idea was to build a core class that handles our UI stuff, a
> ProjectManager
> >  class to create/load projects and keep track of its files, and other
> >  stuffs. As soon as everything works well, first we have to provide a
> >  secure way to upload the package ( the idea is to use QCA to sign the
> >  package ); second, that is, when an user download a package from our
> >  server, we have to alert the user with one of these signals ( iirc :P ):
> >
> >- Green flag: package signed by both KDE and the developer ( =
> >  completely trusted );
> >- Blue flag: package signed by KDE, but not by the developer;
> >- Yellow flag: package signed by the developer, but not by KDE;
> >- Red flag: package is not signed ( = install it at your own risk ).
> >
> > Also, some improvements on Plasma::PackageMetadata should be done ( if
> >  there are no issues with BC ):
> >
> >- Made method's name more coherent ( for example, if the entry we want
> >  to retrieve is "X-KDE-PluginInfo-Name" and the getter is called
> >  "PluginName()", why the setter is named "setName()" ? it should be
> >  "setPluginName()" ! )
>
> it is setPluginName().
>

Ops, you are right ! These days my brain is completely screwed up ...
The funny part is I used both of them in my code =P

>
> >  ; - extend the API in order to handle more entries (
> >  for example, up to now there is no API call to write the
> >  "X-Plasma-MainScript" entry, so i'm forced to use QFile to open the
> >  metadata.desktop file, and then append that string manually O_o )
>
> that probably belongs either in a subclass or via a
> PackageMetaData::setProperty(const QString &key, const QVariant &value)
> method
> since X-Plasma-MainScript is specific to plasmoid scripting and not to
> packages in general.
>
> > * At present, the TimeLine is broken again because the regexp fix made @
> > Tokamak was wrong: in fact the regexp "^commit [0-9a-ef]+$" always
> returns
> > the entire list of commits! I've adjusted it with
>
> hm. try setMinimal(true) on the QRegExp object.
>
> as for the sha1 hash, try:
>
> "^commit ([0-9a-f])+$"
>
> and then you can use QRegExp::cap(int), and use a while loop like the one
> in
> the QRegExp docu:
>
> while ((pos = rx.indexIn(str, pos)) != -1) {
> list << rx.cap(1);
> pos += rx.matchedLength();
>  }
>
> and cut up the list as you go.
>

Ok, I'll try it as soon as possible =)

>
> > * The editor works pretty good, I tried it and works perfectly.
>
> great :)
>
> > * The previewer is awesome, but its possible to test it with a "fake"
> > package and see if it load it correctly ?
>
> can you try it on a real package loaded in plasmate?
>

I'll have a look !

>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Qt Development Frameworks
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel