Re: Review Request: Launcher support for libtaskmanager
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4585/#review6469 --- Um, I think that was done by accident: /kdebase/workspace/libs/taskmanager/launcheritem.h is GPL while /kdebase/workspace/libs/taskmanager/launcheritem.cpp is under a BSD license. Shouldn't both be BSDL'ed? - Markus On 2010-07-10 17:21:34, Anton Kreuzkamp wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4585/ --- (Updated 2010-07-10 17:21:34) Review request for Plasma. Summary --- Adds support for Windows 7 like launchers in libtaskmanager. (I'm on holliday from 12th July until 1st August so I will not be able to reply during this time.) Diffs - /trunk/KDE/kdebase/workspace/libs/taskmanager/taskitem.h 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/taskgroup.h 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/strategies/programgroupingstrategy.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.cpp PRE-CREATION /trunk/KDE/kdebase/workspace/libs/taskmanager/launcheritem.h PRE-CREATION /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/groupmanager.h 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractgroupableitem.h 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/abstractsortingstrategy.cpp 1148442 /trunk/KDE/kdebase/workspace/libs/taskmanager/CMakeLists.txt 1148442 Diff: http://reviewboard.kde.org/r/4585/diff Testing --- Tested with a small test-applett and everything works. Thanks, Anton ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adds support for corner widgets in Plasma::TabBar
On 2010-07-10 14:32:16, Marco Martin wrote: trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp, line 620 http://reviewboard.kde.org/r/4537/diff/2/?file=30620#file30620line620 should change the widget ownership to TabBar and delete any old one that was already existing Shouldn't the ownership be already taken by the layout? I don't think it should delete the old widget. If i was doing an applet with this i may want to have a new tab button only when the immutability is Mutable. And i don't think that deleting and recreating the widget again and again would be so clean. - Giulio --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4537/#review6466 --- On 2010-07-10 14:26:41, Giulio Camuffo wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4537/ --- (Updated 2010-07-10 14:26:41) Review request for Plasma and Marco Martin. Summary --- This patch adds two methods that allow to put two QGraphicsWidget in the top left and top right corner of the tab bar, like it is possible with QTabWidget. Diffs - trunk/KDE/kdelibs/plasma/widgets/tabbar.h 1147219 trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp 1147219 Diff: http://reviewboard.kde.org/r/4537/diff Testing --- Tested, it works, but there's one thing that annoys me and I don't how to solve in a clean way: when there are no tabs the NativeTabBar becomes a bit smaller in height and the widgets resize accordingly. Screenshots --- added two Plasma::PushButton http://reviewboard.kde.org/r/4537/s/446/ Thanks, Giulio ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [kde-promo] Plasma Calendar showing Akonadi Events in SC 4.5
On Wednesday, 2010-07-07, John Layt wrote: I've been chatting to the kdepim guys about the bugs in the plasma calendar when showing pim events. While I'm on track to fix those today, a more basic issue has appeared. The plasma calendar uses Akonadi to obtain the calendar data. Calendar data is being akonadi-fied for the first time in kdepim 4.5. kdepim 4.5 has been delayed and will not ship with the rest of SC 4.5. Hence most users will not even see the calendar events displayed as their data will not have been migrated and they do not have the compatibility layer enabled. The part of the migration where Akonadi gets access to the same files used by KResource applications should be enabled already (since 4.2 or 4.3 IIRC). The disabled part if the creation of application side compatibility plugins. E.g. KOrganizer writing into the default calendar file through KResources should be detected by Akonadi's Personal Calendar Resource. Probably not instantanious though. This becomes a comms issue. If we announce the feature in the release plan then we will get bug reports for it not working and disappointed users. We need to either not announce the feature at all, or make it very clear that this will only work when kdepim 4.5 is released which may be several months. Right. Even if Akonadi has access to the same data, it might do so slightly different and thus not give the fully integrated experience. Cheers, Kevin -- Kevin Krammer, KDE developer, xdg-utils developer KDE user support, developer mentoring signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: broken plasma setup
On Sunday 04 July 2010, Jos Poortvliet wrote: dudes and dudettes, I dunno how much this helps but here's a set of config files which results in this pretty picture: http://img205.imageshack.us/img205/1427/67445608.png The user could only get out of it by deleting the config :( I hope these files can help fix this?!? Cheers, Jos it -should- be fixed in trunk and 4.5 branch, can somebody confirm this with a recent chackout? (no, rc2 is too old :)) Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: IRC meeting: point of what was done at akademy
On Sun 11 July 2010 7:32:14 am Chani wrote: On Saturday, July 10, 2010 03:41:47 am Marco Martin wrote: On Saturday 10 July 2010, Aaron J. Seigo wrote: On July 9, 2010, Marco Martin wrote: oh, fsck, scrap that: i remembered that 90% i'll be away 16-17-18 :/ 15th? gives ryan a day to recuperate and a day before you leave? if it's ok for other people would be perfect :) thursday the 15th? sure :) your thursday morning is vancouver's wednesday night, it should be easy for me to stay up late then. +1 WORKSFORME :) You people have made me worse of a night owl than I was two weeks ago anyways :P -- Ryan Rix == http://hackersramblings.wordpress.com | http://rix.si/ == == http://rix.si/page/contact/ if you need a word == ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add external loader support to Plasma::Applet, Plasma::DataEngine, Plasma::Service
On 2010-07-10 08:00:51, Aaron Seigo wrote: trunk/KDE/kdelibs/plasma/pluginloader.h, lines 31-41 http://reviewboard.kde.org/r/4554/diff/1/?file=30585#file30585line31 a few issues here: the name of the file and the name of the class don't match. it's also missing the PLASMA_EXPORT macro which is why you can't see it outside of liblasma. but i don't think we need PluginLoaderManager in any case. setPluginLoader and pluginLoader could just as easily be static methods in ExternalPluginLoader with just one static pointer in ExternalPluginLoader::Private. the only advantage i can think of for having a full-blown manager is to offer an easy way eventually to layer multiple loaders. i'm not sure that's even a feature we want, and if we do end up wanting it we can add that fairly easily without a manager as well (or add a manager then and change the implements of ExternalPluginLoader::setPluginLoader() to use that internally) Seems reasonable... I assume that I have to use K_GLOBAL_STATIC on the ExternalPluginLoader class then, to make the static members available? The build is currently failing: [ 84%] Building CXX object plasma/CMakeFiles/plasma.dir/externalpluginloader.o /home/rrix/dev/trunk/kdelibs/plasma/externalpluginloader.cpp:34: error: ‘externalPluginLoaderSingleton’ has not been declared /home/rrix/dev/trunk/kdelibs/plasma/externalpluginloader.cpp:35: error: expected constructor, destructor, or type conversion before ‘}’ token make[2]: *** [plasma/CMakeFiles/plasma.dir/externalpluginloader.o] Error 1 make[1]: *** [plasma/CMakeFiles/plasma.dir/all] Error 2 make: *** [all] Error 2 I'll upload the current diff. - Ryan --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4554/#review6457 --- On 2010-07-09 10:11:58, Ryan Rix wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4554/ --- (Updated 2010-07-09 10:11:58) Review request for Plasma, Aaron Seigo and Shaun Reich. Summary --- Adds ability for applications which embed plasma to specify a class which plasma will query for Applet, DataEngine, and Service creation, giving them the chance to create these objects internally. The foremost use of this is to give Plasma the chance to ask applications when restoring layouts from disk, for applets which were based on QWidgets, such as the case in various Plasma dashboards which may embed QWidgets as plasma::applets Diffs - trunk/KDE/kdelibs/plasma/CMakeLists.txt 1146180 trunk/KDE/kdelibs/plasma/applet.cpp 1146180 trunk/KDE/kdelibs/plasma/dataenginemanager.cpp 1146180 trunk/KDE/kdelibs/plasma/externalpluginloader.h PRE-CREATION trunk/KDE/kdelibs/plasma/pluginloader.h PRE-CREATION trunk/KDE/kdelibs/plasma/pluginloader.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/service.cpp 1146180 Diff: http://reviewboard.kde.org/r/4554/diff Testing --- Well, this thing is about 90% there right now, everything works, etc, afaict, but I can't get the instance of the PluginManager outside of the Plasma namespace, if someone could help that would be great. :) I can commit some support into trunk/playground/base/shells/kpart Thanks, Ryan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add external loader support to Plasma::Applet, Plasma::DataEngine, Plasma::Service
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4554/ --- (Updated 2010-07-11 17:04:28.665791) Review request for Plasma, Aaron Seigo, Robert Marmorstein, and Shaun Reich. Changes --- Hur dur, my patch was more broken than I meant to upload, let's try again. Sorry for the noise Summary --- Adds ability for applications which embed plasma to specify a class which plasma will query for Applet, DataEngine, and Service creation, giving them the chance to create these objects internally. The foremost use of this is to give Plasma the chance to ask applications when restoring layouts from disk, for applets which were based on QWidgets, such as the case in various Plasma dashboards which may embed QWidgets as plasma::applets Diffs (updated) - trunk/KDE/kdelibs/plasma/CMakeLists.txt 1146180 trunk/KDE/kdelibs/plasma/applet.cpp 1146180 trunk/KDE/kdelibs/plasma/dataenginemanager.cpp 1146180 trunk/KDE/kdelibs/plasma/externalpluginloader.h PRE-CREATION trunk/KDE/kdelibs/plasma/externalpluginloader.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/service.cpp 1146180 Diff: http://reviewboard.kde.org/r/4554/diff Testing --- Well, this thing is about 90% there right now, everything works, etc, afaict, but I can't get the instance of the PluginManager outside of the Plasma namespace, if someone could help that would be great. :) I can commit some support into trunk/playground/base/shells/kpart Thanks, Ryan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add external loader support to Plasma::Applet, Plasma::DataEngine, Plasma::Service
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4554/ --- (Updated 2010-07-11 16:57:38.178690) Review request for Plasma, Aaron Seigo, Robert Marmorstein, and Shaun Reich. Changes --- Sorry I forgot to add you, Robert. :) Summary --- Adds ability for applications which embed plasma to specify a class which plasma will query for Applet, DataEngine, and Service creation, giving them the chance to create these objects internally. The foremost use of this is to give Plasma the chance to ask applications when restoring layouts from disk, for applets which were based on QWidgets, such as the case in various Plasma dashboards which may embed QWidgets as plasma::applets Diffs - trunk/KDE/kdelibs/plasma/CMakeLists.txt 1146180 trunk/KDE/kdelibs/plasma/applet.cpp 1146180 trunk/KDE/kdelibs/plasma/dataenginemanager.cpp 1146180 trunk/KDE/kdelibs/plasma/externalpluginloader.h PRE-CREATION trunk/KDE/kdelibs/plasma/externalpluginloader.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/service.cpp 1146180 Diff: http://reviewboard.kde.org/r/4554/diff Testing --- Well, this thing is about 90% there right now, everything works, etc, afaict, but I can't get the instance of the PluginManager outside of the Plasma namespace, if someone could help that would be great. :) I can commit some support into trunk/playground/base/shells/kpart Thanks, Ryan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Add external loader support to Plasma::Applet, Plasma::DataEngine, Plasma::Service
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4554/ --- (Updated 2010-07-11 16:57:12.494120) Review request for Plasma, Aaron Seigo and Shaun Reich. Changes --- Changes per aseigo's comments Summary --- Adds ability for applications which embed plasma to specify a class which plasma will query for Applet, DataEngine, and Service creation, giving them the chance to create these objects internally. The foremost use of this is to give Plasma the chance to ask applications when restoring layouts from disk, for applets which were based on QWidgets, such as the case in various Plasma dashboards which may embed QWidgets as plasma::applets Diffs (updated) - trunk/KDE/kdelibs/plasma/CMakeLists.txt 1146180 trunk/KDE/kdelibs/plasma/applet.cpp 1146180 trunk/KDE/kdelibs/plasma/dataenginemanager.cpp 1146180 trunk/KDE/kdelibs/plasma/externalpluginloader.h PRE-CREATION trunk/KDE/kdelibs/plasma/externalpluginloader.cpp PRE-CREATION trunk/KDE/kdelibs/plasma/service.cpp 1146180 Diff: http://reviewboard.kde.org/r/4554/diff Testing --- Well, this thing is about 90% there right now, everything works, etc, afaict, but I can't get the instance of the PluginManager outside of the Plasma namespace, if someone could help that would be great. :) I can commit some support into trunk/playground/base/shells/kpart Thanks, Ryan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adds support for corner widgets in Plasma::TabBar
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4537/ --- (Updated 2010-07-11 21:06:03.666064) Review request for Plasma and Marco Martin. Changes --- use QWeakPointer delete the previous widget take the ownership of the widget declare two Q_PROPERTIES for them. Summary --- This patch adds two methods that allow to put two QGraphicsWidget in the top left and top right corner of the tab bar, like it is possible with QTabWidget. Diffs (updated) - trunk/KDE/kdelibs/plasma/widgets/tabbar.h 1147219 trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp 1147219 Diff: http://reviewboard.kde.org/r/4537/diff Testing --- Tested, it works, but there's one thing that annoys me and I don't how to solve in a clean way: when there are no tabs the NativeTabBar becomes a bit smaller in height and the widgets resize accordingly. Screenshots --- added two Plasma::PushButton http://reviewboard.kde.org/r/4537/s/446/ Thanks, Giulio ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma::Wallpaper does software scaling/copying when it isn't necessary
On Sunday 11 July 2010 12:44:50 velociraptor Genjix wrote: See the conversation http://kde-look.org/content/show.php?content=112105forumpage=4 titled Phonon video backend? I do the scaling using hardware acceleration Really? To me it looks like you're just using sws_scale which is a software scale. but Plasma::Wallpaper requires me to still copy this array with slow software acceleration. If the format is correct then just give me the target X surface. I'm not sure what would that give you. I'm guessing you want to use something like XvPutImage which wouldn't work because you already convert the frames to RGB and basically no one accelerates Xv with RGB surfaces. Besides it would be only meaningful assuming that a) Plasma currently runs on a system with X11, b) the driver doesn't implement Xv using an overlay. While we could assume a and disable the plugin if it's not the case, there's no reliable way of testing b and it will obviously break the entire Plasma (your video will render on top of everything). A video wallpaper should be as natural as an image or colour in today's world. That's a bit unrealistic. A static wallpaper needs to be uploaded only once, while the video will need to be uploaded ~24 times per second (and given that you're scaling in software even on an avarage laptop that's 1280*800*4*24 =~ 98MB every second). IMHO for video it'd be more interesting to start Plasma with a GL engine and after decoding the frame (to whatever is the video native YUV format, e.g. YUV420 for VP8) rendering it as a texture while doing the to rgb conversion and scale in shaders. z ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Security updates in kdeplasma-addons for 4.5
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4602/ --- Review request for Plasma. Summary --- A whole bunch of security updates for the 4.5 timeframe, they need to go out before 4.5 final is tagged, for applets which can or cannot reside on the plasma-overlay screensaver. I feel like a dork for waiting until rc2 to remember this patch, and I feel like more of a dork for sending it as an offlist mail first, but here is the reviewboard since I suffer from hate-commiting-to-code-i-didn't-write-itis :) - add proper attributes to bookmarks' desktop file - add proper attributes to opendesktop's desktop file - add proper attributes to kdeobservatory's dekstop file - add proper attributes to kimpanel's desktop file - add proper attributes to pastebin's desktop file - add proper attributes to plasmaboard's desktop file - add proper attributes to qalculate's desktop file - add proper attributes to socialnews's desktop file - add proper attributes to spellcheck's desktop file - make systemloadviewer's launchapp optional (Made a KRunner DBUS call to show system activity window) - make weatherstation's launchbrowser optional. Diffs - trunk/KDE/kdeplasma-addons/applets/bookmarks/plasma-applet-bookmarks.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/community/plasma-applet-opendesktop.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/kdeobservatory/plasma-applet-kdeobservatory.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/kimpanel/src/plasma-applet-kimpanel.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/pastebin/plasma-applet-pastebin.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/plasmaboard/plasma_applet_plasmaboard.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/qalculate/plasma-applet-qalculate.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/social-news/activitywidget.cpp 1142195 trunk/KDE/kdeplasma-addons/applets/social-news/plasma-applet-opendesktop-activities.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/spellcheck/plasma-applet-spellcheck.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/systemloadviewer/plasma-applet-systemloadviewer.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/systemloadviewer/systemloadviewer.cpp 1142195 trunk/KDE/kdeplasma-addons/applets/weatherstation/plasma-applet-weatherstation.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/weatherstation/weatherstation.cpp 1142195 Diff: http://reviewboard.kde.org/r/4602/diff Testing --- it's been sitting on my system from two weeks not eating $cute_creatures Thanks, Ryan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Security updates in kdeplasma-addons for 4.5
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4602/#review6482 --- Ship it! - Chani On 2010-07-11 21:53:30, Ryan Rix wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4602/ --- (Updated 2010-07-11 21:53:30) Review request for Plasma. Summary --- A whole bunch of security updates for the 4.5 timeframe, they need to go out before 4.5 final is tagged, for applets which can or cannot reside on the plasma-overlay screensaver. I feel like a dork for waiting until rc2 to remember this patch, and I feel like more of a dork for sending it as an offlist mail first, but here is the reviewboard since I suffer from hate-commiting-to-code-i-didn't-write-itis :) - add proper attributes to bookmarks' desktop file - add proper attributes to opendesktop's desktop file - add proper attributes to kdeobservatory's dekstop file - add proper attributes to kimpanel's desktop file - add proper attributes to pastebin's desktop file - add proper attributes to plasmaboard's desktop file - add proper attributes to qalculate's desktop file - add proper attributes to socialnews's desktop file - add proper attributes to spellcheck's desktop file - make systemloadviewer's launchapp optional (Made a KRunner DBUS call to show system activity window) - make weatherstation's launchbrowser optional. Diffs - trunk/KDE/kdeplasma-addons/applets/bookmarks/plasma-applet-bookmarks.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/community/plasma-applet-opendesktop.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/kdeobservatory/plasma-applet-kdeobservatory.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/kimpanel/src/plasma-applet-kimpanel.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/pastebin/plasma-applet-pastebin.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/plasmaboard/plasma_applet_plasmaboard.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/qalculate/plasma-applet-qalculate.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/social-news/activitywidget.cpp 1142195 trunk/KDE/kdeplasma-addons/applets/social-news/plasma-applet-opendesktop-activities.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/spellcheck/plasma-applet-spellcheck.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/systemloadviewer/plasma-applet-systemloadviewer.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/systemloadviewer/systemloadviewer.cpp 1142195 trunk/KDE/kdeplasma-addons/applets/weatherstation/plasma-applet-weatherstation.desktop 1142195 trunk/KDE/kdeplasma-addons/applets/weatherstation/weatherstation.cpp 1142195 Diff: http://reviewboard.kde.org/r/4602/diff Testing --- it's been sitting on my system from two weeks not eating $cute_creatures Thanks, Ryan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Scrollbars in add widget ui
Hi,
I have been playing a bit with the Add Widget UI on the plane back from
Akademy and replaced the scroll buttons with a scrollbar. Attached patch
is a first step at it, largely unfinished as I would like to know if you
are interested in getting this integrated before I finish it.
Screenshots:
- Horizontal: http://imagebin.ca/view/NkxkAG.html
- Vertical: http://imagebin.ca/view/XnBxX8vt.html
What do you think?
Aurélien
diff --git a/workspace/libs/plasmagenericshell/abstracticonlist.cpp b/workspace/libs/plasmagenericshell/abstracticonlist.cpp
index 78a1fd1..3141516 100644
--- a/workspace/libs/plasmagenericshell/abstracticonlist.cpp
+++ b/workspace/libs/plasmagenericshell/abstracticonlist.cpp
@@ -37,6 +37,7 @@
#include Plasma/Containment
#include Plasma/Corona
#include Plasma/ItemBackground
+#include Plasma/ScrollBar
#include Plasma/Theme
#include Plasma/ToolButton
@@ -102,6 +103,11 @@ void AbstractIconList::init()
m_downRightArrow-setPreferredSize(IconSize(KIconLoader::Panel), IconSize(KIconLoader::Panel));
m_downRightArrow-setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Expanding);
+m_scrollBar = new Plasma::ScrollBar(this);
+m_scrollBar-setOrientation(m_orientation);
+m_scrollBar-setSingleStep(128);
+connect(m_scrollBar, SIGNAL(valueChanged(int)), SLOT(scrollListWidget(int)));
+/*
if (m_orientation == Qt::Horizontal) {
m_upLeftArrow-setIcon(KIcon(m_arrowsSvg-pixmap(left-arrow)));
m_downRightArrow-setIcon(KIcon(m_arrowsSvg-pixmap(right-arrow)));
@@ -113,6 +119,7 @@ void AbstractIconList::init()
m_upLeftArrow-setMaximumSize(-1, IconSize(KIconLoader::Panel));
m_downRightArrow-setMaximumSize(-1, IconSize(KIconLoader::Panel));
}
+*/
connect(m_downRightArrow, SIGNAL(pressed()), this, SLOT(scrollDownRight()));
connect(m_upLeftArrow, SIGNAL(pressed()), this, SLOT(scrollUpLeft()));
@@ -136,6 +143,7 @@ void AbstractIconList::init()
m_appletListWindowWidget-installEventFilter(this);
//layouts
+/*
m_arrowsLayout = new QGraphicsLinearLayout(m_orientation);
m_arrowsLayout-addItem(m_appletListWindowWidget);
@@ -145,7 +153,14 @@ void AbstractIconList::init()
m_arrowsLayout-setAlignment(m_downRightArrow, Qt::AlignVCenter | Qt::AlignHCenter);
m_arrowsLayout-setAlignment(m_upLeftArrow, Qt::AlignVCenter | Qt::AlignHCenter);
m_arrowsLayout-setAlignment(m_appletListWindowWidget, Qt::AlignVCenter | Qt::AlignHCenter);
-
+*/
+if (m_orientation == Qt::Horizontal) {
+m_arrowsLayout = new QGraphicsLinearLayout(Qt::Vertical);
+} else {
+m_arrowsLayout = new QGraphicsLinearLayout(Qt::Horizontal);
+}
+m_arrowsLayout-addItem(m_appletListWindowWidget);
+m_arrowsLayout-addItem(m_scrollBar);
//m_hoverIndicator = new Plasma::ItemBackground(m_appletListWindowWidget);
m_hoverIndicator = new Plasma::ItemBackground(m_appletListWidget);
setLayout(m_arrowsLayout);
@@ -344,6 +359,7 @@ void AbstractIconList::updateList()
updateGeometry();
m_hoverIndicator-hide();
resetScroll();
+updateScrollBar();
}
void AbstractIconList::wheelEvent(QGraphicsSceneWheelEvent *event)
@@ -462,11 +478,30 @@ void AbstractIconList::resetScroll()
manageArrows();
}
+void AbstractIconList::scrollListWidget(int value)
+{
+qreal pos = -value;
+if (m_orientation == Qt::Horizontal) {
+m_appletListWidget-setPos(pos, 0);
+} else {
+m_appletListWidget-setPos(0, pos);
+}
+}
+
+void AbstractIconList::updateScrollBar()
+{
+int ws = windowSize();
+m_scrollBar-setPageStep(ws);
+m_scrollBar-setRange(0, listSize() - ws);
+}
+
void AbstractIconList::manageArrows()
{
qreal list_size = listSize();
qreal window_size = windowSize();
+updateScrollBar();
+
if (list_size = window_size || m_currentAppearingAppletsOnList.isEmpty()) {
m_upLeftArrow-setEnabled(false);
m_downRightArrow-setEnabled(false);
diff --git a/workspace/libs/plasmagenericshell/abstracticonlist.h b/workspace/libs/plasmagenericshell/abstracticonlist.h
index cd14cd5..d7dbaf5 100644
--- a/workspace/libs/plasmagenericshell/abstracticonlist.h
+++ b/workspace/libs/plasmagenericshell/abstracticonlist.h
@@ -38,6 +38,7 @@ namespace Plasma
{
class Animation;
class ItemBackground;
+class ScrollBar;
class ToolButton;
class PLASMAGENERICSHELL_EXPORT AbstractIconList : public QGraphicsWidget
@@ -110,6 +111,8 @@ private:
void wheelEvent(QGraphicsSceneWheelEvent *event);
+void updateScrollBar();
+
public Q_SLOTS:
void searchTermChanged(const QString text);
void updateList();
@@ -137,6 +140,7 @@ private Q_SLOTS:
void iconHoverEnter(Plasma::AbstractIcon *icon);
void setSearch();
+void scrollListWidget(int);
private:
//list containing the applet icons of the filter proxy model
@@ -147,6 +151,7 @@ private:
QGraphicsWidget *m_appletListWindowWidget;
Activity identicons v 1.99 :) (post-akademy)
Hi all, At aKademy, Nuno proposed a bit different design for identicons used for plasma activities. 1. The identicons should be showed inside a bubble with background and an overlay. 2. He will make some default icons for users that want to choose specific ones instead of the automatically generated. -- 1. First, for those who don't know, identicons are essentially a graphic hash function - depending on the hash, the pattern and base colour is generated. The first implementation of the new approach (screenshot of it) is attached. Naturally, it could look better, but I didn't really have the time to make fancier SVG template. The SVG is consisted of a background, content (which is being drilled to provide the pattern), and overlay (which can be normal and active *1*). The overlay is not hinted with the hash-generated colour, while everything else is. The elements (including the hash-generated patterns) can be of any shape, not only bubbles, as per theme designer wishes. -- 2. We need a list of common activities for Nuno to make icons for. Ideas? We should get at least 20 :) Cheerio, Ivan *1* In the screenshot, every 4th icon is activated. I could also add hovered and disabled (for stopped activities). -- While you were hanging yourself on someone else's words Dying to believe in what you heard I was staring straight into the shining sun attachment: identicons.jpg___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On Monday 12 July 2010 00:18:03 Aurélien Gâteau wrote: What do you think? I think that the scrollbars are an improvement, but I like the window from 4.3 better: The current one requires to hover over an icon to see the description. I have yet to see any improvement of the Add widget bar over the window, but I also didn't participate in the discussion before SC 4.4 over which one is better. So I'm not aware of the exchanged arguments. (I hope there was a discussion.) Markus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On Sunday, July 11, 2010 03:18:03 pm Aurélien Gâteau wrote: Hi, I have been playing a bit with the Add Widget UI on the plane back from Akademy and replaced the scroll buttons with a scrollbar. Attached patch is a first step at it, largely unfinished as I would like to know if you are interested in getting this integrated before I finish it. Screenshots: - Horizontal: http://imagebin.ca/view/NkxkAG.html - Vertical: http://imagebin.ca/view/XnBxX8vt.html What do you think? Aurélien +1 from me :) just being able to see where in the list I am makes me happier. how does it look if there aren't enough to scroll? P.S. Reviewboard Is Your Friend ;) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Activity identicons v 1.99 :) (post-akademy)
On Sunday, July 11, 2010 03:20:39 pm Ivan Čukić wrote: Hi all, At aKademy, Nuno proposed a bit different design for identicons used for plasma activities. 1. The identicons should be showed inside a bubble with background and an overlay. they look pretty :) now, what if $plasmoid wants to use the icon (eg, activity bar)? what if $application wants to use the icon (eg. when associating something with an activity)? it'd be nice if I could see the icons when assigning windows to activities, but I dunno if that'd be possible with autogenerated ones... 2. He will make some default icons for users that want to choose specific ones instead of the automatically generated. can users still choose any arbitrary icon they like? 2. We need a list of common activities for Nuno to make icons for. Ideas? We should get at least 20 :) work fun chat school math science writing art music cooking ... really, the sort of activities the user has is likely to depend on what the user does in his/her life :) me, I'll have activities for kwin, plasma, odfkit, etc... plus various courses, and one for fun. rrix has activities for fedora, plasma, and a dozen other things I forget. activities are a rather personal thing... ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Scrollbars in add widget ui
On July 11, 2010, Markus Slopianka wrote: On Monday 12 July 2010 00:18:03 Aurélien Gâteau wrote: What do you think? I think that the scrollbars are an improvement, but I like the window from 4.3 better: The current one requires to hover over an icon to see the description. I have yet to see any improvement of the Add widget bar over the window, but I also didn't participate in the discussion before SC 4.4 over which one is better. So I'm not aware of the exchanged arguments. (I hope there was a discussion.) I kind-of agree, I still can't figure out how to remove widgets once they've been lost. There's no remove button in the new selector like there used to be. Markus ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Thomas Fjellstrom tfjellst...@shaw.ca ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Activity identicons v 1.99 :) (post-akademy)
On Sun, Jul 11, 2010 at 6:20 PM, Ivan Čukić ivan.cu...@kde.org wrote: 2. We need a list of common activities for Nuno to make icons for. Ideas? We should get at least 20 :) At the very least the same categories found in the Application Launcher could be used, with the added advantage that they don't need separate icons. For me I have these: Development Edutainment Games Graphics Internet Multimedia Office Utilities Here are some other possibilities: Default Startup Web PIM/Personal Information Management Art Pictures Work Home Mobile Relaxation Music Video Science Math Writing Travel File Management Launch Organization -Todd ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
