Re: bug killing

2011-11-22 Thread Rick Stockton

On 01/-10/-28163 11:59 AM, todd rme wrote:
I often encounter bugs that are duplicate, fixed, etc, and I post a 
comment on the bug report to that effect, but the comments seem to 
rarely be acted upon
Todd, I cannot imagine another person, currently WITHOUT admin bugzilla 
rights, who is as qualified and capable of using using those rights 
correctly as YOU.


I was facing the same problem yesterday night -- looking at one of "my 
favorite" bugs, in which my final comments indicated exactly why and how 
it should be closed: With no action from the assignee. My solution? Jump 
on IRC, channel #kde-bugs, and point at that particular bug (the 
notorious https://bugs.kde.org/show_bug.cgi?id=34362) as the one I 
needed permissions to close. A 'big guy in KDE' happened to be online, 
even tough it was well after midnight EU time. He looked at my work, 
approved of what he saw, set me up, and the bug is now closed. (Thanks, 
Ben ;) I'm sure that nearly any Admin 'Voice' on #kde-bugs would do the 
same for you, or immediately pull in another person to do the review and 
confirm (if your original IRC contact hasn't already heard of you.)


- - - - - A lengthy side-bar discussion - - - - -

IMO, bugs being erroneously closed is _not_ one of our larger issues 
with KDE Bugzilla. And if a mistake is made, a bug which is closed in 
error can be re-opened quite easily. The lowest-hanging fruit consists 
of the bugs which don't even need 10-line fixes. I'll list 3 groups 
which have come to my little, feeble mind:


1. BugIDs which SHOULD be closed after re-triage and verification (the 
problem no longer exists). It sounds like you have found many of these, 
thanks!


2. Bugs which are so ill-defined that no one can really work on them. 
(Bugs with vast numbers of comments flung at the wall', asking for 
different things, with an assignee who has left them all "still stuck". 
These need re-definition, restricting them to a unique problem and 
solution. (I have an example which I intend to take on myself, the 
almost-as-notorious https://bugs.kde.org/show_bug.cgi?id=48062. It asks 
for Mouse Buttons as modifier keys, which is ONE thing, but many of the 
comments- including a few of mine- talk abut high-numbered as shortcuts 
all be themselves (without another keystroke, without emulating a 
held-down modifier button). The difference between these two wishlist 
items is huge.


3. And the third group, which includes many cases of Group #1 or Group 
#2: The assignee is no longer listening. This appears to be the case 
with #48062, which (after 8 years or so) seems to have it's owner 
ignoring it completely. (He's still an open software guy, but not paying 
attention to activity on THIS bug.) In these cases, we need a person 
with Admin permission (me, or YOU) to re-assign it themselves after one 
final, polite 'Ping?' attempt. Then, after YOU taken ownership and 
responsibility, you take the action which you have explained in your 
comments. I suspect that we have many, many bug owners who have their 
bugs in limbo when they have chosen to move on- a real, REALLY Bad Thing 
To Do.
One part of the solution for this probably needs to be an emphasis 
that we WILL accept a reverse assignment, from a specific person back to 
'unassigned', if the assignee decides not to work on it. With no whining 
from us, either -- or these assignees will avoid the job by leaving them 
as they are, "trapped" in a non-productive assignment to an email which 
isn't listening, or isn't capable of resolving the problem. The lives of 
KDE people, past and present, are prone to change from time to time. A 
Bugzilla database full of false "assignee" values is MUCH worse than a 
database with these particular bugs sent back into 'unassigned' State.


- - - - - end of side-bar, back to Todd

So- please jump on IRC, get permission from an authoritative person, and 
take control of those bugs where YOU have already determined the 
Action(s) which needs to be done. Or -- someone reading this, and 
authoritative in offering BugZilla permissions - please set Todd up, and 
send him an email when he's got the ability to squash a few- we might 
find that he Resolves _way_ more than just a few.


Thanks to all, I know that I was VERY wordy, but I feel that a thorough 
review of our 'stale assignee' problem could be beneficial.

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Media Query: KDE's Support For Android Tablets

2011-11-22 Thread Alex Fiestas
HAving a good mtp support is going to become more and more important 
since a lot of companies are using it to avoid to pay the vFat fee M$ is 
imposing.


I'm no expert in mtp but it seems that it is a transport protocol which 
allow to offer different services, for example if you grab an N9 or N950 
and execute mtp-detect you will see stuff like:


- File access
- Photo access
- Music
- Device information...

So we must support the the most used ones.

As part of the fixing, there is a patch waiting to be commited that will 
improve libsolid detection, so it seems that the only thing left to do 
is to have good mtp kio's.

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Media Query: KDE's Support For Android Tablets

2011-11-22 Thread Martin Klapetek
On Tue, Nov 22, 2011 at 19:50, todd rme  wrote:

> On Tue, Nov 22, 2011 at 6:41 PM, Alex Fiestas  wrote:
> > On 11/22/2011 02:29 PM, Markus Slopianka wrote:
> >>
> >> As far as I'm aware, existing MTP access methods (DigiKam, Amarok) were
> >> seen as good
> >> enough, so nobody so far found the need to write a MTP KIO Slave to
> mount
> >> MTP devices in
> >> Dolphin. (Well, not exactly true: In 2007 a 3rd party wrote it but it
> died
> >> in alpha stage:
> >> http://kde-apps.org/content/show.php/kio_mtp?content=55618 )
> >> I don't have an MTP device so I can't tell how good Amarok and DigiKam
> in
> >> that respect.
> >
> > I'm planning on working in this since I bought a Galaxy Tab 10.1 a few
> weeks
> > ago though in that case it won't work ebcause Samsung implements some
> nasty
> > DRM mtp version.
> >
> > I don't have much time to work on this so help is welcomed :p
>
> With Android 4.0 (Ice Cream Sandwich) and later MTP is used for all
> Android devices, not only tablets.  So anyone using an Android 4 or
> later phone or 3 or later tablet will need to use MTP to access the
> internal memory.
>

In that case I might help with that as I'll have some Android 4.0 device
soon (matter of two months probably).

--
Martin Klapetek | KDE Developer


>
> -Todd
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Media Query: KDE's Support For Android Tablets

2011-11-22 Thread todd rme
On Tue, Nov 22, 2011 at 6:41 PM, Alex Fiestas  wrote:
> On 11/22/2011 02:29 PM, Markus Slopianka wrote:
>>
>> As far as I'm aware, existing MTP access methods (DigiKam, Amarok) were
>> seen as good
>> enough, so nobody so far found the need to write a MTP KIO Slave to mount
>> MTP devices in
>> Dolphin. (Well, not exactly true: In 2007 a 3rd party wrote it but it died
>> in alpha stage:
>> http://kde-apps.org/content/show.php/kio_mtp?content=55618 )
>> I don't have an MTP device so I can't tell how good Amarok and DigiKam in
>> that respect.
>
> I'm planning on working in this since I bought a Galaxy Tab 10.1 a few weeks
> ago though in that case it won't work ebcause Samsung implements some nasty
> DRM mtp version.
>
> I don't have much time to work on this so help is welcomed :p

With Android 4.0 (Ice Cream Sandwich) and later MTP is used for all
Android devices, not only tablets.  So anyone using an Android 4 or
later phone or 3 or later tablet will need to use MTP to access the
internal memory.

-Todd
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Media Query: KDE's Support For Android Tablets

2011-11-22 Thread David Narvaez
On Tue, Nov 22, 2011 at 12:41 PM, Alex Fiestas  wrote:
> I'm planning on working in this since I bought a Galaxy Tab 10.1 a few weeks
> ago though in that case it won't work ebcause Samsung implements some nasty
> DRM mtp version.
>
> I don't have much time to work on this so help is welcomed :p

Sure! Send in your tablet and I'll help you :D j/k

I have a friend with an Archos Android Tablet which I'm pretty sure I
could use in case you need us to test something (non-destructive).

David E. Narvaez
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Media Query: KDE's Support For Android Tablets

2011-11-22 Thread Alex Fiestas

On 11/22/2011 02:29 PM, Markus Slopianka wrote:

As far as I'm aware, existing MTP access methods (DigiKam, Amarok) were seen as 
good
enough, so nobody so far found the need to write a MTP KIO Slave to mount MTP 
devices in
Dolphin. (Well, not exactly true: In 2007 a 3rd party wrote it but it died in 
alpha stage:
http://kde-apps.org/content/show.php/kio_mtp?content=55618 )
I don't have an MTP device so I can't tell how good Amarok and DigiKam in that 
respect.


I'm planning on working in this since I bought a Galaxy Tab 10.1 a few 
weeks ago though in that case it won't work ebcause Samsung implements 
some nasty DRM mtp version.


I don't have much time to work on this so help is welcomed :p
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: bug killing

2011-11-22 Thread Gregor Tätzner
Am Dienstag, 22. November 2011, 11:40:29 schrieb Aaron J. Seigo:
> On Tuesday, November 22, 2011 09:09:51 Gregor =?ISO-8859-1?Q?T=E4tzner?=
> 
> wrote:
> > +1 that would be great! I have the same problem and *don't* know people
> > with admin rights.
> 
> i have given the bugs.kde.org accounts for both you and Todd the ability to
> edit bugs ... handle with care, and welcome to the world of helping us tame
> the bug count...
thanks, hopefully I don't mess things up :)
> 
> tip:
> 
> when logged in to bugs.kde.org, go to "Edit my Preferences" under "My
> Account" in the left side bar.
> 
> then click on "Saved Searches"
> 
> you should see (in the massive list there) a few shared saved searches for
> plasma. you can add them to your sidebar (aka "footer") or click on them to
> run them manually (and they can be bookmarked)
nice tip!

-- 
Space is big.  You just won't believe how vastly, hugely, mind-bogglingly
big it is.  I mean, you may think it's a long way down the road to the
drug store, but that's just peanuts to space.
-- The Hitchhiker's Guide to the Galaxy


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Plasma Widgets in Qt-designer

2011-11-22 Thread Tomaz Canabrava
On Tue, Nov 22, 2011 at 9:31 AM, Aaron J. Seigo  wrote:
> On Tuesday, November 22, 2011 08:13:44 Tomaz Canabrava wrote:
>
>> If you want to use plasma widgets in your app, it's possible, you can
>
>> use a Plasma::Corona and the set of plasma classes for it, like Amarok
>
>> does.
> or use QML and the Plasma QtComponents ...
>

Sure, that works too. I didn't had the time to study the QML code yet,
but since plasma and a lot of apps are migrating a tiny bit to it, I
understand that it'll be the future.

Back to the study board...

> --
>
> Aaron J. Seigo
>
> humru othro a kohnu se
>
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
>
>
>
> KDE core developer sponsored by Qt Development Frameworks
>
>
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: bug killing

2011-11-22 Thread Aaron J. Seigo
On Monday, November 21, 2011 11:01:47 Aaron J. Seigo wrote:
> i'll arrange for a workshop + bug squash days near the end of the month.
> please take a moment to fill in this doodle:
> 
>   http://www.doodle.com/3rx2m4vz92qcrhm5

so far it looks like thursda the 1st afternoon and friday the 2nd in the 
evening will be the two best days. i'll give it another couple of days and 
then settle on final times, so be sure to fill out the doodle if you haven't 
already.

btw.. we're down almost another 100 reports today.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Plasma Widgets in Qt-designer

2011-11-22 Thread Aaron J. Seigo
On Tuesday, November 22, 2011 08:13:44 Tomaz Canabrava wrote:
> If you want to use plasma widgets in your app, it's possible, you can
> use a Plasma::Corona and the set of plasma classes for it, like Amarok
> does.

or use QML and the Plasma QtComponents ...

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Media Query: KDE's Support For Android Tablets

2011-11-22 Thread Markus Slopianka
As far as I'm aware, existing MTP access methods (DigiKam, Amarok) were seen as 
good 
enough, so nobody so far found the need to write a MTP KIO Slave to mount MTP 
devices in 
Dolphin. (Well, not exactly true: In 2007 a 3rd party wrote it but it died in 
alpha stage:
http://kde-apps.org/content/show.php/kio_mtp?content=55618 )
I don't have an MTP device so I can't tell how good Amarok and DigiKam in that 
respect.

Markus

On Dienstag 22 November 2011 11:44:38 Swapnil Bhartiya wrote:
> Hi Aaron,
> 
> I have been trying to reach you but just can't get hold of you at all.
> Thus posting it here.
> 
> I represent Muktware.com and I am working on a story about Android
> support in Linux. While Gnome can detect and mount the Android 3.x +
> tablets, allowing users to drag/drop content to the tablets and crate
> folders (it can't see content inside folders). So, at least a user can
> copy content -- movie/music to the tablet.
> 
> On the contrary KDE mounts it as a Camera and can't see content on the
> tablet, can create folders and can't drag/drop or paste content in the
> tablet which makes it hard for a user to use KDE to manage tablets.
> 
> What is the reason KDE can't mounts Android Honeycomb tablets which use
> MTP? With increasing use of tablets, what is the KDE team doing to fix
> this problem?
> 
> Best
> Sapnil Bhartiya
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Plasma Widgets in Qt-designer

2011-11-22 Thread Tomaz Canabrava
On Tue, Nov 22, 2011 at 8:09 AM, David Baron  wrote:
> On Monday 24 Heshvan 5772 23:02:13 Aaron J. Seigo wrote:
>> On Monday, November 21, 2011 16:38:22 Luiz =?ISO-8859-1?Q?Rom=E1rio?=
>> Santana
>>
>> Rios wrote:
>> > I think it's because Plasma widgets are not QWidgets, but
>> > QGraphicsWidgets.
>>
>> you are correct.
>
> I assume that yet-another-set-of-widgets was written because they have
> qualtities the others do not, i.e., portray according the the plasma style,
> etc. (BTW, most look great for panels but the text in some apps is barely
> readable.) The ability to use a visual forms tool to set them up would mean I
> would make use of them instead of some of the Qt and KDE I use now.
>
> An alterntive might be a script to convert of .ui or uih file if the calls
> are similar enough.

They are not QWidgets, they are QGraphicsItems that acts as widgets.
they are not made from .ui nor transformed from ui to a ui_file.h, so
this is impossible.
If you want to use plasma widgets in your app, it's possible, you can
use a Plasma::Corona and the set of plasma classes for it, like Amarok
does.

Tomaz

> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Plasma Widgets in Qt-designer

2011-11-22 Thread David Baron
On Monday 24 Heshvan 5772 23:02:13 Aaron J. Seigo wrote:
> On Monday, November 21, 2011 16:38:22 Luiz =?ISO-8859-1?Q?Rom=E1rio?=
> Santana
> 
> Rios wrote:
> > I think it's because Plasma widgets are not QWidgets, but
> > QGraphicsWidgets.
> 
> you are correct.

I assume that yet-another-set-of-widgets was written because they have 
qualtities the others do not, i.e., portray according the the plasma style, 
etc. (BTW, most look great for panels but the text in some apps is barely 
readable.) The ability to use a visual forms tool to set them up would mean I 
would make use of them instead of some of the Qt and KDE I use now.

An alterntive might be a script to convert of .ui or uih file if the calls 
are similar enough.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Media Query: KDE's Support For Android Tablets

2011-11-22 Thread Sebastian Kügler
On Tuesday, November 22, 2011 11:44:38 Swapnil Bhartiya wrote:
> I have been trying to reach you but just can't get hold of you at all. 
> Thus posting it here.
> 
> I represent Muktware.com and I am working on a story about Android 
> support in Linux. While Gnome can detect and mount the Android 3.x +
> tablets, allowing users to drag/drop content to the tablets and crate
> folders (it can't see content inside folders). So, at least a user can
> copy content -- movie/music to the tablet.
> 
> On the contrary KDE mounts it as a Camera and can't see content on the
> tablet, can create folders and can't drag/drop or paste content in the
> tablet which makes it hard for a user to use KDE to manage tablets.
> 
> What is the reason KDE can't mounts Android Honeycomb tablets which use
> MTP? With increasing use of tablets, what is the KDE team doing to fix
> this problem?

That should work just fine with software such as Amarok, which supports the 
MTP protocol.

http://amarok.kde.org/wiki/Media_Device:MTP

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Media Query: KDE's Support For Android Tablets

2011-11-22 Thread Swapnil Bhartiya

Hi Aaron,

I have been trying to reach you but just can't get hold of you at all. 
Thus posting it here.


I represent Muktware.com and I am working on a story about Android 
support in Linux. While Gnome can detect and mount the Android 3.x +

tablets, allowing users to drag/drop content to the tablets and crate
folders (it can't see content inside folders). So, at least a user can
copy content -- movie/music to the tablet.

On the contrary KDE mounts it as a Camera and can't see content on the
tablet, can create folders and can't drag/drop or paste content in the
tablet which makes it hard for a user to use KDE to manage tablets.

What is the reason KDE can't mounts Android Honeycomb tablets which use
MTP? With increasing use of tablets, what is the KDE team doing to fix
this problem?

Best
Sapnil Bhartiya
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Thomas Lübking


> On Nov. 22, 2011, 9:24 a.m., Thomas Lübking wrote:
> > plasma/private/containment_p.h, line 71
> > 
> >
> > ibeg your pardon?
> > to me this looks like you delete the same entry forever (what *will* 
> > crash at a point) since you don't remove it - should be "takeFirst", yesno?
> 
> Ben Cooksley wrote:
> Other code handles this for us - which is why qDeleteAll() crashes.
> 
> Thomas Lübking wrote:
> sorry, but the only way i see this could be correct is that qlist (fun 
> with templates) subclasses pointer Types and reimplements delete to 
> automatically remove them from the list, what is, nicely spoken, sick.
> is there any detailed (official) explanation on this?
> 
> Aaron J. Seigo wrote:
> see ContainmentPrivate::appletDestroyed(Plasma::Applet *applet) in 
> kdelibs/plasma/containment.cpp
> 
> Ben Cooksley wrote:
> Only information I have is https://git.reviewboard.kde.org/r/102981/
> I haven't checked the code, but i'm guessing that Plasma::Applet must do 
> something similar to what Akregator does.
> In any case, I tested and Plasma does not infinitely loop - it does close 
> properly.

okey, thanks - that explains things.
qlist needs a mutex (at least as friend for qdeleteall) - and imho this here 
needs another comment since esp. the superfluous clear() makes it look like i 
bug. (written by touch in a shaky train ;-)


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103202/#review8384
---


On Nov. 22, 2011, 7:39 a.m., Ben Cooksley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103202/
> ---
> 
> (Updated Nov. 22, 2011, 7:39 a.m.)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Description
> ---
> 
> Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. This 
> patch fixes one of those scenarios to ensure that Plasma Desktop does not 
> crash on quit or logout.
> 
> 
> Diffs
> -
> 
>   plasma/private/containment_p.h 4025bf4 
> 
> Diff: http://git.reviewboard.kde.org/r/103202/diff/diff
> 
> 
> Testing
> ---
> 
> Compiled, Plasma Desktop no longer crashes on exit.
> 
> 
> Thanks,
> 
> Ben Cooksley
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: bug killing

2011-11-22 Thread Aaron J. Seigo
On Tuesday, November 22, 2011 09:09:51 Gregor =?ISO-8859-1?Q?T=E4tzner?= 
wrote:
> +1 that would be great! I have the same problem and *don't* know people with
> admin rights.

i have given the bugs.kde.org accounts for both you and Todd the ability to 
edit bugs ... handle with care, and welcome to the world of helping us tame 
the bug count...

tip:

when logged in to bugs.kde.org, go to "Edit my Preferences" under "My Account" 
in the left side bar.

then click on "Saved Searches"

you should see (in the massive list there) a few shared saved searches for 
plasma. you can add them to your sidebar (aka "footer") or click on them to 
run them manually (and they can be bookmarked)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: bug killing

2011-11-22 Thread Aaron J. Seigo
On Tuesday, November 22, 2011 09:54:48 todd rme wrote: 
> Thanks!  I will do so.

i can also grant these priveleges in b.k.o, so just ask and thou shalt receive 
:)
 
> But this isn't really about me specifically, it is a way for any user
> to make the bug triaging load easier.  Even if users aren't

this would be great if "any user" was capable of doing this work in a reliable 
manner. given the interactions we have with "any user" on b.k.o, this is 
really expecting too much and would likely do as much harm as good.

identifying those who could and should get these priveleges is something we 
don't do an amazingly great job at, though, so on the flip side we do 
currently miss out on opportunities.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: bug killing

2011-11-22 Thread Aaron J. Seigo
On Tuesday, November 22, 2011 10:16:09 Christoph Feck wrote:
> Plasma bug list is a bit different. It does not have a maintainer
> looking at the messages regularily, so those messages are lost in
> noise, as you already mentioned.

oh, i look at them on a regular basis. the rate of reports and comments is 
simply too high to keep up with given the time i have, however. some days 
there will be over 50 new messages; and if i'm away for a day or two 
(meetings, conference, etc) then it's easy to come back to 200+ reports. 

so it's a matter of having enough separate eyeballs looking at things and 
working on the triage together to make the load manageable. that's the key.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Bug fix for 278765

2011-11-22 Thread Aaron J. Seigo


> On Nov. 16, 2011, 5 p.m., Aaron J. Seigo wrote:
> > plasma/desktop/applets/tasks/abstracttaskitem.cpp, lines 172-176
> > 
> >
> > much simpler is:
> > 
> > data.setInstantPopup(KWindowSystem::compositingActive());
> > 
> > it does the same thing after all :)
> 
> Aaron J. Seigo wrote:
> to increase the timeout for zero to an arbitrary value would require 
> allowing Plasma::ToolTipData to take a timeout. i do not want to see that as 
> it means we'll end up with these "special" timeouts (and higher maintenance 
> and impossible to keep consistency) throughout plasma using code.
> 
> instead, i'd prefer to see instant popups behave more sanely (a small 
> timeout rather than a zero one, for instance). that code is in 
> Plasma::ToolTipManager and is what should be altered.
> 
> Giorgos Tsiapaliwkas wrote:
> I updated the diff according to Aaron's advice.
> 
> So if i understood correctly this patch is ready and the 
> Plasma::ToolTipManager.Is another patch.
> 
> thanks

yes, the tooltipmanager would be a different patch and would need to happen in 
the frameworks branch against libplasma2 since it is a new feature and not 
really a bug fix.


- Aaron J.


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102304/#review8236
---


On Nov. 22, 2011, 7:57 a.m., Giorgos Tsiapaliwkas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102304/
> ---
> 
> (Updated Nov. 22, 2011, 7:57 a.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> ---
> 
> hello,
> 
> I found a third solution for this bug(Aaron said the other two at tha 
> plasma-devel mailing list).
> 
> 
> This addresses bug 278765.
> http://bugs.kde.org/show_bug.cgi?id=278765
> 
> 
> Diffs
> -
> 
>   plasma/desktop/applets/tasks/abstracttaskitem.cpp 48ba172 
>   plasma/desktop/applets/tasks/applauncheritem.cpp 4dc24ee 
>   plasma/desktop/applets/tasks/taskgroupitem.cpp d7816d3 
>   plasma/desktop/applets/tasks/windowtaskitem.cpp c4db8c7 
> 
> Diff: http://git.reviewboard.kde.org/r/102304/diff/diff
> 
> 
> Testing
> ---
> 
> compiles fines
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Bug fix for 278765

2011-11-22 Thread Aaron J. Seigo

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102304/#review8391
---

Ship it!


Ship It!

- Aaron J. Seigo


On Nov. 22, 2011, 7:57 a.m., Giorgos Tsiapaliwkas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102304/
> ---
> 
> (Updated Nov. 22, 2011, 7:57 a.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> ---
> 
> hello,
> 
> I found a third solution for this bug(Aaron said the other two at tha 
> plasma-devel mailing list).
> 
> 
> This addresses bug 278765.
> http://bugs.kde.org/show_bug.cgi?id=278765
> 
> 
> Diffs
> -
> 
>   plasma/desktop/applets/tasks/abstracttaskitem.cpp 48ba172 
>   plasma/desktop/applets/tasks/applauncheritem.cpp 4dc24ee 
>   plasma/desktop/applets/tasks/taskgroupitem.cpp d7816d3 
>   plasma/desktop/applets/tasks/windowtaskitem.cpp c4db8c7 
> 
> Diff: http://git.reviewboard.kde.org/r/102304/diff/diff
> 
> 
> Testing
> ---
> 
> compiles fines
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Ben Cooksley


> On Nov. 22, 2011, 9:24 a.m., Thomas Lübking wrote:
> > plasma/private/containment_p.h, line 71
> > 
> >
> > ibeg your pardon?
> > to me this looks like you delete the same entry forever (what *will* 
> > crash at a point) since you don't remove it - should be "takeFirst", yesno?
> 
> Ben Cooksley wrote:
> Other code handles this for us - which is why qDeleteAll() crashes.
> 
> Thomas Lübking wrote:
> sorry, but the only way i see this could be correct is that qlist (fun 
> with templates) subclasses pointer Types and reimplements delete to 
> automatically remove them from the list, what is, nicely spoken, sick.
> is there any detailed (official) explanation on this?
> 
> Aaron J. Seigo wrote:
> see ContainmentPrivate::appletDestroyed(Plasma::Applet *applet) in 
> kdelibs/plasma/containment.cpp

Only information I have is https://git.reviewboard.kde.org/r/102981/
I haven't checked the code, but i'm guessing that Plasma::Applet must do 
something similar to what Akregator does.
In any case, I tested and Plasma does not infinitely loop - it does close 
properly.


- Ben


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103202/#review8384
---


On Nov. 22, 2011, 7:39 a.m., Ben Cooksley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103202/
> ---
> 
> (Updated Nov. 22, 2011, 7:39 a.m.)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Description
> ---
> 
> Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. This 
> patch fixes one of those scenarios to ensure that Plasma Desktop does not 
> crash on quit or logout.
> 
> 
> Diffs
> -
> 
>   plasma/private/containment_p.h 4025bf4 
> 
> Diff: http://git.reviewboard.kde.org/r/103202/diff/diff
> 
> 
> Testing
> ---
> 
> Compiled, Plasma Desktop no longer crashes on exit.
> 
> 
> Thanks,
> 
> Ben Cooksley
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Aaron J. Seigo


> On Nov. 22, 2011, 9:24 a.m., Thomas Lübking wrote:
> > plasma/private/containment_p.h, line 71
> > 
> >
> > ibeg your pardon?
> > to me this looks like you delete the same entry forever (what *will* 
> > crash at a point) since you don't remove it - should be "takeFirst", yesno?
> 
> Ben Cooksley wrote:
> Other code handles this for us - which is why qDeleteAll() crashes.
> 
> Thomas Lübking wrote:
> sorry, but the only way i see this could be correct is that qlist (fun 
> with templates) subclasses pointer Types and reimplements delete to 
> automatically remove them from the list, what is, nicely spoken, sick.
> is there any detailed (official) explanation on this?

see ContainmentPrivate::appletDestroyed(Plasma::Applet *applet) in 
kdelibs/plasma/containment.cpp


- Aaron J.


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103202/#review8384
---


On Nov. 22, 2011, 7:39 a.m., Ben Cooksley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103202/
> ---
> 
> (Updated Nov. 22, 2011, 7:39 a.m.)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Description
> ---
> 
> Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. This 
> patch fixes one of those scenarios to ensure that Plasma Desktop does not 
> crash on quit or logout.
> 
> 
> Diffs
> -
> 
>   plasma/private/containment_p.h 4025bf4 
> 
> Diff: http://git.reviewboard.kde.org/r/103202/diff/diff
> 
> 
> Testing
> ---
> 
> Compiled, Plasma Desktop no longer crashes on exit.
> 
> 
> Thanks,
> 
> Ben Cooksley
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Fix Notes applet crash on load

2011-11-22 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103203/#review8388
---


This review has been submitted with commit 
f94d509f9303f32311ec49012ed620f04fee8ddf by Ben Cooksley to branch master.

- Commit Hook


On Nov. 22, 2011, 8:42 a.m., Ben Cooksley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103203/
> ---
> 
> (Updated Nov. 22, 2011, 8:42 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Fix a crash that always occurs with Plasma when trying to load the Notes 
> applet.
> 
> 
> Diffs
> -
> 
>   applets/notes/notes.cpp 4ce6c3a 
> 
> Diff: http://git.reviewboard.kde.org/r/103203/diff/diff
> 
> 
> Testing
> ---
> 
> Compiled, tried starting it with Plasmoid Viewer - no longer crashes.
> 
> 
> Thanks,
> 
> Ben Cooksley
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Fix Notes applet crash on load

2011-11-22 Thread Aaron J. Seigo

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103203/#review8387
---

Ship it!


Ship It!

- Aaron J. Seigo


On Nov. 22, 2011, 8:42 a.m., Ben Cooksley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103203/
> ---
> 
> (Updated Nov. 22, 2011, 8:42 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Fix a crash that always occurs with Plasma when trying to load the Notes 
> applet.
> 
> 
> Diffs
> -
> 
>   applets/notes/notes.cpp 4ce6c3a 
> 
> Diff: http://git.reviewboard.kde.org/r/103203/diff/diff
> 
> 
> Testing
> ---
> 
> Compiled, tried starting it with Plasmoid Viewer - no longer crashes.
> 
> 
> Thanks,
> 
> Ben Cooksley
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Thomas Lübking


> On Nov. 22, 2011, 9:24 a.m., Thomas Lübking wrote:
> > plasma/private/containment_p.h, line 71
> > 
> >
> > ibeg your pardon?
> > to me this looks like you delete the same entry forever (what *will* 
> > crash at a point) since you don't remove it - should be "takeFirst", yesno?
> 
> Ben Cooksley wrote:
> Other code handles this for us - which is why qDeleteAll() crashes.

sorry, but the only way i see this could be correct is that qlist (fun with 
templates) subclasses pointer Types and reimplements delete to automatically 
remove them from the list, what is, nicely spoken, sick.
is there any detailed (official) explanation on this?


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103202/#review8384
---


On Nov. 22, 2011, 7:39 a.m., Ben Cooksley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103202/
> ---
> 
> (Updated Nov. 22, 2011, 7:39 a.m.)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Description
> ---
> 
> Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. This 
> patch fixes one of those scenarios to ensure that Plasma Desktop does not 
> crash on quit or logout.
> 
> 
> Diffs
> -
> 
>   plasma/private/containment_p.h 4025bf4 
> 
> Diff: http://git.reviewboard.kde.org/r/103202/diff/diff
> 
> 
> Testing
> ---
> 
> Compiled, Plasma Desktop no longer crashes on exit.
> 
> 
> Thanks,
> 
> Ben Cooksley
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Ben Cooksley


> On Nov. 22, 2011, 9:24 a.m., Thomas Lübking wrote:
> > plasma/private/containment_p.h, line 71
> > 
> >
> > ibeg your pardon?
> > to me this looks like you delete the same entry forever (what *will* 
> > crash at a point) since you don't remove it - should be "takeFirst", yesno?

Other code handles this for us - which is why qDeleteAll() crashes.


- Ben


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103202/#review8384
---


On Nov. 22, 2011, 7:39 a.m., Ben Cooksley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103202/
> ---
> 
> (Updated Nov. 22, 2011, 7:39 a.m.)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Description
> ---
> 
> Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. This 
> patch fixes one of those scenarios to ensure that Plasma Desktop does not 
> crash on quit or logout.
> 
> 
> Diffs
> -
> 
>   plasma/private/containment_p.h 4025bf4 
> 
> Diff: http://git.reviewboard.kde.org/r/103202/diff/diff
> 
> 
> Testing
> ---
> 
> Compiled, Plasma Desktop no longer crashes on exit.
> 
> 
> Thanks,
> 
> Ben Cooksley
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Thomas Lübking

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103202/#review8384
---



plasma/private/containment_p.h


ibeg your pardon?
to me this looks like you delete the same entry forever (what *will* crash 
at a point) since you don't remove it - should be "takeFirst", yesno?


- Thomas Lübking


On Nov. 22, 2011, 7:39 a.m., Ben Cooksley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103202/
> ---
> 
> (Updated Nov. 22, 2011, 7:39 a.m.)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Description
> ---
> 
> Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. This 
> patch fixes one of those scenarios to ensure that Plasma Desktop does not 
> crash on quit or logout.
> 
> 
> Diffs
> -
> 
>   plasma/private/containment_p.h 4025bf4 
> 
> Diff: http://git.reviewboard.kde.org/r/103202/diff/diff
> 
> 
> Testing
> ---
> 
> Compiled, Plasma Desktop no longer crashes on exit.
> 
> 
> Thanks,
> 
> Ben Cooksley
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: bug killing

2011-11-22 Thread Christoph Feck
On Tuesday 22 November 2011 09:54:48 todd rme wrote:
> On Tue, Nov 22, 2011 at 9:29 AM, Christoph Feck 
 wrote:
> > On Tuesday 22 November 2011 01:30:46 todd rme wrote:
> >> Is there a feature for bugzilla that allows users to flag bugs
> >> as being fixed, duplicate, upstream, downstream, etc?
> > 
> > You can use https://bugs.kde.org/enter_sysadmin_request.cgi and
> > select component "bugzilla" to request the rights to edit bugs.
> > If needed, you can mention me as an approver.
> > 
> > Christoph Feck (kdepepo)
> > KDE Quality Team
> 
> Thanks!  I will do so.

Great, looking forward to your participation in bug squashing ;)

> But this isn't really about me specifically, it is a way for any
> user to make the bug triaging load easier.  Even if users aren't
> specifically hunting for bugs that should be closed, they can
> still stumble upon them when using bko normally, and when they do
> it would be helpful if there was a way for them to notify
> developers about the issue so it can be fixed.

Usually adding a comment to the bug should be sufficient, as the 
maintainer of the application receiving the message will close the bug 
later. Mentioning "bug XY can be closed because it was fixed in KDE 
4.x.y" in #kde-bugs might work, too.

Plasma bug list is a bit different. It does not have a maintainer 
looking at the messages regularily, so those messages are lost in 
noise, as you already mentioned.

> Of course we
> can't just give every user admin rights, the final decision would
> still have to go through someone trusted,

Exactly. Sometimes I even have to reopen bugs from users that reported 
and closed their own bugs ;)

> but the people who have
> the authority to make a decision can't if they don't know the
> issue exists.  Hence a dedicated way to inform them would help, I
> think.

The sysadmin request does exactly that, or am I missing something?

> -Todd
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: bug killing

2011-11-22 Thread todd rme
On Tue, Nov 22, 2011 at 9:29 AM, Christoph Feck  wrote:
> On Tuesday 22 November 2011 01:30:46 todd rme wrote:
>> Is there a feature for bugzilla that allows users to flag bugs as
>> being fixed, duplicate, upstream, downstream, etc?
>
> You can use https://bugs.kde.org/enter_sysadmin_request.cgi and select
> component "bugzilla" to request the rights to edit bugs. If needed,
> you can mention me as an approver.
>
> Christoph Feck (kdepepo)
> KDE Quality Team

Thanks!  I will do so.

But this isn't really about me specifically, it is a way for any user
to make the bug triaging load easier.  Even if users aren't
specifically hunting for bugs that should be closed, they can still
stumble upon them when using bko normally, and when they do it would
be helpful if there was a way for them to notify developers about the
issue so it can be fixed.   Of course we can't just give every user
admin rights, the final decision would still have to go through
someone trusted, but the people who have the authority to make a
decision can't if they don't know the issue exists.  Hence a dedicated
way to inform them would help, I think.

-Todd
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request: Fix Notes applet crash on load

2011-11-22 Thread Ben Cooksley

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103203/
---

Review request for Plasma.


Description
---

Fix a crash that always occurs with Plasma when trying to load the Notes applet.


Diffs
-

  applets/notes/notes.cpp 4ce6c3a 

Diff: http://git.reviewboard.kde.org/r/103203/diff/diff


Testing
---

Compiled, tried starting it with Plasmoid Viewer - no longer crashes.


Thanks,

Ben Cooksley

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: bug killing

2011-11-22 Thread Christoph Feck
On Tuesday 22 November 2011 01:30:46 todd rme wrote:
> Is there a feature for bugzilla that allows users to flag bugs as
> being fixed, duplicate, upstream, downstream, etc?

You can use https://bugs.kde.org/enter_sysadmin_request.cgi and select 
component "bugzilla" to request the rights to edit bugs. If needed, 
you can mention me as an approver.

Christoph Feck (kdepepo)
KDE Quality Team
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103202/#review8379
---


This review has been submitted with commit 
f02884d36bc6ff4db4453b43d088c7226acfdf6e by Ben Cooksley to branch KDE/4.7.

- Commit Hook


On Nov. 22, 2011, 7:39 a.m., Ben Cooksley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103202/
> ---
> 
> (Updated Nov. 22, 2011, 7:39 a.m.)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Description
> ---
> 
> Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. This 
> patch fixes one of those scenarios to ensure that Plasma Desktop does not 
> crash on quit or logout.
> 
> 
> Diffs
> -
> 
>   plasma/private/containment_p.h 4025bf4 
> 
> Diff: http://git.reviewboard.kde.org/r/103202/diff/diff
> 
> 
> Testing
> ---
> 
> Compiled, Plasma Desktop no longer crashes on exit.
> 
> 
> Thanks,
> 
> Ben Cooksley
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request: Ensure Plasma Desktop does not crash on exit with Qt 4.8

2011-11-22 Thread Aaron J. Seigo

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103202/#review8378
---

Ship it!


this is massively bad on the part of qt :/ what a crazy, crazy regression. in 
any case, yes, this can go in, and the commit should mark BUG:284989

- Aaron J. Seigo


On Nov. 22, 2011, 7:39 a.m., Ben Cooksley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103202/
> ---
> 
> (Updated Nov. 22, 2011, 7:39 a.m.)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Description
> ---
> 
> Qt 4.8 contains changes which break qDeleteAll() in certain scenarios. This 
> patch fixes one of those scenarios to ensure that Plasma Desktop does not 
> crash on quit or logout.
> 
> 
> Diffs
> -
> 
>   plasma/private/containment_p.h 4025bf4 
> 
> Diff: http://git.reviewboard.kde.org/r/103202/diff/diff
> 
> 
> Testing
> ---
> 
> Compiled, Plasma Desktop no longer crashes on exit.
> 
> 
> Thanks,
> 
> Ben Cooksley
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: bug killing

2011-11-22 Thread Gregor Tätzner
Am Dienstag, 22. November 2011, 01:30:46 schrieb todd rme:
> On Sun, Nov 20, 2011 at 9:37 PM, Aaron J. Seigo  wrote:
> > if you have other ideas, let me know.
> 
> Is there a feature for bugzilla that allows users to flag bugs as
> being fixed, duplicate, upstream, downstream, etc?  I know people with
> administrator rights can close bugs in this way, but if
> non-admisitrator users could flag bugs so that people with
> administrator rights would get notified that the bug should be closed
> it might make triaging easier.
> 
> I often encounter bugs that are duplicate, fixed, etc, and I post a
> comment on the bug report to that effect, but the comments seem to
> rarely be acted upon, probably because they appear the same as all the
> other random comments and thus get lost in all the noise coming from
> bko.  So if there was some special way to notify devs about bugs that
> should be fixed, one that won't as easily get lost amongst ordinary
> comments, it might make things easier for everyone.  But such a
> feature may not exist for bugzilla.
> 
> -Todd
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel

+1 that would be great! I have the same problem and *don't* know people with 
admin rights.


-- 
The way some people find fault, you'd think there was some kind of reward.


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel