Re: Review Request: RSSNOW QML:reset the timer on click and some coding style fixes.

[Aaron J. Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103347/#review8761
---


currently the arrow buttons don't actually move the listing forward or back, 
which i assume will be in another patch?


rssnow/package/contents/ui/ListItemEntry.qml


if the arrows were both in the same svg, this would be more efficient (they 
would share a the svg renderer behind the scenes)



rssnow/package/contents/ui/main.qml


this may be more easily / clearly expressed as:

entryLIst.currentIndex = (entryList.currentIndex + 1) % entryList.count


- Aaron J. Seigo


On Dec. 6, 2011, 2:28 p.m., Giorgos Tsiapaliwkas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103347/
> ---
> 
> (Updated Dec. 6, 2011, 2:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Hello,
> 
> the Timer component will reset to zero when the user clicks the arrows.
> Also i made some fixes in the coding style.
> 
> thanks in advance
> 
> 
> Diffs
> -
> 
>   rssnow/package/contents/ui/ListItemEntry.qml dac3f93 
>   rssnow/package/contents/ui/main.qml e39a1f6 
> 
> Diff: http://git.reviewboard.kde.org/r/103347/diff/diff
> 
> 
> Testing
> ---
> 
> everything is ok
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: port dictionary qml to Plasma Components

[Marco Martin]

> On Nov. 17, 2011, 11:34 a.m., Marco Martin wrote:
> > dictionary/package/contents/ui/main.qml, line 80
> > 
> >
> > clearbuttonShown is available again in the textfield api, so it can stay
> 
> Giorgos Tsiapaliwkas wrote:
> Sorry for the delay..
> I added the clearButtonShown: true
> but i received the error that the property doesn't exist.
> 
> Aaron J. Seigo wrote:
> probably due to marco having a newer build than you did at the time? 
> please push this into git in a branch if it isn't already so we can have it 
> for merging into 4.9.

yes, you need newer kde-runtime (and yes in 4.8 rlease that property is present)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103143/#review8259
---


On Nov. 15, 2011, 3:54 p.m., Giorgos Tsiapaliwkas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103143/
> ---
> 
> (Updated Nov. 15, 2011, 3:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Hello,
> 
> i ported the plasmoid to the plasma components and also add an archors 
> property in order to be rendered properly.
> 
> 
> Diffs
> -
> 
>   dictionary/package/contents/ui/main.qml e9cb9fc 
> 
> Diff: http://git.reviewboard.kde.org/r/103143/diff/diff
> 
> 
> Testing
> ---
> 
> the PlasmaWidget.WebView doesn't expand in all the entire layout of the 
> plasmoid.
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: RSSNOW QML:reset the timer on click and some coding style fixes.

[Artur Duque de Souza]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103347/#review8755
---

Ship it!


Ship It!

- Artur Duque de Souza


On Dec. 6, 2011, 2:28 p.m., Giorgos Tsiapaliwkas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103347/
> ---
> 
> (Updated Dec. 6, 2011, 2:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Hello,
> 
> the Timer component will reset to zero when the user clicks the arrows.
> Also i made some fixes in the coding style.
> 
> thanks in advance
> 
> 
> Diffs
> -
> 
>   rssnow/package/contents/ui/ListItemEntry.qml dac3f93 
>   rssnow/package/contents/ui/main.qml e39a1f6 
> 
> Diff: http://git.reviewboard.kde.org/r/103347/diff/diff
> 
> 
> Testing
> ---
> 
> everything is ok
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: RSSNOW QML:reset the timer on click and some coding style fixes.

[Giorgos Tsiapaliwkas]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103347/
---

Review request for Plasma.


Description
---

Hello,

the Timer component will reset to zero when the user clicks the arrows.
Also i made some fixes in the coding style.

thanks in advance


Diffs
-

  rssnow/package/contents/ui/ListItemEntry.qml dac3f93 
  rssnow/package/contents/ui/main.qml e39a1f6 

Diff: http://git.reviewboard.kde.org/r/103347/diff/diff


Testing
---

everything is ok


Thanks,

Giorgos Tsiapaliwkas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: plasmoid qalculate - menu button

[Aaron J. Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103052/#review8754
---



applets/qalculate/qalculate_applet.cpp


this looks wrong. it should be put into a layout somewhere and managed that 
way. in particular, this will break with larger fonts.



applets/qalculate/qalculate_applet.cpp


if this is to make m_output appear before m_historyButton in the layout, 
use insertItem instead of addItem :)


- Aaron J. Seigo


On Nov. 11, 2011, 5:41 p.m., Greg T wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103052/
> ---
> 
> (Updated Nov. 11, 2011, 5:41 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Hey dudes,
> I implemented a little menu that displays the last 10 results. improvement 
> ideas?
> 
> I found this task in the plasma task list: 
> http://community.kde.org/Plasma/Tasks#Kalgebra_and_Qalculate_Plasmoid
> 
> 
> Diffs
> -
> 
>   applets/qalculate/qalculate_applet.h aee14c0 
>   applets/qalculate/qalculate_applet.cpp 4da9241 
>   applets/qalculate/qalculate_history.h 59185ee 
>   applets/qalculate/qalculate_history.cpp 35592a7 
> 
> Diff: http://git.reviewboard.kde.org/r/103052/diff/diff
> 
> 
> Testing
> ---
> 
> seems to work
> 
> 
> Thanks,
> 
> Greg T
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: port dictionary qml to Plasma Components

[Aaron J. Seigo]

> On Nov. 17, 2011, 11:34 a.m., Marco Martin wrote:
> > dictionary/package/contents/ui/main.qml, line 80
> > 
> >
> > clearbuttonShown is available again in the textfield api, so it can stay
> 
> Giorgos Tsiapaliwkas wrote:
> Sorry for the delay..
> I added the clearButtonShown: true
> but i received the error that the property doesn't exist.

probably due to marco having a newer build than you did at the time? please 
push this into git in a branch if it isn't already so we can have it for 
merging into 4.9.


- Aaron J.


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103143/#review8259
---


On Nov. 15, 2011, 3:54 p.m., Giorgos Tsiapaliwkas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103143/
> ---
> 
> (Updated Nov. 15, 2011, 3:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Hello,
> 
> i ported the plasmoid to the plasma components and also add an archors 
> property in order to be rendered properly.
> 
> 
> Diffs
> -
> 
>   dictionary/package/contents/ui/main.qml e9cb9fc 
> 
> Diff: http://git.reviewboard.kde.org/r/103143/diff/diff
> 
> 
> Testing
> ---
> 
> the PlasmaWidget.WebView doesn't expand in all the entire layout of the 
> plasmoid.
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Bugfix: Plasma::PackageMetadata::read: Match the behavior of KService

[Aaron J. Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102404/#review8748
---

Ship it!


sorry this one slipped through the cracks. it looks good to go.

note that in frameworks, there is no packagemetadata anymore.

- Aaron J. Seigo


On Aug. 22, 2011, 12:49 a.m., Kevin Kofler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102404/
> ---
> 
> (Updated Aug. 22, 2011, 12:49 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Also delete the duplicate entries in PackageMetadata::write.
> 
> 
> This one is a bugfix, and so should be OK for 4.7.
> 
> While testing my GSoC work, I noticed that Plasma::PackageMetadata::read only 
> looks for X-KDE-ServiceTypes, whereas KService concatenates the contents of 
> ServiceTypes and X-KDE-ServiceTypes. There are metadata.desktop files out 
> there using ServiceTypes without the X-KDE prefix.
> 
> I also fixed it to look for both Keywords and X-KDE-Keywords as KService 
> does, not just Keywords.
> 
> 
> Diffs
> -
> 
>   plasma/packagemetadata.cpp 59163b2 
> 
> Diff: http://git.reviewboard.kde.org/r/102404/diff/diff
> 
> 
> Testing
> ---
> 
> Compiles on Fedora 15.
> 
> 
> Thanks,
> 
> Kevin Kofler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

bug triage motivational message ;)

[Aaron J. Seigo]

hi all ...

currently, we are 57 reports away from having "only" 1000 open reports!
we are also 85 away from having fewer open reports than kopete.

my current goal for 4.8 and reports is to get and then keep the report count 
under 1000 for the whole 4.8 series.

during the 4.9 and 4.10 dev cycles, we can try to half that number and reach 
the Big Goal that Martin proposed of getting it down to ~500 reports and then 
hold it there (or lower :) from that point going forward.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate:now StartPage::createNewProject() creates the plasmateprojectrc and not the StartPage::loadLocalProject()

[Giorgos Tsiapaliwkas]

> On Nov. 28, 2011, 3:46 p.m., Aaron J. Seigo wrote:
> > now that's a nice simplification :)
> 
> Aaron J. Seigo wrote:
> one other note: please be sure that all the rest of the plasmate code 
> that assumes this directory structure (if any) is modified to work properly 
> with this new approach.

done and pushed :)


- Giorgos


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102732/#review8567
---


On Nov. 28, 2011, 2:52 p.m., Giorgos Tsiapaliwkas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102732/
> ---
> 
> (Updated Nov. 28, 2011, 2:52 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Hello,
> 
> for the moment the .plasmateprojectrc file exists as a mark for the projects 
> created by plasmate.
> We want the file to be created in the creation of the project not in the load 
> of the project,the patch does that.
> 
> cheers
> 
> 
> Diffs
> -
> 
>   mainwindow.cpp 6ea7f0c 
>   startpage.h f16af4b 
>   startpage.cpp 75052b1 
> 
> Diff: http://git.reviewboard.kde.org/r/102732/diff/diff
> 
> 
> Testing
> ---
> 
> workinig
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel