Re: Review Request: RSSNOW QML:reset the timer on click and some coding style fixes.

[Giorgos Tsiapaliwkas]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103347/
---

(Updated Dec. 16, 2011, 12:12 p.m.)


Review request for Plasma.


Changes
---

Hello,

sorry for the delay.

The above patch is incorrect,i think that the already existing mouse area 
conflicts with mines.

I tried to merge the two svgs,but karbon destroys the new file(its contents are 
empty).


Description
---

Hello,

the Timer component will reset to zero when the user clicks the arrows.
Also i made some fixes in the coding style.

thanks in advance


Diffs (updated)
-

  rssnow/package/contents/ui/ListItemEntry.qml dac3f93 
  rssnow/package/contents/ui/main.qml e39a1f6 

Diff: http://git.reviewboard.kde.org/r/103347/diff/diff


Testing
---

everything is ok


Thanks,

Giorgos Tsiapaliwkas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: RSSNOW QML:reset the timer on click and some coding style fixes.

[Giorgos Tsiapaliwkas]

> On Dec. 6, 2011, 3:51 p.m., Aaron J. Seigo wrote:
> > currently the arrow buttons don't actually move the listing forward or 
> > back, which i assume will be in another patch?

Do you mean that the plasmoid's rss list doesn't go to the next one?
Please check again the new patch since the previous was wrong.


- Giorgos


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103347/#review8761
---


On Dec. 16, 2011, 12:12 p.m., Giorgos Tsiapaliwkas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103347/
> ---
> 
> (Updated Dec. 16, 2011, 12:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Hello,
> 
> the Timer component will reset to zero when the user clicks the arrows.
> Also i made some fixes in the coding style.
> 
> thanks in advance
> 
> 
> Diffs
> -
> 
>   rssnow/package/contents/ui/ListItemEntry.qml dac3f93 
>   rssnow/package/contents/ui/main.qml e39a1f6 
> 
> Diff: http://git.reviewboard.kde.org/r/103347/diff/diff
> 
> 
> Testing
> ---
> 
> everything is ok
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: problem with icontask and javascript

[Aaron J. Seigo]

On Friday, December 16, 2011 07:29:45 Nowardev-Team wrote:
> var icontasks = panel.addWidget("icontasks")
> icontasks.writeConfig("groupClick","1")
> icontasks.writeConfig("unity","true")
> //icontasks.writeConfig("Enabled","true")
> 
> icontasks.writeConfig("Items","file:///usr/share/applications/firefox.deskto
> p?wmClass=Firefox,file:///usr/share/applications/kde4/kate.desktop?wmClass=K
> ate,file:///usr/share/applications/kde4/konversation.desktop?wmClass=Konvers
> ation,file:usr/share/applications/kde4/dolphin.desktop?wmClass=Dolphin,f
> ile:///usr/share/applications/chromium-browser.desktop?wmClass=Chromium-brow
> ser,file:///usr/share/applications/kde4/konsole.desktop?wmClass=Konsole,file
> :///usr/share/applications/kde4/ksnapshot.desktop?wmClass=Ksnapshot,file:///
> usr/share/applications/kde4/systemsettings.desktop?wmClass=Systemsettings")

> *I'm not 100% sure, by Launchers are in a different group.*

from http://techbase.kde.org/KDE_System_Administration/PlasmaDesktopScripting

Array[String] currentConfigGroup: 

the current configuration group path, with each entry in the array representing 
a sub-group. This allows one to access trees of groups with code such as: 
widget.currentConfigGroup = new Array('topGroup', 'subGroupOfTopGroup'). An 
empty Array means the default (top-level) configuration group for the widget


so you probably want sth like:

icontasks.currentConfigGroup = new Array('Launchers')
icontasks.writeConfig("Items", "")

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp

[Aaron J. Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103393/#review9006
---

Ship it!


looks good except for one small issue (see below), but is generally ready to go 
in. as this includes a new string, this needs to wait until 4.9 development 
opens up (should happen early in january).


plasma/applets/folderview/folderview.cpp


just realized one more issue ... if the m_url is set twice in a row to a 
non-local file, then it will connect to this signal multiple times. this is 
easily controlled, however, by adding Qt::UniqueConnection to the parameters 
passed to connect.


- Aaron J. Seigo


On Dec. 16, 2011, 6:20 a.m., Sujith Haridasan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103393/
> ---
> 
> (Updated Dec. 16, 2011, 6:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Adding patch for the TODO, mentioned in the folderview.cpp file. This patch 
> looks whether the url is local or remote. If its remote then checks for the 
> network status of the host machine. If the host machine is not connected to 
> the network then returns.
> 
> 
> Diffs
> -
> 
>   plasma/applets/folderview/folderview.h 4896f07 
>   plasma/applets/folderview/folderview.cpp 43d0511 
> 
> Diff: http://git.reviewboard.kde.org/r/103393/diff/diff
> 
> 
> Testing
> ---
> 
> Tested by removing the host from the network and by adding the host to the 
> network.
> 
> 
> Thanks,
> 
> Sujith Haridasan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: RSSNOW QML:reset the timer on click and some coding style fixes.

[Aaron J. Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103347/#review9007
---


try using inkscape rather than carbon for the svg changes.

- Aaron J. Seigo


On Dec. 16, 2011, 12:12 p.m., Giorgos Tsiapaliwkas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103347/
> ---
> 
> (Updated Dec. 16, 2011, 12:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Hello,
> 
> the Timer component will reset to zero when the user clicks the arrows.
> Also i made some fixes in the coding style.
> 
> thanks in advance
> 
> 
> Diffs
> -
> 
>   rssnow/package/contents/ui/ListItemEntry.qml dac3f93 
>   rssnow/package/contents/ui/main.qml e39a1f6 
> 
> Diff: http://git.reviewboard.kde.org/r/103347/diff/diff
> 
> 
> Testing
> ---
> 
> everything is ok
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Activities Dataengine: avoid calling KActivities::Controller::listActivities() unnecessarily

[Aaron J. Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103358/#review9008
---

Ship it!



plasma/generic/dataengines/activities/activityengine.cpp


can be made const.


- Aaron J. Seigo


On Dec. 16, 2011, 12:25 a.m., Romário Rios wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103358/
> ---
> 
> (Updated Dec. 16, 2011, 12:25 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> Avoid calling listActivities to get the list of running activities everytime 
> by getting it once, storing it in a private member and modifying this member 
> as activities come and go.
> 
> 
> Diffs
> -
> 
>   plasma/generic/dataengines/activities/activityengine.h cbbf94c 
>   plasma/generic/dataengines/activities/activityengine.cpp 9436c34 
> 
> Diff: http://git.reviewboard.kde.org/r/103358/diff/diff
> 
> 
> Testing
> ---
> 
> Tested it now, removed some activities, added some more, stopped another 
> bunch, and it seems to work just fine as long as I tested.
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Breadcrumbs in Kickoff

[Xavier Sythe]

Hello.

It came to my attention that, in this commit;
https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/388b01e979f1959636657b14d03ae70fd0a3d3a8

Kevin Ottens added the breadcrumb navigation in Kickoff, whilst removing
the original navigation bar.

Nearly two months ago, I contacted him, and asked him to reverse the
controversial commit.
He has yet to reply.

When I asked the #KDE IRC channel about this, I was told to contact the
members of this mailing list, to see if I could get the commit reversed.

Thanks,
Xavier
*
*
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma Logs

[Steven Sroka]

Hello,

I'm testing out KDE 4.8 and plasma-desktop keeps crashing
unfortunately. Is there anyway that I can debug it? Are there any log
files I can take a look at?

-- 
Steven Sroka
(lin-unix)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Reset time format upon user request

[Lamarque Vieira Souza]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103434/
---

Review request for kdelibs and Plasma.


Description
---

The patch resets time format in digital clock plasmoid when the user changes 
the 24h configuration in active-settings.

The reset part is from kdelibs/kdecore/localization/klocale_kde.cpp. I am 
wondering if I should add this change to kdelibs instead of kde-workspace to 
avoid duplicating code. Anyway, I wanted someone to review the code to see if 
there can be any side effect.


This addresses bug 289094.
http://bugs.kde.org/show_bug.cgi?id=289094


Diffs
-

  plasma/generic/applets/digital-clock/clock.h 4aec3fd 
  plasma/generic/applets/digital-clock/clock.cpp dd03692 

Diff: http://git.reviewboard.kde.org/r/103434/diff/diff


Testing
---

Works in Plasma Active. In Plasma Desktop kcmlocale does not call 
KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged) so it 
does not take effect. Other kcm modules (e.g. keyboard), call emitChange.


Thanks,

Lamarque Vieira Souza

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Logs

[Shaun Reich]

On Fri, Dec 9, 2011 at 11:18 PM, Steven Sroka  wrote:
> Hello,
>
> I'm testing out KDE 4.8 and plasma-desktop keeps crashing
> unfortunately. Is there anyway that I can debug it? Are there any log
> files I can take a look at?

have a look at ~/.session-errors.

Although it's probably better/easier to just open a terminal and
launch plasma-desktop (when there are no plasma-desktops running,
obviously). which will give the plasma-only output directly.

Then you can also run it through gdb if you have debug symbols on.

-- 
Shaun Reich,
KDE Software Developer (kde.org)
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Reset time format upon user request

[Aaron J. Seigo]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103434/#review9018
---


i've made it so that kcmlocale also emit the signal ... now we just need to put 
the code into the right place, wh ich i imagine is klocale_kde.cpp. it would be 
nice if KLocale also had a signal for when it changed the time format so that 
we could know for sure when it was doing with the changes instead of listening 
to the generic KGlobalSettings signal?


plasma/generic/applets/digital-clock/clock.cpp


this part belongs in klocale for sure. since this will affect all time 
keeping bits. the clock will still need to call generatePixmap() and update() 
though.

also, this should be checking what has been changed and only changing on 
SettingsChanged. (we don't need to do this on, for instance, icon or cursor 
changes ;)


- Aaron J. Seigo


On Dec. 16, 2011, 6:35 p.m., Lamarque Vieira Souza wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103434/
> ---
> 
> (Updated Dec. 16, 2011, 6:35 p.m.)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Description
> ---
> 
> The patch resets time format in digital clock plasmoid when the user changes 
> the 24h configuration in active-settings.
> 
> The reset part is from kdelibs/kdecore/localization/klocale_kde.cpp. I am 
> wondering if I should add this change to kdelibs instead of kde-workspace to 
> avoid duplicating code. Anyway, I wanted someone to review the code to see if 
> there can be any side effect.
> 
> 
> This addresses bug 289094.
> http://bugs.kde.org/show_bug.cgi?id=289094
> 
> 
> Diffs
> -
> 
>   plasma/generic/applets/digital-clock/clock.h 4aec3fd 
>   plasma/generic/applets/digital-clock/clock.cpp dd03692 
> 
> Diff: http://git.reviewboard.kde.org/r/103434/diff/diff
> 
> 
> Testing
> ---
> 
> Works in Plasma Active. In Plasma Desktop kcmlocale does not call 
> KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged) so it 
> does not take effect. Other kcm modules (e.g. keyboard), call emitChange.
> 
> 
> Thanks,
> 
> Lamarque Vieira Souza
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breadcrumbs in Kickoff

[Martin Gräßlin]

On Thursday 08 December 2011 16:01:33 Xavier Sythe wrote:
> Nearly two months ago, I contacted him, and asked him to reverse the
> controversial commit.
> He has yet to reply.
Please understand that not each developer has the time to answer personal
requests. You state yourself that it is controversial. Just imagine each user
disliking the feature sending a mail to Kevin. That just doesn't scale.

Asking to revert the feature is to be honest non-constructive criticism. Like
all other decisions on the default user interface they are done with care. The
breadcrumbs add high value to Kickoff. It makes navigation in a folder like
structure like the application menu more convenient and much more consistant
with other parts of KDE applications, e.g. Dolphin's breadcrumb navigation.

Just because you (and others) dislike the new feature it does not justify to
revert the commit. There are also users liking the feature, so how should we
suit both groups? Now please don't state that we need an option for that. This
is not possible as the code gets too complex and too difficult to maintain.
>
> When I asked the #KDE IRC channel about this, I was told to contact the
> members of this mailing list, to see if I could get the commit reversed.
Reverting the commit is clearly not an option. But what would you say about
improving the breadcrumbs in Kickoff? Getting them into a state that you want
to use them and not the out-of-place back button?

Have a look at my recent blog post [1] about the work on Kickoff for 4.9. It
is easy to give this version a try, it installs alongside the existing
Kickoff. I personally do not see any need for the back button any more.

Kind Regards
Martin Gräßlin

New Kickoff Maintainer after branch merged into master

[1] http://blog.martin-graesslin.com/blog/2011/12/experience-from-porting-
kickoff-to-qml/

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: icon plasmoid - http url naming

[Greg T]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103435/
---

Review request for Plasma.


Description
---

I added a special case so the desktop icon gets a pretty name when you drag and 
drop a link onto your desktop. Additional, a regex strips out the protocol 
(like in firefox) 


This addresses bug 199811.
http://bugs.kde.org/show_bug.cgi?id=199811


Diffs
-

  plasma/generic/applets/icon/icon.cpp b25e5d6 

Diff: http://git.reviewboard.kde.org/r/103435/diff/diff


Testing
---

looks good


Thanks,

Greg T

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Reset time format upon user request

[Lamarque Vieira Souza]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103434/
---

(Updated Dec. 16, 2011, 9:13 p.m.)


Review request for kdelibs and Plasma.


Changes
---

Use KGlobal::locale()->setLanguage() to force reading the configuration file 
instead of duplicating kdelibs code.

Use KGlobalSettings::SETTINGS_COMPLETION category to decide when take action. I 
have not found a better category, the available are: SETTINGS_MOUSE, 
SETTINGS_COMPLETION, SETTINGS_PATHS, SETTINGS_POPUPMENU, SETTINGS_QT, 
SETTINGS_SHORTCUTS. There is no documentation about how use those categories in 
kglobalsettings.h.

There are several other set*() methods in klocale_kde.h. Adding a signal only 
for TimeFormat change will not solve the problem for them, specialy for 
set*Date*(), which are other calls that the clock plasmoid is interested in.

Maybe KLocale could have a localeChanged(changedSetting) signal, indicating 
what has changed. On the other hand... sending a signal for every KLocale's 
setting change sounds a little overkill.


Description
---

The patch resets time format in digital clock plasmoid when the user changes 
the 24h configuration in active-settings.

The reset part is from kdelibs/kdecore/localization/klocale_kde.cpp. I am 
wondering if I should add this change to kdelibs instead of kde-workspace to 
avoid duplicating code. Anyway, I wanted someone to review the code to see if 
there can be any side effect.


This addresses bug 289094.
http://bugs.kde.org/show_bug.cgi?id=289094


Diffs (updated)
-

  plasma/generic/applets/digital-clock/clock.h 4aec3fd 
  plasma/generic/applets/digital-clock/clock.cpp dd03692 

Diff: http://git.reviewboard.kde.org/r/103434/diff/diff


Testing
---

Works in Plasma Active. In Plasma Desktop kcmlocale does not call 
KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged) so it 
does not take effect. Other kcm modules (e.g. keyboard), call emitChange.


Thanks,

Lamarque Vieira Souza

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Add multiple feeds to rssnow (Qml) plasmoid

[Antonis Tsiapaliokas]

Hello

I am creating a patch, for adding multiple feeds to rssnow (Qml) plasmoid,
but i have stuck and i need some help.
The c++ plasmoid is using signals and custom slots to add/remove feeds from
the plasmoid.
And here is where i stuck. How exactly can i add a custom "slot" to the
rssnow (Qml) plasmoid without using c++?

Regards
Antonis Tsiapaliokas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breadcrumbs in Kickoff

[Xavier Sythe]

Actually, the breadcrumbs don't really need to be removed.
I merely see the need to reinstate the back button.
"I personally do not see any need for the back button any more."

It's mostly a user experience perspective.

It's a simple fact that it requires less mouse movement, hence, less time,
to click the back button, then it does to move your mouse to the top of the
menu, and use the breadcrumbs.  Why?  Because the back button extends all
the way down the length of the menu.  Instead of having to move your mouse
to the top of the menu, then to the left, you can simply move it to the
left and click the button.


"The
breadcrumbs add high value to Kickoff. It makes navigation in a folder like
structure like the application menu more convenient and much more consistant
with other parts of KDE applications, e.g. Dolphin's..."

Just like in Dolphin, this menu style would feature both breadcrumb
navigation, and a back button.

Would you support removing the back button from Dolphin, in favour of just
breadcrumbs?
I doubt that anyone would support that.

I've chatted briefly with the KDE Usability Team, and they actually seemed
to agree with me.

Well some users might stick to the breadcrumb navigation, the majority of
users from previous versions of KDE are accustomed to the back button, and
appreciate its use, both in Kickoff as well as in Dolphin.  Including both
types of navigation will ensure that nobody complains, and presumably, lead
to a better overall user experience.

Thanks,
Xavier Sythe




On Fri, Dec 16, 2011 at 2:12 PM, Martin Gräßlin  wrote:

> On Thursday 08 December 2011 16:01:33 Xavier Sythe wrote:
> > Nearly two months ago, I contacted him, and asked him to reverse the
> > controversial commit.
> > He has yet to reply.
> Please understand that not each developer has the time to answer personal
> requests. You state yourself that it is controversial. Just imagine each
> user
> disliking the feature sending a mail to Kevin. That just doesn't scale.
>
> Asking to revert the feature is to be honest non-constructive criticism.
> Like
> all other decisions on the default user interface they are done with care.
> The
> breadcrumbs add high value to Kickoff. It makes navigation in a folder like
> structure like the application menu more convenient and much more
> consistant
> with other parts of KDE applications, e.g. Dolphin's breadcrumb navigation.
>
> Just because you (and others) dislike the new feature it does not justify
> to
> revert the commit. There are also users liking the feature, so how should
> we
> suit both groups? Now please don't state that we need an option for that.
> This
> is not possible as the code gets too complex and too difficult to maintain.
> >
> > When I asked the #KDE IRC channel about this, I was told to contact the
> > members of this mailing list, to see if I could get the commit reversed.
> Reverting the commit is clearly not an option. But what would you say about
> improving the breadcrumbs in Kickoff? Getting them into a state that you
> want
> to use them and not the out-of-place back button?
>
> Have a look at my recent blog post [1] about the work on Kickoff for 4.9.
> It
> is easy to give this version a try, it installs alongside the existing
> Kickoff. I personally do not see any need for the back button any more.
>
> Kind Regards
> Martin Gräßlin
>
> New Kickoff Maintainer after branch merged into master
>
> [1] http://blog.martin-graesslin.com/blog/2011/12/experience-from-porting-
> kickoff-to-qml/
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel