[KDE Bugtracking System] REMINDER: current Plasma regressions
Please find below a list of the current regressions reported for Plasma This search was scheduled by myr...@kde.org. Plasma regressions -- Bug 283626: https://bugs.kde.org/show_bug.cgi?id=283626 Priority: NOR Severity: crash Platform: openSUSE RPMs Assignee: plasma-b...@kde.org Status: NEW Summary: plasma-desktop crashes when Adding Widget while ActivityManager is visible [@ ActivityManager::setLocation] Bug 290828: https://bugs.kde.org/show_bug.cgi?id=290828 Priority: NOR Severity: normal Platform: Archlinux Packages Assignee: plasma-b...@kde.org Status: NEW Summary: Widget selections scrolling broken Bug 296117: https://bugs.kde.org/show_bug.cgi?id=296117 Priority: NOR Severity: minor Platform: Other Assignee: plasma-b...@kde.org Status: REOPENED Summary: New Add Widgets dialog does not respect fractional font sizes Bug 297842: https://bugs.kde.org/show_bug.cgi?id=297842 Priority: NOR Severity: normal Platform: Other Assignee: plasma-b...@kde.org Status: NEW Summary: Navigating the list with the keyboard when a search filter is entered Bug 300885: https://bugs.kde.org/show_bug.cgi?id=300885 Priority: NOR Severity: critical Platform: Ubuntu Packages Assignee: plasma-b...@kde.org Status: NEW Summary: Weather widget does not work anymore with bbcuk or wetter.com provider Bug 301424: https://bugs.kde.org/show_bug.cgi?id=301424 Priority: NOR Severity: normal Platform: openSUSE RPMs Assignee: plasma-b...@kde.org Status: NEW Summary: Cannot open battery monitor applet if set to hidden in systray Bug 301460: https://bugs.kde.org/show_bug.cgi?id=301460 Priority: NOR Severity: normal Platform: Other Assignee: plasma-b...@kde.org Status: NEW Summary: Switching activities became really slow Bug 301533: https://bugs.kde.org/show_bug.cgi?id=301533 Priority: NOR Severity: normal Platform: Other Assignee: plasma-b...@kde.org Status: NEW Summary: Option Show Multiple Batteries does nothing Bug 301656: https://bugs.kde.org/show_bug.cgi?id=301656 Priority: NOR Severity: normal Platform: Other Assignee: plasma-b...@kde.org Status: NEW Summary: Installed widgets are not marked as such anymore Bug 301815: https://bugs.kde.org/show_bug.cgi?id=301815 Priority: NOR Severity: normal Platform: Ubuntu Packages Assignee: plasma-b...@kde.org Status: NEW Summary: Plasma widget battery: option to display information on the battery icon has disappeared ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Quality Team: LCD weather station and calendar (in panel) are really broken
On Wednesday, June 13, 2012 18:23:47 Luís Gabriel wrote: Hi, I'm currently working on the QML port of LCD Weather Station as a GSoC project and I'm also identified this problem with some weather providers. I think we should add some information (a flag, maybe) in the data engine to indicate if the weather condition data is available or not and filter the providers in the applet side. What do you guys think? It would be enough for now? +1 and then the BBC UK MET provider should be fixed :) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasmate: when Enable signing plasmoid is enabled, automatically choose a key
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105074/#review14725
---
Ship it!
Ship It!
- Aaron J. Seigo
On June 12, 2012, 11:44 a.m., Giorgos Tsiapaliwkas wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105074/
---
(Updated June 12, 2012, 11:44 a.m.)
Review request for Plasma, Sebastian Kügler and Aaron J. Seigo.
Description
---
Hello,
right now when Enable signing plasmoid is enabled if the user doesn't
choose a gpg key,
plasmate won't have a key enabled. So Enable signing plasmoid, will be
enabled but no signing will
happen.
How to test the issue,
- rm ${KDEHOME}/share/config/plasmaterc
-create a gpg key(gpg --gen-key)
-open plasmate
-click publisher
-click enable
Diffs
-
publisher/signingwidget.h 501752e
publisher/signingwidget.cpp e63dbbd
Diff: http://git.reviewboard.kde.org/r/105074/diff/
Testing
---
It works.
Thanks,
Giorgos Tsiapaliwkas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/#review14726 --- getting closer :) publisher/publisher.cpp http://git.reviewboard.kde.org/r/105032/#comment11620 this code is duplicated by different install methods in this class. as it includes string literals for config keys and groups, this makes it brittle for long term maintenance. consider moving it to a separate private method in this class e.g. QString currentPackagePath() const publisher/publisher.cpp http://git.reviewboard.kde.org/r/105032/#comment11621 this is an implementation detail of RemoteInstaller and as such it should be encapsulated in that class, not here. in fact, it looks like the metadata.desktop filename gets dropped in RemoteInstaller anyway. so this should be made to work without metadata.desktop being appended. publisher/remoteinstaller/remoteinstaller.cpp http://git.reviewboard.kde.org/r/105032/#comment11625 const bool ok publisher/remoteinstaller/remoteinstaller.cpp http://git.reviewboard.kde.org/r/105032/#comment11623 on error, this should probably stop the process, preventing doInstall() from being called. this is most easily done by making doInstall private, calling doInstall at the end of the constructor and returning early from the constructor when the temp url creation fails. publisher/remoteinstaller/remoteinstaller.cpp http://git.reviewboard.kde.org/r/105032/#comment11624 this error needs to be caught in doPlasmaPkg. it is an async job, so the error may not happen until doPlasmaPkg. publisher/remoteinstaller/remoteinstallerdialog.cpp http://git.reviewboard.kde.org/r/105032/#comment11622 doInstall should simply be called from the RemoteInstall object. - Aaron J. Seigo On June 12, 2012, 12:10 p.m., Giorgos Tsiapaliwkas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/ --- (Updated June 12, 2012, 12:10 p.m.) Review request for Plasma. Description --- Hello, in terietor/remoteinstaller I have create a remote installer. The goal is to install the projects remotely to another computer. You access the remote install either inside plasmate or using the plasmaremoteinstaller binary. Diffs - CMakeLists.txt 12f8a3a publisher/publisher.h 5f40ae0 publisher/publisher.cpp fd87364 publisher/remoteinstaller/remoteinstaller.h PRE-CREATION publisher/remoteinstaller/remoteinstaller.cpp PRE-CREATION publisher/remoteinstaller/remoteinstaller.ui PRE-CREATION publisher/remoteinstaller/remoteinstallerdialog.h PRE-CREATION publisher/remoteinstaller/remoteinstallerdialog.cpp PRE-CREATION publisher/remoteinstaller/standalone/main.cpp PRE-CREATION publisher/remoteinstaller/standalone/plasmaremoteinstaller.h PRE-CREATION publisher/remoteinstaller/standalone/plasmaremoteinstaller.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105032/diff/ Testing --- I couldn't find any bugs in the remote installer, but the proccess fails during KIO::copy. Apparently I am not writing correct something in the fish protocol. Right now the remote installer tries to do the above KIO::copy(/home/terietor/.kde4/share/apps/plasmate/project, fish://user@ip/home/user) but it fails Thanks, Giorgos Tsiapaliwkas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fix the minimum size of some applets
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105234/#review14728 --- applets MUST be scalable down to smaller sizes, otherwise they break in small spaces such as panels. setting a minimum size in this fashion does not work as a result. applets/pastebin/pastebin.cpp http://git.reviewboard.kde.org/r/105234/#comment11628 minimumSize needs to be reset here, otherwise it won't fit in panels smaller than the min size set below applets/pastebin/pastebin.cpp http://git.reviewboard.kde.org/r/105234/#comment11629 why 33? applets/showdashboard/showdashboard.cpp http://git.reviewboard.kde.org/r/105234/#comment11630 why 22? applets/systemloadviewer/systemloadviewer.cpp http://git.reviewboard.kde.org/r/105234/#comment11627 incorrect indentation applets/timer/timer.cpp http://git.reviewboard.kde.org/r/105234/#comment11631 this will break it in smaller panels. applets/weatherstation/weatherstation.cpp http://git.reviewboard.kde.org/r/105234/#comment11632 breaks in smaller panels. - Aaron J. Seigo On June 13, 2012, 7:19 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105234/ --- (Updated June 13, 2012, 7:19 p.m.) Review request for Plasma. Description --- This fixes the minimum size of the following applets: showdashboard, systemloadviewer, pastebin, weatherstation and timer. Some sizes were to small, so there were visual glitches and some applets had no minimum value set. I have no commit rights. Diffs - applets/pastebin/pastebin.cpp 208e6a3 applets/showdashboard/showdashboard.cpp 1c2f623 applets/systemloadviewer/systemloadviewer.cpp b852256 applets/timer/timer.cpp ba5ee66 applets/weatherstation/weatherstation.cpp 8ada9c2 Diff: http://git.reviewboard.kde.org/r/105234/diff/ Testing --- Run the applets with their new minimum size, and minimized. Thanks, Maarten De Meyer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Quality Team: LCD weather station and calendar (in panel) are really broken
On 06/14/2012 12:10 PM, Aaron J. Seigo wrote: On Wednesday, June 13, 2012 18:23:47 Luís Gabriel wrote: Hi, I'm currently working on the QML port of LCD Weather Station as a GSoC project and I'm also identified this problem with some weather providers. I think we should add some information (a flag, maybe) in the data engine to indicate if the weather condition data is available or not and filter the providers in the applet side. What do you guys think? It would be enough for now? +1 and then the BBC UK MET provider should be fixed :) You misread the Quality Team mail: we are asking for the LCD Weather Station Applet to be fixed for 4.9 or removed. A QML port will not solve any problem for 4.9 as this QML port will not happen for 4.9. Luís, as you are poring to QML(thank you) I invite you to test the port thoroughly as QML ports had a few regressions. See http://community.kde.org/Getinvolved/Testing/Beta/Plasma#Generic_Plasmoid_Check_List for basic tests that must pass. Aaron, Plasma-team: what about the 4.9 release for which the port is not involved? Anne-Marie Speaking for the Quality Team ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Quality Team: LCD weather station and calendar (in panel) are really broken
On Thursday, June 14, 2012 13:15:34 Anne-Marie Mahfouf wrote: You misread the Quality Team mail: we are asking for the LCD Weather Station Applet to be fixed for 4.9 or removed. i misread nothing. the request for it to be removed is denied. if you consider for a moment what this would do to people's otherwise working installations, not to mention what it would mean for future incentive to fix it, the reason for this should become evident. p.s. i'm very happy that we have a more active Q/A team. i am not happy with how it is sometimes handling issues. there was a commit reverted the other day without checking with the original commiter nor the maintainer of the applet or module which should never have been reverted. fortunately i was on irc and watching commits that day. now we have a no, remove it statement which does not fit the way we develop in plasma, which is: * as a team * with communication i'm sure the QA team can improve over time so that we can all work together better. thanks ... -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Quality Team: LCD weather station and calendar (in panel) are really broken
On Wednesday, June 13, 2012 22:31:36 Anne-Marie Mahfouf wrote: Another applet is in bad shape as well: the Calendar applet when placed in panel. The date does not update when the day changes and the layout is totally broken making the calendar not readable. See these issues are fixed. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Quality Team: LCD weather station and calendar (in panel) are really broken
On 06/14/2012 01:52 PM, Aaron J. Seigo wrote: On Thursday, June 14, 2012 13:15:34 Anne-Marie Mahfouf wrote: You misread the Quality Team mail: we are asking for the LCD Weather Station Applet to be fixed for 4.9 or removed. i misread nothing. the request for it to be removed is denied. if you consider for a moment what this would do to people's otherwise working installations, not to mention what it would mean for future incentive to fix it, the reason for this should become evident. p.s. i'm very happy that we have a more active Q/A team. i am not happy with how it is sometimes handling issues. there was a commit reverted the other day without checking with the original commiter nor the maintainer of the applet or module which should never have been reverted. fortunately i was on irc and watching commits that day. now we have a no, remove it statement which does not fit the way we develop in plasma, which is: * as a team * with communication i'm sure the QA team can improve over time so that we can all work together better. thanks ... The reverted commit was me, annma, not the Quality Team, following a user report and my tests. Do not mix me and the Quality Team, thanks. I apologize publicly for reverted your commit. As for the QA Team, I am not sure how you would like us to communicate better. Anne-Marie PS: the communication worked as you were aware of the Calendar problems and fixed them. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Quality Team: LCD weather station and calendar (in panel) are really broken
On Thu, Jun 14, 2012 at 12:52 PM, Aaron J. Seigo ase...@kde.org wrote: On Thursday, June 14, 2012 13:15:34 Anne-Marie Mahfouf wrote: You misread the Quality Team mail: we are asking for the LCD Weather Station Applet to be fixed for 4.9 or removed. i misread nothing. the request for it to be removed is denied. if you consider for a moment what this would do to people's otherwise working installations, not to mention what it would mean for future incentive to fix it, the reason for this should become evident. p.s. i'm very happy that we have a more active Q/A team. i am not happy with how it is sometimes handling issues. there was a commit reverted the other day without checking with the original commiter nor the maintainer of the applet or module which should never have been reverted. fortunately i was on irc and watching commits that day. now we have a no, remove it statement which does not fit the way we develop in plasma, which is: * as a team * with communication i'm sure the QA team can improve over time so that we can all work together better. thanks ... For communication between two teams to get better both teams need to improve. Plasma does not communicate as well as you imply, speaking as a person who is trying to get involved in Plasma and help fix things, there is so much resistance. Reviews are slow, replies on maliing lists (such as this one) can be very condescending instantly blaming an entire team for a lack of communication and most ML threads seem to derail into arguments. Have you discussed the weather LCD applet with the team before denying the request. I've not seen anything? Either you haven't, and have just decided on behalf of your entire team which isn't a good example of communication, or there's a communication channel which doesn't include me...which again isn't a good example of good inclusive communication. The real reason this happened this sort of things happens is because Plasma does not have an attitude of everyone doing reviews. Everyone will just follow the example set by everyone else. It's the perfect way of increasing communication between everyone so we all know what's going on. Especially once we've entered such a beta phase. David Edmundson -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Quality Team: LCD weather station and calendar (in panel) are really broken
On Thu, Jun 14, 2012 at 5:58 PM, David Edmundson da...@davidedmundson.co.uk wrote: On Thu, Jun 14, 2012 at 12:52 PM, Aaron J. Seigo ase...@kde.org wrote: On Thursday, June 14, 2012 13:15:34 Anne-Marie Mahfouf wrote: You misread the Quality Team mail: we are asking for the LCD Weather Station Applet to be fixed for 4.9 or removed. i misread nothing. the request for it to be removed is denied. if you consider for a moment what this would do to people's otherwise working installations, not to mention what it would mean for future incentive to fix it, the reason for this should become evident. p.s. i'm very happy that we have a more active Q/A team. i am not happy with how it is sometimes handling issues. there was a commit reverted the other day without checking with the original commiter nor the maintainer of the applet or module which should never have been reverted. fortunately i was on irc and watching commits that day. now we have a no, remove it statement which does not fit the way we develop in plasma, which is: * as a team * with communication i'm sure the QA team can improve over time so that we can all work together better. thanks ... For communication between two teams to get better both teams need to improve. Plasma does not communicate as well as you imply, speaking as a person who is trying to get involved in Plasma and help fix things, there is so much resistance. Reviews are slow, replies on maliing lists (such as this one) can be very condescending instantly blaming an entire team for a lack of communication and most ML threads seem to derail into arguments. Have you discussed the weather LCD applet with the team before denying the request. I've not seen anything? Either you haven't, and have just decided on behalf of your entire team which isn't a good example of communication, or there's a communication channel which doesn't include me...which again isn't a good example of good inclusive communication. The real reason this happened this sort of things happens is because Plasma does not have an attitude of everyone doing reviews. Everyone will just follow the example set by everyone else. It's the perfect way of increasing communication between everyone so we all know what's going on. Especially once we've entered such a beta phase. David Edmundson -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel Just a FYI, http://www.wunderground.com/weather/api/ seems to be free and decent as well. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasm qml-components: also highlight the dualstate button on keyboard-focus
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105232/#review14727
---
plasma/declarativeimports/plasmacomponents/qml/private/DualStateButton.qml
http://git.reviewboard.kde.org/r/105232/#comment11626
loos like this will work but i dislike how shadowLoader.state is being set
all over the place in a rather procedural manner. much nicer imho would be sth
like:
Loader {
id: shadowLoader
anchors.fill: surfaceLoader
state: (duableButton.enabled dualButton.focus) ? hover : shadow
}
and then do the right thing in Keys.onSpacePressed, Keys.onReturnPressed,
etc.
this would also get rid of the entered() function and maybe even clean up
the MouseArea below as well.
to me this would just feel more QML
Marco: what do you think?
- Aaron J. Seigo
On June 12, 2012, 10:25 p.m., Johannes Tröscher wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105232/
---
(Updated June 12, 2012, 10:25 p.m.)
Review request for Plasma.
Description
---
this will enable the highlight on a dualstatebutton (like a checkbox) also if
the button has keyboardfocus.
Diffs
-
plasma/declarativeimports/plasmacomponents/qml/private/DualStateButton.qml
1579e88
Diff: http://git.reviewboard.kde.org/r/105232/diff/
Testing
---
tested, works
Thanks,
Johannes Tröscher
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/ --- (Updated June 14, 2012, 6:31 p.m.) Review request for Plasma. Changes --- I fixed the issues. Also I merged master into terietor/remoteinstaller and I modified plasmate/CMakeLists.txt in order to have a new cmakelists Description --- Hello, in terietor/remoteinstaller I have create a remote installer. The goal is to install the projects remotely to another computer. You access the remote install either inside plasmate or using the plasmaremoteinstaller binary. Diffs (updated) - CMakeLists.txt cd9fb1c publisher/publisher.h 5f40ae0 publisher/publisher.cpp 4855e49 publisher/remoteinstaller/remoteinstaller.h PRE-CREATION publisher/remoteinstaller/remoteinstaller.cpp PRE-CREATION publisher/remoteinstaller/remoteinstaller.ui PRE-CREATION publisher/remoteinstaller/remoteinstallerdialog.h PRE-CREATION publisher/remoteinstaller/remoteinstallerdialog.cpp PRE-CREATION publisher/remoteinstaller/standalone/main.cpp PRE-CREATION publisher/remoteinstaller/standalone/plasmaremoteinstaller.h PRE-CREATION publisher/remoteinstaller/standalone/plasmaremoteinstaller.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105032/diff/ Testing --- I couldn't find any bugs in the remote installer, but the proccess fails during KIO::copy. Apparently I am not writing correct something in the fish protocol. Right now the remote installer tries to do the above KIO::copy(/home/terietor/.kde4/share/apps/plasmate/project, fish://user@ip/home/user) but it fails Thanks, Giorgos Tsiapaliwkas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Quality Team: LCD weather station and calendar (in panel) are really broken
On Thursday, June 14, 2012 16:58:55 David Edmundson wrote: so much resistance. Reviews are slow, often they happen the same day, sometimes they don't. i would like them to be faster as well. when i keep on top of them and do the reviewing myself, it is fast. when i don't ... well .. replies on maliing lists (such as this one) can be very condescending instantly blaming an entire team for a lack of communication and most ML threads seem to derail into arguments. this has only been the case since a recent expansion of the project happened and new people joined in. this has not been the status quo for the last few years, and it is not enjoyable for anyone. Have you discussed the weather LCD applet with the team before denying the request. yes, on this very list. Luís Gabriel suggested a solution, as someone who is working on what may well be the next revision of the weather applet (done this time with QML). i agreed that solution would work. it was then implied that this was not acceptable, and we really should just do what the QA team says. this is completely unnacceptable. as for decision making authority, in KDE that is the maintainer. the author of the weather dataengine is currently unavailable, and in lieu of them being here, then the maintainership falls on my shoulders. i also happen to be the module maintainer for the repository this component is in. this is the standard way of doing things, and it works if people respect that. i find it disapointing that i need to somehow defend that i am allowed to make decisions over code that i maintain. I've not seen anything? Either you haven't, and have just decided on behalf of your entire team which isn't a good example of communication, or there's a communication channel which doesn't include me...which again isn't a good example of good inclusive communication. you will notice that Ben answered first. then Luís, with a possible solution. then i replied to Luís. what other discussion in the open are you expecting? The real reason this happened this sort of things happens is because Plasma does not have an attitude of everyone doing reviews. Everyone i'm not sure what you are saying here. i can read this a few different ways, but i can't relate it to the topic of the LCD widget or communication on this list. are you refering to the commit that was reverted? could you explain what you mean by the above a bit more so i can respond accurately? thanks. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Quality Team: LCD weather station and calendar (in panel) are really broken
On Thursday, June 14, 2012 20:17:40 Mark wrote: Just a FYI, http://www.wunderground.com/weather/api/ seems to be free and decent as well. unfortunately, unless someone pays for the service we are limited to 500 calls per day. we'll hit that pretty quickly, and would then need to pay for the service. that's a bit of a blocker for code we are distributing as free software. :) the norwegian weather service looks like quite a good possibility: http://om.yr.no/verdata/free-weather-data/ someone needs to write the code in either case of course :) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/#review14740 --- Ship it! Ship It! - Aaron J. Seigo On June 14, 2012, 6:31 p.m., Giorgos Tsiapaliwkas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/ --- (Updated June 14, 2012, 6:31 p.m.) Review request for Plasma. Description --- Hello, in terietor/remoteinstaller I have create a remote installer. The goal is to install the projects remotely to another computer. You access the remote install either inside plasmate or using the plasmaremoteinstaller binary. Diffs - CMakeLists.txt cd9fb1c publisher/publisher.h 5f40ae0 publisher/publisher.cpp 4855e49 publisher/remoteinstaller/remoteinstaller.h PRE-CREATION publisher/remoteinstaller/remoteinstaller.cpp PRE-CREATION publisher/remoteinstaller/remoteinstaller.ui PRE-CREATION publisher/remoteinstaller/remoteinstallerdialog.h PRE-CREATION publisher/remoteinstaller/remoteinstallerdialog.cpp PRE-CREATION publisher/remoteinstaller/standalone/main.cpp PRE-CREATION publisher/remoteinstaller/standalone/plasmaremoteinstaller.h PRE-CREATION publisher/remoteinstaller/standalone/plasmaremoteinstaller.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/105032/diff/ Testing --- I couldn't find any bugs in the remote installer, but the proccess fails during KIO::copy. Apparently I am not writing correct something in the fish protocol. Right now the remote installer tries to do the above KIO::copy(/home/terietor/.kde4/share/apps/plasmate/project, fish://user@ip/home/user) but it fails Thanks, Giorgos Tsiapaliwkas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: fix callback race in the session saving and shutdown code
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105111/#review14741 --- Ship it! i am not overly familiar with this exact bit of code, but it seems to have been working on my system just fine since the patch was posted. - Aaron J. Seigo On May 31, 2012, 8:48 a.m., Andriy Gapon wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105111/ --- (Updated May 31, 2012, 8:48 a.m.) Review request for Plasma. Description --- This patch tries to a fix a race in the session saving and shutdown code of ksmserver. The race may happen on wmPhase1WaitingCount variable when WM-type clients are fast enough to complete their save requests while the loop in KSMServer::shutdown is still iterating. As a result wmPhase1WaitingCount may become zero too early and that would kick off the next save/shutdown phase in a client's callback. In fact, it might even go multiple times from zero to non-zero and back during the WM-specific loop. This addresses bug 206511. http://bugs.kde.org/show_bug.cgi?id=206511 Diffs - ksmserver/shutdown.cpp a5a1ef9 Diff: http://git.reviewboard.kde.org/r/105111/diff/ Testing --- Thanks, Andriy Gapon ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Quality Team: LCD weather station and calendar (in panel) are really broken
On Thu, Jun 14, 2012 at 8:39 PM, Aaron J. Seigo ase...@kde.org wrote: On Thursday, June 14, 2012 20:17:40 Mark wrote: Just a FYI, http://www.wunderground.com/weather/api/ seems to be free and decent as well. unfortunately, unless someone pays for the service we are limited to 500 calls per day. we'll hit that pretty quickly, and would then need to pay for the service. that's a bit of a blocker for code we are distributing as free software. :) yeah, tricky. That kind of data should just be free :) the norwegian weather service looks like quite a good possibility: http://om.yr.no/verdata/free-weather-data/ someone needs to write the code in either case of course :) Ahh, you try it again :p This time it's a NO! :) Once the tooltip thing is done (reminds me that i need to work on it again), i will take up the next thing. The next thing is probably going to be the unification of shortcuts used throughout KDE applications. -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Quality Team: LCD weather station and calendar (in panel) are really broken
On Thu, Jun 14, 2012 at 7:31 PM, Aaron J. Seigo ase...@kde.org wrote: On Thursday, June 14, 2012 16:58:55 David Edmundson wrote: so much resistance. Reviews are slow, often they happen the same day, sometimes they don't. i would like them to be faster as well. when i keep on top of them and do the reviewing myself, it is fast. when i don't ... well .. On the topic of reviews, I consider it's a problem (not your fault) that they all seem to fall to you or Marco. For reviews to work, everyone from the most beginner GSOC students to the most advanced developers need to be doing them even if not everyone hits ship it, I've been trying to help with this on reviews I feel I'm getting to know the code, but it's a culture change to make this happen more regularly. replies on maliing lists (such as this one) can be very condescending instantly blaming an entire team for a lack of communication and most ML threads seem to derail into arguments. this has only been the case since a recent expansion of the project happened and new people joined in. this has not been the status quo for the last few years, and it is not enjoyable for anyone. Have you discussed the weather LCD applet with the team before denying the request. yes, on this very list. Luís Gabriel suggested a solution, as someone who is working on what may well be the next revision of the weather applet (done this time with QML). i agreed that solution would work. it was then implied that this was not acceptable, and we really should just do what the QA team says. this is completely unnacceptable. No-one is saying that you should do always do what the QA team says, the thread was re-opened with this doesn't fix the issue for 4.9, we still need to do something. as for decision making authority, in KDE that is the maintainer. the author of the weather dataengine is currently unavailable, and in lieu of them being here, then the maintainership falls on my shoulders. i also happen to be the module maintainer for the repository this component is in. this is the standard way of doing things, and it works if people respect that. i find it disapointing that i need to somehow defend that i am allowed to make decisions over code that i maintain. We also shouldn't take your word blindly without discussion simply because you're the maintainer. You have the final say, and none of us would change the code without permission, but this doesn't make the first decision you make always instantly right. You can't honestly say you've never argued with a maintainer of another component because you've strongly believed you were correct on how to make KDE better. I've not seen anything? Either you haven't, and have just decided on behalf of your entire team which isn't a good example of communication, or there's a communication channel which doesn't include me...which again isn't a good example of good inclusive communication. you will notice that Ben answered first. then Luís, with a possible solution. then i replied to Luís. what other discussion in the open are you expecting? The real reason this happened this sort of things happens is because Plasma does not have an attitude of everyone doing reviews. Everyone i'm not sure what you are saying here. i can read this a few different ways, but i can't relate it to the topic of the LCD widget or communication on this list. are you refering to the commit that was reverted? could you explain what you mean by the above a bit more so i can respond accurately? thanks. The review part was referring to the reverted commit. (sorry for the confusion) If Anna had submitted a review request before reverting all would have been handled gracefully without any problems. However, we can't only say in retrospect of a bad commit you should have had this reviewed if we don't do it on every other commit. Trying to move the conversation from this was bad to this is how we can make things better in future. Regards Dave -- Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Quality Team: LCD weather station and calendar (in panel) are really broken
On 06/14/2012 08:31 PM, Aaron J. Seigo wrote: On Thursday, June 14, 2012 16:58:55 David Edmundson wrote: so much resistance. Reviews are slow, often they happen the same day, sometimes they don't. i would like them to be faster as well. when i keep on top of them and do the reviewing myself, it is fast. when i don't ... well .. replies on maliing lists (such as this one) can be very condescending instantly blaming an entire team for a lack of communication and most ML threads seem to derail into arguments. this has only been the case since a recent expansion of the project happened and new people joined in. this has not been the status quo for the last few years, and it is not enjoyable for anyone. Have you discussed the weather LCD applet with the team before denying the request. yes, on this very list. Luís Gabriel suggested a solution, as someone who is working on what may well be the next revision of the weather applet (done this time with QML). i agreed that solution would work. it was then implied that this was not acceptable, and we really should just do what the QA team says. this is completely unnacceptable. as for decision making authority, in KDE that is the maintainer. the author of the weather dataengine is currently unavailable, and in lieu of them being here, then the maintainership falls on my shoulders. i also happen to be the module maintainer for the repository this component is in. this is the standard way of doing things, and it works if people respect that. i find it disapointing that i need to somehow defend that i am allowed to make decisions over code that i maintain. Nobody said you had to do this or that. The QA team makes suggestions, you of course have the final say. Thanks for fixing Calendar! Again I apologize for the reverted commit (I CCed you so you were informed instantly), this had nothing to do with the current discussion and should not have been brought into it, it was just a bad handling of my part (which is not a behavior I usually have). It happens to make errors and we (quite enthusiastically) debugged this systray bug and I got carried away. Of course I'll use reviewboard next time. It had nothing to do with the QA Team and the debugging of the bug that lead to my bad revert happened in #plasma. To add a positive note to all this: the work the QA Team did so far: I don't know how many Plasma bug reports were triaged prior the beta 1 release but Myriam alone triaged, verified, put versions in hundreds of reports. It's to be noted that users answered to queries about old bug reports better than we expected. From the beta 1 release to now, more than 100 bug reports were issued or confirmed, most about Plasma and 33 were fixed. Special thanks to Viranch who is tackling QML regressions and make users happy. Tests on community wiki http://community.kde.org/Getinvolved/Testing/Beta/Plasma can be useful to new developers. Plasma bugs in bugzilla should now be very much easier for developers to prioritize. Please let us know if you have questions about bugzilla or suggestions. Best regards, Anne-Marie ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
blogs from the sprint?
hello to everyone at the workspace sprint: can we have a blog or two about the happenings? i think we're probably all interested in what's happening there ... thanks ... -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Quality Team: LCD weather station and calendar (in panel) are really broken
Hey all, On Wednesday, June 13, 2012 22:31:36 Anne-Marie Mahfouf wrote: The LCD Weather Station applet is in a non working state and the Quality Team thinks it cannot be shipped as it is. The problem is that two providers which cover Europe had an API change (and some freedom restrictions?) thus the applet can't display any information for a lot of locations. I know it's the data engine code the culprit but the consequence is a non working applet. See https://bugs.kde.org/show_bug.cgi?id=300885 (Weather Station Applet does not work anymore with bbcuk or wetter.com provider) Another applet is in bad shape as well: the Calendar applet when placed in panel. The date does not update when the day changes and the layout is totally broken making the calendar not readable. See https://bugs.kde.org/show_bug.cgi?id=236874 and https://bugs.kde.org/show_bug.cgi?id=285362 We hope these can be fixed as well as the regressions regularly sent to the list. I think things we can take away from this thread: - We want each other to look at commits more - Just removing components or reverting commits is not a way to fix bugs, it probably leads to more regressions even - We need to improve on our collaboration - New people coming into the team, in which form however, need to learn the ropes, and screwups once in a while are quite natural. It's growing pains, though, and growing is a good thing - We share the same goals, and should all try to not step on each other's toes. (Ok, the last thing hasn't been mentioned explicitely, but still seems quite well backed by evidence. :P) Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Quality Team: LCD weather station and calendar (in panel) are really broken
On Thu, Jun 14, 2012 at 5:58 PM, David Edmundson da...@davidedmundson.co.uk wrote: this is just about a little point of this, more of this later Have you discussed the weather LCD applet with the team before denying the request. I've not seen anything? Either you haven't, and have just decided on behalf of your entire team which isn't a good example of communication, or there's a communication channel which doesn't include me...which again isn't a good example of good inclusive communication. i take responsibility on this, i was part of the irc discussion, and i was agreeing with the decision. so i was agreeing completely against the removal of the applet. unfortunaltely i did not document it, so there wasn't indeed much discussion :/ Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: blogs from the sprint?
Pretty much drinking smoking and eating really well cooked food xD I will blog about my thoughts today ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Last call for Randa 2012 registration
Morning gals and guys Please sent me a 5 to 10 sentences summary on what you plan to do in Randa in September. I'll forward this together with the budget to the e.V. board. Thx Mario ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Quality Team: LCD weather station and calendar (in panel) are really broken
On Thu, Jun 14, 2012 at 10:36 PM, Sebastian Kügler se...@kde.org wrote: Hey all, We hope these can be fixed as well as the regressions regularly sent to the list. I think things we can take away from this thread: - We want each other to look at commits more - Just removing components or reverting commits is not a way to fix bugs, it probably leads to more regressions even - We need to improve on our collaboration - New people coming into the team, in which form however, need to learn the ropes, and screwups once in a while are quite natural. It's growing pains, though, and growing is a good thing - We share the same goals, and should all try to not step on each other's toes. (Ok, the last thing hasn't been mentioned explicitely, but still seems quite well backed by evidence. :P) +1 as i said, personally i didn't see problems... i agreed with the revert of the revert, i agreed with leaving weatherstation in. i didn't see a problem of that decision being seen as unilateral. this seems to hurt new people, adapting to a workflow is difficult, and the workflow is for sure far from perfect. for this thread: let's everybody think about those points, and let's use what we learnt dealing with the next issue, being an important review request, or a decision about what action to take over a severe bug. Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: blogs from the sprint?
On Thu, Jun 14, 2012 at 10:18 PM, Aaron J. Seigo ase...@kde.org wrote: hello to everyone at the workspace sprint: can we have a blog or two about the happenings? i think we're probably all interested in what's happening there ... thanks ... to be brief for now: something out of it very good, but slowly gaining energy like a spring, hopefully with fgreat results in the end. in contrast to a devel one where we have more little developments :) Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
No remaining time option in battery monitor?
Hi, I just noticed there is no option of remaining time in the latest stable released version of the c++ battery applet (4.8.4). Have we discarded it? I want to know this so I can know whether I should keep this in the qml version. Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: No remaining time option in battery monitor?
Was it ever even mainlined? Thought it was just in some branch.. On Jun 14, 2012 7:12 PM, Viranch Mehta viranch.me...@gmail.com wrote: Hi, I just noticed there is no option of remaining time in the latest stable released version of the c++ battery applet (4.8.4). Have we discarded it? I want to know this so I can know whether I should keep this in the qml version. Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: No remaining time option in battery monitor?
On Fri, Jun 15, 2012 at 12:54 AM, Viranch Mehta viranch.me...@gmail.com wrote: Hi, I just noticed there is no option of remaining time in the latest stable released version of the c++ battery applet (4.8.4). Have we discarded it? I want to know this so I can know whether I should keep this in the qml version. there was an old discussion about it. basically there are several problem wit the remaining time (is false information) http://osdir.com/ml/plasma-devel/2009-05/msg00269.html i think the qml version should be for now coherent with the c++ applet ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: No remaining time option in battery monitor?
To me it looks less like a discussion and more like a aaron got pissed because it didn't work for him, who himself is one person therefore nobody should have it. If not all hardware supports it, tough shit we've been shipping compositing on so much hardware that couldn't support it even in a remote sense yet did it anyways. And these days compositing works pretty darn well on even less mature Foss drivers. Do you see parallels here? I don't know, power top manages to get the info just fine. Of course it is by nature inaccurate, but you know what? So is guessing how much % is left. So you're simply wrong, anything associated with a battery can be easily argued as inaccurate, because it is. You know that battery % cannot be measured just from VA alone with Li-ion, many other factors need to be taken into consideration, especially temperature. Otherwise the values you're getting could be at least 20% off. So maybe we should stop displaying the percentage of the battery, and just tell the user that their computer is on. And when it is off, we won't tell them anything. Time remaining applies to a lot of things, and since it's all hardware, it's all inaccurate but does give you a rough idea, look at backup power supplies; also, even cars have it these days(in the form of mpg and miles remaining as well as minutes). The user doesn't expect it to be 100% accurate, because it can't be and it never was, they already know that. Given this logic, perhaps we should also abandon file transfer ETA and just say it's done when it's done, since inter/intranet bandwidth and internal I/O operations vary so greatly with access times and scheduling, there's no way to possibly give you an accurate time, and the users won't be able to trust it ever because it switches from 1 week to 4 hours. And yet we do...? Because it's common functionality and is expected.. That said, every other OS under the sun manages to do ETA just fine, so what's the problem? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: No remaining time option in battery monitor?
On Thu, Jun 14, 2012 at 11:54 PM, Viranch Mehta viranch.me...@gmail.com wrote: Hi, I just noticed there is no option of remaining time in the latest stable released version of the c++ battery applet (4.8.4). Have we discarded it? I want to know this so I can know whether I should keep this in the qml version. There's no option because it's always shown in the popup dialog (or at least appears to be for me (4.8.3)) In the QML port this moved to being a config option for the dialog before you took over. Presumably for the reasons in Macro's email, which people may or may not agree with. I'm assuming you're asking based on a https://bugs.kde.org/show_bug.cgi?id=301872? Which is about showing the time remaining on the icon itself, and this actually states this option hasn't existed since KDE 3, so this is not a regression from the last release. Dave Cheers, Viranch ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: No remaining time option in battery monitor?
2012/6/15 Shaun Reich sre...@kde.org: To me it looks less like a discussion and more like a aaron got pissed because it didn't work for him, who himself is one person therefore nobody should have it. This is not how things went. There has been an extensive discussion in the past you can easily find in the archives of this mailing list, and a number of reiterations of the discussion afterwards (split between here, k-c-d and bug trackers). Also, to provide full disclosure, the people involved in this decision at the time were me and sebas. Apart from that, I stated multiple times in the past I am neutral to this decision since I found myself not really taking sides after all that's been said. With my power management maintainer hat on, I am fine with whatever decision the majority of the other contributors agree on. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: No remaining time option in battery monitor?
ew, why would it need to be a config option anyways? don't see the point in that. it should just be on mouseover an icon switch and/or tooltip. iirc this was exactly what some non-merged applet did. I believe sebas was the one who made that one as well (which worked well, i might add). This is not how things went. There has been an extensive discussion in the past you can easily find in the archives of this mailing list, and a number of reiterations of the discussion afterwards (split between here, k-c-d and bug trackers). Also, to provide full disclosure, the people involved in this decision at the time were me and sebas. okay, it just didn't seem that way from the mails i followed on the marco-provided link. Apart from that, I stated multiple times in the past I am neutral to this decision since I found myself not really taking sides after all that's been said. With my power management maintainer hat on, I am fine with whatever decision the majority of the other contributors agree on. -- Shaun Reich, KDE Software Developer (kde.org) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
