Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116517/#review51601
---
Good thinking, and in fact this is the idea that first came to my mind. But, as
you would've noticed, the experience on clicking the button isn't very natural
now because you aren't really pressing the button.
Another (and better, imo) solution you can try is reverse the parenting order
of MouseEventListener and ToolButton (i.e. MouseEventListener { ToolButton { }
}). This way you will get both the interactions (click and scroll) and will
still feel natural.
- Shantanu Tushar
On March 1, 2014, 3:03 p.m., Rukshan Chathuranga wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116517/
---
(Updated March 1, 2014, 3:03 p.m.)
Review request for Plasma.
Repository: plasma-mediacenter
Description
---
Implement change volume on mouse wheel when top of the voulume icon.
Diffs
-
mediaelements/mediacontroller/MediaController.qml 968c459
Diff: https://git.reviewboard.kde.org/r/116517/diff/
Testing
---
tested the function and not change the default controlling due to new changes.
Thanks,
Rukshan Chathuranga
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll
On March 2, 2014, 11:16 a.m., Shantanu Tushar wrote:
Good thinking, and in fact this is the idea that first came to my mind.
But, as you would've noticed, the experience on clicking the button isn't
very natural now because you aren't really pressing the button.
Another (and better, imo) solution you can try is reverse the parenting
order of MouseEventListener and ToolButton (i.e. MouseEventListener {
ToolButton { } }). This way you will get both the interactions (click and
scroll) and will still feel natural.
Oh really. But i can't see any diffent or any unnatural behavior after this
modification. i'm sorry, may be i can't see that small difference. But my
suggestion is until we find the most appropriate way, we can use this
modification as the fixed one.
- Rukshan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116517/#review51601
---
On March 1, 2014, 3:03 p.m., Rukshan Chathuranga wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116517/
---
(Updated March 1, 2014, 3:03 p.m.)
Review request for Plasma.
Repository: plasma-mediacenter
Description
---
Implement change volume on mouse wheel when top of the voulume icon.
Diffs
-
mediaelements/mediacontroller/MediaController.qml 968c459
Diff: https://git.reviewboard.kde.org/r/116517/diff/
Testing
---
tested the function and not change the default controlling due to new changes.
Thanks,
Rukshan Chathuranga
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll
On March 2, 2014, 11:16 a.m., Shantanu Tushar wrote:
Good thinking, and in fact this is the idea that first came to my mind.
But, as you would've noticed, the experience on clicking the button isn't
very natural now because you aren't really pressing the button.
Another (and better, imo) solution you can try is reverse the parenting
order of MouseEventListener and ToolButton (i.e. MouseEventListener {
ToolButton { } }). This way you will get both the interactions (click and
scroll) and will still feel natural.
Rukshan Chathuranga wrote:
Oh really. But i can't see any diffent or any unnatural behavior after
this modification. i'm sorry, may be i can't see that small difference. But
my suggestion is until we find the most appropriate way, we can use this
modification as the fixed one.
Without the patch, the volume button reacts to your pushing and releasing the
mouse button on the volume button. With the patch, it works even if you don't
release the mouse button (that is one of the things), etc.
As I said, all you need to do to fix this is to change the order of parenting.
If you get any problems, let me know, in that case I can do it for you :)
- Shantanu
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116517/#review51601
---
On March 1, 2014, 3:03 p.m., Rukshan Chathuranga wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116517/
---
(Updated March 1, 2014, 3:03 p.m.)
Review request for Plasma.
Repository: plasma-mediacenter
Description
---
Implement change volume on mouse wheel when top of the voulume icon.
Diffs
-
mediaelements/mediacontroller/MediaController.qml 968c459
Diff: https://git.reviewboard.kde.org/r/116517/diff/
Testing
---
tested the function and not change the default controlling due to new changes.
Thanks,
Rukshan Chathuranga
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116517: Implement change volume on mouse wheel when top of the voulume icon. based on the Bug 322821 - Make volume controllable using mouse scroll
On March 2, 2014, 11:16 a.m., Shantanu Tushar wrote:
Good thinking, and in fact this is the idea that first came to my mind.
But, as you would've noticed, the experience on clicking the button isn't
very natural now because you aren't really pressing the button.
Another (and better, imo) solution you can try is reverse the parenting
order of MouseEventListener and ToolButton (i.e. MouseEventListener {
ToolButton { } }). This way you will get both the interactions (click and
scroll) and will still feel natural.
Rukshan Chathuranga wrote:
Oh really. But i can't see any diffent or any unnatural behavior after
this modification. i'm sorry, may be i can't see that small difference. But
my suggestion is until we find the most appropriate way, we can use this
modification as the fixed one.
Shantanu Tushar wrote:
Without the patch, the volume button reacts to your pushing and releasing
the mouse button on the volume button. With the patch, it works even if you
don't release the mouse button (that is one of the things), etc.
As I said, all you need to do to fix this is to change the order of
parenting. If you get any problems, let me know, in that case I can do it for
you :)
o thanks Tushar, i will work on that and let you know any trouble if i got.
- Rukshan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116517/#review51601
---
On March 1, 2014, 3:03 p.m., Rukshan Chathuranga wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116517/
---
(Updated March 1, 2014, 3:03 p.m.)
Review request for Plasma.
Repository: plasma-mediacenter
Description
---
Implement change volume on mouse wheel when top of the voulume icon.
Diffs
-
mediaelements/mediacontroller/MediaController.qml 968c459
Diff: https://git.reviewboard.kde.org/r/116517/diff/
Testing
---
tested the function and not change the default controlling due to new changes.
Thanks,
Rukshan Chathuranga
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/#review51736 --- Harshit, thanks for picking up the bug and I appreciate your effort. I would like to know every single step you had done as test case. I am pretty sure this is not a one liner fix. Only when the playlist frame gets into the stack, the Play All starts working as per my observation. Let me know if I am wrong. - Sujith Haridasan On March 2, 2014, 10:53 p.m., Harshit Agarwal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 2, 2014, 10:53 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Referring to Bug #331040 The functionality of the media starting to play on the press of the Play All button has been implemented. It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. Diffs - browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 Diff: https://git.reviewboard.kde.org/r/116554/diff/ Testing --- The testing has been done through various test scenarios. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
