Re: Review Request 118061: Plasma-mobile: Add an initial shell package

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118061/#review57664
---


Wouldn't it be better to let the Desktop settle down a bit before we start to 
fork things out? Actually we should find ways to share code and not having to 
actually fork these, which is really counter-productive.

- Aleix Pol Gonzalez


On May 9, 2014, 2:05 p.m., Antonis Tsiapaliokas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118061/
> ---
> 
> (Updated May 9, 2014, 2:05 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mobile
> 
> 
> Description
> ---
> 
> Add a copy of desktop shell package but remove the stuff that we
> don't need. Like the contextmenu, panelconfiguration and the toolbox
> 
> 
> Diffs
> -
> 
>   qmlpackages/shell/package/metadata.desktop PRE-CREATION 
>   qmlpackages/shell/package/contents/views/Panel.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/views/Desktop.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/layout.js PRE-CREATION 
>   qmlpackages/shell/package/contents/loader.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/explorer/WidgetExplorer.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/explorer/Tooltip.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/explorer/AppletDelegate.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/defaults PRE-CREATION 
>   qmlpackages/shell/package/contents/configuration/MouseEventInputButton.qml 
> PRE-CREATION 
>   
> qmlpackages/shell/package/contents/configuration/ContainmentConfiguration.qml 
> PRE-CREATION 
>   qmlpackages/shell/package/contents/configuration/ConfigurationShortcuts.qml 
> PRE-CREATION 
>   
> qmlpackages/shell/package/contents/configuration/ConfigurationContainmentAppearance.qml
>  PRE-CREATION 
>   
> qmlpackages/shell/package/contents/configuration/ConfigurationContainmentActions.qml
>  PRE-CREATION 
>   qmlpackages/shell/package/contents/configuration/ConfigCategoryDelegate.qml 
> PRE-CREATION 
>   qmlpackages/shell/package/contents/configuration/AppletConfiguration.qml 
> PRE-CREATION 
>   qmlpackages/shell/package/contents/applet/DefaultCompactRepresentation.qml 
> PRE-CREATION 
>   qmlpackages/shell/package/contents/applet/CompactApplet.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/applet/AppletError.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/activitymanager/WindowPreview.qml 
> PRE-CREATION 
>   qmlpackages/shell/package/contents/activitymanager/StoppedActivityItem.qml 
> PRE-CREATION 
>   qmlpackages/shell/package/contents/activitymanager/Heading.qml PRE-CREATION 
>   qmlpackages/shell/package/contents/activitymanager/ControlButton.qml 
> PRE-CREATION 
>   qmlpackages/shell/package/contents/activitymanager/ActivityManager.qml 
> PRE-CREATION 
>   qmlpackages/shell/package/contents/activitymanager/ActivityList.qml 
> PRE-CREATION 
>   qmlpackages/shell/package/contents/activitymanager/ActivityItem.qml 
> PRE-CREATION 
>   
> qmlpackages/shell/package/contents/activitymanager/ActivityDeletionDialog.qml 
> PRE-CREATION 
>   
> qmlpackages/shell/package/contents/activitymanager/ActivityCreationDialog.qml 
> PRE-CREATION 
>   qmlpackages/shell/CMakeLists.txt PRE-CREATION 
>   qmlpackages/shell/package/contents/activitymanager/ActivityBrowser.qml 
> PRE-CREATION 
>   qmlpackages/CMakeLists.txt d277441 
>   CMakeLists.txt c7e3797 
> 
> Diff: https://git.reviewboard.kde.org/r/118061/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118015: Dont convert URLs with protocol h**p: to http:

[Alexander Richardson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118015/
---

(Updated May 9, 2014, 11:51 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: kio-extras


Description
---

All URL protocols with four letters starting with h and ending with p where
the middle two characters are the same are automatically converted to http.

This was introduced in r312725 to "support those strange h**p://www.kde.org
style URLs that people tend to post to message boards"

This no longer seems to be very common -> remove this functionality since
it also prevents any kioslave that uses e.g. a haab:/ or hbbp:/ protocol
from working in e.g. dolphin.


Diffs
-

  kurifilter-plugins/shorturi/kshorturifilter.cpp 
58f3435f7599acf692a082d216a0c58684bcf8b6 

Diff: https://git.reviewboard.kde.org/r/118015/diff/


Testing
---

entering haap://foo.bar in the dolphin address bar no longer attempts to open 
the browser


Thanks,

Alexander Richardson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118015: Dont convert URLs with protocol h**p: to http:

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118015/#review57661
---


This review has been submitted with commit 
89b4751253d241185f709d1481051455522ca6b9 by Alex Richardson to branch master.

- Commit Hook


On May 6, 2014, 11:49 a.m., Alexander Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118015/
> ---
> 
> (Updated May 6, 2014, 11:49 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> All URL protocols with four letters starting with h and ending with p where
> the middle two characters are the same are automatically converted to http.
> 
> This was introduced in r312725 to "support those strange h**p://www.kde.org
> style URLs that people tend to post to message boards"
> 
> This no longer seems to be very common -> remove this functionality since
> it also prevents any kioslave that uses e.g. a haab:/ or hbbp:/ protocol
> from working in e.g. dolphin.
> 
> 
> Diffs
> -
> 
>   kurifilter-plugins/shorturi/kshorturifilter.cpp 
> 58f3435f7599acf692a082d216a0c58684bcf8b6 
> 
> Diff: https://git.reviewboard.kde.org/r/118015/diff/
> 
> 
> Testing
> ---
> 
> entering haap://foo.bar in the dolphin address bar no longer attempts to open 
> the browser
> 
> 
> Thanks,
> 
> Alexander Richardson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New Logo (+Ksplash minimal)

[Jens Reuterberg]

But when you say that, do you mean the wonky one with bars flying everywhere 
for no reason or just the one with the normal login?
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: RFC: plasma-shell in pasma-workspace

[Marco Martin]

On Thursday 03 April 2014, Marco Martin wrote:
> Hi all,
> this was briefly mentioned in the past.
> 
> the idea is to leave only libraries and plugins in plasma-workspace, and
> mode plasma-shell in the new plasma-workspace repository instead.
> 
> Is everybody fine with this?
> Also, how to do the move? (i think filter-branch is the only option in this
> case?)

FYI: done today, the executable is now plasmashell
the application name is plasmashell
the dbus adress is org.kde.plasmashell

ocd-ness is happy ;)

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118063: New Formats KCM

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118063/#review57650
---



kcms/formats/kcmformatswidget.ui


Missing colon


- Kai Uwe Broulik


On May 9, 2014, 4:05 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118063/
> ---
> 
> (Updated May 9, 2014, 4:05 p.m.)
> 
> 
> Review request for Plasma and John Layt.
> 
> 
> Bugs: 331930
> https://bugs.kde.org/show_bug.cgi?id=331930
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The current "Locale" KCM is almost entirely broken. The way forward is to 
> split it into localization options (this, Formats), and translaticons. This 
> patch implements a new Formats KCM which writes out an environment suitable 
> for QLocale to pick it up.
> 
> It's a rewrite of the current KCM, since:
> - everything under the hood is different (KLocale is gone, QLocale takes over)
> - everything above the hood is different, in QLocale, everything is deduced 
> from the country / region
> 
> Now this includes feature regressions compared to the old KCM, but not all of 
> these features can be done at all on top of QLocale right now, so we have to 
> set up what we can.
> 
> This KCM caches the settings in a config file, but most importantly, it 
> writes out a script with export instructions, which can be picked up by 
> startkde. This is all done according to John's suggestions, and I have a 
> patch for startkde to pick up the settings here. It all works fine (on my 
> machine).
> 
> Many more details about the implementation can be found in the plasma-devel 
> thead "Locale settings in Plasma Next", started by John on February, 23rd 
> 2014.
> 
> 
> Diffs
> -
> 
>   kcms/formats/kcmformatswidget.ui PRE-CREATION 
>   kcms/formats/kcmformats.cpp PRE-CREATION 
>   kcms/formats/kcmformats.h PRE-CREATION 
>   kcms/formats/Messages.sh PRE-CREATION 
>   kcms/formats/formats.desktop PRE-CREATION 
>   kcms/formats/CMakeLists.txt PRE-CREATION 
>   kcms/CMakeLists.txt ed86efa 
> 
> Diff: https://git.reviewboard.kde.org/r/118063/diff/
> 
> 
> Testing
> ---
> 
> Tried all kinds of different combinations, applied them, made sure they're 
> exported correctly in the script.
> 
> 
> File Attachments
> 
> 
> new Formats KCM in kcmshell5
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/09/873980fe-04f2-4d75-9074-2aa676723061__formatskcm.png
> Formats KCM in systemsettings
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/09/86a830ed-2d5d-4bdd-ba82-71ec73e6ce2c__formatskcmss.png
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QSG_RENDER_LOOP woes

[Martin Gräßlin]

Am 2014-05-09 17:00, schrieb Sebastian Kügler:

On Friday, May 09, 2014 16:39:03 Martin Gräßlin wrote:

On Friday 09 May 2014 16:29:32 Sebastian Kügler wrote:
> On Friday, May 09, 2014 16:03:31 Martin Gräßlin wrote:
> > On Friday 09 May 2014 15:56:53 Sebastian Kügler wrote:
> >
> > Please note that Qt itself switched it off for all of Mesa. The change
> > now
> > was  more to only have one possible way of usage and preventing us
> > hunting
> > down non-reproducable bugs.
> >
> > The crashes we see with threaded render loop cannot be fixed or worked
> > around  if I understand the Qt commit disabling it for all of Mesa
> > correctly. Have a look at the plasma-devel archives, I sent a FYI mail
> > some
> > time back.
>
> I remember that one. That email doesn't say much, except for your "basic
> works for me" in kwin. I didn't see any problems with kwin, only with
> plasma-shell, and I only changed it for plasma-shell in my tests: that
> made
> a difference (on Intel).

no I think I meant another mail, try
http://comments.gmane.org/gmane.comp.kde.devel.plasma/30179


That as well. Seems to work fine for kwin, seems to cause pain for 
Plasma.

Meh.


well then the issues need to be fixed. From the commit message in Qt I 
don't see any chance to get rid of the crashers.


Cheers
Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to normal : plasma-desktop_master_qt5 #156

[KDE CI System]

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Next Beta 1

[Michael Palimaka]

On 05/10/2014 02:07 AM, Jonathan Riddell wrote:
> Tars are available for Plasma Next Beta 1
> 
> Soon to be landing on depot.kde.org 
> unstable/plasma/4.96.0
> 
> Temporary site:
> http://starsky.19inch.net/~jr/tmp/plasma-4.96.0/
> http://starsky.19inch.net/~jr/tmp/plasma-4.96.0/SHA256Sum
> 
> This release works with Qt 5.2 although it is probably better with Qt
> 5.3 RC.
> 
> It'll need KDE Frameworks 5 Beta 2 which was quietly released yesterday.
> 
> It should not overlap with kde-runtime or kdelibs from kdelibs4 land but
> much of it will overlap with kde-workspace from kdelibs4 land, it's new
> versions.
> 
> The translations will also overlap with translations from kde sc 4.13. 
> One suggested solution it to install 4.13 translations into their own
> directory and patch kdelibs4 to read from that directory.
> 
> I may well have made mistakes, this release is still quite undefined. 
> If there are tars I should/should not have included, if there are
> branches I should have used, if there are version numbers I should have
> set differently either in the tars or internally let me know.
> 
> The Plasma team is still discussing what it still be called so for now
> I'll call it Plasma Next.
> 
> I hope to announce this on Tuesday but how knows.
> 
> Good luck :)
> 
> Jonathan
> 
> 
> 
> ___
> Kde-packager mailing list
> kde-packa...@kde.org
> https://mail.kde.org/mailman/listinfo/kde-packager
> 

Hi,

Since powedevil and libkscreen are in extragear, is it expected to use
the same versions as plasma stuff? It's not clear to me the full list of
packages which fall under the Plasma Next umbrella.

Also do we need a milou package? I think it's required by
plasma-workspace (see lookandfeel/contents/runcommand/RunCommand.qml).

Moving forward, are there plans to split kde-baseapps or is that
remaining unchanged?

Best regards,
Michael
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118063: New Formats KCM

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118063/#review57648
---



kcms/formats/kcmformats.cpp


Leaks.



kcms/formats/kcmformats.cpp


I assume you mean kcmshell ?
If so please file a bug. This is quite critical.



kcms/formats/kcmformats.cpp


Do you need the  tags here?




kcms/formats/kcmformats.cpp


Defaults isn't meant to do the same as cancel and re-opening.
It should reset to whatever system defaults should be.



kcms/formats/kcmformats.cpp


I don't think we can hardcode this example.

One wouldn't have 24.99 yen.
and we have to take nloc into account to switch between . and ,



kcms/formats/kcmformats.cpp


This seems wrong.

No-one would say
4km 4.3cm.

It would either by 

4000.0043m
or 4km, 4cm, 3mm

Same for imperial.

Can we use KUnitConversion::Length  directly, which will do the right thing.


- David Edmundson


On May 9, 2014, 4:05 p.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118063/
> ---
> 
> (Updated May 9, 2014, 4:05 p.m.)
> 
> 
> Review request for Plasma and John Layt.
> 
> 
> Bugs: 331930
> https://bugs.kde.org/show_bug.cgi?id=331930
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> The current "Locale" KCM is almost entirely broken. The way forward is to 
> split it into localization options (this, Formats), and translaticons. This 
> patch implements a new Formats KCM which writes out an environment suitable 
> for QLocale to pick it up.
> 
> It's a rewrite of the current KCM, since:
> - everything under the hood is different (KLocale is gone, QLocale takes over)
> - everything above the hood is different, in QLocale, everything is deduced 
> from the country / region
> 
> Now this includes feature regressions compared to the old KCM, but not all of 
> these features can be done at all on top of QLocale right now, so we have to 
> set up what we can.
> 
> This KCM caches the settings in a config file, but most importantly, it 
> writes out a script with export instructions, which can be picked up by 
> startkde. This is all done according to John's suggestions, and I have a 
> patch for startkde to pick up the settings here. It all works fine (on my 
> machine).
> 
> Many more details about the implementation can be found in the plasma-devel 
> thead "Locale settings in Plasma Next", started by John on February, 23rd 
> 2014.
> 
> 
> Diffs
> -
> 
>   kcms/formats/kcmformatswidget.ui PRE-CREATION 
>   kcms/formats/kcmformats.cpp PRE-CREATION 
>   kcms/formats/kcmformats.h PRE-CREATION 
>   kcms/formats/Messages.sh PRE-CREATION 
>   kcms/formats/formats.desktop PRE-CREATION 
>   kcms/formats/CMakeLists.txt PRE-CREATION 
>   kcms/CMakeLists.txt ed86efa 
> 
> Diff: https://git.reviewboard.kde.org/r/118063/diff/
> 
> 
> Testing
> ---
> 
> Tried all kinds of different combinations, applied them, made sure they're 
> exported correctly in the script.
> 
> 
> File Attachments
> 
> 
> new Formats KCM in kcmshell5
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/09/873980fe-04f2-4d75-9074-2aa676723061__formatskcm.png
> Formats KCM in systemsettings
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/09/86a830ed-2d5d-4bdd-ba82-71ec73e6ce2c__formatskcmss.png
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-desktop_master_qt5 #155

[KDE CI System]

See 

Changes:

[bhush94] Unbreak trash applet by adding KDirModel as private import

--
[...truncated 299 lines...]

 * Qt5Network (required version >= 5.3.1)
 * Qt5Qml (required version >= 5.3.1)
 * Qt5Gui (required version >= 5.3.1)
 * Qt5Quick
 * Qt5DBus
 * Qt5Widgets
 * Qt5X11Extras
 * Qt5Svg
 * Qt5Test
 * Qt5Concurrent
 * Qt5 (required version >= 5.2.0)
 * Qt5Core (required version >= 5.2.0)
 * ECM (required version >= 0.0.9)
 * KF5Plasma
 * KF5PlasmaQuick
 * KF5DocTools
 * Gettext
 * KF5I18n
 * KF5KCMUtils
 * KF5NewStuff
 * KF5KDELibs4Support
 * KF5NotifyConfig
 * KF5Su
 * KF5Attica
 * KF5Wallet
 * KF5Runner
 * KF5
 * KDecorations
 * LibKWorkspace
 * LibTaskManager
 * KWinDBusInterface
 * ScreenSaverDBusInterface
 * KRunnerAppDBusInterface
 * KSMServerDBusInterface
 * XCB , X protocol C-language Binding , 
 * Phonon4Qt5 (required version >= 4.6.60)

-- The following features have been disabled:

 * XCB-XKB , Required for building kcm/keyboard
 * Audio setup GUI , libcanberra is needed for audio setup GUI
  * http://0pointer.de/lennart/projects/libcanberra

-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

KDE4_BUILD_TESTS
LIB_SUFFIX
SIP_DEFAULT_SIP_DIR


-- Build files have been written to: 


== Commencing the Build

Scanning dependencies of target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-colors-index-cache-bz2
Scanning dependencies of target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-desktopthemedetails-index-cache-bz2
Scanning dependencies of target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-joystick-index-cache-bz2
Scanning dependencies of target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-kcmstyle-index-cache-bz2
Scanning dependencies of target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-kcmaccess-index-cache-bz2
Scanning dependencies of target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-clock-index-cache-bz2
Scanning dependencies of target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-solid-actions-index-cache-bz2
[  1%] [  1%] [  1%] [  1%] [  2%] Scanning dependencies of target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-splashscreen-index-cache-bz2
[  3%] [  3%] Generating index.cache.bz2
Generating index.cache.bz2
Generating index.cache.bz2
[  3%] Generating index.cache.bz2
Generating index.cache.bz2
Generating index.cache.bz2
Scanning dependencies of target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-powerdevil-index-cache-bz2
Generating index.cache.bz2
Generating index.cache.bz2
[  3%] Generating index.cache.bz2
[  3%] Built target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-joystick-index-cache-bz2
[  3%] Built target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-splashscreen-index-cache-bz2
[  3%] Scanning dependencies of target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-bookmarks-index-cache-bz2
Built target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-solid-actions-index-cache-bz2
[  3%] [  3%] Scanning dependencies of target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-icons-index-cache-bz2
[  3%] [  3%] Built target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-colors-index-cache-bz2
Built target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-kcmaccess-index-cache-bz2
Built target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-desktopthemedetails-index-cache-bz2
Scanning dependencies of target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-cookies-index-cache-bz2
[  3%] Generating index.cache.bz2
Scanning dependencies of target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-ebrowsing-index-cache-bz2
Generating index.cache.bz2
Scanning dependencies of target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-khtml-general-index-cache-bz2
Scanning dependencies of target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-useragent-index-cache-bz2
[  3%] [  3%] [  3%] [  3%] Generating index.cache.bz2
Generating index.cache.bz2
Generating index.cache.bz2
Generating index.cache.bz2
[  3%] Built target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-powerdevil-index-cache-bz2
[  3%] Built target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-clock-index-cache-bz2
Scanning dependencies of target 
-srv-jenkins-workspace-plasma-desktop-master-qt5-build-doc-kcontrol-khtml-plugins-

Re: Locale settings in Plasma Next

[Sebastian Kügler]

On Friday, May 09, 2014 15:03:28 John Layt wrote:
> On 6 May 2014 22:35, Sebastian Kügler  wrote:
> > Where can I find that KCM? I've looked into the old kde-runtime repo, and
> > the new location in plasma-desktop, but no branches that look like the
> > code is in there.
> 
> The new one is only in my private clone of kde-runtime at the moment,
> I could push it to a branch there or plasma-desktop if you like.

That would be nice, a branch in plasma-desktop is fine. I'd like to spruce it 
up, so we can have it in the initial release.

> > You can find it in plasma-desktop[sebas/locale], it's quite
> > work-in-progressy.
> I'll have a play with it.
> 
> > I've started on the Formats KCM, it's very rough (but conceptionally
> > working, writing out export LC_ALL and sourcing that from startkde has
> > the desired effect, now on to splitting the variables out and adding more
> > UI for them.

> Cool, except LC_ALL should never be set by the shell, it's a special
> override for libraries to use when they need to ignore the users
> locale.

Already changed that, it now exports the individual variables, and I'm quite 
happy with the KCM now. I've posted a review request here: 
https://git.reviewboard.kde.org/r/118063/

I'll disable the old KCM shortly.

Thanks,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma Next Beta 1

[Jonathan Riddell]

Tars are available for Plasma Next Beta 1

Soon to be landing on depot.kde.org unstable/plasma/4.96.0

Temporary site:
http://starsky.19inch.net/~jr/tmp/plasma-4.96.0/
http://starsky.19inch.net/~jr/tmp/plasma-4.96.0/SHA256Sum

This release works with Qt 5.2 although it is probably better with Qt 5.3
RC.

It'll need KDE Frameworks 5 Beta 2 which was quietly released yesterday.

It should not overlap with kde-runtime or kdelibs from kdelibs4 land but
much of it will overlap with kde-workspace from kdelibs4 land, it's new
versions.

The translations will also overlap with translations from kde sc 4.13.  One
suggested solution it to install 4.13 translations into their own directory
and patch kdelibs4 to read from that directory.

I may well have made mistakes, this release is still quite undefined.  If
there are tars I should/should not have included, if there are branches I
should have used, if there are version numbers I should have set
differently either in the tars or internally let me know.

The Plasma team is still discussing what it still be called so for now I'll
call it Plasma Next.

I hope to announce this on Tuesday but how knows.

Good luck :)

Jonathan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118063: New Formats KCM

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118063/
---

Review request for Plasma and John Layt.


Bugs: 331930
https://bugs.kde.org/show_bug.cgi?id=331930


Repository: plasma-desktop


Description
---

The current "Locale" KCM is almost entirely broken. The way forward is to split 
it into localization options (this, Formats), and translaticons. This patch 
implements a new Formats KCM which writes out an environment suitable for 
QLocale to pick it up.

It's a rewrite of the current KCM, since:
- everything under the hood is different (KLocale is gone, QLocale takes over)
- everything above the hood is different, in QLocale, everything is deduced 
from the country / region

Now this includes feature regressions compared to the old KCM, but not all of 
these features can be done at all on top of QLocale right now, so we have to 
set up what we can.

This KCM caches the settings in a config file, but most importantly, it writes 
out a script with export instructions, which can be picked up by startkde. This 
is all done according to John's suggestions, and I have a patch for startkde to 
pick up the settings here. It all works fine (on my machine).

Many more details about the implementation can be found in the plasma-devel 
thead "Locale settings in Plasma Next", started by John on February, 23rd 2014.


Diffs
-

  kcms/formats/kcmformatswidget.ui PRE-CREATION 
  kcms/formats/kcmformats.cpp PRE-CREATION 
  kcms/formats/kcmformats.h PRE-CREATION 
  kcms/formats/Messages.sh PRE-CREATION 
  kcms/formats/formats.desktop PRE-CREATION 
  kcms/formats/CMakeLists.txt PRE-CREATION 
  kcms/CMakeLists.txt ed86efa 

Diff: https://git.reviewboard.kde.org/r/118063/diff/


Testing
---

Tried all kinds of different combinations, applied them, made sure they're 
exported correctly in the script.


File Attachments


new Formats KCM in kcmshell5
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/09/873980fe-04f2-4d75-9074-2aa676723061__formatskcm.png
Formats KCM in systemsettings
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/09/86a830ed-2d5d-4bdd-ba82-71ec73e6ce2c__formatskcmss.png


Thanks,

Sebastian Kügler

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New Logo (+Ksplash minimal)

[Marco Martin]

On Friday 09 May 2014, Jens Reuterberg wrote:
> First bit - how about changing the logo on Ksplash minimal (that Martin K
> suggested would get the gradient removed which is a great idea) to the
> Plasma Logo instead of KDE logo.
> 
> Second we've come to a sort of agreement in the KDE concerning the logo for
> Plasma to replace the Cashew. The idea was to follow the cashew in form
> instead of aesthetics and stick to "Flat but 3D" as a concept AND to have
> it spell out a P without using fonts - Uri Herrera is the dude who made
> it.

btw, regardless if this gets used or not, it should be used for the menu,
rather than the toolbox buttons that now have the "cashew"
(i have locally and about to push a pathc that replaces them with a generic 
"menu" ish icon, anybody scream now or gets pushed ;)

> 
> So if you have any good input - put it in. If not we can start doing promo
> work using it (which would be AWESOME)
> 
> Here's the logo:
> http://wstaw.org/m/2014/05/09/nNa4RLa.png

like it, for the colored version i do like the little gradient.
do you think it should be used also as an icon? (would require some shape 
tweaks in this case)
all in all, maybe if the dots are nearer to the p-ish shape would be a bit 
better?

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New Logo (+Ksplash minimal)

[Sebastian Kügler]

On Friday, May 09, 2014 16:46:56 Jens Reuterberg wrote:
> First bit - how about changing the logo on Ksplash minimal (that Martin K 
> suggested would get the gradient removed which is a great idea) to the
> Plasma  Logo instead of KDE logo.
> 
> Second we've come to a sort of agreement in the KDE concerning the logo for 
> Plasma to replace the Cashew. The idea was to follow the cashew in form
> instead of aesthetics and stick to "Flat but 3D" as a concept AND to have
> it spell out a P without using fonts - Uri Herrera is the dude who made it.
> 
> So if you have any good input - put it in. If not we can start doing promo 
> work using it (which would be AWESOME)
> 
> Here's the logo:
> http://wstaw.org/m/2014/05/09/nNa4RLa.png

Scope: This replaces the Plasma logo, not the KDE logo (had to make that clear 
to myself)

Direction: I like the simplistic style, but it's lacking personality to me in 
this form.

I completely agree that the old cashew / spilled yellow matter / Plasma logo 
looks outdated in today's context, so we need something new.

Thanks for picking up the work on that!
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New Logo (+Ksplash minimal)

[Marco Martin]

On Friday 09 May 2014, Martin Klapetek wrote:
> On Fri, May 9, 2014 at 4:59 PM, Jens Reuterberg  wrote:
> > Wait ok so where are we with the login+splash btw?
> 
> There's the sddm login theme and we now ship and use by default new simple
> splash theme, which is basically the same design as the login screen but
> just with a nice progress bar.

It may take the white version of the logo..

btw, that logo would be needed i guess at the various sizes for icons (then 
there is how to push in the icons since so far are *only* in a readonly svn 
server)

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New Logo (+Ksplash minimal)

[Martin Klapetek]

On Fri, May 9, 2014 at 4:59 PM, Jens Reuterberg  wrote:

> Wait ok so where are we with the login+splash btw?
>

There's the sddm login theme and we now ship and use by default new simple
splash theme, which is basically the same design as the login screen but
just with a nice progress bar.


Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QSG_RENDER_LOOP woes

[Sebastian Kügler]

On Friday, May 09, 2014 16:39:03 Martin Gräßlin wrote:
> On Friday 09 May 2014 16:29:32 Sebastian Kügler wrote:
> > On Friday, May 09, 2014 16:03:31 Martin Gräßlin wrote:
> > > On Friday 09 May 2014 15:56:53 Sebastian Kügler wrote:
> > >
> > > Please note that Qt itself switched it off for all of Mesa. The change
> > > now
> > > was  more to only have one possible way of usage and preventing us
> > > hunting
> > > down non-reproducable bugs.
> > >
> > > The crashes we see with threaded render loop cannot be fixed or worked
> > > around  if I understand the Qt commit disabling it for all of Mesa
> > > correctly. Have a look at the plasma-devel archives, I sent a FYI mail
> > > some
> > > time back.
> >
> > I remember that one. That email doesn't say much, except for your "basic
> > works for me" in kwin. I didn't see any problems with kwin, only with
> > plasma-shell, and I only changed it for plasma-shell in my tests: that
> > made
> > a difference (on Intel).
> 
> no I think I meant another mail, try 
> http://comments.gmane.org/gmane.comp.kde.devel.plasma/30179

That as well. Seems to work fine for kwin, seems to cause pain for Plasma. 
Meh.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New Logo (+Ksplash minimal)

[Jens Reuterberg]

Wait ok so where are we with the login+splash btw?

I know Andrew mentioned the logout dialogues being fixed to but I have no idea 
where/when/how. 
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: New Logo (+Ksplash minimal)

[Martin Klapetek]

On Fri, May 9, 2014 at 4:46 PM, Jens Reuterberg  wrote:

> First bit - how about changing the logo on Ksplash minimal (that Martin K
> suggested would get the gradient removed which is a great idea) to the
> Plasma
> Logo instead of KDE logo.
>

We now have two other splash screens, the new one and the "legacy" one,
which is recreation of the 4 series splash screen. I would personally throw
the spinning-gear-K splash out.

But it people want to keep it, then sure, let's change it.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118062: Add month name & month menu to Calendar applet

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118062/#review57643
---

Ship it!


Yes, it could also show the full date.

- Sebastian Kügler


On May 9, 2014, 2:31 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118062/
> ---
> 
> (Updated May 9, 2014, 2:31 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The standalone version of the Calendar applet misses the month header like 
> the calendar in the clock applet, this adds it
> 
> I also think we could maybe display full date in the header? I assume this 
> would be put expanded on the desktop, in which case it's quite useful to show 
> the full date so you can spot it at first sight.
> 
> Please advise.
> 
> 
> Diffs
> -
> 
>   applets/calendar/contents/ui/main.qml 77f8c91 
> 
> Diff: https://git.reviewboard.kde.org/r/118062/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Before the change
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/09/48cf194c-8d93-4c73-82a3-77308fdaaeac__before.png
> After
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/09/4ea2e39c-d3f2-4b65-a9b0-b6c7583e2d87__after.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118062: Add month name & month menu to Calendar applet

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118062/#review57644
---


This review has been submitted with commit 
8a1c53f97ea59d2f72d300e010330e79c0b67308 by Martin Klapetek to branch master.

- Commit Hook


On May 9, 2014, 2:31 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118062/
> ---
> 
> (Updated May 9, 2014, 2:31 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> The standalone version of the Calendar applet misses the month header like 
> the calendar in the clock applet, this adds it
> 
> I also think we could maybe display full date in the header? I assume this 
> would be put expanded on the desktop, in which case it's quite useful to show 
> the full date so you can spot it at first sight.
> 
> Please advise.
> 
> 
> Diffs
> -
> 
>   applets/calendar/contents/ui/main.qml 77f8c91 
> 
> Diff: https://git.reviewboard.kde.org/r/118062/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Before the change
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/09/48cf194c-8d93-4c73-82a3-77308fdaaeac__before.png
> After
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/09/4ea2e39c-d3f2-4b65-a9b0-b6c7583e2d87__after.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118062: Add month name & month menu to Calendar applet

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118062/
---

(Updated May 9, 2014, 2:46 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

The standalone version of the Calendar applet misses the month header like the 
calendar in the clock applet, this adds it

I also think we could maybe display full date in the header? I assume this 
would be put expanded on the desktop, in which case it's quite useful to show 
the full date so you can spot it at first sight.

Please advise.


Diffs
-

  applets/calendar/contents/ui/main.qml 77f8c91 

Diff: https://git.reviewboard.kde.org/r/118062/diff/


Testing
---


File Attachments


Before the change
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/09/48cf194c-8d93-4c73-82a3-77308fdaaeac__before.png
After
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/09/4ea2e39c-d3f2-4b65-a9b0-b6c7583e2d87__after.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

New Logo (+Ksplash minimal)

[Jens Reuterberg]

First bit - how about changing the logo on Ksplash minimal (that Martin K 
suggested would get the gradient removed which is a great idea) to the Plasma 
Logo instead of KDE logo. 

Second we've come to a sort of agreement in the KDE concerning the logo for 
Plasma to replace the Cashew. The idea was to follow the cashew in form 
instead of aesthetics and stick to "Flat but 3D" as a concept AND to have it 
spell out a P without using fonts - Uri Herrera is the dude who made it.

So if you have any good input - put it in. If not we can start doing promo 
work using it (which would be AWESOME)

Here's the logo:
http://wstaw.org/m/2014/05/09/nNa4RLa.png
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: QSG_RENDER_LOOP woes

[Martin Gräßlin]

On Friday 09 May 2014 16:29:32 Sebastian Kügler wrote:
> On Friday, May 09, 2014 16:03:31 Martin Gräßlin wrote:
> > On Friday 09 May 2014 15:56:53 Sebastian Kügler wrote:
> > > Since 30d2489930 in plasma-workspace, we're setting the QSG_RENDER_LOOP
> > > to
> > > "basic", if it's not specified otherwise by an env var. This has been
> > > done
> > > to prevent crashes in the threaded renderer, but unfortunately, it seems
> > > to
> > > come with its own set of problems: Plasma produces artifacts, high CPU
> > > load
> > > and grinds to a complete halt after a while.
> > > 
> > > 
> > > 
> > > I've tried setting the QSG_RENDER_LOOP to threaded, and that does indeed
> > > prevent those problems, but obviously, plasma-shell is more crashy with
> > > it.
> > > Now some of those crashes (at least one I've observed) is indeed in the
> > > scenegraph, but I've also seen other crashes (one in groupmanager of the
> > > taskbar, indirectly, not sure if that's related).
> > > 
> > > 
> > > 
> > > I think we might need to revisit this patch, and find a "stable" way
> > > forward. Just switching to basic renderloop doesn't seem to be the
> > > solution. :/
> > 
> > Please note that Qt itself switched it off for all of Mesa. The change now
> > was  more to only have one possible way of usage and preventing us hunting
> > down non-reproducable bugs.
> > 
> > The crashes we see with threaded render loop cannot be fixed or worked
> > around  if I understand the Qt commit disabling it for all of Mesa
> > correctly. Have a look at the plasma-devel archives, I sent a FYI mail
> > some
> > time back.
> 
> I remember that one. That email doesn't say much, except for your "basic
> works for me" in kwin. I didn't see any problems with kwin, only with
> plasma-shell, and I only changed it for plasma-shell in my tests: that made
> a difference (on Intel).

no I think I meant another mail, try 
http://comments.gmane.org/gmane.comp.kde.devel.plasma/30179

:-)

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118062: Add month name & month menu to Calendar applet

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118062/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

The standalone version of the Calendar applet misses the month header like the 
calendar in the clock applet, this adds it

I also think we could maybe display full date in the header? I assume this 
would be put expanded on the desktop, in which case it's quite useful to show 
the full date so you can spot it at first sight.

Please advise.


Diffs
-

  applets/calendar/contents/ui/main.qml 77f8c91 

Diff: https://git.reviewboard.kde.org/r/118062/diff/


Testing
---


File Attachments


Before the change
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/09/48cf194c-8d93-4c73-82a3-77308fdaaeac__before.png
After
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/09/4ea2e39c-d3f2-4b65-a9b0-b6c7583e2d87__after.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QSG_RENDER_LOOP woes

[Sebastian Kügler]

On Friday, May 09, 2014 16:03:31 Martin Gräßlin wrote:
> On Friday 09 May 2014 15:56:53 Sebastian Kügler wrote:
> >
> > Since 30d2489930 in plasma-workspace, we're setting the QSG_RENDER_LOOP to
> > "basic", if it's not specified otherwise by an env var. This has been done
> > to prevent crashes in the threaded renderer, but unfortunately, it seems
> > to
> > come with its own set of problems: Plasma produces artifacts, high CPU
> > load
> > and grinds to a complete halt after a while.
> >
> > 
> >
> > I've tried setting the QSG_RENDER_LOOP to threaded, and that does indeed
> > prevent those problems, but obviously, plasma-shell is more crashy with
> > it.
> > Now some of those crashes (at least one I've observed) is indeed in the
> > scenegraph, but I've also seen other crashes (one in groupmanager of the
> > taskbar, indirectly, not sure if that's related).
> >
> > 
> >
> > I think we might need to revisit this patch, and find a "stable" way
> > forward. Just switching to basic renderloop doesn't seem to be the
> > solution. :/
> 
> Please note that Qt itself switched it off for all of Mesa. The change now
> was  more to only have one possible way of usage and preventing us hunting
> down non-reproducable bugs.
> 
> The crashes we see with threaded render loop cannot be fixed or worked
> around  if I understand the Qt commit disabling it for all of Mesa
> correctly. Have a look at the plasma-devel archives, I sent a FYI mail some
> time back.

I remember that one. That email doesn't say much, except for your "basic works 
for me" in kwin. I didn't see any problems with kwin, only with plasma-shell, 
and I only changed it for plasma-shell in my tests: that made a difference (on 
Intel).

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 113419: Remove the upper-half white gradient from KSplash Minimalistic theme

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/113419/
---

(Updated May 9, 2014, 4:29 p.m.)


Status
--

This change has been discarded.


Review request for kde-workspace and Plasma.


Repository: kde-workspace


Description
---

NOTE: This is intended for the PW2, not current 4.x series.

Removes the white-black gradient spreading through the upper-half of the 
screen. IMHO it looks more elegant when it's just plain black.


Diffs
-

  ksplash/ksplashqml/themes/Minimalistic/main.qml e4fb8b8 

Diff: https://git.reviewboard.kde.org/r/113419/diff/


Testing
---


File Attachments


Before
  
https://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/32c5b408-0d3e-4639-b2ae-18f1a8dbd699__ksp_old.png
After
  
https://git.reviewboard.kde.org/media/uploaded/files/2013/10/24/d494e4b4-6e13-4ee8-934c-6ff7ac21bc33__ksp_new.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[plasma-shell] [Bug 328593] Dual screen has regressed in plasma-shell

[Martin Klapetek]

https://bugs.kde.org/show_bug.cgi?id=328593

Bug 328593 depends on bug 334502, which changed state.

Bug 334502 Summary: Panel positions in multiscreen are not remembered/placed 
depending on mouse position
https://bugs.kde.org/show_bug.cgi?id=334502

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QSG_RENDER_LOOP woes

[Martin Gräßlin]

On Friday 09 May 2014 15:56:53 Sebastian Kügler wrote:
> Hey,
> 
> Since 30d2489930 in plasma-workspace, we're setting the QSG_RENDER_LOOP to
> "basic", if it's not specified otherwise by an env var. This has been done
> to prevent crashes in the threaded renderer, but unfortunately, it seems to
> come with its own set of problems: Plasma produces artifacts, high CPU load
> and grinds to a complete halt after a while.
> 
> I've tried setting the QSG_RENDER_LOOP to threaded, and that does indeed
> prevent those problems, but obviously, plasma-shell is more crashy with it.
> Now some of those crashes (at least one I've observed) is indeed in the
> scenegraph, but I've also seen other crashes (one in groupmanager of the
> taskbar, indirectly, not sure if that's related).
> 
> I think we might need to revisit this patch, and find a "stable" way
> forward. Just switching to basic renderloop doesn't seem to be the
> solution. :/

Please note that Qt itself switched it off for all of Mesa. The change now was 
more to only have one possible way of usage and preventing us hunting down 
non-reproducable bugs.

The crashes we see with threaded render loop cannot be fixed or worked around 
if I understand the Qt commit disabling it for all of Mesa correctly. Have a 
look at the plasma-devel archives, I sent a FYI mail some time back.

Cheers
Martin

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118061: Plasma-mobile: Add an initial shell package

[Antonis Tsiapaliokas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118061/
---

Review request for Plasma.


Repository: plasma-mobile


Description
---

Add a copy of desktop shell package but remove the stuff that we
don't need. Like the contextmenu, panelconfiguration and the toolbox


Diffs
-

  qmlpackages/shell/package/metadata.desktop PRE-CREATION 
  qmlpackages/shell/package/contents/views/Panel.qml PRE-CREATION 
  qmlpackages/shell/package/contents/views/Desktop.qml PRE-CREATION 
  qmlpackages/shell/package/contents/layout.js PRE-CREATION 
  qmlpackages/shell/package/contents/loader.qml PRE-CREATION 
  qmlpackages/shell/package/contents/explorer/WidgetExplorer.qml PRE-CREATION 
  qmlpackages/shell/package/contents/explorer/Tooltip.qml PRE-CREATION 
  qmlpackages/shell/package/contents/explorer/AppletDelegate.qml PRE-CREATION 
  qmlpackages/shell/package/contents/defaults PRE-CREATION 
  qmlpackages/shell/package/contents/configuration/MouseEventInputButton.qml 
PRE-CREATION 
  qmlpackages/shell/package/contents/configuration/ContainmentConfiguration.qml 
PRE-CREATION 
  qmlpackages/shell/package/contents/configuration/ConfigurationShortcuts.qml 
PRE-CREATION 
  
qmlpackages/shell/package/contents/configuration/ConfigurationContainmentAppearance.qml
 PRE-CREATION 
  
qmlpackages/shell/package/contents/configuration/ConfigurationContainmentActions.qml
 PRE-CREATION 
  qmlpackages/shell/package/contents/configuration/ConfigCategoryDelegate.qml 
PRE-CREATION 
  qmlpackages/shell/package/contents/configuration/AppletConfiguration.qml 
PRE-CREATION 
  qmlpackages/shell/package/contents/applet/DefaultCompactRepresentation.qml 
PRE-CREATION 
  qmlpackages/shell/package/contents/applet/CompactApplet.qml PRE-CREATION 
  qmlpackages/shell/package/contents/applet/AppletError.qml PRE-CREATION 
  qmlpackages/shell/package/contents/activitymanager/WindowPreview.qml 
PRE-CREATION 
  qmlpackages/shell/package/contents/activitymanager/StoppedActivityItem.qml 
PRE-CREATION 
  qmlpackages/shell/package/contents/activitymanager/Heading.qml PRE-CREATION 
  qmlpackages/shell/package/contents/activitymanager/ControlButton.qml 
PRE-CREATION 
  qmlpackages/shell/package/contents/activitymanager/ActivityManager.qml 
PRE-CREATION 
  qmlpackages/shell/package/contents/activitymanager/ActivityList.qml 
PRE-CREATION 
  qmlpackages/shell/package/contents/activitymanager/ActivityItem.qml 
PRE-CREATION 
  qmlpackages/shell/package/contents/activitymanager/ActivityDeletionDialog.qml 
PRE-CREATION 
  qmlpackages/shell/package/contents/activitymanager/ActivityCreationDialog.qml 
PRE-CREATION 
  qmlpackages/shell/CMakeLists.txt PRE-CREATION 
  qmlpackages/shell/package/contents/activitymanager/ActivityBrowser.qml 
PRE-CREATION 
  qmlpackages/CMakeLists.txt d277441 
  CMakeLists.txt c7e3797 

Diff: https://git.reviewboard.kde.org/r/118061/diff/


Testing
---


Thanks,

Antonis Tsiapaliokas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Locale settings in Plasma Next

[John Layt]

On 6 May 2014 22:35, Sebastian Kügler  wrote:

> Where can I find that KCM? I've looked into the old kde-runtime repo, and the
> new location in plasma-desktop, but no branches that look like the code is in
> there.

The new one is only in my private clone of kde-runtime at the moment,
I could push it to a branch there or plasma-desktop if you like.

> You can find it in plasma-desktop[sebas/locale], it's quite work-in-progressy.

I'll have a play with it.

> I've started on the Formats KCM, it's very rough (but conceptionally working,
> writing out export LC_ALL and sourcing that from startkde has the desired
> effect, now on to splitting the variables out and adding more UI for them.

Cool, except LC_ALL should never be set by the shell, it's a special
override for libraries to use when they need to ignore the users
locale.

Cheers!

John.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

QSG_RENDER_LOOP woes

[Sebastian Kügler]

Hey,

Since 30d2489930 in plasma-workspace, we're setting the QSG_RENDER_LOOP to 
"basic", if it's not specified otherwise by an env var. This has been done to 
prevent crashes in the threaded renderer, but unfortunately, it seems to come 
with its own set of problems: Plasma produces artifacts, high CPU load and 
grinds to a complete halt after a while.

I've tried setting the QSG_RENDER_LOOP to threaded, and that does indeed 
prevent those problems, but obviously, plasma-shell is more crashy with it. 
Now some of those crashes (at least one I've observed) is indeed in the 
scenegraph, but I've also seen other crashes (one in groupmanager of the 
taskbar, indirectly, not sure if that's related).

I think we might need to revisit this patch, and find a "stable" way forward. 
Just switching to basic renderloop doesn't seem to be the solution. :/

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to normal : plasma-desktop_master_qt5 #151

[KDE CI System]

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Compatibility problems with latest GTK+ applications

[Jens Reuterberg]

Tell me if you have issues moving it through and we can all try to talk with 
our respective contacts and try to get them to push it a bit :)

On Friday 09 May 2014 13.20.56 David Edmundson wrote:
> >Pardon my ignorance, but does Gtk impose CSD on all apps, or just
> >those apps that opt-in to using it?
> 
> GTK apps can opt out (by not using a GTKHeader widget)
> I can't imagine the Gimp adopting that design anytime soon. They're
> already quite far from Gnome HIG.
> 
> I patched GTK here:
> https://bugzilla.gnome.org/show_bug.cgi?id=729721 to only enable CSD
> if the WM supports checking for gtk shadow hints.
> 
> If anyone wants to check my patch that would be appreciated.
> 
> One of the developers seemed responsive. I'm quite optimistic this
> will all be resolved.
> 
> David
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Compatibility problems with latest GTK+ applications

[John Layt]

On 9 May 2014 10:04, Martin Gräßlin  wrote:
>
> XFCE is affected in that way that GTK developers opened bug reports against
> XFCE that their window manager is broken (stating it's the only one not
> supporting that, well KWin neither).

That's not exactly the way to win friends and influence people :-)

> I'm not sure whether it's opt-in. Using the gtk3-demo and the gallery one can
> find many examples which enforce client-side-decorations. E.g. the standard
> message box dialog example.

If the standard dialogs have it forced, then that does become a big
issue.  If an app chooses to not work cross-desktop that's their
problem, but if an app that wants to be cross-desktop suddenly finds
the standard dialogs don't work then that's a bad thing.

John.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Compatibility problems with latest GTK+ applications

[David Edmundson]

>Pardon my ignorance, but does Gtk impose CSD on all apps, or just
>those apps that opt-in to using it?

GTK apps can opt out (by not using a GTKHeader widget)
I can't imagine the Gimp adopting that design anytime soon. They're
already quite far from Gnome HIG.

I patched GTK here:
https://bugzilla.gnome.org/show_bug.cgi?id=729721 to only enable CSD
if the WM supports checking for gtk shadow hints.

If anyone wants to check my patch that would be appreciated.

One of the developers seemed responsive. I'm quite optimistic this
will all be resolved.

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[plasma-shell] [Bug 328593] Dual screen has regressed in plasma-shell

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=328593

Aleix Pol  changed:

   What|Removed |Added

 Depends on||334548

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[plasma-shell] [Bug 328593] Dual screen has regressed in plasma-shell

[Martin Klapetek]

https://bugs.kde.org/show_bug.cgi?id=328593

Bug 328593 depends on bug 334500, which changed state.

Bug 334500 Summary: plasmoid.screen returns -1 in multiscreen setup
https://bugs.kde.org/show_bug.cgi?id=334500

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to normal : plasma-workspace_master_qt5 #182

[KDE CI System]

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [kde-build-metadata] /: Introduce libkscreen as a feature of Plasma Workspace

[Martin Klapetek]

On Thu, May 8, 2014 at 12:45 PM, Martin Klapetek
wrote:

> It also needs to be added on jenkins, otherwise the build will keep
> failing there too.
>

For the record, it was just added by Aurelien.

Cheers
-- 
Martin Klapetek | KDE Developer
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Compatibility problems with latest GTK+ applications

[Martin Gräßlin]

On Friday 09 May 2014 09:54:53 John Layt wrote:
> On 8 May 2014 13:56, Sebastian Kügler  wrote:
> > On Thursday, May 08, 2014 14:39:49 Matthias Klumpp wrote:
> >> However, to support the cross-desktop efforts, the GNOME people should
> >> maybe make a few compromises (e.g. make GTK+ behave differently on
> >> other DEs), especially since GTK+ is not just for GNOME but also used
> >> by other projects.
> > 
> > This is actually at the root of all these problems. The GTK developers
> > have at some point decided to couple the toolkit with the GNOME desktop,
> > so GTK is -- in their view -- the toolkit for GNOME. It seems, the
> > developers lost interest in keeping their cross-platform and
> > cross-desktop promise. This is visible in other areas as well, such as
> > theming: Theming APIs have been unstable and changed will-nilly for some
> > time now, and the revolt of theme creators has calmed down by now (I
> > suppose they all just walked away). I suppose this CSD episode will just
> > speed up this exodus.
> > 
> > We might be looking at a completely different GTK here than we did a few
> > years ago, and that's pretty bad news for interoperability on the
> > freedesktop.
> Exactly, they seem to have forgotten what the G actually stands for
> 
> :-)  Which makes me wonder how apps like Gimp who use Gtk but are not
> 
> part of Gnome and want to be cross-desktop and cross-platform are
> going to be affected?  And how are the other Gtk desktops like XFCE
> affected?

XFCE is affected in that way that GTK developers opened bug reports against 
XFCE that their window manager is broken (stating it's the only one not 
supporting that, well KWin neither).

> 
> Pardon my ignorance, but does Gtk impose CSD on all apps, or just
> those apps that opt-in to using it?  I'm assuming it's opt-in, in
> which case perhaps the app authors don't realise the implication for
> other desktops/platforms?  If they do realise what it means then
> that's their decision to only support Gnome and I don't see why we
> should even bother to try work around it: if it looks ugly elsewhere
> and that costs them users, that's their problem not ours.

I'm not sure whether it's opt-in. Using the gtk3-demo and the gallery one can 
find many examples which enforce client-side-decorations. E.g. the standard 
message box dialog example.

> 
> Either way, it seems to me that the Gtk app and desktop authors may be
> the people in the best position to influence Gtk to work on these
> issues, the Gtk maintainers may not care about what KDE thinks, but
> you'd hope that they would listen to their own users.  Perhaps if/when
> the direct approach fails, we need to raise bugs reports against the
> apps themselves to get their authors interested?
> 
> John.
> 
> P.S. If Gtk keep this up, we could see another surge in apps switching
> to Qt, and that presents a great opportunity for KDE as a community
> interested in being cross-platform/desktop


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Compatibility problems with latest GTK+ applications

[John Layt]

On 8 May 2014 13:56, Sebastian Kügler  wrote:
> On Thursday, May 08, 2014 14:39:49 Matthias Klumpp wrote:
>> However, to support the cross-desktop efforts, the GNOME people should
>> maybe make a few compromises (e.g. make GTK+ behave differently on
>> other DEs), especially since GTK+ is not just for GNOME but also used
>> by other projects.
>
> This is actually at the root of all these problems. The GTK developers have at
> some point decided to couple the toolkit with the GNOME desktop, so GTK is --
> in their view -- the toolkit for GNOME. It seems, the developers lost interest
> in keeping their cross-platform and cross-desktop promise. This is visible in
> other areas as well, such as theming: Theming APIs have been unstable and
> changed will-nilly for some time now, and the revolt of theme creators has
> calmed down by now (I suppose they all just walked away). I suppose this CSD
> episode will just speed up this exodus.
>
> We might be looking at a completely different GTK here than we did a few years
> ago, and that's pretty bad news for interoperability on the freedesktop.

Exactly, they seem to have forgotten what the G actually stands for
:-)  Which makes me wonder how apps like Gimp who use Gtk but are not
part of Gnome and want to be cross-desktop and cross-platform are
going to be affected?  And how are the other Gtk desktops like XFCE
affected?

Pardon my ignorance, but does Gtk impose CSD on all apps, or just
those apps that opt-in to using it?  I'm assuming it's opt-in, in
which case perhaps the app authors don't realise the implication for
other desktops/platforms?  If they do realise what it means then
that's their decision to only support Gnome and I don't see why we
should even bother to try work around it: if it looks ugly elsewhere
and that costs them users, that's their problem not ours.

Either way, it seems to me that the Gtk app and desktop authors may be
the people in the best position to influence Gtk to work on these
issues, the Gtk maintainers may not care about what KDE thinks, but
you'd hope that they would listen to their own users.  Perhaps if/when
the direct approach fails, we need to raise bugs reports against the
apps themselves to get their authors interested?

John.

P.S. If Gtk keep this up, we could see another surge in apps switching
to Qt, and that presents a great opportunity for KDE as a community
interested in being cross-platform/desktop
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Compatibility problems with latest GTK+ applications

[John Layt]

On 8 May 2014 13:56, Sebastian Kügler  wrote:
> On Thursday, May 08, 2014 14:39:49 Matthias Klumpp wrote:
>> However, to support the cross-desktop efforts, the GNOME people should
>> maybe make a few compromises (e.g. make GTK+ behave differently on
>> other DEs), especially since GTK+ is not just for GNOME but also used
>> by other projects.
>
> This is actually at the root of all these problems. The GTK developers have at
> some point decided to couple the toolkit with the GNOME desktop, so GTK is --
> in their view -- the toolkit for GNOME. It seems, the developers lost interest
> in keeping their cross-platform and cross-desktop promise. This is visible in
> other areas as well, such as theming: Theming APIs have been unstable and
> changed will-nilly for some time now, and the revolt of theme creators has
> calmed down by now (I suppose they all just walked away). I suppose this CSD
> episode will just speed up this exodus.
>
> We might be looking at a completely different GTK here than we did a few years
> ago, and that's pretty bad news for interoperability on the freedesktop.

Exactly, they seem to have forgotten what the G actually stands for
:-)  Which makes me wonder how apps like Gimp who use Gtk but are not
part of Gnome and want to be cross-desktop and cross-platform are
going to be affected?  And how are the other Gtk desktops like XFCE
affected?

Pardon my ignorance, but does Gtk impose CSD on all apps, or just
those apps that opt-in to using it?  I'm assuming it's opt-in, in
which case perhaps the app authors don't realise the implication for
other desktops/platforms?  If they do realise what it means then
that's their decision to only support Gnome and I don't see why we
should even bother to try work around it: if it looks ugly elsewhere
and that costs them users, that's their problem not ours.

Either way, it seems to me that the Gtk app and desktop authors may be
the people in the best position to influence Gtk to work on these
issues, the Gtk maintainers may not care about what KDE thinks, but
you'd hope that they would listen to their own users.  Perhaps if/when
the direct approach fails, we need to raise bugs reports against the
apps themselves to get their authors interested?

John.

P.S. If Gtk keep this up, we could see another surge in apps switching
to Qt, and that presents a great opportunity for KDE as a community
interested in being cross-platform/desktop
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117904: Set soversion to match Plasma

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117904/
---

(Updated May 9, 2014, 8:01 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Solid and Àlex Fiestas.


Repository: powerdevil


Description
---

Set SOVERSION to 5 to match libraries elsewhere in Plasma


Diffs
-

  CMakeLists.txt 0dfc422 

Diff: https://git.reviewboard.kde.org/r/117904/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-desktop_master_qt5 #150

[KDE CI System]

See 

Changes:

[jr] use renamed country.desktop files from 
https://git.reviewboard.kde.org/r/117940/

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[plasma-desktop_master_qt5] $ /bin/sh -xe /tmp/hudson8080516042092885766.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-desktop
   af06f17..00c7bd5  master -> origin/master
   9bc3819..7569398  sebas/locale -> origin/sebas/locale
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at af06f17 Install documentation into own subdirectory.
Success build forhudson.tasks.Shell@16e0784c
 > git rev-parse --is-inside-work-tree
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/plasma-desktop
Fetching upstream changes from git://anongit.kde.org/plasma-desktop
 > git --version
 > git fetch --tags --progress git://anongit.kde.org/plasma-desktop 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/refs/heads/jenkins^{commit}
 > git rev-parse refs/heads/jenkins^{commit}
Checking out Revision 00c7bd52b7b3fc48eb0bb835935a60b3e6a95b86 
(refs/heads/jenkins)
 > git config core.sparsecheckout
 > git checkout -f 00c7bd52b7b3fc48eb0bb835935a60b3e6a95b86
 > git rev-list af06f17f4d2d75f0c80de184dd29d35d8cdda592
 > git tag -a -f -m Jenkins Build #150 jenkins-plasma-desktop_master_qt5-150
[plasma-desktop_master_qt5] $ /bin/sh -xe /tmp/hudson6657797147035188916.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-desktop - Branch master
== Build Dependencies:
 khtml - Branch master
 ksysguard - Branch master
 frameworkintegration - Branch master
 kplotting - Branch master
 sonnet - Branch master
 kcodecs - Branch master
 kdoctools - Branch master
 kf5umbrella - Branch master
 kiconthemes - Branch master
 kfilemetadata - Branch frameworks
 kjsembed - Branch master
 extra-cmake-modules - Branch master
 kdnssd - Branch master
 kcoreaddons - Branch master
 libdbusmenu-qt - Branch master
 plasma-framework - Branch master
 ktexteditor - Branch master
 kdeclarative - Branch master
 karchive - Branch master
 kcmutils - Branch master
 oxygen - Branch master
 powerdevil - Branch master
 kemoticons - Branch master
 kio-extras - Branch master
 kdesupport-svn - Branch master
 kconfig - Branch master
 kguiaddons - Branch master
 kdbusaddons - Branch master
 kjs - Branch master
 systemsettings - Branch master
 kded - Branch master
 kglobalaccel - Branch master
 kjobwidgets - Branch master
 krunner - Branch master
 kidletime - Branch master
 kauth - Branch master
 kio - Branch master
 kxmlgui - Branch master
 kservice - Branch master
 kconfigwidgets - Branch master
 knewstuff - Branch master
 kunitconversion - Branch master
 ki18n - Branch master
 kwidgetsaddons - Branch master
 kitemmodels - Branch master
 kcrash - Branch master
 kdesu - Branch master
 polkit-qt-1 - Branch qt5
 kitemviews - Branch master
 solid - Branch master
 libkscreen - Branch frameworks
 breeze - Branch master
 kinit - Branch master
 kactivities - Branch master
 kdewebkit - Branch master
 phonon - Branch master
 khelpcenter - Branch master
 plasma-workspace - Branch master
 kwindowsystem - Branch master
 ktextwidgets - Branch master
 cmake - Branch master
 baloo - Branch frameworks
 milou - Branch frameworks
 kwallet - Branch master
 kcompletion - Branch master
 knotifications - Branch master
 kpty - Branch master
 attica - Branch master
 qt5 - Branch stable
 kdelibs4support - Branch master
 kbookmarks - Branch master
 threadweaver - Branch master
 kde-cli-tools - Branch master
 libksysguard - Branch master
 kross - Branch master
 kwin - Branch master
 kparts - Branch master
 kdesignerplugin - Branch master
 knotifyconfig - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/extragear/libs/libkscreen/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project plasma-desktop failed.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Recording 

Re: Review Request 117942: use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117942/
---

(Updated May 9, 2014, 7:44 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-desktop


Description
---

use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/


Diffs
-

  kcms/locale/kcmlocale.h f3a691596128c438ce9db7f45b1712fc585ae042 
  kcms/locale/kcmlocale.cpp c430bcd048b962dc3eaf49a278ba8fffb5244bb0 

Diff: https://git.reviewboard.kde.org/r/117942/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117942: use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117942/
---

(Updated May 9, 2014, 7:44 a.m.)


Review request for Plasma.


Repository: plasma-desktop


Description
---

use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/


Diffs
-

  kcms/locale/kcmlocale.h f3a691596128c438ce9db7f45b1712fc585ae042 
  kcms/locale/kcmlocale.cpp c430bcd048b962dc3eaf49a278ba8fffb5244bb0 

Diff: https://git.reviewboard.kde.org/r/117942/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117942: use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117942/
---

(Updated May 9, 2014, 7:44 a.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-desktop


Description
---

use renamed country.desktop files from https://git.reviewboard.kde.org/r/117940/


Diffs
-

  kcms/locale/kcmlocale.h f3a691596128c438ce9db7f45b1712fc585ae042 
  kcms/locale/kcmlocale.cpp c430bcd048b962dc3eaf49a278ba8fffb5244bb0 

Diff: https://git.reviewboard.kde.org/r/117942/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #181

[KDE CI System]

See 

Changes:

[jr] rename kuiserver to kuiserver5 for coinstallability

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson948542886845753497.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-workspace
   602e7f2..6a7ba41  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at 602e7f2 Remove useless timer from systray, which only closes the 
popup in 10ms
Success build forhudson.tasks.Shell@31785114
 > git rev-parse --is-inside-work-tree
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/plasma-workspace
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
 > git --version
 > git fetch --tags --progress git://anongit.kde.org/plasma-workspace 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/refs/heads/jenkins^{commit}
 > git rev-parse refs/heads/jenkins^{commit}
Checking out Revision 6a7ba4115b0a05b93eab0dffec78be9132a89e9d 
(refs/heads/jenkins)
 > git config core.sparsecheckout
 > git checkout -f 6a7ba4115b0a05b93eab0dffec78be9132a89e9d
 > git rev-list 612f470b9fd7a0c9b0cb66bde3cd09df0d252911
 > git tag -a -f -m Jenkins Build #181 jenkins-plasma-workspace_master_qt5-181
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson6935319872601171582.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
 kcrash - Branch master
 kf5umbrella - Branch master
 sonnet - Branch master
 libdbusmenu-qt - Branch master
 kservice - Branch master
 kdoctools - Branch master
 kpty - Branch master
 kio - Branch master
 kiconthemes - Branch master
 kfilemetadata - Branch frameworks
 kidletime - Branch master
 ktexteditor - Branch master
 kwallet - Branch master
 kcoreaddons - Branch master
 kded - Branch master
 plasma-framework - Branch master
 kdnssd - Branch master
 karchive - Branch master
 kcmutils - Branch master
 kglobalaccel - Branch master
 kconfig - Branch master
 kcodecs - Branch master
 extra-cmake-modules - Branch master
 knewstuff - Branch master
 kwin - Branch master
 kguiaddons - Branch master
 kdesignerplugin - Branch master
 kjobwidgets - Branch master
 krunner - Branch master
 kdelibs4support - Branch master
 kross - Branch master
 kauth - Branch master
 kemoticons - Branch master
 kdesu - Branch master
 libksysguard - Branch master
 kunitconversion - Branch master
 polkit-qt-1 - Branch qt5
 ki18n - Branch master
 kwidgetsaddons - Branch master
 kplotting - Branch master
 kcompletion - Branch master
 kde-cli-tools - Branch master
 kdbusaddons - Branch master
 libkscreen - Branch frameworks
 kdewebkit - Branch master
 breeze - Branch master
 kactivities - Branch master
 solid - Branch master
 phonon - Branch master
 frameworkintegration - Branch master
 knotifications - Branch master
 kwindowsystem - Branch master
 ktextwidgets - Branch master
 kdeclarative - Branch master
 baloo - Branch frameworks
 milou - Branch frameworks
 threadweaver - Branch master
 kjsembed - Branch master
 kio-extras - Branch master
 kitemmodels - Branch master
 knotifyconfig - Branch master
 qt5 - Branch stable
 kdesupport-svn - Branch master
 kbookmarks - Branch master
 khtml - Branch master
 cmake - Branch master
 kxmlgui - Branch master
 kconfigwidgets - Branch master
 khelpcenter - Branch master
 kitemviews - Branch master
 kparts - Branch master
 kjs - Branch master
 attica - Branch master
 kinit - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/extragear/libs/libkscreen/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project plasma-workspace failed.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Recording test results
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117876/
---

(Updated May 9, 2014, 7:35 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

kuiserver in kde 4 land is from kde-runtime so needs to be co-installable with 
plasma next.  rename to kuiserver5.


Diffs
-

  kuiserver/CMakeLists.txt 6d79b41 
  kuiserver/kuiserver.desktop 2dec197 

Diff: https://git.reviewboard.kde.org/r/117876/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117876: rename kuiserver to kuiserver5 for coinstallability

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117876/#review57628
---


This review has been submitted with commit 
6a7ba4115b0a05b93eab0dffec78be9132a89e9d by Jonathan Riddell to branch master.

- Commit Hook


On April 30, 2014, 9:20 a.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117876/
> ---
> 
> (Updated April 30, 2014, 9:20 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> kuiserver in kde 4 land is from kde-runtime so needs to be co-installable 
> with plasma next.  rename to kuiserver5.
> 
> 
> Diffs
> -
> 
>   kuiserver/CMakeLists.txt 6d79b41 
>   kuiserver/kuiserver.desktop 2dec197 
> 
> Diff: https://git.reviewboard.kde.org/r/117876/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-workspace_master_qt5 #180

[KDE CI System]

See 

Changes:

[jr] don't install kconf_update files from KDE4 land, KF5 apps start with a 
fresh install

--
Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit
Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace 

Running Prebuild steps
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson5360232989249167387.sh
+ /home/jenkins/scripts/setup-env.sh

Preparing to perform KDE Continuous Integration build
== Setting Up Sources

>From git://anongit.kde.org/plasma-workspace
   d56af60..612f470  master -> origin/master
Branch jenkins set up to track remote branch master from origin.

== Cleaning Source Tree

HEAD is now at d56af60 Configuration option to disable plasmoids is back
Success build forhudson.tasks.Shell@31785114
 > git rev-parse --is-inside-work-tree
Fetching changes from the remote Git repository
 > git config remote.origin.url git://anongit.kde.org/plasma-workspace
Fetching upstream changes from git://anongit.kde.org/plasma-workspace
 > git --version
 > git fetch --tags --progress git://anongit.kde.org/plasma-workspace 
 > +refs/heads/*:refs/remotes/origin/*
 > git rev-parse origin/refs/heads/jenkins^{commit}
 > git rev-parse refs/heads/jenkins^{commit}
Checking out Revision 612f470b9fd7a0c9b0cb66bde3cd09df0d252911 
(refs/heads/jenkins)
 > git config core.sparsecheckout
 > git checkout -f 612f470b9fd7a0c9b0cb66bde3cd09df0d252911
 > git rev-list d56af607161b3ec957318928ecbf80170629d4e7
 > git tag -a -f -m Jenkins Build #180 jenkins-plasma-workspace_master_qt5-180
[plasma-workspace_master_qt5] $ /bin/sh -xe /tmp/hudson4825709919021156318.sh
+ /home/jenkins/scripts/execute-job.sh

KDE Continuous Integration Build
== Building Project: plasma-workspace - Branch master
== Build Dependencies:
 kf5umbrella - Branch master
 sonnet - Branch master
 kcodecs - Branch master
 kservice - Branch master
 kdoctools - Branch master
 kpty - Branch master
 kio - Branch master
 kiconthemes - Branch master
 kfilemetadata - Branch frameworks
 kwindowsystem - Branch master
 kidletime - Branch master
 ktexteditor - Branch master
 kwallet - Branch master
 kcoreaddons - Branch master
 plasma-framework - Branch master
 kdnssd - Branch master
 karchive - Branch master
 kcmutils - Branch master
 kglobalaccel - Branch master
 kconfig - Branch master
 khtml - Branch master
 kemoticons - Branch master
 knewstuff - Branch master
 kparts - Branch master
 kwin - Branch master
 kguiaddons - Branch master
 kdelibs4support - Branch master
 kjobwidgets - Branch master
 krunner - Branch master
 cmake - Branch master
 frameworkintegration - Branch master
 kdesu - Branch master
 libksysguard - Branch master
 kinit - Branch master
 kunitconversion - Branch master
 polkit-qt-1 - Branch qt5
 ki18n - Branch master
 kwidgetsaddons - Branch master
 kplotting - Branch master
 kcompletion - Branch master
 kde-cli-tools - Branch master
 kdbusaddons - Branch master
 threadweaver - Branch master
 kdewebkit - Branch master
 libkscreen - Branch frameworks
 kross - Branch master
 breeze - Branch master
 kded - Branch master
 solid - Branch master
 phonon - Branch master
 knotifications - Branch master
 kcrash - Branch master
 kauth - Branch master
 kdeclarative - Branch master
 baloo - Branch frameworks
 kdesignerplugin - Branch master
 milou - Branch frameworks
 kdesupport-svn - Branch master
 kitemmodels - Branch master
 kio-extras - Branch master
 kjsembed - Branch master
 kjs - Branch master
 kbookmarks - Branch master
 knotifyconfig - Branch master
 qt5 - Branch stable
 extra-cmake-modules - Branch master
 libdbusmenu-qt - Branch master
 kxmlgui - Branch master
 kconfigwidgets - Branch master
 khelpcenter - Branch master
 kitemviews - Branch master
 ktextwidgets - Branch master
 attica - Branch master
 kactivities - Branch master

== Applying Patches
=== No patches to apply

== Syncing Dependencies from Master Server

rsync: change_dir 
"/srv/jenkins/install/linux/x86_64/g++/kf5-qt5/extragear/libs/libkscreen/inst" 
failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 
23) at main.c(1530) [Receiver=3.0.9]
Syncing dependencies from master server for project plasma-workspace failed.
Build step 'Execute shell' marked build as failure
[WARNINGS] Skipping publisher since build result is FAILURE
Recording test results
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117861: remove obsolete kconfig_update file

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117861/
---

(Updated May 9, 2014, 7:31 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: kio-extras


Description
---

update to https://git.reviewboard.kde.org/r/117093 for split repositories

remove kconf_update file which handles settings from kdelibs4 land.  In kf5 
land people will start with clean settings.


Diffs
-

  kurifilter-plugins/ikws/CMakeLists.txt 51294b5 
  kurifilter-plugins/ikws/kuriikwsfilter.upd 0874ce2 

Diff: https://git.reviewboard.kde.org/r/117861/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117874: don't install kconf_update files from KDE4 land, KF5 apps start with a fresh install

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117874/#review57626
---


This review has been submitted with commit 
612f470b9fd7a0c9b0cb66bde3cd09df0d252911 by Jonathan Riddell to branch master.

- Commit Hook


On April 29, 2014, 3:10 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117874/
> ---
> 
> (Updated April 29, 2014, 3:10 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> don't install kconf_update files from KDE4 land, KF5 apps start with a fresh 
> install
> 
> 
> Diffs
> -
> 
>   drkonqi/CMakeLists.txt 4794621 
>   drkonqi/drkonqi-rename-config-section.upd 413908f 
>   kglobalaccel/CMakeLists.txt 1ddee63 
>   kglobalaccel/kconf/kdedglobalaccel_kde42.upd 260434a 
>   klipper/CMakeLists.txt f4bd831 
>   klipper/klipper-kconfigxt.upd 586948e 
>   ksmserver/CMakeLists.txt 65af7d8 
>   ksmserver/ksmserver_shortcuts.upd 760f6a9 
>   ksmserver/screenlocker/CMakeLists.txt 700cdff 
>   ksmserver/screenlocker/data/CMakeLists.txt 624eaf3 
>   ksmserver/screenlocker/data/force_krunner_lock_shortcut_unreg.cpp fe1cd8a 
>   ksmserver/screenlocker/data/kscreenlocker_locksession-shortcut.upd cbc4d52 
> 
> Diff: https://git.reviewboard.kde.org/r/117874/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117874: don't install kconf_update files from KDE4 land, KF5 apps start with a fresh install

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117874/
---

(Updated May 9, 2014, 7:29 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

don't install kconf_update files from KDE4 land, KF5 apps start with a fresh 
install


Diffs
-

  drkonqi/CMakeLists.txt 4794621 
  drkonqi/drkonqi-rename-config-section.upd 413908f 
  kglobalaccel/CMakeLists.txt 1ddee63 
  kglobalaccel/kconf/kdedglobalaccel_kde42.upd 260434a 
  klipper/CMakeLists.txt f4bd831 
  klipper/klipper-kconfigxt.upd 586948e 
  ksmserver/CMakeLists.txt 65af7d8 
  ksmserver/ksmserver_shortcuts.upd 760f6a9 
  ksmserver/screenlocker/CMakeLists.txt 700cdff 
  ksmserver/screenlocker/data/CMakeLists.txt 624eaf3 
  ksmserver/screenlocker/data/force_krunner_lock_shortcut_unreg.cpp fe1cd8a 
  ksmserver/screenlocker/data/kscreenlocker_locksession-shortcut.upd cbc4d52 

Diff: https://git.reviewboard.kde.org/r/117874/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117859: rename kioslave files for co-installability

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117859/
---

(Updated May 9, 2014, 7:07 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: kio-extras


Description
---

rename kioslave files for co-installability

ktrash -> ktrash5 (I'm not aware of anything which uses this binary)
network.xml -> kf5_network.xml
org.kde.network.kioslavenotifier.xml -> 
kf5_org.kde.network.kioslavenotifier.xml (I don't know what uses this but I 
assume something must and will need updated)

old review for pre-split kde-runtime https://git.reviewboard.kde.org/r/117092/


Diffs
-

  archive/tar.protocol 9442d4d 
  bookmarks/bookmarks.protocol 68503d8 
  cgi/cgi.protocol 862758a 
  doc/kioslave/bookmarks/CMakeLists.txt d90f510 
  doc/kioslave/bzip2/CMakeLists.txt 164ff50 
  doc/kioslave/cgi/CMakeLists.txt 4474a13 
  doc/kioslave/finger/CMakeLists.txt 54a06b0 
  doc/kioslave/fish/CMakeLists.txt a711911 
  doc/kioslave/floppy/CMakeLists.txt 601a7e8 
  doc/kioslave/gzip/CMakeLists.txt 15d9a61 
  doc/kioslave/info/CMakeLists.txt 3a4ace9 
  doc/kioslave/man/CMakeLists.txt 7375332 
  doc/kioslave/network/CMakeLists.txt 0921d20 
  doc/kioslave/nfs/CMakeLists.txt 5d98ace 
  doc/kioslave/sftp/CMakeLists.txt fe08290 
  doc/kioslave/smb/CMakeLists.txt 906e945 
  doc/kioslave/tar/CMakeLists.txt a699590 
  doc/kioslave/thumbnail/CMakeLists.txt 555407d 
  doc/kioslave/xz/CMakeLists.txt 731d519 
  filter/bzip.protocol eceae18 
  filter/bzip2.protocol 3db24ff 
  filter/gzip.protocol b0fa2b3 
  filter/lzma.protocol cdaa888 
  filter/xz.protocol fc66e28 
  finger/finger.protocol dda641b 
  fish/fish.protocol fd577c8 
  floppy/floppy.protocol cbd288a 
  info/info.protocol c001580 
  kurifilter-plugins/ikws/CMakeLists.txt 51294b5 
  kurifilter-plugins/ikws/kuriikwsfilter.upd 0874ce2 
  man/man.protocol cd03f9f 
  network/kded/CMakeLists.txt e851f73 
  network/mimetypes/CMakeLists.txt c20dc90 
  nfs/nfs.protocol 4781b3c 
  sftp/sftp.protocol 6e49ed2 
  smb/smb.protocol e15395e 
  thumbnail/thumbnail.protocol 216f428 
  trash/CMakeLists.txt 7c72cdc 

Diff: https://git.reviewboard.kde.org/r/117859/diff/


Testing
---


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117859: rename kioslave files for co-installability

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117859/#review57625
---


This review has been submitted with commit 
fac9aa7d600582f9e030370a294ce486265ddc2c by Jonathan Riddell to branch master.

- Commit Hook


On April 30, 2014, 9:36 a.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117859/
> ---
> 
> (Updated April 30, 2014, 9:36 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> rename kioslave files for co-installability
> 
> ktrash -> ktrash5 (I'm not aware of anything which uses this binary)
> network.xml -> kf5_network.xml
> org.kde.network.kioslavenotifier.xml -> 
> kf5_org.kde.network.kioslavenotifier.xml (I don't know what uses this but I 
> assume something must and will need updated)
> 
> old review for pre-split kde-runtime https://git.reviewboard.kde.org/r/117092/
> 
> 
> Diffs
> -
> 
>   archive/tar.protocol 9442d4d 
>   bookmarks/bookmarks.protocol 68503d8 
>   cgi/cgi.protocol 862758a 
>   doc/kioslave/bookmarks/CMakeLists.txt d90f510 
>   doc/kioslave/bzip2/CMakeLists.txt 164ff50 
>   doc/kioslave/cgi/CMakeLists.txt 4474a13 
>   doc/kioslave/finger/CMakeLists.txt 54a06b0 
>   doc/kioslave/fish/CMakeLists.txt a711911 
>   doc/kioslave/floppy/CMakeLists.txt 601a7e8 
>   doc/kioslave/gzip/CMakeLists.txt 15d9a61 
>   doc/kioslave/info/CMakeLists.txt 3a4ace9 
>   doc/kioslave/man/CMakeLists.txt 7375332 
>   doc/kioslave/network/CMakeLists.txt 0921d20 
>   doc/kioslave/nfs/CMakeLists.txt 5d98ace 
>   doc/kioslave/sftp/CMakeLists.txt fe08290 
>   doc/kioslave/smb/CMakeLists.txt 906e945 
>   doc/kioslave/tar/CMakeLists.txt a699590 
>   doc/kioslave/thumbnail/CMakeLists.txt 555407d 
>   doc/kioslave/xz/CMakeLists.txt 731d519 
>   filter/bzip.protocol eceae18 
>   filter/bzip2.protocol 3db24ff 
>   filter/gzip.protocol b0fa2b3 
>   filter/lzma.protocol cdaa888 
>   filter/xz.protocol fc66e28 
>   finger/finger.protocol dda641b 
>   fish/fish.protocol fd577c8 
>   floppy/floppy.protocol cbd288a 
>   info/info.protocol c001580 
>   kurifilter-plugins/ikws/CMakeLists.txt 51294b5 
>   kurifilter-plugins/ikws/kuriikwsfilter.upd 0874ce2 
>   man/man.protocol cd03f9f 
>   network/kded/CMakeLists.txt e851f73 
>   network/mimetypes/CMakeLists.txt c20dc90 
>   nfs/nfs.protocol 4781b3c 
>   sftp/sftp.protocol 6e49ed2 
>   smb/smb.protocol e15395e 
>   thumbnail/thumbnail.protocol 216f428 
>   trash/CMakeLists.txt 7c72cdc 
> 
> Diff: https://git.reviewboard.kde.org/r/117859/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel