Review Request 118110: [declarative/core] Use proper GLXFBConfig for glxpixmap
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118110/ --- Review request for Plasma and Martin Klapetek. Bugs: 334241 http://bugs.kde.org/show_bug.cgi?id=334241 Repository: plasma-framework Description --- [declarative/core] Use proper GLXFBConfig for glxpixmap We need to use a GLXFBConfig which matches the depth of the window pixmap's depth. So far it used the GLXFBConfig of the GL context. This worked fine for RGBA windows, but failed for RGB windows on e.g. some NVIDIA drivers. After this change the FBConfig of the context is completely ignored, instead it tries to find a good FBConfig for a given depth. Whenever a FBConfig for a given depth is found it's inserted in a cache shared between all WindowThumbnails so that we don't have the X roundtrips all the time. BUG: 334241 Diffs - src/declarativeimports/core/windowthumbnail.h d3a7b64ad3594006bdcd689984f55290a4ed4576 src/declarativeimports/core/windowthumbnail.cpp c91d1896553f6eecc6828497724d6b119900e40e Diff: https://git.reviewboard.kde.org/r/118110/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Where we are now... (VDG)
On Tuesday 13 May 2014, Andrew Lake wrote: * wallpapers: once they're ready I say put 'em here. We'll need to get them selected and a default chosen before the artwork freeze on May 29th (is that date still right?) yeah, makes sense Not in the Breeze project repo: * plasma theme - ready to ship (probably a few minor fixes before artwork freeze) is in the plasma-framework repo, shipped () * icons - with the actions complete pretty well fleshed out and everything else baselined on Flattr, I'm thinking we're closing in on something very much shippable. ok, ping us when they are ready, they'll end up there too probably If it's not already done, we still need to disable the oxygen background gradient since, far as I can tell, that's still our default window decoration and widget style for the first release. one thing is that in the first release most of the applications will be kde4 (probably even dolphin) so having a different oxygen theme in kde4 and kf5 apps won't help much i think -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Where we are now... (VDG)
On Tuesday 13 May 2014 09:37:20 Marco Martin wrote: Not in the Breeze project repo: * plasma theme - ready to ship (probably a few minor fixes before artwork freeze) is in the plasma-framework repo, shipped () Shouldn't the plasma theme go into the breeze repo at some point, too, so everything artwork-related is in the same repo? * icons - with the actions complete pretty well fleshed out and everything else baselined on Flattr, I'm thinking we're closing in on something very much shippable. ok, ping us when they are ready, they'll end up there too probably If it's not already done, we still need to disable the oxygen background gradient since, far as I can tell, that's still our default window decoration and widget style for the first release. one thing is that in the first release most of the applications will be kde4 (probably even dolphin) so having a different oxygen theme in kde4 and kf5 apps won't help much i think As far as I know, the idea was to apply the Breeze color scheme and remove the gradient from the next release of Oxygen (or create a new widget style which is basically just Oxygen sans the gradient and choose that as default) so that applications using it (both generation 4 and 5) would fit into the overall design direction better. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Where we are now... (VDG)
On Tuesday 13 May 2014, Thomas Pfeiffer wrote: On Tuesday 13 May 2014 09:37:20 Marco Martin wrote: Not in the Breeze project repo: * plasma theme - ready to ship (probably a few minor fixes before artwork freeze) is in the plasma-framework repo, shipped () Shouldn't the plasma theme go into the breeze repo at some point, too, so everything artwork-related is in the same repo? no, the framework repo needs at least one theme, the one with pluginname default since needs it in order to work and can't depend from an artwork repo for sure. one thing is that in the first release most of the applications will be kde4 (probably even dolphin) so having a different oxygen theme in kde4 and kf5 apps won't help much i think As far as I know, the idea was to apply the Breeze color scheme and remove the gradient from the next release of Oxygen (or create a new widget style which is basically just Oxygen sans the gradient and choose that as default) so that applications using it (both generation 4 and 5) would fit into the overall design direction better. if that's done also in the next 4.x release, that's fine -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116024: Port IconItem to native QSGTexture
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/ --- (Updated May 13, 2014, 10:50 a.m.) Review request for Plasma. Changes --- Updated Repository: plasma-framework Description --- Port IconItem to native QSGTexture including the animation. This will save constantly uploading a new texture to OpenGL throughout the animation. Diffs (updated) - .reviewboardrc 804529c CMakeLists.txt a726c75 src/declarativeimports/core/CMakeLists.txt 9b3313d src/declarativeimports/core/fadingnode.cpp PRE-CREATION src/declarativeimports/core/fadingnode_p.h PRE-CREATION src/declarativeimports/core/iconitem.h 92a5233 src/declarativeimports/core/iconitem.cpp 9cb487c Diff: https://git.reviewboard.kde.org/r/116024/diff/ Testing --- Test app: http://paste.kde.org/pl5pwdnel Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118061: Plasma-mobile: Add an initial shell package
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118061/#review57860 --- Ship it! Ship It! - Marco Martin On May 10, 2014, 4:25 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118061/ --- (Updated May 10, 2014, 4:25 p.m.) Review request for Plasma. Repository: plasma-mobile Description --- Add a copy of desktop shell package but remove the stuff that we don't need. Like the contextmenu, panelconfiguration and the toolbox Diffs - CMakeLists.txt c7e3797 activeshellpackage/CMakeLists.txt PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityBrowser.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityCreationDialog.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityDeletionDialog.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityItem.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityList.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityManager.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ControlButton.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/Heading.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/StoppedActivityItem.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/WindowPreview.qml PRE-CREATION activeshellpackage/package/contents/applet/AppletError.qml PRE-CREATION activeshellpackage/package/contents/applet/CompactApplet.qml PRE-CREATION activeshellpackage/package/contents/applet/DefaultCompactRepresentation.qml PRE-CREATION activeshellpackage/package/contents/configuration/AppletConfiguration.qml PRE-CREATION activeshellpackage/package/contents/configuration/ConfigCategoryDelegate.qml PRE-CREATION activeshellpackage/package/contents/configuration/ConfigurationContainmentActions.qml PRE-CREATION activeshellpackage/package/contents/configuration/ConfigurationContainmentAppearance.qml PRE-CREATION activeshellpackage/package/contents/configuration/ConfigurationShortcuts.qml PRE-CREATION activeshellpackage/package/contents/configuration/ContainmentConfiguration.qml PRE-CREATION activeshellpackage/package/contents/configuration/MouseEventInputButton.qml PRE-CREATION activeshellpackage/package/contents/defaults PRE-CREATION activeshellpackage/package/contents/explorer/AppletDelegate.qml PRE-CREATION activeshellpackage/package/contents/explorer/Tooltip.qml PRE-CREATION activeshellpackage/package/contents/explorer/WidgetExplorer.qml PRE-CREATION activeshellpackage/package/contents/layout.js PRE-CREATION activeshellpackage/package/contents/loader.qml PRE-CREATION activeshellpackage/package/contents/views/Desktop.qml PRE-CREATION activeshellpackage/package/contents/views/Panel.qml PRE-CREATION activeshellpackage/package/metadata.desktop PRE-CREATION qmlpackages/CMakeLists.txt d277441 Diff: https://git.reviewboard.kde.org/r/118061/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118061: Plasma-mobile: Add an initial shell package
On May 10, 2014, 12:15 a.m., Aleix Pol Gonzalez wrote: Wouldn't it be better to let the Desktop settle down a bit before we start to fork things out? Actually we should find ways to share code and not having to actually fork these, which is really counter-productive. Marco Martin wrote: That's the whole point of having shell packages. One thing that may be improved in the future is introducing a fallback mechanism between packages to not have to copy all, but i'm quite on the fence to that, and i wouldn't do it if not after it has to be provn really, really necessary. And without attempts now I'll never really know for sure what is missing in the whole mechanism. Furthermore, the gsoc on active is *now* and not in a few months time, the mediacenter gscoc is *now* and not in a few months time. Aleix Pol Gonzalez wrote: Well, we already have a buggy fork in plasmate. I've seen problems that I've fixed to plasma-shell appearing over there. I don't see why Active is going to be different. Aleix Pol Gonzalez wrote: FWIW, we don't need to inherit from different shells, we can actually share code through QML components too. Bhushan Shah wrote: Well, I think both plasmate and active/mediacenter cases are totally different.. Plasmoidviewer shares similar code with desktop shell but I don't think active/mediacenter/any other shell will share code with the desktop. Aleix Pol Gonzalez wrote: Alright, then maybe I'm being overprotective. I understand plasmoidviewer is a special case (although I believe it shouldn't be forking plasma-shell code). Either way, if this is the way it's going to be it would be good to remind how important it is to share code. As for the review, consider my comment discarded. yep, that's true, it's very important, and thanks for reminding :) anyways, if sharing is done, i would prefer inheritance instead of components - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118061/#review57664 --- On May 10, 2014, 4:25 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118061/ --- (Updated May 10, 2014, 4:25 p.m.) Review request for Plasma. Repository: plasma-mobile Description --- Add a copy of desktop shell package but remove the stuff that we don't need. Like the contextmenu, panelconfiguration and the toolbox Diffs - CMakeLists.txt c7e3797 activeshellpackage/CMakeLists.txt PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityBrowser.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityCreationDialog.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityDeletionDialog.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityItem.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityList.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityManager.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ControlButton.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/Heading.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/StoppedActivityItem.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/WindowPreview.qml PRE-CREATION activeshellpackage/package/contents/applet/AppletError.qml PRE-CREATION activeshellpackage/package/contents/applet/CompactApplet.qml PRE-CREATION activeshellpackage/package/contents/applet/DefaultCompactRepresentation.qml PRE-CREATION activeshellpackage/package/contents/configuration/AppletConfiguration.qml PRE-CREATION activeshellpackage/package/contents/configuration/ConfigCategoryDelegate.qml PRE-CREATION activeshellpackage/package/contents/configuration/ConfigurationContainmentActions.qml PRE-CREATION activeshellpackage/package/contents/configuration/ConfigurationContainmentAppearance.qml PRE-CREATION activeshellpackage/package/contents/configuration/ConfigurationShortcuts.qml PRE-CREATION activeshellpackage/package/contents/configuration/ContainmentConfiguration.qml PRE-CREATION activeshellpackage/package/contents/configuration/MouseEventInputButton.qml PRE-CREATION activeshellpackage/package/contents/defaults PRE-CREATION activeshellpackage/package/contents/explorer/AppletDelegate.qml PRE-CREATION activeshellpackage/package/contents/explorer/Tooltip.qml PRE-CREATION
Re: Review Request 118061: Plasma-mobile: Add an initial shell package
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118061/#review57863 --- This review has been submitted with commit b08e4f0c2bb8d30616e37774ed5e873f91e2172b by Antonis Tsiapaliokas to branch frameworks. - Commit Hook On May 10, 2014, 4:25 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118061/ --- (Updated May 10, 2014, 4:25 p.m.) Review request for Plasma. Repository: plasma-mobile Description --- Add a copy of desktop shell package but remove the stuff that we don't need. Like the contextmenu, panelconfiguration and the toolbox Diffs - CMakeLists.txt c7e3797 activeshellpackage/CMakeLists.txt PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityBrowser.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityCreationDialog.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityDeletionDialog.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityItem.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityList.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityManager.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ControlButton.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/Heading.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/StoppedActivityItem.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/WindowPreview.qml PRE-CREATION activeshellpackage/package/contents/applet/AppletError.qml PRE-CREATION activeshellpackage/package/contents/applet/CompactApplet.qml PRE-CREATION activeshellpackage/package/contents/applet/DefaultCompactRepresentation.qml PRE-CREATION activeshellpackage/package/contents/configuration/AppletConfiguration.qml PRE-CREATION activeshellpackage/package/contents/configuration/ConfigCategoryDelegate.qml PRE-CREATION activeshellpackage/package/contents/configuration/ConfigurationContainmentActions.qml PRE-CREATION activeshellpackage/package/contents/configuration/ConfigurationContainmentAppearance.qml PRE-CREATION activeshellpackage/package/contents/configuration/ConfigurationShortcuts.qml PRE-CREATION activeshellpackage/package/contents/configuration/ContainmentConfiguration.qml PRE-CREATION activeshellpackage/package/contents/configuration/MouseEventInputButton.qml PRE-CREATION activeshellpackage/package/contents/defaults PRE-CREATION activeshellpackage/package/contents/explorer/AppletDelegate.qml PRE-CREATION activeshellpackage/package/contents/explorer/Tooltip.qml PRE-CREATION activeshellpackage/package/contents/explorer/WidgetExplorer.qml PRE-CREATION activeshellpackage/package/contents/layout.js PRE-CREATION activeshellpackage/package/contents/loader.qml PRE-CREATION activeshellpackage/package/contents/views/Desktop.qml PRE-CREATION activeshellpackage/package/contents/views/Panel.qml PRE-CREATION activeshellpackage/package/metadata.desktop PRE-CREATION qmlpackages/CMakeLists.txt d277441 Diff: https://git.reviewboard.kde.org/r/118061/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118061: Plasma-mobile: Add an initial shell package
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118061/ --- (Updated May 13, 2014, 10:55 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-mobile Description --- Add a copy of desktop shell package but remove the stuff that we don't need. Like the contextmenu, panelconfiguration and the toolbox Diffs - CMakeLists.txt c7e3797 activeshellpackage/CMakeLists.txt PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityBrowser.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityCreationDialog.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityDeletionDialog.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityItem.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityList.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ActivityManager.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/ControlButton.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/Heading.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/StoppedActivityItem.qml PRE-CREATION activeshellpackage/package/contents/activitymanager/WindowPreview.qml PRE-CREATION activeshellpackage/package/contents/applet/AppletError.qml PRE-CREATION activeshellpackage/package/contents/applet/CompactApplet.qml PRE-CREATION activeshellpackage/package/contents/applet/DefaultCompactRepresentation.qml PRE-CREATION activeshellpackage/package/contents/configuration/AppletConfiguration.qml PRE-CREATION activeshellpackage/package/contents/configuration/ConfigCategoryDelegate.qml PRE-CREATION activeshellpackage/package/contents/configuration/ConfigurationContainmentActions.qml PRE-CREATION activeshellpackage/package/contents/configuration/ConfigurationContainmentAppearance.qml PRE-CREATION activeshellpackage/package/contents/configuration/ConfigurationShortcuts.qml PRE-CREATION activeshellpackage/package/contents/configuration/ContainmentConfiguration.qml PRE-CREATION activeshellpackage/package/contents/configuration/MouseEventInputButton.qml PRE-CREATION activeshellpackage/package/contents/defaults PRE-CREATION activeshellpackage/package/contents/explorer/AppletDelegate.qml PRE-CREATION activeshellpackage/package/contents/explorer/Tooltip.qml PRE-CREATION activeshellpackage/package/contents/explorer/WidgetExplorer.qml PRE-CREATION activeshellpackage/package/contents/layout.js PRE-CREATION activeshellpackage/package/contents/loader.qml PRE-CREATION activeshellpackage/package/contents/views/Desktop.qml PRE-CREATION activeshellpackage/package/contents/views/Panel.qml PRE-CREATION activeshellpackage/package/metadata.desktop PRE-CREATION qmlpackages/CMakeLists.txt d277441 Diff: https://git.reviewboard.kde.org/r/118061/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Where we are now... (VDG)
On Tuesday 13 May 2014 12:31:11 Marco Martin wrote: no, the framework repo needs at least one theme, the one with pluginname default since needs it in order to work and can't depend from an artwork repo for sure. Okay, now I got it, it's about the framework which can be used outside the workspace. one thing is that in the first release most of the applications will be kde4 (probably even dolphin) so having a different oxygen theme in kde4 and kf5 apps won't help much i think As far as I know, the idea was to apply the Breeze color scheme and remove the gradient from the next release of Oxygen (or create a new widget style which is basically just Oxygen sans the gradient and choose that as default) so that applications using it (both generation 4 and 5) would fit into the overall design direction better. if that's done also in the next 4.x release, that's fine Which part of the 4.x release exactly do you mean? Applications don't decide for themselves which widget theme they use, do they? So people who use 4.14 with Plasma Workspaces 4.11 can still use Oxygen with the gradient and the default Oxygen color theme, whereas people who use Plasma Next with 4.14 applications can use the Breeze color theme plus Oxygen sans gradient for the same applications, can't they? That way everything, including applications, would look new when run in Plasma Next compared to Plasma 4.11. Or am I missing some technological restriction here? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116024: Port IconItem to native QSGTexture
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/ --- (Updated May 13, 2014, 11:09 a.m.) Review request for Plasma. Repository: plasma-framework Description --- Port IconItem to native QSGTexture including the animation. This will save constantly uploading a new texture to OpenGL throughout the animation. Diffs - .reviewboardrc 804529c CMakeLists.txt a726c75 src/declarativeimports/core/CMakeLists.txt 9b3313d src/declarativeimports/core/fadingnode.cpp PRE-CREATION src/declarativeimports/core/fadingnode_p.h PRE-CREATION src/declarativeimports/core/iconitem.h 92a5233 src/declarativeimports/core/iconitem.cpp 9cb487c Diff: https://git.reviewboard.kde.org/r/116024/diff/ Testing (updated) --- Test app: http://paste.kde.org/pl5pwdnel Test app shows for lots of icons a decrease from 40 - 27Mb apitrace has a lot fewer calls to glTexImage2D Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118110: [declarative/core] Use proper GLXFBConfig for glxpixmap
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118110/#review57865 --- YES! I HAZ THUMBNAILS! ...confirming this works on my machine with binary nvidia, where it was broken before. Good job! Testing it for a while shows one artifact tho -- http://i.imgur.com/eoUJcez.png -- happens mostly randomly; not sure where the bug of this lies however. - Martin Klapetek On May 13, 2014, 9:02 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118110/ --- (Updated May 13, 2014, 9:02 a.m.) Review request for Plasma and Martin Klapetek. Bugs: 334241 http://bugs.kde.org/show_bug.cgi?id=334241 Repository: plasma-framework Description --- [declarative/core] Use proper GLXFBConfig for glxpixmap We need to use a GLXFBConfig which matches the depth of the window pixmap's depth. So far it used the GLXFBConfig of the GL context. This worked fine for RGBA windows, but failed for RGB windows on e.g. some NVIDIA drivers. After this change the FBConfig of the context is completely ignored, instead it tries to find a good FBConfig for a given depth. Whenever a FBConfig for a given depth is found it's inserted in a cache shared between all WindowThumbnails so that we don't have the X roundtrips all the time. BUG: 334241 Diffs - src/declarativeimports/core/windowthumbnail.h d3a7b64ad3594006bdcd689984f55290a4ed4576 src/declarativeimports/core/windowthumbnail.cpp c91d1896553f6eecc6828497724d6b119900e40e Diff: https://git.reviewboard.kde.org/r/118110/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118110: [declarative/core] Use proper GLXFBConfig for glxpixmap
On May 13, 2014, 1:13 p.m., Martin Klapetek wrote: YES! I HAZ THUMBNAILS! ...confirming this works on my machine with binary nvidia, where it was broken before. Good job! Testing it for a while shows one artifact tho -- http://i.imgur.com/eoUJcez.png -- happens mostly randomly; not sure where the bug of this lies however. Interesting, observe Kate's icon -- http://i.imgur.com/T1OPzoG.png -- it's actually the KTp contact list thumnbail... o_O - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118110/#review57865 --- On May 13, 2014, 9:02 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118110/ --- (Updated May 13, 2014, 9:02 a.m.) Review request for Plasma and Martin Klapetek. Bugs: 334241 http://bugs.kde.org/show_bug.cgi?id=334241 Repository: plasma-framework Description --- [declarative/core] Use proper GLXFBConfig for glxpixmap We need to use a GLXFBConfig which matches the depth of the window pixmap's depth. So far it used the GLXFBConfig of the GL context. This worked fine for RGBA windows, but failed for RGB windows on e.g. some NVIDIA drivers. After this change the FBConfig of the context is completely ignored, instead it tries to find a good FBConfig for a given depth. Whenever a FBConfig for a given depth is found it's inserted in a cache shared between all WindowThumbnails so that we don't have the X roundtrips all the time. BUG: 334241 Diffs - src/declarativeimports/core/windowthumbnail.h d3a7b64ad3594006bdcd689984f55290a4ed4576 src/declarativeimports/core/windowthumbnail.cpp c91d1896553f6eecc6828497724d6b119900e40e Diff: https://git.reviewboard.kde.org/r/118110/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Where we are now... (VDG)
On Tuesday 13 May 2014, Thomas Pfeiffer wrote: Which part of the 4.x release exactly do you mean? Applications don't decide for themselves which widget theme they use, do they? So people who use 4.14 with Plasma Workspaces 4.11 can still use i mean updating oxygen for the next release to not use the gradient anymore and use the new colors -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Where we are now... (VDG)
On Tuesday 13 May 2014 13:16:18 Marco Martin wrote: On Tuesday 13 May 2014, Thomas Pfeiffer wrote: Which part of the 4.x release exactly do you mean? Applications don't decide for themselves which widget theme they use, do they? So people who use 4.14 with Plasma Workspaces 4.11 can still use i mean updating oxygen for the next release to not use the gradient anymore and use the new colors Yes, we could either do that or fork Oxygen and ship the fork plus Breeze color scheme only with Plasma Next, right? Personally, I'd prefer the latter, because then we'd have more of a visual distinction between Plasma Next and Plasma 4.x, even though the applications are actually the same. I'd like to hear Jens' and Andrew's opinions on that, too though. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118110: [declarative/core] Use proper GLXFBConfig for glxpixmap
On May 13, 2014, 1:13 p.m., Martin Klapetek wrote: YES! I HAZ THUMBNAILS! ...confirming this works on my machine with binary nvidia, where it was broken before. Good job! Testing it for a while shows one artifact tho -- http://i.imgur.com/eoUJcez.png -- happens mostly randomly; not sure where the bug of this lies however. Martin Klapetek wrote: Interesting, observe Kate's icon -- http://i.imgur.com/T1OPzoG.png -- it's actually the KTp contact list thumnbail... o_O ok that looks broken :-( It might be unrelated to the change, but it's clearly broken. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118110/#review57865 --- On May 13, 2014, 9:02 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118110/ --- (Updated May 13, 2014, 9:02 a.m.) Review request for Plasma and Martin Klapetek. Bugs: 334241 http://bugs.kde.org/show_bug.cgi?id=334241 Repository: plasma-framework Description --- [declarative/core] Use proper GLXFBConfig for glxpixmap We need to use a GLXFBConfig which matches the depth of the window pixmap's depth. So far it used the GLXFBConfig of the GL context. This worked fine for RGBA windows, but failed for RGB windows on e.g. some NVIDIA drivers. After this change the FBConfig of the context is completely ignored, instead it tries to find a good FBConfig for a given depth. Whenever a FBConfig for a given depth is found it's inserted in a cache shared between all WindowThumbnails so that we don't have the X roundtrips all the time. BUG: 334241 Diffs - src/declarativeimports/core/windowthumbnail.h d3a7b64ad3594006bdcd689984f55290a4ed4576 src/declarativeimports/core/windowthumbnail.cpp c91d1896553f6eecc6828497724d6b119900e40e Diff: https://git.reviewboard.kde.org/r/118110/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Where we are now... (VDG)
On Tuesday, May 13, 2014 12:25:57 Thomas Pfeiffer wrote: As far as I know, the idea was to apply the Breeze color scheme and remove the gradient from the next release of Oxygen I tried that last week, and it looked really underwhelming. We *can* remove gradient and adjust color scheme, but at that point, it becomes clear that our artwork is half-assed, in Oxygen, the Breeze color scheme lacks depth and contrast. Try it for yourself. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Where we are now... (VDG)
I tried that last week, and it looked really underwhelming. We *can* remove gradient and adjust color scheme, but at that point, it becomes clear that our artwork is half-assed, in Oxygen, the Breeze color scheme lacks depth and contrast. Try it for yourself. I have tried it and have to agree. The colour scheme does not suit oxygen at all. Cheers -- Make your code readable. Pretend the next person who looks at your code is a psychopath and they know where you live. -- Philip Wadler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Bug: Battery widget only showing one battery out of two after resume from standby
Hello, I am running KDE 4.11.x on an Lenovo Thinkpad T440s with two batteries. The KDE battery widget works fine after the initial boot and shows the correct values for both batteries. But after a standby and resume cycle, in about 25% of the time, the battery widget is missing to display one battery (currently BAT0 is missing). This is the output of upower -d after resume: --- brauchle@mo-brauchle:~ upower -d Device: /org/freedesktop/UPower/devices/line_power_AC native-path: AC power supply: yes updated: Tue 13 May 2014 10:14:56 AM CEST (120 seconds ago) has history: no has statistics: no line-power online: yes Device: /org/freedesktop/UPower/devices/battery_BAT1 native-path: BAT1 vendor: LGC model:45N1127 serial: 4696 power supply: yes updated: Tue 13 May 2014 10:16:30 AM CEST (26 seconds ago) has history: yes has statistics: yes battery present: yes rechargeable:yes state: charging energy: 2.11 Wh energy-empty:0 Wh energy-full: 23.68 Wh energy-full-design: 23.48 Wh energy-rate: 23.224 W voltage: 11.947 V time to full:55.7 minutes percentage: 8% capacity:100% technology: lithium-ion History (charge): 1399968990 8.000 charging 1399968960 7.000 charging 1399968930 6.000 charging History (rate): 1399968990 23.224 charging 1399968960 19.680 charging 1399968930 27.635 charging Device: /org/freedesktop/UPower/devices/battery_BAT0 native-path: BAT0 vendor: SONY model:45N serial: 12294 power supply: yes updated: Tue 13 May 2014 10:16:30 AM CEST (26 seconds ago) has history: yes has statistics: yes battery present: yes rechargeable:yes state: charging energy: 18.26 Wh energy-empty:0 Wh energy-full: 22.97 Wh energy-full-design: 23.2 Wh energy-rate: 0 W voltage: 12.002 V percentage: 79% capacity:99.0086% technology: lithium-polymer Daemon: daemon-version: 0.9.23 can-suspend: yes can-hibernate: yes on-battery: no on-low-battery: no lid-is-closed: no lid-is-present: yes is-docked: no --- Both batteries are displayed there, but the battery widget only shows one (BAT1) battery installed and charging. Best regards, Joschi Brauchle smime.p7s Description: S/MIME Cryptographic Signature ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Where we are now... (VDG)
On Tuesday 13 May 2014 13:44:12 Sebastian Kügler wrote: On Tuesday, May 13, 2014 12:25:57 Thomas Pfeiffer wrote: As far as I know, the idea was to apply the Breeze color scheme and remove the gradient from the next release of Oxygen I tried that last week, and it looked really underwhelming. We *can* remove gradient and adjust color scheme, but at that point, it becomes clear that our artwork is half-assed, in Oxygen, the Breeze color scheme lacks depth and contrast. Try it for yourself. The idea came from Andrew and tbh I haven't tried it yet. How does one remove the gradient? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Where we are now... (VDG)
* icons - with the actions complete pretty well fleshed out and everything else baselined on Flattr, I'm thinking we're closing in on something very much shippable. ok, ping us when they are ready, they'll end up there too probably I know I'll get slapped for this, but (regardless of the theme, and maybe a little bit off-topic) I wanted to raise a question regarding icon theme configurability. The thing that I've found quite problematic with oxygen are the toolbar (action) icons. I never had much problems with most application icons, devices and such. I was thinking of something like separate icon sets for toolbars and other parts - just like we have the plasma icons separate which was a little bit hackish. This would also help changing the action icons for the dark colour schemes without the need to change the main icon theme. Thoughts? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Bug: Battery widget only showing one battery out of two after resume from standby
Hi Joschi, On Tuesday, May 13, 2014 10:21:59 Joschi Brauchle wrote: I am running KDE 4.11.x on an Lenovo Thinkpad T440s with two batteries. The KDE battery widget works fine after the initial boot and shows the correct values for both batteries. But after a standby and resume cycle, in about 25% of the time, the battery widget is missing to display one battery (currently BAT0 is missing). Could you file this bug on http://bugs.kde.org? Tracking problems like this on the mailinglist doesn't really work, having the bug recorded in bugzilla means we can properly take care of it. Thanks, -- sebas This is the output of upower -d after resume: --- brauchle@mo-brauchle:~ upower -d Device: /org/freedesktop/UPower/devices/line_power_AC native-path: AC power supply: yes updated: Tue 13 May 2014 10:14:56 AM CEST (120 seconds ago) has history: no has statistics: no line-power online: yes Device: /org/freedesktop/UPower/devices/battery_BAT1 native-path: BAT1 vendor: LGC model:45N1127 serial: 4696 power supply: yes updated: Tue 13 May 2014 10:16:30 AM CEST (26 seconds ago) has history: yes has statistics: yes battery present: yes rechargeable:yes state: charging energy: 2.11 Wh energy-empty:0 Wh energy-full: 23.68 Wh energy-full-design: 23.48 Wh energy-rate: 23.224 W voltage: 11.947 V time to full:55.7 minutes percentage: 8% capacity:100% technology: lithium-ion History (charge): 1399968990 8.000 charging 1399968960 7.000 charging 1399968930 6.000 charging History (rate): 1399968990 23.224 charging 1399968960 19.680 charging 1399968930 27.635 charging Device: /org/freedesktop/UPower/devices/battery_BAT0 native-path: BAT0 vendor: SONY model:45N serial: 12294 power supply: yes updated: Tue 13 May 2014 10:16:30 AM CEST (26 seconds ago) has history: yes has statistics: yes battery present: yes rechargeable:yes state: charging energy: 18.26 Wh energy-empty:0 Wh energy-full: 22.97 Wh energy-full-design: 23.2 Wh energy-rate: 0 W voltage: 12.002 V percentage: 79% capacity:99.0086% technology: lithium-polymer Daemon: daemon-version: 0.9.23 can-suspend: yes can-hibernate: yes on-battery: no on-low-battery: no lid-is-closed: no lid-is-present: yes is-docked: no --- Both batteries are displayed there, but the battery widget only shows one (BAT1) battery installed and charging. Best regards, Joschi Brauchle -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116024: Port IconItem to native QSGTexture
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/#review57872 --- I really like the approach! src/declarativeimports/core/CMakeLists.txt https://git.reviewboard.kde.org/r/116024/#comment40270 why do you link against Qt5::OpenGL and find it? OpenGL is part of Gui src/declarativeimports/core/fadingnode.cpp https://git.reviewboard.kde.org/r/116024/#comment40275 I normally prefix the varying with v_ e.g. varying highp vec2 v_coord src/declarativeimports/core/fadingnode.cpp https://git.reviewboard.kde.org/r/116024/#comment40276 similarily I prefix uniforms with u_ e.g. uniform sampler2D u_src src/declarativeimports/core/fadingnode.cpp https://git.reviewboard.kde.org/r/116024/#comment40271 I'd always activate the GL_TEXTURE0 texture target after setting the texture. You never know what will be called afterwards and it might expect it's GL_TEXTURE0. src/declarativeimports/core/fadingnode.cpp https://git.reviewboard.kde.org/r/116024/#comment40273 any particular reason to explicitly set the true? src/declarativeimports/core/fadingnode.cpp https://git.reviewboard.kde.org/r/116024/#comment40272 QScopedPointer? src/declarativeimports/core/fadingnode.cpp https://git.reviewboard.kde.org/r/116024/#comment40274 empty newlines src/declarativeimports/core/iconitem.h https://git.reviewboard.kde.org/r/116024/#comment40281 why additional new line? src/declarativeimports/core/iconitem.h https://git.reviewboard.kde.org/r/116024/#comment40280 why is it moved around? src/declarativeimports/core/iconitem.cpp https://git.reviewboard.kde.org/r/116024/#comment40282 pedantic: move all the * one to right src/declarativeimports/core/iconitem.cpp https://git.reviewboard.kde.org/r/116024/#comment40277 coding style if( - if ( src/declarativeimports/core/iconitem.cpp https://git.reviewboard.kde.org/r/116024/#comment40279 ? src/declarativeimports/core/iconitem.cpp https://git.reviewboard.kde.org/r/116024/#comment40278 ? - Martin Gräßlin On May 13, 2014, 1:09 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/ --- (Updated May 13, 2014, 1:09 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Port IconItem to native QSGTexture including the animation. This will save constantly uploading a new texture to OpenGL throughout the animation. Diffs - .reviewboardrc 804529c CMakeLists.txt a726c75 src/declarativeimports/core/CMakeLists.txt 9b3313d src/declarativeimports/core/fadingnode.cpp PRE-CREATION src/declarativeimports/core/fadingnode_p.h PRE-CREATION src/declarativeimports/core/iconitem.h 92a5233 src/declarativeimports/core/iconitem.cpp 9cb487c Diff: https://git.reviewboard.kde.org/r/116024/diff/ Testing --- Test app: http://paste.kde.org/pl5pwdnel Test app shows for lots of icons a decrease from 40 - 27Mb apitrace has a lot fewer calls to glTexImage2D Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Where we are now... (VDG)
On May 13, 2014 4:55 AM, Ivan Čukić wrote: I tried that last week, and it looked really underwhelming. We *can* remove gradient and adjust color scheme, but at that point, it becomes clear that our artwork is half-assed, in Oxygen, the Breeze color scheme lacks depth and contrast. Try it for yourself. I have tried it and have to agree. The colour scheme does not suit oxygen at all. Thanks, this is helpful. The main motivation was to make the application and the desktop portions look a little less like they're from different ends of the universe. It seems that specific color scheme didn't accomplish that. I think we can come up with a color scheme better suited to Oxygen (better depth and contrast) and that uses a similar palette to the plasma theme. If we think its worth it I'll do that today. Andrew ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117995: [screenlocker] Add a unit test for KSldApp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117995/#review57877 --- Ship it! Ship It! - David Edmundson On May 9, 2014, 6:26 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117995/ --- (Updated May 9, 2014, 6:26 a.m.) Review request for Plasma and David Edmundson. Repository: plasma-workspace Description --- [screenlocker] Add a unit test for KSldApp The unit test so far only tests establishGrab. This is a little bit tricky as we need a different X Client which grabs pointer or keyboard to make establishGrab fail. For that two small helper applications are included which do nothing else than connecting to X and the one grabbing keyboard the other grabbing pointer. The applications are started from the test to get the keyboard/pointer grabbed which results in ::establishGrab to return false. What this test is not yet able to test is handling the sleep between two grab attemps. As the test is using doUnlock() from KSldApp, the implementation is changed to use xcb for ungrab pointer/keyboard. With XLib the test would have needed an XSync which would have required to either add the XLib call to the test or doUnlock or implement the sync using xcb. REVIEW: 117995 Diffs - ksmserver/screenlocker/autotests/CMakeLists.txt ff95d9d031cdac32085e358e30b95a9e9a6fb7dc ksmserver/screenlocker/autotests/keyboardgrabber.cpp PRE-CREATION ksmserver/screenlocker/autotests/ksldtest.cpp PRE-CREATION ksmserver/screenlocker/autotests/pointergrabber.cpp PRE-CREATION ksmserver/screenlocker/ksldapp.h fafe894ee2068910f2f42584a1f30303036619da ksmserver/screenlocker/ksldapp.cpp 007eb2a7032d3f3210ce6a211ae9b4562dba1508 Diff: https://git.reviewboard.kde.org/r/117995/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[plasma-shell] [Bug 328593] Dual screen has regressed in plasma-shell
https://bugs.kde.org/show_bug.cgi?id=328593 Bug 328593 depends on bug 334502, which changed state. Bug 334502 Summary: Panel positions in multiscreen are not remembered/placed depending on mouse position https://bugs.kde.org/show_bug.cgi?id=334502 What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Where we are now... (VDG)
Sry for being quiet here - I'm fiddling with it (the Breeze-Oxygen color theme) this evening so expect something with screenshots. Also is it possible to our users a massive favour? Scrap the gradient AND the blue highlight (I know I know I've gotten attached to it too and it was actually pretty damn cool and ahead of its time but... well you know) - lets just replace it with something flat and a shadow and call it a day and combined with the new color scheme we can show that its a go between. ALSO just to be sure - we're shipping the Qtquick and Aurorae theme along with oxygen, right but not as defaults? Or are we leaving it to the user to install them themselves? I just want to make certain that they at least have a presence that is available. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116024: Port IconItem to native QSGTexture
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/ --- (Updated May 13, 2014, 3:25 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Port IconItem to native QSGTexture including the animation. This will save constantly uploading a new texture to OpenGL throughout the animation. Diffs (updated) - .reviewboardrc 804529c src/declarativeimports/core/CMakeLists.txt 9b3313d src/declarativeimports/core/fadingnode.cpp PRE-CREATION src/declarativeimports/core/fadingnode_p.h PRE-CREATION src/declarativeimports/core/iconitem.h 92a5233 src/declarativeimports/core/iconitem.cpp 9cb487c Diff: https://git.reviewboard.kde.org/r/116024/diff/ Testing --- Test app: http://paste.kde.org/pl5pwdnel Test app shows for lots of icons a decrease from 40 - 27Mb apitrace has a lot fewer calls to glTexImage2D Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116024: Port IconItem to native QSGTexture
On May 13, 2014, 12:47 p.m., Martin Gräßlin wrote: src/declarativeimports/core/CMakeLists.txt, line 39 https://git.reviewboard.kde.org/r/116024/diff/4/?file=272717#file272717line39 why do you link against Qt5::OpenGL and find it? OpenGL is part of Gui For anyone else who gets this problem: QGlContext needs porting to QOpenGLContext which is in Gui. Then you don't need to link OpenGL directly On May 13, 2014, 12:47 p.m., Martin Gräßlin wrote: src/declarativeimports/core/fadingnode.cpp, lines 84-92 https://git.reviewboard.kde.org/r/116024/diff/4/?file=272718#file272718line84 I'd always activate the GL_TEXTURE0 texture target after setting the texture. You never know what will be called afterwards and it might expect it's GL_TEXTURE0. I'm confused. I need to set the active texture /before/ I bind to it. Otherwise everything breaks. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/#review57872 --- On May 13, 2014, 3:25 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/ --- (Updated May 13, 2014, 3:25 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Port IconItem to native QSGTexture including the animation. This will save constantly uploading a new texture to OpenGL throughout the animation. Diffs - .reviewboardrc 804529c src/declarativeimports/core/CMakeLists.txt 9b3313d src/declarativeimports/core/fadingnode.cpp PRE-CREATION src/declarativeimports/core/fadingnode_p.h PRE-CREATION src/declarativeimports/core/iconitem.h 92a5233 src/declarativeimports/core/iconitem.cpp 9cb487c Diff: https://git.reviewboard.kde.org/r/116024/diff/ Testing --- Test app: http://paste.kde.org/pl5pwdnel Test app shows for lots of icons a decrease from 40 - 27Mb apitrace has a lot fewer calls to glTexImage2D Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116024: Port IconItem to native QSGTexture
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/#review57887 --- looks good. I'll give it a run tomorrow in a real setup. src/declarativeimports/core/fadingnode.cpp https://git.reviewboard.kde.org/r/116024/#comment40286 double ;; - Martin Gräßlin On May 13, 2014, 5:25 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/ --- (Updated May 13, 2014, 5:25 p.m.) Review request for Plasma. Repository: plasma-framework Description --- Port IconItem to native QSGTexture including the animation. This will save constantly uploading a new texture to OpenGL throughout the animation. Diffs - .reviewboardrc 804529c src/declarativeimports/core/CMakeLists.txt 9b3313d src/declarativeimports/core/fadingnode.cpp PRE-CREATION src/declarativeimports/core/fadingnode_p.h PRE-CREATION src/declarativeimports/core/iconitem.h 92a5233 src/declarativeimports/core/iconitem.cpp 9cb487c Diff: https://git.reviewboard.kde.org/r/116024/diff/ Testing --- Test app: http://paste.kde.org/pl5pwdnel Test app shows for lots of icons a decrease from 40 - 27Mb apitrace has a lot fewer calls to glTexImage2D Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118119: remove unneeded header
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118119/ --- Review request for KDE Frameworks, kdewin and Plasma. Repository: plasma-framework Description --- remove unneeded header Diffs - src/plasma/theme.cpp aed5b98609d8502f05ca8b8404d92efd4eedf8d4 Diff: https://git.reviewboard.kde.org/r/118119/diff/ Testing --- mingw windows Thanks, Patrick Spendrin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118119: remove unneeded header
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118119/#review57898 --- Ship it! Ship It! - David Edmundson On May 13, 2014, 10:35 p.m., Patrick Spendrin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118119/ --- (Updated May 13, 2014, 10:35 p.m.) Review request for KDE Frameworks, kdewin and Plasma. Repository: plasma-framework Description --- remove unneeded header Diffs - src/plasma/theme.cpp aed5b98609d8502f05ca8b8404d92efd4eedf8d4 Diff: https://git.reviewboard.kde.org/r/118119/diff/ Testing --- mingw windows Thanks, Patrick Spendrin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build failed in Jenkins: plasma-desktop_master_qt5 #172
See http://build.kde.org/job/plasma-desktop_master_qt5/172/changes Changes: [sebas] Improve margins in kickoffitem -- [...truncated 2102 lines...] http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:756:88: warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations] http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:761:101: warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations] KonqOperations *KonqOperations::renameV2( QWidget * parent, const KUrl oldurl, const KUrl newurl ) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:761:101: warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations] http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp: In static member function ‘static KonqOperations* KonqOperations::renameV2(QWidget*, const KUrl, const KUrl)’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:763:34: warning: ‘QDebug operator(QDebug, const QUrl)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kdebug.h:257) [-Wdeprecated-declarations] kDebug(1203) oldurl= oldurl newurl= newurl; ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:763:58: warning: ‘QDebug operator(QDebug, const QUrl)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kdebug.h:257) [-Wdeprecated-declarations] kDebug(1203) oldurl= oldurl newurl= newurl; ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:767:16: warning: ‘List’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:143) [-Wdeprecated-declarations] KUrl::List lst; ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:774:111: warning: ‘static QString KGlobalSettings::desktopPath()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kglobalsettings.h:199) [-Wdeprecated-declarations] if ( oldurl.isLocalFile() oldurl.toLocalFile( KUrl::AddTrailingSlash ) == KGlobalSettings::desktopPath() ) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:778:45: warning: ‘KStandardDirs* KGlobal::dirs()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kglobal.h:375) [-Wdeprecated-declarations] const QString userDirsFile(KGlobal::dirs()-localxdgconfdir() + QLatin1String(user-dirs.dirs)); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:778:50: warning: ‘KStandardDirs* KGlobal::dirs()’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kglobal.h:375) [-Wdeprecated-declarations] const QString userDirsFile(KGlobal::dirs()-localxdgconfdir() + QLatin1String(user-dirs.dirs)); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:778:69: warning: ‘QString KStandardDirs::localxdgconfdir() const’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kstandarddirs.h:723) [-Wdeprecated-declarations] const QString userDirsFile(KGlobal::dirs()-localxdgconfdir() + QLatin1String(user-dirs.dirs)); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:782:110: warning: ‘static void KGlobalSettings::emitChange(KGlobalSettings::ChangeType, int)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kglobalsettings.h:559) [-Wdeprecated-declarations]
Build failed in Jenkins: plasma-desktop_master_qt5 #173
See http://build.kde.org/job/plasma-desktop_master_qt5/173/changes Changes: [sebas] Fix warning: parent might be undefined here at first [sebas] Fix a bunch of warnings in Kickoff -- [...truncated 2200 lines...] http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:982:21: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] const KUrl url = *m_urlsIterator; ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:984:14: warning: ‘KUrl’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:109) [-Wdeprecated-declarations] KUrl new_url = url; ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:991:26: warning: ‘void KUrl::setPath(const QString)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:459) [-Wdeprecated-declarations] new_url.setPath(path); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp: At global scope: http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:1030:69: warning: ‘KUrl’ is deprecated [-Wdeprecated-declarations] QPairbool, QString KonqOperations::pasteInfo(const KUrl targetUrl) ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp: In static member function ‘static QPairbool, QString KonqOperations::pasteInfo(const KUrl)’: http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:1037:16: warning: ‘List’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:143) [-Wdeprecated-declarations] KUrl::List urls = KUrl::List::fromMimeData(mimeData); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:1037:56: warning: ‘static KUrl::List KUrl::List::fromMimeData(const QMimeData*, KUrl::List::DecodeOptions, KUrl::MetaDataMap*)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:317) [-Wdeprecated-declarations] KUrl::List urls = KUrl::List::fromMimeData(mimeData); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:1040:73: warning: ‘KFileItem::KFileItem(mode_t, mode_t, const QUrl, bool)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kio/inst/include/KF5/KIOCore/kfileitem.h:104) [-Wdeprecated-declarations] KFileItem item(KFileItem::Unknown, KFileItem::Unknown, targetUrl); ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/containments/folder/plugin/internallibkonq/konq_operations.cpp:1044:92: warning: ‘KFileItem::KFileItem(mode_t, mode_t, const QUrl, bool)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kio/inst/include/KF5/KIOCore/kfileitem.h:104) [-Wdeprecated-declarations] const KFileItem item(KFileItem::Unknown, KFileItem::Unknown, urls.first(), true); ^ Building CXX object applets/kickoff/CMakeFiles/kickoffplugin.dir/krunner_interface.cpp.o In file included from http://build.kde.org/job/plasma-desktop_master_qt5/ws/build/containments/folder/moc_konq_copytomenu_p.cpp:9:0, from http://build.kde.org/job/plasma-desktop_master_qt5/ws/build/containments/folder/folderplugin_automoc.cpp:4: http://build.kde.org/job/plasma-desktop_master_qt5/ws/build/containments/folder/../../../containments/folder/plugin/internallibkonq/konq_copytomenu_p.h:33:16: warning: ‘List’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kurl.h:143) [-Wdeprecated-declarations] KUrl::List m_urls; ^ http://build.kde.org/job/plasma-desktop_master_qt5/ws/build/containments/folder/../../../containments/folder/plugin/internallibkonq/konq_copytomenu_p.h:57:39: warning: ‘KUrl’ is deprecated
Build failed in Jenkins: plasma-workspace_master_qt5 #208
See http://build.kde.org/job/plasma-workspace_master_qt5/208/changes Changes: [sebas] Remove hack to update status, works fine now without -- [...truncated 1216 lines...] Generating moc_imageplugin.cpp Generating moc_wallpaperpackage.cpp [ 21%] Built target plasma_wallpaper_imageplugin_automoc [ 21%] Generating moc_taskjob.cpp Generating moc_tasksengine.cpp Generating moc_taskservice.cpp Generating moc_taskwindowjob.cpp Generating moc_taskwindowservice.cpp Generating moc_virtualdesktopssource.cpp Generating moc_backtraceparser.cpp Generating moc_backtraceparsergdb.cpp Generating moc_backtraceparserkdbgwin.cpp Generating moc_backtraceparsernull.cpp Generating ui_launcherproperties.h [ 21%] [ 21%] Generating detachedprocessmonitor.moc http://build.kde.org/job/plasma-workspace_master_qt5/ws/drkonqi/detachedprocessmonitor.cpp:0: Note: No relevant classes found. No output generated. Built target drkonqi_backtrace_parser_automoc Built target plasma_engine_tasks_automoc [ 21%] [ 21%] Generating ui_launcherconfig.h Generating appmenuadaptor.cpp, appmenuadaptor.h Generating deviceactionsdialog.moc http://build.kde.org/job/plasma-workspace_master_qt5/ws/soliduiserver/deviceactionsdialog.cpp:0: Note: No relevant classes found. No output generated. [ 21%] [ 22%] Generating menuimporteradaptor.cpp, menuimporteradaptor.h Generating plasmashelladaptor.cpp, plasmashelladaptor.h [ 22%] Generating moc_backtraceparsertest.cpp Generating moc_fakebacktracegenerator.cpp [ 22%] Scanning dependencies of target kworkspace [ 22%] Generating plasmashelladaptor.moc Built target backtraceparsertest_automoc Generating menuimporteradaptor.moc [ 22%] Generating drkonqibackends.moc http://build.kde.org/job/plasma-workspace_master_qt5/ws/drkonqi/drkonqibackends.cpp:0: Note: No relevant classes found. No output generated. Building CXX object libkworkspace/CMakeFiles/kworkspace.dir/kdisplaymanager.cpp.o [ 22%] Generating appmenuadaptor.moc Generating moc_component.cpp Generating moc_globalshortcutsregistry.cpp Generating kglobalaccel_x11.moc http://build.kde.org/job/plasma-workspace_master_qt5/ws/kglobalaccel/kglobalaccel_x11.cpp:0: Note: No relevant classes found. No output generated. Generating moc_jobview.cpp Generating moc_progresslistdelegate.cpp Generating moc_progresslistmodel.cpp Generating moc_requestviewcallwatcher.cpp Generating moc_uiserver.cpp Generating moc_uiserver_p.cpp [ 22%] Built target kdeinit_kuiserver5_automoc Scanning dependencies of target plasmawidgetexplorerplugin [ 22%] Building CXX object libkworkspace/CMakeFiles/kworkspace.dir/kworkspace.cpp.o Scanning dependencies of target taskmanager [ 22%] Building CXX object shell/widgetexplorer/CMakeFiles/plasmawidgetexplorerplugin.dir/kcategorizeditemsviewmodels.cpp.o Scanning dependencies of target kded_appmenu Generating moc_kglobalacceld.cpp Generating moc_kglobalaccel_x11.cpp [ 22%] Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/abstractgroupableitem.cpp.o [ 22%] [ 22%] Building CXX object appmenu/CMakeFiles/kded_appmenu.dir/appmenu.cpp.o Built target kdeinit_kglobalaccel5_automoc [ 22%] Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/abstractgroupingstrategy.cpp.o Generating deviceserviceaction.moc Generating soliduiserver.moc Generating moc_deviceactionsdialog.cpp Generating moc_soliduiserver.cpp [ 22%] Built target kded_soliduiserver_automoc [ 22%] Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/abstractsortingstrategy.cpp.o Scanning dependencies of target plasmashell [ 23%] Building CXX object shell/CMakeFiles/plasmashell.dir/activity.cpp.o Generating moc_aboutbugreportingdialog.cpp Generating moc_applicationdetailsexamples.cpp Generating moc_backtracegenerator.cpp Generating moc_backtraceratingwidget.cpp Generating moc_backtracewidget.cpp Generating moc_crashedapplication.cpp Generating moc_debuggerlaunchers.cpp Generating moc_debuggermanager.cpp Generating moc_debugpackageinstaller.cpp Generating moc_detachedprocessmonitor.cpp Generating moc_drkonqibackends.cpp Generating moc_drkonqidialog.cpp Generating moc_statuswidget.cpp Generating moc_systeminformation.cpp [ 23%] Built target drkonqi_automoc [ 23%] Building CXX object shell/CMakeFiles/plasmashell.dir/main.cpp.o [ 23%] Building CXX object shell/CMakeFiles/plasmashell.dir/containmentconfigview.cpp.o http://build.kde.org/job/plasma-workspace_master_qt5/ws/appmenu/appmenu.cpp: In destructor ‘virtual AppMenuModule::~AppMenuModule()’: http://build.kde.org/job/plasma-workspace_master_qt5/ws/appmenu/appmenu.cpp:92:16: warning: possible problem detected in invocation of delete operator: [enabled by default] delete m_menubar; ^ http://build.kde.org/job/plasma-workspace_master_qt5/ws/appmenu/appmenu.cpp:92:16: warning: invalid use of incomplete type ‘class TopMenuBar’ [enabled by default] In file included from http://build.kde.org/job/plasma-workspace_master_qt5/ws/appmenu/appmenu.cpp:26:0:
Build failed in Jenkins: plasma-workspace_master_qt5 #209
See http://build.kde.org/job/plasma-workspace_master_qt5/209/changes Changes: [sebas] Disable debug output from systemtray, it's too chatty -- [...truncated 1388 lines...] http://build.kde.org/job/plasma-workspace_master_qt5/ws/shell/containmentconfigview.h:81:37: warning: ‘ContainmentConfigView::m_currentContainmentActionsModel’ will be initialized after [-Wreorder] CurrentContainmentActionsModel *m_currentContainmentActionsModel; ^ http://build.kde.org/job/plasma-workspace_master_qt5/ws/shell/containmentconfigview.h:80:31: warning: ‘PlasmaQuick::ConfigModel* ContainmentConfigView::m_containmentPluginsConfigModel’ [-Wreorder] PlasmaQuick::ConfigModel *m_containmentPluginsConfigModel; ^ http://build.kde.org/job/plasma-workspace_master_qt5/ws/shell/containmentconfigview.cpp:43:1: warning: when initialized here [-Wreorder] ContainmentConfigView::ContainmentConfigView(Plasma::Containment *cont, QWindow *parent) ^ [ 27%] Building CXX object klipper/CMakeFiles/kdeinit_klipper.dir/urlgrabber.cpp.o [ 27%] Building CXX object shell/CMakeFiles/plasmashell.dir/currentcontainmentactionsmodel.cpp.o [ 27%] Building CXX object shell/CMakeFiles/plasmashell.dir/desktopview.cpp.o [ 27%] Building CXX object shell/CMakeFiles/plasmashell.dir/kidenticongenerator.cpp.o http://build.kde.org/job/plasma-workspace_master_qt5/ws/appmenu/menuimporter.cpp: In member function ‘WId MenuImporter::recursiveMenuId(WId)’: http://build.kde.org/job/plasma-workspace_master_qt5/ws/appmenu/menuimporter.cpp:112:45: warning: ‘static WId KWindowSystem::transientFor(WId)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kwindowsystem/inst/include/KF5/KWindowSystem/kwindowsystem.h:238) [-Wdeprecated-declarations] WId tid = KWindowSystem::transientFor(id); ^ http://build.kde.org/job/plasma-workspace_master_qt5/ws/appmenu/menuimporter.cpp:118:46: warning: ‘static WId KWindowSystem::transientFor(WId)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kwindowsystem/inst/include/KF5/KWindowSystem/kwindowsystem.h:238) [-Wdeprecated-declarations] tid = KWindowSystem::transientFor(tid); ^ [ 27%] Building CXX object libkworkspace/CMakeFiles/kworkspace.dir/kworkspace_automoc.cpp.o [ 27%] Building CXX object freespacenotifier/CMakeFiles/kded_freespacenotifier.dir/settings.cpp.o http://build.kde.org/job/plasma-workspace_master_qt5/ws/shell/widgetexplorer/plasmaappletitemmodel.cpp: In member function ‘void PlasmaAppletItemModel::populateModel(const QStringList)’: http://build.kde.org/job/plasma-workspace_master_qt5/ws/shell/widgetexplorer/plasmaappletitemmodel.cpp:236:33: warning: ‘KPluginInfo::KPluginInfo(KService::Ptr)’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kservice/inst/include/KF5/KService/kplugininfo.h:114) [-Wdeprecated-declarations] KPluginInfo info(service); ^ [ 27%] Building CXX object appmenu/CMakeFiles/kded_appmenu.dir/appmenu_dbus.cpp.o http://build.kde.org/job/plasma-workspace_master_qt5/ws/klipper/urlgrabber.cpp: In member function ‘void URLGrabber::actionMenu(const HistoryItem*, bool)’: http://build.kde.org/job/plasma-workspace_master_qt5/ws/klipper/urlgrabber.cpp:223:24: warning: ‘KMenu’ is deprecated (declared at /srv/jenkins/install/linux/x86_64/g++/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kmenu.h:42) [-Wdeprecated-declarations] m_myMenu = new KMenu; ^ Linking CXX shared library libkworkspace.so [ 27%] [ 27%] [ 27%] Built target kworkspace Building CXX object shell/widgetexplorer/CMakeFiles/plasmawidgetexplorerplugin.dir/openwidgetassistant.cpp.o [ 28%] [ 28%] Building CXX object klipper/CMakeFiles/kdeinit_klipper.dir/configdialog.cpp.o Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/launcheritem.cpp.o Building CXX object libtaskmanager/CMakeFiles/taskmanager.dir/startup.cpp.o http://build.kde.org/job/plasma-workspace_master_qt5/ws/shell/currentcontainmentactionsmodel.cpp: In member function ‘void CurrentContainmentActionsModel::showAbout(int)’: http://build.kde.org/job/plasma-workspace_master_qt5/ws/shell/currentcontainmentactionsmodel.cpp:233:36: error: no matching function for call to ‘KAboutData::KAboutData(QByteArray, QByteArray, QString, QByteArray, QString, KAboutLicense::LicenseKey, QString, QString, QByteArray, QByteArray)’ info.email().toLatin1()); ^ http://build.kde.org/job/plasma-workspace_master_qt5/ws/shell/currentcontainmentactionsmodel.cpp:233:36: note: candidates are: In file included from
