Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118160/
---

Review request for Plasma and David Edmundson.


Repository: plasma-workspace


Description
---

[screenlocker] Move grace time unlock functionality to KSLDApp

The LockWindow deep called into KSLDApp to unlock in case of user
activity during grace time. But LockWindow also emits a signal on user
activity. From an architectural point of view it's better to handle this
directly in the KSLDApp and connect to the signal to unlock if it's in
grace time.

Another advantage is that LockWindow now no longer pulls in the KSLDApp
which improves the unit test situation for the LockWindow as the
lockWindowTest no longer needs to link the complete ksld library.


Diffs
-

  ksmserver/screenlocker/autotests/CMakeLists.txt 
b31bbf79930042af2dfc6c95cedae65bc86655f6 
  ksmserver/screenlocker/ksldapp.cpp 7c4338cfb7019d01f08e36aff01aad8e91e5d343 
  ksmserver/screenlocker/lockwindow.cpp 
2abacb1cedc98eaa0414acf1bd46a6e5e14e6d5c 

Diff: https://git.reviewboard.kde.org/r/118160/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Re: Jenkins build became unstable: plasma-workspace_master_qt5 #217

[Martin Gräßlin]

Martin GräßlinOn Friday 16 May 2014 08:35:50  wrote:
> Martin GräßlinOn Wednesday 14 May 2014 14:14:26  wrote:
> > On Wednesday 14 May 2014 12:14:39 KDE CI System wrote:
> > > See 
> > 
> > seems to be my fault, apparently Jenkins (or openbox) doesn't like my
> > latest unit test
> 
> To give some feedback: I'm currently looking at it together with Ben. When
> running the test suit manually on Jenkins it succeeds, though.

Shot in the blue: https://git.reviewboard.kde.org/r/118160/


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is still unstable: plasma-workspace_master_qt5 #236

[KDE CI System]

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Ship with Aurorae and Qtcurve or not...

[David Edmundson]

QtCurve QStyle + Oxygen window dec is an option.

I run it here, it looks ok.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Ship with Aurorae and Qtcurve or not...

[Jens Reuterberg]

Screenshot?


On Fri, May 16, 2014 at 12:41 PM, David Edmundson <
da...@davidedmundson.co.uk> wrote:

> QtCurve QStyle + Oxygen window dec is an option.
>
> I run it here, it looks ok.
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Ship with Aurorae and Qtcurve or not...

[David Edmundson]

On Fri, May 16, 2014 at 1:04 PM, Jens Reuterberg  wrote:
> Screenshot?

http://imgur.com/Px6n2YO
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: Re: Ship with Aurorae and Qtcurve or not...

[Martin Gräßlin]

On Friday 16 May 2014 13:11:37 David Edmundson wrote:
> On Fri, May 16, 2014 at 1:04 PM, Jens Reuterberg  wrote:
> > Screenshot?
> 
> http://imgur.com/Px6n2YO

true, looks quite good. That's with gradient disabled, isn't it?

signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Ship with Aurorae and Qtcurve or not...

[Marco Martin]

On Friday 16 May 2014, David Edmundson wrote:
> On Fri, May 16, 2014 at 1:04 PM, Jens Reuterberg  wrote:
> > Screenshot?
> 
> http://imgur.com/Px6n2YO

the buttons are quite alien, but may be bearable

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Ship with Aurorae and Qtcurve or not...

[Marco Martin]

On Thursday 15 May 2014, Marco Martin wrote:
> btw, i added a small kde4 application in the breeze repo in the branch
> mart/kde4breeze
> that tries to set qtcurve, apply colors etc in the kde4 session.
> Do we go in this direction?

err, would be cool at least to know if i have to invest time in this or not.

i see here a giant thread of opinions wether "would look nice" or not,
and zero about concrete steps about how to solve the whole mess.
that's not cool

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breeze repo

[Marco Martin]

On Thursday 15 May 2014, Marco Martin wrote:
> On Monday 05 May 2014, Andrew Lake wrote:
> > I went ahead and added a 'working' branch and added the following:
> going into "resuscitating dead threads" again:
> 
> can the working branch be merged now?

ping again,
just to remind about how horribly late we are about all of this
(ie later today i am going to merge, no matter what)

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118160/#review58055
---



ksmserver/screenlocker/lockwindow.cpp


This is a behavioural change as we no longer have the return. 

Now we'll be indirectly calling unlock() then doing all of this sendEvent() 
onto a window that I think we've just terminated.

It might still work but it seems a tad dangerous.
Can you confirm it's ok?




- David Edmundson


On May 16, 2014, 7:34 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118160/
> ---
> 
> (Updated May 16, 2014, 7:34 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [screenlocker] Move grace time unlock functionality to KSLDApp
> 
> The LockWindow deep called into KSLDApp to unlock in case of user
> activity during grace time. But LockWindow also emits a signal on user
> activity. From an architectural point of view it's better to handle this
> directly in the KSLDApp and connect to the signal to unlock if it's in
> grace time.
> 
> Another advantage is that LockWindow now no longer pulls in the KSLDApp
> which improves the unit test situation for the LockWindow as the
> lockWindowTest no longer needs to link the complete ksld library.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> b31bbf79930042af2dfc6c95cedae65bc86655f6 
>   ksmserver/screenlocker/ksldapp.cpp 7c4338cfb7019d01f08e36aff01aad8e91e5d343 
>   ksmserver/screenlocker/lockwindow.cpp 
> 2abacb1cedc98eaa0414acf1bd46a6e5e14e6d5c 
> 
> Diff: https://git.reviewboard.kde.org/r/118160/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

[Martin Gräßlin]

> On May 16, 2014, 2:46 p.m., David Edmundson wrote:
> > ksmserver/screenlocker/lockwindow.cpp, line 307
> > 
> >
> > This is a behavioural change as we no longer have the return. 
> > 
> > Now we'll be indirectly calling unlock() then doing all of this 
> > sendEvent() onto a window that I think we've just terminated.
> > 
> > It might still work but it seems a tad dangerous.
> > Can you confirm it's ok?
> > 
> >

normally it doesn't matter that the events go to a no longer existing window. 
But anyway: should I change to Qt::QueuedConnection so that the events are 
processed first and then the unlock kicks in?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118160/#review58055
---


On May 16, 2014, 9:34 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118160/
> ---
> 
> (Updated May 16, 2014, 9:34 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [screenlocker] Move grace time unlock functionality to KSLDApp
> 
> The LockWindow deep called into KSLDApp to unlock in case of user
> activity during grace time. But LockWindow also emits a signal on user
> activity. From an architectural point of view it's better to handle this
> directly in the KSLDApp and connect to the signal to unlock if it's in
> grace time.
> 
> Another advantage is that LockWindow now no longer pulls in the KSLDApp
> which improves the unit test situation for the LockWindow as the
> lockWindowTest no longer needs to link the complete ksld library.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> b31bbf79930042af2dfc6c95cedae65bc86655f6 
>   ksmserver/screenlocker/ksldapp.cpp 7c4338cfb7019d01f08e36aff01aad8e91e5d343 
>   ksmserver/screenlocker/lockwindow.cpp 
> 2abacb1cedc98eaa0414acf1bd46a6e5e14e6d5c 
> 
> Diff: https://git.reviewboard.kde.org/r/118160/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

[David Edmundson]

> On May 16, 2014, 12:46 p.m., David Edmundson wrote:
> > ksmserver/screenlocker/lockwindow.cpp, line 307
> > 
> >
> > This is a behavioural change as we no longer have the return. 
> > 
> > Now we'll be indirectly calling unlock() then doing all of this 
> > sendEvent() onto a window that I think we've just terminated.
> > 
> > It might still work but it seems a tad dangerous.
> > Can you confirm it's ok?
> > 
> >
> 
> Martin Gräßlin wrote:
> normally it doesn't matter that the events go to a no longer existing 
> window. But anyway: should I change to Qt::QueuedConnection so that the 
> events are processed first and then the unlock kicks in?

Or just move the emit to the end of the function.
Your call.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118160/#review58055
---


On May 16, 2014, 7:34 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118160/
> ---
> 
> (Updated May 16, 2014, 7:34 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [screenlocker] Move grace time unlock functionality to KSLDApp
> 
> The LockWindow deep called into KSLDApp to unlock in case of user
> activity during grace time. But LockWindow also emits a signal on user
> activity. From an architectural point of view it's better to handle this
> directly in the KSLDApp and connect to the signal to unlock if it's in
> grace time.
> 
> Another advantage is that LockWindow now no longer pulls in the KSLDApp
> which improves the unit test situation for the LockWindow as the
> lockWindowTest no longer needs to link the complete ksld library.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> b31bbf79930042af2dfc6c95cedae65bc86655f6 
>   ksmserver/screenlocker/ksldapp.cpp 7c4338cfb7019d01f08e36aff01aad8e91e5d343 
>   ksmserver/screenlocker/lockwindow.cpp 
> 2abacb1cedc98eaa0414acf1bd46a6e5e14e6d5c 
> 
> Diff: https://git.reviewboard.kde.org/r/118160/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

[Martin Gräßlin]

> On May 16, 2014, 2:46 p.m., David Edmundson wrote:
> > ksmserver/screenlocker/lockwindow.cpp, line 307
> > 
> >
> > This is a behavioural change as we no longer have the return. 
> > 
> > Now we'll be indirectly calling unlock() then doing all of this 
> > sendEvent() onto a window that I think we've just terminated.
> > 
> > It might still work but it seems a tad dangerous.
> > Can you confirm it's ok?
> > 
> >
> 
> Martin Gräßlin wrote:
> normally it doesn't matter that the events go to a no longer existing 
> window. But anyway: should I change to Qt::QueuedConnection so that the 
> events are processed first and then the unlock kicks in?
> 
> David Edmundson wrote:
> Or just move the emit to the end of the function.
> Your call.

moving the emit woul also change the functionality. Let's use 
Qt::QueuedConnection.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118160/#review58055
---


On May 16, 2014, 9:34 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118160/
> ---
> 
> (Updated May 16, 2014, 9:34 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [screenlocker] Move grace time unlock functionality to KSLDApp
> 
> The LockWindow deep called into KSLDApp to unlock in case of user
> activity during grace time. But LockWindow also emits a signal on user
> activity. From an architectural point of view it's better to handle this
> directly in the KSLDApp and connect to the signal to unlock if it's in
> grace time.
> 
> Another advantage is that LockWindow now no longer pulls in the KSLDApp
> which improves the unit test situation for the LockWindow as the
> lockWindowTest no longer needs to link the complete ksld library.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> b31bbf79930042af2dfc6c95cedae65bc86655f6 
>   ksmserver/screenlocker/ksldapp.cpp 7c4338cfb7019d01f08e36aff01aad8e91e5d343 
>   ksmserver/screenlocker/lockwindow.cpp 
> 2abacb1cedc98eaa0414acf1bd46a6e5e14e6d5c 
> 
> Diff: https://git.reviewboard.kde.org/r/118160/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118160/
---

(Updated May 16, 2014, 3:20 p.m.)


Review request for Plasma and David Edmundson.


Changes
---

Qt::QueuedConnection


Repository: plasma-workspace


Description
---

[screenlocker] Move grace time unlock functionality to KSLDApp

The LockWindow deep called into KSLDApp to unlock in case of user
activity during grace time. But LockWindow also emits a signal on user
activity. From an architectural point of view it's better to handle this
directly in the KSLDApp and connect to the signal to unlock if it's in
grace time.

Another advantage is that LockWindow now no longer pulls in the KSLDApp
which improves the unit test situation for the LockWindow as the
lockWindowTest no longer needs to link the complete ksld library.


Diffs (updated)
-

  ksmserver/screenlocker/autotests/CMakeLists.txt 
b31bbf79930042af2dfc6c95cedae65bc86655f6 
  ksmserver/screenlocker/ksldapp.cpp 7c4338cfb7019d01f08e36aff01aad8e91e5d343 
  ksmserver/screenlocker/lockwindow.cpp 
2abacb1cedc98eaa0414acf1bd46a6e5e14e6d5c 

Diff: https://git.reviewboard.kde.org/r/118160/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118160/#review58059
---

Ship it!


Ship It!

- David Edmundson


On May 16, 2014, 1:20 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118160/
> ---
> 
> (Updated May 16, 2014, 1:20 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [screenlocker] Move grace time unlock functionality to KSLDApp
> 
> The LockWindow deep called into KSLDApp to unlock in case of user
> activity during grace time. But LockWindow also emits a signal on user
> activity. From an architectural point of view it's better to handle this
> directly in the KSLDApp and connect to the signal to unlock if it's in
> grace time.
> 
> Another advantage is that LockWindow now no longer pulls in the KSLDApp
> which improves the unit test situation for the LockWindow as the
> lockWindowTest no longer needs to link the complete ksld library.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> b31bbf79930042af2dfc6c95cedae65bc86655f6 
>   ksmserver/screenlocker/ksldapp.cpp 7c4338cfb7019d01f08e36aff01aad8e91e5d343 
>   ksmserver/screenlocker/lockwindow.cpp 
> 2abacb1cedc98eaa0414acf1bd46a6e5e14e6d5c 
> 
> Diff: https://git.reviewboard.kde.org/r/118160/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118160/#review58060
---


This review has been submitted with commit 
5c78986e1aea066cab13b9f330f19be9937fbc82 by Martin Gräßlin to branch master.

- Commit Hook


On May 16, 2014, 1:20 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118160/
> ---
> 
> (Updated May 16, 2014, 1:20 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [screenlocker] Move grace time unlock functionality to KSLDApp
> 
> The LockWindow deep called into KSLDApp to unlock in case of user
> activity during grace time. But LockWindow also emits a signal on user
> activity. From an architectural point of view it's better to handle this
> directly in the KSLDApp and connect to the signal to unlock if it's in
> grace time.
> 
> Another advantage is that LockWindow now no longer pulls in the KSLDApp
> which improves the unit test situation for the LockWindow as the
> lockWindowTest no longer needs to link the complete ksld library.
> 
> 
> Diffs
> -
> 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 
> b31bbf79930042af2dfc6c95cedae65bc86655f6 
>   ksmserver/screenlocker/ksldapp.cpp 7c4338cfb7019d01f08e36aff01aad8e91e5d343 
>   ksmserver/screenlocker/lockwindow.cpp 
> 2abacb1cedc98eaa0414acf1bd46a6e5e14e6d5c 
> 
> Diff: https://git.reviewboard.kde.org/r/118160/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118160: [screenlocker] Move grace time unlock functionality to KSLDApp

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118160/
---

(Updated May 16, 2014, 1:26 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and David Edmundson.


Repository: plasma-workspace


Description
---

[screenlocker] Move grace time unlock functionality to KSLDApp

The LockWindow deep called into KSLDApp to unlock in case of user
activity during grace time. But LockWindow also emits a signal on user
activity. From an architectural point of view it's better to handle this
directly in the KSLDApp and connect to the signal to unlock if it's in
grace time.

Another advantage is that LockWindow now no longer pulls in the KSLDApp
which improves the unit test situation for the LockWindow as the
lockWindowTest no longer needs to link the complete ksld library.


Diffs
-

  ksmserver/screenlocker/autotests/CMakeLists.txt 
b31bbf79930042af2dfc6c95cedae65bc86655f6 
  ksmserver/screenlocker/ksldapp.cpp 7c4338cfb7019d01f08e36aff01aad8e91e5d343 
  ksmserver/screenlocker/lockwindow.cpp 
2abacb1cedc98eaa0414acf1bd46a6e5e14e6d5c 

Diff: https://git.reviewboard.kde.org/r/118160/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Ship with Aurorae and Qtcurve or not...

[Thomas Pfeiffer]

On Friday 16 May 2014 13:37:34 Marco Martin wrote:
> On Thursday 15 May 2014, Marco Martin wrote:
> > btw, i added a small kde4 application in the breeze repo in the branch
> > mart/kde4breeze
> > that tries to set qtcurve, apply colors etc in the kde4 session.
> > Do we go in this direction?
> 
> err, would be cool at least to know if i have to invest time in this or not.
> 
> i see here a giant thread of opinions wether "would look nice" or not,
> and zero about concrete steps about how to solve the whole mess.
> that's not cool

Do you need input from developers or designers? If designer input is needed, 
just ping Jens and Andrew.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Ship with Aurorae and Qtcurve or not...

[Jens Reuterberg]

I am already pinged and have pinged Andrew


On Fri, May 16, 2014 at 3:28 PM, Thomas Pfeiffer wrote:

> On Friday 16 May 2014 13:37:34 Marco Martin wrote:
> > On Thursday 15 May 2014, Marco Martin wrote:
> > > btw, i added a small kde4 application in the breeze repo in the branch
> > > mart/kde4breeze
> > > that tries to set qtcurve, apply colors etc in the kde4 session.
> > > Do we go in this direction?
> >
> > err, would be cool at least to know if i have to invest time in this or
> not.
> >
> > i see here a giant thread of opinions wether "would look nice" or not,
> > and zero about concrete steps about how to solve the whole mess.
> > that's not cool
>
> Do you need input from developers or designers? If designer input is
> needed,
> just ping Jens and Andrew.
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Ship with Aurorae and Qtcurve or not...

[Marco Martin]

On Friday 16 May 2014, Thomas Pfeiffer wrote:
> > i see here a giant thread of opinions wether "would look nice" or not,
> > and zero about concrete steps about how to solve the whole mess.
> > that's not cool
> 
> Do you need input from developers or designers? If designer input is
> needed, just ping Jens and Andrew.

mastly developers :)

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is still unstable: plasma-workspace_master_qt5 #237

[KDE CI System]

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118092: Left and right movement in All music

[Shantanu Tushar]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118092/#review58065
---



components/listbrowser/ListBrowser.qml


A ListBrowser does not need to be in a TabBar, (even though in All Music it 
is). So as a safeguard, do a check that listBrowserRoot.topSibling.buttons 
should be defined. Something like-
var buttons = listBrowserRoot.topSibling.buttons;
if (buttons) {
buttons.get(1).button.clicked();
}



- Shantanu Tushar


On May 16, 2014, 3:18 a.m., Sujith Haridasan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118092/
> ---
> 
> (Updated May 16, 2014, 3:18 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Bugs: 334148
> http://bugs.kde.org/show_bug.cgi?id=334148
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Left and right movement in All Music -> Songs section. Now user can navigate 
> left and right when in the songs section. And this is applicable only to the 
> songs section.
> 
> 
> Diffs
> -
> 
>   components/listbrowser/ListBrowser.qml 202d406 
> 
> Diff: https://git.reviewboard.kde.org/r/118092/diff/
> 
> 
> Testing
> ---
> 
> 1) Use down arrow key to reach songs.
> 2) Press left/right arrow key.
> 3) Press left/right arrow key(for some reason we have to press the same key 
> twice).
> 4) User reaches Artists if pressed left or Albums if pressed right.
> 
> 
> Thanks,
> 
> Sujith Haridasan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118092: Left and right movement in All music

[Shantanu Tushar]

> On May 16, 2014, 4:20 a.m., Ashish Madeti wrote:
> > Now if you are on Songs tab, a single left/right key press will take you to 
> > Artists/Albums section but when you return to Songs section, the focus is 
> > still on tab bar. Due to this user has to first go to the list by pressing 
> > down key once (not intuitive) whereas imho user should be able to continue 
> > from where he left.

The bigger problem is that our up/down navigation is already not so clear in 
All Music. Fixing that should be better, i.e. to properly show that the focus 
is still on the TabBar. However, this is not in scope of this patch.


- Shantanu


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118092/#review58040
---


On May 16, 2014, 3:18 a.m., Sujith Haridasan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118092/
> ---
> 
> (Updated May 16, 2014, 3:18 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Bugs: 334148
> http://bugs.kde.org/show_bug.cgi?id=334148
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Left and right movement in All Music -> Songs section. Now user can navigate 
> left and right when in the songs section. And this is applicable only to the 
> songs section.
> 
> 
> Diffs
> -
> 
>   components/listbrowser/ListBrowser.qml 202d406 
> 
> Diff: https://git.reviewboard.kde.org/r/118092/diff/
> 
> 
> Testing
> ---
> 
> 1) Use down arrow key to reach songs.
> 2) Press left/right arrow key.
> 3) Press left/right arrow key(for some reason we have to press the same key 
> twice).
> 4) User reaches Artists if pressed left or Albums if pressed right.
> 
> 
> Thanks,
> 
> Sujith Haridasan
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Ship with Aurorae and Qtcurve or not...

[David Edmundson]

We have an extra month. Lets do it.

As for your application, I think we need a guard on
if (QFile::exists( theQStyleRcFile ) {
  return;
}
so we don't trash user configs.

group.writeEntry("widgetStyle", "oxygen");
seems wrong

Is the plan to add a kconf_update script to run this?
Or have it run by startkde? or by the user manually?

David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Ship with Aurorae and Qtcurve or not...

[Marco Martin]

On Friday 16 May 2014, David Edmundson wrote:
> We have an extra month. Lets do it.
> 
> As for your application, I think we need a guard on
> if (QFile::exists( theQStyleRcFile ) {
>   return;
> }
> so we don't trash user configs.
> 
> group.writeEntry("widgetStyle", "oxygen");
> seems wrong
> 
> Is the plan to add a kconf_update script to run this?
> Or have it run by startkde? or by the user manually?

it can't be a kconf_update, becasue is a kde4 application and has to be 
executed at a plasma next session startup.
so should be an autostart application.

at the moment is a kde4 application to be safer to access config of kde4
(otherwise i guess would be possible by just accessing ~/.kde or ~/kde4 going 
by attempts, but a bit more error prone perhaps)

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Ship with Aurorae and Qtcurve or not...

[Sebastian Kügler]

On Friday, May 16, 2014 16:20:26 Marco Martin wrote:
> On Friday 16 May 2014, David Edmundson wrote:
> > We have an extra month. Lets do it.
> >
> > 
> >
> > As for your application, I think we need a guard on
> > if (QFile::exists( theQStyleRcFile ) {
> >
> >   return;
> >
> > }
> > so we don't trash user configs.
> >
> > 
> >
> > group.writeEntry("widgetStyle", "oxygen");
> > seems wrong
> >
> > 
> >
> > Is the plan to add a kconf_update script to run this?
> > Or have it run by startkde? or by the user manually?
> 
> it can't be a kconf_update, becasue is a kde4 application and has to be 
> executed at a plasma next session startup.
> so should be an autostart application.
> 
> at the moment is a kde4 application to be safer to access config of kde4
> (otherwise i guess would be possible by just accessing ~/.kde or ~/kde4
> going  by attempts, but a bit more error prone perhaps)

We should be able to check KDEDIRS first here? (It's unused in KF5, but could 
still be set in a Plasma session to indicate "the old .kde config is ").
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Ship with Aurorae and Qtcurve or not...

[Ivan Čukić]

> > at the moment is a kde4 application to be safer to access config of kde4
> > (otherwise i guess would be possible by just accessing ~/.kde or ~/kde4
> > going  by attempts, but a bit more error prone perhaps)
> 
> We should be able to check KDEDIRS first here? (It's unused in KF5, but
> could still be set in a Plasma session to indicate "the old .kde config is
> ").

See Kdelibs4Migration class from kdecoreaddons.

Cheers
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118126: Show applets from the system tray in Widget Explorer

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118126/#review58071
---


BUMP.


- David Edmundson


On May 14, 2014, 1:08 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118126/
> ---
> 
> (Updated May 14, 2014, 1:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Show applets from the system tray in Widget Explorer
> 
> I'm not super happy with the approach; but I really can't find anything 
> better.
> Registering the Containment in Corona becomes an even bigger hack.
> 
> 
> Diffs
> -
> 
>   applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.cpp 3121c81 
>   shell/widgetexplorer/widgetexplorer.cpp 1ba8ee6 
> 
> Diff: https://git.reviewboard.kde.org/r/118126/diff/
> 
> 
> Testing
> ---
> 
> Opened widget explorer. 
> 
> Note it seems adding/removing containments whilst the explorer is open is 
> currently unimplemented; this will still be the case for adding/removing the 
> system tray. That can be a different patch.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118126: Show applets from the system tray in Widget Explorer

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118126/#review58072
---


that's the least terrible.
registering the containment to the corona would do a disaster, would screw the 
configuration file pretty badly

- Marco Martin


On May 14, 2014, 1:08 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118126/
> ---
> 
> (Updated May 14, 2014, 1:08 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Show applets from the system tray in Widget Explorer
> 
> I'm not super happy with the approach; but I really can't find anything 
> better.
> Registering the Containment in Corona becomes an even bigger hack.
> 
> 
> Diffs
> -
> 
>   applets/systemtray/plugin/protocols/plasmoid/plasmoidprotocol.cpp 3121c81 
>   shell/widgetexplorer/widgetexplorer.cpp 1ba8ee6 
> 
> Diff: https://git.reviewboard.kde.org/r/118126/diff/
> 
> 
> Testing
> ---
> 
> Opened widget explorer. 
> 
> Note it seems adding/removing containments whilst the explorer is open is 
> currently unimplemented; this will still be the case for adding/removing the 
> system tray. That can be a different patch.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Ship with Aurorae and Qtcurve or not...

[Marco Martin]

On Friday 16 May 2014, Ivan Čukić wrote:
> > > at the moment is a kde4 application to be safer to access config of
> > > kde4 (otherwise i guess would be possible by just accessing ~/.kde or
> > > ~/kde4 going  by attempts, but a bit more error prone perhaps)
> > 
> > We should be able to check KDEDIRS first here? (It's unused in KF5, but
> > could still be set in a Plasma session to indicate "the old .kde config
> > is ").
> 
> See Kdelibs4Migration class from kdecoreaddons.

hmm, *almost*
seems to find only stuff in the home tough with locateLocal

while i would have to find also stuff installed systemwide

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breeze repo

[Andrew Lake]

No problem on merging Marco.


On Fri, May 16, 2014 at 4:39 AM, Marco Martin  wrote:

> On Thursday 15 May 2014, Marco Martin wrote:
> > On Monday 05 May 2014, Andrew Lake wrote:
> > > I went ahead and added a 'working' branch and added the following:
> > going into "resuscitating dead threads" again:
> >
> > can the working branch be merged now?
>
> ping again,
> just to remind about how horribly late we are about all of this
> (ie later today i am going to merge, no matter what)
>
> --
> Marco Martin
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Breeze repo

[Marco Martin]

On Friday 16 May 2014, Andrew Lake wrote:
> No problem on merging Marco.
> 

done ;)

-- 
Marco Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Ship with Aurorae and Qtcurve or not...

[Andrew Lake]

On Fri, May 16, 2014 at 6:29 AM, Jens Reuterberg wrote:

> I am already pinged and have pinged Andrew
>
>
Best I can tell, the new Plasma Next plan for visuals is:
* Widget style: QtCurve with Breeze settings applied for qt4 and qt5
QWidget apps
* Window decoration: Oxygen with background gradient off (looks quite
decent to me)
* Icons: (Actions/Places icons from new theme + Oxygen)? OR (the new
theme)? I'm ok with either approach.
* Plasma theme: Breeze (done)
* Cursors: Breeze (done)
* Colors: Breeze color scheme

That all looks great to me. I'm not sure what else I can do from my end to
help, but if there's anything I can do please let me know.

Do we need to get the icons into the breeze project repo?
Are there any other visual assets that are needed but not yet in place?
Are there any tweaks needed to any of the existing visual assets that I can
help with from the VDG side?

Thanks,
Andrew
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118169: Rename pkgconfig file

[Michael Palimaka]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118169/
---

Review request for Plasma and Jonathan Riddell.


Repository: libkscreen


Description
---

Since frameworks branch is being released as libkscreen2 and is required to be 
coinstallable, the pkgconfig file needs to be renamed to avoid colliding.


Diffs
-

  src/CMakeLists.txt 14bf2dffa50f88ec591eeffcd918685be97d8f27 

Diff: https://git.reviewboard.kde.org/r/118169/diff/


Testing
---

Builds, installs.


Thanks,

Michael Palimaka

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is still unstable: plasma-workspace_master_qt5 #238

[KDE CI System]

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118092: Left and right movement in All music

[Sujith Haridasan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118092/
---

(Updated May 16, 2014, 6:36 p.m.)


Review request for Plasma, Shantanu Tushar and Sinny Kumari.


Changes
---

Added a check if listBrowserRoot.topSibling.buttons, is defined. If defined 
then switch the focus on to the tabbar.


Bugs: 334148
http://bugs.kde.org/show_bug.cgi?id=334148


Repository: plasma-mediacenter


Description
---

Left and right movement in All Music -> Songs section. Now user can navigate 
left and right when in the songs section. And this is applicable only to the 
songs section.


Diffs (updated)
-

  components/listbrowser/ListBrowser.qml 202d406 

Diff: https://git.reviewboard.kde.org/r/118092/diff/


Testing
---

1) Use down arrow key to reach songs.
2) Press left/right arrow key.
3) Press left/right arrow key(for some reason we have to press the same key 
twice).
4) User reaches Artists if pressed left or Albums if pressed right.


Thanks,

Sujith Haridasan

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is still unstable: plasma-workspace_master_qt5 #239

[KDE CI System]

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel