Review Request 118343: [klipper] Port from KMenu to QMenu

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118343/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

[klipper] Port from KMenu to QMenu

Note: depending on the widget style this renders a regression as the
section might not be supported by the style. This is the case for
Oxygen, see bug 335400.


Diffs
-

  klipper/klipperpopup.h 52e7c4ce38afb211af00a61439e6656e6b542343 
  klipper/klipperpopup.cpp dc15d03b0b5cdaa65db3d0cad629e2b42cee9852 
  klipper/popupproxy.h 69e3ddd0fe6d92d9fbef9c07601f912e8ff37346 
  klipper/popupproxy.cpp 6a1e757c2051d3c25699a5ced5dc75de120bf212 
  klipper/urlgrabber.h 01a83df2b2a4bd16ed735c7b6c0d12ef63d9aa83 
  klipper/urlgrabber.cpp 923aa943c5e95d0f24565bf8f286cac13aba0b04 

Diff: https://git.reviewboard.kde.org/r/118343/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118341: [klipper] Port from KCmdLineArgs to QCommandLineParser

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118341/#review58541
---

Ship it!


Ship It!

- Martin Klapetek


On May 27, 2014, 7:43 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118341/
> ---
> 
> (Updated May 27, 2014, 7:43 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Port from KCmdLineArgs to QCommandLineParser
> 
> 
> Diffs
> -
> 
>   klipper/main.cpp 48901bb88ec8097a116d00ba294f349b9419b9d8 
> 
> Diff: https://git.reviewboard.kde.org/r/118341/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[Thomas Pfeiffer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/#review58542
---


Could you attach a screenshot of the Compositing KCM with the patch applied so 
we could see whether all layout glitches have been fixed and add Andrew Lake to 
the review request? That would be great, thanks!

- Thomas Pfeiffer


On May 26, 2014, 11:19 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118337/
> ---
> 
> (Updated May 26, 2014, 11:19 p.m.)
> 
> 
> Review request for Plasma, Hugo Pereira Da Costa and Thomas Pfeiffer.
> 
> 
> Repository: oxygen
> 
> 
> Description
> ---
> 
> 
> PM_DefaultLayoutSpacing is deprecated and replaced by both
> PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.
> 
> Qt Layouts now query for these, not the default spacing.
> 
> See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum
> 
> There are some other deprecated enums, which are mostly not a problem.
> 
> 
> Diffs
> -
> 
>   kstyle/oxygenstyle.cpp 8bcb79a 
> 
> Diff: https://git.reviewboard.kde.org/r/118337/diff/
> 
> 
> Testing
> ---
> 
> Spacing between labels and controls is now restored o/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/
---

(Updated May 27, 2014, 9:25 a.m.)


Review request for Plasma, Hugo Pereira Da Costa and Thomas Pfeiffer.


Changes
---

Added screenshot (after)

For before see https://git.reviewboard.kde.org/r/118273/


Repository: oxygen


Description
---


PM_DefaultLayoutSpacing is deprecated and replaced by both
PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.

Qt Layouts now query for these, not the default spacing.

See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum

There are some other deprecated enums, which are mostly not a problem.


Diffs
-

  kstyle/oxygenstyle.cpp 8bcb79a 

Diff: https://git.reviewboard.kde.org/r/118337/diff/


Testing
---

Spacing between labels and controls is now restored o/


File Attachments (updated)


compositing_kcm
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/#review58545
---



File Attachment: compositing_kcm - bustle1.png

This is still an issue, but one thing at a time.

- David Edmundson


On May 27, 2014, 9:25 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118337/
> ---
> 
> (Updated May 27, 2014, 9:25 a.m.)
> 
> 
> Review request for Plasma, Hugo Pereira Da Costa and Thomas Pfeiffer.
> 
> 
> Repository: oxygen
> 
> 
> Description
> ---
> 
> 
> PM_DefaultLayoutSpacing is deprecated and replaced by both
> PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.
> 
> Qt Layouts now query for these, not the default spacing.
> 
> See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum
> 
> There are some other deprecated enums, which are mostly not a problem.
> 
> 
> Diffs
> -
> 
>   kstyle/oxygenstyle.cpp 8bcb79a 
> 
> Diff: https://git.reviewboard.kde.org/r/118337/diff/
> 
> 
> Testing
> ---
> 
> Spacing between labels and controls is now restored o/
> 
> 
> File Attachments
> 
> 
> compositing_kcm
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

4.x autostart compat

[Harald Sitter]

Heya

Something that just occured to me is that it appears we currently have
no autostart compatibility with kdelibs4 applications. Namely when an
application installs an autostart desktop file in 4.x they'd end up in
$PREFIX/share/autostart which by default does not appear to be
searched by ksmserver unless one explicitly adds it to
XDG_CONFIG_DIRS.

How is this supposed to be done in production? Should the user/distro
set XDG_CONFIG_DIRS? And if so, what happens if the legacy autostart
folder contains legacy applications that are replaced by a kf5
version? (plasma-desktop/-netbook, baloo...).

HS
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118346: [klipper] Re-enable prison support

[Johannes Huber]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118346/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Build option is needed to have prison support.


Diffs
-

  klipper/CMakeLists.txt c700f9e 

Diff: https://git.reviewboard.kde.org/r/118346/diff/


Testing
---

Compiled with and without prison support. 


Thanks,

Johannes Huber

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/
---

(Updated May 27, 2014, 9:42 a.m.)


Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas 
Pfeiffer.


Repository: oxygen


Description
---


PM_DefaultLayoutSpacing is deprecated and replaced by both
PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.

Qt Layouts now query for these, not the default spacing.

See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum

There are some other deprecated enums, which are mostly not a problem.


Diffs
-

  kstyle/oxygenstyle.cpp 8bcb79a 

Diff: https://git.reviewboard.kde.org/r/118337/diff/


Testing
---

Spacing between labels and controls is now restored o/


File Attachments


compositing_kcm
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118346: [klipper] Re-enable prison support

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118346/#review58547
---


at the moment this cannot be enabled yet. I have already prepared a similar 
change and backed away from it, due to no way to figure out whether prison is 
compiled against Qt4 or Qt5.

Further more on Debian based systems the installation of prison for Qt5 is 
broken, see https://git.reviewboard.kde.org/r/118291/

This results in the system's prison installation being used and completely 
breaking klipper. To solve this I added a version check in my variant, but 
that's of course also incomplete.

- Martin Gräßlin


On May 27, 2014, 11:37 a.m., Johannes Huber wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118346/
> ---
> 
> (Updated May 27, 2014, 11:37 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Build option is needed to have prison support.
> 
> 
> Diffs
> -
> 
>   klipper/CMakeLists.txt c700f9e 
> 
> Diff: https://git.reviewboard.kde.org/r/118346/diff/
> 
> 
> Testing
> ---
> 
> Compiled with and without prison support. 
> 
> 
> Thanks,
> 
> Johannes Huber
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118342: [klipper] Port to new KAboutData

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118342/#review58548
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On May 27, 2014, 6:09 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118342/
> ---
> 
> (Updated May 27, 2014, 6:09 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Port to new KAboutData
> 
> 
> Diffs
> -
> 
>   klipper/main.cpp 48901bb88ec8097a116d00ba294f349b9419b9d8 
>   klipper/klipper.cpp b41af1e2c5a8de2e997dc82821d35ac69b1bee6d 
>   klipper/klipper.h ad18b66497c43b61c457984b6b92416047962780 
> 
> Diff: https://git.reviewboard.kde.org/r/118342/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118346: [klipper] Re-enable prison support

[Johannes Huber]

> On May 27, 2014, 12:08 p.m., Martin Gräßlin wrote:
> > at the moment this cannot be enabled yet. I have already prepared a similar 
> > change and backed away from it, due to no way to figure out whether prison 
> > is compiled against Qt4 or Qt5.
> > 
> > Further more on Debian based systems the installation of prison for Qt5 is 
> > broken, see https://git.reviewboard.kde.org/r/118291/
> > 
> > This results in the system's prison installation being used and completely 
> > breaking klipper. To solve this I added a version check in my variant, but 
> > that's of course also incomplete.

This seems debian/ubuntu specific problem. Works here on Gentoo with prison qt5 
build. As this is a optional build option it can be easily disabled downstream.

* Contents of media-libs/prison-:
/usr
/usr/include
/usr/include/prison
/usr/include/prison/AbstractBarcode
/usr/include/prison/BarcodeItem
/usr/include/prison/BarcodeWidget
/usr/include/prison/Code39Barcode
/usr/include/prison/Code93Barcode
/usr/include/prison/DataMatrixBarcode
/usr/include/prison/QRCodeBarcode
/usr/include/prison/abstractbarcode.h
/usr/include/prison/barcodeitem.h
/usr/include/prison/barcodewidget.h
/usr/include/prison/code39barcode.h
/usr/include/prison/code93barcode.h
/usr/include/prison/datamatrixbarcode.h
/usr/include/prison/prison_export.h
/usr/include/prison/qrcodebarcode.h
/usr/lib
/usr/lib/debug
/usr/lib/debug/usr
/usr/lib/debug/usr/lib64
/usr/lib/debug/usr/lib64/libprison.so.0.2.0.debug
/usr/lib64
/usr/lib64/cmake
/usr/lib64/cmake/Prison
/usr/lib64/cmake/Prison/PrisonConfig.cmake
/usr/lib64/cmake/Prison/PrisonConfigVersion.cmake
/usr/lib64/libprison.so -> libprison.so.0
/usr/lib64/libprison.so.0 -> libprison.so.0.2.0
/usr/lib64/libprison.so.0.2.0


- Johannes


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118346/#review58547
---


On May 27, 2014, 11:37 a.m., Johannes Huber wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118346/
> ---
> 
> (Updated May 27, 2014, 11:37 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Build option is needed to have prison support.
> 
> 
> Diffs
> -
> 
>   klipper/CMakeLists.txt c700f9e 
> 
> Diff: https://git.reviewboard.kde.org/r/118346/diff/
> 
> 
> Testing
> ---
> 
> Compiled with and without prison support. 
> 
> 
> Thanks,
> 
> Johannes Huber
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118346: [klipper] Re-enable prison support

[Martin Gräßlin]

> On May 27, 2014, 12:08 p.m., Martin Gräßlin wrote:
> > at the moment this cannot be enabled yet. I have already prepared a similar 
> > change and backed away from it, due to no way to figure out whether prison 
> > is compiled against Qt4 or Qt5.
> > 
> > Further more on Debian based systems the installation of prison for Qt5 is 
> > broken, see https://git.reviewboard.kde.org/r/118291/
> > 
> > This results in the system's prison installation being used and completely 
> > breaking klipper. To solve this I added a version check in my variant, but 
> > that's of course also incomplete.
> 
> Johannes Huber wrote:
> This seems debian/ubuntu specific problem. Works here on Gentoo with 
> prison qt5 build. As this is a optional build option it can be easily 
> disabled downstream.
> 
> * Contents of media-libs/prison-:
> /usr
> /usr/include
> /usr/include/prison
> /usr/include/prison/AbstractBarcode
> /usr/include/prison/BarcodeItem
> /usr/include/prison/BarcodeWidget
> /usr/include/prison/Code39Barcode
> /usr/include/prison/Code93Barcode
> /usr/include/prison/DataMatrixBarcode
> /usr/include/prison/QRCodeBarcode
> /usr/include/prison/abstractbarcode.h
> /usr/include/prison/barcodeitem.h
> /usr/include/prison/barcodewidget.h
> /usr/include/prison/code39barcode.h
> /usr/include/prison/code93barcode.h
> /usr/include/prison/datamatrixbarcode.h
> /usr/include/prison/prison_export.h
> /usr/include/prison/qrcodebarcode.h
> /usr/lib
> /usr/lib/debug
> /usr/lib/debug/usr
> /usr/lib/debug/usr/lib64
> /usr/lib/debug/usr/lib64/libprison.so.0.2.0.debug
> /usr/lib64
> /usr/lib64/cmake
> /usr/lib64/cmake/Prison
> /usr/lib64/cmake/Prison/PrisonConfig.cmake
> /usr/lib64/cmake/Prison/PrisonConfigVersion.cmake
> /usr/lib64/libprison.so -> libprison.so.0
> /usr/lib64/libprison.so.0 -> libprison.so.0.2.0
> /usr/lib64/libprison.so.0.2.0
> 
>

and what happens if you have both prison for qt4 and qt5 installed? This looks 
to me like you only have one install of prison.

I run into this issue on Saturday resulting in the linked review request. To me 
it looks like prison for Qt 5 has not yet reached a quality that allows it as a 
dependency.

Of course it's an optional dependency and can be easily disabled. But it means 
that anybody not yet having prison/qt5, but having a prison/qt4 will have 
picked it up automatically and thus breaking klipper. As long as prison doesn't 
fix that, it's a -2 to me. It's easy to fix in prison: just use a new version 
number for the Qt5 build.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118346/#review58547
---


On May 27, 2014, 11:37 a.m., Johannes Huber wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118346/
> ---
> 
> (Updated May 27, 2014, 11:37 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Build option is needed to have prison support.
> 
> 
> Diffs
> -
> 
>   klipper/CMakeLists.txt c700f9e 
> 
> Diff: https://git.reviewboard.kde.org/r/118346/diff/
> 
> 
> Testing
> ---
> 
> Compiled with and without prison support. 
> 
> 
> Thanks,
> 
> Johannes Huber
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118343: [klipper] Port from KMenu to QMenu

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118343/#review58552
---

Ship it!


Ship It!

- Sebastian Kügler


On May 27, 2014, 7:31 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118343/
> ---
> 
> (Updated May 27, 2014, 7:31 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Port from KMenu to QMenu
> 
> Note: depending on the widget style this renders a regression as the
> section might not be supported by the style. This is the case for
> Oxygen, see bug 335400.
> 
> 
> Diffs
> -
> 
>   klipper/klipperpopup.h 52e7c4ce38afb211af00a61439e6656e6b542343 
>   klipper/klipperpopup.cpp dc15d03b0b5cdaa65db3d0cad629e2b42cee9852 
>   klipper/popupproxy.h 69e3ddd0fe6d92d9fbef9c07601f912e8ff37346 
>   klipper/popupproxy.cpp 6a1e757c2051d3c25699a5ced5dc75de120bf212 
>   klipper/urlgrabber.h 01a83df2b2a4bd16ed735c7b6c0d12ef63d9aa83 
>   klipper/urlgrabber.cpp 923aa943c5e95d0f24565bf8f286cac13aba0b04 
> 
> Diff: https://git.reviewboard.kde.org/r/118343/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118346: [klipper] Re-enable prison support

[Johannes Huber]

> On May 27, 2014, 12:08 p.m., Martin Gräßlin wrote:
> > at the moment this cannot be enabled yet. I have already prepared a similar 
> > change and backed away from it, due to no way to figure out whether prison 
> > is compiled against Qt4 or Qt5.
> > 
> > Further more on Debian based systems the installation of prison for Qt5 is 
> > broken, see https://git.reviewboard.kde.org/r/118291/
> > 
> > This results in the system's prison installation being used and completely 
> > breaking klipper. To solve this I added a version check in my variant, but 
> > that's of course also incomplete.
> 
> Johannes Huber wrote:
> This seems debian/ubuntu specific problem. Works here on Gentoo with 
> prison qt5 build. As this is a optional build option it can be easily 
> disabled downstream.
> 
> * Contents of media-libs/prison-:
> /usr
> /usr/include
> /usr/include/prison
> /usr/include/prison/AbstractBarcode
> /usr/include/prison/BarcodeItem
> /usr/include/prison/BarcodeWidget
> /usr/include/prison/Code39Barcode
> /usr/include/prison/Code93Barcode
> /usr/include/prison/DataMatrixBarcode
> /usr/include/prison/QRCodeBarcode
> /usr/include/prison/abstractbarcode.h
> /usr/include/prison/barcodeitem.h
> /usr/include/prison/barcodewidget.h
> /usr/include/prison/code39barcode.h
> /usr/include/prison/code93barcode.h
> /usr/include/prison/datamatrixbarcode.h
> /usr/include/prison/prison_export.h
> /usr/include/prison/qrcodebarcode.h
> /usr/lib
> /usr/lib/debug
> /usr/lib/debug/usr
> /usr/lib/debug/usr/lib64
> /usr/lib/debug/usr/lib64/libprison.so.0.2.0.debug
> /usr/lib64
> /usr/lib64/cmake
> /usr/lib64/cmake/Prison
> /usr/lib64/cmake/Prison/PrisonConfig.cmake
> /usr/lib64/cmake/Prison/PrisonConfigVersion.cmake
> /usr/lib64/libprison.so -> libprison.so.0
> /usr/lib64/libprison.so.0 -> libprison.so.0.2.0
> /usr/lib64/libprison.so.0.2.0
> 
>
> 
> Martin Gräßlin wrote:
> and what happens if you have both prison for qt4 and qt5 installed? This 
> looks to me like you only have one install of prison.
> 
> I run into this issue on Saturday resulting in the linked review request. 
> To me it looks like prison for Qt 5 has not yet reached a quality that allows 
> it as a dependency.
> 
> Of course it's an optional dependency and can be easily disabled. But it 
> means that anybody not yet having prison/qt5, but having a prison/qt4 will 
> have picked it up automatically and thus breaking klipper. As long as prison 
> doesn't fix that, it's a -2 to me. It's easy to fix in prison: just use a new 
> version number for the Qt5 build.

> and what happens if you have both prison for qt4 and qt5 installed?


 * package media-libs/prison-1.1.1 NOT merged
 * 
 * Detected file collision(s):
 * 
 *  /usr/include/prison/prison_export.h
 *  /usr/include/prison/QRCodeBarcode
 *  /usr/include/prison/qrcodebarcode.h
 *  /usr/include/prison/DataMatrixBarcode
 *  /usr/include/prison/datamatrixbarcode.h
 *  /usr/include/prison/Code93Barcode
 *  /usr/include/prison/code93barcode.h
 *  /usr/include/prison/Code39Barcode
 *  /usr/include/prison/code39barcode.h
 *  /usr/include/prison/BarcodeWidget
 *  /usr/include/prison/barcodewidget.h
 *  /usr/include/prison/BarcodeItem
 *  /usr/include/prison/barcodeitem.h
 *  /usr/include/prison/AbstractBarcode
 *  /usr/include/prison/abstractbarcode.h
 *  /usr/lib64/cmake/Prison/PrisonConfig.cmake
 *  /usr/lib64/libprison.so
 *  /usr/lib64/libprison.so.0

With the current build system of prison it isn't possible to install prison 
qt4/qt5 in parallel.


- Johannes


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118346/#review58547
---


On May 27, 2014, 11:37 a.m., Johannes Huber wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118346/
> ---
> 
> (Updated May 27, 2014, 11:37 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Build option is needed to have prison support.
> 
> 
> Diffs
> -
> 
>   klipper/CMakeLists.txt c700f9e 
> 
> Diff: https://git.reviewboard.kde.org/r/118346/diff/
> 
> 
> Testing
> ---
> 
> Compiled with and without prison support. 
> 
> 
> Thanks,
> 
> Johannes Huber
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: High DPI issues

[Teo Mrnjavac]

On Monday, May 26, 2014 17:47:35 Teo Mrnjavac wrote:
> On Tuesday, May 20, 2014 15:16:25 Teo Mrnjavac wrote:
> > On Tuesday, May 20, 2014 14:55:16 David Edmundson wrote:
> > > On Tue, May 20, 2014 at 2:28 PM, Teo Mrnjavac  wrote:
> > > > Another important issue is that currently the only tested and nicely
> > > > working values for QT_HIGHDPI_SCALE_FACTOR are 1.0 and 2.0, i.e. Mac
> > > > OS
> > > > style scaling.
> > > 
> > > I can't imagine it being too big a problem; things only look bad once
> > > they're past a certain point.
> > > 
> > > > produce decent results and minimize glitches, but the only way to be
> > > > sure
> > > > of that is trying it out. I'll try to give his branch a spin when I
> > > > get
> > > > the chance.
> > > 
> > > Please do, and report back.
> > 
> > Will do.
> 
> High DPI status update, part 2.
> 
> So I've managed to build Morten's highdpi branch [1] and (most of) the
> kdesrc- build roster on top of it. Right now the highdpi branch tracks
> stable. As hinted last week, this branch scales up all UI elements by a
> scaling factor. On OSX this scaling factor is 1.0 or 2.0, in line with
> Apple's retina scaling policy, but on X11 it doesn't have to be an integer.
> Also on X11 there is no code that tries to guess this scaling factor,
> relying instead on an environment variable QT_HIGHDPI_SCALE_FACTOR.
> 
> I've made some screenshots of Kate with different values of
> QT_HIGHDPI_SCALE_FACTOR. All of them are with kwin 4 and unless otherwise
> noted, the style is Fusion.
> 
> http://wstaw.org/m/2014/05/26/plasma-desktopIo2083.png
> QT_HIGHDPI_SCALE_FACTOR not set.
> Font size in pixels is big because the fonts DPI is from the Xft.dpi setting
> which in turn comes from my Nvidia driver. The window opens up way too
> small for my screen.
> 
> http://wstaw.org/m/2014/05/26/plasma-desktopni2083.png
> QT_HIGHDPI_SCALE_FACTOR=1.0
> It looks like the scale factor overrides the Xft DPI setting.
> 
> http://wstaw.org/m/2014/05/26/plasma-desktopaQ2083.png
> QT_HIGHDPI_SCALE_FACTOR=1.5
> Decent overall widget geometry, window size also good automatically. Bad
> pixmaps, font kerning issues to be fixed in Qt.
> 
> http://wstaw.org/m/2014/05/26/plasma-desktoppN2083.png
> QT_HIGHDPI_SCALE_FACTOR=1.75
> 
> http://wstaw.org/m/2014/05/26/plasma-desktopLe2083.png
> QT_HIGHDPI_SCALE_FACTOR=2.0
> Pixmaps still rough, fonts look better. This is arguably the right scale
> factor for my 215ppi panel, and the overall result is visually nice.
> 
> http://wstaw.org/m/2014/05/26/plasma-desktopTf2083.png
> QT_HIGHDPI_SCALE_FACTOR=3.0
> 
> http://wstaw.org/m/2014/05/26/plasma-desktopCs2083.png
> QT_HIGHDPI_SCALE_FACTOR=2.0
> With Oxygen style.
> 
> Feel free to let me know if you can think of ways to break it, I can try and
> report back with screenshots.
> 
> As for generating the QT_HIGHDPI_SCALE_FACTOR, we can have some heuristics
> based on Xft DPI (if set), which could then be overridden in the Fonts KCM
> or some other KCM. Multiples of .25 or even .5 would probably be just fine,
> so if we scale pixmaps to increments of .5 and if the font rendering issues
> are fixed upstream, this could work nicely.
> 
> I'm still curious what happens in Plasma with this scaling factor, but
> unfortunately plasma-framework didn't build for me with the highdpi branch.
> I'll investigate and report back if there's breakage.
> 
> [1] https://github.com/msorvig/qt5-qtbase-highdpi
> 
> Cheers,

Something I forgot yesterday: this stuff is also on Gerrit [1] as of a few 
days ago.

[1] https://codereview.qt-project.org/#change,86107

Cheers,
-- 
Teo Mrnjavac
http://teom.org | t...@kde.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118254: Plasma-Framework: Add new a shell intrerceptor

[Antonis Tsiapaliokas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118254/
---

(Updated May 27, 2014, 11:27 a.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-framework


Description
---

hello,

This patch adds a new interceptor for our shell packages.
Right now we cannot load an svg if the image is inside the /contents/images of 
the shell package.
So this patch solves that issue.


Diffs
-

  src/plasma/private/packages.cpp fa0fc6a 
  src/plasmaquick/CMakeLists.txt cc5554a 
  src/plasmaquick/shellurlinterceptor.h PRE-CREATION 
  src/plasmaquick/shellurlinterceptor.cpp PRE-CREATION 
  src/plasmaquick/view.cpp 5aa1102 

Diff: https://git.reviewboard.kde.org/r/118254/diff/


Testing
---

*Testing*
org.kde.desktop shell package works without any issue.

*Issues*

The interceptor doesn't return a scheme for the svg component.

PlasmaCore.SvgItem {
svg: PlasmaCore.Svg {
imagePath: "shellpackage:/images/bar.svgz"
}
}

On the above code, the "path.scheme()" from the interceptor never returns
"shellpackage", so it is completely ignored.

But the following one it works

Image {
source: "shellpackage:/images/foo.png"
}


Thanks,

Antonis Tsiapaliokas

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118346: [klipper] Re-enable prison support

[Martin Gräßlin]

> On May 27, 2014, 12:08 p.m., Martin Gräßlin wrote:
> > at the moment this cannot be enabled yet. I have already prepared a similar 
> > change and backed away from it, due to no way to figure out whether prison 
> > is compiled against Qt4 or Qt5.
> > 
> > Further more on Debian based systems the installation of prison for Qt5 is 
> > broken, see https://git.reviewboard.kde.org/r/118291/
> > 
> > This results in the system's prison installation being used and completely 
> > breaking klipper. To solve this I added a version check in my variant, but 
> > that's of course also incomplete.
> 
> Johannes Huber wrote:
> This seems debian/ubuntu specific problem. Works here on Gentoo with 
> prison qt5 build. As this is a optional build option it can be easily 
> disabled downstream.
> 
> * Contents of media-libs/prison-:
> /usr
> /usr/include
> /usr/include/prison
> /usr/include/prison/AbstractBarcode
> /usr/include/prison/BarcodeItem
> /usr/include/prison/BarcodeWidget
> /usr/include/prison/Code39Barcode
> /usr/include/prison/Code93Barcode
> /usr/include/prison/DataMatrixBarcode
> /usr/include/prison/QRCodeBarcode
> /usr/include/prison/abstractbarcode.h
> /usr/include/prison/barcodeitem.h
> /usr/include/prison/barcodewidget.h
> /usr/include/prison/code39barcode.h
> /usr/include/prison/code93barcode.h
> /usr/include/prison/datamatrixbarcode.h
> /usr/include/prison/prison_export.h
> /usr/include/prison/qrcodebarcode.h
> /usr/lib
> /usr/lib/debug
> /usr/lib/debug/usr
> /usr/lib/debug/usr/lib64
> /usr/lib/debug/usr/lib64/libprison.so.0.2.0.debug
> /usr/lib64
> /usr/lib64/cmake
> /usr/lib64/cmake/Prison
> /usr/lib64/cmake/Prison/PrisonConfig.cmake
> /usr/lib64/cmake/Prison/PrisonConfigVersion.cmake
> /usr/lib64/libprison.so -> libprison.so.0
> /usr/lib64/libprison.so.0 -> libprison.so.0.2.0
> /usr/lib64/libprison.so.0.2.0
> 
>
> 
> Martin Gräßlin wrote:
> and what happens if you have both prison for qt4 and qt5 installed? This 
> looks to me like you only have one install of prison.
> 
> I run into this issue on Saturday resulting in the linked review request. 
> To me it looks like prison for Qt 5 has not yet reached a quality that allows 
> it as a dependency.
> 
> Of course it's an optional dependency and can be easily disabled. But it 
> means that anybody not yet having prison/qt5, but having a prison/qt4 will 
> have picked it up automatically and thus breaking klipper. As long as prison 
> doesn't fix that, it's a -2 to me. It's easy to fix in prison: just use a new 
> version number for the Qt5 build.
> 
> Johannes Huber wrote:
> > and what happens if you have both prison for qt4 and qt5 installed?
> 
> 
>  * package media-libs/prison-1.1.1 NOT merged
>  * 
>  * Detected file collision(s):
>  * 
>  *  /usr/include/prison/prison_export.h
>  *  /usr/include/prison/QRCodeBarcode
>  *  /usr/include/prison/qrcodebarcode.h
>  *  /usr/include/prison/DataMatrixBarcode
>  *  /usr/include/prison/datamatrixbarcode.h
>  *  /usr/include/prison/Code93Barcode
>  *  /usr/include/prison/code93barcode.h
>  *  /usr/include/prison/Code39Barcode
>  *  /usr/include/prison/code39barcode.h
>  *  /usr/include/prison/BarcodeWidget
>  *  /usr/include/prison/barcodewidget.h
>  *  /usr/include/prison/BarcodeItem
>  *  /usr/include/prison/barcodeitem.h
>  *  /usr/include/prison/AbstractBarcode
>  *  /usr/include/prison/abstractbarcode.h
>  *  /usr/lib64/cmake/Prison/PrisonConfig.cmake
>  *  /usr/lib64/libprison.so
>  *  /usr/lib64/libprison.so.0
> 
> With the current build system of prison it isn't possible to install 
> prison qt4/qt5 in parallel.
>

> With the current build system of prison it isn't possible to install prison 
> qt4/qt5 in parallel.

sorry, but we get side tracked. The issue is that if Qt 4 version is installed, 
but not the Qt 5 version, the Qt 4 version gets picked and breaks klipper.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118346/#review58547
---


On May 27, 2014, 11:37 a.m., Johannes Huber wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118346/
> ---
> 
> (Updated May 27, 2014, 11:37 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Build option is needed to have prison support.
> 
> 
> Diffs
> -
> 
>   klipper/CMakeLists.txt c700f9e 
> 
> Diff: https:

Re: Review Request 118346: [klipper] Re-enable prison support

[Johannes Huber]

> On May 27, 2014, 12:08 p.m., Martin Gräßlin wrote:
> > at the moment this cannot be enabled yet. I have already prepared a similar 
> > change and backed away from it, due to no way to figure out whether prison 
> > is compiled against Qt4 or Qt5.
> > 
> > Further more on Debian based systems the installation of prison for Qt5 is 
> > broken, see https://git.reviewboard.kde.org/r/118291/
> > 
> > This results in the system's prison installation being used and completely 
> > breaking klipper. To solve this I added a version check in my variant, but 
> > that's of course also incomplete.
> 
> Johannes Huber wrote:
> This seems debian/ubuntu specific problem. Works here on Gentoo with 
> prison qt5 build. As this is a optional build option it can be easily 
> disabled downstream.
> 
> * Contents of media-libs/prison-:
> /usr
> /usr/include
> /usr/include/prison
> /usr/include/prison/AbstractBarcode
> /usr/include/prison/BarcodeItem
> /usr/include/prison/BarcodeWidget
> /usr/include/prison/Code39Barcode
> /usr/include/prison/Code93Barcode
> /usr/include/prison/DataMatrixBarcode
> /usr/include/prison/QRCodeBarcode
> /usr/include/prison/abstractbarcode.h
> /usr/include/prison/barcodeitem.h
> /usr/include/prison/barcodewidget.h
> /usr/include/prison/code39barcode.h
> /usr/include/prison/code93barcode.h
> /usr/include/prison/datamatrixbarcode.h
> /usr/include/prison/prison_export.h
> /usr/include/prison/qrcodebarcode.h
> /usr/lib
> /usr/lib/debug
> /usr/lib/debug/usr
> /usr/lib/debug/usr/lib64
> /usr/lib/debug/usr/lib64/libprison.so.0.2.0.debug
> /usr/lib64
> /usr/lib64/cmake
> /usr/lib64/cmake/Prison
> /usr/lib64/cmake/Prison/PrisonConfig.cmake
> /usr/lib64/cmake/Prison/PrisonConfigVersion.cmake
> /usr/lib64/libprison.so -> libprison.so.0
> /usr/lib64/libprison.so.0 -> libprison.so.0.2.0
> /usr/lib64/libprison.so.0.2.0
> 
>
> 
> Martin Gräßlin wrote:
> and what happens if you have both prison for qt4 and qt5 installed? This 
> looks to me like you only have one install of prison.
> 
> I run into this issue on Saturday resulting in the linked review request. 
> To me it looks like prison for Qt 5 has not yet reached a quality that allows 
> it as a dependency.
> 
> Of course it's an optional dependency and can be easily disabled. But it 
> means that anybody not yet having prison/qt5, but having a prison/qt4 will 
> have picked it up automatically and thus breaking klipper. As long as prison 
> doesn't fix that, it's a -2 to me. It's easy to fix in prison: just use a new 
> version number for the Qt5 build.
> 
> Johannes Huber wrote:
> > and what happens if you have both prison for qt4 and qt5 installed?
> 
> 
>  * package media-libs/prison-1.1.1 NOT merged
>  * 
>  * Detected file collision(s):
>  * 
>  *  /usr/include/prison/prison_export.h
>  *  /usr/include/prison/QRCodeBarcode
>  *  /usr/include/prison/qrcodebarcode.h
>  *  /usr/include/prison/DataMatrixBarcode
>  *  /usr/include/prison/datamatrixbarcode.h
>  *  /usr/include/prison/Code93Barcode
>  *  /usr/include/prison/code93barcode.h
>  *  /usr/include/prison/Code39Barcode
>  *  /usr/include/prison/code39barcode.h
>  *  /usr/include/prison/BarcodeWidget
>  *  /usr/include/prison/barcodewidget.h
>  *  /usr/include/prison/BarcodeItem
>  *  /usr/include/prison/barcodeitem.h
>  *  /usr/include/prison/AbstractBarcode
>  *  /usr/include/prison/abstractbarcode.h
>  *  /usr/lib64/cmake/Prison/PrisonConfig.cmake
>  *  /usr/lib64/libprison.so
>  *  /usr/lib64/libprison.so.0
> 
> With the current build system of prison it isn't possible to install 
> prison qt4/qt5 in parallel.
>
> 
> Martin Gräßlin wrote:
> > With the current build system of prison it isn't possible to install 
> prison qt4/qt5 in parallel.
> 
> sorry, but we get side tracked. The issue is that if Qt 4 version is 
> installed, but not the Qt 5 version, the Qt 4 version gets picked and breaks 
> klipper.

Yes thats an downstream packaging issue of defining the correct version.


- Johannes


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118346/#review58547
---


On May 27, 2014, 11:37 a.m., Johannes Huber wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118346/
> ---
> 
> (Updated May 27, 2014, 11:37 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> 

Re: Review Request 118341: [klipper] Port from KCmdLineArgs to QCommandLineParser

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118341/#review58556
---


This review has been submitted with commit 
3fa16e6844a67c597717da19e15f1858642deaaa by Martin Gräßlin to branch master.

- Commit Hook


On May 27, 2014, 5:43 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118341/
> ---
> 
> (Updated May 27, 2014, 5:43 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Port from KCmdLineArgs to QCommandLineParser
> 
> 
> Diffs
> -
> 
>   klipper/main.cpp 48901bb88ec8097a116d00ba294f349b9419b9d8 
> 
> Diff: https://git.reviewboard.kde.org/r/118341/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118343: [klipper] Port from KMenu to QMenu

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118343/#review58558
---


This review has been submitted with commit 
4718ff36ccb1c75940eae8fe09399250ea446eea by Martin Gräßlin to branch master.

- Commit Hook


On May 27, 2014, 7:31 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118343/
> ---
> 
> (Updated May 27, 2014, 7:31 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Port from KMenu to QMenu
> 
> Note: depending on the widget style this renders a regression as the
> section might not be supported by the style. This is the case for
> Oxygen, see bug 335400.
> 
> 
> Diffs
> -
> 
>   klipper/klipperpopup.h 52e7c4ce38afb211af00a61439e6656e6b542343 
>   klipper/klipperpopup.cpp dc15d03b0b5cdaa65db3d0cad629e2b42cee9852 
>   klipper/popupproxy.h 69e3ddd0fe6d92d9fbef9c07601f912e8ff37346 
>   klipper/popupproxy.cpp 6a1e757c2051d3c25699a5ced5dc75de120bf212 
>   klipper/urlgrabber.h 01a83df2b2a4bd16ed735c7b6c0d12ef63d9aa83 
>   klipper/urlgrabber.cpp 923aa943c5e95d0f24565bf8f286cac13aba0b04 
> 
> Diff: https://git.reviewboard.kde.org/r/118343/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118342: [klipper] Port to new KAboutData

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118342/#review58557
---


This review has been submitted with commit 
461225e400ebb49273b164158183aa5682d4b80e by Martin Gräßlin to branch master.

- Commit Hook


On May 27, 2014, 6:09 a.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118342/
> ---
> 
> (Updated May 27, 2014, 6:09 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Port to new KAboutData
> 
> 
> Diffs
> -
> 
>   klipper/main.cpp 48901bb88ec8097a116d00ba294f349b9419b9d8 
>   klipper/klipper.cpp b41af1e2c5a8de2e997dc82821d35ac69b1bee6d 
>   klipper/klipper.h ad18b66497c43b61c457984b6b92416047962780 
> 
> Diff: https://git.reviewboard.kde.org/r/118342/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118342: [klipper] Port to new KAboutData

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118342/
---

(Updated May 27, 2014, 11:38 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

[klipper] Port to new KAboutData


Diffs
-

  klipper/main.cpp 48901bb88ec8097a116d00ba294f349b9419b9d8 
  klipper/klipper.cpp b41af1e2c5a8de2e997dc82821d35ac69b1bee6d 
  klipper/klipper.h ad18b66497c43b61c457984b6b92416047962780 

Diff: https://git.reviewboard.kde.org/r/118342/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118343: [klipper] Port from KMenu to QMenu

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118343/
---

(Updated May 27, 2014, 11:38 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

[klipper] Port from KMenu to QMenu

Note: depending on the widget style this renders a regression as the
section might not be supported by the style. This is the case for
Oxygen, see bug 335400.


Diffs
-

  klipper/klipperpopup.h 52e7c4ce38afb211af00a61439e6656e6b542343 
  klipper/klipperpopup.cpp dc15d03b0b5cdaa65db3d0cad629e2b42cee9852 
  klipper/popupproxy.h 69e3ddd0fe6d92d9fbef9c07601f912e8ff37346 
  klipper/popupproxy.cpp 6a1e757c2051d3c25699a5ced5dc75de120bf212 
  klipper/urlgrabber.h 01a83df2b2a4bd16ed735c7b6c0d12ef63d9aa83 
  klipper/urlgrabber.cpp 923aa943c5e95d0f24565bf8f286cac13aba0b04 

Diff: https://git.reviewboard.kde.org/r/118343/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118341: [klipper] Port from KCmdLineArgs to QCommandLineParser

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118341/
---

(Updated May 27, 2014, 11:38 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

[klipper] Port from KCmdLineArgs to QCommandLineParser


Diffs
-

  klipper/main.cpp 48901bb88ec8097a116d00ba294f349b9419b9d8 

Diff: https://git.reviewboard.kde.org/r/118341/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118346: [klipper] Re-enable prison support

[Martin Gräßlin]

> On May 27, 2014, 12:08 p.m., Martin Gräßlin wrote:
> > at the moment this cannot be enabled yet. I have already prepared a similar 
> > change and backed away from it, due to no way to figure out whether prison 
> > is compiled against Qt4 or Qt5.
> > 
> > Further more on Debian based systems the installation of prison for Qt5 is 
> > broken, see https://git.reviewboard.kde.org/r/118291/
> > 
> > This results in the system's prison installation being used and completely 
> > breaking klipper. To solve this I added a version check in my variant, but 
> > that's of course also incomplete.
> 
> Johannes Huber wrote:
> This seems debian/ubuntu specific problem. Works here on Gentoo with 
> prison qt5 build. As this is a optional build option it can be easily 
> disabled downstream.
> 
> * Contents of media-libs/prison-:
> /usr
> /usr/include
> /usr/include/prison
> /usr/include/prison/AbstractBarcode
> /usr/include/prison/BarcodeItem
> /usr/include/prison/BarcodeWidget
> /usr/include/prison/Code39Barcode
> /usr/include/prison/Code93Barcode
> /usr/include/prison/DataMatrixBarcode
> /usr/include/prison/QRCodeBarcode
> /usr/include/prison/abstractbarcode.h
> /usr/include/prison/barcodeitem.h
> /usr/include/prison/barcodewidget.h
> /usr/include/prison/code39barcode.h
> /usr/include/prison/code93barcode.h
> /usr/include/prison/datamatrixbarcode.h
> /usr/include/prison/prison_export.h
> /usr/include/prison/qrcodebarcode.h
> /usr/lib
> /usr/lib/debug
> /usr/lib/debug/usr
> /usr/lib/debug/usr/lib64
> /usr/lib/debug/usr/lib64/libprison.so.0.2.0.debug
> /usr/lib64
> /usr/lib64/cmake
> /usr/lib64/cmake/Prison
> /usr/lib64/cmake/Prison/PrisonConfig.cmake
> /usr/lib64/cmake/Prison/PrisonConfigVersion.cmake
> /usr/lib64/libprison.so -> libprison.so.0
> /usr/lib64/libprison.so.0 -> libprison.so.0.2.0
> /usr/lib64/libprison.so.0.2.0
> 
>
> 
> Martin Gräßlin wrote:
> and what happens if you have both prison for qt4 and qt5 installed? This 
> looks to me like you only have one install of prison.
> 
> I run into this issue on Saturday resulting in the linked review request. 
> To me it looks like prison for Qt 5 has not yet reached a quality that allows 
> it as a dependency.
> 
> Of course it's an optional dependency and can be easily disabled. But it 
> means that anybody not yet having prison/qt5, but having a prison/qt4 will 
> have picked it up automatically and thus breaking klipper. As long as prison 
> doesn't fix that, it's a -2 to me. It's easy to fix in prison: just use a new 
> version number for the Qt5 build.
> 
> Johannes Huber wrote:
> > and what happens if you have both prison for qt4 and qt5 installed?
> 
> 
>  * package media-libs/prison-1.1.1 NOT merged
>  * 
>  * Detected file collision(s):
>  * 
>  *  /usr/include/prison/prison_export.h
>  *  /usr/include/prison/QRCodeBarcode
>  *  /usr/include/prison/qrcodebarcode.h
>  *  /usr/include/prison/DataMatrixBarcode
>  *  /usr/include/prison/datamatrixbarcode.h
>  *  /usr/include/prison/Code93Barcode
>  *  /usr/include/prison/code93barcode.h
>  *  /usr/include/prison/Code39Barcode
>  *  /usr/include/prison/code39barcode.h
>  *  /usr/include/prison/BarcodeWidget
>  *  /usr/include/prison/barcodewidget.h
>  *  /usr/include/prison/BarcodeItem
>  *  /usr/include/prison/barcodeitem.h
>  *  /usr/include/prison/AbstractBarcode
>  *  /usr/include/prison/abstractbarcode.h
>  *  /usr/lib64/cmake/Prison/PrisonConfig.cmake
>  *  /usr/lib64/libprison.so
>  *  /usr/lib64/libprison.so.0
> 
> With the current build system of prison it isn't possible to install 
> prison qt4/qt5 in parallel.
>
> 
> Martin Gräßlin wrote:
> > With the current build system of prison it isn't possible to install 
> prison qt4/qt5 in parallel.
> 
> sorry, but we get side tracked. The issue is that if Qt 4 version is 
> installed, but not the Qt 5 version, the Qt 4 version gets picked and breaks 
> klipper.
> 
> Johannes Huber wrote:
> Yes thats an downstream packaging issue of defining the correct version.

no that is NOT a packaging issue. If one has the Qt4 version installed it gets 
picked. No matter whether you have a Qt5 version installed or not.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118346/#review58547
---


On May 27, 2014, 11:37 a.m., Johannes Huber wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118346/
> -

Re: Review Request 118346: [klipper] Re-enable prison support

[Johannes Huber]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118346/
---

(Updated May 27, 2014, 1:45 p.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-workspace


Description
---

Build option is needed to have prison support.


Diffs
-

  klipper/CMakeLists.txt c700f9e 

Diff: https://git.reviewboard.kde.org/r/118346/diff/


Testing
---

Compiled with and without prison support. 


Thanks,

Johannes Huber

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118347/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

[klipper] Port from KIntSpinBox to QSpinBox

Unfortunately this way we cannot have a plural aware suffix.


Diffs
-

  klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be 
  klipper/generalconfig.ui f0145752eb2dbd927392b682b6472695c793a588 

Diff: https://git.reviewboard.kde.org/r/118347/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118348: [klipper] Port KSaveFile -> QSaveFile

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118348/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

[klipper] Port KSaveFile -> QSaveFile


Diffs
-

  klipper/klipper.cpp 506739d4aabcc540ffbeb3ec064387c72db36c0d 

Diff: https://git.reviewboard.kde.org/r/118348/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118351: [klipper] Port from KDialog to QDialog

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118351/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

[klipper] Port from KDialog to QDialog


Diffs
-

  klipper/urlgrabber.cpp 2cc2e5a01e85afea3a32b4f03eaabcce8addfe5c 
  klipper/klipper.cpp 506739d4aabcc540ffbeb3ec064387c72db36c0d 
  klipper/editactiondialog.cpp 4b8fc0c837be0c7ebddd534b3d7676991fbfd796 
  klipper/editactiondialog.h be564f83617253182d622f918a1352001775d77a 
  klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be 

Diff: https://git.reviewboard.kde.org/r/118351/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/#review58565
---


Makes sense, do we know why they used to be -1?


- Aleix Pol Gonzalez


On May 27, 2014, 9:42 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118337/
> ---
> 
> (Updated May 27, 2014, 9:42 a.m.)
> 
> 
> Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas 
> Pfeiffer.
> 
> 
> Repository: oxygen
> 
> 
> Description
> ---
> 
> 
> PM_DefaultLayoutSpacing is deprecated and replaced by both
> PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.
> 
> Qt Layouts now query for these, not the default spacing.
> 
> See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum
> 
> There are some other deprecated enums, which are mostly not a problem.
> 
> 
> Diffs
> -
> 
>   kstyle/oxygenstyle.cpp 8bcb79a 
> 
> Diff: https://git.reviewboard.kde.org/r/118337/diff/
> 
> 
> Testing
> ---
> 
> Spacing between labels and controls is now restored o/
> 
> 
> File Attachments
> 
> 
> compositing_kcm
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[David Edmundson]

> On May 27, 2014, 1:11 p.m., Aleix Pol Gonzalez wrote:
> > Makes sense, do we know why they used to be -1?
> >

If negative it would go into combinedLayoutSpacing which we don't implement.
Which would in turn use the (now deprecated) defaultLayoutSpacing


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/#review58565
---


On May 27, 2014, 9:42 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118337/
> ---
> 
> (Updated May 27, 2014, 9:42 a.m.)
> 
> 
> Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas 
> Pfeiffer.
> 
> 
> Repository: oxygen
> 
> 
> Description
> ---
> 
> 
> PM_DefaultLayoutSpacing is deprecated and replaced by both
> PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.
> 
> Qt Layouts now query for these, not the default spacing.
> 
> See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum
> 
> There are some other deprecated enums, which are mostly not a problem.
> 
> 
> Diffs
> -
> 
>   kstyle/oxygenstyle.cpp 8bcb79a 
> 
> Diff: https://git.reviewboard.kde.org/r/118337/diff/
> 
> 
> Testing
> ---
> 
> Spacing between labels and controls is now restored o/
> 
> 
> File Attachments
> 
> 
> compositing_kcm
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118347/#review58567
---


> Unfortunately this way we cannot have a plural aware suffix.

What if you do this from code like "setSuffix(i18np("signular", "plural", 
value));" ?

- Martin Klapetek


On May 27, 2014, 2:04 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118347/
> ---
> 
> (Updated May 27, 2014, 2:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Port from KIntSpinBox to QSpinBox
> 
> Unfortunately this way we cannot have a plural aware suffix.
> 
> 
> Diffs
> -
> 
>   klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be 
>   klipper/generalconfig.ui f0145752eb2dbd927392b682b6472695c793a588 
> 
> Diff: https://git.reviewboard.kde.org/r/118347/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

[Martin Klapetek]

> On May 27, 2014, 3:52 p.m., Martin Klapetek wrote:
> > > Unfortunately this way we cannot have a plural aware suffix.
> > 
> > What if you do this from code like "setSuffix(i18np("signular", "plural", 
> > value));" ?

Oh but that's not a binding so it won't auto update...too much time in QML xD

Nevermind.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118347/#review58567
---


On May 27, 2014, 2:04 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118347/
> ---
> 
> (Updated May 27, 2014, 2:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Port from KIntSpinBox to QSpinBox
> 
> Unfortunately this way we cannot have a plural aware suffix.
> 
> 
> Diffs
> -
> 
>   klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be 
>   klipper/generalconfig.ui f0145752eb2dbd927392b682b6472695c793a588 
> 
> Diff: https://git.reviewboard.kde.org/r/118347/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118347: [klipper] Port from KIntSpinBox to QSpinBox

[Martin Gräßlin]

> On May 27, 2014, 3:52 p.m., Martin Klapetek wrote:
> > > Unfortunately this way we cannot have a plural aware suffix.
> > 
> > What if you do this from code like "setSuffix(i18np("signular", "plural", 
> > value));" ?
> 
> Martin Klapetek wrote:
> Oh but that's not a binding so it won't auto update...too much time in 
> QML xD
> 
> Nevermind.

I hoped there is a better solution, which I'm just not aware of :-) It would 
need a connect to update the suffix whenever the value changes, which was the 
reason I didn't implement that one.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118347/#review58567
---


On May 27, 2014, 2:04 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118347/
> ---
> 
> (Updated May 27, 2014, 2:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Port from KIntSpinBox to QSpinBox
> 
> Unfortunately this way we cannot have a plural aware suffix.
> 
> 
> Diffs
> -
> 
>   klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be 
>   klipper/generalconfig.ui f0145752eb2dbd927392b682b6472695c793a588 
> 
> Diff: https://git.reviewboard.kde.org/r/118347/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [RFC] Which icon to use for kwin's killer helper

[Aleix Pol]

On Tue, May 27, 2014 at 3:37 PM, Martin Gräßlin  wrote:

> Hi all,
>
> I'm currently considering whether we should change the window icon used in
> KWin's killer helper (the dialog which gets shown when trying to close a
> hung
> window).
>
> Attached are three variants.
> 1. killer-current.png: that's the current state using the kwin icon. This
> icon
> is nowhere else used
> 2. killer-edit-bomb.png: this uses the same icon as on the button which
> will
> kill the window
> 3. killer-window-icon.png: this tries to get the icon from the hung window
> and
> uses it
>
> Variant 3 would create a stronger connection between the hung window and
> the
> killer. But it might also look like it's coming from the window and not
> from
> the system.
>
> So what do you all think and recommend.
>
> Cheers
> Martin
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
Do we really need an icon there?

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/#review58575
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On May 27, 2014, 9:42 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118337/
> ---
> 
> (Updated May 27, 2014, 9:42 a.m.)
> 
> 
> Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas 
> Pfeiffer.
> 
> 
> Repository: oxygen
> 
> 
> Description
> ---
> 
> 
> PM_DefaultLayoutSpacing is deprecated and replaced by both
> PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.
> 
> Qt Layouts now query for these, not the default spacing.
> 
> See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum
> 
> There are some other deprecated enums, which are mostly not a problem.
> 
> 
> Diffs
> -
> 
>   kstyle/oxygenstyle.cpp 8bcb79a 
> 
> Diff: https://git.reviewboard.kde.org/r/118337/diff/
> 
> 
> Testing
> ---
> 
> Spacing between labels and controls is now restored o/
> 
> 
> File Attachments
> 
> 
> compositing_kcm
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118351: [klipper] Port from KDialog to QDialog

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118351/#review58577
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On May 27, 2014, 12:59 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118351/
> ---
> 
> (Updated May 27, 2014, 12:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Port from KDialog to QDialog
> 
> 
> Diffs
> -
> 
>   klipper/urlgrabber.cpp 2cc2e5a01e85afea3a32b4f03eaabcce8addfe5c 
>   klipper/klipper.cpp 506739d4aabcc540ffbeb3ec064387c72db36c0d 
>   klipper/editactiondialog.cpp 4b8fc0c837be0c7ebddd534b3d7676991fbfd796 
>   klipper/editactiondialog.h be564f83617253182d622f918a1352001775d77a 
>   klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be 
> 
> Diff: https://git.reviewboard.kde.org/r/118351/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118348: [klipper] Port KSaveFile -> QSaveFile

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118348/#review58578
---

Ship it!


Ship It!

- Aleix Pol Gonzalez


On May 27, 2014, 12:11 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118348/
> ---
> 
> (Updated May 27, 2014, 12:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Port KSaveFile -> QSaveFile
> 
> 
> Diffs
> -
> 
>   klipper/klipper.cpp 506739d4aabcc540ffbeb3ec064387c72db36c0d 
> 
> Diff: https://git.reviewboard.kde.org/r/118348/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [RFC] Which icon to use for kwin's killer helper

[Thomas Lübking]

bomb, cashew - or ask nuno ;-)

the kwin icon looks dull and has no meaning to the user.
i don't like using the hung app icon - the icon shows up in the taskbar as
well and creates a wrong idea about the source of the dialog (it feels odd
that a process would detect that it does no more respond and instead of
maybe just fixing that, shows a -responsive- dialog that offers suicide.

thomas being sorry for top posting

Am Dienstag, 27. Mai 2014 schrieb Martin Gräßlin :
> Hi all,
>
> I'm currently considering whether we should change the window icon used in
> KWin's killer helper (the dialog which gets shown when trying to close a
hung
> window).
>
> Attached are three variants.
> 1. killer-current.png: that's the current state using the kwin icon. This
icon
> is nowhere else used
> 2. killer-edit-bomb.png: this uses the same icon as on the button which
will
> kill the window
> 3. killer-window-icon.png: this tries to get the icon from the hung
window and
> uses it
>
> Variant 3 would create a stronger connection between the hung window and
the
> killer. But it might also look like it's coming from the window and not
from
> the system.
>
> So what do you all think and recommend.
>
> Cheers
> Martin
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: [RFC] Which icon to use for kwin's killer helper

[Martin Gräßlin]

On Tuesday 27 May 2014 16:21:11 Aleix Pol wrote:
> On Tue, May 27, 2014 at 3:37 PM, Martin Gräßlin  wrote:
> > Hi all,
> > 
> > I'm currently considering whether we should change the window icon used in
> > KWin's killer helper (the dialog which gets shown when trying to close a
> > hung
> > window).
> > 
> > Attached are three variants.
> > 1. killer-current.png: that's the current state using the kwin icon. This
> > icon
> > is nowhere else used
> > 2. killer-edit-bomb.png: this uses the same icon as on the button which
> > will
> > kill the window
> > 3. killer-window-icon.png: this tries to get the icon from the hung window
> > and
> > uses it
> > 
> > Variant 3 would create a stronger connection between the hung window and
> > the
> > killer. But it might also look like it's coming from the window and not
> > from
> > the system.
> > 
> > So what do you all think and recommend.
> > 
> > Cheers
> > Martin
> > ___
> > Plasma-devel mailing list
> > Plasma-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/plasma-devel
> 
> Do we really need an icon there?

yes we need an icon as otherwise the generic xorg icon gets picked. There is 
no option "no icon", every window has an icon.

Cheers
Martin


signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build became unstable: plasma-workspace_master_qt5 #288

[KDE CI System]

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: [RFC] Which icon to use for kwin's killer helper

[Aleix Pol]

On Tue, May 27, 2014 at 4:55 PM, Martin Gräßlin  wrote:

> On Tuesday 27 May 2014 16:21:11 Aleix Pol wrote:
> > On Tue, May 27, 2014 at 3:37 PM, Martin Gräßlin 
> wrote:
> > > Hi all,
> > >
> > > I'm currently considering whether we should change the window icon
> used in
> > > KWin's killer helper (the dialog which gets shown when trying to close
> a
> > > hung
> > > window).
> > >
> > > Attached are three variants.
> > > 1. killer-current.png: that's the current state using the kwin icon.
> This
> > > icon
> > > is nowhere else used
> > > 2. killer-edit-bomb.png: this uses the same icon as on the button which
> > > will
> > > kill the window
> > > 3. killer-window-icon.png: this tries to get the icon from the hung
> window
> > > and
> > > uses it
> > >
> > > Variant 3 would create a stronger connection between the hung window
> and
> > > the
> > > killer. But it might also look like it's coming from the window and not
> > > from
> > > the system.
> > >
> > > So what do you all think and recommend.
> > >
> > > Cheers
> > > Martin
> > > ___
> > > Plasma-devel mailing list
> > > Plasma-devel@kde.org
> > > https://mail.kde.org/mailman/listinfo/plasma-devel
> >
> > Do we really need an icon there?
>
> yes we need an icon as otherwise the generic xorg icon gets picked. There
> is
> no option "no icon", every window has an icon.
>
> Cheers
> Martin
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
Then just leave the bomb? We probably have more important issues than this.

Aleix
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118357: Disable the agenda part of the calendar

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118357/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

As agreed on irc (someday ago), the agenda part is useless until there's a 
proper agenda backend and should just be hidden. Here's a patch simply hiding 
the left part - it's easier to do just "visible: false" than comment it out and 
then comment out/remove all the lines referencing parts of the agenda, also 
cleaner.

I added a big comment at the file beginning, I'll fill the commit sha after 
committing so it can be easily reverted (the comment will be separate commit).

Screenshot attached.

Oh and you might want to remove the clock from panel and readd it/remove plasma 
config as the popup size seems to be saved and so after this patch you may 
still get the original-sized half-empty dialog.


Diffs
-

  applets/digital-clock/package/contents/ui/CalendarView.qml 43812a4 

Diff: https://git.reviewboard.kde.org/r/118357/diff/


Testing
---


File Attachments


Calendar without agenda
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/84880c21-1367-4d48-88db-7747553c40f5__plasma_cal1.png


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Jenkins build is back to stable : plasma-workspace_master_qt5 #289

[KDE CI System]

See 

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[Andrew Lake]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/#review58586
---

Ship it!


Ship It!

- Andrew Lake


On May 27, 2014, 9:42 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118337/
> ---
> 
> (Updated May 27, 2014, 9:42 a.m.)
> 
> 
> Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas 
> Pfeiffer.
> 
> 
> Repository: oxygen
> 
> 
> Description
> ---
> 
> 
> PM_DefaultLayoutSpacing is deprecated and replaced by both
> PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.
> 
> Qt Layouts now query for these, not the default spacing.
> 
> See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum
> 
> There are some other deprecated enums, which are mostly not a problem.
> 
> 
> Diffs
> -
> 
>   kstyle/oxygenstyle.cpp 8bcb79a 
> 
> Diff: https://git.reviewboard.kde.org/r/118337/diff/
> 
> 
> Testing
> ---
> 
> Spacing between labels and controls is now restored o/
> 
> 
> File Attachments
> 
> 
> compositing_kcm
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[Andrew Lake]

> On May 27, 2014, 4:12 p.m., Andrew Lake wrote:
> > Ship It!

In case anyone is wondering why this arbitrary fellow said "Ship It!", I just 
wanted to provide an explicit thumbs up that this matches the 4px spacing basis 
grid recommended in the HIG 
(http://techbase.kde.org/Projects/Usability/HIG/Placement#Space), so yay! We 
can tackle individual layout designs separately to get the spacing even better.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/#review58586
---


On May 27, 2014, 9:42 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118337/
> ---
> 
> (Updated May 27, 2014, 9:42 a.m.)
> 
> 
> Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas 
> Pfeiffer.
> 
> 
> Repository: oxygen
> 
> 
> Description
> ---
> 
> 
> PM_DefaultLayoutSpacing is deprecated and replaced by both
> PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.
> 
> Qt Layouts now query for these, not the default spacing.
> 
> See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum
> 
> There are some other deprecated enums, which are mostly not a problem.
> 
> 
> Diffs
> -
> 
>   kstyle/oxygenstyle.cpp 8bcb79a 
> 
> Diff: https://git.reviewboard.kde.org/r/118337/diff/
> 
> 
> Testing
> ---
> 
> Spacing between labels and controls is now restored o/
> 
> 
> File Attachments
> 
> 
> compositing_kcm
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Re: [RFC] Which icon to use for kwin's killer helper

[Andrew Lake]

I suggest just using the same icon as used on the "Terminate Application
[foobar]" button. Terminating the application is the primary function of
that dialog and I struggle to identify the information value of using a
different visual metaphor for the window icon.

Hope that helps!
Andrew


On Tue, May 27, 2014 at 7:55 AM, Martin Gräßlin  wrote:

> On Tuesday 27 May 2014 16:21:11 Aleix Pol wrote:
> > On Tue, May 27, 2014 at 3:37 PM, Martin Gräßlin 
> wrote:
> > > Hi all,
> > >
> > > I'm currently considering whether we should change the window icon
> used in
> > > KWin's killer helper (the dialog which gets shown when trying to close
> a
> > > hung
> > > window).
> > >
> > > Attached are three variants.
> > > 1. killer-current.png: that's the current state using the kwin icon.
> This
> > > icon
> > > is nowhere else used
> > > 2. killer-edit-bomb.png: this uses the same icon as on the button which
> > > will
> > > kill the window
> > > 3. killer-window-icon.png: this tries to get the icon from the hung
> window
> > > and
> > > uses it
> > >
> > > Variant 3 would create a stronger connection between the hung window
> and
> > > the
> > > killer. But it might also look like it's coming from the window and not
> > > from
> > > the system.
> > >
> > > So what do you all think and recommend.
> > >
> > > Cheers
> > > Martin
> > > ___
> > > Plasma-devel mailing list
> > > Plasma-devel@kde.org
> > > https://mail.kde.org/mailman/listinfo/plasma-devel
> >
> > Do we really need an icon there?
>
> yes we need an icon as otherwise the generic xorg icon gets picked. There
> is
> no option "no icon", every window has an icon.
>
> Cheers
> Martin
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118357: Disable the agenda part of the calendar

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118357/#review58588
---


I agree it makes sense, +1. Not adding "ship it" because the original authors 
might have comments.

- Aleix Pol Gonzalez


On May 27, 2014, 4 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118357/
> ---
> 
> (Updated May 27, 2014, 4 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> As agreed on irc (someday ago), the agenda part is useless until there's a 
> proper agenda backend and should just be hidden. Here's a patch simply hiding 
> the left part - it's easier to do just "visible: false" than comment it out 
> and then comment out/remove all the lines referencing parts of the agenda, 
> also cleaner.
> 
> I added a big comment at the file beginning, I'll fill the commit sha after 
> committing so it can be easily reverted (the comment will be separate commit).
> 
> Screenshot attached.
> 
> Oh and you might want to remove the clock from panel and readd it/remove 
> plasma config as the popup size seems to be saved and so after this patch you 
> may still get the original-sized half-empty dialog.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/package/contents/ui/CalendarView.qml 43812a4 
> 
> Diff: https://git.reviewboard.kde.org/r/118357/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Calendar without agenda
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/84880c21-1367-4d48-88db-7747553c40f5__plasma_cal1.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118348: [klipper] Port KSaveFile -> QSaveFile

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118348/
---

(Updated May 27, 2014, 4:48 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

[klipper] Port KSaveFile -> QSaveFile


Diffs
-

  klipper/klipper.cpp 506739d4aabcc540ffbeb3ec064387c72db36c0d 

Diff: https://git.reviewboard.kde.org/r/118348/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118348: [klipper] Port KSaveFile -> QSaveFile

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118348/#review58591
---


This review has been submitted with commit 
9103dcfa446ef92944a9081dce5cf02f8cba2f33 by Martin Gräßlin to branch master.

- Commit Hook


On May 27, 2014, 12:11 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118348/
> ---
> 
> (Updated May 27, 2014, 12:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Port KSaveFile -> QSaveFile
> 
> 
> Diffs
> -
> 
>   klipper/klipper.cpp 506739d4aabcc540ffbeb3ec064387c72db36c0d 
> 
> Diff: https://git.reviewboard.kde.org/r/118348/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118351: [klipper] Port from KDialog to QDialog

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118351/#review58590
---


This review has been submitted with commit 
3e96409fbb2ca2d5711505050dede93e599be49a by Martin Gräßlin to branch master.

- Commit Hook


On May 27, 2014, 12:59 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118351/
> ---
> 
> (Updated May 27, 2014, 12:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Port from KDialog to QDialog
> 
> 
> Diffs
> -
> 
>   klipper/urlgrabber.cpp 2cc2e5a01e85afea3a32b4f03eaabcce8addfe5c 
>   klipper/klipper.cpp 506739d4aabcc540ffbeb3ec064387c72db36c0d 
>   klipper/editactiondialog.cpp 4b8fc0c837be0c7ebddd534b3d7676991fbfd796 
>   klipper/editactiondialog.h be564f83617253182d622f918a1352001775d77a 
>   klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be 
> 
> Diff: https://git.reviewboard.kde.org/r/118351/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118351: [klipper] Port from KDialog to QDialog

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118351/
---

(Updated May 27, 2014, 4:48 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma.


Repository: plasma-workspace


Description
---

[klipper] Port from KDialog to QDialog


Diffs
-

  klipper/urlgrabber.cpp 2cc2e5a01e85afea3a32b4f03eaabcce8addfe5c 
  klipper/klipper.cpp 506739d4aabcc540ffbeb3ec064387c72db36c0d 
  klipper/editactiondialog.cpp 4b8fc0c837be0c7ebddd534b3d7676991fbfd796 
  klipper/editactiondialog.h be564f83617253182d622f918a1352001775d77a 
  klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be 

Diff: https://git.reviewboard.kde.org/r/118351/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118351: [klipper] Port from KDialog to QDialog

[Ömer Fadıl Usta]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118351/#review58592
---



klipper/klipper.cpp


is this a forgotten KDialog or on purpose ?


- Ömer Fadıl Usta


On May 27, 2014, 7:48 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118351/
> ---
> 
> (Updated May 27, 2014, 7:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Port from KDialog to QDialog
> 
> 
> Diffs
> -
> 
>   klipper/urlgrabber.cpp 2cc2e5a01e85afea3a32b4f03eaabcce8addfe5c 
>   klipper/klipper.cpp 506739d4aabcc540ffbeb3ec064387c72db36c0d 
>   klipper/editactiondialog.cpp 4b8fc0c837be0c7ebddd534b3d7676991fbfd796 
>   klipper/editactiondialog.h be564f83617253182d622f918a1352001775d77a 
>   klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be 
> 
> Diff: https://git.reviewboard.kde.org/r/118351/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118351: [klipper] Port from KDialog to QDialog

[Martin Gräßlin]

> On May 27, 2014, 7:10 p.m., Ömer Fadıl Usta wrote:
> > klipper/klipper.cpp, line 888
> > 
> >
> > is this a forgotten KDialog or on purpose ?

it's on purpose. This is currently dead code (see the #ifdef HAVE_PRISON), thus 
I am not able to test it and refuse to do a blind port without testing ;-)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118351/#review58592
---


On May 27, 2014, 6:48 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118351/
> ---
> 
> (Updated May 27, 2014, 6:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> [klipper] Port from KDialog to QDialog
> 
> 
> Diffs
> -
> 
>   klipper/urlgrabber.cpp 2cc2e5a01e85afea3a32b4f03eaabcce8addfe5c 
>   klipper/klipper.cpp 506739d4aabcc540ffbeb3ec064387c72db36c0d 
>   klipper/editactiondialog.cpp 4b8fc0c837be0c7ebddd534b3d7676991fbfd796 
>   klipper/editactiondialog.h be564f83617253182d622f918a1352001775d77a 
>   klipper/configdialog.cpp 15901992db8d6fe28d800c4a18a3a6529cace1be 
> 
> Diff: https://git.reviewboard.kde.org/r/118351/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 105312: Add missing email addresses back into add widget tooltip.

[Matthew Dawson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/105312/
---

(Updated May 27, 2014, 2:27 p.m.)


Status
--

This change has been discarded.


Review request for Plasma, Ivan Čukić and Marco Martin.


Repository: kde-workspace


Description
---

When the QML port of the add widget dialog occured, the creator's email address 
got chopped off.  This commit fixes a bug hidding the email address, and also 
starts displaying it again in the tooltip.

There are a couple of issue left with this patch:
1) I have to disable wrapping, otherwise the text wraps at odd points for no 
reason (it fits fine otherwise).
2) The link currently doesn't work as I'm not sure how to hook it up to send 
mail.  Should it be left as is, or just remove the link for 4.9 and update with 
a link for 4.10?


Diffs
-

  libs/plasmagenericshell/widgetsexplorer/package/contents/ui/Tooltip.qml 
ba804fd006496ee4a7118e97fe44038f0617eec7 
  libs/plasmagenericshell/widgetsexplorer/plasmaappletitemmodel_p.h 
e745ef58533ab0e22d2109d5beeff6c29c4d18b4 

Diff: https://git.reviewboard.kde.org/r/105312/diff/


Testing
---

Tested locally in Xephyr.  The tooltip now contains the email address.


Thanks,

Matthew Dawson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118361: Don't hide Dialog when opening QMenu from it

[Martin Klapetek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118361/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

When plasmoid in a popup is opening a QMenu, the popup itself hides because it 
looses focus. This patch fixes it.


Diffs
-

  src/plasmaquick/dialog.cpp d8e263c 

Diff: https://git.reviewboard.kde.org/r/118361/diff/


Testing
---


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[Christoph Feck]

> On May 27, 2014, 4:12 p.m., Andrew Lake wrote:
> > Ship It!
> 
> Andrew Lake wrote:
> In case anyone is wondering why this arbitrary fellow said "Ship It!", I 
> just wanted to provide an explicit thumbs up that this matches the 4px 
> spacing basis grid recommended in the HIG 
> (http://techbase.kde.org/Projects/Usability/HIG/Placement#Space), so yay! We 
> can tackle individual layout designs separately to get the spacing even 
> better.

I hope no HIG ever suggest a fixed amount of pixels, but an amount relative to 
the font size.


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/#review58586
---


On May 27, 2014, 9:42 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118337/
> ---
> 
> (Updated May 27, 2014, 9:42 a.m.)
> 
> 
> Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas 
> Pfeiffer.
> 
> 
> Repository: oxygen
> 
> 
> Description
> ---
> 
> 
> PM_DefaultLayoutSpacing is deprecated and replaced by both
> PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.
> 
> Qt Layouts now query for these, not the default spacing.
> 
> See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum
> 
> There are some other deprecated enums, which are mostly not a problem.
> 
> 
> Diffs
> -
> 
>   kstyle/oxygenstyle.cpp 8bcb79a 
> 
> Diff: https://git.reviewboard.kde.org/r/118337/diff/
> 
> 
> Testing
> ---
> 
> Spacing between labels and controls is now restored o/
> 
> 
> File Attachments
> 
> 
> compositing_kcm
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[Andrew Lake]

> On May 27, 2014, 4:12 p.m., Andrew Lake wrote:
> > Ship It!
> 
> Andrew Lake wrote:
> In case anyone is wondering why this arbitrary fellow said "Ship It!", I 
> just wanted to provide an explicit thumbs up that this matches the 4px 
> spacing basis grid recommended in the HIG 
> (http://techbase.kde.org/Projects/Usability/HIG/Placement#Space), so yay! We 
> can tackle individual layout designs separately to get the spacing even 
> better.
> 
> Christoph Feck wrote:
> I hope no HIG ever suggest a fixed amount of pixels, but an amount 
> relative to the font size.

Till we get a credible resolution-independent approach to laying out all visual 
elements, including typeface, pixels is probably the best guidance guidance we 
can come up with.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/#review58586
---


On May 27, 2014, 9:42 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118337/
> ---
> 
> (Updated May 27, 2014, 9:42 a.m.)
> 
> 
> Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas 
> Pfeiffer.
> 
> 
> Repository: oxygen
> 
> 
> Description
> ---
> 
> 
> PM_DefaultLayoutSpacing is deprecated and replaced by both
> PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.
> 
> Qt Layouts now query for these, not the default spacing.
> 
> See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum
> 
> There are some other deprecated enums, which are mostly not a problem.
> 
> 
> Diffs
> -
> 
>   kstyle/oxygenstyle.cpp 8bcb79a 
> 
> Diff: https://git.reviewboard.kde.org/r/118337/diff/
> 
> 
> Testing
> ---
> 
> Spacing between labels and controls is now restored o/
> 
> 
> File Attachments
> 
> 
> compositing_kcm
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118361: Don't hide Dialog when opening QMenu from it

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118361/#review58609
---



src/plasmaquick/dialog.cpp


Isn't comparison more efficient using QLatin1String?


- Kai Uwe Broulik


On May 27, 2014, 7:13 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118361/
> ---
> 
> (Updated May 27, 2014, 7:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> When plasmoid in a popup is opening a QMenu, the popup itself hides because 
> it looses focus. This patch fixes it.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/dialog.cpp d8e263c 
> 
> Diff: https://git.reviewboard.kde.org/r/118361/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117954: Port keditfiletype away from kde4support

[David Faure]

> On May 20, 2014, 3:08 p.m., Alexander Potashev wrote:
> > You probably need to check in CMakeLists.txt that version of 
> > shared-mime-info is at least 0.40.
> 
> Aurélien Gâteau wrote:
> shared-mime-info is only required at run time so I am not sure it makes 
> sense to check at build time. Furthermore, 0.40 was released in June 2008, so 
> I think it is safe to assume the installed version is at least 0.40.
> 
> Alexander Potashev wrote:
> If you don't add it as build-time dependency, then it needs to be checked 
> at run-time like it was done before this patch. I understand it is unlikely 
> that someone uses KF5-based software and shared-mime-info <0.40 concurrently, 
> but I guess it is still possible.
> 
> Aurélien Gâteau wrote:
> Building keditfiletype with shared-mime-info < 0.40 sounds very unlikely: 
> it might not even be possible to build KF5 with a compiler from 2008. Anyway, 
> I added David to this review so he can weight in, as he is more familiar than 
> I am with shared-mime-info.

kcoreaddons already requires shared-mime-info >= 0.70.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117954/#review58199
---


On May 23, 2014, 8:45 a.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117954/
> ---
> 
> (Updated May 23, 2014, 8:45 a.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> ---
> 
> This patch contains multiple commits, which I can make available if needed. 
> It ports keditfiletype away from kde4support, which helps identifying its 
> dependencies so that it can hopefully be moved closer to the classes which 
> need it in frameworks (right now kwidgetsaddons and kio forks it)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt d62ee8b 
>   keditfiletype/CMakeLists.txt 566e76a 
>   keditfiletype/filegroupdetails.cpp c733ba4 
>   keditfiletype/filetypedetails.h 7c0abb4 
>   keditfiletype/filetypedetails.cpp bfcbb07 
>   keditfiletype/filetypesview.h 82fd0ab 
>   keditfiletype/filetypesview.cpp 886892f 
>   keditfiletype/keditfiletype.h 0b235ce 
>   keditfiletype/keditfiletype.cpp aab0830 
>   keditfiletype/kservicelistwidget.h c817d24 
>   keditfiletype/kservicelistwidget.cpp 88dface 
>   keditfiletype/kserviceselectdlg.h 8e6d0d0 
>   keditfiletype/kserviceselectdlg.cpp 09c7c5d 
>   keditfiletype/mimetypedata.h 042b043 
>   keditfiletype/mimetypedata.cpp 057113f 
>   keditfiletype/mimetypewriter.h 5a618a6 
>   keditfiletype/mimetypewriter.cpp be5e5d4 
>   keditfiletype/newtypedlg.h fba8385 
>   keditfiletype/newtypedlg.cpp c933a8f 
>   keditfiletype/sharedmimeinfoversion.h 9824d7b 
>   keditfiletype/sharedmimeinfoversion.cpp 9dabf0e 
>   keditfiletype/tests/CMakeLists.txt 489bb4d 
>   keditfiletype/tests/filetypestest.cpp 68eef26 
>   keditfiletype/typeslistitem.h 05e425a 
>   keditfiletype/typeslistitem.cpp 97cd3c1 
> 
> Diff: https://git.reviewboard.kde.org/r/117954/diff/
> 
> 
> Testing
> ---
> 
> Program starts and looks like it behaves correctly. Unit-test is failing, but 
> was already failing before :/
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 117954: Port keditfiletype away from kde4support

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117954/#review58611
---

Ship it!



keditfiletype/mimetypedata.h


comment is wrong, can't be 0 anymore.


- David Faure


On May 23, 2014, 8:45 a.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117954/
> ---
> 
> (Updated May 23, 2014, 8:45 a.m.)
> 
> 
> Review request for Plasma and David Faure.
> 
> 
> Repository: kde-cli-tools
> 
> 
> Description
> ---
> 
> This patch contains multiple commits, which I can make available if needed. 
> It ports keditfiletype away from kde4support, which helps identifying its 
> dependencies so that it can hopefully be moved closer to the classes which 
> need it in frameworks (right now kwidgetsaddons and kio forks it)
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt d62ee8b 
>   keditfiletype/CMakeLists.txt 566e76a 
>   keditfiletype/filegroupdetails.cpp c733ba4 
>   keditfiletype/filetypedetails.h 7c0abb4 
>   keditfiletype/filetypedetails.cpp bfcbb07 
>   keditfiletype/filetypesview.h 82fd0ab 
>   keditfiletype/filetypesview.cpp 886892f 
>   keditfiletype/keditfiletype.h 0b235ce 
>   keditfiletype/keditfiletype.cpp aab0830 
>   keditfiletype/kservicelistwidget.h c817d24 
>   keditfiletype/kservicelistwidget.cpp 88dface 
>   keditfiletype/kserviceselectdlg.h 8e6d0d0 
>   keditfiletype/kserviceselectdlg.cpp 09c7c5d 
>   keditfiletype/mimetypedata.h 042b043 
>   keditfiletype/mimetypedata.cpp 057113f 
>   keditfiletype/mimetypewriter.h 5a618a6 
>   keditfiletype/mimetypewriter.cpp be5e5d4 
>   keditfiletype/newtypedlg.h fba8385 
>   keditfiletype/newtypedlg.cpp c933a8f 
>   keditfiletype/sharedmimeinfoversion.h 9824d7b 
>   keditfiletype/sharedmimeinfoversion.cpp 9dabf0e 
>   keditfiletype/tests/CMakeLists.txt 489bb4d 
>   keditfiletype/tests/filetypestest.cpp 68eef26 
>   keditfiletype/typeslistitem.h 05e425a 
>   keditfiletype/typeslistitem.cpp 97cd3c1 
> 
> Diff: https://git.reviewboard.kde.org/r/117954/diff/
> 
> 
> Testing
> ---
> 
> Program starts and looks like it behaves correctly. Unit-test is failing, but 
> was already failing before :/
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118361: Don't hide Dialog when opening QMenu from it

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118361/#review58613
---


That's frickin' clever! 
We can remove a lot of hacks thanks to this.

Do we even need the last clause? Surely any child window shouldn't close the 
parent?

- David Edmundson


On May 27, 2014, 7:13 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118361/
> ---
> 
> (Updated May 27, 2014, 7:13 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> When plasmoid in a popup is opening a QMenu, the popup itself hides because 
> it looses focus. This patch fixes it.
> 
> 
> Diffs
> -
> 
>   src/plasmaquick/dialog.cpp d8e263c 
> 
> Diff: https://git.reviewboard.kde.org/r/118361/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/
---

(Updated May 27, 2014, 10:38 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas 
Pfeiffer.


Repository: oxygen


Description
---


PM_DefaultLayoutSpacing is deprecated and replaced by both
PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.

Qt Layouts now query for these, not the default spacing.

See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum

There are some other deprecated enums, which are mostly not a problem.


Diffs
-

  kstyle/oxygenstyle.cpp 8bcb79a 

Diff: https://git.reviewboard.kde.org/r/118337/diff/


Testing
---

Spacing between labels and controls is now restored o/


File Attachments


compositing_kcm
  
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/#review58614
---


This review has been submitted with commit 
bec64684e8d3fb621c3c3bcee3dde512fc828f0f by David Edmundson to branch master.

- Commit Hook


On May 27, 2014, 9:42 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118337/
> ---
> 
> (Updated May 27, 2014, 9:42 a.m.)
> 
> 
> Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas 
> Pfeiffer.
> 
> 
> Repository: oxygen
> 
> 
> Description
> ---
> 
> 
> PM_DefaultLayoutSpacing is deprecated and replaced by both
> PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.
> 
> Qt Layouts now query for these, not the default spacing.
> 
> See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum
> 
> There are some other deprecated enums, which are mostly not a problem.
> 
> 
> Diffs
> -
> 
>   kstyle/oxygenstyle.cpp 8bcb79a 
> 
> Diff: https://git.reviewboard.kde.org/r/118337/diff/
> 
> 
> Testing
> ---
> 
> Spacing between labels and controls is now restored o/
> 
> 
> File Attachments
> 
> 
> compositing_kcm
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118337: Adjust to deprecated PM_DefaultLayoutSpacing:

[David Edmundson]

> On May 27, 2014, 4:12 p.m., Andrew Lake wrote:
> > Ship It!
> 
> Andrew Lake wrote:
> In case anyone is wondering why this arbitrary fellow said "Ship It!", I 
> just wanted to provide an explicit thumbs up that this matches the 4px 
> spacing basis grid recommended in the HIG 
> (http://techbase.kde.org/Projects/Usability/HIG/Placement#Space), so yay! We 
> can tackle individual layout designs separately to get the spacing even 
> better.
> 
> Christoph Feck wrote:
> I hope no HIG ever suggest a fixed amount of pixels, but an amount 
> relative to the font size.
> 
> Andrew Lake wrote:
> Till we get a credible resolution-independent approach to laying out all 
> visual elements, including typeface, pixels is probably the best guidance 
> guidance we can come up with.

With Qt 5.4's new high DPI pixels no longer refers to actual pixels. One writes 
code as though the screen will be 96dpi, and Qt scales 4px to 4 or 8 or 16 real 
pixels depending.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118337/#review58586
---


On May 27, 2014, 10:38 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118337/
> ---
> 
> (Updated May 27, 2014, 10:38 p.m.)
> 
> 
> Review request for Plasma, Andrew Lake, Hugo Pereira Da Costa, and Thomas 
> Pfeiffer.
> 
> 
> Repository: oxygen
> 
> 
> Description
> ---
> 
> 
> PM_DefaultLayoutSpacing is deprecated and replaced by both
> PM_LayoutHorizontalSpacing and PM_LayoutVerticalSpacing in Qt5.
> 
> Qt Layouts now query for these, not the default spacing.
> 
> See http://qt-project.org/doc/qt-5/qstyle.html#PixelMetric-enum
> 
> There are some other deprecated enums, which are mostly not a problem.
> 
> 
> Diffs
> -
> 
>   kstyle/oxygenstyle.cpp 8bcb79a 
> 
> Diff: https://git.reviewboard.kde.org/r/118337/diff/
> 
> 
> Testing
> ---
> 
> Spacing between labels and controls is now restored o/
> 
> 
> File Attachments
> 
> 
> compositing_kcm
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/738bd5af-5b0e-45d6-a2f4-907a249dbc77__bustle1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118367: Fix activities data engine by exporting toggleActivityManager method over DBus.

[Bhushan Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118367/
---

Review request for Plasma.


Bugs: 335427
https://bugs.kde.org/show_bug.cgi?id=335427


Repository: plasma-workspace


Description
---

Fix activities data engine by exporting toggleActivityManager method over DBus.


Diffs
-

  dataengines/activities/activityjob.cpp fab23ba 
  shell/dbus/org.kde.PlasmaShell.xml 0b26526 
  shell/shellcorona.h 0d4e462 

Diff: https://git.reviewboard.kde.org/r/118367/diff/


Testing
---

Tested with qdbusviewer, plasmaengineexplorer and Activities applet.


Thanks,

Bhushan Shah

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel