Re: Review Request 118382: [klipper] Fix i18n
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118382/#review58765 --- This review has been submitted with commit 52405190040b6dbf093e44327ed3dac05f9577a4 by Martin Gräßlin to branch master. - Commit Hook On May 28, 2014, 3:22 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118382/ --- (Updated May 28, 2014, 3:22 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Fix i18n Diffs - klipper/CMakeLists.txt 7a57b30b8b59a77c3d0702095dd72bb275d22e57 klipper/main.cpp 153a03160717431eaaa95e77903ab43de9b07fcb Diff: https://git.reviewboard.kde.org/r/118382/diff/ Testing --- I still don't know how to test i18n with kf5 :-) Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118414: [killer] Use dialog-warning icon as window icon for killer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118414/ --- Review request for kwin and Plasma. Repository: kwin Description --- [killer] Use dialog-warning icon as window icon for killer Based on the discussion on kwin [1] and plasma-devel [2] mailing list. [1] http://lists.kde.org/?l=kwinm=140119827404150w=2 [2] https://mail.kde.org/pipermail/plasma-devel/2014-May/031749.html Diffs - killer/killer.cpp 0c3ca043ecf9dcd14813dc8d2c8cca8254e51a25 Diff: https://git.reviewboard.kde.org/r/118414/diff/ Testing --- File Attachments Killer with warning icon https://git.reviewboard.kde.org/media/uploaded/files/2014/05/30/49819e8e-d86c-48e9-8829-c01ba90cad9a__killer-window-warning.png Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118414: [killer] Use dialog-warning icon as window icon for killer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118414/#review58772 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 30, 2014, 6:54 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118414/ --- (Updated May 30, 2014, 6:54 a.m.) Review request for kwin and Plasma. Repository: kwin Description --- [killer] Use dialog-warning icon as window icon for killer Based on the discussion on kwin [1] and plasma-devel [2] mailing list. [1] http://lists.kde.org/?l=kwinm=140119827404150w=2 [2] https://mail.kde.org/pipermail/plasma-devel/2014-May/031749.html Diffs - killer/killer.cpp 0c3ca043ecf9dcd14813dc8d2c8cca8254e51a25 Diff: https://git.reviewboard.kde.org/r/118414/diff/ Testing --- File Attachments Killer with warning icon https://git.reviewboard.kde.org/media/uploaded/files/2014/05/30/49819e8e-d86c-48e9-8829-c01ba90cad9a__killer-window-warning.png Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118417: [klipper] Port from KDebug to QDebug
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118417/ --- Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port from KDebug to QDebug Diffs - klipper/actionstreewidget.cpp 201e32b821f526bc5869aaae6864a5723d2a2572 klipper/configdialog.cpp 808be4e4ea0e42dbb3b9fb11abf4456e16caacdf klipper/editactiondialog.cpp 4719fc5eccf3c28b4d8824b54cbdf62d43805ebf klipper/history.cpp 486e8f77bb71d8e8b22b4dc330e96e080ab5f7c1 klipper/historyimageitem.cpp 6fcb409400e62dd55caf551f229f28ebc68ff52a klipper/historyitem.cpp e9bdec76ef0e12fbfaead90487a7d772cc6fc5f4 klipper/klipper.cpp 8847af324ff0c0c8e07d7e69ca473945cf001772 klipper/klipperpopup.cpp 89d12adba2a3fcfa9cb2e65e52cb54c5f783eb07 klipper/popupproxy.cpp 5d1b0a0d245c56c94a00cb9b191a727e008d4725 klipper/urlgrabber.cpp 54085e8a28fb2836c80900759201f4e936da051b Diff: https://git.reviewboard.kde.org/r/118417/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118417: [klipper] Port from KDebug to QDebug
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118417/#review58779 --- Ship it! Ship It! - Marco Martin On May 30, 2014, 10:22 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118417/ --- (Updated May 30, 2014, 10:22 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port from KDebug to QDebug Diffs - klipper/actionstreewidget.cpp 201e32b821f526bc5869aaae6864a5723d2a2572 klipper/configdialog.cpp 808be4e4ea0e42dbb3b9fb11abf4456e16caacdf klipper/editactiondialog.cpp 4719fc5eccf3c28b4d8824b54cbdf62d43805ebf klipper/history.cpp 486e8f77bb71d8e8b22b4dc330e96e080ab5f7c1 klipper/historyimageitem.cpp 6fcb409400e62dd55caf551f229f28ebc68ff52a klipper/historyitem.cpp e9bdec76ef0e12fbfaead90487a7d772cc6fc5f4 klipper/klipper.cpp 8847af324ff0c0c8e07d7e69ca473945cf001772 klipper/klipperpopup.cpp 89d12adba2a3fcfa9cb2e65e52cb54c5f783eb07 klipper/popupproxy.cpp 5d1b0a0d245c56c94a00cb9b191a727e008d4725 klipper/urlgrabber.cpp 54085e8a28fb2836c80900759201f4e936da051b Diff: https://git.reviewboard.kde.org/r/118417/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118417: [klipper] Port from KDebug to QDebug
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118417/#review58780 --- This review has been submitted with commit a0b58e066ce2f48a8f8a87d275b5fbf3027f0f00 by Martin Gräßlin to branch master. - Commit Hook On May 30, 2014, 10:22 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118417/ --- (Updated May 30, 2014, 10:22 a.m.) Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port from KDebug to QDebug Diffs - klipper/actionstreewidget.cpp 201e32b821f526bc5869aaae6864a5723d2a2572 klipper/configdialog.cpp 808be4e4ea0e42dbb3b9fb11abf4456e16caacdf klipper/editactiondialog.cpp 4719fc5eccf3c28b4d8824b54cbdf62d43805ebf klipper/history.cpp 486e8f77bb71d8e8b22b4dc330e96e080ab5f7c1 klipper/historyimageitem.cpp 6fcb409400e62dd55caf551f229f28ebc68ff52a klipper/historyitem.cpp e9bdec76ef0e12fbfaead90487a7d772cc6fc5f4 klipper/klipper.cpp 8847af324ff0c0c8e07d7e69ca473945cf001772 klipper/klipperpopup.cpp 89d12adba2a3fcfa9cb2e65e52cb54c5f783eb07 klipper/popupproxy.cpp 5d1b0a0d245c56c94a00cb9b191a727e008d4725 klipper/urlgrabber.cpp 54085e8a28fb2836c80900759201f4e936da051b Diff: https://git.reviewboard.kde.org/r/118417/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118417: [klipper] Port from KDebug to QDebug
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118417/ --- (Updated May 30, 2014, 10:29 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port from KDebug to QDebug Diffs - klipper/actionstreewidget.cpp 201e32b821f526bc5869aaae6864a5723d2a2572 klipper/configdialog.cpp 808be4e4ea0e42dbb3b9fb11abf4456e16caacdf klipper/editactiondialog.cpp 4719fc5eccf3c28b4d8824b54cbdf62d43805ebf klipper/history.cpp 486e8f77bb71d8e8b22b4dc330e96e080ab5f7c1 klipper/historyimageitem.cpp 6fcb409400e62dd55caf551f229f28ebc68ff52a klipper/historyitem.cpp e9bdec76ef0e12fbfaead90487a7d772cc6fc5f4 klipper/klipper.cpp 8847af324ff0c0c8e07d7e69ca473945cf001772 klipper/klipperpopup.cpp 89d12adba2a3fcfa9cb2e65e52cb54c5f783eb07 klipper/popupproxy.cpp 5d1b0a0d245c56c94a00cb9b191a727e008d4725 klipper/urlgrabber.cpp 54085e8a28fb2836c80900759201f4e936da051b Diff: https://git.reviewboard.kde.org/r/118417/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118413: Put the settings views in a ScrollView
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118413/#review58778 --- Ship it! desktoppackage/contents/configuration/AppletConfiguration.qml https://git.reviewboard.kde.org/r/118413/#comment40897 is large/2 not just small ? desktoppackage/contents/configuration/AppletConfiguration.qml https://git.reviewboard.kde.org/r/118413/#comment40896 remove this debug info desktoppackage/contents/configuration/AppletConfiguration.qml https://git.reviewboard.kde.org/r/118413/#comment40898 I'm not 100% convinced by this, it means a text label won't wrap as that can have a huge implicitWidth. Lets only make it grow vertically. - David Edmundson On May 30, 2014, 12:41 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118413/ --- (Updated May 30, 2014, 12:41 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- So far, if the page didn't fit the view, it wouldn't react or anything and it would just cut the contents out. With this change it will show scrollbars so it can be reached, if it's needed. Diffs - desktoppackage/contents/configuration/AppletConfiguration.qml ea6010a Diff: https://git.reviewboard.kde.org/r/118413/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118413: Put the settings views in a ScrollView
On May 30, 2014, 10:42 a.m., David Edmundson wrote: desktoppackage/contents/configuration/AppletConfiguration.qml, line 224 https://git.reviewboard.kde.org/r/118413/diff/1/?file=276339#file276339line224 is large/2 not just small ? I have no idea, this was already there though. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118413/#review58778 --- On May 30, 2014, 12:41 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118413/ --- (Updated May 30, 2014, 12:41 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- So far, if the page didn't fit the view, it wouldn't react or anything and it would just cut the contents out. With this change it will show scrollbars so it can be reached, if it's needed. Diffs - desktoppackage/contents/configuration/AppletConfiguration.qml ea6010a Diff: https://git.reviewboard.kde.org/r/118413/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118413: Put the settings views in a ScrollView
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118413/ --- (Updated May 30, 2014, 10:52 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-desktop Description --- So far, if the page didn't fit the view, it wouldn't react or anything and it would just cut the contents out. With this change it will show scrollbars so it can be reached, if it's needed. Diffs - desktoppackage/contents/configuration/AppletConfiguration.qml ea6010a Diff: https://git.reviewboard.kde.org/r/118413/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118413: Put the settings views in a ScrollView
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118413/#review58786 --- This review has been submitted with commit 69c55fbc6dcf1d074f86b775c280ec0b471a1d19 by Aleix Pol to branch master. - Commit Hook On May 30, 2014, 12:41 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118413/ --- (Updated May 30, 2014, 12:41 a.m.) Review request for Plasma. Repository: plasma-desktop Description --- So far, if the page didn't fit the view, it wouldn't react or anything and it would just cut the contents out. With this change it will show scrollbars so it can be reached, if it's needed. Diffs - desktoppackage/contents/configuration/AppletConfiguration.qml ea6010a Diff: https://git.reviewboard.kde.org/r/118413/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118419: Add tooltip to wallpaper thumbnail delegates showing wallpaper name and author when available
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118419/ --- Review request for Plasma and Marco Martin. Repository: plasma-workspace Description --- This adds a QWidget-based tooltip to the wallpaper thumbnail delegate showing its metadata. In the example screenshot this helps identify what the wallpaper shows, and of course to credit the author. A note on the FIXME: The same interval is hardcoded in other places where we use the same approach, like the Button and ToolButton components. Diffs - wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml c139941 wallpapers/image/imagepackage/contents/ui/config.qml 9f1602b Diff: https://git.reviewboard.kde.org/r/118419/diff/ Testing --- File Attachments Example tooltip https://git.reviewboard.kde.org/media/uploaded/files/2014/05/30/f7c261cf-c0ea-4850-ab3b-04ef885627b3__tooltip.png Thanks, Eike Hein ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118419: Add tooltip to wallpaper thumbnail delegates showing wallpaper name and author when available
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118419/#review58795 --- Ship it! Ship It! - Marco Martin On May 30, 2014, 12:01 p.m., Eike Hein wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118419/ --- (Updated May 30, 2014, 12:01 p.m.) Review request for Plasma and Marco Martin. Repository: plasma-workspace Description --- This adds a QWidget-based tooltip to the wallpaper thumbnail delegate showing its metadata. In the example screenshot this helps identify what the wallpaper shows, and of course to credit the author. A note on the FIXME: The same interval is hardcoded in other places where we use the same approach, like the Button and ToolButton components. Diffs - wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml c139941 wallpapers/image/imagepackage/contents/ui/config.qml 9f1602b Diff: https://git.reviewboard.kde.org/r/118419/diff/ Testing --- File Attachments Example tooltip https://git.reviewboard.kde.org/media/uploaded/files/2014/05/30/f7c261cf-c0ea-4850-ab3b-04ef885627b3__tooltip.png Thanks, Eike Hein ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118419: Add tooltip to wallpaper thumbnail delegates showing wallpaper name and author when available
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118419/ --- (Updated May 30, 2014, 12:12 p.m.) Status -- This change has been marked as submitted. Review request for Plasma and Marco Martin. Repository: plasma-workspace Description --- This adds a QWidget-based tooltip to the wallpaper thumbnail delegate showing its metadata. In the example screenshot this helps identify what the wallpaper shows, and of course to credit the author. A note on the FIXME: The same interval is hardcoded in other places where we use the same approach, like the Button and ToolButton components. Diffs - wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml c139941 wallpapers/image/imagepackage/contents/ui/config.qml 9f1602b Diff: https://git.reviewboard.kde.org/r/118419/diff/ Testing --- File Attachments Example tooltip https://git.reviewboard.kde.org/media/uploaded/files/2014/05/30/f7c261cf-c0ea-4850-ab3b-04ef885627b3__tooltip.png Thanks, Eike Hein ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118419: Add tooltip to wallpaper thumbnail delegates showing wallpaper name and author when available
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118419/#review58796 --- This review has been submitted with commit 2363d463b4f2496714fb96f3c7b119dd8c7d151e by Eike Hein to branch master. - Commit Hook On May 30, 2014, 12:01 p.m., Eike Hein wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118419/ --- (Updated May 30, 2014, 12:01 p.m.) Review request for Plasma and Marco Martin. Repository: plasma-workspace Description --- This adds a QWidget-based tooltip to the wallpaper thumbnail delegate showing its metadata. In the example screenshot this helps identify what the wallpaper shows, and of course to credit the author. A note on the FIXME: The same interval is hardcoded in other places where we use the same approach, like the Button and ToolButton components. Diffs - wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml c139941 wallpapers/image/imagepackage/contents/ui/config.qml 9f1602b Diff: https://git.reviewboard.kde.org/r/118419/diff/ Testing --- File Attachments Example tooltip https://git.reviewboard.kde.org/media/uploaded/files/2014/05/30/f7c261cf-c0ea-4850-ab3b-04ef885627b3__tooltip.png Thanks, Eike Hein ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118421: [klipper] Port from KStandardDirs to QStandardPaths
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118421/ --- Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port from KStandardDirs to QStandardPaths Diffs - klipper/klipper.cpp 37fa8240041a63051b4a23df60fd0164e3f96c1e Diff: https://git.reviewboard.kde.org/r/118421/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118421: [klipper] Port from KStandardDirs to QStandardPaths
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118421/#review58798 --- Ship it! Ship It! - Martin Klapetek On May 30, 2014, 2:45 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118421/ --- (Updated May 30, 2014, 2:45 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port from KStandardDirs to QStandardPaths Diffs - klipper/klipper.cpp 37fa8240041a63051b4a23df60fd0164e3f96c1e Diff: https://git.reviewboard.kde.org/r/118421/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118421: [klipper] Port from KStandardDirs to QStandardPaths
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118421/ --- (Updated May 30, 2014, 12:51 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port from KStandardDirs to QStandardPaths Diffs - klipper/klipper.cpp 37fa8240041a63051b4a23df60fd0164e3f96c1e Diff: https://git.reviewboard.kde.org/r/118421/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118357: Disable the agenda part of the calendar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/#review58803 --- Ship it! Ship it since the changes look sane to me. Mind you, i'm not the author of this code. - Mark Gaiser On May 27, 2014, 4 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/ --- (Updated May 27, 2014, 4 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- As agreed on irc (someday ago), the agenda part is useless until there's a proper agenda backend and should just be hidden. Here's a patch simply hiding the left part - it's easier to do just visible: false than comment it out and then comment out/remove all the lines referencing parts of the agenda, also cleaner. I added a big comment at the file beginning, I'll fill the commit sha after committing so it can be easily reverted (the comment will be separate commit). Screenshot attached. Oh and you might want to remove the clock from panel and readd it/remove plasma config as the popup size seems to be saved and so after this patch you may still get the original-sized half-empty dialog. Diffs - applets/digital-clock/package/contents/ui/CalendarView.qml 43812a4 Diff: https://git.reviewboard.kde.org/r/118357/diff/ Testing --- File Attachments Calendar without agenda https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/84880c21-1367-4d48-88db-7747553c40f5__plasma_cal1.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118423: [klipper] Port KMimeType to QMimeType
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/#review58802 --- klipper/urlgrabber.cpp https://git.reviewboard.kde.org/r/118423/#comment40905 we lose fast mode here. I think this means if I drag a 100Gb file from the internet onto klipper it will start downloading it. Not sure how problematic this is. klipper/urlgrabber.cpp https://git.reviewboard.kde.org/r/118423/#comment40906 this comment doesn't seem true, we explicitly check if the mimetype is html klipper/urlgrabber.cpp https://git.reviewboard.kde.org/r/118423/#comment40907 this can definitely be QMimeDatabase::MatchExtension as this file doesn't actually exist, we just want it to match .html to return text/html. The full mimetype match might even fail I /think/ this can also be reduced to db.mimeTypeForName(text/html); which would be easier to read. - David Edmundson On May 30, 2014, 1:02 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/ --- (Updated May 30, 2014, 1:02 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port KMimeType to QMimeType Diffs - klipper/urlgrabber.cpp 4eccb7065ae2932cc548c902ab3a8c50e4972444 Diff: https://git.reviewboard.kde.org/r/118423/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118423: [klipper] Port KMimeType to QMimeType
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/#review58804 --- klipper/urlgrabber.cpp https://git.reviewboard.kde.org/r/118423/#comment40908 Here you might want to pass QMimeDatabase::MatchExtension. - Aleix Pol Gonzalez On May 30, 2014, 1:02 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/ --- (Updated May 30, 2014, 1:02 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port KMimeType to QMimeType Diffs - klipper/urlgrabber.cpp 4eccb7065ae2932cc548c902ab3a8c50e4972444 Diff: https://git.reviewboard.kde.org/r/118423/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118424: [klipper] Port away from KSessionManager
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118424/ --- Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port away from KSessionManager Diffs - klipper/klipper.h 3a204bb764d24c24bfc4d4aae759a52c510b7b33 klipper/klipper.cpp ad2855c6e91d2ef659a6a7f341b060181766d66d Diff: https://git.reviewboard.kde.org/r/118424/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118424: [klipper] Port away from KSessionManager
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118424/#review58805 --- Ship it! Current behaviour is if you have something in your clipboard on closing, it will be there when you restart. Can you confirm this still works before shipping. - David Edmundson On May 30, 2014, 1:18 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118424/ --- (Updated May 30, 2014, 1:18 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port away from KSessionManager Diffs - klipper/klipper.h 3a204bb764d24c24bfc4d4aae759a52c510b7b33 klipper/klipper.cpp ad2855c6e91d2ef659a6a7f341b060181766d66d Diff: https://git.reviewboard.kde.org/r/118424/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118357: Disable the agenda part of the calendar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/#review58808 --- Ship it! Since the visible flag is now static false, let's comment the agenda item code, so we don't waste memory or CPU cycles. Once done, please ship. - Sebastian Kügler On May 27, 2014, 4 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/ --- (Updated May 27, 2014, 4 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- As agreed on irc (someday ago), the agenda part is useless until there's a proper agenda backend and should just be hidden. Here's a patch simply hiding the left part - it's easier to do just visible: false than comment it out and then comment out/remove all the lines referencing parts of the agenda, also cleaner. I added a big comment at the file beginning, I'll fill the commit sha after committing so it can be easily reverted (the comment will be separate commit). Screenshot attached. Oh and you might want to remove the clock from panel and readd it/remove plasma config as the popup size seems to be saved and so after this patch you may still get the original-sized half-empty dialog. Diffs - applets/digital-clock/package/contents/ui/CalendarView.qml 43812a4 Diff: https://git.reviewboard.kde.org/r/118357/diff/ Testing --- File Attachments Calendar without agenda https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/84880c21-1367-4d48-88db-7747553c40f5__plasma_cal1.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118424: [klipper] Port away from KSessionManager
On May 30, 2014, 3:21 p.m., David Edmundson wrote: Current behaviour is if you have something in your clipboard on closing, it will be there when you restart. Can you confirm this still works before shipping. sure, steps done: 1. recompiled and installed klipper 2. stopped running klipper 3. started new klipper 4. added a new entry to klipper 5. verified it's there 6. stoppe klipper 7. started klipper 8. verified it's still there \o/ - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118424/#review58805 --- On May 30, 2014, 3:18 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118424/ --- (Updated May 30, 2014, 3:18 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port away from KSessionManager Diffs - klipper/klipper.h 3a204bb764d24c24bfc4d4aae759a52c510b7b33 klipper/klipper.cpp ad2855c6e91d2ef659a6a7f341b060181766d66d Diff: https://git.reviewboard.kde.org/r/118424/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118424: [klipper] Port away from KSessionManager
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118424/#review58810 --- This review has been submitted with commit 8904a2ee625d482c76cb9903e4e8706504d5ad02 by Martin Gräßlin to branch master. - Commit Hook On May 30, 2014, 1:18 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118424/ --- (Updated May 30, 2014, 1:18 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port away from KSessionManager Diffs - klipper/klipper.h 3a204bb764d24c24bfc4d4aae759a52c510b7b33 klipper/klipper.cpp ad2855c6e91d2ef659a6a7f341b060181766d66d Diff: https://git.reviewboard.kde.org/r/118424/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118424: [klipper] Port away from KSessionManager
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118424/ --- (Updated May 30, 2014, 1:29 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port away from KSessionManager Diffs - klipper/klipper.h 3a204bb764d24c24bfc4d4aae759a52c510b7b33 klipper/klipper.cpp ad2855c6e91d2ef659a6a7f341b060181766d66d Diff: https://git.reviewboard.kde.org/r/118424/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118357: Disable the agenda part of the calendar
On May 30, 2014, 3:27 p.m., Sebastian Kügler wrote: Since the visible flag is now static false, let's comment the agenda item code, so we don't waste memory or CPU cycles. Once done, please ship. I specifically opted out of commenting it as that would mean commenting stuff all around (stuff that references the commented out stuff). If really needed, I can do tho. On the other hand, if this is to make things faster, it will make them slow again in the future -- users will observe performance drop ;) - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/#review58808 --- On May 27, 2014, 6 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/ --- (Updated May 27, 2014, 6 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- As agreed on irc (someday ago), the agenda part is useless until there's a proper agenda backend and should just be hidden. Here's a patch simply hiding the left part - it's easier to do just visible: false than comment it out and then comment out/remove all the lines referencing parts of the agenda, also cleaner. I added a big comment at the file beginning, I'll fill the commit sha after committing so it can be easily reverted (the comment will be separate commit). Screenshot attached. Oh and you might want to remove the clock from panel and readd it/remove plasma config as the popup size seems to be saved and so after this patch you may still get the original-sized half-empty dialog. Diffs - applets/digital-clock/package/contents/ui/CalendarView.qml 43812a4 Diff: https://git.reviewboard.kde.org/r/118357/diff/ Testing --- File Attachments Calendar without agenda https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/84880c21-1367-4d48-88db-7747553c40f5__plasma_cal1.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118423: [klipper] Port KMimeType to QMimeType
On May 30, 2014, 3:15 p.m., David Edmundson wrote: klipper/urlgrabber.cpp, line 147 https://git.reviewboard.kde.org/r/118423/diff/1/?file=276477#file276477line147 this comment doesn't seem true, we explicitly check if the mimetype is html I read this comment different: if clipboard contents starts with http, enforce the mimetype to be html, because that's what's being done in the if - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/#review58802 --- On May 30, 2014, 3:02 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/ --- (Updated May 30, 2014, 3:02 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port KMimeType to QMimeType Diffs - klipper/urlgrabber.cpp 4eccb7065ae2932cc548c902ab3a8c50e4972444 Diff: https://git.reviewboard.kde.org/r/118423/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118423: [klipper] Port KMimeType to QMimeType
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/ --- (Updated May 30, 2014, 3:38 p.m.) Review request for Plasma. Changes --- changed to db.mimeTypeForName(text/html); Repository: plasma-workspace Description --- [klipper] Port KMimeType to QMimeType Diffs (updated) - klipper/urlgrabber.cpp 4eccb7065ae2932cc548c902ab3a8c50e4972444 Diff: https://git.reviewboard.kde.org/r/118423/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118390: Powerdevil KCM Updates
Hey, First, thanks all for the reviews. On Thursday, May 29, 2014 16:10:19 Andrew Lake wrote: On May 29, 2014, 8:13 a.m., Thomas Pfeiffer wrote: Good improvements in general! There are two changes which are not HIG-compliant: - Control labels which are written next to the controls (checkboxes, spin boxes etc.) do not use Title Capitalization. See http://techbase.kde.org/Projects/Usability/HIG/Capitalization for details. Therefore most of the capitalization changes have to be reverted, I'm afraid. - For grouping controls (as in the case of Battery Levels and Events) the HIG recommends using group boxes (see http://techbase.kde.org/Projects/Usability/HIG/GroupBox ) instead of simply spacing Apart from those two things, the changes look fine to me! w - For grouping controls (as in the case of Battery Levels and Events) the HIG recommends using group boxes (see http://techbase.kde.org/Projects/Usability/HIG/GroupBox ) instead of simply spacing Hmm, may be time to update that portion of the HIG since, from a visual design standpoint, spacing can be quite effective at grouping visual elements while avoiding more visual chrome. In this case, for the Advanced page, a bit more spacing between the Battery Levels group and the Events group should provide enough visual distinction between the groups. Also, the checkboxes in the Events group can probably be left-aligned under Events since they're unrelated to the widgets from the Battery Levels group and likely better match the alignment guidelines for making the checkboxes span two columns (http://techbase.kde.org/Projects/Usability/HIG/Alignment). Would be nice to have that changed. I'm not a big fan of these groupboxes, for two reasons: - They add visual clutter, and they're often over-used - They break layouts (kind of the purpose), but aligning the widgets in two groupboxes requires internal layout poking, which sucks on the one hand and usually means that the widgets stay unaligned (Aurelien's hack mentioned in the HIG is really that -- a hack and not available for Qt5 yet). In some cases, groupboxes might be warranted, inside FormLayout, they usually do more harm than good, and there's a semantic grouping mechanism already: The titles. I'll not change to groupboxes in this review, but anticipate the HIG catching up. :) Other changes are coming up, of course. Otherwise, the changes look quite nice to me! Thanks! -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Ship with Aurorae and Qtcurve or not...
On Thursday, May 29, 2014 15:09:33 Marco Martin wrote: On Thursday 15 May 2014 11:39:00 Jens Reuterberg wrote: Ok so after the feedback from the Beta Release an issue that we knew was coming have happened. Visuals being the most easily accessible bit of anything technical, people have reacted negatively to the lack of change. just to give a shot on every and single options, i gave a try to modifying oxygen in order to make it look like breeze (therefore sharing all the things that it does that are not related to painting, like drag the window from anywhere) this is the half done, half missing attempt (ignore the non changed elements) http://wstaw.org/m/2014/05/29/plasma-desktophP1414.png is pretty hacky, but *maybe* is possible to have in the end only a different stylehelper (and pixelmetrics/stylehints) so could be something worth exploring in the future That's pretty neat: I quite like the approach to change Oxygen, since it has a lot of knowledge encoded and is actively maintained. Have we talked with Hugo about ways to adjust Oxygen to Breeze? Cheers, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118390: Powerdevil KCM Updates
On Friday 30 May 2014 15:34:27 Sebastian Kügler wrote: I'll not change to groupboxes in this review, but anticipate the HIG catching up. :) Yes, that's okay. We'll discuss the grouping HIG on our list. If we come out with a different solution to what you implemented in the end, we'll notify you :) Other changes are coming up, of course. Thanks! The capitalization was more important to me anyway, as we'd really like to get that consistent. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118423: [klipper] Port KMimeType to QMimeType
On May 30, 2014, 1:15 p.m., David Edmundson wrote: klipper/urlgrabber.cpp, line 140 https://git.reviewboard.kde.org/r/118423/diff/1/?file=276477#file276477line140 we lose fast mode here. I think this means if I drag a 100Gb file from the internet onto klipper it will start downloading it. Not sure how problematic this is. Martin Gräßlin wrote: given the documentation that should be fine, see http://qt-project.org/doc/qt-5/qmimedatabase.html#mimeTypeForUrl my interpretation of the documentation is that it won't download Yes, it won't download, it will just return a default mimetype, which is actually pretty bad... On May 30, 2014, 1:15 p.m., David Edmundson wrote: klipper/urlgrabber.cpp, line 147 https://git.reviewboard.kde.org/r/118423/diff/1/?file=276477#file276477line147 this comment doesn't seem true, we explicitly check if the mimetype is html Martin Gräßlin wrote: I read this comment different: if clipboard contents starts with http, enforce the mimetype to be html, because that's what's being done in the if Yep, it's just ensuring it's html if it's http. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/#review58802 --- On May 30, 2014, 1:38 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/ --- (Updated May 30, 2014, 1:38 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port KMimeType to QMimeType Diffs - klipper/urlgrabber.cpp 4eccb7065ae2932cc548c902ab3a8c50e4972444 Diff: https://git.reviewboard.kde.org/r/118423/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118357: Disable the agenda part of the calendar
On May 30, 2014, 1:27 p.m., Sebastian Kügler wrote: Since the visible flag is now static false, let's comment the agenda item code, so we don't waste memory or CPU cycles. Once done, please ship. Martin Klapetek wrote: I specifically opted out of commenting it as that would mean commenting stuff all around (stuff that references the commented out stuff). If really needed, I can do tho. On the other hand, if this is to make things faster, it will make them slow again in the future -- users will observe performance drop ;) That's a pretty weak argument. Let's keep rubbish in that isn't used, so when we use it, it's as slow as it's now and nobody will notice that we added stuff and slowed it down, essentially. :D The agenda part should be optional in the code, perhaps show / hide dynamically, based on whether the user wants or as agenda items. These are quite complex bits of UI, the lazy-loading helps, but we should still attempt to make it not load stuff that isn't necessary. So let's do it right. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/#review58808 --- On May 27, 2014, 4 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/ --- (Updated May 27, 2014, 4 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- As agreed on irc (someday ago), the agenda part is useless until there's a proper agenda backend and should just be hidden. Here's a patch simply hiding the left part - it's easier to do just visible: false than comment it out and then comment out/remove all the lines referencing parts of the agenda, also cleaner. I added a big comment at the file beginning, I'll fill the commit sha after committing so it can be easily reverted (the comment will be separate commit). Screenshot attached. Oh and you might want to remove the clock from panel and readd it/remove plasma config as the popup size seems to be saved and so after this patch you may still get the original-sized half-empty dialog. Diffs - applets/digital-clock/package/contents/ui/CalendarView.qml 43812a4 Diff: https://git.reviewboard.kde.org/r/118357/diff/ Testing --- File Attachments Calendar without agenda https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/84880c21-1367-4d48-88db-7747553c40f5__plasma_cal1.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118357: Disable the agenda part of the calendar
On May 30, 2014, 1:27 p.m., Sebastian Kügler wrote: Since the visible flag is now static false, let's comment the agenda item code, so we don't waste memory or CPU cycles. Once done, please ship. Martin Klapetek wrote: I specifically opted out of commenting it as that would mean commenting stuff all around (stuff that references the commented out stuff). If really needed, I can do tho. On the other hand, if this is to make things faster, it will make them slow again in the future -- users will observe performance drop ;) Sebastian Kügler wrote: That's a pretty weak argument. Let's keep rubbish in that isn't used, so when we use it, it's as slow as it's now and nobody will notice that we added stuff and slowed it down, essentially. :D The agenda part should be optional in the code, perhaps show / hide dynamically, based on whether the user wants or as agenda items. These are quite complex bits of UI, the lazy-loading helps, but we should still attempt to make it not load stuff that isn't necessary. So let's do it right. Ah, btw ... commenting stuff all around is not needed: You can just check within the code if references are valid and make it conditional, that's more future-proof as well. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/#review58808 --- On May 27, 2014, 4 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118357/ --- (Updated May 27, 2014, 4 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- As agreed on irc (someday ago), the agenda part is useless until there's a proper agenda backend and should just be hidden. Here's a patch simply hiding the left part - it's easier to do just visible: false than comment it out and then comment out/remove all the lines referencing parts of the agenda, also cleaner. I added a big comment at the file beginning, I'll fill the commit sha after committing so it can be easily reverted (the comment will be separate commit). Screenshot attached. Oh and you might want to remove the clock from panel and readd it/remove plasma config as the popup size seems to be saved and so after this patch you may still get the original-sized half-empty dialog. Diffs - applets/digital-clock/package/contents/ui/CalendarView.qml 43812a4 Diff: https://git.reviewboard.kde.org/r/118357/diff/ Testing --- File Attachments Calendar without agenda https://git.reviewboard.kde.org/media/uploaded/files/2014/05/27/84880c21-1367-4d48-88db-7747553c40f5__plasma_cal1.png Thanks, Martin Klapetek ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118390: Powerdevil KCM Updates
On May 29, 2014, 9:22 a.m., Kai Uwe Broulik wrote: File Attachment: Energy Saving page after - powerdevil-kcm-profiles-after.png https://git.reviewboard.kde.org/r/118390/#fcomment226 Why remove the icons? They make the individual settings recognizable more quickly. I don't think they do, the icons are so small it's hard to decipher. Also, icons in Checkboxes are very unusual. Removing them improves consistency: Let's face it, the bold text and checkboxes were just a bad idea by some developer thinking these checkboxes are somehow special. (That person was me. ;)) On May 29, 2014, 9:22 a.m., Kai Uwe Broulik wrote: File Attachment: Advanced page after - powerdevil-kcm-advanced-after.png https://git.reviewboard.kde.org/r/118390/#fcomment227 Indeed, GroupBoxes should be used here We'll add spacing as an option in the HIG. Groupbox here means alignment headaches over the whole page. On May 29, 2014, 9:22 a.m., Kai Uwe Broulik wrote: File Attachment: Advanced page after - powerdevil-kcm-advanced-after.png https://git.reviewboard.kde.org/r/118390/#fcomment228 That empty space looks weird Not a big issue, correct alignment is more important than a bit of subjectively weird space. On May 29, 2014, 9:22 a.m., Kai Uwe Broulik wrote: daemon/actions/bundled/dimdisplayconfig.cpp, line 62 https://git.reviewboard.kde.org/r/118390/diff/1/?file=275942#file275942line62 That should be come dpi independent Right now, that's irrelevant, since Oxygen and QWidgets aren't DPI-dependent. In the future, the currently proposed solution will take care of this automatically. IOW, it's not an issue right now, likely won't be in the future, it's also not a regression. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58693 --- On May 28, 2014, 11:33 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated May 28, 2014, 11:33 p.m.) Review request for Plasma, Solid and KDE Usability. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - kcmodule/profiles/profileEditPage.ui dc2657943a2bb63f137ad11b77b254b3782f0407 kcmodule/profiles/powerdevilprofilesconfig.desktop e95b908dfea30a4a15ccd8c89d4ceb36256e2185 kcmodule/profiles/EditPage.cpp a674ccbdd76ba682c7b7111f2f9d0b9123ffe8b8 kcmodule/global/powerdevilglobalconfig.desktop 1d4aa2238b2fa02dfa984f9163f133c941ff509e kcmodule/global/generalPage.ui 2ce7cef98e30f872ea9233edc7882deea134fdd3 kcmodule/global/GeneralPage.cpp d025e429df7ca191bf56443b2bd30353a74993a9 kcmodule/common/actioneditwidget.cpp 4c67b4feeb2cff0df2e397f44ffba2926bbb7276 kcmodule/common/actionconfigwidget.cpp 2161c84b68e5fc3b56240a482ed77825ce4a5f03 kcmodule/activities/powerdevilactivitiesconfig.desktop 9ee81b55ec7f4685adb5d102cb21df81f17cf3e3 kcmodule/activities/activitypage.cpp 48e9c6c75f2ab95ce52c96b586475dbb4d6022fd daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273697f11864716dae0204009d52264be99f daemon/actions/bundled/runscriptconfig.cpp c0d3adb6651320702bb6503e505b6ebdc06d6004 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 31772679560a256dcf9f66aefbb4cf02351bd5d3 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd87c06f5dce6d1ff10697837a60cdcc5f29
Re: Review Request 118390: Powerdevil KCM Updates
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated May 30, 2014, 2:19 p.m.) Review request for Plasma, Solid and KDE Usability. Changes --- Addressed comments. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs (updated) - daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e daemon/actions/bundled/dimdisplayconfig.cpp f683935 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 daemon/actions/bundled/runscriptconfig.cpp c0d3adb daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 kcmodule/activities/activitypage.cpp 48e9c6c kcmodule/activities/powerdevilactivitiesconfig.desktop 9ee81b5 kcmodule/common/actionconfigwidget.cpp 2161c84 kcmodule/common/actioneditwidget.cpp 4c67b4f kcmodule/global/GeneralPage.cpp d025e42 kcmodule/global/generalPage.ui 2ce7cef kcmodule/global/powerdevilglobalconfig.desktop 1d4aa22 kcmodule/profiles/EditPage.cpp a674ccb kcmodule/profiles/powerdevilprofilesconfig.desktop e95b908 kcmodule/profiles/profileEditPage.ui dc26579 Diff: https://git.reviewboard.kde.org/r/118390/diff/ Testing --- Tested in kcmshell5 and systemsettings, still fully functional. File Attachments Energy Saving page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png Energy Saving page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png Advanced page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png Advanced page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build became unstable: plasma-workspace_master_qt5 #317
See http://build.kde.org/job/plasma-workspace_master_qt5/317/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build is back to stable : plasma-workspace_master_qt5 #318
See http://build.kde.org/job/plasma-workspace_master_qt5/318/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118417: [klipper] Port from KDebug to QDebug
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118417/#review58827 --- Shouldn't this rather use qCDebug() so that the output can be disabled? - Alexander Richardson On May 30, 2014, 12:29 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118417/ --- (Updated May 30, 2014, 12:29 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- [klipper] Port from KDebug to QDebug Diffs - klipper/actionstreewidget.cpp 201e32b821f526bc5869aaae6864a5723d2a2572 klipper/configdialog.cpp 808be4e4ea0e42dbb3b9fb11abf4456e16caacdf klipper/editactiondialog.cpp 4719fc5eccf3c28b4d8824b54cbdf62d43805ebf klipper/history.cpp 486e8f77bb71d8e8b22b4dc330e96e080ab5f7c1 klipper/historyimageitem.cpp 6fcb409400e62dd55caf551f229f28ebc68ff52a klipper/historyitem.cpp e9bdec76ef0e12fbfaead90487a7d772cc6fc5f4 klipper/klipper.cpp 8847af324ff0c0c8e07d7e69ca473945cf001772 klipper/klipperpopup.cpp 89d12adba2a3fcfa9cb2e65e52cb54c5f783eb07 klipper/popupproxy.cpp 5d1b0a0d245c56c94a00cb9b191a727e008d4725 klipper/urlgrabber.cpp 54085e8a28fb2836c80900759201f4e936da051b Diff: https://git.reviewboard.kde.org/r/118417/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118428: Drop configuration options for taskbar and desktop fonts
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118428/ --- Review request for Plasma. Repository: plasma-desktop Description --- Drop configuration options for taskbar and desktop fonts These weren't being used by plasma so it ended up as a config option to do nothing. Diffs - kcms/fonts/fonts.cpp 9747761 Diff: https://git.reviewboard.kde.org/r/118428/diff/ Testing --- Opened KCM. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118428: Drop configuration options for taskbar and desktop fonts
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118428/#review58830 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 30, 2014, 3:42 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118428/ --- (Updated May 30, 2014, 3:42 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- Drop configuration options for taskbar and desktop fonts These weren't being used by plasma so it ended up as a config option to do nothing. Diffs - kcms/fonts/fonts.cpp 9747761 Diff: https://git.reviewboard.kde.org/r/118428/diff/ Testing --- Opened KCM. Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Ship with Aurorae and Qtcurve or not...
On Fri, May 30, 2014 at 6:44 AM, Sebastian Kügler wrote: On Thursday, May 29, 2014 15:09:33 Marco Martin wrote: just to give a shot on every and single options, i gave a try to modifying oxygen in order to make it look like breeze (therefore sharing all the things that it does that are not related to painting, like drag the window from anywhere) this is the half done, half missing attempt (ignore the non changed elements) http://wstaw.org/m/2014/05/29/plasma-desktophP1414.png is pretty hacky, but *maybe* is possible to have in the end only a different stylehelper (and pixelmetrics/stylehints) so could be something worth exploring in the future That's pretty neat: I quite like the approach to change Oxygen, since it has a lot of knowledge encoded and is actively maintained. Have we talked with Hugo about ways to adjust Oxygen to Breeze? Pretty cool stuff indeed! ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118390: Powerdevil KCM Updates
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58836 --- Looks like there are still quite a few Title Case labels in there. Can you fix them as well? - Thomas Pfeiffer On May 30, 2014, 2:19 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/ --- (Updated May 30, 2014, 2:19 p.m.) Review request for Plasma, Solid and KDE Usability. Repository: powerdevil Description --- This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch. General: - Less icon usage, especially in the form layouts - Title casing throughout - Better HIG compliance (not 100%, but improved) - Energy Saving / Actions UI now scales with dialog - Proper usage of FormLayouts - A bunch of cleanups of dead code - Parenting fixes In Detail: * Improve Advanced Settings page - Use a QFormLayout, and do it properly - Fix up spacing and alignment - Remove icons before titles - Use Title Case for Labels - Shorter labels for better readability * Clean up brightness-OSD-related dead code * Make powerdevil actions layout stretch out horizontally * Compile-time connections in actionconfigwidget * widget and layout parenting fixes * No bold font, increased spacing instead This removes the bold fonts from the checkboxes, as that is non-standard in the HIG. In order to make it look a bit more structured between the sections, a bit of spacing is added. * Remove icons from actions The icons are really small and add more visual noise than being useful. * Streamline Comments of KCMs * Clean up dead code Diffs - daemon/actions/bundled/brightnesscontrolconfig.cpp fea2a3e daemon/actions/bundled/dimdisplayconfig.cpp f683935 daemon/actions/bundled/keyboardbrightnesscontrol.cpp 44dbcd8 daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp 3177267 daemon/actions/bundled/runscriptconfig.cpp c0d3adb daemon/actions/dpms/powerdevildpmsactionconfig.cpp 4d96273 kcmodule/activities/activitypage.cpp 48e9c6c kcmodule/activities/powerdevilactivitiesconfig.desktop 9ee81b5 kcmodule/common/actionconfigwidget.cpp 2161c84 kcmodule/common/actioneditwidget.cpp 4c67b4f kcmodule/global/GeneralPage.cpp d025e42 kcmodule/global/generalPage.ui 2ce7cef kcmodule/global/powerdevilglobalconfig.desktop 1d4aa22 kcmodule/profiles/EditPage.cpp a674ccb kcmodule/profiles/powerdevilprofilesconfig.desktop e95b908 kcmodule/profiles/profileEditPage.ui dc26579 Diff: https://git.reviewboard.kde.org/r/118390/diff/ Testing --- Tested in kcmshell5 and systemsettings, still fully functional. File Attachments Energy Saving page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png Energy Saving page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png Advanced page after https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png Advanced page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118340: Allow the kactivitymanagerd daemon to be disabled.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118340/ --- (Updated May 30, 2014, 11:42 p.m.) Review request for KDE Frameworks, Plasma and Ivan Čukić. Changes --- Change the macro_optional_add_subdirectory to a proper option. This also disables the KCM when the daemon is disabled. Repository: kactivities Description --- To allow for the library to be co-installed with the frameworks version, allow the daemon to be disabled. I'm not sure if this is the best way to do this. If there is any better way, I'll update the patch as appropriate. Diffs (updated) - src/CMakeLists.txt b4733648fd53ebd681694f185cc5b23f51dfd3f9 Diff: https://git.reviewboard.kde.org/r/118340/diff/ Testing --- Visually inspected install directories. Seems to remove only what is necessary. Thanks, Matthew Dawson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
