Re: Review Request 120050: Wallpaper package structure fixes
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/#review67019 --- This causes a regression: normal images can no longer be loaded. Plasmashell outputs No metadata file in the package, expected it at: /path/to/parent/dir/of/wallpaper/metadata.desktop - Luca Beltrame On Set. 19, 2014, 2:28 p.m., Aaron J. Seigo wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/ --- (Updated Set. 19, 2014, 2:28 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This patch set does two things: 1. restore the ability to set the wallpaper to be used to the name of the wallpaper package In the old days this was handled exclusively in setSingleImage, but the QML goes through addUrl wich did not have this feature. Now it does. 2. Move the wallpaper package structure into a plugin so that wallpapers other than Image can use it. It did mean sacrificing the built-in ability to find the prefered image size, which stays behind in Image. This means each plugin using Wallpaper/Images will need to figure out which image to use on their own. This is still better than not having access to the package definition at all, but I imagine other plugins will want similar functionality. A bridge to cross once reached? Diffs - wallpapers/image/wallpaperpackage.cpp 1ee524e34470acdec3e79238b1ba7151584ca858 shell/packageplugins/wallpaper/wallpaper.h shell/packageplugins/wallpaper/wallpaper.cpp shell/packageplugins/wallpaperimages/CMakeLists.txt PRE-CREATION shell/packageplugins/wallpaperimages/plasma-packagestructure-wallpaperimages.desktop PRE-CREATION shell/packageplugins/wallpaperimages/wallpaperpackage.cpp PRE-CREATION shell/scripting/applet.h 082a930637c5ffafab89cf44e875e95fc4996cf5 shell/scripting/applet.cpp 43a8acc053836fd04a640b8ae2f296d8a1e064d5 shell/scripting/containment.cpp fc7fa82b6b9005ef298e18b6d8150cf2f2794351 shell/scripting/scriptengine.cpp f458becb5df33116a6251ba3876aa6e06d16e2bf wallpapers/image/CMakeLists.txt 50d1f1c8849a110a3e2c6a8d76ee96f5b8eb4fea wallpapers/image/backgroundlistmodel.h d5690e6859053c3debeac3ebf53bc0d947c0e8d8 wallpapers/image/backgroundlistmodel.cpp ccb9d103ac2815c613783121d238ef5bd35c5655 wallpapers/image/image.h c517c28d09e3187994db7085b5e9584f2d446b48 wallpapers/image/image.cpp d672dfebcfb6849776aaf3faf4362a19182f7045 wallpapers/image/wallpaperpackage.h 45e8736685ce50cb0b1c21a4ab80734f304ccde2 shell/packageplugins/CMakeLists.txt 16ea8c03fb4a4ec1ee64ca506be5021d6db09d8b shell/packageplugins/wallpaper/CMakeLists.txt shell/packageplugins/wallpaper/plasma-packagestructure-wallpaper.desktop Diff: https://git.reviewboard.kde.org/r/120050/diff/ Testing --- Tested in a full plasmashell desktop session, configuration, etc. All worked as expected. Also tested with a shell package that sets wallpaper data on start, that works now too. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120050: Wallpaper package structure fixes
On Sept. 20, 2014, 6:22 a.m., Luca Beltrame wrote: This causes a regression: normal images can no longer be loaded. Plasmashell outputs No metadata file in the package, expected it at: /path/to/parent/dir/of/wallpaper/metadata.desktop this has been fixed. - Aaron J. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/#review67019 --- On Sept. 19, 2014, 2:28 p.m., Aaron J. Seigo wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/ --- (Updated Sept. 19, 2014, 2:28 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This patch set does two things: 1. restore the ability to set the wallpaper to be used to the name of the wallpaper package In the old days this was handled exclusively in setSingleImage, but the QML goes through addUrl wich did not have this feature. Now it does. 2. Move the wallpaper package structure into a plugin so that wallpapers other than Image can use it. It did mean sacrificing the built-in ability to find the prefered image size, which stays behind in Image. This means each plugin using Wallpaper/Images will need to figure out which image to use on their own. This is still better than not having access to the package definition at all, but I imagine other plugins will want similar functionality. A bridge to cross once reached? Diffs - wallpapers/image/wallpaperpackage.cpp 1ee524e34470acdec3e79238b1ba7151584ca858 shell/packageplugins/wallpaper/wallpaper.h shell/packageplugins/wallpaper/wallpaper.cpp shell/packageplugins/wallpaperimages/CMakeLists.txt PRE-CREATION shell/packageplugins/wallpaperimages/plasma-packagestructure-wallpaperimages.desktop PRE-CREATION shell/packageplugins/wallpaperimages/wallpaperpackage.cpp PRE-CREATION shell/scripting/applet.h 082a930637c5ffafab89cf44e875e95fc4996cf5 shell/scripting/applet.cpp 43a8acc053836fd04a640b8ae2f296d8a1e064d5 shell/scripting/containment.cpp fc7fa82b6b9005ef298e18b6d8150cf2f2794351 shell/scripting/scriptengine.cpp f458becb5df33116a6251ba3876aa6e06d16e2bf wallpapers/image/CMakeLists.txt 50d1f1c8849a110a3e2c6a8d76ee96f5b8eb4fea wallpapers/image/backgroundlistmodel.h d5690e6859053c3debeac3ebf53bc0d947c0e8d8 wallpapers/image/backgroundlistmodel.cpp ccb9d103ac2815c613783121d238ef5bd35c5655 wallpapers/image/image.h c517c28d09e3187994db7085b5e9584f2d446b48 wallpapers/image/image.cpp d672dfebcfb6849776aaf3faf4362a19182f7045 wallpapers/image/wallpaperpackage.h 45e8736685ce50cb0b1c21a4ab80734f304ccde2 shell/packageplugins/CMakeLists.txt 16ea8c03fb4a4ec1ee64ca506be5021d6db09d8b shell/packageplugins/wallpaper/CMakeLists.txt shell/packageplugins/wallpaper/plasma-packagestructure-wallpaper.desktop Diff: https://git.reviewboard.kde.org/r/120050/diff/ Testing --- Tested in a full plasmashell desktop session, configuration, etc. All worked as expected. Also tested with a shell package that sets wallpaper data on start, that works now too. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Jenkins build became unstable: plasma-workspace_master_qt5 #879
See http://build.kde.org/job/plasma-workspace_master_qt5/879/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120298: Enable lastfmimagefetchertest again,
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120298/ --- Review request for Plasma and Shantanu Tushar. Repository: plasma-mediacenter Description --- This enables lastfmimagefetchertest again with error handling Diffs - libs/mediacenter/lastfmimagefetcher.h 25d53fd libs/mediacenter/lastfmimagefetcher.cpp 8d9edf4 libs/test/lastfmimagefetchertest.h f315f7c libs/test/lastfmimagefetchertest.cpp e9ff4f1 Diff: https://git.reviewboard.kde.org/r/120298/diff/ Testing --- Checked without internet, test is getting skipped. Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 119218: Add option to toggle between PerspectiveCrop/Fit while viewing images
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119218/ --- Review request for Plasma, Bhushan Shah, Shantanu Tushar, and Sinny Kumari. Repository: plasma-mediacenter Description --- Double clicking the image adds toggles between PerspectiveCrop/Fit. This feature is particularly useful while viewing landscape images. Diffs - mediaelements/imageviewer/ImageViewer.qml 81f9cc6a9268040e657216d1dee2e00abf76b4fa Diff: https://git.reviewboard.kde.org/r/119218/diff/ Testing --- Open new image, double click -- toggles. double click again -- toggles again. Thanks, R.Harish Navnit ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review67074 --- dataengines/comic/CMakeLists.txt https://git.reviewboard.kde.org/r/120276/#comment46806 Why this is commented out? - Bhushan Shah On Sept. 20, 2014, 12:47 a.m., Andrei Amuraritei wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Sept. 20, 2014, 12:47 a.m.) Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/comic/plasma-packagestructure-comic.desktop 67f96c0 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 dataengines/comic/plasma-dataengine-comic.desktop f9e5433 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120298: Enable lastfmimagefetchertest again,
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120298/ --- (Updated Sept. 20, 2014, 8:34 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- This enables lastfmimagefetchertest again with error handling Diffs - libs/mediacenter/lastfmimagefetcher.h 25d53fd libs/mediacenter/lastfmimagefetcher.cpp 8d9edf4 libs/test/lastfmimagefetchertest.h f315f7c libs/test/lastfmimagefetchertest.cpp e9ff4f1 Diff: https://git.reviewboard.kde.org/r/120298/diff/ Testing --- Checked without internet, test is getting skipped. Thanks, Bhushan Shah ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120276: Initial port to frameworks for the comic dataengine.
On Sept. 20, 2014, 4 p.m., Bhushan Shah wrote: dataengines/comic/CMakeLists.txt, line 82 https://git.reviewboard.kde.org/r/120276/diff/2/?file=313487#file313487line82 Why this is commented out? The file does not exist anymore; It had only the EXPORT macro in it anyway and i advised to move it to the .cpp and remove that file. This line should just be removed. - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review67074 --- On Sept. 19, 2014, 9:17 p.m., Andrei Amuraritei wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/ --- (Updated Sept. 19, 2014, 9:17 p.m.) Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler. Repository: kdeplasma-addons Description --- comic DataEngine initial port to frameworks. Diffs - dataengines/comic/plasma-packagestructure-comic.desktop 67f96c0 dataengines/comic/comic_package.cpp 6d2ff0b dataengines/comic/comicprovider.h 630ee8d dataengines/comic/comicprovider.cpp ab248a5 dataengines/comic/comicproviderkross.h 46a9072 dataengines/comic/comicproviderkross.cpp 9820f05 dataengines/comic/comicproviderwrapper.h 81eee68 dataengines/comic/comicproviderwrapper.cpp 48ced42 dataengines/comic/plasma-dataengine-comic.desktop f9e5433 dataengines/comic/CMakeLists.txt 8e382e6 dataengines/comic/cachedprovider.cpp caca25e dataengines/comic/comic.h 8cc3969 dataengines/comic/comic.cpp 7130f44 dataengines/comic/comic_package.h 32be381 Diff: https://git.reviewboard.kde.org/r/120276/diff/ Testing --- Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages. This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts. Thanks notmart, d_ed, sebas, bshas etc for helping. Thanks, Andrei Amuraritei ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Announcing KWayland library
On Friday 19 of September 2014 11:06:56 Martin Gräßlin wrote: Hi plasma-devs, as discussed on Monday's hangout I split out KWin's Wayland handling code into a dedicated repository and library: git clone kde:kwayland The repository provides two libraries: * Client * Server At the moment Server doesn't get installed, but is used for the auto-tests of the Client library. Reporting now here, as there doesn't seem to be a bugzilla product yet. Seems the Server library uses Wayland API (wl_shm_buffer_begin_access and wl_shm_buffer_end_access) added after 1.3 release, but minimal version per CMakeLists is officially 1.2. Cheers, Hrvoje Cheers Martin [1]: https://git.reviewboard.kde.org/r/120279 signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120050: Wallpaper package structure fixes
On set. 20, 2014, 6:22 a.m., Luca Beltrame wrote: This causes a regression: normal images can no longer be loaded. Plasmashell outputs No metadata file in the package, expected it at: /path/to/parent/dir/of/wallpaper/metadata.desktop Aaron J. Seigo wrote: this has been fixed. Sounds like it should be unit tested. - Aleix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/#review67019 --- On set. 19, 2014, 2:28 p.m., Aaron J. Seigo wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/ --- (Updated set. 19, 2014, 2:28 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This patch set does two things: 1. restore the ability to set the wallpaper to be used to the name of the wallpaper package In the old days this was handled exclusively in setSingleImage, but the QML goes through addUrl wich did not have this feature. Now it does. 2. Move the wallpaper package structure into a plugin so that wallpapers other than Image can use it. It did mean sacrificing the built-in ability to find the prefered image size, which stays behind in Image. This means each plugin using Wallpaper/Images will need to figure out which image to use on their own. This is still better than not having access to the package definition at all, but I imagine other plugins will want similar functionality. A bridge to cross once reached? Diffs - wallpapers/image/wallpaperpackage.cpp 1ee524e34470acdec3e79238b1ba7151584ca858 shell/packageplugins/wallpaper/wallpaper.h shell/packageplugins/wallpaper/wallpaper.cpp shell/packageplugins/wallpaperimages/CMakeLists.txt PRE-CREATION shell/packageplugins/wallpaperimages/plasma-packagestructure-wallpaperimages.desktop PRE-CREATION shell/packageplugins/wallpaperimages/wallpaperpackage.cpp PRE-CREATION shell/scripting/applet.h 082a930637c5ffafab89cf44e875e95fc4996cf5 shell/scripting/applet.cpp 43a8acc053836fd04a640b8ae2f296d8a1e064d5 shell/scripting/containment.cpp fc7fa82b6b9005ef298e18b6d8150cf2f2794351 shell/scripting/scriptengine.cpp f458becb5df33116a6251ba3876aa6e06d16e2bf wallpapers/image/CMakeLists.txt 50d1f1c8849a110a3e2c6a8d76ee96f5b8eb4fea wallpapers/image/backgroundlistmodel.h d5690e6859053c3debeac3ebf53bc0d947c0e8d8 wallpapers/image/backgroundlistmodel.cpp ccb9d103ac2815c613783121d238ef5bd35c5655 wallpapers/image/image.h c517c28d09e3187994db7085b5e9584f2d446b48 wallpapers/image/image.cpp d672dfebcfb6849776aaf3faf4362a19182f7045 wallpapers/image/wallpaperpackage.h 45e8736685ce50cb0b1c21a4ab80734f304ccde2 shell/packageplugins/CMakeLists.txt 16ea8c03fb4a4ec1ee64ca506be5021d6db09d8b shell/packageplugins/wallpaper/CMakeLists.txt shell/packageplugins/wallpaper/plasma-packagestructure-wallpaper.desktop Diff: https://git.reviewboard.kde.org/r/120050/diff/ Testing --- Tested in a full plasmashell desktop session, configuration, etc. All worked as expected. Also tested with a shell package that sets wallpaper data on start, that works now too. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120279: Port to KWayland client library
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/#review67091 --- Modules/base/info_wayland.cpp https://git.reviewboard.kde.org/r/120279/#comment46828 Why we need a new connection? QPA already has one. - Pier Luigi Fiorini On Sept. 19, 2014, 10:49 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/ --- (Updated Sept. 19, 2014, 10:49 a.m.) Review request for Plasma. Repository: kinfocenter Description --- By using the KWayland library we don't need to interact with the low level C-library. Diffs - CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 Diff: https://git.reviewboard.kde.org/r/120279/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120279: Port to KWayland client library
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/#review67092 --- Modules/base/info_wayland.cpp https://git.reviewboard.kde.org/r/120279/#comment46830 need a space after comma, before registry Modules/base/info_wayland.cpp https://git.reviewboard.kde.org/r/120279/#comment46829 name is used - Pier Luigi Fiorini On Sept. 19, 2014, 10:49 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120279/ --- (Updated Sept. 19, 2014, 10:49 a.m.) Review request for Plasma. Repository: kinfocenter Description --- By using the KWayland library we don't need to interact with the low level C-library. Diffs - CMakeLists.txt 9a89864d56772725dbd976efe507d8e2f6d62ea6 Modules/base/CMakeLists.txt e84a1dc25924e48f07f160a3b0c8b4346809f8f9 Modules/base/info_linux.cpp a4304160dfb4d3b2101a41025d81f0c8cf64ff11 Modules/base/info_wayland.h 80bf2a28098515301db6a6c58c6f3700ff117d93 Modules/base/info_wayland.cpp 2d70fb8d1fec423d7edd1218df83313f524e3d70 Modules/info/CMakeLists.txt 79b40102bb46db9a7b839e8a89aef89d567d1cd6 Modules/pci/CMakeLists.txt 64b9cbf363fa2cbcf25f52ab6063c45c3165e5d7 Diff: https://git.reviewboard.kde.org/r/120279/diff/ Testing --- Thanks, Martin Gräßlin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120050: Wallpaper package structure fixes
On Sept. 20, 2014, 6:22 a.m., Luca Beltrame wrote: This causes a regression: normal images can no longer be loaded. Plasmashell outputs No metadata file in the package, expected it at: /path/to/parent/dir/of/wallpaper/metadata.desktop Aaron J. Seigo wrote: this has been fixed. Aleix Pol Gonzalez wrote: Sounds like it should be unit tested. It would benefit from unit testing, but even more so from integration testing. Some of the functionality relies on screen resolution to be deterministic, but I'm sure that can be creatively worked around. The real challenge is in the integration testing. With the current design the Package classes are in libplasma, the QML interfaces are in libplasmaquick, the configuration glue is partly in the image plugin and partly in plasmashell, finding the preferred image file is partly in the wallpaper package and partly in the image plugin, some of the image wallpaper logic is in QML some is in C++ in the image plugin ... these breakages are more from integration points than unit functionality. There is also room for refactoring which could clean up some of the integration points which in turn would make testing a bit more straightforward. - Aaron J. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/#review67019 --- On Sept. 19, 2014, 2:28 p.m., Aaron J. Seigo wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120050/ --- (Updated Sept. 19, 2014, 2:28 p.m.) Review request for Plasma. Repository: plasma-workspace Description --- This patch set does two things: 1. restore the ability to set the wallpaper to be used to the name of the wallpaper package In the old days this was handled exclusively in setSingleImage, but the QML goes through addUrl wich did not have this feature. Now it does. 2. Move the wallpaper package structure into a plugin so that wallpapers other than Image can use it. It did mean sacrificing the built-in ability to find the prefered image size, which stays behind in Image. This means each plugin using Wallpaper/Images will need to figure out which image to use on their own. This is still better than not having access to the package definition at all, but I imagine other plugins will want similar functionality. A bridge to cross once reached? Diffs - wallpapers/image/wallpaperpackage.cpp 1ee524e34470acdec3e79238b1ba7151584ca858 shell/packageplugins/wallpaper/wallpaper.h shell/packageplugins/wallpaper/wallpaper.cpp shell/packageplugins/wallpaperimages/CMakeLists.txt PRE-CREATION shell/packageplugins/wallpaperimages/plasma-packagestructure-wallpaperimages.desktop PRE-CREATION shell/packageplugins/wallpaperimages/wallpaperpackage.cpp PRE-CREATION shell/scripting/applet.h 082a930637c5ffafab89cf44e875e95fc4996cf5 shell/scripting/applet.cpp 43a8acc053836fd04a640b8ae2f296d8a1e064d5 shell/scripting/containment.cpp fc7fa82b6b9005ef298e18b6d8150cf2f2794351 shell/scripting/scriptengine.cpp f458becb5df33116a6251ba3876aa6e06d16e2bf wallpapers/image/CMakeLists.txt 50d1f1c8849a110a3e2c6a8d76ee96f5b8eb4fea wallpapers/image/backgroundlistmodel.h d5690e6859053c3debeac3ebf53bc0d947c0e8d8 wallpapers/image/backgroundlistmodel.cpp ccb9d103ac2815c613783121d238ef5bd35c5655 wallpapers/image/image.h c517c28d09e3187994db7085b5e9584f2d446b48 wallpapers/image/image.cpp d672dfebcfb6849776aaf3faf4362a19182f7045 wallpapers/image/wallpaperpackage.h 45e8736685ce50cb0b1c21a4ab80734f304ccde2 shell/packageplugins/CMakeLists.txt 16ea8c03fb4a4ec1ee64ca506be5021d6db09d8b shell/packageplugins/wallpaper/CMakeLists.txt shell/packageplugins/wallpaper/plasma-packagestructure-wallpaper.desktop Diff: https://git.reviewboard.kde.org/r/120050/diff/ Testing --- Tested in a full plasmashell desktop session, configuration, etc. All worked as expected. Also tested with a shell package that sets wallpaper data on start, that works now too. Thanks, Aaron J. Seigo ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
